Dave Airlie writes:
> On Thu, 16 Jul 2020 at 00:59, Thomas Zimmermann wrote:
> >
> > This patchset puts device initialization in the correct order and
> > adds support for G200 Desktop chips (PCI ids 0x520 and 0x521).
>
> why? :-)
>
> I'm pretty sure I NAKed the previous version because
Takashi Iwai writes:
> On Thu, 20 Jul 2017 06:17:58 +0200,
> Dave Airlie wrote:
> >
> > On 19 July 2017 at 00:43, Takashi Iwai <ti...@suse.de> wrote:
> > > From: Egbert Eich <e...@suse.de>
> > >
> > > Add two more models G2
Just as a reminder, the nomination period for the X.Org Foundation
Board of Directors election ends on
Monday, Feb 16 2015, 23:59 UTC (12:59 PM UTC).
If you would like to nominate yourself, please send email to
elections at x.org.
Please note that to be a candidate in this election your have
The X.Org Foundation is holding elections for
- The Board of Directors
- Adoption of changes to the By Laws.
Election Schedule
=
Q Session for the
By Law changes start:Jan 26
Nomination period Start: Jan 26 00:00 UTC
Nomination period End: Feb 15 23:59 UTC
}
> ast->vga2_clone = false;
> } else {
> -ast->chip = 2000;
> +ast->chip = AST2000;
> DRM_INFO("AST 2000 detected\n");
> }
> }
> --
> 1.8.3.1
>
Reviewed-by: Egbert Eich
> {
> struct ast_private *ast = dev->dev_private;
> uint32_t data, jreg;
> +ast_open_key(ast);
>
> if (dev->pdev->device == PCI_CHIP_AST1180) {
> ast->chip = AST1100;
> --
> 1.8.3.1
>
Reviewed-by: Egbert Eich
:
> From: "Y.C. Chen"
>
> Signed-off-by: Egbert Eich
> Signed-off-by: Y.C. Chen
>
> v2: Add two pass mode selection, first try to match sync polarities and
> refresh
> if this fails, try matching refresh only. Suggested by: Egbert Eich
>
Hi YC,
Y.C. Chen writes:
> From: "Y.C. Chen"
>
> Signed-off-by: Y.C. Chen
> ---
> drivers/gpu/drm/ast/ast_mode.c | 32 +++---
> drivers/gpu/drm/ast/ast_tables.h | 42
>
> 2 files changed, 50 insertions(+), 24
Hi YC,
Y.C. Chen writes:
> From: "Y.C. Chen"
>
> Signed-off-by: Y.C. Chen
> ---
> drivers/gpu/drm/ast/ast_mode.c | 32 +++---
> drivers/gpu/drm/ast/ast_tables.h | 42
>
> 2 files changed, 50 insertions(+), 24
/* 19:
> VCLK97_75*/
> };
>
> static struct ast_vbios_stdtable vbios_stdtable[] = {
> --
> 1.8.3.1
>
Reviewed-by: Egbert Eich
Just noticed two other things:
On Tue, Aug 19, 2014 at 05:10:51PM +0800, Y.C. Chen wrote:
> --- a/drivers/gpu/drm/ast/ast_tables.h
> +++ b/drivers/gpu/drm/ast/ast_tables.h
> @@ -72,6 +72,7 @@
> static struct ast_vbios_dclk_info dclk_table[] = {
> {0x2C, 0xE7, 0x03},
On Tue, Aug 19, 2014 at 05:10:51PM +0800, Y.C. Chen wrote:
> From: "Y.C. Chen"
>
> ---
> drivers/gpu/drm/ast/ast_mode.c | 27 +-
> drivers/gpu/drm/ast/ast_tables.h | 42
> ++--
> 2 files changed, 41 insertions(+), 28 deletions(-)
>
Jiri Kosina writes:
> On Mon, 21 Oct 2013, Egbert Eich wrote:
>
> > > On Thu, 3 Oct 2013, Daniel Vetter wrote:
> > >
> > > > Can you please attach full dmesg from boot up to the first WARN with
> > > > drm.debug=0xe? This really shouldn'
Hi Jiri,
Just found your email, it got missed do to a temporary inaccessibility to
my email.
Jiri Kosina writes:
> On Thu, 3 Oct 2013, Daniel Vetter wrote:
>
> > Can you please attach full dmesg from boot up to the first WARN with
> > drm.debug=0xe? This really shouldn't happen and
Hi Dave,
Dave Airlie writes:
> On Wed, Jul 17, 2013 at 11:07 PM, Egbert Eich wrote:
> > This set of patches contains several fixes and enhancements for the
> > MGAG200 KMS driver.
>
> Hi Egbert,
>
> I've pushed some of these into a branch in my repo, mga
Add missing 'return 0;'.
v2: Simplified patch as suggested by Dave Airlie
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c
b/drivers/gpu/drm/mgag200/mgag200_ttm.c
index 6461fd2
Add missing 'return 0;'.
v2: Simplified patch as suggested by Dave Airlie airl...@redhat.com
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c
b/drivers/gpu/drm/mgag200
Hi Dave,
Dave Airlie writes:
On Wed, Jul 17, 2013 at 11:07 PM, Egbert Eich e...@suse.com wrote:
This set of patches contains several fixes and enhancements for the
MGAG200 KMS driver.
Hi Egbert,
I've pushed some of these into a branch in my repo, mgag200-queue,
I'll try
Chris Wilson writes:
> On Wed, Jul 17, 2013 at 03:07:17PM +0200, Egbert Eich wrote:
> > drm_gem_handle_create() should not have referenced an object when it's
> > creation has failed for some reason.
> >
> > Signed-off-by: Egbert Eich
>
> Nak. The unrefe
ual() called from ttm_bo_handle_move_mem() will take
care of this.
v2: Don't call ttm_bo_unmap_virtual() in mgag200_bo_pin(), fix comment.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c
This code was ported from the xorg mga driver.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 0bb0e1e
Matrox hardware only supports modes whose horizontal parameters are
multiples of 8. This rules out a mode like 1366x768 for example.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/mgag200
Since there are only 32 (64) distinct color values for each color
in 16bpp Matrox hardware expects those in a 'dense' manner, ie in
the first 32 (64) entries of the respective color.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 23 +++
1 file
From: Takashi Iwai <ti...@suse.com>
The framebuffer pitch calculation needs to be done differently for bpp == 24
- check xf86-video-mga for reference.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 2fe1f64..020a623 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers
Due to a missing initialization there was no way to map fbdev memory.
Thus for example using the Xserver with the fbdev driver failed.
This fix adds initialization for fix.smem_start and fix.smem_len
in the fb_info structure, which fixes this problem.
Signed-off-by: Egbert Eich
---
drivers/gpu
of this BO. When user space accesses this memory again we
will receive a page fault and are able to set up the page tables to
point to the correct physical memory.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 251784a..2fe1f64 100644
--- a/drivers/gpu/drm/mgag200
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c
b/drivers/gpu/drm/mgag200/mgag200_ttm.c
index 2606031..3a2e5e2 100644
--- a/drivers/gpu/drm/mgag200/mgag200_ttm.c
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c
b/drivers/gpu/drm/mgag200/mgag200_main.c
index d51096c..fe8ed66 100644
--- a/drivers/gpu/drm/mgag200/mgag200_main.c
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c
b/drivers/gpu/drm/mgag200/mgag200_ttm.c
index 6461fd2..2606031 100644
--- a/drivers/gpu/drm
The fb id string was used in an error message right before it was set.
Reversing the order of the code fixes this.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_fb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c
b
drm_gem_handle_create() should not have referenced an object when it's
creation has failed for some reason.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c
b
Technically freeing mga_fb->base is the same as freeing mga_fb as 'base'
the first member of the data structure.
Still this makes it cleaner.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/
The allocated struct mgag200_bo was not freed in all error paths.
This patch consolidates error handling and fixes this.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mgag200
Some mmemory allocated in mgag200fb_create() was not properly
freed before the function returned with an error.
This patch takes care of this.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_fb.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff
This set of patches contains several fixes and enhancements for the
MGAG200 KMS driver.
Egbert Eich (15):
drm/mgag200: Fix memleaks in error path in mgag200_fb_create()
drm/mgag200: Fix memleak in error path in mgag200_bo_create()
drm/mgag200: Free container instead of member
This set of patches contains several fixes and enhancements for the
MGAG200 KMS driver.
Egbert Eich (15):
drm/mgag200: Fix memleaks in error path in mgag200_fb_create()
drm/mgag200: Fix memleak in error path in mgag200_bo_create()
drm/mgag200: Free container instead of member
Some mmemory allocated in mgag200fb_create() was not properly
freed before the function returned with an error.
This patch takes care of this.
Signed-off-by: Egbert Eich e...@suse.de
---
drivers/gpu/drm/mgag200/mgag200_fb.c | 21 -
1 file changed, 16 insertions(+), 5
From: Takashi Iwai ti...@suse.com
The framebuffer pitch calculation needs to be done differently for bpp == 24
- check xf86-video-mga for reference.
Signed-off-by: Egbert Eich e...@suse.de
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Due to a missing initialization there was no way to map fbdev memory.
Thus for example using the Xserver with the fbdev driver failed.
This fix adds initialization for fix.smem_start and fix.smem_len
in the fb_info structure, which fixes this problem.
Signed-off-by: Egbert Eich e...@suse.de
Technically freeing mga_fb-base is the same as freeing mga_fb as 'base'
the first member of the data structure.
Still this makes it cleaner.
Signed-off-by: Egbert Eich e...@suse.de
---
drivers/gpu/drm/mgag200/mgag200_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 251784a..2fe1f64 100644
--- a/drivers/gpu/drm/mgag200
The allocated struct mgag200_bo was not freed in all error paths.
This patch consolidates error handling and fixes this.
Signed-off-by: Egbert Eich e...@suse.de
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu
Signed-off-by: Egbert Eich e...@suse.de
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c
b/drivers/gpu/drm/mgag200/mgag200_ttm.c
index 6461fd2..2606031 100644
--- a/drivers
Signed-off-by: Egbert Eich e...@suse.de
---
drivers/gpu/drm/mgag200/mgag200_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c
b/drivers/gpu/drm/mgag200/mgag200_main.c
index d51096c..fe8ed66 100644
--- a/drivers/gpu/drm/mgag200
Since there are only 32 (64) distinct color values for each color
in 16bpp Matrox hardware expects those in a 'dense' manner, ie in
the first 32 (64) entries of the respective color.
Signed-off-by: Egbert Eich e...@suse.de
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 23
drm_gem_handle_create() should not have referenced an object when it's
creation has failed for some reason.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/mgag200/mgag200_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mgag200
of this BO. When user space accesses this memory again we
will receive a page fault and are able to set up the page tables to
point to the correct physical memory.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
Signed-off-by: Egbert Eich e...@suse.de
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_ttm.c
b/drivers/gpu/drm/mgag200/mgag200_ttm.c
index 2606031..3a2e5e2 100644
--- a/drivers/gpu/drm/mgag200
This code was ported from the xorg mga driver.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/mgag200/mgag200_mode.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index
() called from ttm_bo_handle_move_mem() will take
care of this.
v2: Don't call ttm_bo_unmap_virtual() in mgag200_bo_pin(), fix comment.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mgag200
Chris Wilson writes:
On Wed, Jul 17, 2013 at 03:07:17PM +0200, Egbert Eich wrote:
drm_gem_handle_create() should not have referenced an object when it's
creation has failed for some reason.
Signed-off-by: Egbert Eich e...@suse.com
Nak. The unreference here is to free
debugging is enabled.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index e8d17ee..2dc1a60 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm
debugging is enabled.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/drm_edid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index e8d17ee..2dc1a60 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers
Ville Syrj?l? writes:
> On Thu, Nov 22, 2012 at 07:28:44PM +0100, Egbert Eich wrote:
> >
> > Something similar should be done for drm_edid_is_valid() - even if the
> > driver doesn't bother (for instance because this function is only called
> > once
Ville Syrj?l? writes:
> >
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index dd0df60..aa9b34d 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -157,6 +157,17 @@ int drm_edid_header_is_valid(const u8 *raw_edid)
> > }
>
drm_edid_is_valid() to return the actual error
state.
Included results of extension block checking in the
overall error state.
Removed drm_edid_block_valid() as there is noone
using it.
v5: Added missing radeon/radeon_combios.c.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c
Ville Syrj?l? writes:
> On Thu, Nov 22, 2012 at 05:23:03AM -0500, Egbert Eich wrote:
> >
> > - /* if there's no extensions, we're done */
> > + /* if there are no extensions, we're done - don't bother caching */
> >if (block[EDID_EXTENSION_FLAG_OFFSET] =
Ville Syrj?l? writes:
>
> Me neither. I just figured it might reduce the chance of false
> positives. But if you say that can't happen, I'll take your word
> for it.
>
> > Regarding memcmp() you are definitely right, I will change the code.
> >
> > >
> > > Also the comment is
v2: Adjusted to apply cleanly.
Signed-off-by: Egbert Eich
---
include/drm/drm_crtc.h |8
include/drm/drm_edid.h |9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 7a3ccbf..7eed9bd 100644
.
Included results of extension block checking in the
overall error state.
Removed drm_edid_block_valid() as there is noone
using it.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 136
drivers/gpu/drm/radeon
Ville Syrj?l? writes:
> On Thu, Nov 22, 2012 at 05:22:55AM -0500, Egbert Eich wrote:
> > There are displays which announce EDID extension blocks in the
> > Extension Flag of the EDID base block although they are not EDDC
> > capable (ie. take a segment address at I
the monitor is changed
but still prevents permanent EDID errors from piling up
the the kernel logs.
v2: Fixed conflits due to reordering of commits.
Set error state where missing.
v3: Don't update cache when returning block from cache.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c
when reading a 'firmware'-supplied EDID or on error.
V3: Uncache when only one extension block is found. This chunk had
accidentally gone into the next patch of the series. Found by
Ville Syrj?l? .
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_crtc.c |1 +
drivers/gpu/drm
? :
Reworded comment,
Used memcmp(),
Compared entire base block instead of signature only.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index
Signed-off-by: Egbert Eich
---
include/drm/drm_crtc.h |8
include/drm/drm_edid.h |9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index d402b3b..7eed9bd 100644
--- a/include/drm/drm_crtc.h
+++ b/include
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/mgag200/mgag200_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index d3d99a2..f89a0c1 100644
--- a/drivers/gpu/drm/mgag200
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/gma500/cdv_intel_dp.c|1 +
drivers/gpu/drm/gma500/oaktrail_lvds.c |1 +
drivers/gpu/drm/gma500/psb_intel_modes.c |1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c
b/drivers
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/ast/ast_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 7fc9f72..c27aa8d 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast
the monitor is changed
but still prevents permanent EDID errors from piling up
the the kernel logs.
v2: Fixed conflits due to reordering of commits.
Set error state where missing.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 115 +---
drivers/gpu
when reading a 'firmware'-supplied EDID or on error.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_crtc.c |1 +
drivers/gpu/drm/drm_edid.c | 57 +--
include/drm/drm_crtc.h |1 +
include/drm/drm_edid.h |1 +
4 files changed, 52
-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 64 +++
drivers/gpu/drm/drm_edid_load.c | 54 +++-
include/drm/drm_edid.h |1 +
3 files changed, 71 insertions(+), 48 deletions(-)
diff --git a/drivers/gpu/drm
the different connector
sections.
The option now looks like this:
edid_firmware="[:][;:]..."
v2: Check for edidname != NULL before entering loop.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid_load.c | 45 ++
1 files changed, 31 inserti
for detecting the presence of a device thru
EDID). Also it does so not on the helper level any more, the possibility for
EDID loading now happens on the DRM KMS core level.
v2: Fixed formatting and conflicts due to reordering of commits.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_crtc_helper.c
.
v2: a. Also adapt Kconfig
b. Add missing 'select FW_LOADER'
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/Kconfig |3 ++-
drivers/gpu/drm/Makefile |2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 18321b68b
as
this is less time consuming. For v1.3 we scrap any exsisting map
blocks and recreate them from scratch.
v2: Fixed conflits due to reordering of commits.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 89
1 files changed, 89 insertions(+), 0
urn the same
block.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index da2f7fa..0fe61fb 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/
EDID extension blogs are only expected for EDIDs version 1.3 or higher.
If an EDID with a lower version is found fix the block count in the
extension flags and return the base block.
This should help to avoid issues with older displays with broken
DDC implementations.
Signed-off-by: Egbert Eich
address is not taken into account, this block will
be identical to the base block in which case we stop reading further
EEDID blocks, correct the extension flag and just return the base
block.
v2: Split up EDID fixup code into separate commit.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c
When we fail to allocate space for EDID extensions we should just
warn, fix up the EDID block count and return the base block instead
of failing.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
If I2C readout fails for an extension block but we have read a
valid base block, don't fail completely but at least return the
base block.
v2: Make goto target names more telling.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |7 +--
1 files changed, 5 insertions(+), 2
v2: Use offsetof().
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 049fa52..9e64069 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b
This patch is a bit cosmetic as the variable size will truncate
the start address anyway but for readability it should be made
explicite that the lowest bit in the EDID block number determines
the I2C start address.
Signed-off-by: Egbert Eich
---
drivers/gpu/drm/drm_edid.c |2 +-
1 files
The patches have been reordered and the changes suggested by
Takashi Iwai have been worked in.
Egbert Eich (18):
1. Make error handling of EDID extension blocks a bit more fault
tolorant:
* Don't fail when EDID extension blocks cannot be read or memory
cannot be allocated.
* Don't
The patches have been reordered and the changes suggested by
Takashi Iwai have been worked in.
Egbert Eich (18):
1. Make error handling of EDID extension blocks a bit more fault
tolorant:
* Don't fail when EDID extension blocks cannot be read or memory
cannot be allocated.
* Don't
When we fail to allocate space for EDID extensions we should just
warn, fix up the EDID block count and return the base block instead
of failing.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/drm_edid.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git
address is not taken into account, this block will
be identical to the base block in which case we stop reading further
EEDID blocks, correct the extension flag and just return the base
block.
v2: Split up EDID fixup code into separate commit.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu
as
this is less time consuming. For v1.3 we scrap any exsisting map
blocks and recreate them from scratch.
v2: Fixed conflits due to reordering of commits.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/drm_edid.c | 89
1 files changed, 89
the same
block.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/drm_edid.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index da2f7fa..0fe61fb 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/ast/ast_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 7fc9f72..c27aa8d 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu
the monitor is changed
but still prevents permanent EDID errors from piling up
the the kernel logs.
v2: Fixed conflits due to reordering of commits.
Set error state where missing.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/drm_edid.c | 115
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/mgag200/mgag200_mode.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c
b/drivers/gpu/drm/mgag200/mgag200_mode.c
index d3d99a2..f89a0c1 100644
--- a/drivers/gpu/drm/mgag200
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/gma500/cdv_intel_dp.c|1 +
drivers/gpu/drm/gma500/oaktrail_lvds.c |1 +
drivers/gpu/drm/gma500/psb_intel_modes.c |1 +
3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/gma500
.
v2: a. Also adapt Kconfig
b. Add missing 'select FW_LOADER'
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/Kconfig |3 ++-
drivers/gpu/drm/Makefile |2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
v2: Use offsetof().
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/drm_edid.c | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 049fa52..9e64069 100644
--- a/drivers/gpu/drm
when reading a 'firmware'-supplied EDID or on error.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/drm_crtc.c |1 +
drivers/gpu/drm/drm_edid.c | 57 +--
include/drm/drm_crtc.h |1 +
include/drm/drm_edid.h |1 +
4 files
the different connector
sections.
The option now looks like this:
edid_firmware=[connector_0:]edid_file_0[;connector_n:edid_file_1]...
v2: Check for edidname != NULL before entering loop.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/drm_edid_load.c | 45
Signed-off-by: Egbert Eich e...@suse.com
---
include/drm/drm_crtc.h |8
include/drm/drm_edid.h |9 +
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index d402b3b..7eed9bd 100644
--- a/include/drm/drm_crtc.h
This patch is a bit cosmetic as the variable size will truncate
the start address anyway but for readability it should be made
explicite that the lowest bit in the EDID block number determines
the I2C start address.
Signed-off-by: Egbert Eich e...@suse.com
---
drivers/gpu/drm/drm_edid.c |2
1 - 100 of 185 matches
Mail list logo
