Dear Sylwester Nawrocki.
Sorry. I didn't check your third patch. I understand the "mux", "parent"
meaning. please ignore my comment of "mux", "parent"
and please check below comments.
Thank's
BR
Eunchul Kim.
On 04/17/2013 02:31 AM, Sylwester Nawrocki wr
Dear Sylwester Nawrocki
Thank you for your update. I have some question of your patch.
please give your information to me.
Thank's
BR
Eunchul Kim.
On 04/17/2013 06:53 PM, Sylwester Nawrocki wrote:
> The clocks handling is refactored and a "mux" clock handling is
> added to acc
Dear Sylwester Nawrocki
Thank you for your update. I have some question of your patch.
please give your information to me.
Thank's
BR
Eunchul Kim.
On 04/17/2013 06:53 PM, Sylwester Nawrocki wrote:
The clocks handling is refactored and a mux clock handling is
added to account for changes
Dear Sylwester Nawrocki.
Sorry. I didn't check your third patch. I understand the mux, parent
meaning. please ignore my comment of mux, parent
and please check below comments.
Thank's
BR
Eunchul Kim.
On 04/17/2013 02:31 AM, Sylwester Nawrocki wrote:
This patch adds OF initialization
This patch removes needless parenthesis.
This was pointed out but in case of fimc side. we missed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b
s stop at s/w reset
to avoid incorrect interrupt.
Signed-off-by: Jinyoung Jeon
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/
driver.
Signed-off-by: JoongMock Shin
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index 8cfc5a9..a99ceef
This patch cleanup corrects some comments to abbreviation.
We would like to prevent it stands misunderstood.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2
This patch fixes erroneous register read.
reall function needs register base address + offset but
exynos_drm_gsc module used only offset to read a register.
so this patch uses gsc_read function instead of readl.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
1
This patch considers both case of vflip and hflip.
If we want that the contents in buffer to be rotated to 180 degree,
then we can use h,vflip or 180 degree.
Changelog v2:
- added EXYNOS_DRM_FLIP_BOTH enum value to avoid build warnning.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos
This patch removes property error handling. because property couldn't be NULL.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12
drivers/gpu/drm/exynos/exynos_drm_ipp.c |5 -
3
This patch change current command name from cmd to c_node.
because we are using the member name, 'cmd', for command control ioctl in
another structure.
so, this patch changes it to c_node to avoid such confusing.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|8
.
* correct some comments to abbreviation : we change comments for right grammar.
* remove needless parenthesis : we misse changing of fimc side. so, I added it.
* remove color bar pattern operation : we don't use color display at
writeback. so, remove it.
Thank's
BR
Eunchul Kim
Eunchul Kim (6
Dear Sean Paul.
Thank's for your comment.
I am in charge of Display Part in Samsung TN.
and I also use exynos drm and I contributed some part to dri-devel(e.g
IPPs).
Your comment is very helpful to me.
I answer to your comment. please check my answer.
Thank's
BR
Eunchul Kim
On 12/22/2012 04
Thank's for your advice.
Your opinion is very helpful to me.
I will consider your comments, and then I resend it.
Thank's
BR
Eunchul Kim
On 12/21/2012 08:53 PM, Alan Cox wrote:
> On Fri, 21 Dec 2012 18:47:57 +0900
> Eunchul Kim wrote:
>
>> HDCP stands for High-bandwidth
This patch removes property error handling. because property couldn't be NULL.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12
drivers/gpu/drm/exynos
.
* correct some comments to abbreviation : we change comments for right grammar.
* remove needless parenthesis : we misse changing of fimc side. so, I added it.
* remove color bar pattern operation : we don't use color display at
writeback. so, remove it.
Thank's
BR
Eunchul Kim
Eunchul Kim (6
This patch change current command name from cmd to c_node.
because we are using the member name, 'cmd', for command control ioctl in
another structure.
so, this patch changes it to c_node to avoid such confusing.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos
This patch considers both case of vflip and hflip.
If we want that the contents in buffer to be rotated to 180 degree,
then we can use h,vflip or 180 degree.
Changelog v2:
- added EXYNOS_DRM_FLIP_BOTH enum value to avoid build warnning.
Signed-off-by: Eunchul Kim chulspro@samsung.com
This patch fixes erroneous register read.
reall function needs register base address + offset but
exynos_drm_gsc module used only offset to read a register.
so this patch uses gsc_read function instead of readl.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos
This patch cleanup corrects some comments to abbreviation.
We would like to prevent it stands misunderstood.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos
.
Signed-off-by: JoongMock Shin jmock.s...@samsung.com
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos
at s/w reset
to avoid incorrect interrupt.
Signed-off-by: Jinyoung Jeon jy0.j...@samsung.com
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos
This patch removes needless parenthesis.
This was pointed out but in case of fimc side. we missed it.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos
.
- compare Ri,Rj. If same and not repeater, then start encryption.
- If not same, retry. If repeater, then start second authentication.
- stop encryption.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu
Eunchul Kim
Eunchul Kim (1):
drm/exynos: added hdcp driver for contents protection.
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 12 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu
This patch cleanup needless parenthesis. we got the comment from GSC.
but we missed fimc side. so, we cleanup the code.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos
g Jeon
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index a99ceef..9f52b7f 100644
--- a/drivers/gpu/drm/
From: JoongMock Shin <jmock.s...@samsung.com>
This patch removed color bar pattern register. we not use color bar
any more. and don't support color bar at writeback operation.
Signed-off-by: JoongMock Shin
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c
This patch cleanup comment of abbreviation.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
This patch fixed warnning in GSC build.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
index 3e5b456..410175a
in this case. so, fixed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|1 +
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_rotator.c |1 +
include/uapi/drm/exynos_drm.h |2 ++
4 files changed, 5
This patch removed property error handling. property couldn't be NULL.
so, I removed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12
drivers/gpu/drm/exynos/exynos_drm_ipp.c |5
This patch changed current command name from cmd to c_node.
because we already use cmd for command control ioctl in another structure.
so, this name make some confusion.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|8
drivers/gpu/drm/exynos
for right grammar.
* cleanup needless parenthesis : we missed changing of fimc side. so, I added
it.
* removed color bar pattern display : we don't use color display at writeback.
so, removed it.
Thank's
BR
Eunchul Kim
Eunchul Kim (6):
drm/exynos: cleanup current command name.
drm/exynos: removed
Eunchul Kim
Eunchul Kim (1):
drm/exynos: added hdcp driver for contents protection.
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 12 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu
.
- compare Ri,Rj. If same and not repeater, then start encryption.
- If not same, retry. If repeater, then start second authentication.
- stop encryption.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile
Thank's for your advice.
Your opinion is very helpful to me.
I will consider your comments, and then I resend it.
Thank's
BR
Eunchul Kim
On 12/21/2012 08:53 PM, Alan Cox wrote:
On Fri, 21 Dec 2012 18:47:57 +0900
Eunchul Kim chulspro@samsung.com wrote:
HDCP stands for High-bandwidth
Thank's for comment.
Oops, sorry that is my fault.
I will resend it.
BR
Eunchul Kim
On 12/20/2012 06:48 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Thursday, December 20, 2012
This patch cleanup needless parenthesis. we got the comment from GSC.
but we missed fimc side. so, we cleanup the code.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos
g Jeon
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index 67e1b88..c9eaa81 100644
--- a/drivers/gpu/drm/
From: JoongMock Shin <jmock.s...@samsung.com>
This patch removed color bar pattern register. we not use color bar
any more. and don't support color bar at writeback operation.
Signed-off-by: JoongMock Shin
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c
This patch cleanup comment of abbreviation.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
This patch fixed warnning in GSC build.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
index ba5fefd..4546833
This patch fixed vflip, hflip at the same time. If we want to change 180 degree
about buffer,
then we can use h,vflip or 180 degree. we supports 180 degree using h,vflip.
but we make error handling in this case. so, fixed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos
This patch removed property error handling. property couldn't be NULL.
so, I removed it.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12
drivers/gpu/drm/exynos/exynos_drm_ipp.c |5
This patch changed current command name from cmd to c_node.
because we already use cmd for command control ioctl in another structure.
so, this name make some confusion.
Signed-off-by: Eunchul Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|8
drivers/gpu/drm/exynos
NULL.
* cleanup comment of abbreviation : we changed comments for right grammar.
* cleanup needless parenthesis : we missed changing of fimc side. so, I added
it.
* removed color bar pattern display : we don't use color display at writeback.
so, removed it.
Thank's
BR
Eunchul Kim
Eunchul Kim
This patch changed current command name from cmd to c_node.
because we already use cmd for command control ioctl in another structure.
so, this name make some confusion.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|8
drivers
This patch removed property error handling. property couldn't be NULL.
so, I removed it.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12
drivers/gpu/drm/exynos
This patch fixed vflip, hflip at the same time. If we want to change 180 degree
about buffer,
then we can use h,vflip or 180 degree. we supports 180 degree using h,vflip.
but we make error handling in this case. so, fixed it.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu
This patch fixed warnning in GSC build.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
This patch cleanup comment of abbreviation.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +-
3 files changed, 3 insertions(+), 3
From: JoongMock Shin jmock.s...@samsung.com
This patch removed color bar pattern register. we not use color bar
any more. and don't support color bar at writeback operation.
Signed-off-by: JoongMock Shin jmock.s...@samsung.com
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu
...@samsung.com
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index 67e1b88
This patch cleanup needless parenthesis. we got the comment from GSC.
but we missed fimc side. so, we cleanup the code.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Thank's for comment.
Oops, sorry that is my fault.
I will resend it.
BR
Eunchul Kim
On 12/20/2012 06:48 PM, Inki Dae wrote:
-Original Message-
From: Eunchul Kim [mailto:chulspro@samsung.com]
Sent: Thursday, December 20, 2012 6:32 PM
To: dri-devel@lists.freedesktop.org; inki
for right grammar.
* cleanup needless parenthesis : we missed changing of fimc side. so, I added
it.
* removed color bar pattern display : we don't use color display at writeback.
so, removed it.
Thank's
BR
Eunchul Kim
Eunchul Kim (6):
drm/exynos: cleanup current command name.
drm/exynos: removed
This patch changed current command name from cmd to c_node.
because we already use cmd for command control ioctl in another structure.
so, this name make some confusion.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|8
drivers
This patch fixed warnning in GSC build.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
This patch cleanup comment of abbreviation.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +-
3 files changed, 3 insertions(+), 3
This patch removed property error handling. property couldn't be NULL.
so, I removed it.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12
drivers/gpu/drm/exynos
From: JoongMock Shin jmock.s...@samsung.com
This patch removed color bar pattern register. we not use color bar
any more. and don't support color bar at writeback operation.
Signed-off-by: JoongMock Shin jmock.s...@samsung.com
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu
...@samsung.com
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index a99ceef
in this case. so, fixed it.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|1 +
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 +-
drivers/gpu/drm/exynos/exynos_drm_rotator.c |1 +
include/uapi/drm/exynos_drm.h |2 ++
4
This patch cleanup needless parenthesis. we got the comment from GSC.
but we missed fimc side. so, we cleanup the code.
Signed-off-by: Eunchul Kim chulspro@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
Mixer.
Changelog v5
- Changed return type
- Define hard coding value
- Changed to devm_ function
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |5 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
and display output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1
This patch adds iommu support for ipp.
For this, it adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu
driver for each hardware.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 24 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |7 +
drivers/gpu
= exynos_drm_ipp_queue_buf(fd, [i],
EXYNOS_DRM_OPS_DST,
IPP_BUF_DEQUEUE,
property.prop_id, i, gem2[i].handle);
if (ret < 0)
fprintf(stderr, "failed to ipp buf dst dequeue\n");
}
/* Sto
Thank's for your comment.
please check my answer.
BR
Eunchul Kim
On 12/13/2012 11:29 AM, Joonyoung Shim wrote:
> Hi,
>
> I can't review about logic of driver because i don't know well but i
> feel there are too many checking codes and unused or big size defines.
- I think error h
This patch adds iommu support for ipp.
For this, it adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim chulspro@samsung.com
Signed-off-by: Jinyoung
);
}
/* Stop */
ret = exynos_drm_ipp_cmd_ctrl(fd, cmd_ctrl, property.prop_id,
IPP_CTRL_STOP);
if (ret)
fprintf(stderr, failed to ipp ctrl IPP_CMD_WB stop\n);
return;
}
Eunchul Kim (5):
drm/exynos: add ipp subsystem
drm/exynos: add iommu support for ipp
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim chulspro@samsung.com
Signed
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |5 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
and display output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1
This patch adds iommu support for ipp.
For this, it adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu
driver for each hardware.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 24 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |7 +
drivers/gpu
For destination buffer dequeue to IPP */
for (i = 0; i < MAX_BUF; i++) {
ret = exynos_drm_ipp_queue_buf(fd, [i],
EXYNOS_DRM_OPS_DST,
IPP_BUF_DEQUEUE,
property.prop_id, i, gem2[i].handle);
if (ret < 0)
fpr
Thank's for your comment.
BR
Eunchul Kim.
On 12/12/2012 06:46 PM, Inki Dae wrote:
>
> One more comment.
>
>
>> -Original Message-
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Wednesday, December 12, 2012 6:26 PM
&g
Thank's your comment
BR
Eunchul Kim
On 12/12/2012 07:39 PM, Inki Dae wrote:
>
>
>> -Original Message-
>> From: Inki Dae [mailto:inki.dae at samsung.com]
>> Sent: Wednesday, December 12, 2012 7:01 PM
>> To: 'Inki Dae'; 'Eunchul Kim'
>> Cc:
Thank's your comment.
I answer your comment. please check that.
Thank's
BR
Eunchul Kim
On 12/12/2012 05:29 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Wednesday, December 12, 2012
Thank's your comment.
I anwer your comment, please check that.
Thank's
BR
Eunchul Kim.
On 12/12/2012 05:18 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Wednesday, December 12, 2012
output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |5 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1 +
drivers/gpu/drm
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim
Signed-off-by: Youngjun Cho
and display output operations.
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu/drm/exynos/Kconfig |6 +
drivers/gpu/drm/exynos/Makefile |1 +
drivers/gpu/drm/exynos/exynos_drm_drv.c | 15 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |1
This patch adds iommu support for ipp.
For this, it adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim
Signed-off-by: Jinyoung Jeon
---
drivers/gpu
gem2[i].handle);
if (ret < 0)
fprintf(stderr, "failed to ipp buf dst dequeue\n");
}
/* Stop */
ret = exynos_drm_ipp_cmd_ctrl(fd, _ctrl, property.prop_id,
IPP_CTRL_STOP);
if (ret)
fprintf(stderr, &
Thank's your comment.
I answer your comment. please check that.
Thank's
BR
Eunchul Kim
On 12/12/2012 05:29 PM, Inki Dae wrote:
-Original Message-
From: Eunchul Kim [mailto:chulspro@samsung.com]
Sent: Wednesday, December 12, 2012 4:35 PM
To: dri-devel@lists.freedesktop.org
Thank's for your comment.
BR
Eunchul Kim.
On 12/12/2012 06:46 PM, Inki Dae wrote:
One more comment.
-Original Message-
From: Eunchul Kim [mailto:chulspro@samsung.com]
Sent: Wednesday, December 12, 2012 6:26 PM
To: Inki Dae
Cc: dri-devel@lists.freedesktop.org; jy0.j
)
fprintf(stderr, failed to ipp buf dst dequeue\n);
}
/* Stop */
ret = exynos_drm_ipp_cmd_ctrl(fd, cmd_ctrl, property.prop_id,
IPP_CTRL_STOP);
if (ret)
fprintf(stderr, failed to ipp ctrl IPP_CMD_WB stop\n);
return;
}
Eunchul
This patch adds iommu support for ipp.
For this, it adds subdrv_probe/remove callback to enable or disable ipp iommu.
we can get or put device address to a gem handle from user
through exynos_drm_gem_get/put_dma_addr().
Signed-off-by: Eunchul Kim chulspro@samsung.com
Signed-off-by: Jinyoung
Rotator supports rotation/crop/flip and input/output DMA operations
Rotator ipp driver supports 90,180,270 degree rotaion and vertical, horizontal
flip.
and has some limitations(source and destination format have to be same, no
scaler)
Signed-off-by: Eunchul Kim chulspro@samsung.com
Signed
OK, I know what you mean.
I talk about GSC feature with Inki.Dae.
I will re-send our final source instead of first commit.
please one more time review about next RFC v3.
Thank's
BR
Eunchul Kim
On 12/11/2012 05:31 PM, Joonyoung Shim wrote:
> Hi,
>
> I want to see only just curr
Thank's for comments.
I answer your comment, please check that.
Thank's
BR
Eunchul Kim.
On 12/11/2012 04:17 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Tuesday, December 11, 2012 2:55 PM
&g
Thank's your comments
I answer your comments. please check that.
Thank's
BR
Eunchul Kim
On 12/11/2012 02:49 PM, Joonyoung Shim wrote:
> Hi,
>
> On 12/10/2012 10:45 PM, Eunchul Kim wrote:
>> GSC is stand for General SCaler and supports supports
>> image scaler/rotator/cr
Thank's your comments.
I answer your comments. please check that.
Thank's
BR
Eunchul Kim
On 12/11/2012 02:16 PM, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Eunchul Kim [mailto:chulspro.kim at samsung.com]
>> Sent: Monday, December 10, 2012 1
1 - 100 of 145 matches
Mail list logo
