RE: [PATCH 09/38] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()'

Hi Lee Thank you for the patch BR Fabien ST Restricted > -Original Message- > From: Lee Jones > Sent: jeudi 20 mai 2021 14:02 > To: lee.jo...@linaro.org > Cc: linux-ker...@vger.kernel.org; Benjamin Gaignard > ; David Airlie ; Daniel Vetter > ; Philipp Zabel ; Fa

RE: [PATCH 07/38] drm/sti/sti_hda: Provide missing function names

Hi Lee Thank you for the patch BR Fabien ST Restricted > -Original Message- > From: Lee Jones > Sent: jeudi 20 mai 2021 14:02 > To: lee.jo...@linaro.org > Cc: linux-ker...@vger.kernel.org; Benjamin Gaignard > ; David Airlie ; Daniel Vetter > ; Fabien

Re: [PATCH 2/4] media: bdisp: fix memleak on release

rn value of the v4l2 release file operation is > ignored. > > Fixes: 28ffeebbb7bd ("[media] bdisp: 2D blitter driver using v4l2 mem2mem > framework") > Cc: stable # 4.2 > Cc: Fabien Dessenne > Cc: Hans Verkuil > Cc: Mauro Carvalho Chehab > Signe

[PATCH 0/2] drm/stm: ltdc: manage error cases in probe

This patchset adds some check of the returned error code in probe. Fabien Dessenne (2): drm/stm: ltdc: manage the get_irq probe defer case drm/stm: ltdc: return appropriate error code during probe drivers/gpu/drm/stm/ltdc.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

[PATCH 1/2] drm/stm: ltdc: manage the get_irq probe defer case

Manage the -EPROBE_DEFER error case for the ltdc IRQ. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/stm/ltdc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 566b0d8..521ba83 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b

[PATCH 2/2] drm/stm: ltdc: return appropriate error code during probe

During probe, return the "clk_get" error value instead of -ENODEV. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/stm/ltdc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 521ba83..97912e2 10

[PATCH 2/3] drm/sti: Fix up crtc_state->event handling

Use drm-core to handle event. This is required to be able to use the nonblocking helpers. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_crtc.c | 46 + drivers/gpu/drm/sti/sti_mixer.h | 2 -- 2 files changed, 14 insertions(+), 34 deletions

[PATCH 3/3] drm/sti: do not check hw scaling if mode is not set

Fix a division by 0 case : in some cases, when the HQVDP plane is being disabled atomic_check() is called with "mode->clock = 0". In that case, do not check for scaling capabilities. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_hqvdp.c | 6 +++--- 1 file changed,

[PATCH 1/3] drm/sti: use atomic_helper for commit

Since nonblocking atomic commits are now supported, the driver can now use drm_atomic_helper_commit(). Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_drv.c | 83 +-- drivers/gpu/drm/sti/sti_drv.h | 6 2 files changed, 1 insertion(+), 88

[PATCH 0/3] Use nonblocking atomic helpers

This series replaces the driver customized atomic_commit implementation with the drm core helpers (patch 1). The vblank event management is reworked (patch 2) and a side-effect is fixed (patch 3). Fabien ___ dri-devel mailing list dri-devel@lists.freed

[PATCH 0/5] drm/sti: do not sync legacy IOCTL on vblank if not ATOMIC

03, 2017 at 05:56:47PM +0100, Fabien Dessenne wrote: >> These patches allow a legacy framework (eg non-atomic Weston) to call >> several SETPLANE within the same Vsync cycle. >> - [PATCH 1/5] drm/sti: use atomic_helper for commit >> - [PATCH 2/5] drm/sti: add drm_file to sti

[PATCH 5/5] drm/sti: do not check hw scaling if mode is not set

Fix a division by 0 case : in some cases, when the HQVDP plane is being disabled atomic_check() is called with "mode->clock = 0". In that case, do not check for scaling capabilities. Change-Id: I7fb752ab394211c3deafa149f52cfb2bca244e84 Signed-off-by: Fabien Dessenne --- driver

[PATCH 4/5] drm/sti: do not sync SETPROPERTY on vblank if not ATOMIC

legacy_cursor_update flag, to behave the same way as DRM_IOCTL_MODE_CURSOR (not vblank synced). Change-Id: I6b6134eca57eca399bdda006ab1cb8280d4002d4 Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_cursor.c | 2 +- drivers/gpu/drm/sti/sti_gdp.c| 2 +- drivers/gpu/drm/sti/sti_hqvdp.c | 2

[PATCH 3/5] drm/sti: do not sync SETPLANE on vblank if not ATOMIC

, to behave the same way as DRM_IOCTL_MODE_CURSOR (not vblank synced). Change-Id: Ia241b6c88411c675bf589c17d4a44db6d02f669f Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_cursor.c | 4 +- drivers/gpu/drm/sti/sti_gdp.c| 4 +- drivers/gpu/drm/sti/sti_hqvdp.c | 4 +- drivers/gpu

[PATCH 2/5] drm/sti: add drm_file to sti_private

Store the drm_file *filp in sti_private, so the driver can access more configuration information like the client capabilities. Change-Id: Ib8f305f1a41b4fdfe56f80294cd79e5dc44433ee Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_drv.c | 10 ++ drivers/gpu/drm/sti/sti_drv.h

[PATCH 1/5] drm/sti: use atomic_helper for commit

Since nonblocking atomic commits are now supported, the driver can now use drm_atomic_helper_commit(). Change-Id: I3e49872b0dc9e79ca652bec7e5cd29d912c86382 Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_drv.c | 83 +-- drivers/gpu/drm/sti

[PATCH 0/5] drm/sti: do not sync legacy IOCTL on vblank if not ATOMIC

These patches allow a legacy framework (eg non-atomic Weston) to call several SETPLANE within the same Vsync cycle. - [PATCH 1/5] drm/sti: use atomic_helper for commit - [PATCH 2/5] drm/sti: add drm_file to sti_private - [PATCH 3/5] drm/sti: do not sync SETPLANE on vblank if not ATOMIC - [PATCH 4/5

[PATCH 2/2] drm/sti: do not post HQVDP command if no update

(non-atomic) IOCTL : in that case atomic_update() is called multiple times with the same parameters. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_hqvdp.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti

[PATCH 1/2] drm/sti: load XP70 firmware only once

When a plane is enabled, after having been disabled, do not reload XP70 firmware again, but only register VTG again Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_hqvdp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b

[PATCH 0/2] drm/sti: HQVDP plane improvements

These patches fix HQVDP plane performance issues - [PATCH 1/2] drm/sti: load XP70 firmware only once - [PATCH 2/2] drm/sti: do not post HQVDP command if no update Fabien

[PATCH 8/8] drm/sti: use valid video mode

In atomic mode the crtc_xxx (eg crtc_hdisplay) members of the mode structure may be unset before calling atomic_check/commit for planes. Instead of, use xxx members which are actually set. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_gdp.c | 8 drivers/gpu/drm/sti

[PATCH 7/8] drm/sti: in crtc_atomic_flush, enable only planes of this crtc

crtc_atomic_flush performs some additional processing, like plane enable at mixer level. Enable only the planes attached to the CRTC. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_crtc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/sti/sti_crtc.c b

[PATCH 6/8] drm/sti: use vtg array instead of vtg_main/aux

This is more generic and more consistent with the other members of the sti_compositor struct. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_compositor.c | 4 ++-- drivers/gpu/drm/sti/sti_compositor.h | 6 ++ drivers/gpu/drm/sti/sti_crtc.c | 12 +--- drivers/gpu

[PATCH 5/8] drm/sti: use different notifier_block for each pipe

Each pipe shall have its own notifier block to manage the vblank event. This fixes issues where a client registered on given pipe is later abusively notified of events on the other pipe. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_compositor.c | 4 +++- drivers/gpu/drm/sti

[PATCH 4/8] drm/sti: fix atomic_disable check

When a drm_plane is being disabled, its ->crtc member is set to NULL before the .atomic_disable() func is called. To get the crtc of the plane, read old_state->crtc instead of drm_plane->crtc Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_cursor.c | 6 +++--- drivers/gp

[PATCH 3/8] drm/sti: run gdp init sequence only once

Do not rely on plane->status to define whether this is the first update but rather check for gdp->vtg. This avoids multiple and unwanted calls to sti_vtg_register_client() which breaks the kernel scheduler. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_gdp.c | 4 ++--

[PATCH 2/8] drm/sti: run hqvdp init sequence only once

Do not rely on plane->status to define whether this is the first update but rather check for hqvdp->xp70_initialized bit status. This avoids multiple and unwanted calls to sti_vtg_register_client() which breaks the kernel scheduler. Signed-off-by: Fabien Dessenne --- drivers/gpu/d

[PATCH 1/8] drm/sti: fix debug logs

Add some missing \n in logs. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/sti/sti_gdp.c | 2 +- drivers/gpu/drm/sti/sti_hda.c | 4 ++-- drivers/gpu/drm/sti/sti_hdmi.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm

[PATCH 0/8] drm/sti: atomic bug fixes

This serie provides with bug fixes found while testing drm/sti with an atomic version of weston [PATCH 1/8] drm/sti: fix debug logs [PATCH 2/8] drm/sti: run hqvdp init sequence only once [PATCH 3/8] drm/sti: run gdp init sequence only once [PATCH 4/8] drm/sti: fix atomic_disable check [PATCH 5/8]

[PATCH] drm: Set depth and bpp for XRGB4444 family formats

on to get this fixed? Fabien On 08/10/2016 05:26 PM, Fabien DESSENNE wrote: > > On 08/10/2016 04:12 PM, Daniel Vetter wrote: >> On Wed, Aug 10, 2016 at 01:04:54PM +0200, Fabien DESSENNE wrote: >>> On 08/10/2016 12:35 PM, Daniel Vetter wrote: >>>> On Wed, Aug 10, 201

[PATCH] drm: Set depth and bpp for XRGB4444 family formats

On 08/10/2016 04:12 PM, Daniel Vetter wrote: > On Wed, Aug 10, 2016 at 01:04:54PM +0200, Fabien DESSENNE wrote: >> On 08/10/2016 12:35 PM, Daniel Vetter wrote: >>> On Wed, Aug 10, 2016 at 11:21:56AM +0200, Fabien Dessenne wrote: >>>> These pixel formats are su

[PATCH] drm: Set depth and bpp for XRGB4444 family formats

On 08/10/2016 12:35 PM, Daniel Vetter wrote: > On Wed, Aug 10, 2016 at 11:21:56AM +0200, Fabien Dessenne wrote: >> These pixel formats are supported by format_check() from drm_crtc.c, so >> provide there depth and bpp. >> >> Signed-off-by: Fabien Dessenne > Why? At

[PATCH] drm: Set depth and bpp for XRGB4444 family formats

These pixel formats are supported by format_check() from drm_crtc.c, so provide there depth and bpp. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/drm_fourcc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index

[PATCH] drm: fix pixel size of NV12 / NV16 pixel formats

actually 1 byte per pixel. Signed-off-by: Fabien Dessenne --- drivers/gpu/drm/drm_crtc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 3313f7e..572c6fa 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers

[PATCH 0/2] drm/sti: support of interlaced content with Bottom Field

On 03/03/2016 02:33 PM, Ville Syrjälä wrote: > On Thu, Mar 03, 2016 at 02:28:38PM +0100, Fabien DESSENNE wrote: >> >> On 03/03/2016 12:28 PM, Ville Syrjälä wrote: >>> On Thu, Mar 03, 2016 at 11:03:51AM +0100, Fabien DESSENNE wrote: >>>> Hi Ville, >&g

[PATCH 0/2] drm/sti: support of interlaced content with Bottom Field

On 03/03/2016 12:28 PM, Ville Syrjälä wrote: > On Thu, Mar 03, 2016 at 11:03:51AM +0100, Fabien DESSENNE wrote: >> Hi Ville, >> >> Using DRM_MODE_PRESENT_TOP_FIELD/DRM_MODE_PRESENT_BOTTOM_FIELD assumes >> that the userland controls the field presentation on the disp

[PATCH 0/2] drm/sti: support of interlaced content with Bottom Field

Hi Ville, Using DRM_MODE_PRESENT_TOP_FIELD/DRM_MODE_PRESENT_BOTTOM_FIELD assumes that the userland controls the field presentation on the display output. This assumes that the userland is aware of the field actually on display and I think that this information is not provided by the DRM framewor

[PATCH] drm/crtc-helper: use drm_framebuffer flags

Hi, Can anyone review this patch ? Thanks for your time. Fabien > -Original Message- > From: Fabien DESSENNE [mailto:fabien.dessenne at st.com] > Sent: mardi 1 juillet 2014 14:41 > To: dri-devel at lists.freedesktop.org > Cc: Benjamin Gaignard; Vincent ABRIOU; Fabien DES

[PATCH] drm/crtc-helper: use drm_framebuffer flags

The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be propagated and used by the driver. The only possible value of flags is DRM_MODE_FB_INTERLACED. Signed-off-by: Fabien Dessenne Reviewed-by: Benjamin GAIGNARD --- drivers/gpu/drm/drm_crtc_helper.c | 1 + 1 file changed, 1

[PATCH] drm/crtc-helper: use drm_framebuffer flags

The "flags" parameter of the DRM_IOCTL_MODE_ADDFB2 ioctl must be propagated and used by the driver. The only possible value of flags is DRM_MODE_FB_INTERLACED. Change-Id: I989c01b1e6eef753eb004a5ac876665ea8ab0da6 Signed-off-by: Fabien Dessenne Change-Id: I2350ad8bd1553a4a7388e8d8b7733e

[PATCH] modetest: consider supported formats before selecting a DRM plane

Can anyone review this patch ? Thanks for your time. Fabien > -Original Message- > From: Fabien DESSENNE [mailto:fabien.dessenne at st.com] > Sent: vendredi 28 mars 2014 11:16 > To: dri-devel at lists.freedesktop.org > Cc: Benjamin Gaignard; Vincent Abriou; Fabien DES

[PATCH] modetest: consider supported formats before selecting a DRM plane

. Modetest has to check the supported formats accross the plane list before selecting a candidate. Signed-off-by: Fabien Dessenne --- tests/modetest/modetest.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index