Re: [PATCH] drm/imagination: Ensure PVR_MIPS_PT_PAGE_COUNT is never zero

28012313.5934-1-ya...@kylinos.cn > Closes: > https://lore.kernel.org/dri-devel/20240228012313.5934-1-ya...@kylinos.cn > Fixes: 927f3e0253c1 ("drm/imagination: Implement MIPS firmware processor and > MMU support") > Signed-off-by: Matt Coster Reviewed-by: Frank Binns > --

Re: [PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

On Thu, 2024-03-07 at 07:31 -0600, Adam Ford wrote: > On Thu, Mar 7, 2024 at 6:37 AM Frank Binns wrote: > > On Thu, 2024-03-07 at 12:26 +0000, Frank Binns wrote: > > > On Tue, 2024-02-27 at 05:50 -0600, Adam Ford wrote: > > > > On Tue, Feb 27, 2024 at 3:31 

Re: [PATCH 1/6] dt-bindings: gpu: powervr-rogue: Add PowerVR support for some Renesas GPUs

Hi Adam, On Mon, 2024-02-26 at 21:45 -0600, Adam Ford wrote: > Update the binding to add support for various Renesas SoC's with PowerVR > Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update > the table to indicate such like what was done for the ti,am62-gpu. > >

Re: [PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

On Thu, 2024-03-07 at 12:26 +, Frank Binns wrote: > On Tue, 2024-02-27 at 05:50 -0600, Adam Ford wrote: > > On Tue, Feb 27, 2024 at 3:31 AM Matt Coster wrote: > > > Hi Adam, > > > > > > Thanks for these patches! I'll just reply to this one patch, but

Re: [PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

On Tue, 2024-02-27 at 05:50 -0600, Adam Ford wrote: > On Tue, Feb 27, 2024 at 3:31 AM Matt Coster wrote: > > Hi Adam, > > > > Thanks for these patches! I'll just reply to this one patch, but my > > comments apply to them all. > > > > On 27/02/2024 03:45, Adam Ford wrote: > > > The GPU on the

Re: [PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

Hi Geert, On Tue, 2024-02-27 at 12:04 +0100, Geert Uytterhoeven wrote: > Hi Matt, > > On Tue, Feb 27, 2024 at 10:31 AM Matt Coster wrote: > > Hi Adam, > > > > Thanks for these patches! I'll just reply to this one patch, but my > > comments apply to them all. > > > > On 27/02/2024 03:45, Adam

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

On Tue, 2024-03-05 at 07:47 -0600, Adam Ford wrote: > On Tue, Mar 5, 2024 at 5:58 AM Frank Binns wrote: > > Hi Adam, > > > > Sorry for not responding sooner. I've recently just returned from paternity > > leave, so just catching up on everything. > > Congrat

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

Hi Adam, Sorry for not responding sooner. I've recently just returned from paternity leave, so just catching up on everything. On Thu, 2024-02-15 at 11:22 -0600, Adam Ford wrote: > On Thu, Feb 15, 2024 at 11:10 AM Adam Ford wrote: > > On Thu, Feb 15, 2024 at 10:54 AM Geert Uytterhoeven > >

Re: [PATCH RFC v2 01/11] dt-bindings: gpu: Rename img,powervr to img,powervr-rogue

'. Can you change the title to: Imagination Technologies PowerVR and IMG Rogue GPUs With that changed and Javier's suggestions addressed: Reviewed-by: Frank Binns > > maintainers: >- Frank Binns > diff --git a/MAINTAINERS b/MAINTAINERS > index fa67e2624723f..5b205795da04e 100644

Re: [PATCH] drm/imagination: Move dereference after NULL check in pvr_mmu_backing_page_init()

rm/imagination: Add GEM and VM related code") > Signed-off-by: Dan Carpenter Reviewed-by: Frank Binns > --- > drivers/gpu/drm/imagination/pvr_mmu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imagination/pvr_mmu.c > b/dr

[PATCH] MAINTAINERS: Document Imagination PowerVR driver patches go via drm-misc

This is the tree used by nearly all other DRM drivers, so use it for the PowerVR driver as well. Signed-off-by: Frank Binns --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0ba904b46efe..d4b46b3db022 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH] drm/imagination: fix off by one in pvr_vm_mips_init() error handling

and > MMU support") > Signed-off-by: Dan Carpenter Reviewed-by: Frank Binns > --- > drivers/gpu/drm/imagination/pvr_vm_mips.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/imagination/pvr_vm_mips.c > b/dri

Re: [PATCH 2/2] drm/imagination: Fix IS_ERR() vs NULL bug in pvr_request_firmware()

by: Dan Carpenter Reviewed-by: Frank Binns > --- > drivers/gpu/drm/imagination/pvr_device.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/imagination/pvr_device.c > b/drivers/gpu/drm/imagination/pvr_device.c > index e1dcc4e4

Re: [PATCH 1/2] drm/imagination: Fix error codes in pvr_device_clk_init()

Hi, Thank you for the patches. On Thu, 2023-11-30 at 10:26 +0300, Dan Carpenter wrote: > There is a cut and paste error so this code returns the wrong variable. > > Fixes: 1f88f017e649 ("drm/imagination: Get GPU resources") > Signed-off-by: Dan Carpenter Re

Re: [PATCH drm-misc-next 0/5] PowerVR VM fixes

t; > base-commit: 46990918f35c1bf6e367cf8e0423e7344fec9fcb For the series: Tested-by: Frank Binns I'll leave it to Donald to do the review. Thanks Frank

Re: [PATCH][next] drm/imagination: Fix a couple of spelling mistakes in literal strings

Hi Colin, Thank you for the patch. On Fri, 2023-11-24 at 16:39 +, Colin Ian King wrote: > There are a couple of spelling mistakes in literal strings in the > stid_fmts array. Fix these. > > Signed-off-by: Colin Ian King Reviewed-by: Frank Binns > --- > drivers/g

Re: [PATCH -next] drm/imagination: Remove unneeded semicolon

Hi, Thank you for the patch. On Mon, 2023-11-27 at 09:04 +0800, Yang Li wrote: > ./drivers/gpu/drm/imagination/pvr_free_list.c:258:2-3: Unneeded semicolon > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7635 > Signed-off-by: Yang Li Rev

Re: [PATCH v5 09/17] drm/imagination: Implement power management

Hi Paul, On Wed, 2023-08-16 at 12:56 +0200, Paul Cercueil wrote: > Hi Sarah, > > Le mercredi 16 août 2023 à 09:25 +0100, Sarah Walker a écrit : > > Add power management to the driver, using runtime pm. The power off > > sequence depends on firmware commands which are not implemented in > > this

Re: [PATCH v5 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

tainers, I have added it for now. Thank you - it looks like something went wrong when the patch was sent. > > On Wed, Aug 16, 2023 at 10:26 AM Sarah Walker wrote: > > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > >

Re: [PATCH v4 03/17] drm/imagination/uapi: Add PowerVR driver UAPI

Hi Michel, Thank you for the feedback (comments below). On Tue, 2023-08-08 at 15:46 +0200, Michel Dänzer wrote: > On 7/14/23 16:25, Sarah Walker wrote: > > +/** > > + * DOC: PowerVR IOCTL CREATE_BO interface > > + */ > > + > > +/** > > + * DOC: Flags for CREATE_BO > > + * > > + * The

Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

Hi Krzysztof, On Tue, 2023-07-18 at 08:19 +0200, Krzysztof Kozlowski wrote: > On 14/07/2023 16:30, Sarah Walker wrote: > > Add the Series AXE GPU node to the AM62 device tree. > > > > Signed-off-by: Sarah Walker > > --- > > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 + > > 1

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

Hi Krzysztof, On Tue, 2023-07-18 at 08:20 +0200, Krzysztof Kozlowski wrote: > On 14/07/2023 16:25, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > ... > > > + > > +additionalProperties: false > > + > > +examples: > > +

Re: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

Hi Krzysztof, On Tue, 2023-07-18 at 13:10 +0200, Krzysztof Kozlowski wrote: > On 18/07/2023 13:08, Frank Binns wrote: > > > And this > > > items: > > > - const: gpu > > > can just be > > > const: gpu > > > > > > Although, if t

Re: Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

Hi Krzysztof, On Mon, 2023-07-17 at 09:29 +0200, Krzysztof Kozlowski wrote: > On 14/07/2023 16:25, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > ... > > > + > > + clocks: > > +minItems: 1 > > +maxItems: 3 > >

Re: [PATCH v4 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

Hi Conor, Thank you for your feedback (comments below). On Sat, 2023-07-15 at 11:40 +0100, Conor Dooley wrote: > Hey Sarah, > > Your series does not appear to be threaded. `git send-email` can be > passed, for example, a directory containing a whole series & will set > the correct in-reply-to

Re: [PATCH v3 09/17] drm/imagination: Implement power management

Hi Maxime, On Fri, 2023-07-07 at 14:48 +0200, Maxime Ripard wrote: > On Tue, Jun 13, 2023 at 03:47:52PM +0100, Sarah Walker wrote: > > @@ -503,21 +506,31 @@ pvr_device_init(struct pvr_device *pvr_dev) > > if (err) > > goto err_device_clk_fini; > > > > + /* Explicitly

Re: [PATCH v3 05/17] drm/imagination: Get GPU resources

Hi Maxime, On Fri, 2023-07-07 at 14:47 +0200, Maxime Ripard wrote: > On Tue, Jun 13, 2023 at 03:47:48PM +0100, Sarah Walker wrote: > > Acquire clock, regulator and register resources, and enable/map as > > appropriate. > > > > Signed-off-by: Sarah Walker > > --- > >

Re: [PATCH v3 04/17] drm/imagination: Add skeleton PowerVR driver

Hi Maxime, Thank you for your feedback (comments below). On Fri, 2023-07-07 at 14:46 +0200, Maxime Ripard wrote: > Hi, > > [I just noticed I dropped the Cc list, resending] > > Thanks for contributing this driver, it's awesome to see it moving > forward. > > And congrats on the documentation

Re: Re: [PATCH v3 07/17] drm/imagination: Add GPU ID parsing and firmware loading

On Mon, 2023-06-26 at 10:38 -0500, Adam Ford wrote: > On Mon, Jun 26, 2023 at 8:22 AM Frank Binns wrote: > > Hi Adam, > > > > On Sat, 2023-06-17 at 07:48 -0500, Adam Ford wrote: > > > On Tue, Jun 13, 2023 at 10:20 AM Sarah Walker > > > wrote: > &g

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

Hi Linus, On Fri, 2023-06-16 at 14:48 +0200, Linus Walleij wrote: > Hi Sarah, > > thanks for your patch! > > On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote: > > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > Signed-off-by: Sarah

Re: [PATCH v3 00/17] Imagination Technologies PowerVR DRM driver

Hi Nikolaus, On Fri, 2023-06-16 at 16:06 +0200, H. Nikolaus Schaller wrote: > Hi Linus, > thanks for sharing this conversation with me. > > > Am 16.06.2023 um 14:29 schrieb Linus Walleij : > > > > Hi Sarah, > > > > thanks for starting this long awaited work! > > > > On Tue, Jun 13, 2023 at

Re: [PATCH v3 00/17] Imagination Technologies PowerVR DRM driver

Hi Linus, On Fri, 2023-06-16 at 14:29 +0200, Linus Walleij wrote: > Hi Sarah, > > thanks for starting this long awaited work! > > On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote: > > > This patch series adds the initial DRM driver for Imagination Technologies > > PowerVR > > GPUs,

Re: [PATCH v3 01/17] sizes.h: Add entries between 32G and 64T

Hi Linus, On Fri, 2023-06-16 at 14:10 +0200, Linus Walleij wrote: > On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote: > > > From: Matt Coster > > > > Signed-off-by: Matt Coster > > Looks useful. > Reviewed-by: Linus Walleij Thank you for the review! Frank > > Yours, > Linus Walleij

Re: [PATCH v3 07/17] drm/imagination: Add GPU ID parsing and firmware loading

Hi Adam, On Sat, 2023-06-17 at 07:48 -0500, Adam Ford wrote: > On Tue, Jun 13, 2023 at 10:20 AM Sarah Walker wrote: > > Read the GPU ID register at probe time and select the correct > > features/quirks/enhancements. Use the GPU ID to form the firmware > > file name and load the firmware. > > I

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

> + - interrupt-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > +#include > > +#include > > + > > +gpu: gpu@fd0 { > > +compatible = "ti,am62-gpu", "img,powervr-seriesaxe"; >

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

Hi Rob, On Thu, 2023-06-15 at 14:50 -0600, Rob Herring wrote: > On Tue, Jun 13, 2023 at 9:20 AM Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > Signed-off-by: Sarah Walker > > --- > >

Re: [PATCH v3 05/17] drm/imagination: Get GPU resources

Hi Andrew, On Tue, 2023-06-13 at 13:12 -0500, Andrew Davis wrote: > On 6/13/23 9:47 AM, Sarah Walker wrote: > > Acquire clock, regulator and register resources, and enable/map as > > appropriate. > > > > Signed-off-by: Sarah Walker > > --- > > drivers/gpu/drm/imagination/Makefile | 1 +

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

Hi Krzysztof, On Tue, 2023-06-13 at 20:24 +0200, Krzysztof Kozlowski wrote: > On 13/06/2023 16:47, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > I don't see improvements. That's a NAK :( > > This is a friendly

Re: [PATCH libdrm] xf86drm: Fix operator precedence

Reviewed-by: Frank Binns Thierry Reding writes: > From: Thierry Reding > > The array subscription operator ([]) has higher precedence than the > indirection operator (*), so we need to use parentheses to properly > instruct the compiler to dereference the pointer to

Re: [PATCH libdrm] xf86drmMode: merge successive mutually-exclusive #ifs

Reviewed-by: Frank Binns <frank.bi...@imgtec.com> Eric Engestrom <eric.engest...@imgtec.com> writes: > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > xf86drmMode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/x

Re: [PATCH libdrm] xf86drmMode: merge successive mutually-exclusive #ifs

Reviewed-by: Frank Binns <frank.bi...@imgtec.com> Eric Engestrom <eric.engest...@imgtec.com> writes: > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > xf86drmMode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/x

[PATCH] dma-fence: remove duplicate word in comment

Signed-off-by: Frank Binns <frank.bi...@imgtec.com> --- include/linux/dma-fence.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h index ca97422..efdabbb 100644 --- a/include/linux/dma-fence.h +++ b/include/linux/dma-f

[PATCH] drm: Fix locking cargo-cult in encoder/plane init/cleanup

On 29/11/16 09:45, Daniel Vetter wrote: > Encoders can't be hotplugged, we dont need looking for this s/looking/locking/ With that changed: Reviewed-by: Frank Binns > since it's all single-threaded driver setup/teardown code. CRTCs > already don't grab locks. > > While

[PATCH 2/2] drm: Used DRM_LEGACY for all legacy functions

On 04/08/16 09:20, Daniel Vetter wrote: > On Thu, Aug 04, 2016 at 08:37:49AM +0100, Frank Binns wrote: >> On 03/08/16 20:11, Daniel Vetter wrote: >>> Except for nouveau, only legacy drivers need this really. And nouveau >>> is already marked up with DRIVER_KMS_LE

[PATCH 1/8] drm: rename DRM_MINOR_LEGACY to DRM_MINOR_PRIMARY

MARY (to match the actual struct-member name). > > Furthermore, this is in no way a legacy node, so lets not call it that. > > Signed-off-by: David Herrmann Reviewed-by: Frank Binns > --- > drivers/gpu/drm/drm_drv.c | 14 +++--- > include/drm/drmP.h|

[PATCH 2/2] drm: Used DRM_LEGACY for all legacy functions

callback says that it's called for legacy UMS drivers but it does a check based on DRIVER_MODESET. There are also some places in drm_pci.c that should be changed as well. Anyway, this is progress so: Reviewed-by: Frank Binns > --- > drivers/gpu/drm/drm_agpsupport.c | 6 ++ >

[PATCH 1/2] drm: Mark up legacy/dri1 drivers with DRM_LEGACY

r 100 places using DRIVER_MODESET we need to roll out > this change without a flag day. > > v2: Update docs. > > Signed-off-by: Daniel Vetter Reviewed-by: Frank Binns > --- > Documentation/gpu/drm-internals.rst | 9 ++--- > drivers/gpu/drm/i810/i810_drv.c | 4 +--- &

[PATCH 3/6] drm/amd/amdgpu: Set DRIVER_MODESET feature flag at build time

On 24/06/16 23:08, Alex Deucher wrote: > On Fri, Jun 24, 2016 at 1:15 PM, Frank Binns > wrote: >> This flag was being set unconditionally at runtime so just set it at >> compile time instead. >> >> Signed-off-by: Frank Binns > Reviewed-by: Alex Deucher >

[PATCH v2 6/6] drm: Separate DRIVER_MODESET and DRIVER_LEGACY

- Move a core check Signed-off-by: Frank Binns --- drivers/gpu/drm/drm_bufs.c| 22 +++--- drivers/gpu/drm/drm_context.c | 24 drivers/gpu/drm/drm_dma.c | 4 ++-- drivers/gpu/drm/drm_fops.c| 10 ++ drivers/gpu/drm/drm_ioctl.c | 4

[PATCH v2 5/6] drm: Introduce DRIVER_LEGACY feature

setting functionality only, irrespective of whether it is legacy or not. Mark all legacy drivers appropriately. Signed-off-by: Thierry Reding v2: - Rebase - Add legacy flag to r128 - Don't add legacy flag to radeon - Build fix for tdfx (use the correct field name) - Add documentation to drm-internals

[PATCH 4/6] drm/qxl: Remove dead code

From: Thierry Reding The QXL driver sets DRIVER_MODESET unconditionally, so testing for the absence of the feature will always fail. Signed-off-by: Thierry Reding --- drivers/gpu/drm/qxl/qxl_kms.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH 3/6] drm/amd/amdgpu: Set DRIVER_MODESET feature flag at build time

This flag was being set unconditionally at runtime so just set it at compile time instead. Signed-off-by: Frank Binns --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd

[PATCH 2/6] drm: Rename DRM_MINOR_LEGACY to DRM_MINOR_PRIMARY

This brings the minor type name into line with how the actual minor, using this type, is referenced throughout the rest of drm. Signed-off-by: Frank Binns --- drivers/gpu/drm/drm_drv.c | 16 include/drm/drmP.h| 4 ++-- 2 files changed, 10 insertions(+), 10 deletions

[PATCH 1/6] drm/vmwgfx: Stop checking minor type directly

Use the appropriate drm minor type helper instead. Cc: Sinclair Yeh Cc: Thomas Hellstrom Signed-off-by: Frank Binns --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx

[PATCH v2 0/6] Support render only drivers

at have been rebased are marked as v2. [1] https://lwn.net/Articles/588016/ Frank Binns (4): drm/vmwgfx: Stop checking minor type directly drm: Rename DRM_MINOR_LEGACY to DRM_MINOR_PRIMARY drm/amd/amdgpu: Set DRIVER_MODESET feature flag at build time drm: Separate DRIVER_MODESET and DRIVER_LE

[PATCH] drm/i915: Fix misleading driver debug message

Stop claiming that UMS support is disabled when it's not actually supported anymore. Signed-off-by: Frank Binns --- drivers/gpu/drm/i915/i915_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 3eb47fb

[PATCH] drm: fix some spelling mistakes

Signed-off-by: Frank Binns --- drivers/gpu/drm/drm_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 8ca3d2b..149453c 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c @@ -532,7 +532,7

[PATCH v9 14/14] drm/mediatek: Add interface to allocate Mediatek GEM buffer.

Hi Philipp, Comments below. On 12/01/16 15:15, Philipp Zabel wrote: > From: CK Hu > > Add an interface to allocate Mediatek GEM buffers, allow the IOCTLs > to be used by render nodes. > This patch also sets the RENDER driver feature. > > Signed-off-by: CK Hu > Signed-off-by: Nicolas Boichat >

[PATCH] android: fix warning when releasing active sync point

Is this not the issue fixed by 8e43c9c75? Thanks Frank On 15/12/15 13:30, Gustavo Padovan wrote: > 2015-12-14 Dmitry Torokhov : > >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the following warning: >> >> [ 43.853176]

[PATCH libdrm v2] drm: add drmGet(Master|Render)NameFrom(Render|Master)FD functions

er device name, given an render/master FD. > > v2: > - Rename Device and Primary to Master (aka the /dev/dri/cardX device). > - Check for the file via readdir_r() rather than stat(). > - Wrap the check into a single function. > - Return NULL for non-linux platforms. > > Cc:

[PATCH libdrm] Add new drmGetNodeTypeFromFd function

Hi Emil, On 13/02/15 16:38, Emil Velikov wrote: > Hi Frank, > On 13/02/15 10:51, Frank Binns wrote: >> Add a helper function that returns the type of device node from an fd. >> >> Signed-off-by: Frank Binns > Reviewed-by: Emil Velikov > > Thank you for gett

[RFC PATCH 0/2] libdrm: Add master <> render node helpers

Hi Emil, On 13/02/15 09:18, Emil Velikov wrote: > On 12/02/15 18:21, David Herrmann wrote: >> Hi >> >> On Tue, Feb 10, 2015 at 11:37 PM, Emil Velikov >> wrote: >>> On 02/02/15 00:14, Emil Velikov wrote: Hi all, As mentioned a couple of days ago at #dri-devel some(most) users of

[PATCH 1/2] drm: add drmGet{Device, Render}NameFrom{Render, Device}Fd helpers

Hi Emil, On 02/02/15 00:14, Emil Velikov wrote: > Currently most places assume reliable primary <> render node mapping. > Although this may work in some cases, it is not correct. > > Add a couple of helpers that hide the details and safes all the > guesswork for the user. > > Cc: Daniel Vetter >

[PATCH libdrm] Add new drmGetNodeTypeFromFd function

Add a helper function that returns the type of device node from an fd. Signed-off-by: Frank Binns --- xf86drm.c | 39 +++ xf86drm.h | 1 + 2 files changed, 40 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index d85115c..e117bc6 100644 --- a/xf86drm.c

[PATCH 2/2] libdrm: add drmGetNodeType() helper

Hi Emil, On 02/02/15 00:14, Emil Velikov wrote: > The add a simple helper which returns the node type of the opened fd. > Likely to be used in conjunction with the previous two helpers. > > Cc: Daniel Vetter > Cc: David Herrmann > Signed-off-by: Emil Velikov > --- > xf86drm.c | 43

[PATCH 1/2] Add new drmOpenWithType function (v4)

Reviewed-by: Frank Binns On 11/02/15 04:40, Jammy Zhou wrote: > v2: Add drmGetMinorBase, and call drmOpenWithType in drmOpen > v3: Pass 'type' to drmOpenByBusid and drmOpenDevice in drmOpenByName > v4: Renumber node type definitions, and return -1 for unsupported type > > Signe

[PATCH 1/2] Add new drmOpenWithType function (v3)

On 02/02/15 10:06, Jammy Zhou wrote: > v2: Add drmGetMinorBase, and call drmOpenWithType in drmOpen > v3: Pass 'type' to drmOpenByBusid and drmOpenDevice in drmOpenByName > > Signed-off-by: Jammy Zhou > --- > xf86drm.c | 63 > --- >

[PATCH libdrm 1/2] Rename DRM_NODE_RENDER to DRM_NODE_PRIMARY

Ping On 14/01/15 14:07, Frank Binns wrote: > Now that there are render nodes it doesn't seem appropriate for the type of > the card nodes to be DRM_NODE_RENDER. For this reason, rename this type to > DRM_NODE_PRIMARY as this name better represents the purpose of these nodes. >

[PATCH libdrm 2/2] Add new drmOpenRender function

Add a new function, drmOpenRender, that can be used to open render nodes. This can be used in the same way that drmOpenControl is used to open control nodes. Signed-off-by: Frank Binns --- xf86drm.c | 40 ++-- xf86drm.h | 2 ++ 2 files changed, 40 insertions

[PATCH libdrm 1/2] Rename DRM_NODE_RENDER to DRM_NODE_PRIMARY

Now that there are render nodes it doesn't seem appropriate for the type of the card nodes to be DRM_NODE_RENDER. For this reason, rename this type to DRM_NODE_PRIMARY as this name better represents the purpose of these nodes. Signed-off-by: Frank Binns --- tests/dristat.c | 2 +- xf86drm.c

RFC on upstreaming of a Mediatek DRM modesetting driver

On 01/12/14 15:28, Daniel Vetter wrote: > On Mon, Dec 01, 2014 at 10:01:37AM +0000, Frank Binns wrote: >> Hi, >> >> We are currently in negotiations with one of our customers (Mediatek) on >> a strategy that will allow them to push a DRM modesetting driver into

RFC on upstreaming of a Mediatek DRM modesetting driver

Hi, We are currently in negotiations with one of our customers (Mediatek) on a strategy that will allow them to push a DRM modesetting driver into the upstream kernel. We are writing to get people's opinions and feedback on our proposed approach. Currently, our driver is structured in such a

[PATCH RESEND] drm: fix case where panic notifier isn't unregistered

if a driver's probe function returns 0. Make sure that an attempt to add the panic notifier is made only when adding an element to kernel_fb_helper_list. Signed-off-by: Frank Binns --- This should hopefully have none of the whitespace damage introduced by my email client last time. drivers/gpu/drm

[PATCH] drm: fix case where panic notifier isn't unregistered

nns=imgtec.com at lists.freedesktop.org > [mailto:dri-devel-bounces+frank.binns=imgtec.com at lists.freedesktop.org] On > Behalf Of Frank Binns > Sent: 14 May 2012 16:28 > To: 'airlied at linux.ie'; 'dri-devel at lists.freedesktop.org' > Subject: [PATCH] drm: fix case where panic notifier

RE: [PATCH] drm: fix case where panic notifier isn't unregistered

@lists.freedesktop.org [mailto:dri-devel-bounces+frank.binns=imgtec@lists.freedesktop.org] On Behalf Of Frank Binns Sent: 14 May 2012 16:28 To: 'airl...@linux.ie'; 'dri-devel@lists.freedesktop.org' Subject: [PATCH] drm: fix case where panic notifier isn't unregistered The framebuffer

[PATCH RESEND] drm: fix case where panic notifier isn't unregistered

if a driver's probe function returns 0. Make sure that an attempt to add the panic notifier is made only when adding an element to kernel_fb_helper_list. Signed-off-by: Frank Binns frank.bi...@imgtec.com --- This should hopefully have none of the whitespace damage introduced by my email client last time

[PATCH] drm: fix case where panic notifier isn't unregistered

if a driver's probe function returns 0. Make sure that an attempt to add the panic notifier is made only when adding an element to kernel_fb_helper_list. Signed-off-by: Frank Binns --- drivers/gpu/drm/drm_fb_helper.c | 21 ++--- 1 files changed, 10 insertions(+), 11 deletions(-) diff

[PATCH] drm: fix case where panic notifier isn't unregistered

if a driver's probe function returns 0. Make sure that an attempt to add the panic notifier is made only when adding an element to kernel_fb_helper_list. Signed-off-by: Frank Binns frank.bi...@imgtec.com --- drivers/gpu/drm/drm_fb_helper.c | 21 ++--- 1 files changed, 10 insertions(+), 11