>
> + ret = of_drm_get_panel_orientation(dsi->dev.of_node, >orientation);
> + if (ret < 0)
> + return dev_err_probe(>dev, ret, "Failed to get
> orientation\n");
> +
> drm_panel_init(>panel, dev, _drm_funcs,
> DRM_MODE_CONNECTOR_DSI);
Reviewed-by: Guido Günther
Cheers,
-- Guido
>
> --
> 2.34.1
>
rue
rotation: true
(which also seems to match what other panels do). With that
Reviewd-by: Guido Günther
Cheers,
-- Guido
> required:
>- compatible
>- reg
> --
> 2.34.1
>
7703_enable(struct drm_panel *panel)
> {
> struct st7703 *ctx = panel_to_st7703(panel);
> @@ -784,6 +874,7 @@ static void st7703_remove(struct mipi_dsi_device *dsi)
>
> static const struct of_device_id st7703_of_match[] = {
> { .compatible = "anbernic,r
enum:
># Anberic RG353V-V2 5.0" 640x480 TFT LCD panel
>- anbernic,rg353v-panel-v2
> + # Powkiddy RGB10MAX3 5.0" 720x1280 TFT LCD panel
> + - powkiddy,rgb10max3-panel
># Powkiddy RGB30 3.0" 720x720 TFT LCD panel
>- powkiddy,rgb30-panel
63);
> mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETMIPI, 0x33, 0x81, 0x05,
> 0xf9, 0x0e, 0x0e, 0x20, 0x00, 0x00, 0x00,
> 0x00,
Reviewed-by: Guido Günther
-- Guido
> --
> 2.43.0
>
Hi Ao,
this doesn't say why that was changed but your cover letter
has that information:
> After correcting these parameters by referencing the
> device tree in JELOS (which uses the BSP kernel for RK3566), the panel
> started to work properly.
Can you add that to the commit message and maybe
Hi Chris,
On Fri, Oct 13, 2023 at 01:39:16PM -0500, Chris Morgan wrote:
> From: Chris Morgan
>
> The Powkiddy RGB30 4 inch panel is a 4 inch 720x720 DSI panel used in
> the Powkiddy RGB30 handheld gaming device. Add support for it.
>
> TODO: The panel seems to not resume properly from suspend.
Hi,
On Mon, Feb 13, 2023 at 01:32:38PM +0100, Frank Oltmanns wrote:
> Fix flickering of the pinephone's XDB599 panel that happens after
> resume.
>
> Extend the delay after issuing the command to exit sleep mode from 60 to
> 120 msec as per the controller's specification.
>
> Introduce a 120
Hi,
On Sat, Feb 11, 2023 at 06:17:48PM +0100, Frank Oltmanns wrote:
> From: Ondrej Jirman
>
> Switching to a different reset sequence, enabling IOVCC before enabling
> VCC.
>
> There also needs to be a delay after enabling the supplies and before
> deasserting the reset. The datasheet specifies
time to stabilize before deasserting reset. */
> + usleep_range(1, 2);
> +
> gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> - msleep(20);
> + usleep_range(15000, 2);
>
> ctx->prepared = true;
>
> return 0;
> -
> -disable_vcc:
> - regulator_disable(ctx->vcc);
> - return ret;
> }
>
> static const u32 mantix_bus_formats[] = {
Reviewed-by: Guido Günther
Cheers,
-- Guido
> --
> 2.39.1
>
Hi Caleb,
thanks for putting this out.
On Mon, Oct 09, 2023 at 06:32:50PM +0100, Caleb Connolly wrote:
> Some display panels found in modern phones and laptops feature
> non-standard display shapes with features like rounded corners, notches
> (sections of the display that are cut-out from the
dev_err(ctx->dev, "Failed to enter sleep mode: %d\n", ret);
>
> + /* It takes the controller 120 msec to enter sleep mode. */
> + msleep(120);
> +
> return 0;
> }
Tested this patch on a Librem 5 devkit.
Reviewed-by: Guido Günther
Tested-by: Guido Günther
Cheers,
-- Guido
>
> --
> 2.39.1
>
,imx8mq-lcdif
> + then:
> +required:
> + - power-domains
>
> examples:
>- |
> --
> 2.40.1
>
Thanks a lot to Marek and Liu for confirming!
Acked-by: Guido Günther
Cheers,
-- Guido
Fixes: 44cfc6233447 ("drm/bridge: Add NWL MIPI DSI host controller support")
> Fixes: 171b3b1e0f8b ("drm: bridge: samsung-dsim: Select
> GENERIC_PHY_MIPI_DPHY")
> Signed-off-by: Randy Dunlap
> Reported-by: Aleksandr Nogikh
> Link: lore.kernel.org/r/20230803144227.
Hi,
On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote:
> i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers
> requirement of power-domains, thou it's not required.
>
> Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL
> power-domains
handheld gaming
> device. Like the first revision of the RG353V the control chip is known
> but the panel itself is unknown, so name it for the device.
>
> Signed-off-by: Chris Morgan
> Acked-by: Krzysztof Kozlowski
> Acked-by: Guido Günther
> ---
> .../devicetree/bindings/disp
69000,
> + .clock = (720 + 40 + 40 + 40) * (1440 + 18 + 10 + 17) * 60 / 1000,
> .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> .width_mm= 68,
> .height_mm = 136,
Reviewed-by: Guido Günther
(I've seen your other patches but it will be some days until I can test
the jh057n00900 panel).
Cheers,
-- Guido
> --
> 2.39.1
>
5 Devkit, the Librem 5 uses the
mantix,mlaf057we51-x panel.
> This is the concluding message from Guido Günther in that thread:
> https://lore.kernel.org/all/20200801110409.ga6...@bogon.m.sigxcpu.org/#t
>
> Guido wanted changes to the commit message. I updated it to adress his
> request
0x01, 0x00, 0xFF, 0xFF,
> 0x00);
> + dsi_dcs_write_seq(dsi, ST7703_CMD_SETECO, 0x01, 0x00, 0xFF, 0xFF, 0x00);
Thanks for catching this! Would make sense to split that into a separate
commit. With that fixed
Reviewed-by: Guido Günther
-- Guido
>
> dsi_dcs_write_seq(d
- anbernic,rg353v-panel-v2
># Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel
> - rocktech,jh057n00900
># Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
Acked-by: Guido Günther
Cheers,
-- Guido
> --
> 2.34.1
>
, 0x00, 0x00, 0x00,
> +0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x0A,
> +0xA5, 0x00, 0x00, 0x00, 0x00);
>
> /* Adjust the gamma characteristics of the panel. */
> - dsi_dcs_write_seq(dsi, ST7703_CMD_SETGAMMA,
> - 0x00, 0x09, 0x0D, 0x23, 0x27, 0x3C, 0x41, 0x35,
> - 0x07, 0x0D, 0x0E, 0x12, 0x13, 0x10, 0x12, 0x12,
> - 0x18, 0x00, 0x09, 0x0D, 0x23, 0x27, 0x3C, 0x41,
> - 0x35, 0x07, 0x0D, 0x0E, 0x12, 0x13, 0x10, 0x12,
> - 0x12, 0x18);
> + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETGAMMA,
> +0x00, 0x09, 0x0D, 0x23, 0x27, 0x3C, 0x41, 0x35,
> +0x07, 0x0D, 0x0E, 0x12, 0x13, 0x10, 0x12, 0x12,
> +0x18, 0x00, 0x09, 0x0D, 0x23, 0x27, 0x3C, 0x41,
> +0x35, 0x07, 0x0D, 0x0E, 0x12, 0x13, 0x10, 0x12,
> +0x12, 0x18);
>
> return 0;
> }
> @@ -499,7 +482,7 @@ static int allpixelson_set(void *data, u64 val)
> struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>
> dev_dbg(ctx->dev, "Setting all pixels on\n");
> - dsi_generic_write_seq(dsi, ST7703_CMD_ALL_PIXEL_ON);
> + mipi_dsi_generic_write_seq(dsi, ST7703_CMD_ALL_PIXEL_ON);
> msleep(val * 1000);
> /* Reset the panel to get video back */
> drm_panel_disable(>panel);
Reviewed-by: Guido Günther
Cheers,
-- Guido
> --
> 2.38.1
>
H, 0xA5);
> + mipi_dsi_generic_write_seq(dsi, MANTIX_CMD_OTP_STOP_RELOAD_MIPI, 0x00,
> 0x2F);
> msleep(20);
>
> dev_dbg(dev, "Panel init sequence done\n");
Would have been nice to be cc'ed on the changes to
include/drm/drm_mipi_dsi.h as well so one doesn't have to go and hunt
for changes on lore.kernel.org. Anyway:
Reviewed-by: Guido Günther
Cheers,
-- Guido
> --
> 2.38.1
>
Hi Javier,
Could you please also cc maintainers on the actual macro addition since
it's hard to review without seeing what the code gets changed to
(especially when there's multiple revisions). I assume
https://lore.kernel.org/dri-devel/20221228014757.3170486-2-javi...@redhat.com/
is the
sion is enabled.
> + */
> +#define VIVANTE_MOD_COMP_DEC400 (1ULL << 52)
> +#define VIVANTE_MOD_COMP_MASK (0xfULL << 52)
> +
> +/* Masking out the extension bits will yield the base modifier. */
> +#define VIVANTE_MOD_EXT_MASK (VIVANTE_MOD_TS_MASK | \
> + VIVANTE_MOD_COMP_MASK)
> +
> /* NVIDIA frame buffer modifiers */
>
> /*
Reviewed-by: Guido Günther
Cheers,
-- Guido
gt;use += 1;
> + }
> else
> mapping = NULL;
> mutex_unlock(_context->lock);
Reviewed-by: Guido Günther
Cheers,
-- Guido
> --
> 2.30.2
>
ct etnaviv_iommu_context
> *context,
> struct etnaviv_vram_mapping *mapping, u64 va);
> void etnaviv_iommu_unmap_gem(struct etnaviv_iommu_context *context,
> struct etnaviv_vram_mapping *mapping);
> +void etnaviv_iommu_reap_mapping(struct etnaviv_vram_mapping *mapping);
>
> int etnaviv_iommu_get_suballoc_va(struct etnaviv_iommu_context *ctx,
> struct etnaviv_vram_mapping *mapping,
Reviewed-by: Guido Günther
Cheers,
-- Guido
> --
> 2.30.2
>
Hi Liu,
On Fri, Apr 29, 2022 at 08:30:43PM +0800, Liu Ying wrote:
> Hi,
>
> On Fri, 2022-04-22 at 19:24 +0200, Guido Günther wrote:
> > Hi,
> > On Tue, Apr 19, 2022 at 09:08:48AM +0800, Liu Ying wrote:
> > > The Northwest Logic MIPI DSI host controller em
dsi_mode_set() to set PHY mode to MIPI DPHY
> explicitly.
>
> Cc: Guido Günther
> Cc: Robert Chiras
> Cc: Martin Kepplinger
> Cc: Andrzej Hajda
> Cc: Neil Armstrong
> Cc: Laurent Pinchart
> Cc: Jonas Karlman
> Cc: Jernej Skrabec
> Cc: David Airlie
> Cc: D
dsi_mode_set() to set PHY mode to MIPI DPHY
> explicitly.
>
> Cc: Guido Günther
> Cc: Robert Chiras
> Cc: Martin Kepplinger
> Cc: Andrzej Hajda
> Cc: Neil Armstrong
> Cc: Laurent Pinchart
> Cc: Jonas Karlman
> Cc: Jernej Skrabec
> Cc: David Airlie
> Cc: D
gned-off-by: Lucas Stach
Whole series
Tested-by: Guido Günther
Acked-by: Guido Günther
The code changes look good to me too but I got some details wrong too many times
for a `Reviewed-by:`
Cheers,
-- Guido
> ---
> drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 6 ++
> 1 file changed
SI_IRQ_MASK2, 0x7);
Works fine here. I thought it was due to some hw quirk but can't find
any note in it so:
Reviewed-by: Guido Günther
Thanks,
-- Guido
>
> return nwl_dsi_clear_error(dsi);
> }
> --
> 2.25.1
>
Hi,
On Tue, Mar 01, 2022 at 07:42:41PM +0530, Jagan Teki wrote:
> devm_drm_of_get_bridge is capable of looking up the downstream
> bridge and panel and trying to add a panel bridge if the panel
> is found.
>
> Replace explicit finding calls with devm_drm_of_get_bridge.
>
&
Cc: Andrzej Hajda
> Cc: Neil Armstrong
> Cc: Robert Foss
> Cc: Laurent Pinchart
> Cc: Jonas Karlman
> Cc: Jernej Skrabec
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Kishon Vijay Abraham I
> Cc: Vinod Koul
> Cc: Kevin Hilman
> Cc: Jerome Brunet
> C
Hi,
On Fri, Dec 10, 2021 at 11:18:17PM +0530, Jagan Teki wrote:
> panel_bridge pointer never used anywhere except the one it
> looked up at nwl_dsi_bridge_attach.
>
> Drop it from the nwl_dsi structure.
>
> Cc: Guido Günther
> Signed-off-by: Jagan Teki
Revie
Hi Sam,
On Thu, Oct 14, 2021 at 09:35:20PM +0200, Sam Ravnborg wrote:
> Hi Guido,
>
> > > >
> > > > + if (ret != -EPROBE_DEFER) {
> > > > #ifdef CONFIG_OF
> > > > - DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n",
> > > > - bridge->of_node,
ttach fails") which triggered
[drm:drm_bridge_attach] *ERROR* failed to attach bridge
/soc@0/bus@3080/mipi-dsi@30a0 to encoder None-34: -517
during boot.
Signed-off-by: Guido Günther
---
This was prompted by the discussion at
https://lore.kernel.org
Hi,
On Wed, Oct 13, 2021 at 08:48:32AM +0200, Andrzej Hajda wrote:
> On 12.10.2021 22:47, Guido Günther wrote:
> > Hi Laurent,
> > On Tue, Oct 12, 2021 at 11:17:07PM +0300, Laurent Pinchart wrote:
> > > Hi Guido,
> > >
> > > Thank you for the patch.
>
Hi,
On Tue, Oct 12, 2021 at 10:47:14PM +0200, Guido Günther wrote:
> Hi Laurent,
> On Tue, Oct 12, 2021 at 11:17:07PM +0300, Laurent Pinchart wrote:
> > Hi Guido,
> >
> > Thank you for the patch.
> >
> > On Tue, Oct 12, 2021 at 09:58:58PM +0200, Guido
Hi Laurent,
On Tue, Oct 12, 2021 at 11:17:07PM +0300, Laurent Pinchart wrote:
> Hi Guido,
>
> Thank you for the patch.
>
> On Tue, Oct 12, 2021 at 09:58:58PM +0200, Guido Günther wrote:
> > Otherwise logs are filled with
> >
> > [drm:drm_bridge_attach
Hi,
On Tue, Oct 12, 2021 at 10:08:28PM +0200, Sam Ravnborg wrote:
> Hi Guido,
>
> On Tue, Oct 12, 2021 at 09:58:58PM +0200, Guido Günther wrote:
> > Otherwise logs are filled with
> >
> > [drm:drm_bridge_attach] *ERROR* failed to attach bridge
> > /soc@
Otherwise logs are filled with
[drm:drm_bridge_attach] *ERROR* failed to attach bridge
/soc@0/bus@3080/mipi-dsi@30a0 to encoder None-34: -517
when the bridge isn't ready yet.
Fixes: fb8d617f8fd6 ("drm/bridge: Centralize error message when bridge attach
fails")
Signed-off
Hi Sam,
On Mon, Oct 11, 2021 at 06:56:00PM +0200, Sam Ravnborg wrote:
> Hi Guido,
>
> On Mon, Oct 11, 2021 at 03:41:22PM +0200, Guido Günther wrote:
> > commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if
> > present") added bus format probin
If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is
returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in
that case.
This unbreaks e.g. using mxsfb with the nwl bridge and mipi dsi panels.
Reported-by: Martin Kepplinger
Signed-off-by: Guido Günther
media-bus-formats.h has them in hexadecimal as well so matching with
that file saves one conversion when debugging.
Signed-off-by: Guido Günther
Reviewed-by: Lucas Stach
Reviewed-by: Robert Foss
---
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This allows the DSI bridge to detect the correct bus format.
We currently only support MEDIA_BUS_FMT_RGB888_1X24.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-mantix
This allows the DSI bridge to detect the correct bus format.
We currently only support MEDIA_BUS_FMT_RGB888_1X24.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-sitronix
output (see chapter 13.6 of the i.MX 8MQ reference
manual) - which matches what xsfb can input.
Fixes: b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if
present")
Signed-off-by: Guido Günther
Reviewed-by: Lucas Stach
---
drivers/gpu/drm/bridge/nwl-
xcpu.org/T/#m961c22bf2a437a16b29214913d6f0d523fbe88e2
- Add Reviewd-by from Rober Foss
https://lore.kernel.org/dri-devel/cag3jfyteqcpnzqrfsggcrnpdfsggqvibfhbezw+1hcf3-z9...@mail.gmail.com/
Guido Günther (5):
drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts
drm/panel: mantix: Add media
Hi,
On Mon, Oct 04, 2021 at 09:58:37AM +0200, Lucas Stach wrote:
> Am Montag, dem 04.10.2021 um 09:27 +0200 schrieb Guido Günther:
> > If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is
> > returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) i
ridge if
present")
Reported-by: Martin Kepplinger
Signed-off-by: Guido Günther
---
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
index d6abd2077114..e3fbb8b58d5d 100644
---
media-bus-formats.h has them in hexadecimal as well so matching with
that file saves one conversion when debugging.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
b/drivers
This allows the DSI bridge to detect the correct bus format.
We currently only support MEDIA_BUS_FMT_RGB888_1X24.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-sitronix
This allows the DSI bridge to detect the correct bus format.
We currently only support MEDIA_BUS_FMT_RGB888_1X24.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-mantix
output (see chapter 13.6 of the i.MX 8MQ reference
manual) - which matches what xsfb can input.
Fixes: b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if
present")
Signed-off-by: Guido Günther
---
drivers/gpu/drm/bridge/nwl-dsi.c | 35 ++
the queue and the actual nwl fix to the
front.
Guido Günther (5):
drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts
drm/panel: mantix: Add media bus format
drm/panel: st7703: Add media bus format
drm: mxsfb: Print failed bus format in hex
drm: mxsfb: Set proper default bus format when usin
Hi,
On Tue, Sep 28, 2021 at 11:27:49AM +0200, Lucas Stach wrote:
> Am Dienstag, dem 28.09.2021 um 11:19 +0200 schrieb Guido Günther:
> > Hi,
> > On Tue, Sep 28, 2021 at 11:08:58AM +0200, Marek Vasut wrote:
> > > On 9/28/21 10:55 AM, Guido Günther wrote:
> > >
ridge if
present")
Reported-by: Martin Kepplinger
Signed-off-by: Guido Günther
---
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
index d6abd2077114..f4be16f5c20b 100644
---
output (see chapter 13.6 of the i.MX 8MQ reference
manual) - which matches what xsfb can input.
Fixes: b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if
present")
Signed-off-by: Guido Günther
---
drivers/gpu/drm/bridge/nwl-dsi.c | 35 ++
This allows the DSI bridge to detect the correct bus format.
We currently only support MEDIA_BUS_FMT_RGB888_1X24.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-sitronix
This allows the DSI bridge to detect the correct bus format.
We currently only support MEDIA_BUS_FMT_RGB888_1X24.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-mantix
media-bus-formats.h has them in hexadecimal as well so matching with
that file saves one conversion when debugging.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
b/drivers
to unbreak the display stack in 5.15.
Guido Günther (5):
drm: mxsfb: Print failed bus format in hex
drm: mxsfb: Set proper default bus format when using a bridge
drm/bridge: nwl-dsi: Add atomic_get_input_bus_fmts
drm/panel: mantix: Add media bus format
drm/panel: st7703: Add media
Hi,
On Tue, Sep 28, 2021 at 11:08:58AM +0200, Marek Vasut wrote:
> On 9/28/21 10:55 AM, Guido Günther wrote:
> > If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is
> > returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in
> > that case.
&
ridge if
present")
Signed-off-by: Guido Günther
---
I'll look at what needs to be done in nwl separately but this also
unbreaks other bridge seupts that don't to format negotiation yet.
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu
Hi,
On Sun, Jul 04, 2021 at 03:04:33PM +0530, Jagan Teki wrote:
> nwl_dsi_plat_clk_config structure added in below commit but not
> used anywhere in the driver.
>
> commit <44cfc6233447c> ("drm/bridge: Add NWL MIPI DSI host controller
> support")
>
> Drop it.
tep.
Looks good to me and tested on imx8mq Librem 5 Devkit with
https://lore.kernel.org/linux-arm-kernel/cover.1617968250.git@sigxcpu.org/
on top so
Reviewed-by: Guido Günther
Tested-by: Guido Günther
Cheers,
-- Guido
>
>
> v2->v3:
> * Split the single patch in v2 into 3 patc
Hi,
On Tue, Dec 08, 2020 at 10:04:57AM +0100, Guido Günther wrote:
> Hi,
> On Fri, Dec 04, 2020 at 03:33:41PM +0800, Liu Ying wrote:
> > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp
> > works with a Mixel MIPI DPHY + LVDS PHY combo to support either
>
the only DRM_DEV_ERROR() usage, the rest of the driver
uses dev_err().
Guido Günther (1):
drm: mxsfb: Silence -EPROBE_DEFER while waiting for bridge
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
--
2.29.2
the only DRM_DEV_ERROR() usage, the rest of the driver
uses dev_err().
Signed-off-by: Guido Günther
Fixes: c42001e357f7 ("drm: mxsfb: Use drm_panel_bridge")
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu
takes reference to the latest
> dphy node in imx8mq.dtsi.
>
> Cc: Guido Günther
> Cc: Kishon Vijay Abraham I
> Cc: Vinod Koul
> Cc: Rob Herring
> Cc: NXP Linux Team
> Signed-off-by: Liu Ying
> ---
> v2->v3:
> * Improve the 'clock-names' property by d
Hi,
On Fri, Dec 11, 2020 at 09:46:21AM +0800, Liu Ying wrote:
> Add support for Mixel MIPI DPHY + LVDS PHY combo IP
> as found on Freescale i.MX8qxp SoC.
>
> Cc: Guido Günther
> Cc: Kishon Vijay Abraham I
> Cc: Vinod Koul
> Cc: Rob Herring
> Cc: NXP Linux Team
&
he LVDS PHY mode only
> for the i.MX8qxp Mixel combo PHY, i.e., the MIPI DPHY mode is yet to be
> supported, so for now error would be returned from ->set_mode() if MIPI
> DPHY mode is passed over to it for the combo PHY.
>
> Cc: Guido Günther
> Cc: Robert Chiras
> Cc: Kishon Vijay Abrah
Hi,
On Tue, Dec 08, 2020 at 06:03:05PM +0800, Liu Ying wrote:
> On Tue, 2020-12-08 at 10:24 +0100, Guido Günther wrote:
> > Hi Liu,
> > some minor comments inline:
> >
> > On Fri, Dec 04, 2020 at 03:33:44PM +0800, Liu Ying wrote:
> > > i.MX8qxp SoC embeds a Mi
Hi,
On Mon, Dec 07, 2020 at 03:32:06PM -0600, Rob Herring wrote:
> On Wed, 18 Nov 2020 09:29:53 +0100, Guido Günther wrote:
> > This panel from Shenzhen Yashi Changhua Intelligent Technology Co
> > uses the same driver IC but a different LCD.
> >
> > Signed-off-by:
t this patch supports the LVDS PHY mode only
> for the i.MX8qxp Mixel combo PHY, i.e., the MIPI DPHY mode is yet to be
> supported, so for now error would be returned from ->set_mode() if MIPI
> DPHY mode is passed over to it for the combo PHY.
>
> Cc: Guido Günther
> Cc: Robert
found on Freescale i.MX8qxp SoC.
>
> Cc: Guido Günther
> Cc: Kishon Vijay Abraham I
> Cc: Vinod Koul
> Cc: Rob Herring
> Cc: NXP Linux Team
> Signed-off-by: Liu Ying
> ---
> Documentation/devicetree/bindings/phy/mixel,mipi-dsi-phy.txt | 8 +++-
> 1 file
l_dsi_enable() to set PHY mode to MIPI DPHY
> explicitly.
>
> Cc: Guido Günther
> Cc: Robert Chiras
> Cc: Martin Kepplinger
> Cc: Andrzej Hajda
> Cc: Neil Armstrong
> Cc: Laurent Pinchart
> Cc: Jonas Karlman
> Cc: Jernej Skrabec
> Cc: David Airlie
> Cc: D
Hi Liu,
On Fri, Dec 04, 2020 at 03:33:40PM +0800, Liu Ying wrote:
> Hi,
>
> This series adds i.MX8qxp LVDS PHY mode support for the Mixel PHY in the
> Freescale i.MX8qxp SoC.
This looks good to me from the NWL and actual phy driver part. I'll
comment in the individual patches but leave comments
Hi Linus,
On Thu, Nov 19, 2020 at 09:35:17AM +0100, Linus Walleij wrote:
> On Wed, Nov 18, 2020 at 9:29 AM Guido Günther wrote:
>
> > This adds new panel type to the mantix driver as found on the Librem 5 and
> > fixes a glitch in the init sequence (affecting bot
This allows us to raise DRAM bandiwth to a high enough value for a
stable picture on i.mx8mq. We pick a bandwidth that should be sufficient
for 4k@60Hz.
Modelled like mdp5_kms.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/imx/dcss/dcss-dev.c | 47 +++--
drivers/gpu
in a cyan
screen.
Modelled like mdp5_kms.
Guido Günther (1):
drm/imx/dcss: Add interconnect support
drivers/gpu/drm/imx/dcss/dcss-dev.c | 47 +++--
drivers/gpu/drm/imx/dcss/dcss-dev.h | 3 ++
2 files changed, 48 insertions(+), 2 deletions(-)
--
2.29.2
Hi Lukas,
On Tue, Nov 24, 2020 at 06:12:17PM +0100, Lukas F. Hartmann wrote:
> The fixup of HSYNC and VSYNC should not be done when the input source is
> DCSS, or internal display does not work on MNT Reform 2 (open hardware
> laptop based on NXP i.MX8M using DCSS->DSI->eDP for internal display).
Hi,
On Mon, Nov 23, 2020 at 10:48:26PM +0100, Sam Ravnborg wrote:
> Hi Guido,
>
> On Wed, Nov 18, 2020 at 09:29:47AM +0100, Guido Günther wrote:
> > This adds new panel type to the mantix driver as found on the Librem 5 and
> > fixes a glitch in the init sequence (affecting
Hi Linus,
On Thu, Nov 19, 2020 at 09:35:17AM +0100, Linus Walleij wrote:
> On Wed, Nov 18, 2020 at 9:29 AM Guido Günther wrote:
>
> > This adds new panel type to the mantix driver as found on the Librem 5 and
> > fixes a glitch in the init sequence (affecting bot
Hi Linus,
The whole series looks good to me code wise so
Reviewed-by: Guido Günther
but i have no means to test the changes.
Cheers,
-- Guido
On Tue, Nov 17, 2020 at 06:56:19PM +0100, Linus Walleij wrote:
> Fix up the format of the manufacturer command set table
> to be TAB-in
Hi,
On Tue, Nov 17, 2020 at 09:42:33PM +0100, Linus Walleij wrote:
> On Tue, Nov 17, 2020 at 6:49 PM Guido Günther wrote:
>
> > Add prefix for Shenzhen Yashi Changhua Intelligent Technology Co., Ltd.
> >
> > Signed-off-by: Guido Günther
> > ---
> > Docu
This panel from Shenzhen Yashi Changhua Intelligent Technology Co
uses the same driver IC but a different LCD.
Signed-off-by: Guido Günther
Reviewed-by: Linus Walleij
---
.../devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git
Add prefix for Shenzhen Yashi Changhua Intelligent Technology Co., Ltd.
Signed-off-by: Guido Günther
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation
We've seen some (non permanent) burn in and bad white balance
on some of the panels. Adding this bit from a vendor supplied
sequence fixes it.
Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X
DSI panel")
Signed-off-by: Guido Günther
Reviewed-by: Lin
Less code and easier probe deferral debugging.
Signed-off-by: Guido Günther
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 24 +++
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
b
The panel uses the same driver IC and has the same resolution but a
slightly different default mode. It seems it can work with the same
init sequence.
Signed-off-by: Guido Günther
Reviewed-by: Linus Walleij
---
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 16
1 file
This can be used to use different modes for differnt panels via OF
device match.
Signed-off-by: Guido Günther
Reviewed-by: Linus Walleij
---
.../gpu/drm/panel/panel-mantix-mlaf057we51.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm
comments by Linus Walleij
- fix alphabetical ordering in
Documentation/devicetree/bindings/vendor-prefixes.yaml
https://lore.kernel.org/dri-devel/CACRpkdao_TMcpRsdK=7k5fnkjse0bqwk58iwu0xsxddndcf...@mail.gmail.com/
- add reviewed by to all except 5/6, thanks
Guido Günther (6):
drm/panel
The panel uses the same driver IC and has the same resolution but a
slightly different default mode. It seems it can work with the same
init sequence.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 16
1 file changed, 16 insertions(+)
diff
We've seen some (non permanent) burn in and bad white balance
on some of the panels. Adding this bit from a vendor supplied
sequence fixes it.
Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X
DSI panel")
Signed-off-by: Guido Günther
---
drivers/gpu/drm/p
This panel from Shenzhen Yashi Changhua Intelligent Technology Co
uses the same driver IC but a different LCD.
Signed-off-by: Guido Günther
---
.../devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git
a/Documentation/devicetree/bindings
This can be used to use different modes for differnt panels via OF
device match.
Signed-off-by: Guido Günther
---
.../gpu/drm/panel/panel-mantix-mlaf057we51.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51
Less code and easier probe deferral debugging.
Signed-off-by: Guido Günther
---
drivers/gpu/drm/panel/panel-sitronix-st7703.c | 24 +++
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
b/drivers/gpu/drm/panel/panel
Add prefix for Shenzhen Yashi Changhua Intelligent Technology Co., Ltd.
Signed-off-by: Guido Günther
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
b/Documentation
This adds new panel type to the mantix driver as found on the Librem 5 and
fixes a glitch in the init sequence (affecting both panels). The fix is at the
start of the series to make backporting simpler.
It also adds a patch to make st7703 use dev_err_probe().
Guido Günther (6):
drm/panel
1 - 100 of 452 matches
Mail list logo
