Re: [PATCH 7/9] drm/gma500: use gem get/put page helpers

2013-10-08 Thread Guillaume CLÉMENT
On Wed, Aug 07, 2013 at 01:41:25PM -0400, Rob Clark wrote: Signed-off-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/gma500/gtt.c | 38 ++ 1 file changed, 6 insertions(+), 32 deletions(-) [ snip ] This is quite late to report, but I've just begun

Re: [PATCH 7/9] drm/gma500: use gem get/put page helpers

2013-10-08 Thread Guillaume CLÉMENT
This is quite late to report, but I've just begun testing 3.12, and this patch makes my screen garbled when using the modesetting xorg driver. Alright, after trying to notice what was different between the old and new code, I've found the culprit : - gt-npage = pages; There is no

[PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Guillaume CLÉMENT
> >> Can you please submit the exact same change for drm/i915/intel_sdvoc.c > >> too? The sdvo encoders can be the same ones for psb and i915 so having > >> the same code would be great. Separate patch for drm/i915 ofc. > > > > Are you absolutely sure that is a hardware error and not a software

Re: [PATCH] gma500: Fix SDVO turning off randomly

2013-08-10 Thread Guillaume CLÉMENT
Can you please submit the exact same change for drm/i915/intel_sdvoc.c too? The sdvo encoders can be the same ones for psb and i915 so having the same code would be great. Separate patch for drm/i915 ofc. Are you absolutely sure that is a hardware error and not a software SDVO protocol

drm/gma500 : Suspend/resume issues

2012-05-17 Thread Guillaume Clément
> Either way, if I add an empty "save" function, suspend works again (but at > the moment, resume still doesn't work, I'm still trying to work on that). > > If I just add a "if (connector->funcs->save)", this also fixes the crash. > Actually, the resume problem is exactly the same as the

drm/gma500 : Suspend/resume issues

2012-05-17 Thread Guillaume Clément
Hello, On my Poulsbo-enabled machine, I cannot do suspend/resume since the gma500_gfx has left staging. I'm currently testing on linux-3.4-rc7. After some debugging, I found out what the issue is. The crash occurs in psb_save_display_registers at the following lines :

[PATCH] gma500: Fix hardware cursor support for poulsbo

2012-05-17 Thread Guillaume Clément
Le dimanche 13 mai 2012 15:07:46 Patrik Jakobsson a ?crit : > Poulsbo needs a physical address in the cursor base register. We allocate a > stolen memory buffer and copy the cursor image provided by userspace into > it. When/If we get our own userspace driver we can map this stolen memory >

Re: [PATCH] gma500: Fix hardware cursor support for poulsbo

2012-05-16 Thread Guillaume Clément
Le dimanche 13 mai 2012 15:07:46 Patrik Jakobsson a écrit : Poulsbo needs a physical address in the cursor base register. We allocate a stolen memory buffer and copy the cursor image provided by userspace into it. When/If we get our own userspace driver we can map this stolen memory directly.

drm/gma500 : Suspend/resume issues

2012-05-16 Thread Guillaume Clément
Hello, On my Poulsbo-enabled machine, I cannot do suspend/resume since the gma500_gfx has left staging. I'm currently testing on linux-3.4-rc7. After some debugging, I found out what the issue is. The crash occurs in psb_save_display_registers at the following lines :

Re: drm/gma500 : Suspend/resume issues

2012-05-16 Thread Guillaume Clément
Either way, if I add an empty save function, suspend works again (but at the moment, resume still doesn't work, I'm still trying to work on that). If I just add a if (connector-funcs-save), this also fixes the crash. Actually, the resume problem is exactly the same as the suspend problem.

[gma500] Fix screen blackouts

2012-04-21 Thread Guillaume Clément
Hello, Since linux-3.3 I have been experiencing screen "blackouts" with the gma500_gfx driver. My laptop display would turn off and on again frequently. After activating the drm.debug=255 kernel option, the logs showed this during the blackout : [ 166.940676]

[gma500] Fix screen blackouts

2012-04-21 Thread Guillaume Clément
Hello, Since linux-3.3 I have been experiencing screen blackouts with the gma500_gfx driver. My laptop display would turn off and on again frequently. After activating the drm.debug=255 kernel option, the logs showed this during the blackout : [ 166.940676]