Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-11 Thread Hans Verkuil
On 6/11/19 2:10 PM, Cheng-yi Chiang wrote: > On Tue, Jun 4, 2019 at 3:24 PM Daniel Vetter wrote: >> >> On Tue, Jun 04, 2019 at 10:32:50AM +0800, Cheng-yi Chiang wrote: >>> On Mon, Jun 3, 2019 at 4:09 PM Daniel Vetter wrote: >>>> >>>> On Mon, Jun

Re: [PATCH 5/8] drivers: media: coda: fix warning same module names

2019-06-11 Thread Hans Verkuil
On 6/11/19 10:15 AM, Philipp Zabel wrote: > Hi, > > On Mon, 2019-06-10 at 13:14 +, Matt Redfearn wrote: >> >> On 10/06/2019 14:03, Anders Roxell wrote: >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil wrote: >>>> >>>> On 6/6

Re: [PATCH 5/8] drivers: media: coda: fix warning same module names

2019-06-06 Thread Hans Verkuil
On 6/6/19 11:47 AM, Anders Roxell wrote: > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as > loadable modules, we see the following warning: > > warning: same module names found: > fs/coda/coda.ko > drivers/media/platform/coda/coda.ko > > Rework so media coda matches the

Re: [PATCH 4/8] drivers: media: i2c: fix warning same module names

2019-06-06 Thread Hans Verkuil
On 6/6/19 11:47 AM, Anders Roxell wrote: > When building with CONFIG_VIDEO_ADV7511 and CONFIG_DRM_I2C_ADV7511 > enabled as loadable modules, we see the following warning: > > warning: same module names found: > drivers/gpu/drm/bridge/adv7511/adv7511.ko > drivers/media/i2c/adv7511.ko > >

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-03 Thread Hans Verkuil
On 6/3/19 10:09 AM, Daniel Vetter wrote: > On Mon, Jun 03, 2019 at 09:45:49AM +0200, Hans Verkuil wrote: >> On 6/3/19 6:32 AM, Cheng-Yi Chiang wrote: >>> From: Hans Verkuil >>> >>> Add support for HDMI hotplug and EDID notifiers, which is used to conv

Re: [PATCH 1/7] video: add HDMI state notifier support

2019-06-03 Thread Hans Verkuil
On 6/3/19 6:32 AM, Cheng-Yi Chiang wrote: > From: Hans Verkuil > > Add support for HDMI hotplug and EDID notifiers, which is used to convey > information from HDMI drivers to their CEC and audio counterparts. > > Based on an earlier version from Russell King: > > http

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-05-02 Thread Hans Verkuil
Hi Maxime, Apologies for the late reply, most if this thread happened when I was on vacation, and I missed that I should reply to it. Thank you for reminding me. Please let me know if I should reply to other mails in the discussion of this patch series. On 4/18/19 10:56 PM, Maxime Ripard wrote:

Re: [PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-05-02 Thread Hans Verkuil
Hi Maxime, On 4/17/19 9:54 AM, Maxime Ripard wrote: > V4L2 uses different fourcc's than DRM, and has a different set of formats. > For now, let's add the v4l2 fourcc's for the already existing formats. For this lib to be more useful for V4L2, would it be a good idea to add Bayer formats as well?

Re: [PATCH v2 2/2] drm/sun4i: dw-hdmi: Bit bang CEC on some SoCs

2019-04-12 Thread Hans Verkuil
On 4/1/19 9:15 PM, Jernej Skrabec wrote: > All DW HDMI controllers used by Allwinner SoCs include CEC controller. > However, due to additional logic put between CEC controller and pins, > CEC communication doesn't work well on some of them. > > Based on observations, it seems that only outgoing

Re: [PATCH v2 0/2] drm/sun4i: dw-hdmi: Improve CEC support

2019-04-12 Thread Hans Verkuil
Hi Jernej, On 4/1/19 9:15 PM, Jernej Skrabec wrote: > It turns out that additional logic between HDMI CEC controller and > pins on PHY on some Allwinner SoCs prevents proper communication. > It might be possible to fix it, but it's much easier and less error > prone to just directly drive pins

Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-04-11 Thread Hans Verkuil
On 3/22/19 8:55 PM, Nicolas Dufresne wrote: > Le mardi 19 mars 2019 à 22:57 +0100, Maxime Ripard a écrit : >> V4L2 uses different fourcc's than DRM, and has a different set of formats. >> For now, let's add the v4l2 fourcc's for the already existing formats. > > Hopefully I get the fixup right

Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-04-11 Thread Hans Verkuil
On 4/1/19 4:44 PM, Maxime Ripard wrote: > Hi Nicolas, > > On Fri, Mar 22, 2019 at 03:55:19PM -0400, Nicolas Dufresne wrote: >> Le mardi 19 mars 2019 à 22:57 +0100, Maxime Ripard a écrit : >>> V4L2 uses different fourcc's than DRM, and has a different set of formats. >>> For now, let's add the

Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-04-11 Thread Hans Verkuil
On 4/11/19 9:12 AM, Hans Verkuil wrote: > Hi Maxime, > > Some comments below... > > On 3/19/19 10:57 PM, Maxime Ripard wrote: >> V4L2 uses different fourcc's than DRM, and has a different set of formats. >> For now, let's add the v4l2 fourcc's for the already existin

Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-04-11 Thread Hans Verkuil
Hi Maxime, Some comments below... On 3/19/19 10:57 PM, Maxime Ripard wrote: > V4L2 uses different fourcc's than DRM, and has a different set of formats. > For now, let's add the v4l2 fourcc's for the already existing formats. > > Signed-off-by: Maxime Ripard > --- >

Re: [PATCHv2] omapdrm: hdmi4_cec: Fix CEC clock handling for PM

2019-03-27 Thread Hans Verkuil
() as suggested by Hans Verkuil . > This way the CEC clock gets only enabled when needed. This can be tested > by doing cec-ctl --playback to enable the CEC, and doing cec-ctl --clear > to disable it. > > Let's also fix the typo for "divider" in the comments while a

Re: [PATCH] omapdrm: hdmi4_cec: Fix CEC clock handling for PM

2019-03-26 Thread Hans Verkuil
() as suggested by Hans Verkuil . > This way the CEC clock gets only enabled when needed. This can be tested > by doing cec-ctl --playback to enable the CEC, and doing cec-ctl --clear > to disable it. > > Let's also fix the typo for "divider" in the comments while a

Re: CEC blocks idle on omap4

2019-03-25 Thread Hans Verkuil
On 3/25/19 5:21 PM, Tony Lindgren wrote: > * Hans Verkuil [190325 16:12]: >> On 3/25/19 4:55 PM, Laurent Pinchart wrote: >>>> The reality is that HDMI CEC and HDMI video are really independent of >>>> one another. So I wonder if it isn't better to explain t

Re: CEC blocks idle on omap4

2019-03-25 Thread Hans Verkuil
On 3/25/19 4:55 PM, Laurent Pinchart wrote: > Hi Hans, > > On Mon, Mar 25, 2019 at 04:51:57PM +0100, Hans Verkuil wrote: >> On 3/25/19 4:32 PM, Tony Lindgren wrote: >>> Hi Hans, >>> >>> Looks like CONFIG_OMAP4_DSS_HDMI_CEC=y blocks SoC core retention >

Re: CEC blocks idle on omap4

2019-03-25 Thread Hans Verkuil
Hi Tony, On 3/25/19 4:32 PM, Tony Lindgren wrote: > Hi Hans, > > Looks like CONFIG_OMAP4_DSS_HDMI_CEC=y blocks SoC core retention > idle on omap4 if selected. > > Should we maybe move hdmi4_cec_init() to hdmi_display_enable() > and hdmi4_cec_uninit() to hdmi_display_disable()? > > Or add some

Re: [PATCH] drm/tegra: Refactor CEC support

2018-12-11 Thread Hans Verkuil
On 12/10/18 6:07 PM, Hans Verkuil wrote: > On 12/10/18 5:36 PM, Hans Verkuil wrote: >> On 12/10/18 5:34 PM, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> Most of the CEC support code already lives in the "output" library code. >>> M

Re: [PATCH] drm/tegra: Refactor CEC support

2018-12-11 Thread Hans Verkuil
210 and later via the SOR. > > Signed-off-by: Thierry Reding Reviewed-by: Hans Verkuil Thanks! Hans > --- > drivers/gpu/drm/tegra/drm.h| 2 +- > drivers/gpu/drm/tegra/hdmi.c | 9 - > drivers/gpu/drm/tegra/output.c | 11 +-- > 3 files changed, 10

Re: [PATCH] drm/tegra: Refactor CEC support

2018-12-11 Thread Hans Verkuil
On 12/10/18 5:36 PM, Hans Verkuil wrote: > On 12/10/18 5:34 PM, Thierry Reding wrote: >> From: Thierry Reding >> >> Most of the CEC support code already lives in the "output" library code. >> Move registration and unregistration to the library code as

Re: [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

2018-12-03 Thread Hans Verkuil
On 12/03/2018 12:23 PM, Andrzej Hajda wrote: > On 30.11.2018 15:48, Hans Verkuil wrote: >> On 11/30/18 15:29, Ville Syrjälä wrote: >>> On Fri, Nov 30, 2018 at 03:20:59PM +0100, Andrzej Hajda wrote: >>>> Hi Ville, >>>> >>>> As Christoph can

Re: [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

2018-11-30 Thread Hans Verkuil
On 11/30/18 16:16, Ville Syrjälä wrote: > On Fri, Nov 30, 2018 at 03:48:00PM +0100, Hans Verkuil wrote: >> On 11/30/18 15:29, Ville Syrjälä wrote: >>> On Fri, Nov 30, 2018 at 03:20:59PM +0100, Andrzej Hajda wrote: >>>> Hi Ville, >>>> >>>> As Ch

Re: [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

2018-11-30 Thread Hans Verkuil
;>>>> color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects >>>>> the value ranges within the selected color encoding. The properties >>>>> are stored to drm_plane object to allow different set of supported >>>>&

Re: [v2, 1/8] drm: Add optional COLOR_ENCODING and COLOR_RANGE properties to drm_plane

2018-11-30 Thread Hans Verkuil
orted non RGB >>>> color encoding, for instance ITU-R BT.709 YCbCr. COLOR_RANGE selects >>>> the value ranges within the selected color encoding. The properties >>>> are stored to drm_plane object to allow different set of supported >>>> encodin

Re: [RFC] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-12 Thread Hans Verkuil
On 11/12/2018 03:41 AM, Anshuman Khandual wrote: > At present there are multiple places where invalid node number is encoded > as -1. Even though implicitly understood it is always better to have macros > in there. Replace these open encodings for an invalid node number with the > global macro

Re: [Intel-gfx] [v2 1/2] drm: Add colorspace property

2018-11-05 Thread Hans Verkuil
-...@lists.freedesktop.org; Syrjala, Ville ; Lankhorst, Maarten ; Hans Verkuil Subject: Re: [Intel-gfx] [v2 1/2] drm: Add colorspace property On Fri, Nov 02, 2018 at 10:19:10AM +0100, Maarten Lankhorst wrote: Op 31-10-18 om 13:05 schreef Uma Shankar: This patch adds a colorspace property enabling

Re: [PATCH] drm: Do not call drm_dp_cec_set_edid() while registering DP connectors

2018-10-11 Thread Hans Verkuil
ith just one DP port disconnected while reducing more than > 3sec in a machine with 4 DP ports disconnected. > > Cc: Hans Verkuil > Signed-off-by: José Roberto de Souza I acked this on Sep 25th, but it seems you missed that. Anyway: Acked-by: Hans Verkuil Regards, Ha

[PATCH] omapdrm/dss/hdmi4_cec.c: simplify clear_tx/rx_fifo functions

2018-10-08 Thread Hans Verkuil
Use REG_GET to avoid the temp variable. Add pr_err_once if hdmi_cec_clear_tx_fifo() fails in hdmi4_cec_irq(). Signed-off-by: Hans Verkuil --- Note: the FIFOs are cleared almost immediately (after just one try), so adding delays is overkill. --- diff --git a/drivers/gpu/drm/omapdrm/dss

Re: [PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count

2018-10-08 Thread Hans Verkuil
On 10/08/2018 02:47 PM, Tomi Valkeinen wrote: > On 04/10/18 12:09, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The HDMI_CEC_DBG_3 register does have a retransmit count, but you >> can't write to it, those bits are read-only. >> >> So drop the att

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Hans Verkuil
On 10/08/2018 02:52 PM, Tomi Valkeinen wrote: > > On 05/10/18 17:13, Hans Verkuil wrote: >> Tomi, >> >> Can you review this patch and the next? They should go to 4.20. >> This patch in particular is a nasty one, hard to reproduce. >> >> This patch shou

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Hans Verkuil
On 10/08/2018 02:45 PM, Tomi Valkeinen wrote: > Hi Hans, > > On 04/10/18 12:08, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The TX FIFO has to be cleared if the transmit failed due to e.g. >> a NACK condition, otherwise the hardware will keep

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-05 Thread Hans Verkuil
:08, Hans Verkuil wrote: > From: Hans Verkuil > > The TX FIFO has to be cleared if the transmit failed due to e.g. > a NACK condition, otherwise the hardware will keep trying to > transmit the message. > > An attempt was made to do this, but it was done after the call to >

[PATCHv2 0/6] cec/adv/cec-gpio: fixes and new status flags

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil This patch series replaces patches 1-3 of: https://www.spinics.net/lists/linux-media/msg141216.html Patches 4 & 5 of that series remain as-is and are omap4 bug fixes. This patch series can be applied to the media subsystem since it has no drm changes. Changes s

[PATCHv2 4/6] adv7842: when the EDID is cleared, unconfigure CEC as well

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil When there is no EDID the CEC adapter should be unconfigured as well. So call cec_phys_addr_invalidate() when this happens. Signed-off-by: Hans Verkuil --- drivers/media/i2c/adv7842.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c

[PATCHv2 2/6] cec: add new tx/rx status bits to detect aborts/timeouts

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil If the HDMI cable is disconnected or the CEC adapter is manually unconfigured, then all pending transmits and wait-for-replies are aborted. Signal this with new status bits (CEC_RX/TX_STATUS_ABORTED). If due to (usually) a driver bug a transmit never ends (i.e

[PATCHv2 6/6] cec-gpio: select correct Signal Free Time

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil If a receive is in progress or starts before the transmit has a chance, then lower the Signal Free Time of the upcoming transmit to no more than CEC_SIGNAL_FREE_TIME_NEW_INITIATOR. This is per the specification requirements. Signed-off-by: Hans Verkuil --- drivers/media

[PATCHv2 1/6] cec-core.rst: improve cec_transmit_done documentation

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil Clarify that calling cec_transmit_done can start a new transmit and that you should put the hardware in a state that allows for a new transmit before calling this function. Signed-off-by: Hans Verkuil --- Documentation/media/kapi/cec-core.rst | 4 1 file changed, 4

[PATCHv2 5/6] cec: fix the Signal Free Time calculation

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil The calculation of the Signal Free Time in the framework was not correct. If a message was received, then the next transmit should be considered a New Initiator and use a shorter SFT value. This was not done with the result that if both sides where continually sending

[PATCHv2 3/6] adv7604: when the EDID is cleared, unconfigure CEC as well

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil When there is no EDID the CEC adapter should be unconfigured as well. So call cec_phys_addr_invalidate() when this happens. Signed-off-by: Hans Verkuil --- drivers/media/i2c/adv7604.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c

[PATCH 1/5] cec: add new tx/rx status bits to detect aborts/timeouts

2018-10-04 Thread Hans Verkuil
From: Hans Verkuil If the HDMI cable is disconnected or the CEC adapter is manually unconfigured, then all pending transmits and wait-for-replies are aborted. Signal this with new status bits (CEC_RX/TX_STATUS_ABORTED). If due to (usually) a driver bug a transmit never ends (i.e

[PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count

2018-10-04 Thread Hans Verkuil
From: Hans Verkuil The HDMI_CEC_DBG_3 register does have a retransmit count, but you can't write to it, those bits are read-only. So drop the attempt to set the retransmit count, since it doesn't work. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 3 --- 1 file

[PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-04 Thread Hans Verkuil
From: Hans Verkuil The TX FIFO has to be cleared if the transmit failed due to e.g. a NACK condition, otherwise the hardware will keep trying to transmit the message. An attempt was made to do this, but it was done after the call to cec_transmit_done, which can cause a race condition since

[PATCH 2/5] adv7604: when the EDID is cleared, unconfigure CEC as well

2018-10-04 Thread Hans Verkuil
From: Hans Verkuil When there is no EDID the CEC adapter should be unconfigured as well. So call cec_phys_addr_invalidate() when this happens. Signed-off-by: Hans Verkuil --- drivers/media/i2c/adv7604.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c

[PATCH 0/5] cec/adv/omap: fixes and new status flags

2018-10-04 Thread Hans Verkuil
From: Hans Verkuil The first patch adds new status flags to indicate when a pending message is aborted because the CEC adapter is unconfigured, and when a transmit times out (this indicates a driver bug). The second and third patch fix a minor issue with the adv HDMI receivers: if the EDID goes

[PATCH 3/5] adv7842: when the EDID is cleared, unconfigure CEC as well

2018-10-04 Thread Hans Verkuil
From: Hans Verkuil When there is no EDID the CEC adapter should be unconfigured as well. So call cec_phys_addr_invalidate() when this happens. Signed-off-by: Hans Verkuil --- drivers/media/i2c/adv7842.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c

Re: [PATCH v3 04/18] video/hdmi: Constify infoframe passed to the pack functions

2018-10-02 Thread Hans Verkuil
t want to change all the >> drivers. >> >> v2: Deal with exynos churn >> Actually export the new funcs >> v3: Fix various documentation fails (Hans) > > Hans, any more concerns about this patch? Acked-by: Hans Verkuil Regards, Hans > >&

Re: [PATCH 1/2] drm: Do not call drm_dp_cec_set_edid() while registering DP connectors

2018-09-25 Thread Hans Verkuil
more than 3sec in a machine with 4 DP ports disconnected. Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks, this makes sense. Hans Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/drm_dp_cec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types

2018-09-21 Thread Hans Verkuil
On 09/21/18 16:01, Ville Syrjälä wrote: > On Fri, Sep 21, 2018 at 10:41:46AM +0200, Hans Verkuil wrote: >> On 09/20/18 20:51, Ville Syrjala wrote: >>> From: Ville Syrjälä >>> >>> We'll be wanting to send more than just infoframes over HDMI. So add an >>&

Re: [PATCH 05/18] video/hdmi: Add an enum for HDMI packet types

2018-09-21 Thread Hans Verkuil
Hans > > Cc: Thierry Reding > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville Syrjälä > --- > include/linux/hdmi.h | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/include/linux/hdmi.h b/include/lin

Re: [PATCH 07/18] video/hdmi: Handle the NTSC VBI infoframe

2018-09-21 Thread Hans Verkuil
om the spec, and totally untested. Do we have any driver that uses this? I would prefer to wait until someone actually need this. Regards, Hans > > Cc: Thierry Reding > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville Syrjä

Re: [PATCH 06/18] video/hdmi: Handle the MPEG Source infoframe

2018-09-21 Thread Hans Verkuil
implementation of this infoframe is not recommended due to unresolved issues. I don't think I've ever seen it either. It obviously doesn't hurt to have this code, but I prefer to wait until there are devices that actively set/use this infoframe. Regards, Hans > > Cc: Thierry Reding >

Re: [PATCH 04/18] video/hdmi: Constify infoframe passed to the pack functions

2018-09-21 Thread Hans Verkuil
> Actually export the new funcs > > Cc: Thierry Reding > Cc: Hans Verkuil > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville Syrjälä > --- > drivers/video/hdmi.c | 425 > +++ > include/linux/hdmi.h | 19 ++

Re: [PATCH 01/18] video/hdmi: Constify 'buffer' to the unpack functions

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > The unpack functions just read from the passed in buffer, > so make it const. > > Cc: Thierry Reding > Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks! Hans > Cc: linux-me...@vger.kernel.or

Re: [PATCH 02/18] video/hdmi: Pass buffer size to infoframe unpack functions

2018-09-21 Thread Hans Verkuil
ierry Reding > Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks, Hans > Cc: linux-me...@vger.kernel.org > Signed-off-by: Ville Syrjälä > --- > drivers/media/i2c/adv7511.c | 2 +- > drivers/media/i2c/adv7604.c | 2 +- > drivers/media/i2c/adv7842.c | 2 +- >

Re: [PATCH 03/18] video/hdmi: Constify infoframe passed to the log functions

2018-09-21 Thread Hans Verkuil
On 09/20/18 20:51, Ville Syrjala wrote: > From: Ville Syrjälä > > The log functions don't modify the passed in infoframe so make it const. > > Cc: Thierry Reding > Cc: Hans Verkuil Acked-by: Hans Verkuil Thanks, Hans > Cc: linux-me...@vger.kernel.org &

[PATCHv2 1/5] media: replace ADOBERGB by OPRGB

2018-09-14 Thread Hans Verkuil
-by: Hans Verkuil --- Changes in v2: Incorporated Mauro's suggestions: - Grouped the old ADOBERGB names together and use defines. - Mentioned that they might have to be removed in the future. --- .../media/videodev2.h.rst.exceptions | 6 +- .../media/common/v4l2-tpg/v4l2-tpg-colors.c

Re: [PATCH 1/5] media: replace ADOBERGB by OPRGB

2018-09-13 Thread Hans Verkuil
On 09/13/18 16:29, Mauro Carvalho Chehab wrote: > Em Thu, 13 Sep 2018 13:47:27 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> The CTA-861 standards have been updated to refer to opRGB instead >> of AdobeRGB. The official standard is

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Hans Verkuil
On 09/13/18 15:48, Russell King - ARM Linux wrote: > On Thu, Sep 13, 2018 at 03:33:20PM +0200, Hans Verkuil wrote: >> On 09/13/18 15:16, Daniel Vetter wrote: >>> On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote: >>>> Hi Hans, >>&

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-13 Thread Hans Verkuil
On 09/13/18 15:16, Daniel Vetter wrote: > On Thu, Sep 13, 2018 at 10:33:35AM +0100, Russell King - ARM Linux wrote: >> Hi Hans, >> >> I'll pick it up in due course. >> >> Thanks. >> >> On Tue, Sep 11, 2018 at 08:41:59AM +0200, Hans Verkuil wrot

[PATCH 3/5] hdmi.h: rename ADOBE_RGB to OPRGB and ADOBE_YCC to OPYCC

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil These names have been renamed in the CTA-861 standard due to trademark issues. Replace them here as well so they are in sync with the standard. Signed-off-by: Hans Verkuil --- drivers/media/i2c/adv7511.c | 4 ++-- drivers/media/v4l2-core/v4l2-dv-timings.c | 4

[PATCH 2/5] media colorspaces*.rst: rename AdobeRGB to opRGB

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil Drop all Adobe references and use the official opRGB standard instead. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/biblio.rst | 10 -- Documentation/media/uapi/v4l/colorspaces-defs.rst | 8 .../media/uapi/v4l/colorspaces

[PATCH 1/5] media: replace ADOBERGB by OPRGB

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil The CTA-861 standards have been updated to refer to opRGB instead of AdobeRGB. The official standard is in fact named opRGB, so switch to that. The two old defines referring to ADOBERGB in the public API are put under #ifndef __KERNEL__ and a comment mentions

[PATCH 5/5] drm/amd: rename ADOBE to OP

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil The CTA-861 standard renamed ADOBE to OP, so do the same to remain in sync with the standard. Signed-off-by: Hans Verkuil Cc: amd-...@lists.freedesktop.org --- drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 4 ++-- drivers/gpu/drm/amd/display/dc/core

[PATCH 0/5] Rename AdobeRGB to opRGB

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil This patch series replaces all AdobeRGB references by opRGB references. In November last year all references to the AdobeRGB colorspace were removed from the CTA-861 standards (all versions) and replaced with the corresponding international opRGB standard (IEC 61966-2-5) due

[PATCH 4/5] drm/bridge/synopsys/dw-hdmi.h: rename ADOBE to OP

2018-09-13 Thread Hans Verkuil
From: Hans Verkuil The CTA-861 standard renamed this from ADOBE to OP. Make the same change to sync with the standard. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge

Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-09-11 Thread Hans Verkuil
Russell (or someone else), can you Ack this patch? I'd like to get this for 4.20. Thanks! Hans On 08/27/2018 02:28 PM, Hans Verkuil wrote: > The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to > prevent the CEC framework from retrying the transmit. If the >

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-31 Thread Hans Verkuil
On 08/24/2018 04:59 PM, Alex Deucher wrote: > On Fri, Aug 24, 2018 at 3:20 AM Hans Verkuil wrote: >> >> On 08/23/2018 08:38 PM, Harry Wentland wrote: >>> On 2018-08-17 10:11 AM, Hans Verkuil wrote: >>>> From: Hans Verkuil >>>> >>>&

[PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only

2018-08-27 Thread Hans Verkuil
The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to prevent the CEC framework from retrying the transmit. If the transmit was successful, then don't set this flag. Found by running 'cec-compliance -A' on a beaglebone box. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/i2c/tda9950.c

Re: [PATCHv2 0/5] drm/nouveau+amdgpu: add DP CEC-Tunneling-over-AUX

2018-08-27 Thread Hans Verkuil
Sorry, this v2 patch series is a bit messy: my git-send-email failed at patch 3 for some reason, so I posted patches 3-5 manually, but I forgot to add 'v2' to the subject of patch 4/5 and for some reason patch 3 now appeared twice. The contents of the patches is correct, though :-) Regards,

[PATCHv2 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-27 Thread Hans Verkuil
Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. Signed-off-by: Hans Verkuil Acked-by: Alex Deucher Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 9 - .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 ++ 2 files changed

[PATCHv2 3/5] drm_dp_mst_topology: fix broken drm_dp_sideband_parse_remote_dpcd_read()

2018-08-27 Thread Hans Verkuil
When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the result is wrong due to a missing idx increment. This was never noticed since DP_REMOTE_DPCD_READ is currently not used, but if you enable it, then it is all wrong. Signed-off-by: Hans Verkuil Reviewed-by: Lyude Paul Acked

[PATCH 4/5] drm/nouveau: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-27 Thread Hans Verkuil
Add DisplayPort CEC-Tunneling-over-AUX support to nouveau. Signed-off-by: Hans Verkuil Reviewed-by: Lyude Paul Acked-by: Alex Deucher --- drivers/gpu/drm/nouveau/nouveau_connector.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau

[PATCHv2 3/5] drm_dp_mst_topology: fix broken drm_dp_sideband_parse_remote_dpcd_read()

2018-08-27 Thread Hans Verkuil
From: Hans Verkuil When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the result is wrong due to a missing idx increment. This was never noticed since DP_REMOTE_DPCD_READ is currently not used, but if you enable it, then it is all wrong. Signed-off-by: Hans Verkuil Reviewed

[PATCHv2 2/5] drm_dp_cec: add note about good MegaChips 2900 CEC support

2018-08-27 Thread Hans Verkuil
From: Hans Verkuil A big problem with DP CEC-Tunneling-over-AUX is that it is tricky to find adapters with a chipset that supports this AND where the manufacturer actually connected the HDMI CEC line to the chipset. Add a mention of the MegaChips 2900 chipset which seems to support this feature

[PATCHv2 1/5] drm_dp_cec: check that aux has a transfer function

2018-08-27 Thread Hans Verkuil
From: Hans Verkuil If aux->transfer == NULL, then just return without doing anything. In that case the function is likely called for a non-(e)DP connector. This never happened for the i915 driver, but the nouveau and amdgpu drivers need this check. The alternative would be to add this ch

[PATCHv2 0/5] drm/nouveau+amdgpu: add DP CEC-Tunneling-over-AUX

2018-08-27 Thread Hans Verkuil
From: Hans Verkuil Now that the DisplayPort CEC-Tunneling-over-AUX drm+i915 support has been merged in the mainline kernel it is time to roll this out to nouveau and amdgpu as well. The first patch is required for this: it adds checks that the drm_dp_cec functions are called with a working aux

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-24 Thread Hans Verkuil
On 08/23/2018 08:38 PM, Harry Wentland wrote: > On 2018-08-17 10:11 AM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. >> >> Signed-off-by: Hans Verkuil >> Acked-by: Alex Deucher >>

Re: [PATCH (repost) 1/5] drm_dp_cec: check that aux has a transfer function

2018-08-20 Thread Hans Verkuil
On 08/20/2018 08:51 PM, Lyude Paul wrote: > On Fri, 2018-08-17 at 16:11 +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> If aux->transfer == NULL, then just return without doing >> anything. In that case the function is likely called for >> a non-(e)DP

Re: [PATCH (repost) 3/5] drm_dp_mst_topology: fix broken drm_dp_sideband_parse_remote_dpcd_read()

2018-08-20 Thread Hans Verkuil
t why not), but you are free to pick it up if you want. Regards, Hans > > On Fri, 2018-08-17 at 16:11 +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the >> result is wrong due to a

[PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-17 Thread Hans Verkuil
From: Hans Verkuil Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. Signed-off-by: Hans Verkuil Acked-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++-- .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 ++ 2 files changed, 13

[PATCH (repost) 3/5] drm_dp_mst_topology: fix broken drm_dp_sideband_parse_remote_dpcd_read()

2018-08-17 Thread Hans Verkuil
From: Hans Verkuil When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the result is wrong due to a missing idx increment. This was never noticed since DP_REMOTE_DPCD_READ is currently not used, but if you enable it, then it is all wrong. Signed-off-by: Hans Verkuil --- drivers/gpu

[PATCH (repost) 2/5] drm_dp_cec: add note about good MegaChips 2900 CEC support

2018-08-17 Thread Hans Verkuil
From: Hans Verkuil A big problem with DP CEC-Tunneling-over-AUX is that it is tricky to find adapters with a chipset that supports this AND where the manufacturer actually connected the HDMI CEC line to the chipset. Add a mention of the MegaChips 2900 chipset which seems to support this feature

[PATCH (repost) 0/5] drm/nouveau+amdgpu: add DP CEC-Tunneling-over-AUX (repost)

2018-08-17 Thread Hans Verkuil
From: Hans Verkuil Repost because I wasn't a member of the nouveau mailinglist the first time around and this series was blocked. I also updated this cover letter for the part about the amdgpu patch after receiving feedback from Alex Deucher. The patches are unchanged (except for adding Alex

[PATCH (repost) 1/5] drm_dp_cec: check that aux has a transfer function

2018-08-17 Thread Hans Verkuil
From: Hans Verkuil If aux->transfer == NULL, then just return without doing anything. In that case the function is likely called for a non-(e)DP connector. This never happened for the i915 driver, but the nouveau and amdgpu drivers need this check. The alternative would be to add this ch

[PATCH (repost) 4/5] drm/nouveau: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-17 Thread Hans Verkuil
From: Hans Verkuil Add DisplayPort CEC-Tunneling-over-AUX support to nouveau. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/nouveau/nouveau_connector.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b

[PATCH 4/5] drm/nouveau: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-16 Thread Hans Verkuil
From: Hans Verkuil Add DisplayPort CEC-Tunneling-over-AUX support to nouveau. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/nouveau/nouveau_connector.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b

[PATCH 2/5] drm_dp_cec: add note about good MegaChips 2900 CEC support

2018-08-16 Thread Hans Verkuil
From: Hans Verkuil A big problem with DP CEC-Tunneling-over-AUX is that it is tricky to find adapters with a chipset that supports this AND where the manufacturer actually connected the HDMI CEC line to the chipset. Add a mention of the MegaChips 2900 chipset which seems to support this feature

[PATCH 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-16 Thread Hans Verkuil
From: Hans Verkuil Add DisplayPort CEC-Tunneling-over-AUX support to amdgpu. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 +++-- .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 ++ 2 files changed, 13 insertions(+), 2 deletions

[PATCH 0/5] drm/nouveau+amdgpu: add DP CEC-Tunneling-over-AUX

2018-08-16 Thread Hans Verkuil
From: Hans Verkuil Now that the DisplayPort CEC-Tunneling-over-AUX drm+i915 support has been merged in the mainline kernel it is time to roll this out to nouveau and amdgpu as well. I combined both in the same patch series since both depend on the same first patch, the comments in this cover

[PATCH 3/5] drm_dp_mst_topology: fix broken drm_dp_sideband_parse_remote_dpcd_read()

2018-08-16 Thread Hans Verkuil
From: Hans Verkuil When parsing the reply of a DP_REMOTE_DPCD_READ DPCD command the result is wrong due to a missing idx increment. This was never noticed since DP_REMOTE_DPCD_READ is currently not used, but if you enable it, then it is all wrong. Signed-off-by: Hans Verkuil --- drivers/gpu

[PATCH 1/5] drm_dp_cec: check that aux has a transfer function

2018-08-16 Thread Hans Verkuil
From: Hans Verkuil If aux->transfer == NULL, then just return without doing anything. In that case the function is likely called for a non-(e)DP connector. This never happened for the i915 driver, but the nouveau and amdgpu drivers need this check. The alternative would be to add this ch

[PATCH for v4.19] drm_dp_cec.c: fix formatting typo: %pdH -> %phD

2018-07-24 Thread Hans Verkuil
This caused a kernel oops since %pdH interpreted the pointer as a struct file. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/drm_dp_cec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_cec.c b/drivers/gpu/drm/drm_dp_cec.c index 87b67cc1ea58

Re: [PATCH v8 0/6] Add ChromeOS EC CEC Support

2018-07-12 Thread Hans Verkuil
On 12/07/18 14:42, Neil Armstrong wrote: > Hi Lee, > > On 12/07/2018 14:26, Lee Jones wrote: >> On Wed, 04 Jul 2018, Neil Armstrong wrote: >> >>> Hi All, >>> >>> The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support >>> through it's Embedded Controller, to enable the Linux CEC

[PATCHv10 2/3] drm-kms-helpers.rst: document the DP CEC helpers

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Document the Display Port CEC helper functions. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- Documentation/gpu/drm-kms-helpers.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms

[PATCHv10 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This adds support for the DisplayPort CEC-Tunneling-over-AUX feature that is part of the DisplayPort 1.3 standard. Unfortunately, not all DisplayPort/USB-C to HDMI adapters with a chip that has this capability actually hook up the CEC pin, so even though a CEC device

[PATCHv10 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Implement support for this DisplayPort feature. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu

[PATCHv10 0/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX feature. This patch series is based on top of drm-intel-next. The v10 is identical to v9, except it is rebased to drm-intel-next (v9 didn't apply cleanly) and two alignment warnings have been fixed

[PATCHv9 2/3] drm-kms-helpers.rst: document the DP CEC helpers

2018-07-11 Thread Hans Verkuil
From: Hans Verkuil Document the Display Port CEC helper functions. Signed-off-by: Hans Verkuil Reviewed-by: Ville Syrjälä --- Documentation/gpu/drm-kms-helpers.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-kms

  1   2   3   4   5   6   7   8   9   10   >