Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL.

2019-06-21 Thread Harry Wentland
blems for Rockchip with the Analogix bridge. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/drm_debugfs_crc.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/drm_debugfs_crc.c > b/drivers/gpu/drm/drm_debugfs_crc.c > index e20adef9d6

Re: [PATCH] drm: actually remove the newline for CRC source name.

2019-06-06 Thread Harry Wentland
chen Zhang wrote: > 'n-1' is the index to replace the newline character of CRC source name. > Add here: v2: Update patch subject (Sam) > Cc: Leo Li > Cc: Harry Wentland > Signed-off-by: Dingchen Zhang > --- > drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- > 1 file cha

Re: [PATCH][next] drm/amd/display: remove redundant assignment to status

2019-05-31 Thread Harry Wentland
On 2019-05-30 12:12 p.m., Colin King wrote: > From: Colin Ian King > > The variable status is initialized with a value that is never read > and status is reassigned several statements later. This initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") >

Re: [PATCH 0/2] drm/amd/display: Add HDR output metadata support for amdgpu

2019-05-29 Thread Harry Wentland
ince that's all the > DRM interface supports. It requires a modeset for entering and exiting HDR > but the metadata can be changed without one. > > Cc: Harry Wentland > Series is Reviewed-by: Harry Wentland Harry > Nicholas Kazlauskas (2): > drm/amd/display: Expo

[PATCH] drm/connector: Add doc for content_protection tri-state

2019-05-17 Thread Harry Wentland
It was there all along in the patch description when this change was introduced but it would be helpful to have the same documented in the code. Signed-off-by: Harry Wentland Cc: Sean Paul Cc: Sean Paul Cc: Bhawanpreet Lakha --- drivers/gpu/drm/drm_connector.c | 9 + 1 file changed

Re: [PATCH] drm/amd/display: Allow faking displays as VRR capable.

2019-05-17 Thread Harry Wentland
On 2019-04-30 3:56 p.m., Mario Kleiner wrote: > [CAUTION: External Email] > > On Tue, Apr 30, 2019 at 2:22 PM Kazlauskas, Nicholas > wrote: >> >> On 4/30/19 3:44 AM, Michel Dänzer wrote: >>> [CAUTION: External Email] >>> >>> On 2019-04-30 9:37 a.m., Mario Kleiner wrote: Allow to detect

2019 Xorg Election Results

2019-05-08 Thread Harry Wentland
this into account and forced voters to rank every candidate. Due to the lack of controversy about the candidates we don't expect this to have had any impact on the final results. Thanks, Harry Wentland, On behalf of the Xorg Elections Committee

[PATCH v3] Allow fd.o to join forces with X.Org

2018-11-08 Thread Harry Wentland
The leadership of freedesktop.org (fd.o) has recently expressed interest in having an elected governing body. Given the tight connection between fd.o and X.Org and the fact that X.Org has such a governing body it seemed obvious to consider extending X.Org's mandate to fd.o. Quite a bit of

[RFC] Allow fd.o to join forces with X.Org

2018-10-15 Thread Harry Wentland
The leadership of freedesktop.org (fd.o) has recently expressed interest in having an elected governing body. Given the tight connection between fd.o and X.Org and the fact that X.Org has such a governing body it seemed obvious to consider extending X.Org's mandate to fd.o. Quite a bit of

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Harry Wentland
On 2018-10-11 04:56 PM, Kazlauskas, Nicholas wrote: > On 10/11/2018 04:39 PM, Harry Wentland wrote: >> On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: >>> Support for AMDGPU specific FreeSync properties and ioctls are dropped >>> from amdgpu_dm in favor of supportin

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Harry Wentland
On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: > Support for AMDGPU specific FreeSync properties and ioctls are dropped > from amdgpu_dm in favor of supporting drm variable refresh rate > properties. > > The drm vrr_capable property is now attached to any DP/HDMI connector. > Its value is

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Harry Wentland
On 2018-10-03 04:25 AM, Mike Lothian wrote: > Hi > > I'm curious to know whether this will/could work over PRIME > I don't see why this shouldn't work over PRIME as long as the presenting GPU supports the new variable refresh rate API, but I know very little about prime, so maybe someone else

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Harry Wentland
On 2018-10-03 04:41 AM, Daniel Vetter wrote: > On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >> >> >> On 2018-10-01 03:15 AM, Daniel Vetter wrote: >>> On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas Kazlauskas wrote: >>>> These pa

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Harry Wentland
On 2018-10-03 02:35 PM, Manasi Navare wrote: > On Wed, Oct 03, 2018 at 10:41:20AM +0200, Daniel Vetter wrote: >> On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >>> >>> >>> On 2018-10-01 03:15 AM, Daniel Vetter wrote: >>>> On

Re: [PATCH 20/21] drm/todo: Add some cleanup tasks

2018-10-05 Thread Harry Wentland
On 2018-10-04 04:24 PM, Daniel Vetter wrote: > Motivated by review comments from Ville > > Cc: Ville Syrjälä > Cc: Sean Paul > Signed-off-by: Daniel Vetter Acked-by: Harry Wentland Harry > --- > Documentation/gpu/todo.rst | 10 ++ > 1 file changed, 10 inser

Re: [PATCH 01/21] drm/amdgpu: Remove default best_encoder hook from DC

2018-10-05 Thread Harry Wentland
1a6481 ("drm/amd/display: Use DRM helper for > best_encoder"). > > Cc: Ville Syrjälä > Signed-off-by: Daniel Vetter > Cc: Alex Deucher > Cc: Harry Wentland > Cc: Andrey Grodzovsky > Cc: Tony Cheng > Cc: "Leo (Sunpeng) Li" > Cc: Shirish S

Re: [PATCH v2] drm/amd/display: Use proper enums in process_channel_reply

2018-10-02 Thread Harry Wentland
~ ^~~ >>> >>> The current enum is incorrect, it should be from aux_transaction_reply, >>> so use AUX_TRANSACTION_REPLY_HPD_DISCON. >>> >>> Reported-by: Nick Desaulniers >>> Suggested-by: Nick Desaulniers >>&g

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-02 Thread Harry Wentland
On 2018-10-01 03:15 AM, Daniel Vetter wrote: > On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas Kazlauskas wrote: >> These patches are part of a proposed new interface for supporting variable >> refresh rate via DRM properties. >> >> === Changes from v1 === >> >> For drm: >> >> * The

Re: [PATCH] drm/amd/display: Change status's type in aux_reply_transaction_data

2018-09-27 Thread Harry Wentland
On 2018-09-24 06:22 PM, Nathan Chancellor wrote: > On Mon, Sep 24, 2018 at 03:07:16PM -0700, Nick Desaulniers wrote: >> On Fri, Sep 21, 2018 at 2:55 PM Nathan Chancellor >> wrote: >>> >>> Clang warns when one enumerated type is implicitly converted to another. >>> >>>

Re: [PATCH v2 1/6] drm/dp_mst: Introduce drm_dp_mst_connector_atomic_check()

2018-09-20 Thread Harry Wentland
function that DRM drivers can call in order to have CRTC enabling > commits fail automatically if the MST port driving the connector no > longer exists. We'll also be able to expand upon this later as well once > we add MST fallback retraining support. > > Changes since v1: >

Re: [PATCH 6/6] drm/amdgpu/dm/mst: Use drm_dp_mst_connector_atomic_check()

2018-09-20 Thread Harry Wentland
only atomic DRM driver without the > ->best_encoder() bug is amdgpu. Congrats AMD! > > Signed-off-by: Lyude Paul Reviewed-by: Harry Wentland Harry > --- > .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 12 > 1 file changed, 12 insertions(+) > >

Re: [PATCH 1/6] drm/dp_mst: Introduce drm_dp_mst_connector_atomic_check()

2018-09-20 Thread Harry Wentland
gt; Cc: sta...@vger.kernel.org This does seem like a saner way to handle the case when the MST connector is gone. As this doesn't currently seem to affect amdgpu directly and I therefore might miss something I'll leave the RB to someone else, but you have my Acked-by: Harry Wentland Harry > -

Re: [PATCH 2/2] drm/amdgpu: Use per-device driver_features to disable atomic

2018-09-20 Thread Harry Wentland
On 2018-09-13 12:31 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Disable atomic on a per-device basis instead of for all devices. > Made possible by the new device.driver_features thing. > > Cc: Alex Deucher > Cc: "Christian König" > Cc: "David

Re: EVoC Program

2018-09-20 Thread Harry Wentland
Adding e...@foundation.x.org and Trevor. He or someone else on the evoc list can probably point you in the right direction. Harry On 2018-09-20 03:06 AM, Sidharth Bansal wrote: > Hi > I want to contribute towards XOrg for EVoC. Can anyone guide me? > Thanks > Sidharth Bansal > > >

Re: [PATCH 1/9] drm: Add variable refresh rate properties to DRM connector

2018-09-11 Thread Harry Wentland
On 2018-09-11 01:56 PM, Ville Syrjälä wrote: > On Tue, Sep 11, 2018 at 01:36:01PM -0400, Kazlauskas, Nicholas wrote: >> On 09/11/2018 12:31 PM, Ville Syrjälä wrote: >>> On Tue, Sep 11, 2018 at 07:22:43PM +0300, Ville Syrjälä wrote: On Tue, Sep 11, 2018 at 12:13:25PM -0400, Nicholas Kazlauskas

Re: [PATCH v2 08/23] drm/dsc: Define VESA Display Stream Compression Capabilities

2018-08-23 Thread Harry Wentland
gt; * Define DSC 1.2 parameters (Manasi) > * Use DSC_NUM_BUF_RANGES (Manasi) > * Call it drm_dsc_config (Manasi) > > Cc: dri-devel@lists.freedesktop.org > Cc: Jani Nikula > Cc: Ville Syrjala > Cc: Anusha Srivatsa > Cc: Harry Wentland > Signed-off-by: Manasi

Re: [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-08-23 Thread Harry Wentland
ence to added kernel-docs in Documentation/gpu/drm-kms-helpers.rst > (Daniel Vetter) > > v2: > * Add EXPORT_SYMBOL for the drm functions (Manasi) > > Cc: dri-devel@lists.freedesktop.org > Cc: Jani Nikula > Cc: Ville Syrjala > Cc: Anusha Srivatsa > Cc: Harry Wen

Re: [PATCH v2 07/23] drm/dsc: Define Display Stream Compression PPS infoframe

2018-08-23 Thread Harry Wentland
frame syntax elements are taken from DSC 1.2 specification > from VESA. > > Cc: Gaurav K Singh > Cc: dri-devel@lists.freedesktop.org > Cc: Jani Nikula > Cc: Ville Syrjala > Cc: Anusha Srivatsa > Cc: Harry Wentland > Signed-off-by: Manasi Navare Looks like this

Re: [PATCH (repost) 5/5] drm/amdgpu: add DisplayPort CEC-Tunneling-over-AUX support

2018-08-23 Thread Harry Wentland
gt; drm_kms_helper_hotplug_event(dev); > } > } > + > if ((dc_link->cur_link_settings.lane_count != LANE_COUNT_UNKNOWN) || > - (dc_link->type == dc_connection_mst_branch)) > + (dc_link->type == dc_connection_mst_branch)) { >

Re: [PATCH] drm/amd/display: add missing void parameter to dc_create_transfer_func

2018-07-31 Thread Harry Wentland
On 2018-07-31 06:42 AM, Colin King wrote: > From: Colin Ian King > > Add a missing void parameter to function dc_create_transfer_func, fixes > sparse warning: > > warning: non-ANSI function declaration of function 'dc_create_transfer_func' > > Signed-off-by: Colin Ian K

Re: [PATCH 00/10] Add helper for plane reset

2018-07-24 Thread Harry Wentland
ble a core property and > observe it doesn't have a proper default value. > > Tested with mali-dp the other drivers are just built-tested. > For some reason I lost 02/10 hence I'm replying to the cover letter. Patches 1 & 2 are Reviewed-by: Harry Wentland Harry

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-16 Thread Harry Wentland
On 2018-07-15 10:36 AM, Alex Deucher wrote: > On Sat, Jul 14, 2018 at 12:31 PM, Takashi Iwai wrote: >> On Sat, 14 Jul 2018 14:03:26 +0200, >> jimqu wrote: >>> >>> >>> >>> 在 2018/7/13 23:07, Takashi Iwai 写道: On Wed, 11 Jul 2018 13:12:01 +0200, Takashi Iwai wrote: > And the forced

Re: [PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows

2018-07-04 Thread Harry Wentland
On 2018-07-04 01:54 PM, Gustavo A. R. Silva wrote: > > > On 07/04/2018 12:51 PM, Harry Wentland wrote: > [..] >>>> >>>> @@ -145,8 +145,8 @@ static bool calculate_fb_and_fractional_fb_divider( >>>> * of fractional feedback decimal poi

Re: [PATCH] drm/amd/display: Use 2-factor allocator calls

2018-07-04 Thread Harry Wentland
On 2018-07-04 01:27 PM, Kees Cook wrote: > As already done treewide, switch from open-coded multiplication to > 2-factor allocation helper. > > Signed-off-by: Kees Cook Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 8

Re: [PATCH] drm/amd/display/dc/dce: Fix multiple potential integer overflows

2018-07-04 Thread Harry Wentland
calc_pll_cs->fract_fb_divider_precision_factor; > > This should be 5ULL, as the commit log says, otherwise it's still only > 32 bits on 32-bit platforms. > Agreed. Otherwise this looks good. With that fixed this patch is Reviewed-by: Harry Wentland Harry > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/amd/display: off by one in find_irq_source_info()

2018-07-04 Thread Harry Wentland
r (v2)") > Signed-off-by: Dan Carpenter Reviewed-by: Harry Wentland Harry > > diff --git a/drivers/gpu/drm/amd/display/dc/irq/irq_service.c > b/drivers/gpu/drm/amd/display/dc/irq/irq_service.c > index dcdfa0f01551..604bea01fc13 100644 > --- a/drivers/gpu/drm/amd/disp

Re: [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Harry Wentland
On 2018-06-26 11:01 AM, Harry Wentland wrote: > On 2018-06-15 03:52 PM, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> To pick the correct MST encoder i915 wants to know which crtc is going >> to be feeding us. To that end let's pass the crtc to the .best_encoder()

Re: [PATCH] drm: Pass crtc to .best_encoder()

2018-06-26 Thread Harry Wentland
n the amdgpu/radeon drivers. None of > the other drivers have such internal uses. The other callers > (crtc_helper, atomic_helper, fb_helper) will pass in the proper crtc. > but no one besides i915 will currently look at it. > > Cc: Alex Deucher > Cc: "Christian

Re: [PATCH] drm/amd/display: don't initialize result

2018-06-26 Thread Harry Wentland
; initialization. > > Signed-off-by: Stefan Agner Thanks for the patch. Reviewed-by: Harry Wentland Ill merge this today. Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm

Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

2018-06-22 Thread Harry Wentland
> > So, we fix this by counting the number of CRTCs this atomic commit disabled > early on in the function before their atomic states have been freed, then use > that count later to do the appropriate number of RPM puts at the end of the > function. > > Fixes: 970

Re: [PATCH 1/2] amdgpu: display: use modern ktime accessors

2018-06-18 Thread Harry Wentland
On 2018-06-18 11:35 AM, Arnd Bergmann wrote: > getrawmonotonic64() is deprecated because of the nonstandard naming. > > The replacement functions ktime_get_raw_ns() also simplifies the callers. > > Signed-off-by: Arnd Bergmann Reviewed-by: Harry Wentland Harry > --- >

Re: [PATCH 2/3] drm: Print bad user modes

2018-06-12 Thread Harry Wentland
On 2018-06-11 03:34 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Print out the modeline when we reject a bad user mode. Avoids having to > guess why it was rejected. > > Signed-off-by: Ville Syrjälä Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/

Re: [PATCH 1/3] drm/atomic: Improve debug messages

2018-06-12 Thread Harry Wentland
On 2018-06-11 03:34 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > Print the id/name of the object we're dealing with. Makes it easier to > figure out what's going on. Also toss in a few extra debug prints that > might be useful. > > Signed-off-by: Ville Syrjälä

Re: [PATCH] drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()

2018-06-05 Thread Harry Wentland
is painfully obvious from the fact that we missed that with the DC driver. That said, from a cursory look at runtime_pm.txt, this looks right. Reviewed-by: Harry Wentland I'll pull this in through the amd-stg tree. > --- > As a note, I'm not entirely happy with this fix and I wouldn'

Re: [PATCH v2 0/4] DRM helpers for Display Stream Compression PPS infoframes

2018-05-16 Thread Harry Wentland
l@lists.freedesktop.org > Cc: Jani Nikula <jani.nik...@linux.intel.com> > Cc: Ville Syrjala <ville.syrj...@linux.intel.com> > Cc: Anusha Srivatsa <anusha.sriva...@intel.com> With my comments for patch 2 and 3 addressed patches 1-3 are Reviewed-by: Harry Wentland <har

Re: [PATCH v2 3/4] drm/dsc: Define VESA Display Stream Compression Capabilities

2018-05-16 Thread Harry Wentland
On 2018-05-14 10:05 PM, Manasi Navare wrote: > From: Gaurav K Singh > > This defines all the DSC parameters as per the VESA DSC spec > that will be required for DSC encoder/decoder > > v2: Define this struct in DRM (From Manasi) > * Changed the data types to u8/u16

Re: [PATCH v2 2/4] drm/dsc: Define Display Stream Compression PPS infoframe

2018-05-16 Thread Harry Wentland
On 2018-05-14 10:05 PM, Manasi Navare wrote: > This patch defines a new header file for all the DSC 1.2 structures > and creates a structure for PPS infoframe which will be used to send > picture parameter set secondary data packet for display stream compression. > All the PPS infoframe syntax

Re: [PATCH 1/3] drm/connector: Add generic underscan properties

2018-05-07 Thread Harry Wentland
On 2018-05-07 12:19 PM, Boris Brezillon wrote: > On Mon, 7 May 2018 18:01:44 +0300 > Ville Syrjälä wrote: > >> On Mon, May 07, 2018 at 04:44:32PM +0200, Boris Brezillon wrote: >>> We have 3 drivers defining the "underscan", "underscan hborder" and >>> "underscan

Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc

2018-05-02 Thread Harry Wentland
order violation") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks like i goofed. Thanks for fixing this. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file cha

Re: [REGRESSION] drm/amd/dc: Add dc display driver (v2)

2018-04-30 Thread Harry Wentland
it was found the following commit introduced the bug: > > > commit 4562236b3bc0a28aeb6ee93b2d8a849a4c4e1c7c > Author: Harry Wentland <harry.wentl...@amd.com> > Date:   Tue Sep 12 15:58:20 2017 -0400 > >     drm/amd/dc: Add dc display driver (v2) > > > The regression

Re: [PATCH] drm/amd/display: Remove erroneous if statement in gamma set

2018-04-26 Thread Harry Wentland
619aa9176aeb05ad630013429b4 > Author: Leo (Sunpeng) Li <sunpeng...@amd.com> > Date: Fri Feb 2 10:18:56 2018 -0500 > > drm/amd/display: Hookup color management functions Missing SOB? With that fixed this is Reviewed-by: Harry Wentland <harry.wentl...@amd

Re: RFC for a render API to support adaptive sync and VRR

2018-04-24 Thread Harry Wentland
On 2018-04-24 08:09 AM, Daniel Vetter wrote: > On Mon, Apr 23, 2018 at 02:19:44PM -0700, Manasi Navare wrote: >> On Mon, Apr 23, 2018 at 10:40:06AM -0400, Harry Wentland wrote: >>> On 2018-04-20 04:32 PM, Manasi Navare wrote: >>>> On Wed, Apr 18, 2018 at 09:39:0

Re: [PATCH] drm/admgpu: fix mode_valid's return type

2018-04-24 Thread Harry Wentland
the driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> amd-gfx mailing list should be sufficient for changes like these. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c| 8

Re: RFC for a render API to support adaptive sync and VRR

2018-04-23 Thread Harry Wentland
On 2018-04-20 04:32 PM, Manasi Navare wrote: > On Wed, Apr 18, 2018 at 09:39:02AM +0200, Daniel Vetter wrote: >> On Wed, Apr 18, 2018 at 5:58 AM, Keith Packard wrote: >>> Michel Dänzer writes: Time-based presentation seems to be the right approach for

Re: [PATCH] drm/amd/display: Disallow enabling CRTC without primary plane with FB

2018-04-19 Thread Harry Wentland
On 2018-04-19 03:43 AM, Michel Dänzer wrote: > > [ Dropping stable@ (fixes with Cc: stable are picked up for stable > branches once they land in Linus' tree, there's no point sending them to > stable@ during review), adding dri-devel ] > > On 2018-04-18 10:26 PM, Ha

Re: [PATCH i-g-t] [RFC] CONTRIBUTING: commit rights docs

2018-04-13 Thread Harry Wentland
shbar.org> > Acked-by: Eric Anholt <e...@anholt.net> > Acked-by: Gustavo Padovan <gust...@padovan.org> > Acked-by: Petri Latvala <petri.latv...@intel.com> Acked-by: Harry Wentland <harry.wentl...@amd.com> Harry > Cc: Alex Deucher <alexander.deuc...@a

Re: RFC for a render API to support adaptive sync and VRR

2018-04-13 Thread Harry Wentland
e discussion. Find my comments below: >>>> On Mon, Apr 09, 2018 at 04:00:21PM -0400, Harry Wentland wrote: >>>>> On 2018-04-09 03:56 PM, Harry Wentland wrote: >>>>>> >>>>>> === A DRM render API to support variable refresh rates === >

Re: RFC for a render API to support adaptive sync and VRR

2018-04-13 Thread Harry Wentland
On 2018-04-13 12:04 PM, Daniel Vetter wrote: > On Mon, Apr 09, 2018 at 04:00:21PM -0400, Harry Wentland wrote: >> Adding dri-devel, which I should've included from the start. > > Top posting, because I'm lazy and was out sick ... > > Few observations: > - Stéphane has a

Re: RFC for a render API to support adaptive sync and VRR

2018-04-12 Thread Harry Wentland
On 2018-04-12 07:39 AM, Nicolai Hähnle wrote: > On 12.04.2018 01:30, Cyr, Aric wrote: >>> At least with VDPAU, video players are already explicitly specifying the >>> target presentation time, so no changes should be required at that >>> level. Don't know about other video APIs. >>> >>> The X11

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
On 2018-04-10 07:44 AM, Chris Wilson wrote: > Quoting Christian König (2018-04-10 07:45:04) >> Am 09.04.2018 um 23:45 schrieb Manasi Navare: >>> Properties that you mentioned above that the UMD can set before kernel can >>> enable VRR functionality >>> *bool vrr_enable or vrr_compatible >>>

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
On 2018-04-10 01:52 PM, Harry Wentland wrote: > On 2018-04-10 12:37 PM, Nicolai Hähnle wrote: >> On 10.04.2018 18:26, Cyr, Aric wrote: >>> That presentation time doesn’t need to come to kernel as such and actually >>> is fine as-is completely decoupled f

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
On 2018-04-10 12:37 PM, Nicolai Hähnle wrote: > On 10.04.2018 18:26, Cyr, Aric wrote: >> That presentation time doesn’t need to come to kernel as such and actually >> is fine as-is completely decoupled from adaptive sync.  As long as the video >> player provides the new target_frame_duration_ns

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
On 2018-04-10 03:37 AM, Michel Dänzer wrote: > On 2018-04-10 08:45 AM, Christian König wrote: >> Am 09.04.2018 um 23:45 schrieb Manasi Navare: >>> Thanks for initiating the discussion. Find my comments below: >>> On Mon, Apr 09, 2018 at 04:00:21PM -0400, Harry Wentland w

Re: RFC for a render API to support adaptive sync and VRR

2018-04-10 Thread Harry Wentland
Adding Anthony and Aric who've been working on Freesync with DC on other OSes for a while. On 2018-04-09 05:45 PM, Manasi Navare wrote: > Thanks for initiating the discussion. Find my comments below: > > On Mon, Apr 09, 2018 at 04:00:21PM -0400, Harry Wentland wrote: >> Adding d

Re: RFC for a render API to support adaptive sync and VRR

2018-04-09 Thread Harry Wentland
Adding dri-devel, which I should've included from the start. On 2018-04-09 03:56 PM, Harry Wentland wrote: > === What is adaptive sync and VRR? === > > Adaptive sync has been part of the DisplayPort spec for a while now and > allows graphics adapters to drive displays with varying f

Re: [PATCH 04/13] drm/amdgpu/dc: Stop updating plane->fb

2018-04-05 Thread Harry Wentland
Deucher <alexander.deuc...@amd.com> >> Cc: "Christian König" <christian.koe...@amd.com> >> Cc: "David (ChunMing) Zhou" <david1.z...@amd.com> >> Cc: Harry Wentland <harry.wentl...@amd.com> >> Cc: amd-...@lists.freedesktop.org >

Re: [PATCH] drm/amd/display: fix spelling mistake: "Usupported" -> "Unsupported"

2018-04-02 Thread Harry Wentland
On 2018-03-30 12:00 PM, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in DRM_ERROR error message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Harry Wentland <

Re: [PATCH 16/23] drm/amdgpu/dc: Stop updating plane->fb

2018-03-23 Thread Harry Wentland
ristian.koe...@amd.com> > Cc: "David (ChunMing) Zhou" <david1.z...@amd.com> > Cc: Harry Wentland <harry.wentl...@amd.com> > Cc: amd-...@lists.freedesktop.org > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Reviewed-by: Harry Wentland <

Re: [PATCH 00/23] drm: Eliminate plane->fb/crtc usage for atomic drivers

2018-03-22 Thread Harry Wentland
On 2018-03-22 01:54 PM, Emil Velikov wrote: > Hi Ville, > > On 22 March 2018 at 15:22, Ville Syrjala > wrote: >> From: Ville Syrjälä >> >> I really just wanted to fix i915 to re-enable its planes afer load >> detection (a two line

Re: [PATCH] drm/atomic: Add new reverse iterator over all plane state (V2)

2018-03-07 Thread Harry Wentland
On 2018-03-06 10:10 PM, Shirish S wrote: > Add reverse iterator for_each_oldnew_plane_in_state_reverse to > compliment the for_each_oldnew_plane_in_state way or reading plane > states. > > The plane states are required to be read in reverse order for > amd drivers, cause the z order convention

Re: [RFC][PATCH 11/11] drm: Sprinkle lockdep asserts for edid/display_info

2018-03-06 Thread Harry Wentland
On 2018-03-06 12:13 PM, Daniel Vetter wrote: > On Tue, Mar 06, 2018 at 11:23:23AM -0500, Harry Wentland wrote: >> On 2018-03-06 07:18 AM, Ville Syrjälä wrote: >>> On Tue, Mar 06, 2018 at 10:31:27AM +0100, Daniel Vetter wrote: >>>> On Tue, Feb 27, 2018 at 02:57:0

Re: [RFC][PATCH 11/11] drm: Sprinkle lockdep asserts for edid/display_info

2018-03-06 Thread Harry Wentland
_edid/update_edid_property > Yeah, it's because the dc_sink carries the EDID and is only created at this point for us. It's bugged me ever since we did this. Might be time to think of a solution to it now. Harry >> >> Otherwise I think this is a real good patch. >> >&

Re: [Intel-gfx] [PATCH 1/3] drm: Make sure at least one plane supports the fb format

2018-03-06 Thread Harry Wentland
On 2018-03-06 05:35 AM, Daniel Vetter wrote: > On Mon, Mar 05, 2018 at 05:44:16PM -0500, Harry Wentland wrote: >> On 2018-03-05 04:33 PM, Alex Deucher wrote: >>> On Mon, Mar 5, 2018 at 4:15 PM, Ville Syrjälä >>> <ville.syrj...@linux.intel.com> wrote: >>>

Re: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-03-06 Thread Harry Wentland
On 2018-03-06 02:51 AM, Daniel Vetter wrote: > On Fri, Feb 23, 2018 at 11:26:41AM -0500, Harry Wentland wrote: >> On 2018-02-22 04:42 PM, Ville Syrjala wrote: >>> From: Ville Syrjälä <ville.syrj...@linux.intel.com> >>> >>> The documentation for the ctm mat

Re: [Intel-gfx] [PATCH 1/3] drm: Make sure at least one plane supports the fb format

2018-03-05 Thread Harry Wentland
On 2018-03-05 04:33 PM, Alex Deucher wrote: > On Mon, Mar 5, 2018 at 4:15 PM, Ville Syrjälä > wrote: >> On Mon, Mar 05, 2018 at 12:59:00PM -0800, Eric Anholt wrote: >>> Ville Syrjala writes: >>> From: Ville Syrjälä

Re: [PATCH] drm/atomic: Add new reverse iterator over all plane state (V2)

2018-03-05 Thread Harry Wentland
On 2018-03-01 02:56 AM, S, Shirish wrote: > From: Shirish S > > Add reverse iterator for_each_oldnew_plane_in_state_reverse to compliment the > for_each_oldnew_plane_in_state way or reading plane states. > > The plane states are required to be read in reverse order for amd

Re: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude representation

2018-02-23 Thread Harry Wentland
yrjälä <ville.syrj...@linux.intel.com> Good clarification. Our new CTM implementation (1) actually assumed two's complement but nobody's using it yet, so we'll patch it to convert. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> (1) https://patchwork.freedesktop.org/patch/2

Re: [Intel-gfx] [PATCH] drm/atomic: Call ww_acquire_done after drm_modeset_lock_all

2018-02-21 Thread Harry Wentland
acquire_done patches I've acked, but where's the fun in not trying :-) > This shouldn't really hurt anything, other than throw DEBUG warnings if DEBUG_MUTEXES is on. Acked-by: Harry Wentland <harry.wentl...@amd.com> Harry > Cheers, Daniel > >> --- >> drivers/gpu/drm/d

Re: [PATCH] drm/doc: nerved -> nerfed in drm_ioctl.c

2018-02-20 Thread Harry Wentland
On 2018-02-19 10:27 AM, Daniel Vetter wrote: > On Thu, Feb 15, 2018 at 03:33:17PM -0500, Alex Deucher wrote: >> On Thu, Feb 15, 2018 at 2:56 PM, Harry Wentland <harry.wentl...@amd.com> >> wrote: >>> On 2018-02-15 11:40 AM, Daniel Stone wrote: >>>> Hi Har

Re: [PATCH v2 3/8] drm/atomic: Include color encoding/range in plane state dump

2018-02-20 Thread Harry Wentland
On 2018-02-19 03:28 PM, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > Include color_enconding and color_range in the plane state dump. > > v2: Add kerneldoc (danvet) > > Cc: Harry Wentland <harry.wentl...@amd.com> > Cc:

Re: [PATCH 04/10] drm: Add Plane Gamma properties

2018-02-16 Thread Harry Wentland
Or are you > supposed to use the same csc for that as you'd use for ctm? In that case > I can understand why the hw would have a gamm lut on each side of the > csc. But it would also means that you can't do yuv->rgb and ctm at the > same time unless you're fine with doing it wr

Re: [PATCH] drm/doc: nerved -> nerfed in drm_ioctl.c

2018-02-15 Thread Harry Wentland
On 2018-02-15 11:40 AM, Daniel Stone wrote: > Hi Harry, > > On 15 February 2018 at 16:28, Harry Wentland <harry.wentl...@amd.com> wrote: >> This threw me for a loop when I read the docs. I imagine this is the >> intended definition: >> http://www.dictiona

Re: [PATCH 04/10] drm: Add Plane Gamma properties

2018-02-15 Thread Harry Wentland
On 2018-02-15 12:32 AM, Daniele Castagna wrote: > From: "uma.shankar at intel.com (Uma Shankar)" > > Add plane gamma as blob property and size as a > range property. > Plane degamma & CTM make sense to me but I'm not sure why gamma would be on a per-plane basis. That

[PATCH] drm/doc: nerved -> nerfed in drm_ioctl.c

2018-02-15 Thread Harry Wentland
This threw me for a loop when I read the docs. I imagine this is the intended definition: http://www.dictionary.com/browse/nerf Signed-off-by: Harry Wentland <harry.wentl...@amd.com> --- drivers/gpu/drm/drm_ioctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH] amdgpu/dc: Add missing cast in dce_clock_set_min_clocks_state()

2018-02-09 Thread Harry Wentland
On 2018-02-09 04:28 PM, Matthias Kaehlcke wrote: > dce_clock_set_min_clocks_state() assigns (intentionally) a value of type > 'enum dm_pp_clocks_state' to a variable of type 'enum dm_pp_power_level' > without an explicit cast. This causes clang to raise the following > warning: > >

Re: [PATCH v3 4/4] amdgpu/dc/calcs: Support clang option for stack alignment

2018-02-08 Thread Harry Wentland
On 2018-02-08 04:03 PM, Harry Wentland wrote: > On 2018-02-08 03:53 PM, Matthias Kaehlcke wrote: >> calcs uses the compiler option -mpreferred-stack-boundary=4 to configure >> a stack alignment of 16 bytes. Clang uses the option -mstack-alignment >> instead, which

Re: [PATCH v3 4/4] amdgpu/dc/calcs: Support clang option for stack alignment

2018-02-08 Thread Harry Wentland
of two like -mpreferred-stack-boundary. > > Probe for both compiler options and use the correct one, similar to > what is done in arch/x86/Makefile. > > Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Series is Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry

Re: [PATCH v2 1/2] amdgpu/dc/dml: Consolidate redundant CFLAGS

2018-02-08 Thread Harry Wentland
On 2018-02-07 08:51 PM, Matthias Kaehlcke wrote: > Use subdir-ccflags instead of specifying the same flags for every source > file. > > Signed-off-by: Matthias Kaehlcke > Reviewed-by: Guenter Roeck > --- > Changes in v2: > - added 'Reviewed-by: Guenter

Re: [PATCH] amdgpu/dc: Fix enum mismatch in calls to program_color_matrix()

2018-02-07 Thread Harry Wentland
m_dce, tbl_entry, GRAPHICS_CSC_ADJUST_TYPE_SW); > > Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 2 +- > drivers/gpu/drm/amd/display/dc

Re: [PATCH] drm/amd/display: Remove extra pairs of parentheses in dce_calcs.c

2018-02-07 Thread Harry Wentland
ous parentheses > [-Werror,-Wparentheses-equality] > if ((data->graphics_micro_tile_mode == bw_def_rotated_micro_tiling)) { > > Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Thanks. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- >

Re: [PATCH 04/10] drm/amdgpu: Handle 64-bit return from drm_crtc_vblank_count()

2018-02-05 Thread Harry Wentland
it reference HW vblank count. Explicitly typecasting this down > to u32 either fixes a potential problem or serves to add clarity in case > the typecasting was implicitly done. > > Cc: Keith Packard <kei...@keithp.com> > Cc: Alex Deucher <alexander.deuc...@amd.com> >

Re: [PATCH 2/2] drm/amdgpu/display: successful spelling fix

2018-02-02 Thread Harry Wentland
On 2018-02-02 04:37 PM, db...@chromium.org wrote: > From: Dominik Behr <db...@chromium.org> > > Replace SUCESSFULL with SUCCESSFUL. > > Signed-off-by: Dominik Behr <db...@chromium.org> Series is Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Will pull

Re: [PATCH] drm/amd/display: fix incompatible structure layouts

2018-02-02 Thread Harry Wentland
On 2018-02-02 11:02 AM, Arnd Bergmann wrote: > On Fri, Feb 2, 2018 at 4:39 PM, Harry Wentland <harry.wentl...@amd.com> wrote: >> On 2018-02-02 07:31 AM, Arnd Bergmann wrote: >>> Building the amd display driver with link-time optimizations revealed a bug >> >&g

Re: [PATCH] drm/amdgpu/display: fix wrong enum type for ddc_result

2018-02-02 Thread Harry Wentland
On 2018-02-01 08:55 PM, db...@chromium.org wrote: > From: Dominik Behr > > v2: now with fixed result comparison and spelling fixes > > Signed-off-by: Dominik Behr > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- >

Re: [PATCH] drm/amd/display: fix incompatible structure layouts

2018-02-02 Thread Harry Wentland
e superset > of the members, to ensure the interfaces are all compatible. > > Fixes: ae79c310b1a6 ("drm/amd/display: Add DCE12 bios parser support") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks for the fix. Reviewed-by: Harry Wentland <harry.wentl...@amd.c

Re: [Intel-gfx] [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-02-01 Thread Harry Wentland
On 2018-02-01 05:30 AM, Maarten Lankhorst wrote: > Op 31-01-18 om 20:57 schreef Harry Wentland: >> On 2018-01-30 05:28 AM, Maarten Lankhorst wrote: >>> Op 29-01-18 om 16:41 schreef Leo Li: >>>> Updated IGT results seem sane: >>>> https://intel-gfx-ci.01.o

Re: [Intel-gfx] [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

2018-01-31 Thread Harry Wentland
On 2018-01-30 05:28 AM, Maarten Lankhorst wrote: > Op 29-01-18 om 16:41 schreef Leo Li: >> Updated IGT results seem sane: >> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7698/shards.html >> >> Would someone be able to apply this patch? >> > Thanks for the reminder, pushed. > Thanks,

Re: amdgpu hangs on boot or shutdown on AMD Raven Ridge CPU (Engineer Sample)

2018-01-31 Thread Harry Wentland
On 2018-01-31 09:31 AM, Chris Chiu wrote: > Hi, > We are working with new laptops that have the AMD Ravenl Ridge > chipset with this `/proc/cpuinfo` > https://gist.github.com/mschiu77/b06dba574e89b9a30cf4c450eaec49bc > > With the latest kernel 4.15, there're lots of different >

Re: [PATCH] drm/atomic: Remove WARN_ON for invalid plane configuration.

2018-01-30 Thread Harry Wentland
st <maarten.lankho...@linux.intel.com> > Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > --- > drivers/gpu/drm/drm_atomic.c | 4 ++-- > 1 file changed, 2 insert

Re: [AMDGPU][TAHITI XT] new display code

2018-01-30 Thread Harry Wentland
On 2018-01-29 05:55 PM, Alex Deucher wrote: > On Mon, Jan 29, 2018 at 5:35 PM, wrote: >> On Mon, Jan 29, 2018 at 03:40:34PM -0500, Alex Deucher wrote: >>> On Mon, Jan 29, 2018 at 3:34 PM, wrote: As far as I can remember, not for the

  1   2   3   4   >