On Tue, Sep 10, 2024 at 11:07:53PM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/dp_mst: Fix DSC decompression detection in Synaptics branch
> devices
> URL : https://patchwork.freedesktop.org/series/138419/
> State : failure
Patch is pushed to drm-misc-fixes, thanks for the r
rm/i915/kernel/-/issues/12047
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index a040d7dfced1
On Sun, Aug 04, 2024 at 06:45:43AM -0700, Manasi Navare wrote:
> On Mon, Jul 22, 2024 at 9:55 AM Imre Deak wrote:
> >
> > In the
> > if (old_ddps != port->ddps || !created)
> > if (port->ddps && !por
024-07-22 at 19:54 +0300, Imre Deak wrote:
> > Factor out a function to queue a work for probing the topology, also
> > used by the next patch.
> >
> > Cc: Lyude Paul
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Imre Deak
> > ---
> >
A follow up i915 patch will need to reprobe the MST topology after the
initial probing, add a helper for this.
Cc: Lyude Paul
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 27 +++
include/drm/display
r that the path resources are
always enumerated for an output port in the plugged state.
Cc: Lyude Paul
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
Factor out a function to queue a work for probing the topology, also
used by the next patch.
Cc: Lyude Paul
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
On Fri, Jul 19, 2024 at 02:43:27PM +0300, Imre Deak wrote:
> On Fri, Jul 19, 2024 at 02:39:11PM +0300, Imre Deak wrote:
> > On Fri, Jul 19, 2024 at 12:36:08PM +0200, Jocelyn Falempe wrote:
> > > This breaks build if DRM_PANIC is not enabled.
> > >
> > >
On Fri, Jul 19, 2024 at 02:39:11PM +0300, Imre Deak wrote:
> On Fri, Jul 19, 2024 at 12:36:08PM +0200, Jocelyn Falempe wrote:
> > This breaks build if DRM_PANIC is not enabled.
> >
> > Fixes: de338c754d40 ("drm/panic: Add missing static inline to
> > drm_panic_is_
On Fri, Jul 19, 2024 at 12:36:08PM +0200, Jocelyn Falempe wrote:
> This breaks build if DRM_PANIC is not enabled.
>
> Fixes: de338c754d40 ("drm/panic: Add missing static inline to
> drm_panic_is_enabled()")
> Signed-off-by: Jocelyn Falempe
Thanks for the quick fi
Hi,
On Wed, Jul 17, 2024 at 10:48:39AM +0200, Jocelyn Falempe wrote:
> It allows to check if the drm device supports drm_panic.
> Prepare the work to have better integration with fbcon and vtconsole.
>
> Signed-off-by: Jocelyn Falempe
> ---
> drivers/gpu/drm/drm_panic.c | 20 +++
On Tue, Jul 09, 2024 at 11:12:26AM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/dp: Fix LTTPR detection (rev2)
> URL : https://patchwork.freedesktop.org/series/135711/
> State : success
Thanks for the reviews, pushed patches 1-4 to drm-intel-next, patch 5 to
drm-misc-next
Cc: dri-devel@lists.freedesktop.org
Cc: Ville Syrjälä
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_helper.c | 66 +
include/drm/display/drm_dp.h| 4 ++
include/drm/display/drm_dp_helper.h | 2 +
3 files changed, 62 insertions(+), 10
Add the DPCD register for the LTTPR PHY OUI. This will be used by a
later i915 patch to dump the descriptors for the detected LTTPR PHYs.
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Imre Deak
---
include/drm/display/drm_dp.h | 4
1 file changed, 4 insertions(+)
diff --git a/include
On Mon, Jul 01, 2024 at 02:28:31PM +0300, Jani Nikula wrote:
> On Fri, 28 Jun 2024, Imre Deak wrote:
> > This is v2 of [1], renaming the helpers from drm_x16 to fxp_q4 as
> > suggested by Jani.
> >
> > [1] https://lore.kernel.org/all/20240614173911.3743172-1-imre.d...
Dump the DSC state to dmesg during HW readout and state computation as
well as the i915_display_info debugfs entry.
v2: Rebase on the s/DRM_X16/FXP_Q4 change.
Signed-off-by: Imre Deak
---
.../drm/i915/display/intel_crtc_state_dump.c | 3 +++
.../drm/i915/display/intel_display_debugfs.c | 4
The Display Engine's DSC register values are deducted from the DSC
configuration stored in intel_crtc_state::dsc. The latter one is
dumped in a human-readable format, so dumping the register values is
redundant, remove it.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_v
Replace the to_bpp_frac() helper defined by the driver with the
equivalent fxp_q4_to_frac() helper defined by DRM core.
v2: Rebase on the s/drm_x16/fxp_q4 change.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_display_types.h | 7 +--
drivers/gpu/drm/i915/display
Replace the BPP_X16_FMT()/ARGS() helpers defined by the driver with the
equivalent FXP_Q4_FMT()/ARGS() helpers defined by DRM core.
v2: Rebase on the s/DRM_X16/FXP_Q4 change.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_audio.c | 5 +++--
drivers/gpu/drm/i915/display
Replace the to_bpp_int_roundup() helper defined by the driver with the
equivalent fxp_q4_to_int_roundup() helper defined by DRM core.
v2: Rebase on s/drm_x16/fxp_q4 change.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 5 -
drivers/gpu/drm/i915/display
Replace the to_bpp_x16() helper defined by the driver with the
equivalent fxp_q4_from_int() helper defined by DRM core.
v2: Rebase on the s/drm_x16/fxp_q4 change.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_bios.c | 5 +++--
.../gpu/drm/i915/display
Replace the to_bpp_int() helper defined by the driver with the
equivalent fxp_q4_to_int() helper defined by DRM core.
v2: Rebase on the s/drm_x16/fxp_q4 change.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/icl_dsi.c | 9 +
drivers/gpu/drm/i915/display
Add a helper to dump the Display Stream Compression configuration, taken
into use in the i915 driver by a later patch.
v2:
- Rebase on the s/DRM_X16/FXP_Q4 change.
- s/DSC configration/DSC configuration in the function documentation.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display
later patches dumping the Display Stream Compression
configuration in DRM core and in the i915 driver to replace the
corresponding bpp_x16 helpers defined locally in the driver.
v2: Use the more generic/descriptive fxp_q4 prefix instead of drm_x16.
(Jani)
Cc: Jani Nikula
Signed-off-by: Imre Deak
This is v2 of [1], renaming the helpers from drm_x16 to fxp_q4 as
suggested by Jani.
[1] https://lore.kernel.org/all/20240614173911.3743172-1-imre.d...@intel.com
Cc: Jani Nikula
Imre Deak (9):
drm: Add helpers for q4 fixed point values
drm/display/dsc: Add a helper to dump the DSC
On Thu, Jun 27, 2024 at 06:41:46PM +0300, Jani Nikula wrote:
> On Wed, 19 Jun 2024, Imre Deak wrote:
> > On Wed, Jun 19, 2024 at 01:10:09PM +0300, Jani Nikula wrote:
> >> On Fri, 14 Jun 2024, Imre Deak wrote:
> >> > Add helpers to convert between x16 fi
On Wed, Jun 19, 2024 at 03:01:03PM +0300, Imre Deak wrote:
> On Wed, Jun 19, 2024 at 01:10:09PM +0300, Jani Nikula wrote:
> > On Fri, 14 Jun 2024, Imre Deak wrote:
> > > Add helpers to convert between x16 fixed point and integer/fraction
> > > values. Also add the form
On Wed, Jun 19, 2024 at 01:10:09PM +0300, Jani Nikula wrote:
> On Fri, 14 Jun 2024, Imre Deak wrote:
> > Add helpers to convert between x16 fixed point and integer/fraction
> > values. Also add the format/argument macros required to printk x16
> > fixed point variables.
>
Replace BPP_X16_FMT()/ARGS() defined by the driver with the equivalent
DRM_X16_FMT()/ARGS() defined by DRM core.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_audio.c | 5 +++--
drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
.../gpu/drm/i915/display
The Display Engine's DSC register values are deducted from the DSC
configuration stored in intel_crtc_state::dsc. The latter one is
dumped in a human-readable format, so dumping the register values is
redundant, remove it.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_v
Replace to_bpp_x16() defined by the driver with the drm_x16_from_int()
defined by DRM core.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_bios.c | 5 +++--
.../gpu/drm/i915/display/intel_display_types.h | 5 -
drivers/gpu/drm/i915/display/intel_dp.c | 17
Replace to_bpp_int_roundup() defined by the driver with the equivalent
drm_x16_to_int_roundup() defined by DRM core.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 4 +++-
drivers/gpu/drm/i915/display/intel_display_types.h | 5 -
drivers/gpu/drm/i915
Replace to_bpp_int() defined by the driver with the equivalent
drm_x16_from_int() defined by DRM core.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/icl_dsi.c | 9 +
drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
drivers/gpu/drm/i915/display
Dump the DSC state to dmesg during HW readout and state computation as
well as the i915_display_info debugfs entry.
Signed-off-by: Imre Deak
---
.../drm/i915/display/intel_crtc_state_dump.c | 3 +++
.../drm/i915/display/intel_display_debugfs.c | 4
drivers/gpu/drm/i915/display
Replace to_bpp_frac() defined by the driver with the equivalent
drm_x16_to_frac() defined by DRM core.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_display_types.h | 7 +--
drivers/gpu/drm/i915/display/intel_dp.c| 4 ++--
drivers/gpu/drm/i915/display
corresponding bpp_x16 helpers defined locally in the driver.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_helper.c | 5 +++--
include/drm/drm_fixed.h | 23 +++
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/display
Add a helper to dump the Display Stream Compression configuration, taken
into use in the i915 driver by a later patch.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dsc_helper.c | 91
include/drm/display/drm_dsc_helper.h | 3 +
2 files changed, 94
from i915 to DRM core.
Imre Deak (9):
drm: Add helpers for x16 fixed point values
drm/display/dsc: Add a helper to dump the DSC configuration
drm/i915: Replace to_bpp_x16() with drm_x16_from_int()
drm/i915: Replace to_bpp_int() with drm_x16_to_int()
drm/i915: Replace to_bpp_int_roundup
> towards each plane declaring only its own requirements, and thus
> we need code to generate the superset.
>
> v2: Drop the borked per-plane vma optimization (Imre)
> Assert that the plane's declared alignment is POT (Imre)
>
> Cc: Imre Deak
> Signed-off-by
On Tue, May 28, 2024 at 10:38:06PM +0300, Ville Syrjälä wrote:
> On Tue, May 28, 2024 at 02:27:52PM +0300, Imre Deak wrote:
> > On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä
> > >
> > > Different planes could h
* alignment for linear UV planes on all platforms.
> - */
> - if (fb->modifier == DRM_FORMAT_MOD_LINEAR)
> - return 256 * 1024;
> -
> - return intel_tile_row_size(fb, color_plane);
> - }
The above will also use the correct 2MB for DPT, which the previous
patch should've kept already. Other than that looks ok:
Reviewed-by: Imre Deak
> -
> switch (fb->modifier) {
> case DRM_FORMAT_MOD_LINEAR:
> case I915_FORMAT_MOD_X_TILED:
> --
> 2.43.2
>
5_FORMAT_MOD_4_TILED:
> + /*
> + * FIXME ADL sees GGTT/DMAR faults with async
> + * flips unless we align to 16k at least.
> + * Figure out what's going on here...
> + */
> +
;
> Signed-off-by: Ville Syrjälä
Reviewed-by: Imre Deak
> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 77 +--
> drivers/gpu/drm/i915/display/intel_fb.h | 4 +-
> .../drm/i915/display/skl_universal_plane.c| 77 ++-
> 3
24;
> + return 4 * 1024;
This changes the current 0 alignment to 4k, but these seem to be
equivalent.
Regardless of the above nit:
Reviewed-by: Imre Deak
> + case DRM_FORMAT_MOD_LINEAR:
> + return 128 * 1024;
> + default:
> + MISSING_CAS
On Mon, May 13, 2024 at 08:59:38PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Split intel_cursor_alignment() into per-platform variants.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Imre Deak
> ---
> drivers/gpu/drm/i915/displa
On Tue, May 28, 2024 at 02:27:58PM +0300, Imre Deak wrote:
> [...]
> > +}
> > +
> > static unsigned int
> > intel_plane_fb_min_alignment(const struct intel_plane_state *plane_state)
> > {
> > struct intel_plane *plane = to_intel_plane(plane_s
On Mon, May 13, 2024 at 08:59:37PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Different planes could have different alignment requirements
> even for the same format/modifier. Collect the alignment
> requirements across all planes capable of scanning out the
> fb such that the alignmen
e will need to fix xe's alignment handling
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Imre Deak
> ---
> drivers/gpu/drm/i915/display/i9xx_plane.c | 8 ++--
> drivers/gpu/drm/i915/display/intel_cursor.c | 2 +
> .../drm/i915/display/intel_display_types.h
On Thu, Apr 18, 2024 at 12:22:53PM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/dp: Few MTL/DSC and a UHBR monitor fix (rev4)
> URL : https://patchwork.freedesktop.org/series/131386/
> State : failure
I pushed the patchset to drm-intel-next, amending the code comment in
p
On Fri, Apr 19, 2024 at 03:40:39PM +0300, Jani Nikula wrote:
> On Wed, 28 Feb 2024, Imre Deak wrote:
> > Fix the documentation issues below, also reported by 'make htmldocs':
> >
> > drivers/gpu/drm/display/drm_dp_tunnel.c:447: warning: Function parameter or
d Almahallawy
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_helper.c | 2 ++
drivers/gpu/drm/i915/display/intel_dp_mst.c | 22 +
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_dp_helper.c
b/drivers/gpu/drm/display/dr
Navare
Acked-by: Maarten Lankhorst
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
include/drm/display/drm_dp_helper.h | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
b/drivers/gpu/drm/i915
On Wed, Apr 17, 2024 at 12:21:58PM +0300, Jani Nikula wrote:
> On Wed, 17 Apr 2024, Imre Deak wrote:
> > Factor out a function to check for UHBR channel coding support used by a
> > follow-up patch in the patchset.
> >
> > Cc: dri-devel@lists.freedesktop.org
>
On Wed, Apr 17, 2024 at 12:39:40PM +0300, Jani Nikula wrote:
> On Wed, 17 Apr 2024, Imre Deak wrote:
> > Enabling the 5k@60Hz uncompressed mode on the MediaTek/Dell U3224KBA
> > monitor results in a blank screen, at least on MTL platforms on UHBR
> > link rates with some (
Lankhorst
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 16
include/drm/display/drm_dp_mst_helper.h | 1 +
2 files changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
b/drivers/gpu/drm/display
another root cause, but still related
to the mode's short HBLANK duration. Enable the quirk for the monitor
adjusting the detection for the above differences.
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Ankit Nautiyal
Tested-by: Khaled Almahallawy
Signed-off-by: Imre Deak
---
drivers/gp
Lankhorst
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 6 +++---
include/drm/display/drm_dp_mst_helper.h | 6 ++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c
b/drivers/gpu/drm/display
Factor out a function to check for UHBR channel coding support used by a
follow-up patch in the patchset.
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Ankit Nautiyal
Reviewed-by: Manasi Navare
Acked-by: Maarten Lankhorst
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display
olor gradients / lines on the decompressed screen image.
Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Ankit Nautiyal
Reviewed-by: Manasi Navare
Acked-by: Maarten Lankhorst
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 ++--
include/drm/display/drm_ds
On Wed, Mar 20, 2024 at 10:11:41PM +0200, Imre Deak wrote:
> Fix the calculation of the DSC line buffer depth. This is limited both
> by the source's and sink's maximum line buffer depth, but the former one
> was not taken into account. On all Intel platform's the source&
plies to
> all platforms or any particular?
The change will make a difference only on MTL+.
> With that clarification:
>
> Reviewed-by: Manasi Navare
Thanks.
> Regards
> Manasi
>
> On Tue, Mar 26, 2024 at 3:01 AM Nautiyal, Ankit K
> wrote:
> >
> >
>
On Wed, Mar 27, 2024 at 02:30:53PM +0530, Nautiyal, Ankit K wrote:
>
> On 3/21/2024 1:41 AM, Imre Deak wrote:
> > Add a function to get the AUX device of the parent of an MST port, used
> > by a follow-up i915 patch in the patchset.
> >
> > Cc: Lyude Paul
> >
another root cause, but still related
to the mode's short HBLANK duration. Enable the quirk for the monitor
adjusting the detection for the above differences.
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_helper.c | 2 ++
drivers/gpu/drm
Add a function to get the AUX device of the parent of an MST port, used
by a follow-up i915 patch in the patchset.
Cc: Lyude Paul
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 16
1 file changed, 16 insertions
Factor out a function to check if an MST port is logical, used by a
follow-up i915 patch in the patchset.
Cc: Lyude Paul
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Imre Deak
---
drivers/gpu/drm/display/drm_dp_mst_topology.c | 6 +++---
include/drm/display/drm_dp_mst_helper.h | 7
Factor out a function to check for UHBR channel coding support used by a
follow-up patch in the patchset.
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp.c | 2 +-
include/drm/display/drm_dp_helper.h | 6 ++
2 files changed, 7
olor gradients / lines on the decompressed screen image.
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 ++--
include/drm/display/drm_dsc.h | 3 ---
2 files changed, 6 insertions(+), 13 deletions(-)
diff --g
helper cec rc_core drm
> nvme nvme_core mxm_wmi xhci_pci xhci_pci_renesas video wmi pinctrl_cannonlake
> mac_hid
> ---[ end trace ]---
>
> Fix this by avoiding the divide if bpp is 0.
>
> Fixes: c1d6a22b7219 ("drm/dp: Add helpers to calculat
On Mon, Mar 18, 2024 at 12:59:29PM +0200, Jani Nikula wrote:
> On Mon, 18 Mar 2024, Jani Nikula wrote:
> > On Mon, 18 Mar 2024, Neil Armstrong wrote:
> >> Hi,
> >>
> >> On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote:
> >>> Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding
> >>> br
m_helper gpu_sched drm_gpuvm drm_exec
> i2c_algo_bit drm_buddy ttm drm_display_helper drm_kms_helper cec rc_core drm
> nvme nvme_core mxm_wmi xhci_pci xhci_pci_renesas video wmi pinctrl_cannonlake
> mac_hid
> ---[ end trace ]---
>
> Fix this by avoiding t
m_ttm_helper gpu_sched drm_gpuvm drm_exec
> i2c_algo_bit drm_buddy ttm drm_display_helper drm_kms_helper cec rc_core drm
> nvme nvme_core mxm_wmi xhci_pci xhci_pci_renesas video wmi pinctrl_cannonlake
> mac_hid
> ---[ end trace ]---
>
> Fix this by avoiding the d
On Mon, Mar 11, 2024 at 06:09:29PM +0200, Imre Deak wrote:
> On Sat, Feb 10, 2024 at 09:24:59PM +, Chris Bainbridge wrote:
>
> Sorry for the delay.
>
> > The following trace occurs when using nouveau and unplugging a DP MST
> > adaptor:
> >
> > div
is_mst);
>
> + /* Avoid potential divide by zero in DIV_ROUND_UP_ULL */
The above comment is redundant.
> + if (bpp_x16 == 0)
> + return 0;
Could you please move the check to th
On Sat, Mar 02, 2024 at 12:55:48PM +0300, Dmitry Baryshkov wrote:
> On Fri, 1 Mar 2024 at 18:22, Imre Deak wrote:
> >
> > If drm_kms_helper_poll=n the output poll work will only get scheduled
> > from drm_helper_probe_single_connector_modes() to handle a delayed
> > h
ned-off-by: Imre Deak
---
drivers/gpu/drm/drm_probe_helper.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_probe_helper.c
b/drivers/gpu/drm/drm_probe_helper.c
index 19ecb749704be..4d60cc810b577 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++ b/d
rm/display/drm_dp_tunnel.c:1903: warning: Function parameter or
struct member 'max_group_count' not described in 'drm_dp_tunnel_mgr_create'
Fixes: 295654f7e554 ("drm/dp: Add support for DP tunneling")
Reported-by: kernel test robot
Signed-off-by: Imre Deak
---
drivers
On Tue, Feb 27, 2024 at 02:21:29PM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Add Display Port tunnel BW allocation support (rev6)
> URL : https://patchwork.freedesktop.org/series/129082/
> State : failure
Thanks for the reviews,acks, patchset is pushed to drm-intel-ne
On Fri, Feb 23, 2024 at 11:37:41PM +0200, Ville Syrjälä wrote:
> On Tue, Feb 20, 2024 at 11:18:32PM +0200, Imre Deak wrote:
> > +static void queue_retry_work(struct intel_atomic_state *state,
> > +struct drm_dp_tunnel *tunnel,
> > +
On Fri, Feb 23, 2024 at 11:32:21PM +0200, Ville Syrjälä wrote:
> On Tue, Feb 20, 2024 at 11:18:22PM +0200, Imre Deak wrote:
> > +static inline void drm_dp_tunnel_ref_put(struct drm_dp_tunnel_ref
> > *tunnel_ref)
> > +{
> > + drm_dp_tunnel_put(tunnel_ref-&g
On Fri, Feb 23, 2024 at 11:11:45PM +0200, Ville Syrjälä wrote:
> On Tue, Feb 20, 2024 at 11:18:31PM +0200, Imre Deak wrote:
> > Add a way to get the active pipes through a given DP port by syncing
> > against a related pending non-blocking commit. Atm
> > intel_dp_get_active_
On Fri, Feb 23, 2024 at 08:25:38AM +0200, Shankar, Uma wrote:
> [...]
> > diff --git a/drivers/gpu/drm/display/Kconfig
> > b/drivers/gpu/drm/display/Kconfig
> > index 09712b88a5b83..c0f56888c3280 100644
> > --- a/drivers/gpu/drm/display/Kconfig
> > +++ b/drivers/gpu/drm/display/Kconfig
> [...]
> >
s
serialized by drm_mode_config::connection_mutex), do a dummy DPRX read-out
in the encoder's HPD pulse handler (which is not blocked by other
encoders).
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp.c | 12
1 file changed, 12 insertions(+)
diff --git a/
x27;s DPRX capabilities (since the BW manager requires this
information, so snoops for it on AUX), so ensure this read takes place.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/gp
Detect DP tunnels and enable the BW allocation mode on them. Send a
hotplug notification to userspace in response to a BW change.
Signed-off-by: Imre Deak
---
.../drm/i915/display/intel_display_driver.c | 20 +++
drivers/gpu/drm/i915/display/intel_dp.c | 14
A follow-up change will need to resume DP tunnels during system resume,
so call intel_dp_sync_state() always for DDI encoders, so this function
can resume the tunnels for all DP connectors.
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
1
intel_dp_tunnel_atomic_clear_stream_bw() to this patch.
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar (v1)
---
drivers/gpu/drm/i915/display/intel_atomic.c | 2 ++
drivers/gpu/drm/i915/display/intel_display.c | 2 ++
drivers/gpu/drm/i915/display/intel_dp.c | 16
drivers
Handle DP tunnel IRQs a sink (or rather a BW management component like
the Thunderbolt Connection Manager) raises to signal the completion of a
BW request by the driver, or to signal any state change related to the
link BW.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_dp.c
Allocate and free the DP tunnel BW required by a stream while
enabling/disabling the stream during a modeset.
v2:
- Move the allocation up from encoder hooks to
intel_atomic_commit_tail().
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar (v1)
---
drivers/gpu/drm/i915/display/intel_ddi.c
Take any link BW limitation into account in
intel_dp_max_link_data_rate(). Such a limitation can be due to multiple
displays on (Thunderbolt) links with DP tunnels sharing the link BW.
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar
---
drivers/gpu/drm/i915/display/intel_dp.c | 32
B4 dependency to CONFIG_DRM_I915_DP_TUNNEL.
Cc: Ville Syrjälä
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/Kconfig | 14 +
drivers/gpu/drm/i915/Kconfig.debug| 1 +
drivers/gpu/drm/i915/Makefile | 3 +
drivers/gpu/drm/i915/display/intel_atomic.c
Add intel_dp_max_link_data_rate() to get the link BW vs. the sink DPRX
BW used by a follow-up patch enabling the DP tunnel BW allocation mode.
The link BW can be below the DPRX BW due to a BW limitation on a link
shared by multiple sinks.
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar
rjälä
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_crtc.c | 27 +++
drivers/gpu/drm/i915/display/intel_crtc.h | 1 +
drivers/gpu/drm/i915/display/intel_dp.c | 6 ++---
drivers/gpu/drm/i915/display/intel_tc.c | 7 ++
4 files changed, 37 insertions(
.
Cc: Ville Syrjälä
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_atomic.c | 6 ++
drivers/gpu/drm/i915/display/intel_display.c | 12
drivers/gpu/drm/i915/display/intel_link_bw.c | 5 +
3 files changed, 23 insertions(+)
diff --git a/drivers/gpu/drm/i915
Factor out a function updating the sink's link rate and lane count
capabilities, used by a follow-up patch enabling the DP tunnel BW
allocation mode.
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar
---
drivers/gpu/drm/i915/display/intel_dp.c | 11 ---
drivers/gpu/drm/i915/di
Factor out a function to read the sink's DPRX capabilities used by a
follow-up patch enabling the DP tunnel BW allocation mode.
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar
---
.../drm/i915/display/intel_dp_link_training.c | 30 +++
.../drm/i915/di
Export intel_dp_max_common_rate() and intel_dp_max_lane_count() used by
a follow-up patch enabling the DP tunnel BW allocation mode.
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar
---
drivers/gpu/drm/i915/display/intel_dp.c | 4 ++--
drivers/gpu/drm/i915/display/intel_dp.h | 2 ++
2 files
t the same time any MST connector with streams through the same
port. A follow-up change enabling the DP tunnel Bandwidth Allocation
Mode will take this into use.
v2:
- Send the uevent only to enabled MST connectors. (Jouni)
Cc: Jouni Högander
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/di
Factor out intel_dp_config_required_rate() used by a follow-up patch
enabling the DP tunnel BW allocation mode.
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar
---
drivers/gpu/drm/i915/display/intel_dp.c | 43 +++--
drivers/gpu/drm/i915/display/intel_dp.h | 1 +
2 files
Instead of intel_dp_max_data_rate() use the equivalent
drm_dp_max_dprx_data_rate() which was copied from the former one in a
previous patch.
Signed-off-by: Imre Deak
Reviewed-by: Uma Shankar
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
drivers/gpu/drm/i915/display/intel_dp.c
behind by the suspend time mode save.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/display/intel_display.c | 3 +--
drivers/gpu/drm/i915/display/intel_link_bw.c | 22
drivers/gpu/drm/i915/display/intel_link_bw.h | 2 +-
3 files changed, 20 insertions(+), 7 deletions
1 - 100 of 610 matches
Mail list logo
