Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-10-31 Thread Ivaylo Dimitrov
On 31.10.22 г. 12:13 ч., Tony Lindgren wrote: * Ivaylo Dimitrov [221031 06:55]: On 31.10.22 г. 0:08 ч., H. Nikolaus Schaller wrote: [ 39.419846] WARNING: CPU: 0 PID: 3673 at drivers/bus/omap_l3_noc.c:139 l3_interrupt_handler+0x23c/0x330 [ 39.429914] 4400.l3-noc:L3 Custom Error

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-10-31 Thread Ivaylo Dimitrov
On 31.10.22 г. 12:13 ч., Tony Lindgren wrote: * Ivaylo Dimitrov [221031 06:55]: On 31.10.22 г. 0:08 ч., H. Nikolaus Schaller wrote: [ 39.419846] WARNING: CPU: 0 PID: 3673 at drivers/bus/omap_l3_noc.c:139 l3_interrupt_handler+0x23c/0x330 [ 39.429914] 4400.l3-noc:L3 Custom Error

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-10-31 Thread Ivaylo Dimitrov
On 31.10.22 г. 9:57 ч., H. Nikolaus Schaller wrote: Am 31.10.2022 um 08:44 schrieb H. Nikolaus Schaller : Hi Ivaylo, Am 31.10.2022 um 08:05 schrieb Ivaylo Dimitrov : HI Nikolaus, On 31.10.22 г. 0:08 ч., H. Nikolaus Schaller wrote: Hi Ivaylo, it took a while until I found time to test

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-10-31 Thread Ivaylo Dimitrov
n rotating landscape<->portrait while closing and opening new windows soon results in allocation failures. Fix that by mapping buffers through DMM/TILER only when really needed, like, for scanout buffers. Signed-off-by: Ivaylo Dimitrov --- drivers/gpu/drm/omapdrm/omap_gem.c | 12 1

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-09-02 Thread Ivaylo Dimitrov
On 30.08.22 г. 21:23 ч., Tomi Valkeinen wrote: On 30/08/2022 21:08, Ivaylo Dimitrov wrote: flags &= ~OMAP_BO_TILED_MASK; flags |= 0x0008; flags |= OMAP_BO_WC; bo = omap_bo_new(dev, size, flags); As you can see we use 0x0008 (OMAP_BO_MEM_CO

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-08-30 Thread Ivaylo Dimitrov
is the best way to fix the issue. Still, see the comments bellow. Thanks, Yongqin Liu On Mon, 29 Aug 2022 at 22:36, Andrew Davis wrote: On 8/29/22 8:24 AM, Ivaylo Dimitrov wrote: Hi, On 29.08.22 г. 5:51 ч., Yongqin Liu wrote: Hi, Ivaylo Sorry for the late response, and Thanks very much

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-08-29 Thread Ivaylo Dimitrov
Hi, On 29.08.22 г. 5:51 ч., Yongqin Liu wrote: Hi, Ivaylo Sorry for the late response, and Thanks very much for the detailed explanations! On Thu, 18 Aug 2022 at 18:23, Ivaylo Dimitrov wrote: Hi, On 17.08.22 г. 7:52 ч., Yongqin Liu wrote: Hi, Ivaylo On Mon, 15 Aug 2022 at 14:23, Ivaylo

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-08-18 Thread Ivaylo Dimitrov
Hi, On 17.08.22 г. 7:52 ч., Yongqin Liu wrote: Hi, Ivaylo On Mon, 15 Aug 2022 at 14:23, Ivaylo Dimitrov wrote: Hi Liu, On 14.08.22 г. 17:27 ч., Yongqin Liu wrote: Hi, IvayIo Thanks very much for the reply! On Sat, 13 Aug 2022 at 14:58, Ivaylo Dimitrov wrote: Hi Liu, On 12.08.22 г. 7

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-08-15 Thread Ivaylo Dimitrov
Hi Liu, On 14.08.22 г. 17:27 ч., Yongqin Liu wrote: Hi, IvayIo Thanks very much for the reply! On Sat, 13 Aug 2022 at 14:58, Ivaylo Dimitrov wrote: Hi Liu, On 12.08.22 г. 7:35 ч., Yongqin Liu wrote: Hi, Ivaylo, Tomi We have one X15 Android AOSP master build, it could not have the home

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-08-13 Thread Ivaylo Dimitrov
) buffers are actually allocated as such - OMAP_BO_SCANOUT flag must be set when calling omap_bo_new(). Regards, Ivo. Thanks, Yongqin Liu On Thu, 17 Feb 2022 at 23:29, Ivaylo Dimitrov wrote: On 17.02.22 г. 14:46 ч., Tomi Valkeinen wrote: Hi, On 19/01/2022 12:23, Ivaylo Dimitrov wrote

Re: [PATCH 0/3] drm: omapdrm: Fix excessive GEM buffers DMM/CMA usage

2022-03-28 Thread Ivaylo Dimitrov
Hi, On 28.03.22 г. 12:46 ч., Tomi Valkeinen wrote: Hi, On 19/01/2022 12:23, Ivaylo Dimitrov wrote: This patch series fixes excessive DMM or CMA usage of GEM buffers leading to various runtime allocation failures. The series enables daily usage of devices without exausting limited resources

Re: [PATCH 0/3] drm: omapdrm: Fix excessive GEM buffers DMM/CMA usage

2022-02-17 Thread Ivaylo Dimitrov
Hi Tomi, On 17.02.22 г. 15:03 ч., Tomi Valkeinen wrote: Hi Ivaylo, On 19/01/2022 12:23, Ivaylo Dimitrov wrote: This patch series fixes excessive DMM or CMA usage of GEM buffers leading to various runtime allocation failures. The series enables daily usage of devices without exausting limited

Re: [PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-02-17 Thread Ivaylo Dimitrov
On 17.02.22 г. 14:46 ч., Tomi Valkeinen wrote: Hi, On 19/01/2022 12:23, Ivaylo Dimitrov wrote: On devices with DMM, all allocations are done through either DMM or TILER. DMM/TILER being a limited resource means that such allocations will start to fail before actual free memory is exhausted

Re: [PATCH 0/3] drm: omapdrm: Fix excessive GEM buffers DMM/CMA usage

2022-02-13 Thread Ivaylo Dimitrov
gentle ping On 19.01.22 г. 12:23 ч., Ivaylo Dimitrov wrote: This patch series fixes excessive DMM or CMA usage of GEM buffers leading to various runtime allocation failures. The series enables daily usage of devices without exausting limited resources like CMA or DMM space if GPU rendering

[PATCH 3/3] drm: omapdrm: Do no allocate non-scanout GEMs through DMM/TILER

2022-01-20 Thread Ivaylo Dimitrov
<->portrait while closing and opening new windows soon results in allocation failures. Fix that by mapping buffers through DMM/TILER only when really needed, like, for scanout buffers. Signed-off-by: Ivaylo Dimitrov --- drivers/gpu/drm/omapdrm/omap_gem.c | 12 1 file chan

[PATCH 0/3] drm: omapdrm: Fix excessive GEM buffers DMM/CMA usage

2022-01-20 Thread Ivaylo Dimitrov
similar issue on OMAP4/5, where DMM/TILER spaces get fragmented with time, leading to allocation failures. Series were tested on Motolola Droid4 and Nokia N900, with OMAP DDX and PVR EXA from https://github.com/maemo-leste/xf86-video-omap Ivaylo Dimitrov (3): drm: omapdrm: simplify omap_gem_pin

[PATCH 1/3] drm: omapdrm: simplify omap_gem_pin

2022-01-20 Thread Ivaylo Dimitrov
Move tiler related code to its own function. Signed-off-by: Ivaylo Dimitrov --- drivers/gpu/drm/omapdrm/omap_gem.c | 75 +- 1 file changed, 42 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm

[PATCH 2/3] drm: omapdrm: Support exporting of non-contiguous GEM BOs

2022-01-20 Thread Ivaylo Dimitrov
. This makes CMA memory only being used when needed, instead for every buffer that has to be off-CPU rendered. Tested on Motorola Droid4 and Nokia N900 Signed-off-by: Ivaylo Dimitrov --- drivers/gpu/drm/omapdrm/omap_gem.c| 125 +- drivers/gpu/drm/omapdrm/omap_gem.h

Re: [PATCH] drm: omapdrm: Fix implicit dma_buf fencing

2022-01-06 Thread Ivaylo Dimitrov
Hi, On 6.01.22 г. 15:43 ч., Tomi Valkeinen wrote: Hi, On 05/01/2022 17:36, Ivaylo Dimitrov wrote: Currently omapdrm driver does not initialize dma_buf_export_info resv member, which leads to a new dma_resv being allocated and attached to the exported dma_buf. This leads to the issue

[PATCH] drm: omapdrm: Fix implicit dma_buf fencing

2022-01-06 Thread Ivaylo Dimitrov
object resv are waited on. This leads to various issues like displaying incomplete frames. Fix that by initializing dma_buf resv to the resv of the gem object being exported. Signed-off-by: Ivaylo Dimitrov --- drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] drm/panel: sony-acx565akm: Fix race condition in probe

2020-11-29 Thread Ivaylo Dimitrov
You may add: Tested-by: Ivaylo Dimitrov On 27.11.20 г. 22:04 ч., Sebastian Reichel wrote: The probe routine acquires the reset GPIO using GPIOD_OUT_LOW. Directly afterwards it calls acx565akm_detect(), which sets the GPIO value to HIGH. If the bootloader initialized the GPIO to HIGH before

Re: [REGRESSION] omapdrm/N900 display broken

2020-11-29 Thread Ivaylo Dimitrov
Hi, On 27.11.20 г. 19:30 ч., Tomi Valkeinen wrote: On 27/11/2020 17:37, Ivaylo Dimitrov wrote: With 5.9.11 and the patch on top, n900 boots fine, albeit display remains blank, could be related to brightness, we're still investigating. Ok. A DSS regdump for a working version and the latest

Re: [REGRESSION] omapdrm/N900 display broken

2020-11-29 Thread Ivaylo Dimitrov
Hi, On 27.11.20 г. 15:10 ч., Ivaylo Dimitrov wrote: On 27.11.20 г. 13:45 ч., Tomi Valkeinen wrote: On 27/11/2020 01:17, Ivaylo Dimitrov wrote: Hi Tomi, On 26.11.20 г. 16:11 ч., Tomi Valkeinen wrote: Hi Aaro, Ivaylo, On 24/11/2020 23:03, Ivaylo Dimitrov wrote: Is there any progress

Re: [REGRESSION] omapdrm/N900 display broken

2020-11-29 Thread Ivaylo Dimitrov
On 27.11.20 г. 13:45 ч., Tomi Valkeinen wrote: On 27/11/2020 01:17, Ivaylo Dimitrov wrote: Hi Tomi, On 26.11.20 г. 16:11 ч., Tomi Valkeinen wrote: Hi Aaro, Ivaylo, On 24/11/2020 23:03, Ivaylo Dimitrov wrote: Is there any progress on the issue? I tried 5.9.1 and still nothing displayed

Re: [REGRESSION] omapdrm/N900 display broken

2020-11-27 Thread Ivaylo Dimitrov
Hi Tomi, On 26.11.20 г. 16:11 ч., Tomi Valkeinen wrote: Hi Aaro, Ivaylo, On 24/11/2020 23:03, Ivaylo Dimitrov wrote: Is there any progress on the issue? I tried 5.9.1 and still nothing displayed. Can you test the attached patch? With this patch I don't see oops that Aaro reported, so

Re: [REGRESSION] omapdrm/N900 display broken

2020-11-25 Thread Ivaylo Dimitrov
Hi, On 25.08.20 г. 16:16 ч., Tomi Valkeinen wrote: Hi Laurent, On 23/08/2020 19:26, Aaro Koskinen wrote: Hi, On Tue, Aug 04, 2020 at 03:39:37PM +0300, Tomi Valkeinen wrote: On 04/08/2020 15:13, Tomi Valkeinen wrote: Can you try to pinpoint a bit where the hang happens? Maybe add