Re: [PATCH 6/6] drm: tiny: gdepaper: add driver for 2/3 color epaper displays

Hi Noralf, thank you for your comments. I've incorporated your suggestions into my draft. On 8/7/19 1:06 AM, Noralf Trønnes wrote: [...] >> +static int gdepaper_probe(struct spi_device *spi) >> +{ >> +struct device *dev = >dev; >> +struct device_node *np = dev->of_node; >> +const

Re: [PATCH 5/6] drm: uapi: add gdepaper uapi header

On 7/31/19 1:49 AM, Emil Velikov wrote: > On 2019/07/31, Jan Sebastian Götte wrote: >> Hi Emil, >> >> thank you for your comments. >> >> On 7/30/19 11:08 PM, Emil Velikov wrote: >>> On 2019/07/30, Jan Sebastian Götte wrote: >>>> Signed-off-by

Re: [RFC PATCH 0/6] tiny: Add driver for gooddisplay epaper panels

Hi Daniel, thanks for your comments! On 7/30/19 11:26 PM, Daniel Vetter wrote: >> I have a couple of questions regarding this driver, thus the RFC: >> (1) By default, when loading the module a vt console binds to the fb. I >> think this is useful, but the cursor blink of the vt leads to an

Re: [PATCH 5/6] drm: uapi: add gdepaper uapi header

Hi Emil, thank you for your comments. On 7/30/19 11:08 PM, Emil Velikov wrote: > On 2019/07/30, Jan Sebastian Götte wrote: >> Signed-off-by: Jan Sebastian Götte >> --- >> include/uapi/drm/gdepaper_drm.h | 62 + >> 1 file changed, 62 in

[PATCH 5/6] drm: uapi: add gdepaper uapi header

Signed-off-by: Jan Sebastian Götte --- include/uapi/drm/gdepaper_drm.h | 62 + 1 file changed, 62 insertions(+) create mode 100644 include/uapi/drm/gdepaper_drm.h diff --git a/include/uapi/drm/gdepaper_drm.h b/include/uapi/drm/gdepaper_drm.h new file mode 100644

[PATCH 6/6] drm: tiny: gdepaper: add driver for 2/3 color epaper displays

lt this is disabled since careful LUT tuning is required for this to not look terrible. Also not all content is suited to this mode of operation. Tested-by: Jan Sebastian Götte Signed-off-by: Jan Sebastian Götte --- drivers/gpu/drm/tinydrm/gdepaper.c| 1262 + dri

[PATCH 4/6] dt-bindings: add gdepaper documentation

Signed-off-by: Jan Sebastian Götte --- .../devicetree/bindings/display/gdepaper.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/gdepaper.txt diff --git a/Documentation/devicetree/bindings/display/gdepaper.txt b

[PATCH 3/6] dt-bindings: add good display epaper header

Signed-off-by: Jan Sebastian Götte --- include/dt-bindings/display/gdepaper.h | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 include/dt-bindings/display/gdepaper.h diff --git a/include/dt-bindings/display/gdepaper.h b/include/dt-bindings/display

[PATCH 2/6] dt-bindings: add gooddisplay vendor prefix

Dalian Good Display Co., Ltd. among others makes three-color epaper panels. Signed-off-by: Jan Sebastian Götte --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation

[PATCH 1/6] drm: tiny: gdepaper: add TINYDRM_GDEPAPER config option

Signed-off-by: Jan Sebastian Götte --- drivers/gpu/drm/tinydrm/Kconfig | 10 ++ drivers/gpu/drm/tinydrm/Makefile | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig index 87819c82bcce..427d1e62e63d 100644

[RFC PATCH 0/6] tiny: Add driver for gooddisplay epaper panels

hes all apply on v5.2. This is my first linux driver, so please be gentle but please do point out all my mistakes :) I'm aware the dt binding doc is still lacking. Best regards, Jan Sebastian Götte [0] https://www.good-display.com/ [1] https://www.waveshare.com/product/modules/oleds-lcds/e-pape

[PATCH v2] Staging: fbtft: Fix GPIO handling

pi via SPI. Fixes: commit c440eee1a7a1d ("Staging: fbtft: Switch to the gpio descriptor interface") Tested-by: Jan Sebastian Götte Reviewed-by: Nicolas Saenz Julienne Signed-off-by: Jan Sebastian Götte --- drivers/staging/fbtft/fb_bd663474.c | 2 +- drivers/staging/fbtft/fb_ili9163

[PATCH] Staging: fbtft: Fix GPIO handling

pi via SPI. Fixes: commit c440eee1a7a1d ("Staging: fbtft: Switch to the gpio descriptor interface") Tested-by: Jan Sebastian Götte Signed-off-by: Jan Sebastian Götte --- drivers/staging/fbtft/fb_bd663474.c | 2 +- drivers/staging/fbtft/fb_ili9163.c | 2 +- drivers/staging/fbtf

Re: [PATCH] Staging: fbtft: Fix wrong check in,fbtft_write_wmem16_bus8()

Coincidentially, I've worked on the exact same issue this weekend. I can confirm this change is necessary, and with this and the other two patches from Phil Reid the driver works again. The same mistake occurred in several other locations, though. I'll send a patch fixing all of them. I've

Re: [PATCH 1/2] Staging: fbtft: Fix probing of gpio descriptor

t;Staging: fbtft: Switch to the gpio descriptor > interface") > Signed-off-by: Phil Reid > --- > drivers/staging/fbtft/fbtft-core.c | 39 > ++---- > 1 file changed, 18 insertions(+), 21 deletions(-) Tested-by: Jan Sebastian Götte __

Re: [PATCH 2/2] Staging: fbtft: Fix reset assertion when using gpio descriptor

the polarity. > > Prior to conversion to gpiod calls the polarity in the DT > was ignored and assumed to be active low. Fix it so that > DT polarity is respected. > > Signed-off-by: Phil Reid > --- > drivers/staging/fbtft/fbtft-core.c | 4 ++-- > 1 file changed, 2 insertions