Re: [PATCH v7 0/4] Introduce drm scaling filter property

2020-10-21 Thread Jani Nikula
drivers/gpu/drm/i915/display/intel_sprite.c | 15 ++- > drivers/gpu/drm/i915/i915_reg.h | 22 > include/drm/drm_crtc.h| 16 +++ > include/drm/drm_plane.h | 21 > 13 files changed, 331 insertions(+), 4 deletions(-) -

Re: [PATCH v2 09/15] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-10-20 Thread Jani Nikula
verify_mprime_in->header.buffer_len = cmd_size - sizeof(struct > hdcp_cmd_header); > > verify_mprime_in->port.integrated_port_type = data->port_type; > verify_mprime_in->port.physical_port = (u8)data->fw_ddi; -- Jani Nikula, Intel Open Source Graphic

Re: [Intel-gfx] [PATCH 09/13] drm/i915/hdcp: mst streams support in hdcp port_data

2020-10-20 Thread Jani Nikula
On Tue, 20 Oct 2020, Anshuman Gupta wrote: > On 2020-10-20 at 12:39:04 +0300, Jani Nikula wrote: >> On Tue, 20 Oct 2020, Anshuman Gupta wrote: >> > On 2020-10-20 at 11:31:37 +0300, Jani Nikula wrote: >> >> On Mon, 19 Oct 2020, Anshuman Gupta wrote: >> >

Re: [Intel-gfx] [RFC] drm/hdcp: Max MST content streams

2020-10-20 Thread Jani Nikula
On Tue, 20 Oct 2020, Maarten Lankhorst wrote: > Op 20-10-2020 om 11:42 schreef Jani Nikula: >> On Mon, 19 Oct 2020, Anshuman Gupta wrote: >>> Let's define Maximum MST content streams up to four >>> generically which can be supported by modern display >>>

Re: [Intel-gfx] [RFC] drm/hdcp: Max MST content streams

2020-10-20 Thread Jani Nikula
header. > */ > -#define HDCP_2_2_MAX_CONTENT_STREAMS_CNT 1 > +#define HDCP_2_2_MAX_CONTENT_STREAMS_CNT 4 > #define HDCP_2_2_TXCAP_MASK_LEN 2 > #define HDCP_2_2_RXCAPS_LEN 3 > #define HDCP_2_2_RX_REPEAT

Re: [Intel-gfx] [PATCH 09/13] drm/i915/hdcp: mst streams support in hdcp port_data

2020-10-20 Thread Jani Nikula
On Tue, 20 Oct 2020, Anshuman Gupta wrote: > On 2020-10-20 at 11:31:37 +0300, Jani Nikula wrote: >> On Mon, 19 Oct 2020, Anshuman Gupta wrote: >> > Add support for multiple mst stream in hdcp port data >> > which will be used by RepeaterAuthStreamManage msg and >&

Re: [Intel-gfx] [PATCH 09/13] drm/i915/hdcp: mst streams support in hdcp port_data

2020-10-20 Thread Jani Nikula
DCP_2_2_RX_REPEATER(x) ((x) & BIT(0)) These two hunk should probably be separate changes... would be easier to record the changes (as they're not mentioned in the commit message at all!) and the acks from other maintainers. Cc: Tomas. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 44/80] docs: gpu: i915.rst: Fix several C duplication warnings

2020-10-16 Thread Jani Nikula
>> --- >>>> Documentation/gpu/i915.rst | 29 + >>>> 1 file changed, 25 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst >>>> i

Re: linux-next: manual merge of the akpm tree with the drm-intel tree

2020-10-01 Thread Jani Nikula
is a bit more complicated, but I just redid my >> patches to not depend on the above ones. I can revert back to the old >> version, though. Andrew, let me know what works for you. > > Imo ignore, rebasing onto linux-next without those intel patches was > the right thing for the 5.10 merge window. > -Daniel -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-30 Thread Jani Nikula
ks like they're not the same... why not if they're supposed to be identical? What else is there? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-30 Thread Jani Nikula
Matt Roper suggested to use PCH to differentiate > between EHL and JSL, Jani also agreed with this solution.This 2 PCHs > can only be associate with EHL and JSL respectively, so no downsides > here. FWIW I said, "If the difference is in the PCH", without pondering further. BR, J

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-29 Thread Jani Nikula
On Mon, 28 Sep 2020, Matt Roper wrote: > On Mon, Sep 28, 2020 at 04:07:39PM -0700, Lucas De Marchi wrote: >> On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: >> > On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" >> > wrote: >> >

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Jani Nikula
the PCH check should be used instead. Which avoids the problem altogether. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, Ville Syrjälä wrote: > On Mon, Sep 28, 2020 at 07:15:43AM -0700, James Ausmus wrote: >> On Mon, Sep 28, 2020 at 04:43:11PM +0300, Jani Nikula wrote: >> > On Mon, 28 Sep 2020, Tejas Upadhyay >> > wrote: >> > > JSL has update in vswin

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
bsequent IS_JASPERLAKE() branch would never be taken. > > BR, > Jani. > > Tejas : In that case I will put attention note in comment about > platform checks such that ladder distrubance can be avoided. What you > suggest? The solution is to make IS_ELKHARTLAKE() mean ELK and on

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Jani Nikula
On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: > > From: Jani Nikula > Sent: Monday, September 28, 2020 7:07 PM > To: Surendrakumar Upadhyay, TejaskumarX > ; Vivi, Rodrigo > ; airl...@linux.ie

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

2020-09-28 Thread Jani Nikula
ombo_buf_trans(encoder, type, rate, > _entries); > + else if (IS_JASPERLAKE(dev_priv)) > + ddi_translations = jsl_get_combo_buf_trans(encoder, type, rate, > +_entries); > else if (IS_ELKHARTLAKE(dev_priv)) > ddi_translations = ehl_get_combo_buf_trans(encoder, type, rate, > _entries); -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/i915/jsl: Split EHL/JSL platform info and PCI ids

2020-09-28 Thread Jani Nikula
\ > INTEL_VGA_DEVICE(0x4557, info), \ > - INTEL_VGA_DEVICE(0x4555, info), \ > + INTEL_VGA_DEVICE(0x4555, info) > + > +/* JSL */ > +#define INTEL_JSL_IDS(info) \ > + INTEL_VGA_DEVICE(0x4E71, info), \ > INTEL_VGA_DEVICE(0x4E61, info), \ > INTEL_VGA_DEVICE(0x4E57, info), \ > INTEL_VGA_DEVICE(0x4E55, info), \ -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PULL] drm-intel-fixes

2020-09-24 Thread Jani Nikula
drm/i915/selftests: Push the fake iommu device from the stack to data Jani Nikula (2): Merge remote-tracking branch 'origin/master' into drm-intel-fixes Merge tag 'gvt-fixes-2020-09-17' of https://github.com/intel/gvt-linux into drm-intel-fixes Zhenyu Wang (1): drm/i915/gvt: Fix

Re: [PATCH 1/2] drm/dp: add subheadings to DPCD address definitions

2020-09-24 Thread Jani Nikula
On Fri, 18 Sep 2020, "Navare, Manasi" wrote: > On Fri, Sep 18, 2020 at 02:40:16PM +0300, Jani Nikula wrote: >> Add the subheadings from the DP spec. No functional changes. >> >> Signed-off-by: Jani Nikula > > Looks good to me > > Reviewed-by: Manasi Na

Re: [PATCH] drm/dp: start using more of the extended receiver caps

2020-09-21 Thread Jani Nikula
On Mon, 21 Sep 2020, Lyude Paul wrote: > On Tue, 2020-09-01 at 21:01 +0300, Jani Nikula wrote: >> I guess we can try without the change, and fix later if we hit issues. > > I'm fine with the change if it doesn't break things btw - just as long as > we're making sure that we don

Re: [PATCH 1/3] drm/crtc: Introduce per-crtc kworker

2020-09-21 Thread Jani Nikula
fresh_data *self_refresh_data; > + > + /** > + * worker: Missing @, should be "@worker:". > + * > + * Per-CRTC worker for nonblock atomic commits. > + */ > + struct kthread_worker *worker; > }; > > /** -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/dp: update kernel-doc line comments

2020-09-21 Thread Jani Nikula
bconnector_type(const u8 > dpcd[DP_RECEIVER_CAP_SIZE], > } > EXPORT_SYMBOL(drm_dp_subconnector_type); > > -/** > +/* > * drm_mode_set_dp_subconnector_property - set subconnector for DP connector > * > * Called by a driver on every detect event. -- Jani Nikula, Intel Open Source Graphics Center ___

[PATCH 2/2] drm/dp: add a number of DP 2.0 DPCD definitions

2020-09-18 Thread Jani Nikula
Prepare for future with DP 2.0 DPCD definitions, with a couple of related drive-by cleanups. No functional changes. v2: Send the version that actually builds. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 52 - 1 file changed, 45 insertions

[PATCH 1/2] drm/dp: add subheadings to DPCD address definitions

2020-09-18 Thread Jani Nikula
Add the subheadings from the DP spec. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index c9f2851904d0

Re: [PATCH] i915: Introduce quirk for shifting eDP brightness.

2020-09-17 Thread Jani Nikula
gt; > void intel_init_quirks(struct drm_i915_private *i915) > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index e4f7f6518945b..cc93bede4fab8 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -525,6 +525,7 @@ struct i915_psr { > #define QUIRK_PIN_SWIZZLED_PAGES (1<<5) > #define QUIRK_INCREASE_T12_DELAY (1<<6) > #define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7) > +#define QUIRK_SHIFT_EDP_BACKLIGHT_BRIGHTNESS (1<<8) > > struct intel_fbdev; > struct intel_fbc_work; -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] drm/dp: add a number of DP 2.0 DPCD definitions

2020-09-17 Thread Jani Nikula
Prepare for future with DP 2.0 DPCD definitions, with a couple of related drive-by cleanups. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 52 - 1 file changed, 45 insertions(+), 7 deletions(-) diff --git a/include/drm

[PATCH 1/2] drm/dp: add subheadings to DPCD address definitions

2020-09-17 Thread Jani Nikula
Add the subheadings from the DP spec. No functional changes. Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 5c45195ced32

[PULL] drm-intel-fixes

2020-09-17 Thread Jani Nikula
5/gt/intel_lrc.c | 15 ++--- drivers/gpu/drm/i915/i915_request.c | 25 +-- drivers/gpu/drm/i915/i915_sw_fence.c| 10 -- 4 files changed, 71 insertions(+), 27 deletions(-) -- Jani Nikula, Intel Open Source Graphics Ce

Re: [Intel-gfx] [RFC 1/5] drm/i915/dp: Program source OUI on eDP panels

2020-09-16 Thread Jani Nikula
we should restrict this to the supported platforms: cfl, whl, cml, > icl, tgl > no? Mmh, this just exposes sink behaviour that I think can be supported by any platform. I don't understand the notion of "supported platforms" here. > >> + >> return true; >> } >> >> -- >> 2.26.2 >> >> ___ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC 5/5] drm/dp: Revert "drm/dp: Introduce EDID-based quirks"

2020-09-16 Thread Jani Nikula
we now have no need for the force DPCD backlight quirk, and > furthermore this also removes the need for any kind of EDID quirk > checking in DRM. So, let's just revert it for now since we were the only > driver using this. > > Signed-off-by: Lyude Paul > Cc: thay...@noraisin.net >

Re: [Intel-gfx] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-15 Thread Jani Nikula
alse; > - fallthrough; > + break; > case DRM_FORMAT_MOD_LINEAR: > case I915_FORMAT_MOD_X_TILED: > case I915_FORMAT_MOD_Y_TILED: Acked-by: Jani Nikula for merging via whichever tree seems best. BR, Jani. --

Re: [PATCH 0/4] Add support for video pattern DP CTS to MSM DP

2020-09-14 Thread Jani Nikula
/drm/msm/dp/dp_debug.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_debug.h -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PULL] drm-intel-fixes

2020-09-10 Thread Jani Nikula
play/intel_display.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PULL] drm-intel-fixes

2020-09-03 Thread Jani Nikula
), 8 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 22/24] drm/i915: Backlight update

2020-09-02 Thread Jani Nikula
ges aren't easy to review when conflated into one, and should there be a regression, the problem would be difficult to pinpoint. I've commented on some of the changes inline, and some of them are clearly unacceptable. BR, Jani. > > Signed-off-by: Sam Ravnborg > Cc: Jani Nikula > Cc:

Re: [PATCH] drm/dp: start using more of the extended receiver caps

2020-09-01 Thread Jani Nikula
On Tue, 01 Sep 2020, Lyude Paul wrote: > On Tue, 2020-09-01 at 15:32 +0300, Jani Nikula wrote: >> In the future, we'll be needing more of the extended receiver capability >> field starting at DPCD address 0x2200. (Specifically, we'll need main >> link channel coding cap for

[PATCH] drm/dp: start using more of the extended receiver caps

2020-09-01 Thread Jani Nikula
In the future, we'll be needing more of the extended receiver capability field starting at DPCD address 0x2200. (Specifically, we'll need main link channel coding cap for DP 2.0.) Start using it now to not miss out later on. Cc: Lyude Paul Signed-off-by: Jani Nikula --- I guess this can

Re: [bug report] drm/dp: annotate implicit fall throughs

2020-08-28 Thread Jani Nikula
add the default label to switch (bpc)? BR, Jani. > >496 default: >497 return 0; >498 } >499 } > > regards, > dan carpenter > ___ > dri-devel mailing list > dri-devel@lis

Re: [PATCH v5 13/20] drm/i915/dp: Extract drm_dp_read_downstream_info()

2020-08-27 Thread Jani Nikula
p_is_branch(dpcd) || > + dpcd[DP_DPCD_REV] < DP_DPCD_REV_10 || > + !(dpcd[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT)) > + return 0; Generally I think stuff like this is easier and faster to read with multiple if statements and early return

Re: [PATCH v5 09/20] drm/i915/dp: Extract drm_dp_read_mst_cap()

2020-08-27 Thread Jani Nikula
e from drm_dp_has_mst() to drm_dp_read_mst_cap() > > Signed-off-by: Lyude Paul > Reviewed-by: Sean Paul Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 22 ++ > drivers/gpu/drm/i915/display/intel_dp.c | 18 ++ > include/drm/drm_d

[PULL] drm-intel-fixes

2020-08-27 Thread Jani Nikula
asks Mika Kuoppala (1): drm/i915: Fix cmd parser desc matching with masks drivers/gpu/drm/i915/i915_cmd_parser.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) -- Jani Nikula, Intel Open Source Graphics Ce

Re: [PULL] drm-misc-next

2020-08-26 Thread Jani Nikula
usly the rule of thumb has been to only ever do backmerges from drm-next. If you need a backmerge from Linus' tree, you ask for a backmerge to drm-next, and then backmerge that. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel

Re: [RFC v4 16/20] drm/i915/dp: Extract drm_dp_get_sink_count()

2020-08-26 Thread Jani Nikula
r.h > index a1413a531eaf4..0c141fc81aaa8 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -1635,6 +1635,7 @@ struct drm_dp_desc; > bool drm_dp_has_sink_count(struct drm_connector *connector, > const u8 dpcd[DP_RECEIVER_CAP_SIZE], >

Re: [RFC v4 09/20] drm/i915/dp: Extract drm_dp_has_mst()

2020-08-26 Thread Jani Nikula
re critical of accumulating a lot of inlines in headers. Do we really want this in the header? > +drm_dp_has_mst(struct drm_dp_aux *aux, > +const u8 dpcd[DP_RECEIVER_CAP_SIZE]) > +{ > + u8 mstm_cap; > + > + if (dpcd[DP_DPCD_REV] < DP_DPCD_REV_12) > +

[PULL] drm-intel-fixes

2020-08-20 Thread Jani Nikula
e enabling TC AUX power wells Jani Nikula (1): Merge tag 'gvt-next-fixes-2020-08-05' of https://github.com/intel/gvt-linux into drm-intel-fixes Matt Roper (1): drm/i915: Update bw_buddy pagemask table Tianjia Zhang (1): drm/i915: Fix wrong return value in intel_atomic_check()

Re: [PATCH v1] drm/i915/gt: convert tasklets to use new tasklet_setup() API

2020-08-19 Thread Jani Nikula
s the tasklet pointer explicitly. >> >> Signed-off-by: Andy Shevchenko > Reviewed-by: Andy Shevchenko > -Chris Uh, what? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.or

Re: [PATCH 06/20] drm/i915: Introduce GEM object functions

2020-08-13 Thread Jani Nikula
selftests/mock_gem_device.c > index ce4d4303229c..4725dad63e0a 100644 > --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > @@ -86,9 +86,6 @@ static struct drm_driver mock_driver = { > .name = "mock", > .driver_

Re: [PULL] drm-intel-next-fixes

2020-08-12 Thread Jani Nikula
l we stopped introducing them. I'll redo the fixes once we have dinq sorted out. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: WTF: patch "[PATCH] drm/mgag200: Remove declaration of mgag200_mmap() from header" was seriously submitted to be applied to the 5.8-stable tree?

2020-08-10 Thread Jani Nikula
> > Cc: Alex Deucher >> > > Cc: Emil Velikov >> > > Cc: # v5.3+ >> > > Link: >> > > https://patchwork.freedesktop.org/patch/msgid/20200605135803.19811-2-tzimmerm...@suse.de >> > > >> > > diff --git a/drivers/gpu/drm/mgag200/mgag200

Re: [PULL] drm-intel-next

2020-07-15 Thread Jani Nikula
Argh, failed to mention: On Wed, 15 Jul 2020, Jani Nikula wrote: > Lee Shawn C (1): > drm/i915/mst: filter out the display mode exceed sink's capability The above depends on: > Lyude Paul (1): > drm/probe_helper: Add drm_connector_helper_funcs.mode_valid_ctx Which

[PULL] drm-intel-next

2020-07-15 Thread Jani Nikula
i915: Move sseu debugfs under gt/ Flavio Suligoi (1): drm/i915: Fix spelling mistake in i915_reg.h Jani Nikula (1): drm/i915: Update DRIVER_DATE to 20200715 José Roberto de Souza (6): drm/i915/display: Implement new combo phy initialization step drm/i915/ehl: Add new PCI

[PULL] drm-intel-fixes

2020-07-15 Thread Jani Nikula
ps.c| 8 drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_perf.c | 1 + 6 files changed, 39 insertions(+), 33 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-d

[PULL] drm-intel-next

2020-07-02 Thread Jani Nikula
DP_TP_STATUS drm/i915/dp_mst: Clear the ACT sent flag during encoder disabling too drm/i915/dp_mst: Enable VC payload allocation after transcoder is enabled drm/i915/tgl+: Fix TBT DPLL fractional divider for 38.4MHz ref clock drm/i915/icl+: Simplify combo/TBT PLL calculation c

[PULL] drm-intel-fixes

2020-07-01 Thread Jani Nikula
dler for D_SKL_PLUS drm/i915/gvt: Fix two CFL MMIO handling caused by regression. drm/i915/gvt: Fix incorrect check of enabled bits in mask registers drm/i915/gvt: Use GFP_ATOMIC instead of GFP_KERNEL in atomic context Jani Nikula (1): Merge tag 'gvt-fixes-2020-06-17' of https://github

Re: [PATCH v3 00/15] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-06-30 Thread Jani Nikula
100TA BYT + CRC-PMIC PWM > -Toshiba WT8-A BYT + CRC-PMIC PWM > -Thundersoft TS178 BYT + CRC-PMIC PWM, inverse PWM > -Asus T100HA CHT + CRC-PMIC PWM > -Terra Pad 1061 BYT + LPSS PWM > -Trekstor Twin 10.1 BYT + LPSS PWM > -Asus T101HA CHT + CRC-PMIC PWM > -GPD Pocket CHT +

Re: [PATCH] drm/i915/display: fix missing null check on allocated dsb object

2020-06-30 Thread Jani Nikula
ssure! That's like being a lemming when Disney >> film makers come to push you off the cliff to create the 1958 nature >> film "White Wilderness". > > :-) Pushed, thanks for the patch and smile. BR, Jani. > >> >> regards, >> dan carpen

Re: [PATCH][next] drm/i915: fix a couple of spelling mistakes in kernel parameter help text

2020-06-30 Thread Jani Nikula
e safest parameters)"); > > i915_param_named_unsafe(force_probe, charp, 0400, > "Force probe the driver for specified devices. " -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [git pull] drm fixes for v5.8-rc3

2020-06-29 Thread Jani Nikula
ean I get 2x of it next week, > we'll see how it goes. Been really quiet here, basically I only got GVT fixes pending. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freede

Re: [Intel-gfx] [PATCH 1/2] Revert "dma-buf: Report signaled links inside dma-fence-chain"

2020-06-25 Thread Jani Nikula
ialize >> >* @prev: the previous fence >> > * @fence: the current fence >> > - * @seqno: the sequence number (syncpt) of the fence within the chain >> >* >> >* Initialize a new chain node and either start a new chain or add the >> > node to >> >* the existing chain of the previous fence. >> >> ___ >> Intel-gfx mailing list >> intel-...@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH libdrm] intel: sync i915_pciids.h with kernel

2020-06-22 Thread Jani Nikula
) > > +/* DG1 */ > +#define INTEL_DG1_IDS(info) \ > +INTEL_VGA_DEVICE(0x4905, info), \ > +INTEL_VGA_DEVICE(0x4906, info) > + > #endif /* _I915_PCIIDS_H */ -- Jani Nikula, Intel Open Source Graphics Center ___

Re: [PATCH v6 2/5] drm: add constant N value in helper file

2020-06-11 Thread Jani Nikula
6: Change commit message > > Signed-off-by: Chandan Uddaraju > Signed-off-by: Vara Reddy > Signed-off-by: Tanmay Shah Acked-by: Jani Nikula for merging via drm-misc if that helps you. > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > include/drm/drm_dp_helper.h

Re: [Intel-gfx] A panic and a hang in the i915 drm driver

2020-06-10 Thread Jani Nikula
On Mon, 08 Jun 2020, David Howells wrote: > Jani Nikula wrote: > >> David, please try [1]. > > Assuming you mean this: > > https://patchwork.freedesktop.org/patch/366958/?series=77635=1 > > yes, that works. > > Tested-by: David Howells Many thanks, Jani.

Re: A panic and a hang in the i915 drm driver

2020-06-08 Thread Jani Nikula
On Sun, 07 Jun 2020, David Howells wrote: > Hi, > > I'm seeing the attached oops and panic from the i915 drm driver. I've tried > bisecting it, but there's a problem in that one of the merged branches causes > the machine to hang without output. Cc: Ville and GG, I thought this was fixed

Re: [PATCH 01/13] sysctl: add new register_sysctl_subdir() helper

2020-05-29 Thread Jani Nikula
be using static tables for this. It's far from obvious. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [PATCH v2 3/9] drm/i915/display/sdvo: Prefer drm_WARN* over WARN*

2020-05-19 Thread Jani Nikula
On Fri, 08 May 2020, "Laxminarayan Bharadiya, Pankaj" wrote: >> -Original Message----- >> From: Jani Nikula >> Sent: 08 May 2020 12:19 >> To: Laxminarayan Bharadiya, Pankaj >> ; dan...@ffwll.ch; intel- >> g...@lists.freedesktop.org; dr

Re: [PATCH v2 06/16] backlight: improve backlight_device documentation

2020-05-18 Thread Jani Nikula
t;> + * >> + * List entry of all registered backlight devices >> + */ >> struct list_head entry; >> >> +/** >> + * @dev: >> + * >> + * Parent device. >> + */ >> struct device dev; >> >> -/* Multiple framebuffers may share one backlight device */ >> +/** >> + * @fb_bl_on: >> + * >> + * Multiple fbdev's may share one backlight device. The fb_bl_on >> + * records the state of the individual fbdev. >> + */ >> bool fb_bl_on[FB_MAX]; >> >> +/** >> + * @use_count: >> + * >> + * The number of uses of fb_bl_on. >> + */ >> int use_count; >> }; >> >> -- >> 2.25.1 >> -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v12 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-05-18 Thread Jani Nikula
rote: >> On Fri, May 15, 2020 at 04:13:18PM +0300, Jani Nikula wrote: >> > On Fri, 15 May 2020, Ville Syrjälä >> > wrote: >> > > On Thu, May 14, 2020 at 02:19:23PM +0300, Jani Nikula wrote: >> > > > On Thu, 14 May 2020, Gwan-gyeong Mun > &

Re: [PATCH] drm/file: wrap excessively long line

2020-05-18 Thread Jani Nikula
On Mon, 18 May 2020, Emil Velikov wrote: > From: Emil Velikov > > Signed-off-by: Emil Velikov Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/drm_file.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_file.c b/dr

Re: [PATCH v2] drm/debugfs: fix plain echo to connector "force" attribute

2020-05-18 Thread Jani Nikula
On Sun, 17 May 2020, Emil Velikov wrote: > On Thu, 17 Aug 2017 at 12:34, Jani Nikula wrote: >> >> On Thu, 17 Aug 2017, Michael Tretter wrote: >> > Using plain echo to set the "force" connector attribute fails with >> > -EINVAL, because echo appends

Re: [PATCH v12 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-05-15 Thread Jani Nikula
On Fri, 15 May 2020, Ville Syrjälä wrote: > On Thu, May 14, 2020 at 02:19:23PM +0300, Jani Nikula wrote: >> On Thu, 14 May 2020, Gwan-gyeong Mun wrote: >> > In order to readout DP SDPs (Secondary Data Packet: DP HDR Metadata >> > Infoframe SDP, DP VSC SDP), it refac

Re: [PATCH v12 00/14] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-05-14 Thread Jani Nikula
> In order to use a common VSC SDP Colorimetry calculating code on PSR, > it uses a new psr vsc sdp compute routine. Pushed the series to drm-intel-next-queued with Daniel's irc ack for merging the two non-i915 patches that route too. Thanks for the patches and review! BR, Jani. -- Jan

Re: [PATCH v2 3/9] drm/i915/display/sdvo: Prefer drm_WARN* over WARN*

2020-05-08 Thread Jani Nikula
"SDVO TV clock out of range: %i\n", dotclock); > } > > pipe_config->clock_set = true; > @@ -2293,7 +2300,7 @@ intel_sdvo_connector_atomic_get_property(struct > drm_connector *connector, > return 0; > } > > - WARN_ON(1); > + drm_WARN_ON(connector->dev, 1); > *val = 0; > } else if (property == intel_sdvo_connector->top || > property == intel_sdvo_connector->bottom) -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 11/36] drm/gem: add drm_object_put helper

2020-05-08 Thread Jani Nikula
inline void > -drm_gem_object_put_unlocked(struct drm_gem_object *obj) > +drm_gem_object_put(struct drm_gem_object *obj) > { > kref_put(>refcount, drm_gem_object_free); > } > > +#define drm_gem_object_put_unlocked drm_gem_object_put > + > void drm_gem_o

Re: [PATCH] drm: Replace drm_modeset_lock/unlock_all with DRM_MODESET_LOCK_ALL_* helpers

2020-04-29 Thread Jani Nikula
rop_value); > @@ -468,7 +470,7 @@ static int set_property_legacy(struct drm_mode_object > *obj, > break; > } > drm_property_change_valid_put(prop, ref); > - drm_modeset_unlock_all(dev); > + DRM_MODESET_LOCK_ALL_END(ctx, ret); > > retur

Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro

2020-04-27 Thread Jani Nikula
On Fri, 24 Apr 2020, Guru Das Srinagesh wrote: > On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote: >> On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: >> > Since the PWM framework is switching struct pwm_state.duty_cycle's >> > datatype to u64, prepare f

Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro

2020-04-24 Thread Jani Nikula
On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: > Since the PWM framework is switching struct pwm_state.duty_cycle's > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > to handle a 64-bit dividend. > > To: Jani Nikula > Cc: Joonas Lahtinen > Cc: David

Re: [PATCH 0/8] drm, fbdev: rework dependencies

2020-04-21 Thread Jani Nikula
ith this landing. Just not terribly happy if the > underlying issue isn't fixed. And I'll keep ignoring the IS_REACHABLE() patches that make i915 build with a config that should not exist. ;) BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel

Re: [PATCH 0/8] drm, fbdev: rework dependencies

2020-04-21 Thread Jani Nikula
On Tue, 21 Apr 2020, Daniel Vetter wrote: > On Mon, Apr 20, 2020 at 04:03:23PM +0200, Arnd Bergmann wrote: >> On Mon, Apr 20, 2020 at 10:14 AM Jani Nikula >> wrote: >> > On Fri, 17 Apr 2020, Jason Gunthorpe wrote: >> > > On Fri, Apr 17, 2020 at 0

Re: [PATCH 17/18] drm/i915/pm: Prefer drm_WARN_ON over WARN_ON

2020-04-21 Thread Jani Nikula
l_build_plane_wm(struct intel_crtc_state > *crtc_state, > const struct drm_framebuffer *fb = plane_state->hw.fb; > enum plane_id y_plane_id = plane_state->planar_linked_plane->id; > > - WARN_ON(!intel_wm_plane_visible(crtc_state, plane_state)); > - WARN_ON(!fb->format->is_yuv || > - fb->format->num_planes == 1); > + drm_WARN_ON(crtc_state->uapi.crtc->dev, > + !intel_wm_plane_visible(crtc_state, plane_state)); > + drm_WARN_ON(crtc_state->uapi.crtc->dev, !fb->format->is_yuv || > + fb->format->num_planes == 1); Ditto. BR, Jani. > > ret = skl_build_plane_wm_single(crtc_state, plane_state, > y_plane_id, 0); -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 15/18] drm/i915/i915_drv: Prefer drm_WARN_ON over WARN_ON

2020-04-21 Thread Jani Nikula
Y(dev_priv)), > !i915_modparams.disable_display) > +#define INTEL_DISPLAY_ENABLED(dev_priv) \ > + (drm_WARN_ON(_priv->drm, !HAS_DISPLAY(dev_priv)), > !i915_modparams.disable_display) Needs parens around the dev_priv macro argument. BR, Jani. > > static inline boo

Re: [PATCH 12/18] drm/i915/display/tc: Prefer drm_WARN_ON over WARN_ON

2020-04-21 Thread Jani Nikula
> intel_tc_port_link_init_refcount(struct intel_digital_port *dig_port, >int refcount) > { > - WARN_ON(dig_port->tc_link_refcount); > + drm_WARN_ON(dig_port->base.base.dev, dig_port->tc_link_refcount); > dig_port->tc_link_refcount = refcount; > } -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 11/18] drm/i915/display/sdvo: Prefer drm_WARN* over WARN*

2020-04-21 Thread Jani Nikula
i\n", dotclock); > } > > pipe_config->clock_set = true; > @@ -2294,7 +2296,7 @@ intel_sdvo_connector_atomic_get_property(struct > drm_connector *connector, > return 0; > } > > - WARN_ON(1); >

Re: [PATCH 06/18] drm/i915/display/dp: Prefer drm_WARN* over WARN*

2020-04-21 Thread Jani Nikula
_ON_ONCE(intel_dp->active_mst_links < 0); > + drm_WARN_ON_ONCE(>drm, intel_dp->active_mst_links < 0); > bret = intel_dp_get_sink_irq_esi(intel_dp, esi); > go_again: > if (bret == true) { > @@ -5695,11 +5702,12 @@ intel_dp_short_pulse(

Re: [PATCH] drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam

2020-04-20 Thread Jani Nikula
xtreme 2nd > Gen 4K AMOLED panel") > Cc: Adam Jackson > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: "Ville Syrjälä" > --- > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/dr

Re: [PATCH 0/8] drm, fbdev: rework dependencies

2020-04-20 Thread Jani Nikula
acklight build issues on some bizarre configs that nobody will ever use, and would not exist if depends were used throughout. I'm fine with select but only when it's restricted to symbols that have no dependencies of their own and have no UI. This is in line with Documentation/kbuild/kconfig-lang

Re: [PATCH 7/8] fbdev: rework backlight dependencies

2020-04-20 Thread Jani Nikula
about somthing like this: I think this is a hack in Kconfig files that should really be fixed in the Kconfig tooling instead. IMHO Kconfig should be as simple a description of the dependencies as possible, not so much a UI language. FWIW the patch is Acked-by: Jani Nikula BR, Jani. -- Jani

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-17 Thread Jani Nikula
On Fri, 17 Apr 2020, Pekka Paalanen wrote: > On Wed, 15 Apr 2020 17:40:46 +0200 > Hans de Goede wrote: > >> Hi, >> >> On 4/15/20 5:28 PM, Jani Nikula wrote: >> > On Wed, 15 Apr 2020, Hans de Goede wrote: >> >> ii. Currently the "priv

Re: [Intel-gfx] [PATCH 4/5] drm/amdgpu: utilize subconnector property for DP through atombios

2020-04-16 Thread Jani Nikula
On Thu, 16 Apr 2020, Alex Deucher wrote: > On Wed, Apr 15, 2020 at 6:05 AM Jani Nikula wrote: >> >> >> Alex, Harry, Christian, can you please eyeball this series and see if it >> makes sense for you? >> > > Patches 4, 5 are: > Acked-by: Alex Deucher

Re: [RFC 0/6] Regressions for "imply" behavior change

2020-04-16 Thread Jani Nikula
d as a dependency. Of course, this is all just talk until someone(tm) posts a patch actually making the change. I've looked at the kconfig tool sources before; not going to make the same mistake again. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Jani Nikula
On Wed, 15 Apr 2020, Rajat Jain wrote: > Hello, > > On Wed, Apr 15, 2020 at 8:40 AM Hans de Goede wrote: >> >> Hi, >> >> On 4/15/20 5:28 PM, Jani Nikula wrote: >> > On Wed, 15 Apr 2020, Hans de Goede wrote: >> >> ii. Currently the &quo

Re: RFC: Drm-connector properties managed by another driver / privacy screen support

2020-04-15 Thread Jani Nikula
have no in-kernel/in-firmware shortcuts to enable/disable the privacy screen, and instead have any hardware buttons just be events that the userspace could react to. However I don't think that'll be the case unfortunately. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center

Re: [Intel-gfx] [PATCH 4/5] drm/amdgpu: utilize subconnector property for DP through atombios

2020-04-15 Thread Jani Nikula
g *dig_connector = > amdgpu_connector->con_priv; > @@ -343,7 +359,7 @@ int amdgpu_atombios_dp_get_dpcd(struct amdgpu_connector > *amdgpu_connector) > dig_connector->dpcd); > > amdgpu_atombios_dp_probe_oui(amdgpu_connector); > - > + amdgpu_atombios_dp_ds_ports(amdgpu_connector); > return 0; > } -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/5] drm/i915: utilize subconnector property for DP

2020-04-15 Thread Jani Nikula
t supposed to add the Link: tag yourself. Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_dp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index

Re: [PATCH 1/5] drm: report dp downstream port type as a subconnector property

2020-04-15 Thread Jani Nikula
CONNECTOR_X as closely as possible. */ > enum drm_mode_subconnector { > - DRM_MODE_SUBCONNECTOR_Automatic = 0, > - DRM_MODE_SUBCONNECTOR_Unknown = 0, > - DRM_MODE_SUBCONNECTOR_DVID = 3, > - DRM_MODE_SUBCONNECTOR_DVIA = 4, > - DRM_MODE_SUBCONNECTOR_Composite = 5, > - DRM_MODE_SU

Re: [PATCH] drm/i915/gt: remove redundant assignment to variable x

2020-04-15 Thread Jani Nikula
drivers/gpu/drm/i915/intel_engine_cs.c Chris Wilson >> 2018-04-24 1223buf, >> f636edb214a5ff drivers/gpu/drm/i915/intel_engine_cs.cChris Wilson >> 2017-10-09 1224jiffies_to_msecs(jiffies - >> rq->emitted_jiffies), >> ab2681512b4c10 drivers/gpu/drm/i915/intel_engine_cs.cChris Wilson >> 2018-03-14 1225name); >> f636edb214a5ff drivers/gpu/drm/i915/intel_engine_cs.cChris Wilson >> 2017-10-09 1226 } >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org >> > -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PULL] topic/phy-compliance

2020-04-15 Thread Jani Nikula
On Wed, 15 Apr 2020, Daniel Vetter wrote: > On Wed, Apr 15, 2020 at 8:40 AM Jani Nikula > wrote: >> >> On Wed, 08 Apr 2020, Maarten Lankhorst >> wrote: >> > Hey, >> > >> > Here's a pull request to pull in the DP PHY Compliance series. >&

Re: [PATCH] Optimized division operation to shift operation

2020-04-15 Thread Jani Nikula
ug_array_offset_bytes)); >> - ucode_size = le32_to_cpu(hdr->header.ucode_size_bytes) / 4; >> + ucode_size = le32_to_cpu(hdr->header.ucode_size_bytes) >> 2; >> fw_data = (const __le32 *) >> (adev->gmc.fw->data + >> le32_to_cpu(hdr->header.ucode_array_offset_bytes)); >> >> -- >> 2.7.4 >> >> ___ >> amd-gfx mailing list >> amd-...@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] component: Silence bind error on -EPROBE_DEFER

2020-04-15 Thread Jani Nikula
On Tue, 14 Apr 2020, James Hilliard wrote: > On Tue, Apr 14, 2020 at 5:07 AM Jani Nikula > wrote: >> >> On Fri, 10 Apr 2020, James Hilliard wrote: >> > If a component fails to bind due to -EPROBE_DEFER we should not log an >> > error as this is not a real fa

Re: [PATCH 5/5] drm/i915: Replace "Broadcast RGB" with "RGB quantization range" property

2020-04-15 Thread Jani Nikula
On Tue, 14 Apr 2020, Yussuf Khalil wrote: > On Tue, 2020-04-14 at 14:34 +0200, Daniel Vetter wrote: >> On Tue, Apr 14, 2020 at 02:21:06PM +0300, Jani Nikula wrote: >> > On Tue, 14 Apr 2020, Jani Nikula >> > wrote: >> > > On Mon, 13 Apr 2020, Simon Ser wr

  1   2   3   4   5   6   7   8   9   10   >