On Mon, 22 Apr 2024, Jani Nikula wrote:
> Surprisingly many places depend on debugfs.h to be included via
> drm_print.h. Fix them.
>
> v3: Also fix armada, ite-it6505, imagination, msm, sti, vc4, and xe
>
> v2: Also fix ivpu and vmwgfx
>
> Reviewed-by: Andrzej Hajda
&
On Wed, 24 Apr 2024, Ryszard Knop wrote:
> - Switch drm-intel URLs to the new GitLab location.
> - Add a short SSH link for drm-xe for completeness with other blocks.
> - Add a missing tab in drm_tip_config for column alignment.
>
> Signed-off-by: Ryszard Knop
Acked-
On Wed, 24 Apr 2024, Ryszard Knop wrote:
> The drm-intel repo is moving from the classic fd.o git host to GitLab.
> Update its location with a URL matching other fd.o GitLab kernel trees.
>
> Signed-off-by: Ryszard Knop
Acked-by: Jani Nikula
> ---
> MAINTAINERS | 2 +-
&g
d 'endmenu' becomes the submenu.
>>
> ...
>>
>> Signed-off-by: Masahiro Yamada
>
> I think this is a useful cleanup.
Yeah, thanks for the good explanation!
However, it won't apply to current drm trees.
BR,
Jani.
--
Jani Nikula, Intel
t; Rodrigo, This set is containing Xe display changes as well. Is it ok to
> push this via drm-intel?
For that we'll need an ack from the xe maintainers; usually Lucas for
the display stuff.
BR,
Jani.
--
Jani Nikula, Intel
can we please drop these changes from the DRM tree until some
> strategy for getting everything merged is put into place?
This is what's being done [1].
BR,
Jani.
[1] https://lore.kernel.org/r/cover.1713780345.git.geert+rene...@glider.be
--
Jani Nikula, Intel
On Mon, 22 Apr 2024, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Signed-off-by: Andy Shevchenko
Assuming it builds, and nothing depends on other stuff from kernel.h via
drm_fixed.h,
Reviewed-by: Jani Nikula
> ---
da-san: would it be difficult to modify Kconfig to ignore symbols
> like DRIVER that select other symbols with unmet dependencies?
> Currently it already warns about that.
>
> Handling this implicitly (instead of the current explict "depends
> on") would have the disadvantage though: a user who is not aware of
> the implicit dependency may wonder why DRIVER is invisible in his
> config interface.
--
Jani Nikula, Intel
On Mon, 22 Apr 2024, "Arnd Bergmann" wrote:
> On Mon, Apr 22, 2024, at 15:28, Jani Nikula wrote:
>> On Mon, 22 Apr 2024, "Arnd Bergmann" wrote:
>>> On Mon, Apr 22, 2024, at 13:50, Jani Nikula wrote:
>>>
>>>> I still disagree with this,
So how can this be fixed? I've considered matching the aspect ratio based
> on the DRM_CLIENT_CAP_ASPECT_RATIO capability, but I'm not sure if that is
> valid. The documentation is limited and I found nothing that describes what
> the userspace should do here.
> Or would a new capability make sense here? Or something entirely different?
> I'm not sure how I should proceed here. Any help would be appreciated.
>
> Regards,
> Michael
--
Jani Nikula, Intel
On Mon, 22 Apr 2024, "Arnd Bergmann" wrote:
> On Mon, Apr 22, 2024, at 13:50, Jani Nikula wrote:
>> On Mon, 22 Apr 2024, Geert Uytterhoeven wrote:
>>> Hi all,
>>>
>>> As discussed on IRC with Maxime and Arnd, this series reverts the
>>>
On Thu, 18 Apr 2024, Jani Nikula wrote:
> On Thu, 18 Apr 2024, Robert Foss wrote:
>> I'm seeing build errors for drivers/gpu/drm/bridge/ite-it6505.c, is
>> this expected?
>
> No, but it's possible my configs didn't catch all configs. :(
Okay, enabled a bunch more arm/arm6
Never include where a forward declaration will suffice.
Reviewed-by: Andrzej Hajda
Acked-by: Maxime Ripard
Link:
https://patchwork.freedesktop.org/patch/msgid/20240410141434.157908-2-jani.nik...@intel.com
Signed-off-by: Jani Nikula
---
include/drm/drm_print.h | 2 +-
1 file changed, 1
/20240410141434.157908-1-jani.nik...@intel.com
Signed-off-by: Jani Nikula
---
Cc: Jacek Lawrynowicz
Cc: Stanislaw Gruszka
Cc: Oded Gabbay
Cc: Russell King
Cc: David Airlie
Cc: Daniel Vetter
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej
nel/Kconfig | 32 -
> drivers/gpu/drm/radeon/Kconfig | 8 +++
> drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +-
> drivers/gpu/drm/rockchip/Kconfig| 10
> drivers/gpu/drm/sun4i/Kconfig | 2 +-
> drivers/gpu/drm/tegra/Kconfig | 8 +++
> drivers/gpu/drm/vc4/Kconfig | 10
> drivers/gpu/drm/xe/Kconfig | 13 --
> drivers/gpu/drm/xlnx/Kconfig| 8 +++
> 25 files changed, 116 insertions(+), 138 deletions(-)
--
Jani Nikula, Intel
On Fri, 19 Apr 2024, Maxime Ripard wrote:
> On Fri, Apr 19, 2024 at 03:35:55PM +0300, Jani Nikula wrote:
>> On Thu, 04 Apr 2024, "Nautiyal, Ankit K" wrote:
>> > On 3/19/2024 3:16 PM, Maxime Ripard wrote:
>> >> On Mon, Mar 18, 2024 at 04:37:58PM +0200,
te - Create a DP tunnel manager
> * @dev: DRM device object
> + * @max_group_count: Maximum number of tunnel groups
> *
> * Creates a DP tunnel manager for @dev.
> *
--
Jani Nikula, Intel
On Thu, 04 Apr 2024, "Nautiyal, Ankit K" wrote:
> On 3/19/2024 3:16 PM, Maxime Ripard wrote:
>> On Mon, Mar 18, 2024 at 04:37:58PM +0200, Jani Nikula wrote:
>>> On Mon, 11 Mar 2024, Mitul Golani
>>> wrote:
>>>> An Adaptive-Sync-capable
On Thu, 18 Apr 2024, Robert Foss wrote:
> I'm seeing build errors for drivers/gpu/drm/bridge/ite-it6505.c, is
> this expected?
No, but it's possible my configs didn't catch all configs. :(
BR,
Jani.
--
Jani Nikula, Intel
Never include where a forward declaration will suffice.
Reviewed-by: Andrzej Hajda
Acked-by: Maxime Ripard
Link:
https://patchwork.freedesktop.org/patch/msgid/20240410141434.157908-2-jani.nik...@intel.com
Signed-off-by: Jani Nikula
---
include/drm/drm_print.h | 2 +-
1 file changed, 1
Surprisingly many places depend on debugfs.h to be included via
drm_print.h. Fix them.
v2: Also fix ivpu and vmwgfx
Reviewed-by: Andrzej Hajda
Acked-by: Maxime Ripard
Link:
https://patchwork.freedesktop.org/patch/msgid/20240410141434.157908-1-jani.nik...@intel.com
Signed-off-by: Jani Nikula
On Wed, 17 Apr 2024, Thomas Zimmermann wrote:
>> Many thanks! Just to double check, do you want me to move patch 5
>> earlier and squash patches 6&7?
>
> Your choice. Either is fine by me.
I jumped at the easy option and merged this as-is. :)
Thanks again,
Jani.
--
Jani Nikula, Intel
ink) devices requiring this quirk doesn't advertise the
What are you trying to say with "UHBR (MST sink)"? We've (read: I) have
been confused by this in the past, and casually equating UHBR and MST
isn't helping.
BR,
Jani.
> + * HBLANK expansion support. Presuming that they perform HBLANK
> + * expansion internally, or are affected by this issue on modes with a
> + * short HBLANK for other reasons.
> + */
> + if (!drm_dp_uhbr_channel_coding_supported(dpcd) &&
> + !(dpcd[DP_RECEIVE_PORT_0_CAP_0] & DP_HBLANK_EXPANSION_CAPABLE))
> return false;
>
> drm_dbg_kms(>drm,
--
Jani Nikula, Intel
ns drm_dp_128b132b_* in the same
file, and I think this one should be named similarly. Maybe just
drm_dp_128b132b_supported(), and rename
drm_dp_channel_coding_supported() to drm_dp_8b10b_supported() to unify?
BR,
Jani.
> +
> static inline bool
> drm_dp_alternate_scrambler_reset_cap(const u8 dpcd[DP_RECEIVER_CAP_SIZE])
> {
--
Jani Nikula, Intel
On Tue, 16 Apr 2024, Thomas Zimmermann wrote:
> Hi
>
> Am 16.04.24 um 14:27 schrieb Jani Nikula:
>> On Tue, 16 Apr 2024, Thomas Zimmermann wrote:
>>> Hi
>>>
>>> Am 16.04.24 um 11:20 schrieb Jani Nikula:
>>>> Repurpose drm_edid_are_equal() t
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Sandy Huang
Cc: "Heiko Stübner"
Cc: Andy Yan
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-rockc...@lists.infradead.org
---
drivers/gpu/drm/rockchip/rk3066_hdmi.c | 12 +-
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Sandy Huang
Cc: "Heiko Stübner"
Cc: Andy Yan
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-rockc...@lists.infradead.org
---
drivers/gpu/drm/rockchip/inno_hdmi.c | 12 +-
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Sandy Huang
Cc: "Heiko Stübner"
Cc: Andy Yan
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-rockc...@lists.infradead.org
---
drivers/gpu/drm/rockchip/cdn-dp-c
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: David Airlie
Cc: Gerd Hoffmann
Cc: Gurchetan Singh
Cc: Chia-I Wu
Cc: virtualizat...@lists.linux.dev
---
drivers/gpu/drm/virtio/virtgpu_display.c | 10 --
drivers/gpu/drm/virtio
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Gerd Hoffmann
Cc: virtualizat...@lists.linux.dev
---
drivers/gpu/drm/tiny/bochs.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/tiny
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Russell King
---
drivers/gpu/drm/i2c/tda998x_drv.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm/i2c
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: "Noralf Trønnes"
---
drivers/gpu/drm/gud/gud_connector.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/gud/gud_connector.c
b/drivers/g
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 26 +++
drivers/gpu
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Maxime Ripard
Cc: Maarten Lankhorst
Cc: Thomas Zimmermann
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 46 ++
1 file changed, 25 insertions(+), 21 deletions(-)
diff --git
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Douglas Anderson
Cc: Neil Armstrong
Cc: Jessica Zhang
Cc: Sam Ravnborg
---
drivers/gpu/drm/panel/panel-edp.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Maxime Ripard
Cc: Chen-Yu Tsai
Cc: Jernej Skrabec
Cc: Samuel Holland
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-su...@lists.linux.dev
---
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 18
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
---
.../gpu/drm/bridge/analogix/analogix-anx6345.c| 15 +++
1 file
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
---
.../drm/bridge/analogix/analogix-anx78xx.c| 23 ++-
1 file
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Neil Armstrong
Cc: Jessica Zhang
Cc: Sam Ravnborg
---
drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu
Prefer struct drm_edid based functions over struct edid.
Signed-off-by: Jani Nikula
---
Cc: Neil Armstrong
Cc: Jessica Zhang
Cc: Sam Ravnborg
---
drivers/gpu/drm/panel/panel-simple.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/panel
I've these laying in a branch for a while, maybe let's try to make some
forward progress in this front.
Build tested only, on x86, arm, and arm64.
BR,
Jani.
Jani Nikula (15):
drm/panel: simple: switch to struct drm_edid
drm/panel-samsung-atna33xc20: switch to struct drm_edid
drm/panel
On Tue, 16 Apr 2024, Thomas Zimmermann wrote:
> Hi
>
> Am 16.04.24 um 11:20 schrieb Jani Nikula:
>> Repurpose drm_edid_are_equal() to be more helpful for its single user,
>> and rename drm_edid_eq(). Functionally deduce the length from the blob
>> size, not the blob
On Tue, 16 Apr 2024, Thomas Zimmermann wrote:
> Hi
>
> Am 16.04.24 um 11:19 schrieb Jani Nikula:
>> Prefer the EDID iterators over drm_edid_find_extension() in
>> drm_edid_has_cta_extension(), even if this leads to more code. The key
>> is to use the same patterns as m
drm_edid_are_equal() is only used within drm_edid.c. Make it static. Do
not encourage more uses of struct edid.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 3 +--
include/drm/drm_edid.h | 2 --
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm
Repurpose drm_edid_are_equal() to be more helpful for its single user,
and rename drm_edid_eq(). Functionally deduce the length from the blob
size, not the blob data, making it more robust against any errors.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 41
Prefer the EDID iterators over drm_edid_find_extension() in
drm_edid_has_cta_extension(), even if this leads to more code. The key
is to use the same patterns as much as possible.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 14 --
1 file changed, 12 insertions(+), 2
Follow the drm_edid_ naming convention.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_internal.h | 2 +-
drivers/gpu/drm/drm_displayid.c | 3 ++-
drivers/gpu/drm/drm_edid.c | 4 ++--
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm
Keep the declarations for struct drm_edid based functions together.
Signed-off-by: Jani Nikula
---
include/drm/drm_edid.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
index 324e900cc287..92fff199aa78 100644
There are no exported symbols for displayid, and it's all internal
interfaces. Move the header to drivers/gpu/drm/drm_displayd_internal.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_displayid.c | 3 ++-
.../gpu/drm/drm_displayid_internal.h
The declarations for internal EDID functions are a bit scattered. Put
them all in drm_crtc_internal.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_crtc_internal.h | 6 ++
drivers/gpu/drm/drm_displayid.c | 1 +
drivers/gpu/drm/drm_eld.c | 4 +++-
drivers/gpu/drm
Rebase.
Jani Nikula (7):
drm/displayid: move drm_displayid.h to drm_displayd_internal.h
drm/edid: move all internal declarations to drm_crtc_internal.h
drm/edid: group struct drm_edid based declarations together
drm/edid: rename drm_find_edid_extension() to
drm_edid_find_extension
truct intel_gt *gt;
>> > + int i;
>> > +
>> > + if (!hwmon)
>> > + return;
>> > +
>> > + for_each_gt(gt, i915, i) {
>> > + struct hwm_drvdata *ddat_gt = hwmon->ddat_gt + i;
>> > +
>> > + if (ddat_gt->hwmon_dev) {
>> > + hwmon_device_unregister(ddat_gt->hwmon_dev);
>> > + ddat_gt->hwmon_dev = NULL;
>> > + }
>> > + }
>> > +
>> > + if (ddat->hwmon_dev)
>> > + hwmon_device_unregister(ddat->hwmon_dev);
>> > +
>> > + mutex_destroy(>hwmon_lock);
>> > + kfree(hwmon);
>> > }
>
> Thanks.
> --
> Ashutosh
--
Jani Nikula, Intel
On Mon, 08 Apr 2024, Jani Nikula wrote:
> v2 of [1], dropping drm_mode_print() stuff altogether, and switching to
> DRM_MODE_FMT/DRM_MODE_ARG() in a separate patch. Also add a few more drm
> device based logging conversion patches, so the last patch makes more sense.
Thanks for th
On Wed, 10 Apr 2024, Jani Nikula wrote:
> We've accumulated enough Intel specific header files under include/drm
> that they warrant a subdirectory of their own. Clean up the top drm
> header directory by moving the Intel files under include/drm/intel.
>
> Since i915 is most impa
On Wed, 10 Apr 2024, Jani Nikula wrote:
> Surprisingly many places depend on debugfs.h to be included via
> drm_print.h. Fix them.
While all of this is trivial, merely adding some includes, please
consider acking the changes to your corner of the kernel.
Thanks,
Jani.
>
> Signed-
On Tue, 09 Apr 2024, Ville Syrjälä wrote:
> On Tue, Apr 09, 2024 at 12:46:11PM +0300, Jani Nikula wrote:
>> To avoid accessing and parsing the raw EDID with drm_edid_raw(), switch
>> to the struct drm_edid based function to extract product id, and use the
>> drm printer
"intel_crtc.h"
> #include "intel_de.h"
> #include "intel_crtc_state_dump.h"
> @@ -1542,6 +1543,7 @@ void intel_connector_debugfs_add(struct intel_connector
> *connector)
> intel_drrs_connector_debugfs_add(connector);
> intel_pps_connector_debugfs_add(connector);
> intel_psr_connector_debugfs_add(connector);
> + intel_alpm_lobf_debugfs_add(connector);
>
> if (connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> connector_type == DRM_MODE_CONNECTOR_HDMIA ||
--
Jani Nikula, Intel
ypes.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1884,6 +1884,7 @@ struct intel_dp {
>
> /* LOBF flags*/
> bool lobf_supported;
> + bool lobf_enabled;
> };
>
> enum lspcon_vendor {
--
Jani Nikula, Intel
tate,
> + struct drm_connector_state *conn_state);
> void intel_alpm_configure(struct intel_dp *intel_dp);
>
> #endif
--
Jani Nikula, Intel
6 +246,7 @@ i915-y += \
> display/intel_atomic.o \
> display/intel_atomic_plane.o \
> display/intel_audio.o \
> + display/intel_alpm.o \
> display/intel_bios.o \
> display/intel_bw.o \
> display/intel_cdclk.o \
That's not sorted.
BR,
Jani.
--
Jani Nikula, Intel
On Wed, 05 Apr 2023, Steven Price wrote:
> On 31/03/2023 09:31, Jani Nikula wrote:
>> On Thu, 30 Mar 2023, Andrew Morton wrote:
>>> On Thu, 30 Mar 2023 21:53:03 + David Laight
>>> wrote:
>>>
>>>>> But wouldn't all these issues be addresse
K_2_FOO))
...
Or just pass iter and block like for displayid_is_tiled_block().
IDK if that becomes unwieldy at the call sites. Maybe we'll need
additional specific helpers like displayid_is_tiled_block() on top.
Anyway, on the patch at hand,
Acked-by: Jani Nikula
>
> So f
yway, all that said,
Acked-by: Jani Nikula
on the i915 changes here.
BR,
Jani.
[1] https://lwn.net/Articles/737094/
--
Jani Nikula, Intel
: Thomas Hellström
Cc: Tvrtko Ursulin
Signed-off-by: Jani Nikula
---
MAINTAINERS | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e7a511b443af..a71254fdbf4c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10841,6 +10841,7 @@ S: Supported
-by: Jani Nikula
---
Documentation/gpu/i915.rst | 2 +-
drivers/gpu/drm/i915/display/intel_audio.c | 2 +-
drivers/gpu/drm/i915/display/intel_hdcp.c| 2 +-
drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 2 +-
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 2 +-
drivers/gpu/drm/xe
On Thu, 11 Apr 2024, Andi Shyti wrote:
> Hi Jani,
>
> On Wed, Apr 10, 2024 at 01:26:15PM +0300, Jani Nikula wrote:
>> Clean up the top level include/drm directory by grouping all the Intel
>> specific files under a common subdirectory.
>>
>> v2: Also fix co
On Thu, 11 Apr 2024, Andi Shyti wrote:
> Hi Jani,
>
> On Wed, Apr 10, 2024 at 01:05:12PM +0300, Jani Nikula wrote:
>> Clean up the top level include/drm directory by grouping all the Intel
>> specific files under a common subdirectory.
>>
>> Cc: Daniel Vetter
&g
Surprisingly many places depend on debugfs.h to be included via
drm_print.h. Fix them.
Signed-off-by: Jani Nikula
---
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc: Jonas Karlman
Cc: Jernej Skrabec
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas
Never include where a forward declaration will suffice.
Signed-off-by: Jani Nikula
---
include/drm/drm_print.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index 561c3b96b6fd..089950ad8681 100644
--- a/include/drm
On Tue, 02 Apr 2024, Jani Nikula wrote:
> Ensure drm headers build, are self-contained, have header guards, and
> have no kernel-doc warnings, when CONFIG_DRM_HEADER_TEST=y.
>
> The mechanism follows similar patters used in i915, xe, and usr/include.
>
> To cover include/drm,
-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c | 2 +-
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
drivers/gpu/drm/i915/gt/intel_ggtt.c | 2 +-
drivers/gpu/drm/i915/gt/intel_rps.c| 2 +-
drivers/gpu/drm/i915/intel_pci_config.h| 2 +-
drivers/gpu/drm/i915/soc
On Wed, 10 Apr 2024, Ilpo Järvinen wrote:
> Could you please also address the comment in
> drivers/gpu/drm/i915/intel_pci_config.h.
Ack.
--
Jani Nikula, Intel
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/xe/xe_pci.c | 2 +-
include/drm/{ => intel}/xe_pciids.h | 0
2 fi
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Tomas Winkler
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_types.h| 2 +-
drivers/gpu
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Tomas Winkler
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 2 +-
drivers/misc/mei
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 2
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Bjorn Helgaas
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c | 2 +-
drivers/gpu
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Bjorn Helgaas
Cc: Hans de Goede
Cc: Ilpo Järvinen
Signed-off-by: Jani Nikula
---
arch/x86/kernel/early-quirks.c
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Tomas Winkler
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Cc: Tomas Winkler
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_proxy.c | 2 +-
drivers
Clean up the top level include/drm directory by grouping all the Intel
specific files under a common subdirectory.
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Lucas De Marchi
Signed-off-by: Jani Nikula
---
drivers/char/agp/intel-agp.c | 2 +-
drivers/char/agp/intel-gtt.c
Use <> instead of "" for including headers from include/, even if the
file is in the same directory.
Signed-off-by: Jani Nikula
---
include/drm/i915_component.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/i915_component.h b/include/drm/i915_c
if this is fine for you.
BR,
Jani.
Cc: Bjorn Helgaas
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: Hans de Goede
Cc: Ilpo Järvinen
Cc: Jaroslav Kysela
Cc: Lucas De Marchi
Cc: Takashi Iwai
Cc: Tomas Winkler
Jani Nikula (10):
drm/i915: use system include for drm headers
drm: move intel-gtt.h
On Wed, 10 Apr 2024, Javier Martinez Canillas wrote:
> Jani Nikula writes:
>
>> gma_drm.h has become an empty, unused header. Remove.
>>
>> Cc: Patrik Jakobsson
>> Signed-off-by: Jani Nikula
>> ---
>
> Reviewed-by: Javier Martinez Canillas
On Tue, 09 Apr 2024, Geert Uytterhoeven wrote:
> Hi Jani,
>
> On Tue, Apr 9, 2024 at 12:04 PM Jani Nikula
> wrote:
>> On Tue, 09 Apr 2024, Geert Uytterhoeven wrote:
>> > The user should not need to know which helpers are needed for the driver
>> > he is i
| 45 +--
> 2 files changed, 81 insertions(+), 21 deletions(-)
> ---
> base-commit: e495e523b888a6155f82c767d34c8d712a41ee54
> change-id: 20240327-google-drm-doc-cd275291792f
>
> Best regards,
--
Jani Nikula, Intel
On Tue, 09 Apr 2024, Ingo Molnar wrote:
> * Jani Nikula wrote:
>
>> On Mon, 08 Apr 2024, Namhyung Kim wrote:
>> > To pick up changes from:
>> >
>> >b112364867499 ("drm/i915: Add GuC submission interface version query")
>> &
to enable
a kconfig option with all its dependencies, recursively. This is what we
lack.
BR,
Jani.
[1] Documentation/kbuild/kconfig-language.rst "reverse dependencies"
--
Jani Nikula, Intel
Use a more suitable type to avoid the cast.
Cc: Ville Syrjälä
Acked-by: Melissa Wen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
b/drivers/gpu/drm
, albeit with slightly different
member definitions.
Cc: Ville Syrjälä
Acked-by: Melissa Wen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bios.c | 43 ++-
1 file changed, 18 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 44 ++
include/drm/drm_edid.h | 3 +++
2 files changed, 47 insertions(+)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 626a0e24e66a..1400722ae3fe 100644
--- a/drivers
-by: Melissa Wen
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid.c | 15 +++
include/drm/drm_edid.h | 25 -
2 files changed, 35 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index ea77577a3786
v2 with __be16 manufacturer_name in patch 1 and revamped date printing
in patch 2.
Jani Nikula (4):
drm/edid: add drm_edid_get_product_id()
drm/edid: add drm_edid_print_product_id()
drm/i915/bios: switch to struct drm_edid and struct
drm_edid_product_id
drm/i915/bios: return
On Mon, 08 Apr 2024, Ville Syrjälä wrote:
> On Thu, Mar 21, 2024 at 12:05:10PM +0200, Jani Nikula wrote:
>> Add a function to print a decoded EDID vendor and product id to a drm
>> printer, optinally with the raw data.
>>
>> Signed-off-by: Jani Nikula
>> ---
&g
On Mon, 08 Apr 2024, Ville Syrjälä wrote:
> On Thu, Mar 21, 2024 at 12:05:09PM +0200, Jani Nikula wrote:
>> Add a struct drm_edid based function to get the vendor and product ID
>> from an EDID. Add a separate struct for defining this part of the EDID,
>> with defined byte o
guments and it addresses
> these tools/perf build warnings:
>
> Warning: Kernel ABI header differences:
> diff -u tools/include/uapi/drm/i915_drm.h include/uapi/drm/i915_drm.h
All these years and I never realized there are header copies
there. But... why copies?
BR,
Jani.
--
Jani Nikula, Intel
On Mon, 08 Apr 2024, Melissa Wen wrote:
> On 04/08, Jani Nikula wrote:
>> On Mon, 08 Apr 2024, Melissa Wen wrote:
>> > On 04/02, Jani Nikula wrote:
>> >> On Thu, 21 Mar 2024, Jani Nikula wrote:
>> >> > Jani Nikula (4):
>> >> > drm
On Mon, 08 Apr 2024, Melissa Wen wrote:
> On 04/02, Jani Nikula wrote:
>> On Thu, 21 Mar 2024, Jani Nikula wrote:
>> > Jani Nikula (4):
>> > drm/edid: add drm_edid_get_product_id()
>> > drm/edid: add drm_edid_print_product_id()
>> > drm/i9
gma_drm.h has become an empty, unused header. Remove.
Cc: Patrik Jakobsson
Signed-off-by: Jani Nikula
---
include/drm/gma_drm.h | 13 -
1 file changed, 13 deletions(-)
delete mode 100644 include/drm/gma_drm.h
diff --git a/include/drm/gma_drm.h b/include/drm/gma_drm.h
deleted file
On Mon, 08 Apr 2024, Dmitry Baryshkov wrote:
> On Mon, 8 Apr 2024 at 11:09, Jani Nikula wrote:
>> Thanks! Do you take this via the msm tree?
>
> Yes, I will
Forgot to mention, there's a Tested-by at [1].
Tested-by: Aishwarya TCV
[1] https://lore.kernel.org/r/157e69d4-850f-40d2
1 - 100 of 5046 matches
Mail list logo
