Re: [Intel-gfx] [PATCH v1 0/2] drm: drop uapi dependencies from include/drm

2019-06-24 Thread Jani Nikula
parameters or return types, right? So we do have some we've screwed up, but it's not nearly as bad as the git grep above would lead you to believe. The ones in question are used in struct drm_map which is used in DRM_IOCTL_GET_MAP, DRM_IOCTL_ADD_MAP, and DRM_IOCTL_RM_MAP. BR,

[PULL] drm-intel-fixes

2019-06-20 Thread Jani Nikula
7:09 +0300) drm/i915 fixes for v5.2-rc6: - GVT: Fix reserved PVINFO register write (Weinan) - Avoid clobbering M/N values in fastset fuzzy checks (Ville) ---- Jani Nikul

Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-20 Thread Jani Nikula
er > without modifying the argument list that calls > hex_dump_to_buffer with whatever added argument content > you need. > > Something like: > > static inline > int hex_dump_to_buffer(const void *buf, size_t len, int rowsize, > int groupsize, ch

Re: KMS documentation for userspace

2019-06-19 Thread Jani Nikula
f the igt conversion, and added some manual polish on top. I'm not volunteering for the libdrm man page conversion though. ;) BR, Jani. [1] https://gitlab.freedesktop.org/drm/igt-gpu-tools/commit/cc7387f17ce5750fc640355d94ed60b6936c2d7b -- Jani Nikula, Intel Open Source Graphi

Re: [PATCH] drm: self_refresh: Fix a reversed condition in drm_self_refresh_helper_cleanup()

2019-06-19 Thread Jani Nikula
struct drm_self_refresh_data *sr_data = crtc->self_refresh_data; >> >> /* Helper is already uninitialized */ >> -if (sr_data) >> +if (!sr_data) >> return; >> >> crtc->self_refresh_data

[PULL] drm-intel-next

2019-06-19 Thread Jani Nikula
drm/i915/dsi: Read back pclk set by GOP and use that as pclk (v3) Imre Deak (2): drm/i915/icl: Fix AUX-B HW not done issue w/o AUX-A drm/i915/icl: Ensure port A combo PHY HW state is correct Jani Nikula (28): drm/i915: make REG_BIT() and REG_GENMASK() work with variables

Re: linux-next: manual merge of the drm tree with the kbuild tree

2019-06-19 Thread Jani Nikula
conflicts should be mentioned to your upstream maintainer when your tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any particularly > complex conflicts. LGTM, thanks. BR, Jani. -- Jani Nikula, Intel Open Sou

Re: [RESEND FOR CI] i915: no need to check return value of debugfs_create functions

2019-06-17 Thread Jani Nikula
On Thu, 13 Jun 2019, Jani Nikula wrote: > From: Greg Kroah-Hartman > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jani

Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

2019-06-17 Thread Jani Nikula
On Fri, 14 Jun 2019, Maxime Ripard wrote: > Hi Jani, > > On Fri, Jun 14, 2019 at 03:28:59PM +0300, Jani Nikula wrote: >> On Fri, 14 Jun 2019, Maxime Ripard wrote: >> > The drm_client_modeset_commit_atomic function uses two times the >> > plane_state

Re: [PATCH 59/59] drm/doc: Document kapi doc expectations

2019-06-17 Thread Jani Nikula
> Cc: Laurent Pinchart > Cc: Jani Nikula > Cc: David Airlie > Cc: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul Acked-by: Jani Nikula > --- > Documentation/gpu/introduction.rst | 13 + > Documentation/gpu/todo.rst

Re: [PATCH v3 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-17 Thread Jani Nikula
line, sizeof(line), > - false) >= sizeof(line)); > + 0) >= sizeof(line)); > drm_printf(m, "[%04zx] %s\n", pos, line); > > prev = buf + pos

Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

2019-06-14 Thread Jani Nikula
struct drm_plane_state *plane_state; > + > /* Cannot fail as we've already gotten the plane state > above */ > plane_state = drm_atomic_get_new_plane_state(state, > primary); > plane_state->rotation = rotation

Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

2019-06-14 Thread Jani Nikula
915/Makefile we actually go for much stricter warnings than the kernel defaults, and disable a more limited and tailored set of warnings. You can do this both on a subdir and file level with subdir-ccflags-y and CFLAGS_filename.o, respectively. BR, Jani. -- Jani Nikul

Re: [PATCH] i915: no need to check return value of debugfs_create functions

2019-06-13 Thread Jani Nikula
On Thu, 13 Jun 2019, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jani Nikula > Cc: Joonas Lahtinen

[RESEND FOR CI] i915: no need to check return value of debugfs_create functions

2019-06-13 Thread Jani Nikula
From: Greg Kroah-Hartman When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: David Airlie Cc: Daniel

[PULL] drm-intel-fixes

2019-06-13 Thread Jani Nikula
+++--- drivers/gpu/drm/i915/intel_sdvo_regs.h | 3 ++ 8 files changed, 91 insertions(+), 16 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [PATCH] drm/edid: parse CEA blocks embedded in DisplayID

2019-06-13 Thread Jani Nikula
fault: > DRM_DEBUG_KMS("found DisplayID tag 0x%x, unhandled\n", > block->tag); > break; > diff --git a/include/drm/drm_displayid.h b/include/drm/drm_displayid.h > index c0d4df6a606f..c7af857f4764 100644 > --- a/include/drm/drm_d

Re: DRM/AST regression (likely 4.14 -> 4.19+), providing EDID manually fails

2019-06-12 Thread Jani Nikula
ms). This should be fixed by commit commit 48eaeb7664c76139438724d520a1ea4a84a3ed92 Author: Jani Nikula Date: Mon Jun 10 12:30:54 2019 +0300 drm: add fallback override/firmware EDID modes workaround in drm-misc-fixes, cc: stable v4.15. Thanks for the report. BR, Jani. -- Jani Nikula,

Re: [PATCH v2] drm: add fallback override/firmware EDID modes workaround

2019-06-12 Thread Jani Nikula
On Tue, 11 Jun 2019, Paul Wise wrote: > On Mon, 2019-06-10 at 12:30 +0300, Jani Nikula wrote: >> We've moved the override and firmware EDID (simply "override EDID" from >> now on) handling to the low level drm_do_get_edid() function in order to >> transparen

Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-12 Thread Jani Nikula
us that, while the rotation would be a transformation from that > default to whatever the user wants. > > More importantly, the orientation is a property of the hardware (ie, > how the display has been assembled), while the rotation is a software > construct. FWIW, agreed. The immutable orient

Re: [PATCH 4/5] drm/connector: Split out orientation quirk detection

2019-06-11 Thread Jani Nikula
ector.h b/include/drm/drm_connector.h > index 47e749b74e5f..c2992f7a0dd5 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -1370,7 +1370,7 @@ void drm_connector_set_link_status_property(struct > drm_connector *connector, > void drm_connector_set_vrr_cap

Re: [PATCH 2/2] drm: add fallback override/firmware EDID modes workaround

2019-06-10 Thread Jani Nikula
he backtrace might offer clues. Thanks for testing! BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2] drm: add fallback override/firmware EDID modes workaround

2019-06-10 Thread Jani Nikula
niel Vetter References: 15f080f08d48 ("drm/edid: respect connector force for drm_get_edid ddc probe") Fixes: 53fd40a90f3c ("drm: handle override and firmware EDID at drm_do_get_edid() level") Cc: # v4.15+ Cc: Daniel Vetter Cc: Ville Syrjälä Cc: Harish Chego

Re: DRM/AST regression (likely 4.14 -> 4.19+), providing EDID manually fails

2019-06-07 Thread Jani Nikula
On Tue, 04 Jun 2019, Ilpo Järvinen wrote: > Yes, if it applies fine to 5.1. ...Also, it will take a week or so. Please try these two patches instead: https://patchwork.freedesktop.org/series/61764/ BR, Jani. -- Jani Nikula, Intel Open Source Graphics Cen

[PATCH 2/2] drm: add fallback override/firmware EDID modes workaround

2019-06-07 Thread Jani Nikula
s: 15f080f08d48 ("drm/edid: respect connector force for drm_get_edid ddc probe") Fixes: 53fd40a90f3c ("drm: handle override and firmware EDID at drm_do_get_edid() level") Cc: # v4.15+ Cc: Daniel Vetter Cc: Ville Syrjälä Cc: Harish Chegondi S

[PATCH 1/2] drm/edid: abstract override/firmware EDID retrieval

2019-06-07 Thread Jani Nikula
Abstract the debugfs override and the firmware EDID retrieval function. We'll be needing it in the follow-up. No functional changes. Cc: Daniel Vetter Cc: Harish Chegondi Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 25 + 1 file changed, 17 insertions

Re: [RFC] drm: Do not call drm_probe_ddc() when connector force isn't specified

2019-06-06 Thread Jani Nikula
et_edid_block. So, the display device is still being > probed by reading EDID_LENGTH bytes of EDID data via I2C. > > Cc: Jani Nikula > Cc: Ville Syrjälä > Signed-off-by: Harish Chegondi > References: https://bugs.freedesktop.org/show_bug.cgi?id=107583 > --- > drivers/gpu

Re: [PATCH v2 08/22] gpu: i915.rst: Fix references to renamed files

2019-06-05 Thread Jani Nikula
ts and Execlists > > -.. kernel-doc:: drivers/gpu/drm/i915/intel_lrc.c > +.. kernel-doc:: drivers/gpu/drm/i915/gt/intel_lrc.c > :internal: > > Global GTT views -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: DRM/AST regression (likely 4.14 -> 4.19+), providing EDID manually fails

2019-06-04 Thread Jani Nikula
On Mon, 03 Jun 2019, Harish Chegondi wrote: > On Wed, May 29, 2019 at 01:22:30PM +0300, Jani Nikula wrote: >> On Wed, 29 May 2019, Ilpo Järvinen wrote: >> > On Tue, 28 May 2019, Jani Nikula wrote: >> > >> >> On Mon, 27 May 2019, Ashutosh Dixit wrote: >

Re: [PATCH 12/22] gpu: i915.rst: Fix references to renamed files

2019-05-31 Thread Jani Nikula
g Contexts and Execlists > > -.. kernel-doc:: drivers/gpu/drm/i915/intel_lrc.c > +.. kernel-doc:: drivers/gpu/drm/i915/gt/intel_lrc.c > :internal: > > Global GTT views -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH][next] drm/i915: fix uninitialized variable 'subslice_mask'

2019-05-29 Thread Jani Nikula
15/intel_device_info.c > +++ b/drivers/gpu/drm/i915/intel_device_info.c > @@ -298,7 +298,7 @@ static void cherryview_sseu_info_init(struct > drm_i915_private *dev_priv) > { > struct sseu_dev_info *sseu = _INFO(dev_priv)->sseu; > u32 fuse; > - u8 subslice_mask; &

Re: [PATCH][next] drm/i915: fix uninitialized variable 'mask'

2019-05-29 Thread Jani Nikula
gt; +++ b/drivers/gpu/drm/i915/gt/intel_sseu.c > @@ -41,7 +41,7 @@ void intel_sseu_copy_subslices(const struct sseu_dev_info > *sseu, int slice, > u32 intel_sseu_get_subslices(const struct sseu_dev_info *sseu, u8 slice) > { > int i, offset = slice * sseu->ss_stride; > - u32 mask; >

Re: DRM/AST regression (likely 4.14 -> 4.19+), providing EDID manually fails

2019-05-29 Thread Jani Nikula
On Wed, 29 May 2019, Ilpo Järvinen wrote: > On Tue, 28 May 2019, Jani Nikula wrote: > >> On Mon, 27 May 2019, Ashutosh Dixit wrote: >> > On Sun, 26 May 2019 12:50:51 -0700, Ilpo Järvinen wrote: >> >> >> >> Hi all, >> >> >> >> I

Re: [Intel-gfx] [PATCH v2 1/7] drm: make drm/drm_auth.h self contained

2019-05-28 Thread Jani Nikula
ct drm_file; > +struct drm_hw_lock; > > /* > * Legacy DRI1 locking data structure. Only here instead of in drm_legacy.h > for -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: DRM/AST regression (likely 4.14 -> 4.19+), providing EDID manually fails

2019-05-28 Thread Jani Nikula
>> removing all the manual *.edid_firmware from the command line so I still >> need to provide one manually to have it reliable working it seems). > > I believe there is a bug already tracking this, here: > > https://bugs.freedesktop.org/show_bug.cgi?id=107583 Ilpo, does vid

Re: [PATCH 05/13] drm/i915: drop DRM_AUTH from DRM_RENDER_ALLOW ioctls

2019-05-27 Thread Jani Nikula
e: the outstanding DRM_AUTH instances are: > - legacy DRI1 ioctls, which are already neutered > - modern but deprecated ioctls > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: intel-...@lists.freedesktop.org > Cc: David Airlie > Cc: Daniel Vett

Re: [PATCH] drm_edid-load: Fix a missing-check bug in drm_load_edid_firmware()

2019-05-24 Thread Jani Nikula
he kernel go wrong. Thus we should check > this kstrdup() operation. > Further, if kstrdup() returns NULL, we should return ERR_PTR(-ENOMEM) to > the caller site. > > Signed-off-by: Gen Zhang > Reviewed-by: Jani Nikula Pushed to drm-misc-next, thanks for the patch. BR, Jani.

[PULL] drm-intel-next

2019-05-24 Thread Jani Nikula
DP/VLV/CHV drm/i915: Assert that TypeC ports are not used for eDP Jani Nikula (39): Merge drm/drm-next into drm-intel-next-queued drm/i915: ensure more headers remain self-contained drm/i915: make intel_bios.h self-contained drm/i915/dvo: rename dvo.h to intel_dvo_dev.h

Re: [PATCH] drm: assure aux_dev is nonzero before using it

2019-05-24 Thread Jani Nikula
i0. >Invoked ipmitool >insmod ipmi kmods > Did not see any crashes or call traces. > > Suggested-by: Daniel Kwon > Signed-off-by: Tony Camuso > --- > drivers/gpu/drm/drm_dp_aux_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/dr

Re: [PATCH] drm/i915: Maintain consistent documentation subsection ordering

2019-05-24 Thread Jani Nikula
his, I would like to send it up soon > with the other Sphinx-related fixes.] Thanks, whatever works, Acked-by: Jani Nikula > > drivers/gpu/drm/i915/i915_reg.h | 6 +++--- > drivers/gpu/drm/i915/intel_workarounds.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) &g

Re: [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-23 Thread Jani Nikula
hen needs to be backmerged to drm-intel-next-queued. We don't do merges from drm-misc-next to drm-intel-next-queued directly. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.

Re: [PATCH v9 0/6] drm/i915/dp: Support for DP YCbCr4:2:0 outputs

2019-05-23 Thread Jani Nikula
nq with Laurent's and Maarten's acks to queue patch 2 via drm-intel. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm_edid-load: Fix a missing-check bug in drivers/gpu/drm/drm_edid_load.c

2019-05-22 Thread Jani Nikula
ht thing to do anyway. Reviewed-by: Jani Nikula > > Signed-off-by: Gen Zhang > > --- > diff --git a/drivers/gpu/drm/drm_edid_load.c b/drivers/gpu/drm/drm_edid_load.c > index a491509..a0e107a 100644 > --- a/drivers/gpu/drm/drm_edid_load.c > +++ b/drivers/gpu/drm/drm_

Re: [Intel-gfx] [PATCH v8 2/6] drm: Rename struct edp_vsc_psr to struct dp_sdp

2019-05-21 Thread Jani Nikula
Reserved > + * DB[16]: Pixel Encoding and Colorimetry Formats > + * DB[17]: Dynamic Range and Component Bit Depth > + * DB[18]: Content Type > + * DB[19] - DB[31]: Reserved > + */ > +struct dp_sdp { > struct dp_sdp_header sdp_header; > - u8 DB0; /* Stereo Inter

Re: [PATCH] i915: disable framebuffer compression on GeminiLake

2019-05-09 Thread Jani Nikula
https://bugs.freedesktop.org/show_bug.cgi?id=108085 >> > > Signed-off-by: Daniel Drake >> > > Signed-off-by: Jian-Hong Pan >> > >> > Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") ? >> > Cc: Paulo Zanoni >> > Cc: Dani

Re: [PATCH v2 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-05-08 Thread Jani Nikula
ine_cs.c| 2 +- For i915, Acked-by: Jani Nikula > drivers/isdn/hardware/mISDN/mISDNisar.c | 6 -- > drivers/mailbox/mailbox-test.c| 2 +- > drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +- > drivers/net/ethernet/synopsys/dwc-xlgmac-comm

Re: [PATCH 1/2] drm/dp: drmP.h include removal

2019-05-06 Thread Jani Nikula
On Mon, 06 May 2019, Noralf Trønnes wrote: > Den 06.05.2019 11.52, skrev Jani Nikula: >> Continue to get rid of drmP.h. Add minimal includes to build. Sort >> includes while at it. >> >> Signed-off-by: Jani Nikula >> --- > > Reviewed-by: Noralf Trønnes

[PATCH 2/2] drm/edid: drmP.h include removal

2019-05-06 Thread Jani Nikula
Continue to get rid of drmP.h. Add minimal includes to build. Sort includes while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 11 +++ drivers/gpu/drm/drm_edid_load.c | 7 +-- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 1/2] drm/dp: drmP.h include removal

2019-05-06 Thread Jani Nikula
Continue to get rid of drmP.h. Add minimal includes to build. Sort includes while at it. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_dp_aux_dev.c | 8 +--- drivers/gpu/drm/drm_dp_dual_mode_helper.c | 4 +++- drivers/gpu/drm/drm_dp_helper.c | 12

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330

2019-04-23 Thread Jani Nikula
misc-fixes, but regardless we can still make the backport request to older kernel once it hits upstream. BR, Jani. > > Thanks in advance. > > El vie., 1 mar. 2019 a las 11:12, Jani Nikula > () escribió: >> >> On Sat, 23 Feb 2019, David Santamaría Rogado wrote: >&g

Re: [Intel-gfx] [PATCH v2] drm: Fire off KMS hotplug events if probe detect says the connector is connected

2019-04-18 Thread Jani Nikula
> + if (old_status != connector->status || > + connector->status == connector_status_connected) > changed = true; > } > drm_connector_list_iter_end(_iter); -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: remove redundant 'default n' from Kconfig

2019-04-12 Thread Jani Nikula
u/drm/exynos/Kconfig |2 -- > drivers/gpu/drm/i915/Kconfig |3 --- > drivers/gpu/drm/i915/Kconfig.debug | 13 - For i915, Acked-by: Jani Nikula and can be merged through whichever tree you like. > drivers/gpu/drm/msm/Kconfig |2 -- >

Re: [PATCH drm-tip] rerere-cache: Fix drm/drm-next merge conflict resolution

2019-04-12 Thread Jani Nikula
508,6 @@ void drm_dev_unplug(struct drm_device *dev) > synchronize_srcu(_unplug_srcu); > > drm_dev_unregister(dev); > - drm_dev_put(dev); > } > EXPORT_SYMBOL(drm_dev_unplug); -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/4] drm/i915/dsi: Fix pipe_bpp for handling for 6 bpc pixel-formats

2019-04-05 Thread Jani Nikula
{ > - DRM_ERROR("Invalid BPP(0)\n"); > - return 0; > - } > + int bpp = mipi_dsi_pixel_format_to_bpp(intel_dsi->pixel_format); > > config->dsi_pll.ctrl = I915_READ(BXT_DSI_PLL_CTL); > > @@ -348,10 +332,7 @@

Re: [Intel-gfx] [PATCH] drm/i915: Fix context IDs not released on driver hot unbind

2019-04-04 Thread Jani Nikula
gt; > > used to be. The panic is entirely correct, we should not be >> > > > unloading >> > > > the module before those dangling pointers have been made safe. >> > > > >> > > > This is papering over the symptom.

Re: [Intel-gfx] linux-next: Tree for Mar 29 (i915, no ACPI)

2019-04-02 Thread Jani Nikula
build/kconfig-language.txt "In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies." -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PULL] drm-intel-fixes

2019-03-28 Thread Jani Nikula
On Thu, 28 Mar 2019, Jani Nikula wrote: > Hi Dave and Daniel, a fairly normal fixes pull. > > drm-intel-fixes-2019-03-28: > drm/i915 fixes for v5.2-rc3: > - fix mmap range checks > - fix gvt ppgtt mm LRU list access races > - fix selftest error pointer check > - fix

Re: [PATCH v2] gpu:drm: Remove duplicate headers

2019-03-28 Thread Jani Nikula
dge { >> > diff --git a/drivers/gpu/drm/i915/intel_display.c >> > b/drivers/gpu/drm/i915/intel_display.c >> > index 1166342..7956e89 100644 >> > --- a/drivers/gpu/drm/i915/intel_display.c >> > +++ b/drivers/gpu/drm/i915/intel_display.c >> > @@ -46

[PULL] drm-intel-fixes

2019-03-28 Thread Jani Nikula
++-- drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 2 +- 8 files changed, 41 insertions(+), 14 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [PATCH 06/16] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

2019-03-27 Thread Jani Nikula
er intel_modeset_init(), in time for the use here. > Suggested-by: Daniel Vetter > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: intel-...@lists.freedesktop.org > Signed-off-by: Noralf Trønnes Reviewed-by: Jani Nikula and Acked-by: Jani Nikula for merging vi

Re: [PATCH libdrm] intel: sync i915_pciids.h with kernel

2019-03-25 Thread Jani Nikula
_AML_CFL_GT2_IDS(info) >> +INTEL_AML_CFL_GT2_IDS(info), \ >> +INTEL_CML_GT1_IDS(info), \ >> +INTEL_CML_GT2_IDS(info) >> >> /* CNL */ >> #define INTEL_CNL_IDS(info) \ >> @@ -469,6 +495,7 @@ >>

Re: [PATCH] drm/edid: Remove defunct EDID_QUIRK_FIRST_DETAILED_PREFERRED

2019-03-22 Thread Jani Nikula
w_bug.cgi?id=284231 (got the > reference from xf86EdidModes.c) > * Peacock Ergovision 19 (only in xf86EdidModes.c) > https://bugzilla.redhat.com/show_bug.cgi?id=492359 > * Philips 107p5 CRT > "Reported on xorg@ with pastebin", didn't find the mail(s) > > Cc

Re: [RFC] drm/i915: adding state checker for gamma lut values

2019-03-20 Thread Jani Nikula
int i; >>> + >>> + sw_lut_size = drm_color_lut_size(blob1); >>> + hw_lut_size = drm_color_lut_size(blob2); >>> + >>> + if (sw_lut_size != hw_lut_size) { >>> + DRM_DEBUG_KMS("Invalid LUT size; got %d, expected %d\n", >

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-15 Thread Jani Nikula
there's a v2 earlier today, but I didn't have the time to check what changed, there's no changelog. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC] drm/i915: adding state checker for gamma lut values

2019-03-15 Thread Jani Nikula
ompare_blob(current_config->name, pipe_config->name)) { \ > + pipe_config_err(adjust, __stringify(name), \ > + "hw_state doesn't match sw_state\n"); \ > + ret = false; \ > + } \ > +} while (0) > +

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-14 Thread Jani Nikula
On Wed, 13 Mar 2019, Robert Tarasov wrote: > On Wed, Mar 13, 2019 at 2:26 AM Jani Nikula > wrote: > read_buff = kmalloc(2, GFP_KERNEL); >> >> A follow-up cleanup might be to switch to using "u8 read_buff[2];" >> instead of kmallocing it. >> >> I

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-13 Thread Jani Nikula
On Thu, 07 Mar 2019, Jani Nikula wrote: > On Thu, 07 Mar 2019, Thomas Preston wrote: >> Would you like me to resubmit with the suggested changes? > > Nah, we can tweak the commit message while applying. Pushed to dinq, thanks for the patch. BR, Jani. -- Jani Nikula, In

Re: [PATCH] drm: Format-declare struct drm_format_info in drm_framebuffer.h

2019-03-13 Thread Jani Nikula
ixed, Reviewed-by: Jani Nikula > --- > include/drm/drm_framebuffer.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h > index f0b34c977ec5..c23016748e3f 100644 > --- a/include/drm/drm_framebuffer.h &

Re: [PATCH] drm/udl: Refactor edid retreiving in UDL driver

2019-03-13 Thread Jani Nikula
n't claim to understand how the usb stuff works, but otherwise the patch looks good to me. Nice refactoring! Reviewed-by: Jani Nikula > if (!read_buff) > - return false; > + return -1; > > - for (i = 0; i < EDID_LENGTH; i++) { > - i

Re: [PATCH] MAINTAINERS: Add an entry for the vboxvideo driver

2019-03-13 Thread Jani Nikula
On Wed, 13 Mar 2019, Hans de Goede wrote: > Hi, > > On 3/13/19 9:26 AM, Jani Nikula wrote: >> On Mon, 11 Mar 2019, Hans de Goede wrote: >>> Add a MAINTAINERS entry for the vboxvideo driver, now that it has been >>> moved out of staging. >>> >>>

Re: [PATCH] MAINTAINERS: Add an entry for the vboxvideo driver

2019-03-13 Thread Jani Nikula
On Wed, 13 Mar 2019, Daniel Vetter wrote: > On Wed, Mar 13, 2019 at 10:26:37AM +0200, Jani Nikula wrote: >> On Mon, 11 Mar 2019, Hans de Goede wrote: >> > Add a MAINTAINERS entry for the vboxvideo driver, now that it has been >> > moved out of staging. >&g

Re: [PATCH] MAINTAINERS: Add an entry for the vboxvideo driver

2019-03-13 Thread Jani Nikula
like *all* DRM drivers to have those.) BR, Jani. > + > DRM DRIVER FOR VMWARE VIRTUAL GPU > M: "VMware Graphics" > M: Thomas Hellstrom -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: DRM-based Oops viewer

2019-03-12 Thread Jani Nikula
On Mon, 11 Mar 2019, "Ahmed S. Darwish" wrote: > Hello Jani, > > On Mon, Mar 11, 2019 at 11:04:19AM +0200, Jani Nikula wrote: >> On Sun, 10 Mar 2019, "Ahmed S. Darwish" wrote: >> Please first better define what you want to achieve. >> > > Oh

Re: [PATCH] drm/udl: Bugfix in EDID reading routine

2019-03-12 Thread Jani Nikula
On Mon, 11 Mar 2019, Robert Tarasov wrote: > Yes, you're right. Will prepare another patch which will use > drm_do_get_edid() Oh, you might want to have this patch first with cc: stable and all that, and do the cleanup afterwards. BR, Jani. > > On Mon, Mar 11, 2019 at 4:33 AM

Re: INFO: rcu detected stall in sys_sendfile64 (2)

2019-03-12 Thread Jani Nikula
ompiler bugs, even - playing with __LINE__ is all it would > take), but the odds that it's _not_ a false positive are very low. If it's not a false positive, it's bound to be good source material for IOCCC. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/udl: Bugfix in EDID reading routine

2019-03-11 Thread Jani Nikula
; ++i) { > + for (i = 1; i <= extensions; ++i) { > if (udl_get_edid_block(udl, i, buff_ptr)) { > buff_ptr += EDID_LENGTH; > } else { Ugh. Why doesn't udl use drm_do_

Re: DRM-based Oops viewer

2019-03-11 Thread Jani Nikula
> > [6] linux/drivers/gpu/drm/i915/i915_drv.c::i915_kick_out_firmware_fb() > linux/drivers/gpu/drm/radeon/radeon_drv.c::radeon_pci_probe() > > [7] > https://docs.microsoft.com/en-us/windows-hardware/drivers/storage/restrictions-on-miniport-drivers-that-manage-the-boot-drive &g

Re: [PATCH v8 1/2] drm/i915: Introduce async plane update to i915

2019-03-08 Thread Jani Nikula
On Fri, 08 Mar 2019, Helen Koike wrote: > Hi Jani, > > On 3/8/19 6:55 AM, Jani Nikula wrote: >> >> Please send drm/i915 patches also to intel-...@lists.freedesktop.org to >> trigger CI on the patches among other things. > > Sure! Is there a way to tell th

Re: [PATCH v8 1/2] drm/i915: Introduce async plane update to i915

2019-03-08 Thread Jani Nikula
ntel_plane_atomic_async_update, > }; > > /** > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 415d8968f2c5..244e1c94277d 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c &g

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Jani Nikula
On Thu, 07 Mar 2019, Thomas Preston wrote: > Would you like me to resubmit with the suggested changes? Nah, we can tweak the commit message while applying. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Jani Nikula
On Thu, 07 Mar 2019, Thomas Preston wrote: > Hi, > Thanks for looking at this. > > On 07/03/2019 08:18, Jani Nikula wrote: >> >> The subject should probably have "drm/i915/bios" or "drm/i915/vbt". >> > > Noted > >> On Wed, 06

Re: Is it possible to reset graphics controller on reboot in a framebuffer driver?

2019-03-07 Thread Jani Nikula
notifiers to achieve the exact same goal. See drivers/video/fbdev/aty/atyfb_base.c, look for register_reboot_notifier(). HTH, Jani. -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Jani Nikula
at have a non-eDP output on port A. I guess it's a risk we have to take, and handle the fallout later. Acked-by: Jani Nikula > Fixes: commit a98d9c1d7e9b ("drm/i915/ddi: Rely on VBT DDI port info for eDP > detection") The Fixes: format does *not* include "commi

Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data

2019-03-05 Thread Jani Nikula
On Tue, 05 Mar 2019, Maxime Ripard wrote: > On Mon, Mar 04, 2019 at 05:47:09PM +0200, Jani Nikula wrote: >> On Mon, 04 Mar 2019, Maxime Ripard wrote: >> > In some cases, in order to accomodate with displays with poor EDIDs, we >> > need to ignore that the monitor alled

Re: [PATCH 3/7] drm/edid: Allow to ignore the HDMI monitor mode

2019-03-04 Thread Jani Nikula
s HDMI > * @edid: monitor EDID information > @@ -4170,6 +4175,9 @@ bool drm_detect_hdmi_monitor(struct edid *edid) > int i; > int start_offset, end_offset; > > + if (force_dvi_monitor) > + return false; > + > edid_ext = drm_find_cea_extension(edid); >

Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data

2019-03-04 Thread Jani Nikula
> * @edid: EDID block to scan > @@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *edid) > bool has_audio = false; > int start_offset, end_offset; > > + if (ignore_edid_audio) > + goto end; > + > edid_ext = drm_find_cea_exten

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330

2019-03-01 Thread Jani Nikula
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), >> + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad >> D330-10IGM"), >> + }, >> + .driver_data = (void *)_rightside_up, >> }, {/

Re: [PATCH 0/3] Propagate DP-over-Type-C hotplug events from Type-C subsys to drm-drivers

2019-02-27 Thread Jani Nikula
orientation, there's a worst case of sixth attempt of finding out there's just one lane in a certain orientation. Couple that with link rate selection (did it not work because too high link rate or because the lanes are just not there?) we get pretty confused about what we should try. BR, Jani. -- Ja

Re: [Intel-gfx] [RFC PATCH 00/42] Introduce memory region concept (including device local memory)

2019-02-26 Thread Jani Nikula
en when it really has slowed us down. So while you may have fair points about a specific case, and again I'll let Joonas address the specific case, I'll have to ask you to please not generalize that to the whole driver. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center __

Re: [PATCH v2 2/3] drm/dsc: Add native 420 and 422 support to compute_rc_params

2019-02-25 Thread Jani Nikula
le422 is renamed to simple_422 to avoid > confusion > > Acked-by: Jani Nikula This was really for patch 1/3 where it actually matters. BR, Jani. > Reviewed-by: Manasi Navare > Reviewed-by: Harry Wentland > Signed-off-by: David Francis > --- > drivers/gpu/drm/drm_dsc.c

Re: [PATCH RESEND 1/2] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-22 Thread Jani Nikula
apad Miix 320 */ >145.matches = { >146 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), >147 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), >148 DMI_EXACT_MATCH(DMI_PRODUCT_V

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Jani Nikula
On Thu, 21 Feb 2019, Gerd Hoffmann wrote: > On Thu, Feb 21, 2019 at 03:08:39PM +0200, Jani Nikula wrote: >> On Thu, 21 Feb 2019, Gerd Hoffmann wrote: >> > It'll be useful for other drivers too, so move it to drm_fb_helper.c >> > (and rename it of course). Also add

Re: [PATCH v2 1/2] drm: move i915_kick_out_vgacon to drm_fb_helper

2019-02-21 Thread Jani Nikula
> - ret = 0; > - } > - console_unlock(); > - > - return ret; > -} > -#endif > - > static void intel_init_dpio(struct drm_i915_private *dev_priv) > { > /* > @@ -1420,7 +1387,7 @@ static int i915_driver_init_hw(struct drm_i915_pri

[PULL] drm-intel-fixes

2019-02-20 Thread Jani Nikula
Chris Wilson (1): drm/i915/fbdev: Actually configure untiled displays drivers/gpu/drm/i915/intel_fbdev.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

Re: [PATCH 1/2] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-18 Thread Jani Nikula
On Sat, 16 Feb 2019, David Santamaría Rogado wrote: > From: howl > > The (void *) casting in the driver_data variable assignment is superfluous. > Spotted by Jani Nikula. > > Signed-off-by: David Santamaría Rogado Reviewed-by: Jani Nikula > -

Re: [Intel-gfx] [PATCH 0/3] Make DRM DSC helpers more generally usable

2019-02-14 Thread Jani Nikula via dri-devel
acking function > to operate only on the packing struct, to allow for drivers with > their own SDP struct headers Acked-by: Jani Nikula as long as you've ironed out the details with Manasi's review. Also okay to merge via drm-misc. Ideally, please rebase on drm-tip and continue to Cc: inte

Re: Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting

2019-02-14 Thread Jani Nikula via dri-devel
> It's usually to put this kind of comment below the --- line... > >> The (void *) casting in the driver_data variable assignment is superfluous. >> Spotted by Jani Nikula. Please either make that Suggested-by: Jani Nikula or leave out completely. >> >> Signed-of

[PULL] drm-intel-fixes

2019-02-13 Thread Jani Nikula via dri-devel
Swarup (1): drm/i915/cnl: Fix CNL macros for Voltage Swing programming Clint Taylor (1): drm/i915/icl: combo port vswing programming changes per BSPEC Jani Nikula (2): drm/i915/opregion: fix version check drm/i915/opregion: rvda is relative from opregion base in opregion 2.1

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330

2019-02-12 Thread Jani Nikula via dri-devel
er_data = _rightside_up, > }, { /* Lenovo Ideapad Miix 320 */ > .matches = { >DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), >DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), >DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), > },

Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Lenovo Ideapad D330

2019-02-12 Thread Jani Nikula via dri-devel
S LTH17 */ > .matches = { >DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"), > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

  1   2   3   4   5   6   7   8   9   10   >