[PATCH v1] drm/rockchip: rk3066_hdmi: change to bridge driver mode

2024-07-09 Thread Johan Jonker
Change rk3066_hdmi.c to bridge driver mode. Signed-off-by: Johan Jonker --- Apply after: [PATCH v10] drm/rockchip: rk3066_hdmi: add sound support --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 293 ++--- 1 file changed, 161 insertions(+), 132 deletions(-) diff --git a

[PATCH v2] drm/rockchip: inno_hdmi: add audio support

2024-07-06 Thread Johan Jonker
Add sound support to the INNO HDMI driver. The HDMI TX audio source is connected to I2S. Using the common hdmi-codec driver to support hdmi audio function. Signed-off-by: Yakir Yang Signed-off-by: Johan Jonker --- NOT TESTED WITH HARDWARE Changed V2: rebased hook to encoder->fu

[PATCH v10] drm/rockchip: rk3066_hdmi: add sound support

2024-07-04 Thread Johan Jonker
Add sound support to the RK3066 HDMI driver. The HDMI TX audio source is connected to I2S_8CH. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- Changed V10: s/audio_enable/audio_enabled hook to encoder->funcs->late_register move audio functions up to avoid adding a decla

[PATCH v9] drm/rockchip: rk3066_hdmi: add sound support

2024-07-03 Thread Johan Jonker
Add sound support to the RK3066 HDMI driver. The HDMI TX audio source is connected to I2S_8CH. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- Changed V9: Use late_register and early_unregister hooks to (un)register the "hdmi-audio-codec" driver. restyle Changed V8

[PATCH v8] drm/rockchip: rk3066_hdmi: add sound support

2024-07-02 Thread Johan Jonker
Add sound support to the RK3066 HDMI driver. The HDMI TX audio source is connected to I2S_8CH. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- Changed V8: return -EPROBE_DEFER as early as possible move rk3066_hdmi_audio_codec_init() function after rk3066_hdmi_register() restyle

Re: [PATCH v7] drm/rockchip: rk3066_hdmi: add sound support

2024-06-29 Thread Johan Jonker
Hi Andy, thanks. On 6/28/24 15:08, Andy Yan wrote: > > Hi Johan, > > At 2024-06-28 17:23:39, "Johan Jonker" wrote: >> Add sound support to the RK3066 HDMI driver. >> The HDMI TX audio source is connected to I2S_8CH. >> >> Signed-off-

[PATCH v7] drm/rockchip: rk3066_hdmi: add sound support

2024-06-28 Thread Johan Jonker
Add sound support to the RK3066 HDMI driver. The HDMI TX audio source is connected to I2S_8CH. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- Changed V7: rebase --- drivers/gpu/drm/rockchip/Kconfig | 2 + drivers/gpu/drm/rockchip/rk3066_hdmi.c | 274

Re: [PATCH v2 3/3] dt-bindings: display: rockchip,dw-hdmi: Fix sound-dai-cells warning

2024-04-14 Thread Johan Jonker
On 4/14/24 17:11, Jonas Karlman wrote: > The rockchip,dw-hdmi node can be used as a sound dai codec, however, > dtbs_check may report the following issue: > > hdmi@fe0a: Unevaluated properties are not allowed ('#sound-dai-cells' > was unexpected) > from schema $id: > http://devicetree

[PATCH v1 3/3] dt-bindings: display: add #sound-dai-cells property to rockchip inno hdmi

2024-04-13 Thread Johan Jonker
The Rockchip inno HDMI controller can take one I2S input and transmit it over the HDMI output. Add #sound-dai-cells (= 0) to the binding for it. Signed-off-by: Johan Jonker --- .../bindings/display/rockchip/rockchip,inno-hdmi.yaml| 5 + 1 file changed, 5 insertions(+) diff --git a

[PATCH v1 2/3] dt-bindings: display: add #sound-dai-cells property to rockchip rk3066 hdmi

2024-04-13 Thread Johan Jonker
The Rockchip rk3066 HDMI controller can take one I2S input and transmit it over the HDMI output. Add #sound-dai-cells (= 0) to the binding for it. Signed-off-by: Johan Jonker --- .../bindings/display/rockchip/rockchip,rk3066-hdmi.yaml| 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v1 1/3] dt-bindings: display: add #sound-dai-cells property to rockchip dw hdmi

2024-04-13 Thread Johan Jonker
The Rockchip DWC HDMI TX Encoder can take one I2S input and transmit it over the HDMI output. Add #sound-dai-cells (= 0) to the binding for it. Signed-off-by: Johan Jonker --- .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a

[PATCH v2 6/6] arm64: dts: rockchip: fix rk3399 hdmi ports node

2024-01-31 Thread Johan Jonker
Fix rk3399 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- Changed V2: keep reg-io-width together with reg --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch

[PATCH v2 5/6] arm64: dts: rockchip: fix rk3328 hdmi ports node

2024-01-31 Thread Johan Jonker
Fix rk3328 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- Changed V2: keep reg-io-width together with reg --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch

[PATCH v2 4/6] ARM: dts: rockchip: fix rk322x hdmi ports node

2024-01-31 Thread Johan Jonker
Fix rk322x hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- Changed V2: keep reg-io-width together with reg --- arch/arm/boot/dts/rockchip/rk322x.dtsi | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a

[PATCH v2 3/6] ARM: dts: rockchip: fix rk3288 hdmi ports node

2024-01-31 Thread Johan Jonker
Fix rk3288 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding with some reordering to align with the (new) documentation about property ordering. Signed-off-by: Johan Jonker --- Changed V2: keep reg-io-width together with reg reword --- arch/arm/boot/dts/rockchip/rk3288

[PATCH v2 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property

2024-01-31 Thread Johan Jonker
Most Rockchip hdmi nodes are part of a power domain. Add a power-domains property and include it to the example with some reordering to align with the (new) documentation about property ordering. Signed-off-by: Johan Jonker Acked-by: Conor Dooley --- Changed V2: keep reg-io-width together

[PATCH v2 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: remove port property

2024-01-31 Thread Johan Jonker
unambiguously, so remove the old port property entirely and make port@0 and port@1 a requirement as all upstream dts files are updated as well and because checking deprecated stuff is a bit pointless. Update the example to avoid use of the removed property. Signed-off-by: Johan Jonker --- Changed V2

[PATCH v1 6/6] arm64: dts: rockchip: fix rk3399 hdmi ports node

2024-01-30 Thread Johan Jonker
Fix rk3399 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts

[PATCH v1 5/6] arm64: dts: rockchip: fix rk3328 hdmi ports node

2024-01-30 Thread Johan Jonker
Fix rk3328 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64

[PATCH v1 4/6] ARM: dts: rockchip: fix rk322x hdmi ports node

2024-01-30 Thread Johan Jonker
Fix rk322x hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rockchip/rk322x.dtsi | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/rockchip/rk322x.dtsi b/arch/arm/boot

[PATCH v1 3/6] ARM: dts: rockchip: fix rk3288 hdmi ports node

2024-01-30 Thread Johan Jonker
Fix rk3288 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rockchip/rk3288.dtsi | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/rockchip/rk3288.dtsi b/arch/arm/boot

[PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property

2024-01-30 Thread Johan Jonker
Most Rockchip hdmi nodes are part of a power domain. Add a power-domains property. Fix example. Signed-off-by: Johan Jonker --- .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree

[PATCH v1 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: deprecate port property

2024-01-30 Thread Johan Jonker
The hdmi-connector nodes are now functional and the new way to model hdmi nodes with, so deprecate the port property and make port@0 and port@1 a requirement. Also update example. Signed-off-by: Johan Jonker --- .../display/rockchip/rockchip,dw-hdmi.yaml| 27 --- 1 file

Re: [PATCH v2 2/2] drm/rockchip: rk3066_hdmi: drop custom fill_modes hook

2023-12-19 Thread Johan Jonker
On 12/19/23 13:55, Maxime Ripard wrote: > Hi, > > On Mon, Dec 18, 2023 at 04:49:06PM +0100, Johan Jonker wrote: >> CRTC size validation for the display controller has been added with >> Commit 8e140cb60270 ("drm/rockchip: vop: limit maximum resolution to >> ha

[PATCH v2 2/2] drm/rockchip: rk3066_hdmi: drop custom fill_modes hook

2023-12-18 Thread Johan Jonker
CRTC size validation for the display controller has been added with Commit 8e140cb60270 ("drm/rockchip: vop: limit maximum resolution to hardware capabilities"), so we can drop the custom fill_modes hook. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rk3066_h

[PATCH v2 0/2] Rockchip rk3066_hdmi update

2023-12-18 Thread Johan Jonker
Update the Rockchip rk3066_hdmi driver in a somewhat similar way to what is proposed for the inno_hdmi driver. Changed V2: Drop already applied patches Remove "Remove useless output format" patch for now Add fill_modes hook removal patch Johan Jonker (2): drm/rockchip: r

[PATCH v2 1/2] drm/rockchip: rk3066_hdmi: remove unused drm device pointer

2023-12-18 Thread Johan Jonker
The drm_dev field in the rk3066_hdmi struct stores a pointer to the DRM device but is never used anywhere in the driver. Let's remove it. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/roc

Re: [PATCH v1 1/3] dt-bindings: drm: rockchip: convert inno_hdmi-rockchip.txt to yaml

2023-12-04 Thread Johan Jonker
Hi, On 12/4/23 19:56, Alex Bee wrote: > Hi Johan, > Am 04.12.23 um 18:39 schrieb Johan Jonker: >> Convert inno_hdmi-rockchip.txt to yaml. > Nice - I'm having something very similar on my queue :) >> >> Signed-off-by: Johan Jonker >> --- >> >> Not

Re: [PATCH v1 3/3] ARM: dts: rockchip: rk3036-kylin: add hdmi-connector node

2023-12-04 Thread Johan Jonker
Hi Alex, Heiko, On 12/4/23 20:12, Alex Bee wrote: > Hi Johan, > Am 04.12.23 um 18:40 schrieb Johan Jonker: >> Add hdmi-connector node to comply with the inno_hdmi binding. >> >> Signed-off-by: Johan Jonker >> --- >>   arch/arm/boot/dts/rockchip/rk3036-kylin.dt

[PATCH v1 3/3] ARM: dts: rockchip: rk3036-kylin: add hdmi-connector node

2023-12-04 Thread Johan Jonker
Add hdmi-connector node to comply with the inno_hdmi binding. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036

[PATCH v1 2/3] ARM: dts: rockchip: rk3036: fix hdmi ports node

2023-12-04 Thread Johan Jonker
Fix hdmi ports node so that it matches the rockchip,inno-hdmi.yaml binding. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rockchip/rk3036.dtsi | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi b/arch/arm/boot/dts

[PATCH v1 1/3] dt-bindings: drm: rockchip: convert inno_hdmi-rockchip.txt to yaml

2023-12-04 Thread Johan Jonker
Convert inno_hdmi-rockchip.txt to yaml. Signed-off-by: Johan Jonker --- Note for rob+dt: Used enum to "soon" be able to add "rockchip,rk3128-inno-hdmi" Changed V1: Rename file to more common layout Add/fix hdmi_out port example --- .../display/rockchip/inno_hdmi-

Re: [PATCH v4 38/45] drm/rockchip: inno_hdmi: Switch to infoframe type

2023-11-28 Thread Johan Jonker
Hi, Maximum for inno_hdmi is: 1920x1080. Do we still need INFOFRAME_VSI? >From Rockchip RK3036 TRM V1.0 20150907-Part2 Peripheral and Interface.pdf: - HDMI 1.4a/b/1.3/1.2/1.1, HDCP 1.2 and DVI 1.0 standard compliant transmitter - Supports all DTV resolutions including 480p/576p/720p/1080p http

Re: [PATCH RFC v3 22/37] drm/rockchip: inno_hdmi: Remove useless output format

2023-11-26 Thread Johan Jonker
Hi Maxime, In stead of further cripplingRockchip HDMI drivers one could also make it functional based  on EDID info. To start with the output could you turn RGB888 input and switch between RGB444, YCBCR444 and YCBCR422 output. Johan On 10/31/23 17:48, Maxime Ripard wrote: > Similarly to the i

[PATCH v1 3/3] drm/rockchip: inno_hdmi: Remove unused drm device pointer

2023-11-26 Thread Johan Jonker
The drm_dev field in the inno_hdmi struct stores a pointer to the DRM device but is never used anywhere in the driver. Let's remove it. Signed-off-by: Maxime Ripard Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/inno_hdmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/dr

[PATCH v1 2/3] drm/rockchip: inno_hdmi: Switch encoder hooks to atomic

2023-11-26 Thread Johan Jonker
The inno_hdmi encoder still uses the non atomic variants of enable and disable. Convert to their atomic equivalents. In atomic mode there is no need to save the adjusted mode, so remove the mode_set function. Signed-off-by: Maxime Ripard Signed-off-by: Johan Jonker --- Changed V1: Combined

[PATCH v1 1/3] drm/rockchip: inno_hdmi: Remove useless mode_fixup

2023-11-26 Thread Johan Jonker
The mode_fixup implementation doesn't do anything, so we can simply remove it. Signed-off-by: Maxime Ripard Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/inno_hdmi.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gp

[PATCH v1 0/3] Rockchip inno_hdmi update

2023-11-26 Thread Johan Jonker
Combined update for the Rockchip inno_hdmi driver in a somewhat similar way to what is proposed for the "Create HDMI Connector infrastructure patch serie". Keeping the inno_hdmi and rk3066_hdmi driver functions comparable makes maintanance easier. Maxime Ripard (3): drm/rockchip: inno_hdmi: Remo

Re: [PATCH v1 3/4] drm/rockchip: rk3066_hdmi: Remove useless output format

2023-11-23 Thread Johan Jonker
On 11/20/23 18:06, Heiko Stuebner wrote: > Hi Johan, > > Am Donnerstag, 2. November 2023, 14:42:19 CET schrieb Johan Jonker: >> The Rk3066 hdmi output format is hard coded to RGB. Remove >> all useless code related to colorimetry and enc_out_format. >> >> Sig

[PATCH v1 4/4] drm/rockchip: rk3066_hdmi: Remove unused drm device pointer

2023-11-02 Thread Johan Jonker
The drm_dev field in the rk3066_hdmi struct stores a pointer to the DRM device but is never used anywhere in the driver. Let's remove it. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/roc

[PATCH v1 3/4] drm/rockchip: rk3066_hdmi: Remove useless output format

2023-11-02 Thread Johan Jonker
The Rk3066 hdmi output format is hard coded to RGB. Remove all useless code related to colorimetry and enc_out_format. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v1 2/4] drm/rockchip: rk3066_hdmi: Switch encoder hooks to atomic

2023-11-02 Thread Johan Jonker
The rk3066_hdmi encoder still uses the non atomic variants of enable and disable. Convert to their atomic equivalents. In atomic mode there is no need to save the adjusted mode, so remove the mode_set function. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 35

[PATCH v1 1/4] drm/rockchip: rk3066_hdmi: Remove useless mode_fixup

2023-11-02 Thread Johan Jonker
The mode_fixup implementation doesn't do anything, so we can simply remove it. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_h

[PATCH v1 0/4] Rockchip rk3066_hdmi update

2023-11-02 Thread Johan Jonker
Update the Rockchip rk3066_hdmi driver in a somewhat similar way to what is proposed for the inno_hdmi driver. Johan Jonker (4): drm/rockchip: rk3066_hdmi: Remove useless mode_fixup drm/rockchip: rk3066_hdmi: Switch encoder hooks to atomic drm/rockchip: rk3066_hdmi: Remove useless output

Re: [PATCH v6 01/17] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2023-02-03 Thread Johan Jonker
On 2/3/23 19:21, Rob Herring wrote: > On Thu, Dec 22, 2022 at 03:22:14PM +0100, Johan Jonker wrote: >> Convert rockchip-lvds.txt to YAML. >> >> Changed: >> Add power-domains property. >> Requirements between PX30 and RK3288 >> >> Signed-off-

[PATCH v6 17/17] arm64: dts: rockchip: rk356x: remove hclk from dsi node

2022-12-22 Thread Johan Jonker
The hclk is not used in the dw-mipi-dsi-rockchip.c driver, so remove hclk from the rk356x.dtsi dsi node. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi

[PATCH v6 16/17] arm64: dts: rockchip: rename vbus-supply to phy-supply in rk3566-box-demo.dts

2022-12-22 Thread Johan Jonker
'vbus-supply' does not match any of the regexes in rk3566-box-demo.dts in the usb2phy0_otg node, so rename vbus-supply to phy-supply. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH v6 15/17] arm64: dts: rockchip: rk3399: fix dp node

2022-12-22 Thread Johan Jonker
Use generic node name for rk3399.dtsi dp node. With the conversion of rockchip,analogix-dp.yaml a port@1 node is required, so add a node with label edp_out. Also restyle. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 7 ++- 1 file changed, 6 insertions(+), 1

[PATCH v6 14/17] arm64: dts: rockchip: rk3399: fix dsi node

2022-12-22 Thread Johan Jonker
Use generic node name for rk3399.dtsi dsi node. With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label mipi_out. Also restyle. Signed-off-by: Johan Jonker --- Changed V6: Restyle --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 13 +++-- 1

[PATCH v6 13/17] arm64: dts: rockchip: px30: fix dsi node

2022-12-22 Thread Johan Jonker
With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label dsi_out. Also add label dsi_in to port@0. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/px30.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch

[PATCH v6 12/17] arm64: dts: rockchip: px30: fix lvds node

2022-12-22 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Also add label lvds_in to port@0. Signed-off-by: Johan Jonker --- Changed V5: rename title add label lvds_in --- arch/arm64/boot/dts/rockchip/px30.dtsi | 6 +- 1 file changed, 5

[PATCH v6 11/17] ARM: dts: rockchip: rk3288: fix dp node

2022-12-22 Thread Johan Jonker
With the conversion of rockchip,analogix-dp.yaml a port@1 node is required, so add a node with label edp_out. Also restyle. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3288.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts

[PATCH v6 10/17] ARM: dts: rockchip: rk3288: fix lvds node

2022-12-22 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Also restyle. Signed-off-by: Johan Jonker --- Changed V6: Restyle Changed V5: Rename title --- arch/arm/boot/dts/rk3288.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion

[PATCH v6 09/17] ARM: dts: rockchip: rk3288: fix dsi node

2022-12-22 Thread Johan Jonker
Use generic node name for rk3288.dtsi dsi node. With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label mipi_out. Also restyle. Signed-off-by: Johan Jonker --- Changed V6: Restyle --- arch/arm/boot/dts/rk3288.dtsi | 14 -- 1 file

[PATCH v6 08/17] dt-bindings: usb: convert fcs,fusb302.txt to yaml

2022-12-22 Thread Johan Jonker
Convert fcs,fusb302.txt to yaml. Changed: Add vbus-supply property Signed-off-by: Johan Jonker --- Changed V6: Add unevaluatedProperties Drop unused labels --- .../devicetree/bindings/usb/fcs,fusb302.txt | 34 -- .../devicetree/bindings/usb/fcs,fusb302.yaml | 67

[PATCH v6 07/17] dt-bindings: display: rockchip: convert analogix_dp-rockchip.txt to yaml

2022-12-22 Thread Johan Jonker
Convert analogix_dp-rockchip.txt to yaml. Changed: Add power-domains property File name Signed-off-by: Johan Jonker --- .../display/rockchip/analogix_dp-rockchip.txt | 98 - .../rockchip/rockchip,analogix-dp.yaml| 103 ++ 2 files changed, 103

[PATCH v6 06/17] dt-bindings: display: bridge: convert analogix_dp.txt to yaml

2022-12-22 Thread Johan Jonker
Convert analogix_dp.txt to yaml for use as common document. Changed: Relexed requirements Signed-off-by: Johan Jonker --- .../bindings/display/bridge/analogix,dp.yaml | 63 +++ .../bindings/display/bridge/analogix_dp.txt | 51 --- .../bindings/display/exynos

[PATCH v6 05/17] dt-bindings: display: rockchip: convert dw_mipi_dsi_rockchip.txt to yaml

2022-12-22 Thread Johan Jonker
Convert dw_mipi_dsi_rockchip.txt to yaml. Changed: file name requirements Signed-off-by: Johan Jonker --- Changed V6: Remove clock-master property Fix $ref --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 94 -- .../rockchip/rockchip,dw-mipi-dsi.yaml| 166

[PATCH v6 04/17] dt-bindings: display: bridge: snps, dw-mipi-dsi: fix clock properties

2022-12-22 Thread Johan Jonker
Fix clock properties from the common snps,dw-mipi-dsi.yaml file, as they don't match with what is used on the SoCs. Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- .../display/bridge/snps,dw-mipi-dsi.yaml | 16 +++- 1 file changed, 3 insertions(+), 13 dele

[PATCH v6 03/17] dt-bindings: display: dsi-controller: move clock-master property

2022-12-22 Thread Johan Jonker
The clock-master property is used for the controller and not in the panel, so move it there. Signed-off-by: Johan Jonker --- .../bindings/display/dsi-controller.yaml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v6 02/17] dt-bindings: soc: rockchip: grf: add rockchip,lvds.yaml

2022-12-22 Thread Johan Jonker
Add new converted rockchip,lvds.yaml to grf.yaml file. Prepare for more SoCs with lvds output. Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- Changed V5: Drop the quotes --- .../devicetree/bindings/soc/rockchip/grf.yaml | 24 +++ 1 file changed, 14 insertions

[PATCH v6 01/17] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-22 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requir

[PATCH v5 12/12] arm64: dts: rockchip: rk356x: remove hclk from dsi node

2022-12-21 Thread Johan Jonker
The hclk is not used in the dw-mipi-dsi-rockchip.c driver, so remove hclk from the rk356x.dtsi dsi node. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi

[PATCH v5 11/12] arm64: dts: rockchip: rename vbus-supply to phy-supply in rk3566-box-demo.dts

2022-12-21 Thread Johan Jonker
'vbus-supply' does not match any of the regexes in rk3566-box-demo.dts in the usb2phy0_otg node, so rename vbus-supply to phy-supply. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH v5 10/12] arm64: dts: rockchip: rk3399: fix dsi node

2022-12-21 Thread Johan Jonker
Use generic node name for rk3399.dtsi dsi node. With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label mipi_out. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2

[PATCH v5 09/12] arm64: dts: rockchip: px30: fix dsi node

2022-12-21 Thread Johan Jonker
With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label dsi_out. Also add label dsi_in to port@0. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/px30.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch

[PATCH v5 08/12] arm64: dts: rockchip: px30: fix lvds node

2022-12-21 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Also add label lvds_in to port@0. Signed-off-by: Johan Jonker --- Changed V5: rename title add label lvds_in --- arch/arm64/boot/dts/rockchip/px30.dtsi | 6 +- 1 file changed, 5

[PATCH v5 07/12] ARM: dts: rockchip: rk3288: fix lvds node

2022-12-21 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Signed-off-by: Johan Jonker --- Changed V5: rename title --- arch/arm/boot/dts/rk3288.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm

[PATCH v5 06/12] ARM: dts: rockchip: rk3288: fix dsi node

2022-12-21 Thread Johan Jonker
Use generic node name for rk3288.dtsi dsi node. With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label mipi_out. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3288.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a

[PATCH v5 05/12] dt-bindings: usb: convert fcs,fusb302.txt to yaml

2022-12-21 Thread Johan Jonker
Convert fcs,fusb302.txt to yaml. Changed: Add vbus-supply property Signed-off-by: Johan Jonker --- .../devicetree/bindings/usb/fcs,fusb302.txt | 34 -- .../devicetree/bindings/usb/fcs,fusb302.yaml | 66 +++ 2 files changed, 66 insertions(+), 34 deletions(-) delete

[PATCH v5 04/12] dt-bindings: display: rockchip: convert dw_mipi_dsi_rockchip.txt to yaml

2022-12-21 Thread Johan Jonker
Convert dw_mipi_dsi_rockchip.txt to yaml. Changed: add clock-master property file name requirements Signed-off-by: Johan Jonker --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 94 -- .../rockchip/rockchip,dw-mipi-dsi.yaml| 173 ++ 2 files changed, 173

[PATCH v5 03/12] dt-bindings: display: bridge: snps, dw-mipi-dsi: fix clock properties

2022-12-21 Thread Johan Jonker
Fix clock properties from the common snps,dw-mipi-dsi.yaml file, as they don't match with what is used on the SoCs. Signed-off-by: Johan Jonker --- .../display/bridge/snps,dw-mipi-dsi.yaml | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --g

[PATCH v5 02/12] dt-bindings: soc: rockchip: grf: add rockchip,lvds.yaml

2022-12-21 Thread Johan Jonker
Add new converted rockchip,lvds.yaml to grf.yaml file. Prepare for more SoCs with lvds output. Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- Changed V5: Drop the quotes --- .../devicetree/bindings/soc/rockchip/grf.yaml | 24 +++ 1 file changed, 14 insertions

[PATCH v5 01/12] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-21 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requir

[PATCH v4 5/5] arm64: dts: rockchip: px30: add lvds_out node

2022-12-19 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/px30.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts

[PATCH v4 4/5] ARM: dts: rockchip: rk3288: add lvds_out node

2022-12-19 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3288.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index

[PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml

2022-12-19 Thread Johan Jonker
On Rockchip rk3399 a port node with one endpoint can be connected to a USB Type-C connector node. Add a port node to the phy-rockchip-inno-usb2.yaml file. Signed-off-by: Johan Jonker --- .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 5 + 1 file changed, 5 insertions

[PATCH v4 2/5] dt-bindings: soc: rockchip: grf: add rockchip,lvds.yaml

2022-12-19 Thread Johan Jonker
Add new converted rockchip,lvds.yaml to grf.yaml file. Prepare for more SoCs with lvds output. Signed-off-by: Johan Jonker --- .../devicetree/bindings/soc/rockchip/grf.yaml | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v4 1/5] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requirements per SoC Sort

Re: [PATCH v3] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Johan Jonker
On 12/19/22 14:04, Krzysztof Kozlowski wrote: > On 19/12/2022 13:32, Johan Jonker wrote: >> Convert rockchip-lvds.txt to YAML. >> >> Changed: >> Add power-domains property. >> Requirements between PX30 and RK3288 >> >> Signed-off-by: Johan J

[PATCH v3] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requirements per SoC Sort

[PATCH v2] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-17 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- Changed V2: Fix title --- .../display/rockchip/rockchip-lvds.txt| 92 -- .../display/rockchip/rockchip-lvds.yaml | 157

[PATCH v1] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-17 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- .../display/rockchip/rockchip-lvds.txt| 92 -- .../display/rockchip/rockchip-lvds.yaml | 159 ++ 2 files

[PATCH v1] drm: rockchip: remove rockchip_drm_framebuffer_init() function

2022-10-19 Thread Johan Jonker
. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 43 -- drivers/gpu/drm/rockchip/rockchip_drm_fb.h | 6 --- 2 files changed, 49 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c index

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
On 10/17/22 21:00, John Keeping wrote: > On Mon, Oct 17, 2022 at 08:30:23PM +0200, Johan Jonker wrote: >> >> >> On 10/17/22 13:29, Heiko Stuebner wrote: >>> Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: >>>> Hi Johan, >>>>

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
On 10/17/22 13:29, Heiko Stuebner wrote: > Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: >> Hi Johan, >> >> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: >>> Your patch contribution causes a kernel panic on MK808 with Rockchip

[BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
Hi John, Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC. Would you like to contribute to fix this issue? The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true! A revert makes it work again. Johan == [7.975906]

Re: [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2022-02-10 Thread Johan Jonker
On 2/10/22 12:47, Sascha Hauer wrote: > On Thu, Feb 10, 2022 at 01:10:32AM +0100, Johan Jonker wrote: >> Hi Sascha, >> >> Something with port and endpoint gives notifications. >> Somehow with the conversion of rockchip,dw-hdmi.txt to YAML not all SoC >> options

Re: [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2022-02-09 Thread Johan Jonker
Hi Sascha, Something with port and endpoint gives notifications. Somehow with the conversion of rockchip,dw-hdmi.txt to YAML not all SoC options were checked/covered (see rk3328 and rk3568). Allow multiple vop: port or port@0 1x vop -> endpoint 2x vop -> endpoint@0 -> endpoint@1 Also all

Re: [PATCH 13/18] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2021-12-08 Thread Johan Jonker
Hi, Could add a patch version to the subject? On 12/8/21 4:12 PM, Sascha Hauer wrote: > This enabled the VOP2 display controller along with hdmi and the > required port routes which is enough to get a picture out of the > hdmi port of the board. > > Signed-off-by: Sascha Hauer > --- > .../boot

Re: [PATCH 17/18] drm: rockchip: Add VOP2 driver

2021-12-08 Thread Johan Jonker
Hi, On 12/8/21 4:12 PM, Sascha Hauer wrote: > From: Andy Yan > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > It replaces the VOP unit found in the older Rockchip SoCs. > > This driver has been derived from the downstream Rockchip Kernel and > heavily modified: > > -

Re: [PATCH 08/12] arm64: dts: rockchip: rk356x: Add VOP2 nodes

2021-11-25 Thread Johan Jonker
Hi Sascha, On 11/17/21 3:33 PM, Sascha Hauer wrote: > The VOP2 is the display output controller on the RK3568. Add the node > for it to the dtsi file along with the required display-subsystem node > and the iommu node. > > Signed-off-by: Sascha Hauer > --- > arch/arm64/boot/dts/rockchip/rk356x

Re: [PATCH] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a

2021-11-25 Thread Johan Jonker
On 11/17/21 4:44 PM, Michael Riesch wrote: > Enable the RK356x Video Output Processor (VOP) 2 on the Pine64 > Quartz64 Model A. > > Signed-off-by: Michael Riesch > --- > .../boot/dts/rockchip/rk3566-quartz64-a.dts | 24 +++ > 1 file changed, 24 insertions(+) > > diff --git

Re: [PATCH v6 2/5] drm: rockchip: add sound support to rk3066 hdmi driver

2021-03-22 Thread Johan Jonker
ping On 12/6/20 2:33 PM, Johan Jonker wrote: > From: Zheng Yang > > Add sound support to the rk3066 HDMI driver. > > The I2S input of the HDMI TX allows transmission of > DVD-Audio and decoded Dolby Digital > to A/V Receivers and high-end displays. > The interface

[RFC PATCH] drm/rockchip: vop_reg: add rk3036 hdmi support

2021-02-01 Thread Johan Jonker
A Rockchip Inno HDMI driver was added, but the rk3036 VOP regs with HDMI support in the manufacturer tree never made it to the mainline kernel. This patch adds only hdmi_en and hdmi_dclk_pol. The inno hdmi driver must set hdmi_pin_pol in GRF_SOC_CON2. Signed-off-by: Johan Jonker --- Not tested

[PATCH] drm/rockchip: vop_reg: add PX30 version info

2021-02-01 Thread Johan Jonker
To reduce memory various Rockchip VOP versions share common reg structures. However more recent added SoCs not always have to same futures as the old ones. Add PX30 missing version info, so all VOP version checks work correct if needed in the future. Signed-off-by: Johan Jonker --- drivers/gpu

[PATCH v6 5/5] ARM: dts: rockchip: enable hdmi_sound and i2s0 for rk3066a-mk808

2020-12-07 Thread Johan Jonker
Make some noise with mk808. Enable the hdmi_sound node and add i2s0 as sound source for hdmi. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a-mk808

[PATCH v6 0/5] Enable rk3066a HDMI sound

2020-12-07 Thread Johan Jonker
hanged v6: remove patches that are applied to linux-next add platform_device_unregister() restyle Changed v5: removed unused variable fill frame structure Johan Jonker (4): dt-bindings: display: add #sound-dai-cells property to rockchip rk3066 hdmi ARM: dts: rockchip: rk3066a: add #

[PATCH v6 1/5] dt-bindings: display: add #sound-dai-cells property to rockchip rk3066 hdmi

2020-12-07 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property. Add it to rockchip,rk3066-hdmi.yaml to document that the rk3066 HDMI TX also can be used to transmit some audio. Signed-off-by: Johan Jonker --- .../devicetree/bindi

[PATCH v6 4/5] ARM: dts: rockchip: add hdmi-sound node to rk3066a.dtsi

2020-12-07 Thread Johan Jonker
Add hdmi-sound node to rk3066a.dtsi, so that it can be reused by boards with HDMI support. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi index

  1   2   >