Re: DRM_UDL and GPU under Xserver

Hi Alexey, Daniel, On 05-04-2018 10:32, Daniel Vetter wrote: > On Thu, Apr 5, 2018 at 9:16 AM, Alexey Brodkin > wrote: >> Hi Daniel, >> >> On Thu, 2018-04-05 at 08:18 +0200, Daniel Vetter wrote: >>> On Wed, Apr 4, 2018 at 10:06 PM, Alexey Brodkin >>>

Re: [PATCHv2] drm/sun4i: validate modes for HDMI

Hi, On 13-12-2017 11:05, Hans Verkuil wrote: > On 13/12/17 11:30, Maxime Ripard wrote: >> Hi Hans, >> >> On Fri, Dec 08, 2017 at 04:48:47PM +0100, Hans Verkuil wrote: >>> When I connected my cubieboard running 4.15-rc1 to my 4k display I got no >>> picture. Some >>> digging found that there is

Re: [PATCH v4 0/9] drm/i915: Implement HDCP

Hi Sean, On 07-12-2017 00:00, Sean Paul wrote: > Welcome to version 4 of the patchset. I think we're nearing the finish line > (hopefully) now. This set addresses the review feedback from v3. I applied > some > R-b's from v3 review, and converted others to Cc since other changes were made > to

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

On 05-12-2017 11:53, Alexey Brodkin wrote: > > From my note above about udl_drm_gem_mmap() being only used in case of Xserver > I barely may conclude anything. Given my lack of knowledge of DRM guts > especially > when it comes to complicated cases with DMA buffer exports/imports I cannot > say >

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

Hi Alexey, On 04-12-2017 17:29, Alexey Brodkin wrote: > > Indeed, in case of kmscube etnaviv is a renderer while UDL > outputs the picture on the screen. Thats nice :) Ok, from your logs I was not able to see anything wrong. X server does not error exit and Prime seems to be working in DRM ...

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

On 04-12-2017 16:00, Alexey Brodkin wrote: > [30.763] (II) armada(0): etnaviv: Xv: using YUY2 format intermediate YUV > target > I'm wondering if this means that target format for UDL is YUV ... But anyway, I revisited your first email and noticed that you said kmscube runs fine. Is this

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

On 04-12-2017 14:53, Alexey Brodkin wrote: > Full log you may find below. Sorry but I meant /var/log/Xorg.0.log file. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: xf86-video-armada via UDL [was: Re: UDL's fbdev doesn't work for user-space apps]

On 04-12-2017 13:16, Alexey Brodkin wrote: > Option "kmsdev" "/dev/dri/card1" Which drm driver uses /dev/dri/card0? I'm seing drmOpen code and if you don't specify the busID it will fallback for the first card that matches "armada-drm" or "imx-drm" or "udl". > But if I swap

Re: UDL's fbdev doesn't work for user-space apps

Hi Alexey, On 04-12-2017 11:32, Alexey Brodkin wrote: > My first [probably incorrect] assumption is Xserver requires fbdev (/dev/fbX) > and it cannot use DRI video card natively. Is that correct? > > Xserver can use DRI directly, you need to enable modesetting driver in Xorg config or use the

Re: PROBLEM: Asus C201 video mode problems on HDMI hotplug (regression)

On 03-12-2017 05:20, Nick Bowler wrote: > > Your patch changes things. With this applied on top of 4.15-rc1 > it is failing 100% of the time instead of only half of the time. Ok, it was a long shot anyway. > > I brought the original test equipment back to the setup so I can > see the video and

Re: PROBLEM: Asus C201 video mode problems on HDMI hotplug (regression)

Hi Nick, On 01-12-2017 00:11, Nick Bowler wrote: > Hi, > > On 2017-11-27 22:30 -0500, Nick Bowler wrote: >> A note about the test setup: I had to remove the test equipment so I >> no longer have any information about the video mode from the sink side >> (like in the photos). Thus, with the

Re: [PATCH 04/10] drm/uapi: Deprecate DRM_MODE_FLAG_BCAST

ol and kms uapi. > > Since kms fbdev emulation never uses the corresponding fbdev flag > there should be no sane way for this to come back into kms via > userspace either. > > Cc: Jose Abreu <jose.ab...@synopsys.com> > Cc: Adam Jackson <a...@redhat.com> > Cc: Keit

Re: [PATCH 03/10] drm/uapi: Deprecate DRM_MODE_FLAG_PIXMUX

to do the the controller<->ramdac > interface with some ancient S3 graphics adapters. Why someone though > it would be a good idea to expose it directly to users I don't know. > And later on it got copied into the randr protocol and kms uapi. > > Cc: Jose Abreu <jose.ab...@s

Re: [PATCH v2 08/10] drm/uapi: Deprecate nonsense kms mode types

space code that would depend > on these. > > v2: Recommend DRIVER instead of BUILTIN (ajax) > > Cc: Jose Abreu <jose.ab...@synopsys.com> > Cc: Adam Jackson <a...@redhat.com> > Cc: Keith Packard <kei...@keithp.com> > Signed-off-by: Ville Syrjälä <ville.syr

Re: [PATCH v2 02/10] drm/uapi: Validate the mode flags/type

Hi Ville, On 15-11-2017 15:49, Ville Syrjala wrote: > > +#define DRM_MODE_FLAG_ALL (DRM_MODE_FLAG_PHSYNC | \ > + DRM_MODE_FLAG_NHSYNC | \ > + DRM_MODE_FLAG_PVSYNC | \ > +

Re: [PATCH 08/10] video/hdmi: Reject illegal picture aspect ratios

ha...@intel.com> > Cc: "Lin, Jia" <lin.a@intel.com> > Cc: Akashdeep Sharma <akashdeep.sha...@intel.com> > Cc: Jim Bride <jim.br...@linux.intel.com> > Cc: Jose Abreu <jose.ab...@synopsys.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.c

Re: [PATCH 07/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

On 13-11-2017 17:04, Ville Syrjala wrote: > From: Ville Syrjälä > > If the user mode would specify an aspect ratio other than 4:3 or 16:9 > we now silently ignore it. Maybe a better apporoach is to return an > error? Let's try that. > > Also we must be careful

Re: [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

Hi Ville, On 13-11-2017 17:04, Ville Syrjala wrote: > > + if (to_match->picture_aspect_ratio) > + match_flags |= DRM_MODE_MATCH_ASPECT_RATIO; > + > Maybe "if (to_match->picture_aspect_ratio != HDMI_PICTURE_ASPECT_NONE && to_match->picture_aspect_ratio !=

Re: [RESEND RFC PATCH 0/7] sun8i H3 HDMI glue driver for DW HDMI

Hi Jernej, On 20-09-2017 21:01, Jernej Skrabec wrote: > [added media mailing list due to CEC question] > > This patch series adds a HDMI glue driver for Allwinner H3 SoC. For now, only > video and CEC functionality is supported. Audio needs more tweaks. > > Series is based on the H3 DE2 patch

Re: [RFC][PATCH v3] drm: kirin: Add mode_valid logic to avoid mode clocks we can't generate

On 19-07-2017 20:21, John Stultz wrote: > On Wed, Jul 19, 2017 at 3:16 AM, Jose Abreu <jose.ab...@synopsys.com> wrote: >> Hi John, >> >> >> On 18-07-2017 18:59, John Stultz wrote: >>> Currently the hikey dsi logic cannot generate accurate byte >>

Re: [RFC][PATCH v3] drm: kirin: Add mode_valid logic to avoid mode clocks we can't generate

t; > This patch uses the new mode_valid callback (many thanks to > Jose Abreu for upstreaming it!) to ensure we don't select > modes we cannot generate. > > Also, since the ade crtc code will adjust the mode in mode_set, > this patch also adds a mode_fixup callback which we use

Re: [RFC][PATCH v2] drm: kirin: Add mode_valid logic to avoid mode clocks we can't generate

On 18-07-2017 17:56, John Stultz wrote: > On Tue, Jul 18, 2017 at 4:10 AM, Jose Abreu <jose.ab...@synopsys.com> wrote: >> Hi John, >> >> >> On 18-07-2017 05:22, John Stultz wrote: >>> Currently the hikey dsi logic cannot generate accurate byte >>

Re: [RFC][PATCH v2] drm: kirin: Add mode_valid logic to avoid mode clocks we can't generate

t; > This patch uses the new mode_valid callback (many thanks to > Jose Abreu for upstreaming it!) to ensure we don't select > modes we cannot generate. > > NOTE: Stylistically I suspect there are better ways to do what > I'm trying to do here. The encoder -> crtc bit is terrible,

[PATCH 2/3] drm: arcpgu: Fix module unload

At module unload we are expecting a struct drm_device but at probing we are not setting it right. Fix this and correct the arcpgu module unload. Signed-off-by: Jose Abreu <joab...@synopsys.com> Fixes: 0c4250e7b15e ("drm: Add support of ARC PGU display controller") Cc: Carlos

[PATCH 0/3] arcpgu: Fixes and improvements

Hi all, Two fixes and an improvement for arcpgu. I've sent this patches in separate but I've now collected them all to ease the review. Best regards, Jose Miguel Abreu Jose Abreu (3): drm: arcpgu: Fix mmap() callback drm: arcpgu: Fix module unload drm: arcpgu: Allow some clock deviation

[PATCH 1/3] drm: arcpgu: Fix mmap() callback

. Signed-off-by: Jose Abreu <joab...@synopsys.com> Fixes: 0c4250e7b15e ("drm: Add support of ARC PGU display controller") Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Cc: Dave Airli

DRM module unload and empty modesetting

Hi Daniel, all, So, I was playing around with arcpgu and I found a bug at module unloading. I corrected it and tested (using a 4.12 kernel) and I got a nice WARNING from DRM core at unloading (instead of the old NULL pointer I got :D). I debugged it and found out that an empty modesetting (i.e. a

[PATCH 3/3] drm: arcpgu: Allow some clock deviation in crtc->mode_valid() callback

deviation. Lets take that into an advantage and use it to calculate how much deviation we can support. Signed-off-by: Jose Abreu <joab...@synopsys.com> Acked-by: Alexey Brodkin <abrod...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.c

[PATCH] drm: arcpgu: Fix mmap() callback

Now that ARC properly supports DMA mmapping we can use the standard CMA helper to map dumb buffers. This makes ARC PGU works with standard DRM consumer applications like, for example, mpv via DRM. This fixes the use of dumb buffers. Signed-off-by: Jose Abreu <joab...@synopsys.com>

Re: [PATCH v2] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

Hi Archit, On 23-06-2017 10:36, Jose Abreu wrote: > Currently HDMI 2.0 PHYs do not have a default configuration function. > > As *some* of the HDMI 2.0 PHYs have the same register layout as the 3D > PHYs we can provide the same default configuration function for both > and

Re: [PATCH] drm/bridge: dw_hdmi: add cec notifier support

Hi Neil, On 06-07-2017 11:33, Neil Armstrong wrote: > From: Russell King > > Add CEC notifier support to the HDMI bridge driver, so that the CEC > part of the IP can receive its physical address. > > Tested-by: Neil Armstrong > Acked-by:

[PATCH] drm: arcpgu: Allow some clock deviation in crtc->mode_valid() callback

take that into an advantage and use it to calculate how much deviation we can support. This patch was based on today's drm-misc-next. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com>

[PATCH v2] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

platforms. This patch is based on today's drm-misc-next branch. Signed-off-by: Jose Abreu <joab...@synopsys.com> Tested-by: Mark Yao <mark@rock-chips.com> Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Cc: Laurent Pinchart <laurent.pinchart+rene...@ideason

Re: [PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback

Hi Daniel, Alexey, On 25-05-2017 15:19, Jose Abreu wrote: > Now that we have a callback to check if crtc supports a given mode > we can use it in arcpgu so that we restrict the number of probbed > modes to the ones we can actually display. > > This is specially useful beca

Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

Hi Laurent, Sorry for the late reply! On 10-06-2017 09:50, Laurent Pinchart wrote: > Hi Jose, > > On Friday 09 Jun 2017 13:53:12 Jose Abreu wrote: >> On 09-06-2017 12:04, Jose Abreu wrote: >>> Currently HDMI 2.0 PHYs do not have a default configuration function. &g

Re: [PATCH v3 2/6] dt-bindings: display: Add Synopsys DW MIPI DSI DRM bridge driver

Hello, On 09-06-2017 05:11, Archit Taneja wrote: > Hi Philippe, Rob, > > On 06/08/2017 09:10 PM, Rob Herring wrote: >> Seems strange there's not also a pixel or bit clock? Or this >> gets driven >> from the phy? > > Since you mention phy here, I wanted to share a concern with > the bindings. >

[PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

prefer the pdata provided configuration function over the internal one. This patch is based on today's drm-misc-next branch. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Cc: Laurent Pinchart <laurent.pinchart+rene...@i

Re: [PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx

Hi Mark, On 09-06-2017 05:03, Mark yao wrote: > Ignore this patch, Jose has a better patch to solve rk3399 hdmi > phy configure. > > Hi Jose > > Sorry for missing your patch about hdmi 2.0 vendor phy fixup: >

Re: [PATCH] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

Hi Mark, On 09-06-2017 12:04, Jose Abreu wrote: > Currently HDMI 2.0 PHYs do not have a default configuration function. > > As these PHYs have the same register layout as the 3D PHYs we can > safely use the default configuration function. I may have been a little to f

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

Hi Hans, On 02-06-2017 07:31, Hans Verkuil wrote: > On 06/01/2017 03:47 PM, Neil Armstrong wrote: >> On 05/30/2017 04:23 PM, Russell King wrote: >>> Add a CEC driver for the dw-hdmi hardware. >>> >>> Signed-off-by: Russell King >>> --- >>>

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

On 01-06-2017 23:30, Russell King - ARM Linux wrote: > On Thu, Jun 01, 2017 at 01:53:21AM +0100, Jose Abreu wrote: >> Hi Russell, >> >> >> On 30-05-2017 15:23, Russell King wrote: >>> +static int dw_hdmi_cec_transmit(struct cec_adapter *adap, u8 attempts,

Re: [PATCH 4/4] drm/bridge: dw-hdmi: add cec driver

Hi Russell, On 30-05-2017 15:23, Russell King wrote: > Add a CEC driver for the dw-hdmi hardware. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/bridge/synopsys/Kconfig | 8 + > drivers/gpu/drm/bridge/synopsys/Makefile | 1 + >

Re: [PATCH 3/4] drm/bridge: dw-hdmi: add better clock disable control

earing the bits that the video path needs to. > > Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 25 +++-- > 1 fi

[PATCH v5 08/10] drm/arm: malidp: Use crtc->mode_valid() callback

: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Liviu Dudau <liviu.du...@arm.com> Cc: Brian Starkey <brian.star...@arm.com> Cc: David Airlie <airl...@l

[PATCH v5 06/10] drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback

: Only compile tested. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Archit Taneja <arch...@codeaurora.org> Cc: Andrzej Hajda <a.ha...@samsung.com> Cc: Laurent Pinchart <laur

[PATCH v5 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback

: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Boris Brezillon <boris.brezil...@free-electrons.com> Cc: David Airlie <airl...@linux.ie> --

[PATCH v5 03/10] drm: Use new mode_valid() helpers in connector probe helper

ode loops through all the connector's encodersXbridgesXcrtcs and calls the callback. If at least a valid encoderXbridgeXcrtc combination is found which accepts the mode then the function returns MODE_OK. Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.v

[PATCH v5 05/10] drm: arcpgu: Use crtc->mode_valid() callback

this clock does not support all the needed ranges. Also, remove the atomic_check() callback as mode_valid() callback will be called before. Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Alexey Brodkin <abrod...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.

[PATCH v5 01/10] drm: Add drm_{crtc/encoder/connector}_mode_valid()

Add a new helper to call crtc->mode_valid, connector->mode_valid and encoder->mode_valid callbacks. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Revie

[PATCH v5 00/10] Introduce new mode validation callbacks

vel/2017-May/141761.html Jose Abreu (10): drm: Add drm_{crtc/encoder/connector}_mode_valid() drm: Introduce drm_bridge_mode_valid() drm: Use new mode_valid() helpers in connector probe helper drm: Use mode_valid() in atomic modeset drm: arcpgu: Use crtc->mode_valid() callback drm/b

[PATCH v5 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback

validation. NOTE: Only compile tested NOTE 2: I also had to change the pdata declaration of mode_valid custom callback so that the passed modes are const. I also changed in the platforms I found. Not even compiled it though. Signed-off-by: Jose Abreu <joab...@synopsys.com> Acked-by: Neil Arm

[PATCH v5 04/10] drm: Use mode_valid() in atomic modeset

be accepted in every components. Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.i

[PATCH v5 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks

. NOTE: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Eric Anholt <e...@anholt.net> Cc: David Airlie <airl...@linux.ie> --- drivers/gpu/drm/vc4/vc4_crtc

[PATCH v5 02/10] drm: Introduce drm_bridge_mode_valid()

Introduce a new helper function which calls mode_valid() callback for all bridges in an encoder chain. Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Ville Syrjälä <ville.sy

Re: [PATCH v4 00/10] Introduce new mode validation callbacks

Hi Daniel, On 22-05-2017 16:31, Daniel Vetter wrote: > On Mon, May 22, 2017 at 09:56:00AM +0200, Daniel Vetter wrote: >> On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote: >>> This series is a follow up from the discussion at [1]. We start by >>> introducing

Re: [PATCH v4 00/10] Introduce new mode validation callbacks

Hi Daniel, On 22-05-2017 08:56, Daniel Vetter wrote: > On Fri, May 19, 2017 at 01:52:09AM +0100, Jose Abreu wrote: >> This series is a follow up from the discussion at [1]. We start by >> introducing crtc->mode_valid(), encoder->mode_valid() and >> bridge-&g

[PATCH v4 07/10] drm/bridge/synopsys: dw-hdmi: Use bridge->mode_valid() callback

validation. NOTE: Only compile tested NOTE 2: I also had to change the pdata declaration of mode_valid custom callback so that the passed modes are const. I also changed in the platforms I found. Not even compiled it though. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha

[PATCH v4 04/10] drm: Use mode_valid() in atomic modeset

be accepted in every components. Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@syno

[PATCH v4 10/10] drm: vc4: Use crtc->mode_valid() and encoder->mode_valid() callbacks

. NOTE: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dav

[PATCH v4 02/10] drm: Introduce drm_bridge_mode_valid()

Introduce a new helper function which calls mode_valid() callback for all bridges in an encoder chain. Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abro

[PATCH v4 06/10] drm/bridge: analogix-anx78xx: Use bridge->mode_valid() callback

: Only compile tested. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dave Airlie

[PATCH v4 08/10] drm/arm: malidp: Use crtc->mode_valid() callback

: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dave Airlie

[PATCH v4 05/10] drm: arc: Use crtc->mode_valid() callback

this clock does not support all the needed ranges. Also, remove the atomic_check() callback as mode_valid() callback will be called before. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com>

[PATCH v4 00/10] Introduce new mode validation callbacks

ment it. [1] https://patchwork.kernel.org/patch/9702233/ [2] https://lists.freedesktop.org/archives/dri-devel/2017-May/141761.html Jose Abreu (10): drm: Add drm_{crtc/encoder/connector}_mode_valid() drm: Introduce drm_bridge_mode_valid() drm: Use new mode_valid() helpers in connector probe

[PATCH v4 03/10] drm: Use new mode_valid() helpers in connector probe helper

ode loops through all the connector's encodersXbridgesXcrtcs and calls the callback. If at least a valid encoderXbridgeXcrtc combination is found which accepts the mode then the function returns MODE_OK. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synops

[PATCH v4 01/10] drm: Add drm_{crtc/encoder/connector}_mode_valid()

Add a new helper to call crtc->mode_valid, connector->mode_valid and encoder->mode_valid callbacks. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Jose Abreu <joab...@synopsys.com> Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch> Revie

[PATCH v4 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback

: Not even compiled tested Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dav

Re: [PATCH 2/2] drm/doc: Clarify mode_fixup vs. atomic_check a bit more

alid, even if it looks like > that at first glance. > > Cc: Andrzej Hajda <a.ha...@samsung.com> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Jose Abreu <jose.ab...@synopsys.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Reviewed-b

Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper

Hi Laurent, On 15-05-2017 08:05, Laurent Pinchart wrote: > On Monday 15 May 2017 08:47:49 Daniel Vetter wrote: >> On Sun, May 14, 2017 at 02:04:24PM +0300, Laurent Pinchart wrote: >>> On Friday 12 May 2017 17:06:14 Jose Abreu wrote: >>>> On 12-05-2017

Re: [PATCH 1/2] drm/doc: Document adjusted/request modes a bit better

: Ville Syrjälä <ville.syrj...@linux.intel.com> > Cc: Jose Abreu <jose.ab...@synopsys.com> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> Reviewed-by: Jose Abreu <joab...@synopsys.com> Best regards, Jose Miguel Abreu > --- > include/drm/drm_bridge.h

Re: [PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback

Hi Daniel, On 15-05-2017 16:52, Daniel Vetter wrote: > On Mon, May 15, 2017 at 10:53:25AM +0200, Daniel Vetter wrote: >> On Thu, May 11, 2017 at 10:06:02AM +0100, Jose Abreu wrote: >>> Now that we have a callback to check if crtc supports a given mode >>> we can

Re: [PATCH v2 8/8] drm: arc: Use crtc->mode_valid() callback

Hi Laurent, Sorry for the late reply. On 12-05-2017 10:57, Laurent Pinchart wrote: > Hi Jose, > > Thank you for the patch. > > On Tuesday 09 May 2017 18:00:15 Jose Abreu wrote: >> Now that we have a callback to check if crtc supports a given mode >> we can use it in

Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper

Hi Laurent, On 12-05-2017 10:35, Laurent Pinchart wrote: > Hi Jose, > > Thank you for the patch. > > On Tuesday 09 May 2017 18:00:12 Jose Abreu wrote: >> This changes the connector probe helper function to use the new >> encoder->mode_valid() and crtc-

Re: [PATCH] drm: Add crtc/encoder/bridge->mode_valid() callbacks

Hi Daniel, On 12-05-2017 08:31, Daniel Vetter wrote: > From: Jose Abreu <jose.ab...@synopsys.com> > > This adds a new callback to crtc, encoder and bridge helper functions > called mode_valid(). This callback shall be implemented if the > corresponding component has som

[PATCH v3 2/6] drm: Add drm_{crtc/encoder/connector}_mode_valid()

Add a new helper to call crtc->mode_valid, connector->mode_valid and encoder->mode_valid callbacks. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Bro

[PATCH v3 4/6] drm: Use new mode_valid() helpers in connector probe helper

ode loops through all the connector's encodersXbridgesXcrtcs and calls the callback. If at least a valid encoderXbridgeXcrtc combination is found which accepts the mode then the function returns MODE_OK. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synops

[PATCH v3 0/6] Introduce new mode validation callbacks

g/patch/9702233/ Jose Abreu (6): drm: Add crtc/encoder/bridge->mode_valid() callbacks drm: Add drm_{crtc/encoder/connector}_mode_valid() drm: Introduce drm_bridge_mode_valid() drm: Use new mode_valid() helpers in connector probe helper drm: Use mode_valid() in atomic modeset

[PATCH v3 6/6] drm: arc: Use crtc->mode_valid() callback

this clock does not support all the needed ranges. Also, remove the atomic_check() callback as mode_valid() callback will be called before. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com>

[PATCH v3 1/6] drm: Add crtc/encoder/bridge->mode_valid() callbacks

also change the documentation so that the new and old callbacks are correctly documented. Only the callbacks were implemented to simplify review process, following patches will make use of them. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsy

[PATCH v3 3/6] drm: Introduce drm_bridge_mode_valid()

Introduce a new helper function which calls mode_valid() callback for all bridges in an encoder chain. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj..

[PATCH v3 5/6] drm: Use mode_valid() in atomic modeset

omponents. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Dave Airlie <airl...@linux.

Re: [PATCH v2 1/8] drm: Add crtc/encoder/bridge->mode_valid() callbacks

Hi Daniel, On 10-05-2017 09:03, Daniel Vetter wrote: > On Tue, May 09, 2017 at 06:00:08PM +0100, Jose Abreu wrote: >> This adds a new callback to crtc, encoder and bridge helper functions >> called mode_valid(). This callback shall be implemented if the >> corresponding co

Re: [PATCH v2 2/8] drm: Add drm_crtc_mode_valid()

Hi Daniel, On 10-05-2017 08:59, Daniel Vetter wrote: > On Tue, May 09, 2017 at 06:00:09PM +0100, Jose Abreu wrote: >> Add a new helper to call crtc->mode_valid callback. >> >> Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> >> Signed-off-by: Jos

Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid()

Hi Ville, On 10-05-2017 15:01, Jose Abreu wrote: > Hi Ville, > > > On 10-05-2017 14:41, Ville Syrjälä wrote: >> On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote: >>> Introduce a new helper function which calls mode_valid() callback >>>

Re: [PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid()

Hi Ville, On 10-05-2017 14:41, Ville Syrjälä wrote: > On Tue, May 09, 2017 at 06:00:13PM +0100, Jose Abreu wrote: >> Introduce a new helper function which calls mode_valid() callback >> for all bridges in an encoder chain. >> >> Signed-off-by: Jose Abreu <joab.

Re: [PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper

Hi Daniel, On 10-05-2017 09:01, Daniel Vetter wrote: > On Tue, May 09, 2017 at 06:00:12PM +0100, Jose Abreu wrote: >> This changes the connector probe helper function to use the new >> encoder->mode_valid() and crtc->mode_valid() helper callbacks to >> validate the mod

[PATCH v2 8/8] drm: arc: Use crtc->mode_valid() callback

this clock does not support all the needed ranges. Also, remove the atomic_check() callback as mode_valid() callback will be called before. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com>

[PATCH v2 5/8] drm: Use new mode_valid() helpers in connector probe helper

gh all the connector's encodersXcrtcs and calls the callback. If at least a valid encoderXcrtc combination is found which accepts the mode then the function returns MODE_OK. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abro

[PATCH v2 2/8] drm: Add drm_crtc_mode_valid()

Add a new helper to call crtc->mode_valid callback. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <

[PATCH v2 0/8] Introduce new mode validation callbacks

e, except the connector->mode_valid one, so that the mode is validated. This is done before calling mode_fixup(). Finally, at 8/8 we use the new crtc->mode_valid() callback in arcpgu and remove the atomic_check() callback. [1] https://patchwork.kernel.org/patch/9702233/ Jose Abreu (8): drm: A

[PATCH v2 3/8] drm: Add drm_encoder_mode_valid()

Add a new helper to call encoder->mode_valid callback. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc

[PATCH v2 4/8] drm: Add drm_connector_mode_valid()

Add a new helper to call connector->mode_valid callback. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc

[PATCH v2 1/8] drm: Add crtc/encoder/bridge->mode_valid() callbacks

also change the description of connector->mode_valid() callback so that it matches the existing behaviour: It is never called in atomic check phase. Only the callbacks were implemented to simplify review process, following patches will make use of them. Signed-off-by: Jose Abreu &l

[PATCH v2 7/8] drm: Use mode_valid() in atomic modeset

be accepted in every components. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc:

[PATCH v2 6/8] drm: Introduce drm_bridge_mode_valid()

Introduce a new helper function which calls mode_valid() callback for all bridges in an encoder chain. Signed-off-by: Jose Abreu <joab...@synopsys.com> Cc: Carlos Palminha <palmi...@synopsys.com> Cc: Alexey Brodkin <abrod...@synopsys.com> Cc: Ville Syrjälä <ville.syrj..

Re: [PATCH 2/5] drm: Use new mode_valid() helpers in connector probe helper

Hi Daniel, On 08-05-2017 08:50, Daniel Vetter wrote: > On Thu, May 04, 2017 at 03:11:39PM +0100, Jose Abreu wrote: >> This changes the connector probe helper function to use the new >> encoder->mode_valid() and crtc->mode_valid() helper callbacks to >> validate the mod

Re: [PATCH 2/5] drm: Use new mode_valid() helpers in connector probe helper

Hi Ville, On 04-05-2017 15:32, Ville Syrjälä wrote: > On Thu, May 04, 2017 at 03:11:39PM +0100, Jose Abreu wrote: >> This changes the connector probe helper function to use the new >> encoder->mode_valid() and crtc->mode_valid() helper callbacks to >> validate the mod

[PATCH 0/5] Introduce new mode validation callbacks

e the new crtc->mode_valid() callback in arcpgu and remove the atomic_check() callback. [1] https://patchwork.kernel.org/patch/9702233/ Jose Abreu (5): drm: Add crtc/encoder/bridge->mode_valid() callbacks drm: Use new mode_valid() helpers in connector probe helper drm: Introduce drm_br

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

Hi Daniel, On 03-05-2017 16:00, Daniel Vetter wrote: > On Wed, May 03, 2017 at 03:16:13PM +0100, Jose Abreu wrote: >> Hi Daniel, >> >> >> On 03-05-2017 07:19, Daniel Vetter wrote: >>> On Tue, May 2, 2017 at 11:29 AM, Jose Abreu <jose.ab...@synopsys.com&g

Re: [PATCH 1/2] drm: Introduce crtc->mode_valid() callback

Hi Daniel, On 03-05-2017 07:19, Daniel Vetter wrote: > On Tue, May 2, 2017 at 11:29 AM, Jose Abreu <jose.ab...@synopsys.com> wrote: >> On 02-05-2017 09:48, Daniel Vetter wrote: >>> On Wed, Apr 26, 2017 at 11:48:34AM +0100, Jose Abreu wrote: >>>> Some crtc

  1   2   3   4   >