[PATCH] drm: fix leaked dma handles after removing drm_pci_free

2021-05-18 Thread Joseph Kogut
After removing drm_pci_alloc/free, some instances where drm_pci_free() would have kfreed the dma handle were skipped. Ensure these handles are freed properly. Signed-off-by: Joseph Kogut --- drivers/gpu/drm/drm_bufs.c | 1 + drivers/gpu/drm/r128/ati_pcigart.c | 2 ++ 2 files changed, 3

[PATCH 1/1] drm: drm_legacy_addbufs_pci(): fix return without cleanup

2021-05-14 Thread Joseph Kogut
Unlocked on: 938,944,951,959,973,1005,1042,1060,1090 Fix the return without cleanup by removing the early return and taking the original return path on allocation failure, including the intended unlocks. Signed-off-by: Joseph Kogut --- drivers/gpu/drm/drm_bufs.c | 23 --- 1 file changed, 12 insertions(+),

Re: [bug report] drm: remove usage of drm_pci_alloc/free

2021-05-14 Thread Joseph Kogut
On Fri, May 14, 2021 at 8:13 AM Joseph Kogut wrote: > > Hi Dan, > > On Fri, May 14, 2021 at 6:54 AM Dan Carpenter > wrote: > > > > Hello Joseph Kogut, > > > > The patch 70556e24e18e: "drm: remove usage of drm_pci_alloc/free" > > from Apr

Re: [bug report] drm: remove usage of drm_pci_alloc/free

2021-05-14 Thread Joseph Kogut
Hi Dan, On Fri, May 14, 2021 at 6:54 AM Dan Carpenter wrote: > > Hello Joseph Kogut, > > The patch 70556e24e18e: "drm: remove usage of drm_pci_alloc/free" > from Apr 22, 2021, leads to the following static checker warning: > > drivers/gpu/drm/drm_buf

[PATCH 2/2] drm: remove legacy drm_pci_alloc/free abstraction

2021-04-23 Thread Joseph Kogut
The drm_pci_alloc/free abstraction of the dma-api is no longer required, remove it. Signed-off-by: Joseph Kogut --- drivers/gpu/drm/drm_pci.c | 58 --- include/drm/drm_legacy.h | 4 --- 2 files changed, 62 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 1/2] drm: remove usage of drm_pci_alloc/free

2021-04-23 Thread Joseph Kogut
Remove usage of legacy dma-api abstraction in preparation for removal Signed-off-by: Joseph Kogut --- Checkpatch warns here that r128 is marked obsolete, and asks for no unnecessary modifications. This series aims to address the FIXME in drivers/gpu/drm/drm_pci.c explaining that drm_pci_alloc

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-19 Thread Joseph Kogut
On Mon, Jun 17, 2019 at 9:36 AM Krzysztof Kozlowski wrote: > > On Mon, Jun 17, 2019 at 09:15:23AM -0700, Joseph Kogut wrote: > > Hi Krzysztof, > > > > Thanks for the review. > > > > On Sun, Jun 16, 2019 at 1:59 AM Krzysztof Kozlowski wrote: > > > &

Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-18 Thread Joseph Kogut
Hi Krzysztof, Thanks for the review. On Sun, Jun 16, 2019 at 1:59 AM Krzysztof Kozlowski wrote: > > On Fri, Jun 14, 2019 at 04:57:19PM -0700, Joseph Kogut wrote: > > Add device tree node for mali gpu on Odroid XU3 SoCs. > > > > Signed-off-by: Joseph Kogut > >

[PATCH 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-16 Thread Joseph Kogut
Add device tree node for mali gpu on Odroid XU3 SoCs. Signed-off-by: Joseph Kogut --- .../boot/dts/exynos5422-odroidxu3-common.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422

[PATCH 1/2] dt-bindings: gpu: add Exynos Mali vendor specifics

2019-06-16 Thread Joseph Kogut
Document vendor specific compatible string for Mali gpus on Exynos SoCs. Signed-off-by: Joseph Kogut --- Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation

[PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3

2019-06-16 Thread Joseph Kogut
Add device tree node for mali gpu on Odroid XU3 SoCs. Signed-off-by: Joseph Kogut --- Changes v1 -> v2: - Use interrupt name ordering from binding doc - Specify a single clock for GPU node - Add gpu opp table - Fix warnings from IRQ_TYPE_NONE .../boot/dts/exynos5422-odroidxu3-common.dtsi |