return EINVAL.
Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.")
Signed-off-by: Justin green
Reviewed-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/dr
return EINVAL.
Signed-off-by: Justin green
---
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index 4f2e3feabc0f..ee49367b6138 100644
--- a/drivers/gpu/drm/mediatek
Add MT8188 overlay driver configuration data. This change consequently
enables 10-bit overlay support on MT8188 devices.
Tested by running ChromeOS UI on MT8188 and using modetest -P. AR30 and
BA30 overlays are confirmed to work from modetest.
Signed-off-by: Justin Green
Tested-by: Justin Green
In that case, this entire patch might be unnecessary in the
tip of tree kernel.
On Thu, Aug 3, 2023 at 4:24 AM Daniel Vetter wrote:
>
> On Mon, Jul 24, 2023 at 01:58:39PM -0400, Justin Green wrote:
> > Add a check to mtk_drm_mode_fb_create() that rejects any modifier that
> > is not the
rts AR30 and BA30, but plane ID 50 does not support any 10-bit
pixel formats.
On Thu, Jul 27, 2023 at 5:37 AM AngeloGioacchino Del Regno
wrote:
>
> Il 26/07/23 21:44, Justin Green ha scritto:
> >> Would it make more sense to commmonize function
> >> mtk_plane_format_mo
ifier" that attempts to create a framebuffer with the
modifier DRM_FORMAT_MOD_INVALID and verifies the ADDFB2 ioctl returns
EINVAL.
Signed-off-by: Justin Green
Tested-by: Fei Shao
---
v2:
* Replace zero check with comparison to DRM_FORMAT_MOD_LINEAR.
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 7 +
> Would it make more sense to commmonize function
> mtk_plane_format_mod_supported()
> and call that one here instead?
I had considered that, but mtk_plane_format_mod_supported() is
required to take a drm_plane as a parameter in order to conform to the
type signature defined in drm_plane_funcs,
ifier" that attempts to create a framebuffer with the
modifier DRM_FORMAT_MOD_INVALID and verifies the ADDFB2 ioctl returns
EINVAL.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/d
ifier" that attempts to create a framebuffer with the
modifier DRM_FORMAT_MOD_INVALID and verifies the ADDFB2 ioctl returns
EINVAL.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/d
overlays for MT8195
devices, but this current patch should be a no-op. This patch was tested by
simply running Chrome on an MT8195 and looking for regressions.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 33 +
1 file changed, 33 insertions(+)
diff
Add an DDP component interface for querying pixel format support and move list
of supported pixel formats into DDP components instead of mtk_drm_plane.c
Tested by running Chrome on an MT8195.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 ++
drivers/gpu/drm
overlays for MT8195
devices, but this current patch should be a no-op. This patch was tested by
simply running Chrome on an MT8195 and looking for regressions.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 33 +
1 file changed, 33 insertions(+)
diff
Justin:
>
> Justin Green 於 2023年3月8日 週三 下午11:34寫道：
> >
> > Tested using "modetest -P" on an MT8195 device.
>
> I think you could not test this when only apply the first two patches
> of this series, so move the test information to the third patch. In
> this pat
st -P" on an MT8195 device. The test pattern displays
correctly for both AR30 and BA30 formats.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
support on
MT8195.
v8:
* Updated descriptions for patches 2 and 3 in the series.
Justin Green (3):
drm/mediatek: Refactor pixel format logic
drm/mediatek: Add support for AR30 and BA30 overlays
drm/mediatek: Enable AR30 and BA30 overlays on MT8195
drivers/gpu/drm/mediatek/mtk_disp_drv.h
Tested using "modetest -P" on an MT8195 device.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
b/drivers/gpu/drm/mediatek/mtk_
Tested using "modetest -P" on an MT8195 device.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
b/drivers/gpu/drm/mediatek/mtk_disp_o
Add an DDP component interface for querying pixel format support and move list
of supported pixel formats into DDP components instead of mtk_drm_plane.c
Tested by running Chrome on an MT8195.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 ++
drivers/gpu/drm
support on
MT8195.
Justin Green (3):
drm/mediatek: Refactor pixel format logic
drm/mediatek: Add support for AR30 and BA30 overlays
drm/mediatek: Enable AR30 and BA30 overlays on MT8195
drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 +
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 94
> Yes, I had a comment on the naming in that patch. Never the less, I think if
> we
> don't need to "overwrite" the value, we should use just one struct for the
> values instead of copying them to the different .c files and give them SoC
> specific names.
I don't have a very strong opinion about
Hi Matthias,
> mt8173_formats are the same as the old struct formats. Maybe we should use
> that
> and only overwrite where we actually use a different array.
I think this was sort of how the original patch worked, but we wanted
to add some flexibility to allow different components to support
Tested using "modetest -P" on an MT8195 device.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
b/drivers/gpu/drm/mediatek/mtk_
Tested using "modetest -P" on an MT8195 device.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
b/drivers/gpu/drm/mediatek/mtk_disp_o
Add an DDP component interface for querying pixel format support and move list
of supported pixel formats into DDP components instead of mtk_drm_plane.c
Tested by running Chrome on an MT8195.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 ++
drivers/gpu/drm
support on
MT8195.
Justin Green (3):
drm/mediatek: Refactor pixel format logic
drm/mediatek: Add support for AR30 and BA30 overlays
drm/mediatek: Enable AR30 and BA30 overlays on MT8195
drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 +
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 94
Hi Chun-Kuang,
> Does all SoC have this register? If no, you should write this register
> for the SoC have this register.
I can't confirm this from the documentation that I have, I can only
confirm this register exists on MT8195 and MT8186. I will send out
another patch.
Thanks,
Justin
-adaptor patch series does not yet implement the
get_formats() interface. I can send a follow-up patch after the
ovl-adaptor series lands, or let Nancy know about the potential
runtime issue.
Regards,
Justin
On Wed, Feb 1, 2023 at 10:30 AM Chun-Kuang Hu wrote:
>
> Hi, Justin:
>
> Jus
checkpatch.pl
v6:
* Refactor patch into patch series.
* Add formats directly to private data.
On Tue, Jan 31, 2023 at 3:08 PM Justin Green wrote:
>
> This patch series adds support for 10-bit overlays to the Mediatek DRM driver.
> Specifically, we add support for AR30 and BA30 overlays
Add an DDP component interface for querying pixel format support and move list
of supported pixel formats into DDP components instead of mtk_drm_plane.c
Tested by running Chrome on an MT8195.
Signed-off-by: Justin Green
edit1
---
drivers/gpu/drm/mediatek/mtk_disp_drv.h | 4 ++
drivers
Add support for overlays with pixel formats AR30 and BA30 on MT8195.
Tested using "modetest -P" on an MT8195 device.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 49 -
1 file changed, 47 insertions(+), 2 deletions(-)
diff --git
with union based approach.
* Refactored overlay register writes to shared code between non-AFBC and
AFBC.
* Minor code cleanups.
v2:
* Marked mtk_ovl_set_afbc as static.
* Reflowed some lines to fit column limit.
Justin Green (2):
drm/mediatek: Refactor pixel format logic
drm/mediatek: Add
this patch might conflict with the
in-flight ovl-adaptor patch. Is there a protocol for a situation like
this?
Regards,
Justin
On Mon, Jan 30, 2023 at 7:28 PM Chun-Kuang Hu wrote:
>
> Hi, Justin:
>
> Justin Green 於 2023年1月31日 週二 上午4:36寫道：
> >
> > Add support for AR3
Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver.
Tested using "modetest -P" on an MT8195.
Signed-off-by: Justin Green
---
v2:
* Rebase and resolve merge conflicts with the AFBC patch.
v3:
* Moved 10-bit support detection to mtk_disk_ovl.c
v4:
* Mov
Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver.
Tested using "modetest -P" on an MT8195.
Signed-off-by: Justin Green
---
v2:
* Rebase and resolve merge conflicts with the AFBC patch.
v3:
* Moved 10-bit support detection to mtk_disk_ovl.c
v4:
* Mov
Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver.
Tested using "modetest -P" on an MT8195.
Signed-off-by: Justin Green
---
v2:
* Rebase and resolve merge conflicts with the AFBC patch.
v3:
* Moved 10-bit support detection to mtk_disk_ovl.c
drivers/gpu/dr
Thanks for the suggestion! That's a lot cleaner than manually
traversing the device tree. Will send out another patch.
On Thu, Jan 26, 2023 at 7:36 PM Chun-Kuang Hu wrote:
>
> Hi, Justin:
>
> Justin Green 於 2023年1月11日 週三 上午4:47寫道：
> >
> > Add support for AR3
Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver.
Tested using "modetest -P" on an MT8195.
Signed-off-by: Justin Green
---
v2:
* Rebase and resolve merge conflicts with the AFBC patch.
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 28 +
drive
Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver.
Tested using "modetest -P" on an MT8195.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 29 ++
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 +++-
drive
From: Justin Green
Tested on MT8195 and confirmed both correct video output and improved DRAM
bandwidth performance.
v5:
* Removed some dead defines.
* Refactored mtk_ovl_set_afbc().
v4:
* Move modifier validation to format_mod_supported function.
* Add modifiers to drm_universal_plane_init
Hi Chun-Kuang,
> > + mtk_ovl_set_afbc(dev, cmdq_pkt, idx, is_afbc);
> > mtk_ddp_write_relaxed(cmdq_pkt, con, >cmdq_reg, ovl->regs,
> > DISP_REG_OVL_CON(idx));
> > - mtk_ddp_write_relaxed(cmdq_pkt, pitch, >cmdq_reg, ovl->regs,
> > +
Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver.
Tested using "modetest -P" on an MT8195.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 29 ++
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 19 +++-
drive
.
* Reflowed some lines to fit column limit.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 67 -
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 74 +++-
drivers/gpu/drm/mediatek/mtk_drm_plane.h | 8 +++
3 files changed, 144 insertions
Thanks for the comments everyone! I'll upload a new CL sometime today.
I did want to ask though, I realize I should be using u32/u64 for
kernel code in general, but the rest of this file seems to be written
using unsigned int/unsigned long long. In this circumstance, does
keeping with the style
as static.
* Reflowed some lines to fit column limit.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 90 +++-
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 37 +-
drivers/gpu/drm/mediatek/mtk_drm_plane.h | 8 +++
3 files changed, 131 insertions
> These would be different from the macros that are available in bitfield.h, but
> not *fundamentally* different, so these would look a little redundant...
>
> I think that you refer to that `pitch` variable that's coming from the
> DRM(/fb)
> API... and bitfield macros are for register access...
gt; 16) & GENMASK(15, 0))
#define OVL_PITCH_LSB(n)(n & GENMASK(15, 0))
Regards,
Justin
On Tue, Oct 11, 2022 at 5:09 AM AngeloGioacchino Del Regno
wrote:
>
> Il 10/10/22 17:01, Justin Green ha scritto:
> > From: Justin Green
> >
> > Add AFBC sup
From: Justin Green
Add AFBC support to Mediatek DRM driver and enable on MT8195.
Tested on MT8195 and confirmed both correct video output and improved DRAM
bandwidth performance.
v2:
Marked mtk_ovl_set_afbc as static, reflowed some lines to fit column
limit.
Signed-off-by: Justin Green
Add AFBC support to Mediatek DRM driver and enable on MT8195.
Tested on MT8195 and confirmed both correct video output and improved DRAM
bandwidth performance.
v2:
Marked mtk_ovl_set_afbc as static, reflowed some lines to fit column
limit.
Signed-off-by: Justin Green
---
drivers/gpu/drm
Add AFBC support to Mediatek DRM driver and enable on MT8195.
Tested on MT8195 and confirmed both correct video output and improved DRAM
bandwidth performance.
Signed-off-by: Justin Green
---
drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 106 ---
drivers/gpu/drm/mediatek
49 matches
Mail list logo
