Re: [PATCH v3 00/10] drm: rcar-du: Rework CRTC and groups for atomic commits

2019-06-18 Thread Kieran Bingham
m: rcar-du: > Rework CRTC and groups for atomic commits" and "[RFC PATCH 0/3] VSP1/DU > atomic interface changes" series. Thanks for getting this series ready for integration. For the changes made to patches originally authored by me: Reviewed-by: Kieran Bingham For you

Re: [PATCH v3 02/10] media: vsp1: drm: Don't configure hardware when the pipeline is disabled

2019-06-18 Thread Kieran Bingham
t Pinchart Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_drm.c | 13 - > drivers/media/platform/vsp1/vsp1_drm.h | 2 ++ > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_drm.c > b/driv

Re: [PATCH v3 07/10] drm: rcar-du: Provide for_each_group helper

2019-06-18 Thread Kieran Bingham
Hi Laurent, On 17/06/2019 22:09, Laurent Pinchart wrote: > From: Kieran Bingham > > Refactoring of the group control code will soon require more iteration > over the available groups. Simplify this process by introducing a group > iteration helper. > > Signed-off-by: Kie

Re: [PATCH v3 07/10] drm: rcar-du: Skip LVDS1 output on Gen3 when using dual-link LVDS mode

2019-06-07 Thread Kieran Bingham
; > Signed-off-by: Laurent Pinchart > Reviewed-by: Jacopo Mondi > Tested-by: Jacopo Mondi And finally, Last one... Reviewed-by: Kieran Bingham > --- > Changess since v2: > > - Remove unneeded bridge NULL check > --- > drivers/gpu/drm/rcar-du/rcar_du_encoder.c |

Re: [PATCH v3 08/10] arm64: dts: renesas: r8a7799[05]: Point LVDS0 to its companion LVDS1

2019-06-07 Thread Kieran Bingham
Hi Laurent, On 28/05/2019 15:12, Laurent Pinchart wrote: > Add the new renesas,companion property to the LVDS0 node to point to the > companion LVDS encoder LVDS1. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Jacopo Mondi > Tested-by: Jacopo Mondi Reviewed-

Re: [PATCH v3 06/10] drm: rcar-du: lvds: Add support for dual-link mode

2019-06-07 Thread Kieran Bingham
Mondi Looks good to me. Reviewed-by: Kieran Bingham > --- > Changes since v2: > > - Fail probe if the companion controller can't be found or is invalid > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 107 > drivers/gpu/drm/rcar-du/rcar_lvds.h |

Re: [PATCH v3 03/10] drm: bridge: thc63: Report input bus mode through bridge timings

2019-06-07 Thread Kieran Bingham
off-by: Laurent Pinchart > Reviewed-by: Jacopo Mondi > Tested-by: Jacopo Mondi Reviewed-by: Kieran Bingham > --- > Changes since v1: > > - Ignore disabled remote device > --- > drivers/gpu/drm/bridge/thc63lvd1024.c | 54 +-- > 1 file changed, 4

Re: [PATCH v3 02/10] dt-bindings: display: bridge: thc63lvd1024: Document dual-link operation

2019-06-07 Thread Kieran Bingham
Hi Laurent, On 07/06/2019 23:30, Laurent Pinchart wrote: > Hi Kieran, > > On Fri, Jun 07, 2019 at 11:15:06PM +0100, Kieran Bingham wrote: >> On 28/05/2019 15:12, Laurent Pinchart wrote: >>> The THC63LVD1024 LVDS decoder can operate in two modes, single-link or >>

Re: [PATCH v3 04/10] dt-bindings: display: renesas: lvds: Add renesas,companion property

2019-06-07 Thread Kieran Bingham
. This property is > + mandatory for the first LVDS encoder on D3 and E3 SoCs, and shall point to > + the second encoder to be used as a companion in dual-link mode. It shall > not > + be set for any other LVDS encoder. > + I see Sam has already asked for an updated example, so with that: I'm fine with the text above. Reviewed-by: Kieran Bingham > > Example: > > -- Regards -- Kieran

Re: [PATCH v3 00/10] R-Car DU: LVDS dual-link mode support

2019-06-07 Thread Kieran Bingham
Hi Laurent, On 28/05/2019 15:12, Laurent Pinchart wrote: > Hello everybody, > > This patch series implements support for LVDS dual-link mode in the > R-Car DU and R-Car LVDS encoder drivers, and well as in the thc63lvd1024 > LVDS decoder driver. > > LVDS dual-link is a mode of operation where

Re: [PATCH v3 02/10] dt-bindings: display: bridge: thc63lvd1024: Document dual-link operation

2019-06-07 Thread Kieran Bingham
@0, and port@1 shall contain endpoints, so that implies that you only expect to support dual-in with the 'dual-link' property. If that is correct, should it be stated explicitly? Otherwise, Reviewed-by: Kieran Bingham > Example: > > > -- Regards -- Kieran _

Re: [PATCH v3 05/10] drm: rcar-du: lvds: Remove LVDS double-enable checks

2019-06-07 Thread Kieran Bingham
hopefully is a good thing! > > Signed-off-by: Laurent Pinchart > Reviewed-by: Jacopo Mondi > Tested-by: Jacopo Mondi > Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 19 --- > 1 file changed, 19 deletions(-) > > diff --gi

[PATCH 1/3] media: vsp1: drm: Split vsp1_du_setup_lif()

2019-05-17 Thread Kieran Bingham
Break vsp1_du_setup_lif() into components more suited to the DRM Atomic API. The existing vsp1_du_setup_lif() API call is maintained as it is still used from the DU. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_drm.c | 233 ++--- include/media/vsp1.h

[PATCH 2/3] drm: rcar-du: Convert to the new VSP atomic API

2019-05-17 Thread Kieran Bingham
users of the deprecated vsp1_du_setup_lif() which can now be removed. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 +++- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 21 +++-- drivers/gpu/drm/rcar-du/rcar_du_vsp.h | 2 ++ 3 files changed, 20 insertions

[PATCH 3/3] media: vsp1: drm: Remove vsp1_du_setup_lif()

2019-05-17 Thread Kieran Bingham
The vsp1_du_setup_lif() function is deprecated, and the users have been removed. Remove the implementation and the associated configuration structure. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_drm.c | 47 -- include/media/vsp1.h

[RFC PATCH 0/3] VSP1/DU atomic interface changes

2019-05-17 Thread Kieran Bingham
the call is removed entirely in [patch 3/3] Whilst these patches are independent and could be reviewed separately, they are not expected to be integrated until the associated group rework is completed. Kieran Bingham (3): media: vsp1: drm: Split vsp1_du_setup_lif() drm: rcar-du: Convert

[PATCH] drm: rcar-du: writeback: include interface header

2019-05-17 Thread Kieran Bingham
as appropriate. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_writeback.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_writeback.c b/drivers/gpu/drm/rcar-du/rcar_du_writeback.c index 989a0be94131..ae07290bba6a 100644 --- a/drivers/gpu/drm

Re: [PATCH/RFC 01/15] drm: Clarify definition of the DRM_BUS_FLAG_(PIXDATA|SYNC)_* macros

2019-04-24 Thread Kieran Bingham
aurent Pinchart > Acked-by: Linus Walleij Reviewed-by: Kieran Bingham > --- > include/drm/drm_connector.h | 36 > 1 file changed, 32 insertions(+), 4 deletions(-) > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h &

Re: [PATCH/RFC 02/15] drm: Use new DRM_BUS_FLAG_*_(DRIVE|SAMPLE)_(POS|NEG)EDGE flags

2019-04-24 Thread Kieran Bingham
w based on the surrounding comments, but even if those comments prompt action - I don't think those changes should necessarily be part of this patch. Therefore: Reviewed-by: Kieran Bingham > 25 files changed, 77 insertions(+), 68 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/dumb-vg

Re: [PATCH/RFC 03/15] drm/bridge: use bus flags in bridge timings

2019-04-24 Thread Kieran Bingham
gt; > In the case at hand a dumb VGA bridge needs a specific data enable > polarity (DRM_BUS_FLAG_DE_LOW). > > Signed-off-by: Stefan Agner > Signed-off-by: Laurent Pinchart Trivial but, should you have a +renesas^ there? > Reviewed-by: Tomi Valkeinen Reviewed-by

Re: [PATCH/RFC 04/15] drm: bridge: Add dual_link field to the drm_bridge_timings structure

2019-04-24 Thread Kieran Bingham
bered pixels are transferred on separate LVDS links. Do you foresee this becoming a bitfield in the future if there are more options? I don't think that affects this right now though, and it's fine as a bool. > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > inc

Re: [PATCH V2 3/4] drm: rcar-du: Add R8A774A1 support

2019-04-12 Thread Kieran Bingham
atch, Reviewed-by: Kieran Bingham > --- > V1-->V2 > * Incorporated Kieran's review comment > (https://patchwork.kernel.org/patch/10896165/) > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 30 ++ > 1 file changed, 30 insertions(+) &g

Re: [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support

2019-04-12 Thread Kieran Bingham
onfiguration and layout match. We're lacking the TCON, but that's not supported currently anyway, and shouldn't matter here. Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.

Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support

2019-04-12 Thread Kieran Bingham
Hi Biju, On 11/04/2019 15:34, Biju Das wrote: > Add support for the R8A774A1 DU (which is very similar to the R8A7796 DU); > it has one RGB output, one LVDS output and one HDMI output. > > Signed-off-by: Biju Das I see Figure 35.1b across the two datasheets does show some differences between

Re: [PATCH 2/4] dt-bindings: display: renesas: lvds: Document r8a774a1 bindings

2019-04-12 Thread Kieran Bingham
Hi Biju, Thank you for the patch, On 11/04/2019 15:34, Biju Das wrote: > Document the RZ/G2M (R8A774A1) LVDS bindings. > > Signed-off-by: Biju Das This looks good. Reviewed-by: Kieran Bingham > --- > Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt

Re: [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings

2019-04-12 Thread Kieran Bingham
ugh my Renesas NDA channels. > Signed-off-by: Biju Das Reviewed-by: Kieran Bingham > --- > Documentation/devicetree/bindings/display/renesas,du.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt > b/

Re: [PATCH 2/2] drm/omap: simplify getting .driver_data

2019-03-22 Thread Kieran Bingham
s good to me. Reviewed-by: Kieran Bingham > --- > > Build tested only. buildbot is happy. > > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 18 ++ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-d

Re: [PATCH 1/2] drm/msm: simplify getting .driver_data

2019-03-22 Thread Kieran Bingham
Hi Wolfram, Thank you for the patch, On 19/03/2019 16:36, Wolfram Sang wrote: > We should get 'driver_data' from 'struct device' directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang This looks good to me. Reviewed-by: Ki

[PATCH v2 5/6] drm: rcar-du: Create a group state object

2019-03-15 Thread Kieran Bingham
Create a new private state object for the DU groups, and move the initialisation of a group object to a new function rcar_du_group_init(). Signed-off-by: Kieran Bingham --- v2: - No change drivers/gpu/drm/rcar-du/rcar_du_group.c | 81 + drivers/gpu/drm/rcar-du

[PATCH v2 6/6] drm: rcar-du: Add group hooks for atomic-commit

2019-03-15 Thread Kieran Bingham
, and so are accessible only when one of its CRTCs has been powered through rcar_du_crtc_atomic_exit_standby(). Signed-off-by: Kieran Bingham --- v2: - All register sequences now maintained. - Clock management is no longer handled by the group (_crtc_{exit,enter}_standby handles this for us

[PATCH v2 1/6] drm: rcar-du: Link CRTCs to the DU device

2019-03-15 Thread Kieran Bingham
pointers. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 48 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 ++ drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +- 3 files changed, 27 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/rcar-du

[PATCH v2 4/6] drm: rcar-du: Provide for_each_group helper

2019-03-15 Thread Kieran Bingham
Refactoring of the group control code will soon require more iteration over the available groups. Simplify this process by introducing a group iteration helper. Signed-off-by: Kieran Bingham --- v2: - no change drivers/gpu/drm/rcar-du/rcar_du_drv.h | 5 + drivers/gpu/drm/rcar-du

[PATCH v2 2/6] drm: rcar-du: Add CRTC standby helpers

2019-03-15 Thread Kieran Bingham
Provide helpers to manage the power state, and initial configuration of the CRTC. rcar_du_crtc_get() and rcar_du_crtc_get() are no longer used, and are removed, simplifying the implementation and removing the initialized flag which was needed to track the state of the CRTC. Signed-off-by: Kieran

[PATCH v2 3/6] drm: rcar-du: Add pre/post commit CRTC helpers

2019-03-15 Thread Kieran Bingham
Provide helpers to allow CRTC configuration to be separated from the power state handling. rcar_du_crtc_atomic_post_commit() is a no-op, but maintained for API symmetry. --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 25 +++-- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 5 +

[PATCH v2 0/6] drm: rcar-du: Rework CRTC and groups for atomic commits

2019-03-15 Thread Kieran Bingham
, but needs to be synchronised with VSP update. These patches are based on top of my previous cleanup series, which is on top of drm-next. Kieran Bingham (6): drm: rcar-du: Link CRTCs to the DU device drm: rcar-du: Add CRTC standby helpers drm: rcar-du: Add pre/post commit CRTC helpers drm: rcar

[RFC PATCH 1/5] drm: rcar-du: Link CRTCs to the DU device

2019-03-15 Thread Kieran Bingham
pointers. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 48 +- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 ++ drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +- 3 files changed, 27 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/rcar-du

[RFC PATCH 4/5] drm: rcar-du: add group hooks for atomic-commit

2019-03-15 Thread Kieran Bingham
in the group. Signed-off-by: Kieran Bingham --- I'm already looking to refactor the series and put the CRTC handlng first. This will mean that the CRTC will power up the group instead, and the 'stealing' of the CRTC clock (rgrp->clock = rcdu->crtcs[rgrp->index * 2].clock;) can be removed driver

[RFC PATCH 2/5] drm: rcar-du: Provide for_each_group helper

2019-03-15 Thread Kieran Bingham
Refactoring of the group control code will soon require more iteration over the available groups. Simplify this process by introducing a group iteration helper. Signed-off-by: Kieran Bingham --- I'm not yet sure if the second patch which utilises this helper will make it to the final cut

[RFC PATCH 5/5] drm: rcar-du: Add crtc standby helpers

2019-03-15 Thread Kieran Bingham
of the CRTC. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 94 ++ drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 7 +- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 + 3 files changed, 57 insertions(+), 46 deletions(-) diff --git a/drivers/gpu/drm

[RFC PATCH 3/5] drm: rcar-du: Create a group state object

2019-03-15 Thread Kieran Bingham
Create a new private state object for the DU groups, and move the initialisation of a group object to a new function rcar_du_group_init(). Signed-off-by: Kieran Bingham --- I'll be extending the data that goes into this private structure. Have I got the creation and handling of the private

[RFC PATCH 0/5] drm: rcar-du: Rework CRTC and groups for atomic commits

2019-03-15 Thread Kieran Bingham
-state group-state, and start to utilise that to refactor so that all hardware operations can occur during rcar_du_atomic_commit_tail(). This is only RFC state at the moment, and I am actively working on this code. Kieran Bingham (5): drm: rcar-du: Link CRTCs to the DU device drm: rcar-du: Provide

[PATCH 3/3] drm: rcar-du: Remove unused prototypes

2019-03-14 Thread Kieran Bingham
The CRTC suspend and resume functions have been replaced, but the prototypes were not removed. Remove the redundant definitions. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.h

[PATCH 2/3] drm: rcar-du: crtc: make local functions static

2019-03-14 Thread Kieran Bingham
The rcar_du_crtc_mode_valid() and rcar_du_crtc_get_crc_sources() functions are accessed only through a function pointer table. Convert the function definitions to be static to the module. Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 9 + 1 file changed, 5

[PATCH 1/3] drm: fix subtle spelling error in drm_crtc_state

2019-03-14 Thread Kieran Bingham
The drm_crtc_state documentation contains a subtle misspelling of the word subtle. Correct it. Signed-off-by: Kieran Bingham --- include/drm/drm_crtc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 85abd3fe9e83

[PATCH 0/3] drm: rcar-du: Cleanup minor CRTC issues

2019-03-14 Thread Kieran Bingham
Three fairly trivial cleanup patches from while I've been working on the CRTC code on rcar-du. The first is a small spelling error in the drm_crtc_state documentation, and the following two are more directly cleaning up the rcar-du. Kieran Bingham (3): drm: fix subtle spelling error

Re: [PATCH v6 11/18] media: vsp1: drm: Implement writeback support

2019-03-14 Thread Kieran Bingham
Hi Laurent, On 13/03/2019 15:56, Laurent Pinchart wrote: > Hi Kieran, > > On Wed, Mar 13, 2019 at 11:42:34AM +0000, Kieran Bingham wrote: >> On 13/03/2019 00:05, Laurent Pinchart wrote: >>> Extend the vsp1_du_atomic_flush() API with writeback support by adding >

Re: [PATCH v6 18/18] drm: rcar-du: Add writeback support for R-Car Gen3

2019-03-13 Thread Kieran Bingham
or > R-Car Gen2 with a consistent API if desired. > > Signed-off-by: Laurent Pinchart An extra blank line, and I was a bit concerned about a function naming below - but other than that: Reviewed-by: Kieran Bingham > --- > Changes since v5: > > - Skip writeback conne

Re: [PATCH v6 17/18] drm: rcar-du: vsp: Extract framebuffer (un)mapping to separate functions

2019-03-13 Thread Kieran Bingham
ll be useful to implement writeback support. Split > the mapping and unmapping out to separate functions. > > Signed-off-by: Laurent Pinchart Looks good to me, Just a refactor and nothing controversial. Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm

Re: [PATCH v6 12/18] drm: writeback: Cleanup job ownership handling when queuing job

2019-03-13 Thread Kieran Bingham
ing NULL set in the vc4 driver), pass the connector > state pointer to the function instead of the job pointer, and set the > writeback_job pointer to NULL internally. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Brian Starkey > Acked-by: Eric Anholt > Acked-by: Liviu Du

Re: [PATCH v6 11/18] media: vsp1: drm: Implement writeback support

2019-03-13 Thread Kieran Bingham
Hi Laurent, On 13/03/2019 00:05, Laurent Pinchart wrote: > Extend the vsp1_du_atomic_flush() API with writeback support by adding > format, pitch and memory addresses of the writeback framebuffer. > Writeback completion is reported through the existing frame completion > callback with a new

Re: [PATCH v6 10/18] media: vsp1: drm: Extend frame completion API to the DU driver

2019-03-13 Thread Kieran Bingham
_INTERNAL)] Or are you relying on the fact that, VSP1_DL_FRAME_END_COMPLETED == VSP1_DU_STATUS_COMPLETE in which case perhaps we should be more explicit somehow, either in code or with a comment that this section is converting between the two bitfield types. However you resolve, the rest lo

Re: [PATCH v6 09/18] media: vsp1: drm: Split RPF format setting to separate function

2019-03-13 Thread Kieran Bingham
format_info *fmtinfo; > + unsigned int chroma_hsub; > + > + fmtinfo = vsp1_get_format_info(vsp1, pixelformat); > + if (!fmtinfo) { > + dev_dbg(vsp1->dev, "Unsupported pixel format %08x for RPF\n", Isn't this now a RWPF ? Other than th

Re: [PATCH v6 07/18] media: vsp1: dl: Allow chained display lists for display pipelines

2019-03-13 Thread Kieran Bingham
s display pipelines can go into the code path which sets the vsp1_dl_list *next. The rest of the refactoring looks good too. Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_dl.c | 35 ++- > 1 file changed, 23 insertions(+), 12 deletions(-) >

Re: [PATCH v6 08/18] media: vsp1: wpf: Add writeback support

2019-03-13 Thread Kieran Bingham
through it while I argue with myself, but I think I reached an agreement with me in the end :) Reviewed-by: Kieran Bingham > Signed-off-by: Laurent Pinchart > --- > drivers/media/platform/vsp1/vsp1_rwpf.h | 2 + > drivers/media/platform/vsp1/vsp1_wpf.c | 73 ++-

Re: [PATCH v6 06/18] media: vsp1: Add vsp1_dl_list argument to .configure_stream() operation

2019-03-13 Thread Kieran Bingham
ving the null-checks out - because as you state above - the only time this variable is used, it will not be NULL, and it is documented as such in the code. So, Reviewed-by: Kieran Bingham > > Signed-off-by: Laurent Pinchart > --- > drivers/media/platform/vsp1/vsp1_brx.c| 1 + >

Re: [PATCH v5 15/19] drm/msm: Remove prototypes for non-existing functions

2019-03-13 Thread Kieran Bingham
move their prototypes. I have confirmed there are no implementations of these prototypes in drm-next tree. Reviewed-by: Kieran Bingham >> >> Signed-off-by: Laurent Pinchart >> --- >> drivers/gpu/drm/msm/msm_drv.h | 2 -- >> 1 file changed, 2 deletions(-) >> &g

Re: [PATCH v5 16/19] drm: rcar-du: Fix rcar_du_crtc structure documentation

2019-03-12 Thread Kieran Bingham
Hi Laurent, On 12/03/2019 15:24, Laurent Pinchart wrote: > Hi Kieran, > > On Mon, Mar 11, 2019 at 10:57:15PM +0000, Kieran Bingham wrote: >> On 21/02/2019 10:32, Laurent Pinchart wrote: >>> The rcar_du_crtc structure index field contains the CRTC hardware index, >>&

Re: [PATCH v2] gpu: drm: atomic_helper: Fix spelling errors

2019-03-12 Thread Kieran Bingham
Hi Ville, On 12/03/2019 15:14, Ville Syrjälä wrote: > On Tue, Mar 12, 2019 at 12:33:07AM +0000, Kieran Bingham wrote: >> Trivial fixes identified while working on the DRM code. >> >> s/artifically/artificially/ >> s/achive/achieve/ >> >> Signed-

[PATCH v2] gpu: drm: atomic_helper: Fix spelling errors

2019-03-11 Thread Kieran Bingham
Trivial fixes identified while working on the DRM code. s/artifically/artificially/ s/achive/achieve/ Signed-off-by: Kieran Bingham --- v2: - Actually spell achieve correctly! drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v5 17/19] drm: rcar-du: Store V4L2 fourcc in rcar_du_format_info structure

2019-03-11 Thread Kieran Bingham
sn't some core framework conversion helpers that do these mappings (presumably in both directions). But even if we had one of those, having a table entry here is a fast conversion. Reviewed-by: Kieran Bingham > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/

Re: [PATCH v5 16/19] drm: rcar-du: Fix rcar_du_crtc structure documentation

2019-03-11 Thread Kieran Bingham
1cc7f8e91 ("drm: rcar-du: Split CRTC handling to support hardware indexing") Either way, Reviewed-by: Kieran Bingham > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] gpu: drm: atomic_helper: Fix spelling errors

2019-03-11 Thread Kieran Bingham
Hi Ville, On 11/03/2019 16:00, Ville Syrjälä wrote: > On Mon, Mar 11, 2019 at 03:36:39PM +0000, Kieran Bingham wrote: >> Trivial fixes identified while working on the DRM code. >> >> s/artifically/artificially/ >> s/achive/acheive/ > > achieve? Good poi

[PATCH] gpu: drm: atomic_helper: Fix spelling errors

2019-03-11 Thread Kieran Bingham
Trivial fixes identified while working on the DRM code. s/artifically/artificially/ s/achive/acheive/ Signed-off-by: Kieran Bingham --- drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers

Re: [PATCH] drm: rcar-du: Support panels connected directly to the DPAD outputs

2019-03-06 Thread Kieran Bingham
eate panel bridge instances. > > Signed-off-by: Laurent Pinchart Except for some minor wording on the comment, which I'll let you handle, Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 54 --- > 1 file changed, 48 insertions(+), 6

Re: [PATCH v5 07/19] media: vsp1: dl: Support one-shot entries in the display list

2019-02-21 Thread Kieran Bingham
be > used to implement writeback support that will need to enable writeback > for the duration of a single frame. > > Signed-off-by: Laurent Pinchart Thanks for adding the documentation, and the new name _oneshot() sounds fine to me. Reviewed-by: Kieran Bingham > --- > drivers/me

Re: [PATCH v5 01/19] Revert "[media] v4l: vsp1: Supply frames to the DU continuously"

2019-02-21 Thread Kieran Bingham
Hi Laurent, On 21/02/2019 10:31, Laurent Pinchart wrote: > From: Kieran Bingham > > This reverts commit 3299ba5c0b21 ("[media] v4l: vsp1: Supply frames to > the DU continuously") > > The DU output mode does not rely on frames being supplied on the WPF as > it

Re: [PATCH v4 6/7] media: vsp1: Replace the display list internal flag with a flags field

2019-02-17 Thread Kieran Bingham
Hi Laurent, On 17/02/2019 02:48, Laurent Pinchart wrote: > To prepare for addition of more flags to the display list, replace the > 'internal' flag field by a bitmask 'flags' field. > > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/media/platf

Re: [PATCH v4 5/7] media: vsp1: Refactor vsp1_video_complete_buffer() for later reuse

2019-02-17 Thread Kieran Bingham
plete_buffer() to vsp1_video_complete_next_buffer(). > > Signed-off-by: Laurent Pinchart This looks good to me - except perhaps the documentation /might/ need some refresh. With or without updates there, the code changes look good to me: Reviewed-by: Kieran Bingham > --- > dri

Re: [PATCH v4 4/7] media: vsp1: Fix addresses of display-related registers for VSP-DL

2019-02-17 Thread Kieran Bingham
ne used both LIF's :) (which I'm sure happens) > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_drm.c | 4 ++-- > drivers/media/platform/vsp1/vsp1_regs.h | 6 +++--- > drivers/media/platform/vsp1/vsp1_wpf.c | 2 +- >

Re: [PATCH v4 3/7] media: vsp1: Replace leftover occurrence of fragment with body

2019-02-17 Thread Kieran Bingham
, but got in /after/ they were removed or something. > Signed-off-by: Laurent Pinchart Regardless, it looks correct to fix this up. Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_dl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/

Re: [PATCH v4 2/7] media: vsp1: wpf: Fix partition configuration for display pipelines

2019-02-17 Thread Kieran Bingham
ute than allocating a table for a single partition (which is what I had locally). > Signed-off-by: Laurent Pinchart I like that this change also simplifies the flip/rotate handling code to make that easier to read. Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_wpf.c | 1

Re: [PATCH v4 7/7] media: vsp1: Provide a writeback video device

2019-02-17 Thread Kieran Bingham
Hi Laurent, On 17/02/2019 20:06, Kieran Bingham wrote: > Hi Laurent, > > Thank you for updating the patch, > > On 17/02/2019 02:48, Laurent Pinchart wrote: >> From: Kieran Bingham >> >> When the VSP1 is used in an active display pipeline, the output of the

Re: [PATCH v4 7/7] media: vsp1: Provide a writeback video device

2019-02-17 Thread Kieran Bingham
Hi Laurent, Thank you for updating the patch, On 17/02/2019 02:48, Laurent Pinchart wrote: > From: Kieran Bingham > > When the VSP1 is used in an active display pipeline, the output of the > WPF can supply the LIF entity directly and simultaneously write to > memor

Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit

2019-02-13 Thread Kieran Bingham
Hi Brendan, On 12/02/2019 22:10, Brendan Higgins wrote: > On Mon, Feb 11, 2019 at 4:16 AM Kieran Bingham > wrote: >> >> Hi Brendan, >> >> On 09/02/2019 00:56, Brendan Higgins wrote: >>> On Thu, Dec 6, 2018 at 4:16 AM Kieran Bingham >>> wrote: >

Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit

2019-02-11 Thread Kieran Bingham
Hi Brendan, On 09/02/2019 00:56, Brendan Higgins wrote: > On Thu, Dec 6, 2018 at 4:16 AM Kieran Bingham > wrote: >> >> Hi Brendan, >> >> On 03/12/2018 23:53, Brendan Higgins wrote: >>> On Thu, Nov 29, 2018 at 7:45 PM Luis Chamberlain wrote: >>>

Re: [PATCH 1/3 v2] drm: rcar-du: add missing of_node_put

2019-01-14 Thread Kieran Bingham
n != of_fwnode_handle(e) > ( > return e; > | > *return ...; > ) > // > > Signed-off-by: Julia Lawall Thankyou for the update. Reviewed-by: Kieran Bingham > > --- > v2: Add the second of_node_put(entity);, as suggested by Kieran Bingham. > > drivers/gpu/drm/rcar-du/rcar_du

Re: [PATCH 1/3] drm: rcar-du: add missing of_node_put

2019-01-14 Thread Kieran Bingham
> @r exists@ > local idexpression e; > expression x; > @@ > e = of_graph_get_remote_port_parent(...); > ... when != x = e > when != true e == NULL > when != of_node_put(e) > when != of_fwnode_handle(e) > ( > return e; > | > *return ...; > )

Re: [PATCH] drm: rcar-du: Remove inclusion of drmP.h

2018-12-29 Thread Kieran Bingham
st of the necessary headers, so the change is simple. > > While at it, remove unneeder inclusion of other headers, and unneeded s/uneeder/unneeded/ > forward declarations of structures. > But otherwise: Reviewed-by: Kieran Bingham > Signed-off-by: Laurent Pinchart > --- >

Re: [PATCH -next] drm/shmob: Fix return value check in shmob_drm_probe

2018-12-17 Thread Kieran Bingham
> probe/remove time") > Signed-off-by: YueHaibing Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > b/drivers

Re: [PATCH] drm: rcar-du: Convert live DT patches to sugar syntax

2018-12-13 Thread Kieran Bingham
t Uytterhoeven >> --- >> The generated dtbs before/after are identical. > > I was going to ask whether you had tested the patch, but this should be good > enough :-) > > The result is nicer to read, thanks. > I agree! FWIW: Reviewed-by: Kieran Bingham > R

Re: [PATCH v2] drm: rcar-du: dw-hdmi: Reject modes with a too high clock frequency

2018-12-11 Thread Kieran Bingham
igned-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 15 +++ > 1 file changed, 15 insertions(+) > > Changes since v1: > > - Add a comment to explain where the limit comes from > > diff --git a/drivers/gpu/drm

Re: [PATCH 3/5] drm: rcar-du: Disable unused DPAD outputs

2018-12-07 Thread Kieran Bingham
t; signals at the output of any DU channel not routed to a DPAD output. > This doesn't affect the DU output signals going to other outputs. > > Signed-off-by: Laurent Pinchart Only spelling and bikeshedding here - so: Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du

Re: [PATCH 2/5] drm: rcar-du: Move CRTC outputs bitmask to private CRTC state

2018-12-07 Thread Kieran Bingham
s a fairly tough read - but aside from one comment near the bottom regarding initialising dpad0 which I'm sure you can handle correctly, and another comment which I think we could improve things outside of this patch: Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c

Re: [PATCH 1/5] drm: rcar-du: Replace EXT_CTRL_REGS feature flag with generation check

2018-12-07 Thread Kieran Bingham
eneration and use > generation checks to replace the feature flag. Looks like a good simplification > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 14 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 7 ++

Re: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel

2018-12-07 Thread Kieran Bingham
Hi Matthew, On 06/12/2018 15:37, Matthew Wilcox wrote: > On Thu, Dec 06, 2018 at 12:32:47PM +0000, Kieran Bingham wrote: >> On 04/12/2018 20:47, Luis Chamberlain wrote: >>> On Mon, Dec 03, 2018 at 03:48:15PM -0800, Brendan Higgins wrote: >>>> On Thu, Nov 29,

Re: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel

2018-12-06 Thread Kieran Bingham
Hi Luis, On 04/12/2018 20:47, Luis Chamberlain wrote: > On Mon, Dec 03, 2018 at 03:48:15PM -0800, Brendan Higgins wrote: >> On Thu, Nov 29, 2018 at 5:54 AM Kieran Bingham >> wrote: >>> >>> Hi Brendan, >>> >>> Thanks again for this series!

Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit

2018-12-06 Thread Kieran Bingham
Hi Brendan, On 03/12/2018 23:53, Brendan Higgins wrote: > On Thu, Nov 29, 2018 at 7:45 PM Luis Chamberlain wrote: >> >> On Thu, Nov 29, 2018 at 01:56:37PM +, Kieran Bingham wrote: >>> Hi Brendan, >>> >>> Please excuse the top posting, but I'm repl

Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit

2018-11-29 Thread Kieran Bingham
Hi Brendan, Please excuse the top posting, but I'm replying here as I'm following the section "Creating a kunitconfig" in Documentation/kunit/start.rst. Could the three line kunitconfig file live under say arch/um/configs/kunit_defconfig? So that it's always provided? And could even be

Re: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel

2018-11-29 Thread Kieran Bingham
Hi Brendan, Thanks again for this series! On 28/11/2018 19:36, Brendan Higgins wrote: > The ultimate goal is to create minimal isolated test binaries; in the > meantime we are using UML to provide the infrastructure to run tests, so > define an abstract way to configure and run tests that allow

Re: [PATCH] drm: rcar-du: dw-hdmi: Reject modes with a too high clock frequency

2018-11-23 Thread Kieran Bingham
Hi Laurent, On 23/11/2018 14:47, Laurent Pinchart wrote: > Hi Kieran, > > On Friday, 23 November 2018 16:43:28 EET Kieran Bingham wrote: >> On 23/11/2018 14:34, Laurent Pinchart wrote: >>> Implement a .mode_valid() handler in the R-Car glue layer to reject >>>

Re: [PATCH] drm: rcar-du: dw-hdmi: Reject modes with a too high clock frequency

2018-11-23 Thread Kieran Bingham
Hi Laurent, Thank you for the patch, On 23/11/2018 14:34, Laurent Pinchart wrote: > Implement a .mode_valid() handler in the R-Car glue layer to reject > modes with an unsupported clock frequency. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_dw_hdmi.c | 11

Re: [PATCH] drm: rcar-du: Fix DU3 start/stop on M3-N

2018-11-23 Thread Kieran Bingham
d-off-by: Laurent Pinchart Second in the series of 'ouch's :-D Well I'm afraid I can't see any simpler way to work around this. And instantiating a CRTC object at dev->crtcs to cover the non-existent DU is overkill (and would incorrectly re-index the CRTCs) So, Acked-by: Kieran Bingham

Re: [PATCH v2] drm: rcar-du: Reject modes that fail CRTC timing requirements

2018-11-21 Thread Kieran Bingham
f 3 lines. Reject > modes that fail those requirements. > > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > Changes since v1: > > - Don't use mode->crtc_v* as they are only set after calling .mode_valid() > - Tested the patch on real hardware (whic

Re: [PATCH 2/2] drm: rcar-du: Enable alpha property on primary planes

2018-11-21 Thread Kieran Bingham
Hi Laurent, On 21/11/2018 18:29, Laurent Pinchart wrote: > Hi Kieran, > > On Thursday, 20 September 2018 14:22:38 EET Laurent Pinchart wrote: >> On Wednesday, 19 September 2018 18:56:59 EEST Kieran Bingham wrote: >>> If the alpha property is not added to a plane, a defaul

Re: [PATCH 2/2] drm/atomic: Create and use __drm_atomic_helper_crtc_reset() everywhere

2018-11-21 Thread Kieran Bingham
t; Cc: Philipp Zabel > Cc: CK Hu > Cc: Matthias Brugger > Cc: Rob Clark > Cc: Ben Skeggs > Cc: Tomi Valkeinen > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: Sandy Huang > Cc: "Heiko Stübner" > Cc: Thierry Reding > Cc: Jonathan Hunter

Re: [PATCH] drm: rcar-du: Fix external clock error checks

2018-11-06 Thread Kieran Bingham
y: Laurent Pinchart This looks good to me: Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > b/drivers/gpu/drm/rca

Re: [PATCH 3/3] arm64: dts: renesas: r8a77965: Add LVDS support

2018-10-18 Thread Kieran Bingham
Hi Laurent, On 18/10/18 01:41, Laurent Pinchart wrote: > The M3-N (r8a77965) platform has oneLVDS encoder connected to the DU. s/oneLVDS/one LVDS/ > Add the corresponding DT node and wire it up. > > Signed-off-by: Laurent Pinchart With the title fixed, Reviewed-by: Ki

Re: [PATCH 2/3] drm: rcar-du: lvds: Add R8A77965 support

2018-10-18 Thread Kieran Bingham
off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c > b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index 173d7ad0b991..534a128a869d 100644 > --

Re: [PATCH 1/3] dt-bindings: display: renesas: lvds: Document r8a77965 bindings

2018-10-18 Thread Kieran Bingham
Hi Laurent, On 18/10/18 01:41, Laurent Pinchart wrote: > The M3-N (r8a77965) includes one LVDS encoder. Extend the binding to > support it. > > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > .../devicetree/bindings/display/bridge/renesas,lvds.txt

Re: [PATCH] drm: rcar-du: Fix vblank initialization

2018-10-18 Thread Kieran Bingham
rly fatal - just some wasted memory perhaps. > Fixes: 4bf8e1962f91 ("drm: Renesas R-Car Display Unit DRM driver") > Reported-by: Tomi Valkeinen > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- > 1 fil

  1   2   3   4   >