Re: [PATCH v4 23/27] arm64: dts: qcom: starqltechn: add display PMIC

2024-09-19 Thread Krzysztof Kozlowski
On 19/09/2024 15:17, Dzmitry Sankouski wrote: >>> + pmic@60 { >>> + compatible = "samsung,s2dos05"; >>> + reg = <0x60>; >>> + >>> + regulators { >>> + s2dos05_ldo1: ldo1 { >>> +

Re: [PATCH v4 08/27] mfd: max77693: remove unused declarations

2024-09-19 Thread Krzysztof Kozlowski
On 19/09/2024 10:40, Dzmitry Sankouski wrote: > чт, 19 сент. 2024 г. в 10:00, Krzysztof Kozlowski : >> >> On 18/09/2024 14:53, Dzmitry Sankouski wrote: >>> пн, 16 сент. 2024 г. в 12:10, Krzysztof Kozlowski : >>>> >>>> On Fri, Sep 13, 2024 at 06:07:5

Re: [PATCH v4 08/27] mfd: max77693: remove unused declarations

2024-09-19 Thread Krzysztof Kozlowski
On 18/09/2024 14:53, Dzmitry Sankouski wrote: > пн, 16 сент. 2024 г. в 12:10, Krzysztof Kozlowski : >> >> On Fri, Sep 13, 2024 at 06:07:51PM +0300, Dzmitry Sankouski wrote: >>> Remove `enum max77693_irq_source` declaration because unused. >>> >

Re: [PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

2024-09-18 Thread Krzysztof Kozlowski
On 18/09/2024 05:08, manikanda...@microchip.com wrote: > Hi Krzysztof, > > On 17/09/24 4:07 pm, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 17/09/2024 11:53, Manikandan Mura

Re: [PATCH 1/2] dt-bindings: display: panel-simple: Document support for Microchip AC69T88A

2024-09-17 Thread Krzysztof Kozlowski
On 17/09/2024 11:53, Manikandan Muralidharan wrote: > Add Microchip AC69T88A 5" LVDS interface (800x480) TFT LCD panel > compatible string > > Signed-off-by: Manikandan Muralidharan > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH v2 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-16 Thread Krzysztof Kozlowski
On 17/09/2024 01:26, Konrad Dybcio wrote: > On 16.09.2024 10:33 PM, Dmitry Baryshkov wrote: >> On Mon, Sep 16, 2024 at 05:23:55PM GMT, Krzysztof Kozlowski wrote: >>> On Fri, Sep 13, 2024 at 04:07:51PM +0530, Soutrik Mukhopadhyay wrote: >>>> Add compatible strin

Re: [PATCH v4 04/27] dt-bindings: panel: add Samsung s6e3ha8

2024-09-16 Thread Krzysztof Kozlowski
On Fri, Sep 13, 2024 at 06:07:47PM +0300, Dzmitry Sankouski wrote: > Add binding for the Samsung s6e3ha8 panel found in the Samsung S9. > > Signed-off-by: Dzmitry Sankouski > > --- > Changes in v4: > - change dts example intendation from tabs > to spaces > - remove reset-gpios description > ---

Re: [PATCH v2 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-16 Thread Krzysztof Kozlowski
On Fri, Sep 13, 2024 at 04:07:51PM +0530, Soutrik Mukhopadhyay wrote: > Add compatible string for the supported eDP PHY on sa8775p platform. > > Signed-off-by: Soutrik Mukhopadhyay > --- > v2: No change > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p

2024-09-16 Thread Krzysztof Kozlowski
.yaml | 1 + Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 15/27] regulator: add s2dos05 regulator support

2024-09-16 Thread Krzysztof Kozlowski
On Fri, Sep 13, 2024 at 06:07:58PM +0300, Dzmitry Sankouski wrote: > S2dos05 has 1 buck and 4 LDO regulators, used for powering > panel/touchscreen. > > Signed-off-by: Dzmitry Sankouski > ... > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include

Re: [PATCH v4 22/27] arm64: dts: qcom: starqltechn: add max77705 PMIC

2024-09-16 Thread Krzysztof Kozlowski
On Fri, Sep 13, 2024 at 06:08:05PM +0300, Dzmitry Sankouski wrote: > Add support for max77705 MFD device. Supported sub-devices: > charger, fuelgauge, haptic, led > > Signed-off-by: Dzmitry Sankouski > --- > .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 103 > + > 1

Re: [PATCH v4 23/27] arm64: dts: qcom: starqltechn: add display PMIC

2024-09-16 Thread Krzysztof Kozlowski
On Fri, Sep 13, 2024 at 06:08:06PM +0300, Dzmitry Sankouski wrote: > Add support for s2dos05 display / touchscreen PMIC > > Signed-off-by: Dzmitry Sankouski > --- > .../boot/dts/qcom/sdm845-samsung-starqltechn.dts | 77 > ++ > 1 file changed, 77 insertions(+) > > diff --g

Re: [PATCH v4 06/27] dt-bindings: mfd: add samsung,s2dos05

2024-09-16 Thread Krzysztof Kozlowski
On Fri, Sep 13, 2024 at 06:07:49PM +0300, Dzmitry Sankouski wrote: > Add samsung,s2dos05 MFD module binding. > > Signed-off-by: Dzmitry Sankouski > > --- > Changes in v4: > - split long(>80) lines > - fix indentation > - merge with regulators binding > - drop pmic suffix > - drop unused labels i

Re: [PATCH v4 08/27] mfd: max77693: remove unused declarations

2024-09-16 Thread Krzysztof Kozlowski
plit your patchset per subsystems. There is no dependency on MFD bits from your DTS... (if there is, this needs to be fixed anyway) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 14/27] mfd: sec-core: add s2dos05 support

2024-09-16 Thread Krzysztof Kozlowski
rivers/mfd/sec-core.c | 11 +++ > include/linux/mfd/samsung/core.h | 1 + > 2 files changed, 12 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1] drm/exynos: gsc: Fix typo in comment

2024-09-09 Thread Krzysztof Kozlowski
On 09/09/2024 10:06, Shen Lichuan wrote: > Replace 'initailization' with 'initialization' in the comment. > > Signed-off-by: Shen Lichuan > --- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_gs

Re: [PATCH v5 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-08 Thread Krzysztof Kozlowski
s (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH 5/5] drm/bridge: ti-dlpc3433: constify regmap_config

2024-09-08 Thread Krzysztof Kozlowski
Mark local static 'struct regmap_config' as const for safer and more obvious code. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/bridge/ti-dlpc3433.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-dlpc3433.c b/drivers/gpu/drm

[PATCH 4/5] drm/mediatek: dp: constify regmap_config

2024-09-08 Thread Krzysztof Kozlowski
Mark local static 'struct regmap_config' as const for safer and more obvious code. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/mediatek/mtk_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediate

[PATCH 3/5] drm/fsl-dcu: constify regmap_config

2024-09-08 Thread Krzysztof Kozlowski
Mark local static 'struct regmap_config' as const for safer and more obvious code. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c b/drivers/gpu/d

[PATCH 2/5] drm/meson: constify regmap_config

2024-09-08 Thread Krzysztof Kozlowski
Mark local static 'struct regmap_config' as const for safer and more obvious code. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/meson/meson_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/m

[PATCH 1/5] drm/meson: drop unused staitc dw_hdmi_dwc_write_bits

2024-09-08 Thread Krzysztof Kozlowski
static inline dw_hdmi_dwc_write_bits() function is not used at all: drivers/gpu/drm/meson/meson_dw_hdmi.c:276:20: error: unused function 'dw_hdmi_dwc_write_bits' [-Werror,-Wunused-function] Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 14 ---

[PATCH 0/5] drm: misc: few simple cleanups

2024-09-08 Thread Krzysztof Kozlowski
No dependencies, trivial patches. Best regards, Krzysztof --- Krzysztof Kozlowski (5): drm/meson: drop unused staitc dw_hdmi_dwc_write_bits drm/meson: constify regmap_config drm/fsl-dcu: constify regmap_config drm/mediatek: dp: constify regmap_config drm/bridge: ti

Re: [PATCH v6 2/3] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-09-06 Thread Krzysztof Kozlowski
w-hdmi-qp.yaml ... > + > + power-domains: > +maxItems: 1 > + > + resets: > +minItems: 2 You can drop minItems. > +maxItems: 2 > + > + reset-names: > +items: > + - const: ref > + - const: hdp Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v6 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-09-05 Thread Krzysztof Kozlowski
On 05/09/2024 22:27, Alex Lanzano wrote: > On Thu, Sep 05, 2024 at 03:23:20PM GMT, Krzysztof Kozlowski wrote: >> On 05/09/2024 14:43, Alex Lanzano wrote: >>> Add device tree bindings for the monochrome Sharp Memory LCD >>> >>> Co-developed-by: Mehdi D

Re: [PATCH v6 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-09-05 Thread Krzysztof Kozlowski
On 05/09/2024 14:43, Alex Lanzano wrote: > Add device tree bindings for the monochrome Sharp Memory LCD > > Co-developed-by: Mehdi Djait > Signed-off-by: Mehdi Djait > Signed-off-by: Alex Lanzano I don't understand what happened here. Your process of handling patches is odd. Tags do not disapp

Re: [PATCH v2 09/11] dt-bindings: display: vop2: Add rk3576 support

2024-09-04 Thread Krzysztof Kozlowski
On 04/09/2024 14:02, Andy Yan wrote: > From: Andy Yan > > Add vop found on rk3576. > > Signed-off-by: Andy Yan > > --- > > Changes in v2: > - Add dt bindings > > .../devicetree/bindings/display/rockchip/rockchip-vop2.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/Doc

Re: [PATCH] dt-bindings: lcdif: Document the dmas/dma-names properties

2024-09-03 Thread Krzysztof Kozlowski
interrupts: > items: >- description: LCDIF DMA interrupt > @@ -156,6 +164,17 @@ allOf: > interrupts: >maxItems: 1 > > + - if: > + not: > +properties: > + compatible: > +contains: > + enum

Re: [PATCH v1 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-03 Thread Krzysztof Kozlowski
On Mon, Sep 02, 2024 at 08:55:02PM +0800, Jianeng Ceng wrote: > MT8186 ponyta, known as huaqin custom lable, is a > MT8186 based laptop. It is based on the "corsola" design. > It includes LTE, touchpad combinations. > > Signed-off-by: Jianeng Ceng > --- > arch/arm64/boot/dts/mediatek/Makefile

Re: [PATCH v2 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

2024-09-03 Thread Krzysztof Kozlowski
On Tue, Sep 03, 2024 at 02:16:01PM +0800, Jianeng Ceng wrote: > This is v2 of the MT8186 Chromebook device tree series. > Where is the changelog? Why do you send the same patch as v2? Best regards, Krzysztof

Re: [PATCH v2 2/2] arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks

2024-09-03 Thread Krzysztof Kozlowski
On Tue, Sep 03, 2024 at 02:16:03PM +0800, Jianeng Ceng wrote: > MT8186 ponyta, known as huaqin custom lable, is a > MT8186 based laptop. It is based on the "corsola" design. > It includes LTE, touchpad combinations. > > Signed-off-by: Jianeng Ceng > --- > arch/arm64/boot/dts/mediatek/Makefile

Re: [PATCH v2 1/2] dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook

2024-09-02 Thread Krzysztof Kozlowski
On Tue, Sep 03, 2024 at 02:16:02PM +0800, Jianeng Ceng wrote: > Add an entry for the MT8186 based Ponyta Chromebook (custom lable). > > Signed-off-by: Jianeng Ceng > --- > Documentation/devicetree/bindings/arm/mediatek.yaml | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/D

Re: [PATCH] docs: devicetree: Fix typo in lvds.yaml

2024-09-02 Thread Krzysztof Kozlowski
On Sun, Sep 01, 2024 at 09:30:46PM +0800, Yu-Chun Lin wrote: > Corrected the spelling in the description of LVDS Display Common > Properties. > > Signed-off-by: Yu-Chun Lin > --- > Documentation/devicetree/bindings/display/lvds.yaml | 2 +- Replacing one typo in one place is a churn. Fix several

Re: [PATCH v5 1/4] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP

2024-09-01 Thread Krzysztof Kozlowski
On 31/08/2024 15:58, Heiko Stübner wrote: > > so I guess the fifth interrupt is meant to be the hotplug? > Though I guess this should be specificed in the name-list too. > > From the SoC's manual it looks like the controller is set up from > different modules. > Like AVP is the audio-video-packet

Re: [PATCH v5? 5/6] dt-bindings: display: rockchip: Add schema for RK3588 DW HDMI QP TX machine

2024-08-31 Thread Krzysztof Kozlowski
On 30/08/2024 17:28, Shimrra Shai wrote: > diff --git > a/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml > > b/Documentation/devicetree/bindings/display/rockchip/rockchip,rk3588-dw-hdmi-qp.yaml > new file mode 100644 > index 0..e71544ced > --- /dev/nul

Re: [PATCH v5? 4/6] dt-bindings: soc: rockchip: Document VO0/1 GRF compatible string changes

2024-08-31 Thread Krzysztof Kozlowski
On 30/08/2024 17:28, Shimrra Shai wrote: > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > index 78c6d5b64..8fd539125 100644 > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > +++ b/Documentation/devi

Re: [PATCH v5? 3/6] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP

2024-08-31 Thread Krzysztof Kozlowski
On 30/08/2024 17:28, Shimrra Shai wrote: > diff --git > a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi-qp.yaml > b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi-qp.yaml > new file mode 100644 > index 0..141899ba2 What is this? Where is proper mess

Re: [PATCH v5 1/4] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP

2024-08-30 Thread Krzysztof Kozlowski
On Sat, Aug 31, 2024 at 12:55:29AM +0300, Cristian Ciocaltea wrote: > Add dt-binding schema containing the common properties for the Synopsys > DesignWare HDMI QP TX controller. > > Note this is not a full dt-binding specification, but is meant to be > referenced by platform-specific bindings for

Re: [PATCH v5 3/4] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-30 Thread Krzysztof Kozlowski
On Sat, Aug 31, 2024 at 12:55:31AM +0300, Cristian Ciocaltea wrote: > Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 > Quad-Pixel (QP) TX controller IP. > > Since this is a new IP block, quite different from those used in the > previous generations of Rockchip SoCs, add a dedicate

Re: [RFC PATCH 3/4] dt-bindings: reserved-memory: add linaro,restricted-heap

2024-08-30 Thread Krzysztof Kozlowski
On Fri, Aug 30, 2024 at 09:03:50AM +0200, Jens Wiklander wrote: > From: Olivier Masse > > DMABUF reserved memory definition for OP-TEE secure data path feature. > > Signed-off-by: Olivier Masse > Signed-off-by: Jens Wiklander > --- > .../linaro,restricted-heap.yaml | 56

Re: [PATCH 1/2] dt-bindings: display: renesas,du: narrow interrupts and resets per variants

2024-08-28 Thread Krzysztof Kozlowski
On 28/08/2024 14:45, Laurent Pinchart wrote: > Hi Krzysztof, > > On Sun, Aug 18, 2024 at 08:48:54PM +0200, Krzysztof Kozlowski wrote: >> On 18/08/2024 19:51, Laurent Pinchart wrote: >>> On Sun, Aug 18, 2024 at 07:44:22PM +0200, Krzysztof Kozlowski wrote: >>>> O

Re: [PATCH v3] dt-bindings: display: st,stm32-ltdc: Document stm32mp25 compatible

2024-08-27 Thread Krzysztof Kozlowski
On 27/08/2024 16:04, Yannick Fertre wrote: > Add "st,stm32mp25-ltdc" compatible for SOC MP25. This new SOC introduce > new clocks (bus, ref & lvds). Bus clock was separated from lcd clock. > New sources are possible for lcd clock (lvds / ref). > > Signed-off-by: Yannick Fertre > --- > > Changes

Re: [PATCH v3 3/4] dt-bindings: display: ti,am65x-dss: Add OLDI properties for AM625 DSS

2024-08-26 Thread Krzysztof Kozlowski
On 26/08/2024 09:32, Aradhya Bhatia wrote: > Hi Krzysztof, > > > On 7/21/24 21:09, Krzysztof Kozlowski wrote: >> On 16/07/2024 10:42, Aradhya Bhatia wrote: >>> The DSS in AM625 SoC has 2 OLDI TXes. Refer the OLDI schema to add the >>> support for the OLDI TXe

Re: [PATCH v3 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

2024-08-26 Thread Krzysztof Kozlowski
On 26/08/2024 07:47, Aradhya Bhatia wrote: > Hi Krzysztof, > > Thank you for the reviewing the patches. > > > On 7/21/24 21:06, Krzysztof Kozlowski wrote: >> On 16/07/2024 10:42, Aradhya Bhatia wrote: >>> The OLDI (transmitters) TXes do not have registers of th

Re: [PATCH v3 1/9] of: property: add of_graph_get_next_port()

2024-08-25 Thread Krzysztof Kozlowski
On Mon, Aug 26, 2024 at 02:43:23AM +, Kuninori Morimoto wrote: > We have endpoint base functions > - of_graph_get_next_device_endpoint() > - of_graph_get_device_endpoint_count() > - for_each_of_graph_device_endpoint() > + if (!prev) { > + /* > + *

[PATCH] dt-bindings: MAINTAINERS: drop stale exynos file pattern

2024-08-25 Thread Krzysztof Kozlowski
Documentation/devicetree/bindings/display/exynos/ Fixes: ad6d17e10306 ("dt-bindings: display: samsung,exynos5-dp: convert to DT Schema") Signed-off-by: Krzysztof Kozlowski --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 028186bb4

Re: [PATCH v2 10/12] dt-bindings: spi: Add rockchip,rk3576-spi compatible

2024-08-24 Thread Krzysztof Kozlowski
ing. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 09/12] dt-bindings: watchdog: Add rockchip,rk3576-wdt compatible

2024-08-24 Thread Krzysztof Kozlowski
On Fri, Aug 23, 2024 at 10:52:36AM -0400, Detlev Casanova wrote: > It is compatible with the other rockchip SoCs. > > Signed-off-by: Detlev Casanova Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 08/12] dt-bindings: gpu: Add rockchip,rk3576-mali compatible

2024-08-24 Thread Krzysztof Kozlowski
; > Signed-off-by: Detlev Casanova > --- > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 1 + Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 07/12] dt-bindings: mmc: Add support for rk3576 eMMC

2024-08-24 Thread Krzysztof Kozlowski
It grows too much with such if:then: and that's not the most important part of binding we need to see first. With above change: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 04/12] dt-bindings: iio: adc: Add rockchip,rk3576-saradc string

2024-08-23 Thread Krzysztof Kozlowski
On Fri, Aug 23, 2024 at 10:52:31AM -0400, Detlev Casanova wrote: > Add rockchip,rk3576-saradc compatible string. > The saradc on RK3576 is compatible with the one on RK3588, so they are > used together in an arm of the oneOf. > > Signed-off-by: Detlev Casanova > Reviewed-by: K

Re: [PATCH v3 1/3] dt-bindings: display: mediatek: dpi: Add power domains

2024-08-22 Thread Krzysztof Kozlowski
-by: Rohit Agarwal > --- > .../bindings/display/mediatek/mediatek,dpi.yaml | 17 + Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/3] dt-bindings: display: mediatek: dpi: Add power domains

2024-08-21 Thread Krzysztof Kozlowski
On 21/08/2024 12:00, Rohit Agarwal wrote: >>> +then: >>> + properties: >>> +power-domains: >>> + maxItems: 1 >> This part can be dropped. Just disallow it for other devices. > I was a bit confused here. > > Can we add something like this? > if: >   not: >    (mt6795

Re: [PATCH v2 1/3] dt-bindings: display: mediatek: dpi: Add power domains

2024-08-21 Thread Krzysztof Kozlowski
On 21/08/2024 11:26, Rohit Agarwal wrote: > Add power domain binding to the mediatek DPI controller > for MT8186. > Also, add power domain binding for other SoCs like > MT6795 and MT8173 that already had power domain property. > > Signed-off-by: Rohit Agarwal > --- > .../display/mediatek/mediate

Re: [PATCH 1/3] dt-bindings: display: mediatek: dpi: Add power domains

2024-08-20 Thread Krzysztof Kozlowski
On 20/08/2024 14:18, Rohit Agarwal wrote: > > On 20/08/24 4:40 PM, Krzysztof Kozlowski wrote: >> On Tue, Aug 20, 2024 at 08:06:57AM +, Rohit Agarwal wrote: >>> Add power domain binding to the mediatek DPI controller. >> Why? Who needs it? Why all devices suddenly

Re: [PATCH 1/3] dt-bindings: display: mediatek: dpi: Add power domains

2024-08-20 Thread Krzysztof Kozlowski
On Tue, Aug 20, 2024 at 08:06:57AM +, Rohit Agarwal wrote: > Add power domain binding to the mediatek DPI controller. Why? Who needs it? Why all devices suddenly have it (IOW, why is it not constrained anyhow per variant)? > > Signed-off-by: Rohit Agarwal > --- > .../devicetree/bindings/di

Re: [PATCH v2 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

2024-08-19 Thread Krzysztof Kozlowski
On Mon, Aug 19, 2024 at 09:20:37AM +, Hui-Ping Chen wrote: > Nuvoton MA35 SoCs NAND Flash Interface Controller > supports 2KB, 4KB and 8KB page size, and up to 8-bit, > 12-bit, and 24-bit hardware ECC calculation circuit > to protect data communication. > > Signed-off-by: Hui-Ping Chen ... >

Re: [PATCH v2 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings

2024-08-19 Thread Krzysztof Kozlowski
; create mode 100644 > Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: display: renesas,du: narrow interrupts and resets per variants

2024-08-18 Thread Krzysztof Kozlowski
On 18/08/2024 19:51, Laurent Pinchart wrote: > On Sun, Aug 18, 2024 at 07:44:22PM +0200, Krzysztof Kozlowski wrote: >> On 18/08/2024 19:41, Laurent Pinchart wrote: >>> Hi Krzysztof, >>> >>> Thank you for the patch. >>> >>> On Sun, Aug 1

Re: [PATCH 1/2] dt-bindings: display: renesas,du: narrow interrupts and resets per variants

2024-08-18 Thread Krzysztof Kozlowski
On 18/08/2024 19:41, Laurent Pinchart wrote: > Hi Krzysztof, > > Thank you for the patch. > > On Sun, Aug 18, 2024 at 07:30:02PM +0200, Krzysztof Kozlowski wrote: >> Each variable-length property like interrupts or resets must have fixed >> constraints on number of

[PATCH 2/2] dt-bindings: display: renesas, du: add top-level constraints

2024-08-18 Thread Krzysztof Kozlowski
sas,cmms and renesas,vsps. Signed-off-by: Krzysztof Kozlowski --- .../bindings/display/renesas,du.yaml | 26 --- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/dis

[PATCH 1/2] dt-bindings: display: renesas, du: narrow interrupts and resets per variants

2024-08-18 Thread Krzysztof Kozlowski
Each variable-length property like interrupts or resets must have fixed constraints on number of items for given variant in binding. The clauses in "if:then:" block should define both limits: upper and lower. Signed-off-by: Krzysztof Kozlowski --- .../bindings/display/renes

Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label

2024-08-16 Thread Krzysztof Kozlowski
ts: qcom: sa8775p: add ADSP, CDSP and GPDSP > nodes") > Reported-by: Ekansh Gupta > Signed-off-by: Bartosz Golaszewski Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: misc: qcom, fastrpc: document new domain ID

2024-08-16 Thread Krzysztof Kozlowski
On 16/08/2024 12:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. > > Signed-off-by: Bartosz Golaszewski > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: misc: qcom, fastrpc: document new domain ID

2024-08-16 Thread Krzysztof Kozlowski
On 16/08/2024 14:29, Bartosz Golaszewski wrote: > On Fri, Aug 16, 2024 at 1:21 PM Krzysztof Kozlowski wrote: >> >> On 16/08/2024 12:23, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> Add "cdsp1" as the new supported label

Re: [PATCH v3 RESEND 2/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2024-08-16 Thread Krzysztof Kozlowski
On 16/08/2024 11:44, Liu Ying wrote: > On 08/16/2024, Krzysztof Kozlowski wrote: >> On 16/08/2024 10:09, Liu Ying wrote: >>> NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which >>> configures parallel display format by using the "PARALLEL_DISP_FOR

Re: [PATCH 1/2] dt-bindings: misc: qcom, fastrpc: document new domain ID

2024-08-16 Thread Krzysztof Kozlowski
On 16/08/2024 12:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. > > Signed-off-by: Bartosz Golaszewski > --- > Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH 1/2] dt-bindings: display: panel-simple: Add On Tat Industrial Company KD50G21-40NT-A1

2024-08-16 Thread Krzysztof Kozlowski
./devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 RESEND 2/2] drm/bridge: imx: Add i.MX93 parallel display format configuration support

2024-08-16 Thread Krzysztof Kozlowski
On 16/08/2024 10:09, Liu Ying wrote: > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > field. Add a DRM bridge driver to support the display format configuration. > > Signed-off-by: Liu Ying > --- ...

Re: [PATCH 2/3] dt-bindings: ili9881c: Add JMO LCM-JM800WX LCD panel

2024-08-14 Thread Krzysztof Kozlowski
On 14/08/2024 15:10, Esben Haabendal wrote: > Document the compatible value for LCM-JM800WX LCD panels from JMO Tech. > > Signed-off-by: Esben Haabendal > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add JMO Tech

2024-08-14 Thread Krzysztof Kozlowski
On 14/08/2024 17:26, Krzysztof Kozlowski wrote: > On 14/08/2024 16:43, Esben Haabendal wrote: >> Krzysztof Kozlowski writes: >> >>> On 14/08/2024 15:10, Esben Haabendal wrote: >>>> Add vendor prefix for JMO Tech CO., LTD. (http://www.jmolcd.com/). >

Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add JMO Tech

2024-08-14 Thread Krzysztof Kozlowski
On 14/08/2024 16:43, Esben Haabendal wrote: > Krzysztof Kozlowski writes: > >> On 14/08/2024 15:10, Esben Haabendal wrote: >>> Add vendor prefix for JMO Tech CO., LTD. (http://www.jmolcd.com/). >>> >>> Signed-off-by: Esben Haabendal >>> -

Re: [PATCH 1/3] dt-bindings: vendor-prefixes: Add JMO Tech

2024-08-14 Thread Krzysztof Kozlowski
On 14/08/2024 15:10, Esben Haabendal wrote: > Add vendor prefix for JMO Tech CO., LTD. (http://www.jmolcd.com/). > > Signed-off-by: Esben Haabendal > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/

Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties

2024-08-13 Thread Krzysztof Kozlowski
properties in panel-common.yaml, which is not expected. >> Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough? > > Strange, you ref to panel-common.yaml, suppose it will use all common > preperties. > > Krzysztof Kozlowski: > >

Re: [PATCH 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

2024-08-12 Thread Krzysztof Kozlowski
On 12/08/2024 11:10, Hui-Ping Chen wrote: >>> + >>> +/* NAND-type Flash BCH Error Data Registers */ >>> +#define MA35_NFI_REG_NANDECCED0(0x960) >>> +#define MA35_NFI_REG_NANDECCED1(0x964) >>> +#define MA35_NFI_REG_NANDECCED2(0x968) >>> +#define MA35_NFI_REG_NANDECCED3(0x96C) >>> +#d

Re: [PATCH 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings

2024-08-12 Thread Krzysztof Kozlowski
On 12/08/2024 11:02, Hui-Ping Chen wrote: > > >>> + >>> + nand-ecc-step-size: >>> +enum: [512, 1024] >> No defaults? So is this required? > > This is required, but I will also add a default. If this is required and should be in required: list. Default does not make sense then... it

Re: [PATCH 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

2024-08-11 Thread Krzysztof Kozlowski
On 12/08/2024 05:00, Hui-Ping Chen wrote: > Nuvoton MA35 SoCs NAND Flash Interface Controller > supports 2KB, 4KB and 8KB page size, and up to 8-bit, > 12-bit, and 24-bit hardware ECC calculation circuit > to protect data communication. > > Signed-off-by: Hui-Ping Chen > --- > drivers/mtd/nand/r

Re: [PATCH 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings

2024-08-11 Thread Krzysztof Kozlowski
On 12/08/2024 05:00, Hui-Ping Chen wrote: > Add dt-bindings for the Nuvoton MA35 SoC NAND Controller. > > Signed-off-by: Hui-Ping Chen > --- > .../bindings/mtd/nuvoton,ma35d1-nand.yaml | 97 +++ > 1 file changed, 97 insertions(+) > create mode 100644 > Documentation/devicet

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Krzysztof Kozlowski
On 09/08/2024 10:35, Joonas Lahtinen wrote: > Quoting Krzysztof Kozlowski (2024-08-08 21:44:39) >> On 08/08/2024 20:35, Krzysztof Kozlowski wrote: >>> On 08/08/2024 10:45, Tvrtko Ursulin wrote: >>>> >>>> Hi Dave, Sima, >>>

Re: [PULL] drm-intel-fixes

2024-08-09 Thread Krzysztof Kozlowski
On 09/08/2024 09:13, Dave Airlie wrote: > Hi Krzysztof, > > You might want to familiarise yourself with the drm tree development > procedures before weighing in, > and snarky comments like the final one are not appreciated on this > list or in this community. > > The drm next trees are never reba

Re: [PULL] drm-intel-fixes

2024-08-08 Thread Krzysztof Kozlowski
On 08/08/2024 20:35, Krzysztof Kozlowski wrote: > On 08/08/2024 10:45, Tvrtko Ursulin wrote: >> >> Hi Dave, Sima, >> >> A small bunch of fixes for the weekly cycle: > > ... > >> >>

Re: [PULL] drm-intel-fixes

2024-08-08 Thread Krzysztof Kozlowski
On 08/08/2024 10:45, Tvrtko Ursulin wrote: > > Hi Dave, Sima, > > A small bunch of fixes for the weekly cycle: ... > > > Andi Shyti (2): > drm/i915/gem: Adjust vma offset for framebuffer mmap offset > drm/i915/gem: Fi

Re: [PATCH v4 1/6] dt-bindings: misc: qcom, fastrpc: increase the max number of iommus

2024-08-05 Thread Krzysztof Kozlowski
On 05/08/2024 19:08, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The fastrpc components on the SA8775P SoC can require up to 10 IOMMU > entries. Bump the maxItems. > > Signed-off-by: Bartosz Golaszewski Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 11/11] arm64: defconfig: build CONFIG_REGULATOR_QCOM_REFGEN as module

2024-08-04 Thread Krzysztof Kozlowski
On 04/08/2024 07:40, Dmitry Baryshkov wrote: > Enable CONFIG_REGULATOR_QCOM_REFGEN and build it as a module. It is an > internal supply used by the DSI on SM8350-based platforms (e.g. on the > SM8350 HDK device). > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Krzysztof K

Re: [PATCH 07/11] dt-bindings: interconnect: qcom,sm8450: drop DISP nodes

2024-08-04 Thread Krzysztof Kozlowski
hese indices, drop them for now. > > Signed-off-by: Dmitry Baryshkov Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 06/11] dt-bindings: interconnect: qcom,sm8350: drop DISP nodes

2024-08-04 Thread Krzysztof Kozlowski
hese indices, drop them for now. > > Signed-off-by: Dmitry Baryshkov Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/2] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP

2024-08-01 Thread Krzysztof Kozlowski
On 01/08/2024 11:29, Cristian Ciocaltea wrote: >>> + interrupts: >>> +minItems: 4 >>> +maxItems: 5 >>> +items: >>> + - description: AVP Unit interrupt >>> + - description: CEC interrupt >>> + - description: eARC RX interrupt >>> + - description: Main Unit interrupt

Re: [PATCH v2 2/3] drm/rockchip: Explicitly include bits header

2024-08-01 Thread Krzysztof Kozlowski
On 01/08/2024 04:25, Cristian Ciocaltea wrote: > Driver makes use of the BIT() macro, but relies on the bits header being > implicitly included. > > Explicitly pull the header in to avoid potential build failures in some > configurations. > > While at it, reorder include directives alphabetically

Re: [PATCH v2 1/3] dt-bindings: display: rockchip: Add schema for RK3588 HDMI TX Controller

2024-08-01 Thread Krzysztof Kozlowski
On 01/08/2024 11:50, Cristian Ciocaltea wrote: > On 8/1/24 6:37 AM, Rob Herring (Arm) wrote: >> >> On Thu, 01 Aug 2024 05:25:52 +0300, Cristian Ciocaltea wrote: >>> Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 >>> Quad-Pixel (QP) TX controller IP. >>> >>> Since this is a new IP b

Re: [PATCH 1/2] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP

2024-08-01 Thread Krzysztof Kozlowski
On 01/08/2024 11:29, Cristian Ciocaltea wrote: > On 8/1/24 11:38 AM, Krzysztof Kozlowski wrote:> On 01/08/2024 04:05, Cristian > Ciocaltea wrote: >>> Add dt-binding schema containing the common properties for the Synopsys >>> DesignWare HDMI QP TX controller. >>

Re: [PATCH 2/2] drm/bridge: synopsys: Add DW HDMI QP TX Controller driver

2024-08-01 Thread Krzysztof Kozlowski
On 01/08/2024 11:43, Cristian Ciocaltea wrote: > On 8/1/24 11:50 AM, Krzysztof Kozlowski wrote: >> On 01/08/2024 04:05, Cristian Ciocaltea wrote: >>> The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX Controller supports >>> the following features, among others: &

Re: [PATCH 2/2] drm/bridge: synopsys: Add DW HDMI QP TX Controller driver

2024-08-01 Thread Krzysztof Kozlowski
On 01/08/2024 04:05, Cristian Ciocaltea wrote: > The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX Controller supports > the following features, among others: ... > + > +void dw_hdmi_qp_unbind(struct dw_hdmi_qp *hdmi) > +{ > +} > +EXPORT_SYMBOL_GPL(dw_hdmi_qp_unbind); This looks like quite use

Re: [PATCH 1/2] dt-bindings: display: bridge: Add schema for Synopsys DW HDMI QP TX IP

2024-08-01 Thread Krzysztof Kozlowski
On 01/08/2024 04:05, Cristian Ciocaltea wrote: > Add dt-binding schema containing the common properties for the Synopsys > DesignWare HDMI QP TX controller. > > Note this is not a full dt-binding specification, but is meant to be > referenced by platform-specific bindings for this IP core. Please

Re: [PATCH v2 07/16] drm/imx: Add i.MX8qxp Display Controller pixel engine

2024-07-30 Thread Krzysztof Kozlowski
On 30/07/2024 11:42, Liu Ying wrote: > On 07/30/2024, Krzysztof Kozlowski wrote: >> On 30/07/2024 08:55, Liu Ying wrote: >>> On 07/28/2024, Dmitry Baryshkov wrote: >>>> On Fri, Jul 12, 2024 at 05:32:34PM GMT, Liu Ying wrote: >>>>> i.MX8qxp Display Contr

Re: [PATCH v2 07/16] drm/imx: Add i.MX8qxp Display Controller pixel engine

2024-07-30 Thread Krzysztof Kozlowski
On 30/07/2024 08:55, Liu Ying wrote: > On 07/28/2024, Dmitry Baryshkov wrote: >> On Fri, Jul 12, 2024 at 05:32:34PM GMT, Liu Ying wrote: >>> i.MX8qxp Display Controller pixel engine consists of all processing >>> units that operate in the AXI bus clock domain. Add drivers for >>> ConstFrame, ExtDs

Re: [PATCH 1/4] dt-bindings: display/msm/gmu: Add SDM670 compatible

2024-07-29 Thread Krzysztof Kozlowski
On 30/07/2024 03:38, Richard Acayan wrote: > The Snapdragon 670 has a GMU. Add its compatible. > > Signed-off-by: Richard Acayan Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-29 Thread Krzysztof Kozlowski
On 29/07/2024 14:05, Alex Lanzano wrote: >> Under which circumstances would you become interested to apply a statement >> like “guard(mutex)(&smd->tx_mutex);”? >> https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/mutex.h#L196 >> > > Ah, I didn't realize guarded mutexes were implemented

Re: [PATCH v3 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-28 Thread Krzysztof Kozlowski
On 29/07/2024 03:42, Alex Lanzano wrote: > Add device tree bindings for the monochrome Sharp Memory LCD > > Co-developed-by: Mehdi Djait > Signed-off-by: Mehdi Djait > Signed-off-by: Alex Lanzano Reviewed-by: Krzysztof Kozlowski --- This is an automated instruction, just i

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-28 Thread Krzysztof Kozlowski
On 28/07/2024 14:56, Alex Lanzano wrote: > + > + spi-cs-high: true You can drop it. >>> >>> This is a required property in order for the display to function correctly. >>> But I have no issues removing it if there's a better place to document it. >> >> The sharp LCD device o

Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

2024-07-28 Thread Krzysztof Kozlowski
On 27/07/2024 18:30, Alex Lanzano wrote: > On Thu, Jul 25, 2024 at 08:17:01AM GMT, Krzysztof Kozlowski wrote: >> On 25/07/2024 02:47, Alex Lanzano wrote: >>> + >>> +properties: >>> + compatible: >>> +enum: >>> + - sharp,ls010b7

  1   2   3   4   5   6   7   8   9   10   >