Re: [PATCH] staging: ion: remove from the tree

, just drop the in-kernel copy of the ion code now, as it's not used, and is only causing problems for everyone involved. Cc: "Arve Hjønnevåg" Cc: "Christian König" Cc: Christian Brauner Cc: Christoph Hellwig Cc: Hridya Valsaraju Cc: Joel Fernandes Cc: John Stultz Cc: Laura

Re: [PATCH 04/15] staging/android/ion: delete dma_buf->kmap/unmap implemenation

ion. Signed-off-by: Daniel Vetter Cc: Laura Abbott Cc: Sumit Semwal Cc: de...@driverdev.osuosl.org Cc: linaro-mm-...@lists.linaro.org --- drivers/staging/android/ion/ion.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/andr

Re: [RESEND][PATCH v8 0/5] DMA-BUF Heaps (destaging ION)

by using shorter argument names (suggested by Christoph) * Remove unused private_flags value * Add forgotten include file to fix build issue on x86 * Checkpatch whitespace fixups Thoughts and feedback would be greatly appreciated! thanks -john Cc: Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal

Re: [PATCH] ion_system_heap: support X86 archtecture

On 9/29/19 3:28 AM, jun.zh...@intel.com wrote: From: zhang jun we see tons of warning like: [ 45.846872] x86/PAT: NDK MediaCodec_:3753 map pfn RAM range req write-combining for [mem 0x1e7a8-0x1e7a87fff], got write-back [ 45.848827] x86/PAT: .vorbis.decoder:4088 map pfn RAM range req

Re: Limits for ION Memory Allocator

On 7/17/19 12:31 PM, Alexander Popov wrote: Hello! The syzkaller [1] has a trouble with fuzzing the Linux kernel with ION Memory Allocator. Syzkaller uses several methods [2] to limit memory consumption of the userspace processes calling the syscalls for testing the kernel: - setrlimit(),

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

On 7/24/19 2:59 AM, Christoph Hellwig wrote: On Mon, Jul 22, 2019 at 10:04:06PM -0700, John Stultz wrote: Apologies, I'm not sure I'm understanding your suggestion here. dma_alloc_contiguous() does have some interesting optimizations (avoiding allocating single page from cma), though its focus

Re: [PATCH] staging: android: ion: Remove unused rbtree for ion_buffer

*/ struct ion_device { struct miscdevice dev; - struct rb_root buffers; - struct mutex buffer_lock; struct rw_semaphore lock; struct plist_head heaps; struct dentry *debug_root; Acked-by: Laura Abbott

Re: [PATCH 2/2] staging: android: ion: Remove file ion_chunk_heap.c

On 7/3/19 4:18 AM, Nishka Dasgupta wrote: Remove file ion_chunk_heap.c as its functions and definitions are not used anywhere else. Issue found with Coccinelle. Acked-by: Laura Abbott Signed-off-by: Nishka Dasgupta --- drivers/staging/android/ion/Kconfig | 9 -- drivers

Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

he point where nobody wants the carveout and chunk heaps so I'd actually be okay with removing those files. Just to be explicit: Acked-by: Laura Abbott Thanks, Laura ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v6 0/5] DMA-BUF Heaps (destaging ION)

not be applicable but given this is not the first time I've seen Ion used as a DoS mechanism, it would be good to think about putting in some basic checks. Thanks, Laura Thoughts and feedback would be greatly appreciated! thanks -john Cc: Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal Cc: Liam

Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

On 3/29/19 7:26 PM, Zengtao (B) wrote: Hi laura: -Original Message- From: Laura Abbott [mailto:labb...@redhat.com] Sent: Friday, March 29, 2019 9:27 PM To: Zengtao (B) ; sumit.sem...@linaro.org Cc: Greg Kroah-Hartman ; Arve Hjønnevåg ; Todd Kjos ; Martijn Coenen ; Joel Fernandes

Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

On 3/29/19 11:40 AM, Zeng Tao wrote: There are two reasons for this patch: 1. There are some potential requirements for ion_alloc in kernel space, some media drivers need to allocate media buffers from ion instead of buddy or dma framework, this is more convient and clean very for media drivers.

Re: [PATCH] driver : staging : ion: optimization for decreasing memory fragmentaion

On 3/20/19 7:23 AM, Vlastimil Babka wrote: You should have CC'd the ION maintainers/lists per ./scripts/get_maintainer.pl - CCing now. On 3/14/19 12:06 PM, Zhaoyang Huang wrote: From: Zhaoyang Huang Two action for this patch: 1. set a batch size for system heap's shrinker, which can have it

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

On 3/15/19 2:29 PM, John Stultz wrote: On Fri, Mar 15, 2019 at 1:18 PM Laura Abbott wrote: On 3/5/19 12:54 PM, John Stultz wrote: +DMA-BUF HEAPS FRAMEWORK +M: Laura Abbott +R: Liam Mark +R: Brian Starkey +R: "Andrew F. Davis" +R: John Stultz +S: Maintained +L:

Re: [RFC][PATCH 5/5 v2] kselftests: Add dma-heap test

On 3/15/19 1:13 PM, John Stultz wrote: On Fri, Mar 15, 2019 at 1:07 PM Laura Abbott wrote: On 3/6/19 9:01 AM, John Stultz wrote: On Wed, Mar 6, 2019 at 8:14 AM Benjamin Gaignard wrote: Le mar. 5 mars 2019 à 21:54, John Stultz a écrit : + + printf("Allocating 1 MEG\n"); +

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

as useful (would love to get some help from actual carveout/chunk users)! That said, the main user-interface is shaping up and I wanted to get some input on the device model (particularly from GreKH) and any other API/ABI specific input. thanks -john Cc: Laura Abbott Cc: Benjamin Gaignard Cc: Greg

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

On 3/5/19 12:54 PM, John Stultz wrote: +DMA-BUF HEAPS FRAMEWORK +M: Laura Abbott +R: Liam Mark +R: Brian Starkey +R: "Andrew F. Davis" +R: John Stultz +S: Maintained +L: linux-me...@vger.kernel.org +L: dri-devel@lists.freedesktop.org +L:

Re: [RFC][PATCH 5/5 v2] kselftests: Add dma-heap test

On 3/6/19 9:01 AM, John Stultz wrote: On Wed, Mar 6, 2019 at 8:14 AM Benjamin Gaignard wrote: Le mar. 5 mars 2019 à 21:54, John Stultz a écrit : + + printf("Allocating 1 MEG\n"); + ret = dmabuf_heap_alloc(heap_fd, ONE_MEG, 0, _fd); + if (ret) + goto out; + +

Re: [PATCH v2] drm/vgem: fix use-after-free when drm_gem_handle_create() fails

using fault injection. Fix it by skipping the second free. Reported-by: syzbot+e73f2fb5ed5a5df36...@syzkaller.appspotmail.com Fixes: af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces") Reviewed-by: Chris Wilson Cc: Laura Abbott Cc: Daniel Vetter Cc: sta...@vger.kernel.org Signed-of

Re: [EARLY RFC][PATCH] dma-buf: Add dma-buf heaps framework

On 2/25/19 6:36 AM, Andrew F. Davis wrote: This framework allows a unified userspace interface for dma-buf exporters, allowing userland to allocate specific types of memory for use in dma-buf sharing. Each heap is given its own device node, which a user can allocate a dma-buf fd from using the

Re: [EARLY RFC][PATCH 0/4] dmabuf pools infrastructure (destaging ION)

On 2/22/19 9:24 AM, John Stultz wrote: On Fri, Feb 22, 2019 at 8:55 AM Andrew F. Davis wrote: On 2/21/19 1:40 AM, John Stultz wrote: Here is a very early peek at my dmabuf pools patchset, which tries to destage a fair chunk of ION functionality. This build and boots, but I've not gotten to

Re: [EARLY RFC][PATCH 0/4] ION per heap devices

On 2/19/19 1:30 PM, Andrew F. Davis wrote: On 2/19/19 3:25 PM, Laura Abbott wrote: On 2/15/19 12:24 PM, John Stultz wrote: This is a *very early RFC* (it builds, that's all I'll say :) but I wanted to share it to get some initial feedback before I go down the rabit hole of trying to adapt

Re: [EARLY RFC][PATCH 3/4] ion: Add HEAP_INFO ioctl to be able to fetch heap type

On 2/19/19 1:39 PM, Andrew F. Davis wrote: On 2/19/19 3:13 PM, Laura Abbott wrote: On 2/15/19 12:24 PM, John Stultz wrote: The per-device heaps don't support HEAP_QUERY ioctl, since the name is provided in the devnode path and the heapid isn't useful with the new interface (one uses the fd

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

On 1/24/19 8:44 AM, Brian Starkey wrote: On Thu, Jan 24, 2019 at 10:04:46AM -0600, Andrew F. Davis wrote: On 1/23/19 11:11 AM, Brian Starkey wrote: [snip] I'm very new to all this, so any pointers to history in this area are appreciated. [snip] In case you didn't come across it

Re: [EARLY RFC][PATCH 0/4] ION per heap devices

the per-heap devices for ION. The main benefit is that it avoids multiplexing heap operations through the /dev/ion interface, and allows for each heap to have its own permissions/sepolicy rules. Feedback would be greatly appreciated! thanks -john Cc: Laura Abbott Cc: Sumit Semwal Cc: Liam Mark

Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags

(i = 0; i < NUM_ORDERS; i++) { struct ion_page_pool *pool; + gfp_t gfp_flags = low_order_gfp_flags; if (orders[i] > 4) gfp_flags = high_order_gfp_flags; Acked-by: Laura Abbott ___ dri-devel

Re: [EARLY RFC][PATCH 2/4] ion: Initial hack to create per heap devices

g. Every CMA region getting exposed was a side effect of doing the eneumeration without tying it to devicetree or other firmware. I'm not opposed to limiting the heaps exposed if we can find a good way to do so that's still compliant with devicetree/whatever. Thanks, Laura Cc: Laura Abbott Cc: S

Re: [EARLY RFC][PATCH 3/4] ion: Add HEAP_INFO ioctl to be able to fetch heap type

it as part of the ABI? Cc: Laura Abbott Cc: Sumit Semwal Cc: Liam Mark Cc: Brian Starkey Cc: Andrew F. Davis Cc: Alistair Strachan Cc: dri-devel@lists.freedesktop.org Signed-off-by: John Stultz --- drivers/staging/android/ion/ion-ioctl.c | 12 drivers/staging/android/uapi/ion.h

Re: [EARLY RFC][PATCH 0/4] ION per heap devices

On 2/19/19 9:21 AM, John Stultz wrote: On Mon, Feb 18, 2019 at 3:51 AM Brian Starkey wrote: On Fri, Feb 15, 2019 at 12:24:08PM -0800, John Stultz wrote: This is a *very early RFC* (it builds, that's all I'll say :) but I wanted to share it to get some initial feedback before I go down the

Re: [EARLY RFC][PATCH 1/4] ion: Add ION_VERSION ioctl

On 2/15/19 12:24 PM, John Stultz wrote: With all the slight interface changes ion has had through its time in staging, keeping userland working properly has been a pain. Assuming more churn going forward, provide a proper version interface. Cc: Laura Abbott Cc: Sumit Semwal Cc: Liam Mark Cc

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

On 2/15/19 11:01 AM, John Stultz wrote: On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey wrote: Hi John, On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: [snip] Some thoughts, as this ABI break has the potential to be pretty painful. 1) Unfortunately, this ABI is exposed

Re: [PATCH] staging: android: ion: Use low_order_gfp_flags for smaller allocations

On 2/11/19 11:09 PM, Jing Xia wrote: gfp_flags is always set high_order_gfp_flags even if allocations of order 0 are made.But for smaller allocations, the system should be able to reclaim some memory. Signed-off-by: Jing Xia Reviewed-by: Yuming Han Reviewed-by: Zhaoyang Huang Reviewed-by:

Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

On 1/19/19 2:25 AM, Christoph Hellwig wrote: On Fri, Jan 18, 2019 at 10:37:46AM -0800, Liam Mark wrote: Add support for configuring dma mapping attributes when mapping and unmapping memory through dma_buf_map_attachment and dma_buf_unmap_attachment. Signed-off-by: Liam Mark And who is going

Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

On 1/18/19 1:32 PM, Liam Mark wrote: On Fri, 18 Jan 2019, Laura Abbott wrote: On 1/18/19 10:37 AM, Liam Mark wrote: Add support for configuring dma mapping attributes when mapping and unmapping memory through dma_buf_map_attachment and dma_buf_unmap_attachment. Signed-off-by: Liam Mark

Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

On 1/18/19 10:37 AM, Liam Mark wrote: Add support for configuring dma mapping attributes when mapping and unmapping memory through dma_buf_map_attachment and dma_buf_unmap_attachment. Signed-off-by: Liam Mark --- include/linux/dma-buf.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

On 1/18/19 12:43 PM, Andrew F. Davis wrote: On 1/18/19 2:31 PM, Laura Abbott wrote: On 1/17/19 8:13 AM, Andrew F. Davis wrote: On 1/16/19 4:48 PM, Liam Mark wrote: On Wed, 16 Jan 2019, Andrew F. Davis wrote: On 1/15/19 1:05 PM, Laura Abbott wrote: On 1/15/19 10:38 AM, Andrew F. Davis wrote

Re: [PATCH 1/4] staging: android: ion: Support cpu access during dma_buf_detach

ment->priv; struct ion_buffer *buffer = dmabuf->priv; - free_duped_table(a->table); mutex_lock(>lock); list_del(>list); mutex_unlock(>lock); + free_duped_table(a->table); kfree(a); } Acked-by: Laura Abbott __

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

On 1/17/19 8:13 AM, Andrew F. Davis wrote: On 1/16/19 4:48 PM, Liam Mark wrote: On Wed, 16 Jan 2019, Andrew F. Davis wrote: On 1/15/19 1:05 PM, Laura Abbott wrote: On 1/15/19 10:38 AM, Andrew F. Davis wrote: On 1/15/19 11:45 AM, Liam Mark wrote: On Tue, 15 Jan 2019, Andrew F. Davis wrote

Re: [PATCH 00/14] Misc ION cleanups and adding unmapped heap

On 1/16/19 8:05 AM, Andrew F. Davis wrote: On 1/15/19 12:58 PM, Laura Abbott wrote: On 1/15/19 9:47 AM, Andrew F. Davis wrote: On 1/14/19 8:39 PM, Laura Abbott wrote: On 1/11/19 10:05 AM, Andrew F. Davis wrote: Hello all, This is a set of (hopefully) non-controversial cleanups for the ION

Re: [PATCH 12/14] staging: android: ion: Declare helpers for carveout and chunk heaps

On 1/18/19 1:59 AM, Greg Kroah-Hartman wrote: On Fri, Jan 11, 2019 at 12:05:21PM -0600, Andrew F. Davis wrote: When enabled the helpers functions for creating carveout and chunk heaps should have declarations in the ION header. Why? No one calls these from what I can tell. Which makes me

Re: [PATCH 11/14] staging: android: ion: Allow heap name to be null

On 1/16/19 9:12 AM, Andrew F. Davis wrote: On 1/16/19 9:28 AM, Brian Starkey wrote: Hi Andrew, On Fri, Jan 11, 2019 at 12:05:20PM -0600, Andrew F. Davis wrote: The heap name can be used for debugging but otherwise does not seem to be required and no other part of the code will fail if left

Re: [PATCH 14/14] staging: android: ion: Add UNMAPPED heap type and helper

On 1/15/19 10:43 AM, Laura Abbott wrote: On 1/15/19 7:58 AM, Andrew F. Davis wrote: On 1/14/19 8:32 PM, Laura Abbott wrote: On 1/11/19 10:05 AM, Andrew F. Davis wrote: The "unmapped" heap is very similar to the carveout heap except the backing memory is presumed to be unmappable b

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

On 1/15/19 10:38 AM, Andrew F. Davis wrote: On 1/15/19 11:45 AM, Liam Mark wrote: On Tue, 15 Jan 2019, Andrew F. Davis wrote: On 1/14/19 11:13 AM, Liam Mark wrote: On Fri, 11 Jan 2019, Andrew F. Davis wrote: Buffers may not be mapped from the CPU so skip cache maintenance here. Accesses

Re: [PATCH 00/14] Misc ION cleanups and adding unmapped heap

On 1/15/19 9:47 AM, Andrew F. Davis wrote: On 1/14/19 8:39 PM, Laura Abbott wrote: On 1/11/19 10:05 AM, Andrew F. Davis wrote: Hello all, This is a set of (hopefully) non-controversial cleanups for the ION framework and current set of heaps. These were found as I start to familiarize myself

Re: [PATCH 14/14] staging: android: ion: Add UNMAPPED heap type and helper

On 1/15/19 7:58 AM, Andrew F. Davis wrote: On 1/14/19 8:32 PM, Laura Abbott wrote: On 1/11/19 10:05 AM, Andrew F. Davis wrote: The "unmapped" heap is very similar to the carveout heap except the backing memory is presumed to be unmappable by the host, in my specific case due to

Re: [PATCH 00/14] Misc ION cleanups and adding unmapped heap

On 1/11/19 10:05 AM, Andrew F. Davis wrote: Hello all, This is a set of (hopefully) non-controversial cleanups for the ION framework and current set of heaps. These were found as I start to familiarize myself with the framework to help in whatever way I can in getting all this up to the

Re: [PATCH 14/14] staging: android: ion: Add UNMAPPED heap type and helper

On 1/11/19 10:05 AM, Andrew F. Davis wrote: The "unmapped" heap is very similar to the carveout heap except the backing memory is presumed to be unmappable by the host, in my specific case due to firewalls. This memory can still be allocated from and used by devices that do have access to the

Re: [PATCH] staging: android: ion: add buffer flag update ioctl

On 1/3/19 5:42 PM, Zengtao (B) wrote: -Original Message- From: Laura Abbott [mailto:labb...@redhat.com] Sent: Thursday, January 03, 2019 6:31 AM To: Zengtao (B) ; sumit.sem...@linaro.org Cc: Greg Kroah-Hartman ; Arve Hjønnevåg ; Todd Kjos ; Martijn Coenen ; Joel Fernandes ; de

Re: [PATCH] staging: android: ion: move map_kernel to ion_dma_buf_kmap

On 12/24/18 12:19 AM, Qing Xia wrote: Now, as Google's user guide, if userspace need clean ION buffer's cache, they should call ioctl(fd, DMA_BUF_IOCTL_SYNC, sync). Then we found that ion_dma_buf_begin_cpu_access/ion_dma_buf_end_cpu_access will do ION buffer's map_kernel, it's not necessary. And

Re: [PATCH] staging: android: ion: add buffer flag update ioctl

On 12/23/18 6:47 PM, Zengtao (B) wrote: Hi laura: -Original Message- From: Laura Abbott [mailto:labb...@redhat.com] Sent: Friday, December 21, 2018 4:50 AM To: Zengtao (B) ; sumit.sem...@linaro.org Cc: Greg Kroah-Hartman ; Arve Hjønnevåg ; Todd Kjos ; Martijn Coenen ; Joel Fernandes

Re: [PATCH] staging: android: ion: add buffer flag update ioctl

On 12/19/18 5:39 PM, Zengtao (B) wrote: Hi laura: -Original Message- From: Laura Abbott [mailto:labb...@redhat.com] Sent: Thursday, December 20, 2018 2:10 AM To: Zengtao (B) ; sumit.sem...@linaro.org Cc: Greg Kroah-Hartman ; Arve Hjønnevåg ; Todd Kjos ; Martijn Coenen ; Joel Fernandes

Re: [PATCH] staging: android: ion: add buffer flag update ioctl

On 12/19/18 9:19 AM, Zeng Tao wrote: In some usecases, the buffer cached attribute is not determined at allocation time, it's determined just before the real cpu mapping. And from the memory view of point, a buffer should not have the cached attribute util is really mapped by the cpu. So in this

Re: [PATCH] staging: android: ion: Remove unused header files

On 11/30/18 6:43 AM, Yangtao Li wrote: seq_file.h does not need to be included,so remove it. Acked-by: Laura Abbott Signed-off-by: Yangtao Li --- drivers/staging/android/ion/ion.c | 1 - drivers/staging/android/ion/ion_system_heap.c | 1 - 2 files changed, 2 deletions

Re: [PATCH] staging: ion: Rework ion_map_dma_buf() to minimize re-mapping

On 10/17/2018 07:53 PM, John Stultz wrote: On Fri, Oct 12, 2018 at 10:51 AM, Laura Abbott wrote: I suspect most of the cost of the dma_map/dma_unmap is from the cache flushing and not the actual mapping operations. If this is the case, another option might be to figure out how to incorporate

Re: [PATCH] staging: ion: Rework ion_map_dma_buf() to minimize re-mapping

m Mark Cc: Laura Abbott Cc: Sumit Semwal Cc: Greg Kroah-Hartman Cc: Todd Kjos Cc: Martijn Coenen Cc: dri-devel@lists.freedesktop.org Signed-off-by: John Stultz --- drivers/staging/android/ion/ion.c | 36 +++- 1 file changed, 31 insertions(+), 5 deletions(-)

Re: [PATCH] android:ion: the order and count are in the wrong position

On 09/07/2018 08:20 AM, jun qian wrote: The value in the wrong position will cause misunderstanding, when the debug infomations display in the window. I think the existing order is okay, it's just not separated well. It's "$count pages of order $order". I also just acked a patch to remove all

[PATCH] staging: android: ion: Return an ERR_PTR in ion_map_kernel

-by: Laura Abbott --- drivers/staging/android/ion/ion_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_heap.c b/drivers/staging/android/ion/ion_heap.c index 772dad65396e..f32c12439eee 100644 --- a/drivers/staging/android/ion/ion_heap.c +++ b

Re: [PATCH 1/2] staging: android: ion: Fix license identifier comment format

On 05/07/2018 07:40 AM, Nathan Chancellor wrote: On Mon, May 07, 2018 at 06:37:52AM -0700, Laura Abbott wrote: On 05/06/2018 06:18 PM, Nathan Chancellor wrote: checkpatch.pl complains these are invalid because the rules in Documentation/process/license-rules.rst state that C headers should

Re: [PATCH 2/2] staging: android: ion: Remove unnecessary blank line

tachments); mutex_init(>lock); mutex_lock(>buffer_lock); Acked-by: Laura Abbott <labb...@redhat.com> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] staging: android: ion: Fix license identifier comment format

On 05/06/2018 06:18 PM, Nathan Chancellor wrote: checkpatch.pl complains these are invalid because the rules in Documentation/process/license-rules.rst state that C headers should have "/* */" style comments. The SPDX markings are special, but I don't see anything from a quick read of the

[PATCHv3] drm/amdkfd: Remove vla

m> Signed-off-by: Laura Abbott <labb...@redhat.com> --- v3: Introduced a #define for the max value, switched to pr_err_once to avoid log flood, switched to sizeof(array) per private suggestion. --- drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 8 +--- drivers/gpu/drm/amd/amdkfd/kfd_pri

[PATCHv2] drm/i2c: tda998x: Remove VLA usage

to this upper bound. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Laura Abbott <labb...@redhat.com> --- v2: Switch to make the buffer size more transparent and add a bounds check. --- drivers/gpu/drm/i2c/tda998x_drv.c | 13 +++-- 1 file changed, 11 insertions(+), 2 del

[PATCHv2] drm/amdkfd: Remove vla

There's an ongoing effort to remove VLAs[1] from the kernel to eventually turn on -Wvla. Switch to a constant value that covers all hardware. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Laura Abbott <labb...@redhat.com> --- v2: Switch to a larger size to account for other ha

Re: [PATCH] drm/i2c: tda998x: Remove VLA usage

On 04/09/2018 03:21 PM, Russell King - ARM Linux wrote: On Mon, Apr 09, 2018 at 02:07:03PM -0700, Laura Abbott wrote: There's an ongoing effort to remove VLAs[1] from the kernel to eventually turn on -Wvla. The vla in reg_write_range is based on the length of data passed. The one use of a non

Re: [PATCH] drm/amdkfd: Remove vla

On 04/09/2018 11:38 PM, Christian König wrote: Am 09.04.2018 um 23:06 schrieb Laura Abbott: There's an ongoing effort to remove VLAs[1] from the kernel to eventually turn on -Wvla. The single VLA usage in the amdkfd driver is actually constant across all current platforms. Actually that isn't

[PATCH] drm/i2c: tda998x: Remove VLA usage

to this upper bound. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Laura Abbott <labb...@redhat.com> --- This one really feels like it should be a #define but I wasn't sure where the 32 came from. It looks like most other uses use one of the #defines in include/linux/hdmi? --- drive

[PATCH] drm/gma500: Remove VLA

There's an ongoing effort to remove VLAs[1] from the kernel to eventually turn on -Wvla. Switch to a reasonable upper bound for the VLAs in the gma500 driver. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Laura Abbott <labb...@redhat.com> --- This was a little hard to figure out

[PATCH] drm/amdkfd: Remove vla

There's an ongoing effort to remove VLAs[1] from the kernel to eventually turn on -Wvla. The single VLA usage in the amdkfd driver is actually constant across all current platforms. Switch to a constant size array instead. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Laura Abbott <l

Re: [PATCH v4] drm/i915/dp: Send DPCD ON for MST before phy_up

docked with lid down case: Tested-by: Laura Abbott <labb...@redhat.com> Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Laura Abbott <labb...@redhat.com> Cc: sta...@

Re: [PATCH] MAINTAINERS: add dri-devel for Android ION

should be small these days. Acked-by: Laura Abbott <labb...@redhat.com> Cc: Laura Abbott <labb...@redhat.com> Cc: Sumit Semwal <sumit.sem...@linaro.org> Cc: de...@driverdev.osuosl.org Cc: dri-devel@lists.freedesktop.org Cc: linaro-mm-...@lists.linaro.org (moderated for non-sub

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

ack up and just never shut the aux block down. Changes since v2: - Fix patch name, no functional changes Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Laura Abbott <labb...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Ville Syrjälä <ville.syrj...@

Re: [PATCH 2/2] selftests: ion: Add simple test with the vgem driver

On 02/26/2018 09:07 AM, Shuah Khan wrote: On 02/19/2018 11:33 AM, Daniel Vetter wrote: On Mon, Feb 19, 2018 at 10:18:21AM -0800, Laura Abbott wrote: On 02/19/2018 07:31 AM, Daniel Vetter wrote: On Thu, Feb 15, 2018 at 05:24:45PM -0800, Laura Abbott wrote: Ion is designed to be a framework

[PATCHv2 1/2] selftests: ion: Remove some prints

There's no need to print messages each time we alloc and free. Remove them. Signed-off-by: Laura Abbott <labb...@redhat.com> --- v2: No changes --- tools/testing/selftests/android/ion/ionutils.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/andro

[PATCHv2 0/2] Ion unit test with VGEM

to actually make some of the dma_buf calls. The vgem DRM driver exists mostly for testing and works great for this case. Changes since v1: - Dropped RFC - Feedback/review from Daniel Vetter about DRM ioctls Thanks, Laura Laura Abbott (2): selftests: ion: Remove some prints selftests: ion: Add

[PATCHv2 2/2] selftests: ion: Add simple test with the vgem driver

.ch> Signed-off-by: Laura Abbott <labb...@redhat.com> --- v2: Introduce drmIoctl wrapper per suggestion of Daniel Vetter to better match how DRM ioctls actually work. --- tools/testing/selftests/android/ion/Makefile | 3 +- tools/testing/selftests/android/ion/config| 1 + t

Re: [PATCH 2/2] selftests: ion: Add simple test with the vgem driver

On 02/19/2018 07:31 AM, Daniel Vetter wrote: On Thu, Feb 15, 2018 at 05:24:45PM -0800, Laura Abbott wrote: Ion is designed to be a framework used by other clients who perform operations on the buffer. Use the DRM vgem client as a simple consumer. In conjunction with the dma-buf sync ioctls

[PATCH 2/2] selftests: ion: Add simple test with the vgem driver

Ion is designed to be a framework used by other clients who perform operations on the buffer. Use the DRM vgem client as a simple consumer. In conjunction with the dma-buf sync ioctls, this tests the full attach/map path for the system heap. Signed-off-by: Laura Abbott <labb...@redhat.

[RFC PATCH 0/2] Ion unit test with VGEM

. Thanks, Laura Laura Abbott (2): selftests: ion: Remove some prints selftests: ion: Add simple test with the vgem driver tools/testing/selftests/android/ion/Makefile | 3 +- tools/testing/selftests/android/ion/config| 1 + tools/testing/selftests/android/ion/ionmap_test.c

[PATCH 1/2] selftests: ion: Remove some prints

There's no need to print messages each time we alloc and free. Remove them. Signed-off-by: Laura Abbott <labb...@redhat.com> --- tools/testing/selftests/android/ion/ionutils.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/android/ion/ionutils.c b

Re: [PATCH] staging: android: ion: Fix dma direction for dma_sync_sg_for_cpu/device

On 12/15/2017 12:59 PM, Sushmita Susheelendra wrote: Use the direction argument passed into begin_cpu_access and end_cpu_access when calling the dma_sync_sg_for_cpu/device. The actual cache primitive called depends on the direction passed in. Acked-by: Laura Abbott <labb...@redhat.

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On 12/02/2017 07:53 AM, Greg KH wrote: This is one of the item in the TODO list before been able to unstage ION which is my real need. Why does it matter where in the tree this code is? Don't go adding new things to it that are not needed. Who needs this? What userspace code wants this type

Regression in TTM driver w/Linus' master

Hi, Fedora QA testing reported a panic when booting up VMs using qmeu vga drivers (https://paste.fedoraproject.org/paste/498yRWTCJv2LKIrmj4EliQ) [ 30.108507] [ cut here ] [ 30.108920] kernel BUG at ./include/linux/gfp.h:408! [ 30.109356] invalid opcode: [#1]

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

l ones for all heaps. Allocation requests will be only allowed if the mask_id match with device minor. Query request could be done on any of the devices. With this patch, sysfs looks like: $ ls /sys/devices/ breakpoint ion platform software system virtual From an Ion perspective, you can have Acked-by

Re: [PATCH v6 1/2] staging: ion: reorder include

On 11/06/2017 07:59 AM, Benjamin Gaignard wrote: Put include in alphabetic order Acked-by: Laura Abbott <labb...@redhat.com> Signed-off-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> --- drivers/staging/android/ion/ion.c | 14 +++--- 1 file changed, 7 inse

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On 10/31/2017 12:11 PM, Mark Brown wrote: > On Tue, Oct 31, 2017 at 12:03:35PM -0700, Laura Abbott wrote: > >> I'm not a fan of the platform bus but I have mixed feelings about >> creating a dedicated bus type. I guess if we really need a bus >>

Re: [PATCH v6 2/2] staging: ion: create one device entry per heap

On 10/23/2017 08:55 AM, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones for all heaps. >

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

On 09/27/2017 06:20 AM, Benjamin Gaignard wrote: > diff --git a/drivers/staging/android/ion/ion.c > b/drivers/staging/android/ion/ion.c > index 93e2c90..092b24c 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -40,6 +40,8 @@ > > #include "ion.h" >

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

On 10/10/2017 02:11 AM, Mark Brown wrote: > On Mon, Oct 09, 2017 at 05:10:37PM -0700, Laura Abbott wrote: >> On 10/09/2017 03:08 PM, Mark Brown wrote: >>> On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: > >>>> Anyway, to move this forward I think

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

On 10/09/2017 03:08 PM, Mark Brown wrote: > On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: > >> Anyway, to move this forward I think we need to see a proof of concept >> of using selinux to protect access to specific heaps. > > Aren't Unix permissions en

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

On 10/05/2017 06:06 AM, Benjamin Gaignard wrote: > 2017-10-04 12:17 GMT+02:00 Mark Brown : >> On Tue, Oct 03, 2017 at 04:08:30PM -0700, Sandeep Patil wrote: >> >>> It is entirely possible and easy in android/ueventd to create those nodes >>> under "/dev/ion/". (assuming the

Re: [PATCH v5 1/2] staging: ion: simplify ioctl args checking function

elieve > this one could be useful. > May I ask you your point of view on those few lines ? > > Benjamin > Yes, this looks better. Acked-by: Laura Abbott <labb...@redhat.com> >> Signed-off-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> >> --- >>

Re: [PATCH] cma: Take __GFP_NOWARN into account in cma_alloc()

ctrons.com> Acked-by: Laura Abbott <labb...@redhat.com> > --- > Hello, > > This patch aims at removing INFO messages that are displayed when the > VC4 driver tries to allocate buffer objects. From the driver perspective > an allocation failure is acceptable, and the driver

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

On 10/03/2017 04:08 PM, Sandeep Patil wrote: > On Tue, Oct 03, 2017 at 02:42:32PM -0700, Laura Abbott wrote: >> On 10/03/2017 09:48 AM, Mark Brown wrote: >>> On Mon, Oct 02, 2017 at 11:07:48AM -0700, Laura Abbott wrote: >>> >>>> Thinking a

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

On 10/03/2017 09:48 AM, Mark Brown wrote: > On Mon, Oct 02, 2017 at 11:07:48AM -0700, Laura Abbott wrote: > >> Thinking about this a bit more, I'm not 100% sure if this >> will allow the security rules we want. Heap ids are assigned >> dynamically and therefore so will t

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

On 09/27/2017 06:20 AM, Benjamin Gaignard wrote: > Instead a getting only one common device "/dev/ion" for > all the heaps this patch allow to create one device > entry ("/dev/ionX") per heap. > Getting an entry per heap could allow to set security rules > per heap and global ones for all heaps. >

Re: [PATCH v4 2/2] staging: ion: create one device entry per heap

On 09/26/2017 09:17 AM, Mark Brown wrote: On Tue, Sep 26, 2017 at 02:07:05PM +0200, Benjamin Gaignard wrote: version 4: - add a configuration flag to switch between legacy Ion misc device and one device per heap version. Should this be a switch or should it just be enabling and disabling

Re: [PATCH v3 2/2] staging: ion: create one device entry per heap

On 09/25/2017 11:56 PM, Greg KH wrote: On Tue, Sep 26, 2017 at 07:09:14AM +0200, Daniel Vetter wrote: On Mon, Sep 25, 2017 at 11:26:27AM -0700, Laura Abbott wrote: On 09/20/2017 01:45 AM, Benjamin Gaignard wrote: Instead a getting one common device "/dev/ion" for all the heaps

Re: [PATCH v3 2/2] staging: ion: create one device entry per heap

On 09/20/2017 01:45 AM, Benjamin Gaignard wrote: Instead a getting one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation

Re: [PATCH 0/3] staging: android: ion: Minor clean ups and fixes

drivers/staging/android/uapi/ion.h | 6 -- > 3 files changed, 3 insertions(+), 31 deletions(-) > Acked-by: Laura Abbott <labb...@redhat.com> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCHv2] drm/prime: Forward declare struct device

of this definition or declaration struct device *attach_dev); ^~ Forward declare it. Signed-off-by: Laura Abbott <labb...@redhat.com> --- v2: Switch to foward declaration instead of including a header. --- include/drm/drm_prime.h | 2 ++ 1 file chan

  1   2   3   >