Re: [PATCH] drivers/video: Fix -Wstringop-truncation in hdmi.c

2020-10-21 Thread Laurent Pinchart
))); As this seems to be a legitimate use of strncpy(), isn't there a way to silence the warning without requiring this additional runtime complexity ? > > return 0; > } -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC][PATCH] drm/bridge: lvds-codec: Add support for pixel data sampling edge select

2020-10-18 Thread Laurent Pinchart
; Cc: Alexandre Torgue > Cc: Andrzej Hajda > Cc: Antonio Borneo > Cc: Benjamin Gaignard > Cc: Biju Das > Cc: Laurent Pinchart > Cc: Maxime Coquelin > Cc: Philippe Cornu > Cc: Sam Ravnborg > Cc: Vincent Abriou > Cc: Yannick Fertre > Cc: linux-arm-ker...@lists

Re: [PATCH v2 3/7] dt-bindings: display: mxsfb: Add a bus-width endpoint property

2020-10-12 Thread Laurent Pinchart
Hi Marek, On Sat, Oct 10, 2020 at 10:47:05AM +0200, Marek Vasut wrote: > On 10/10/20 1:58 AM, Laurent Pinchart wrote: > > Hi Marek, > > Hi, > > > On Wed, Oct 07, 2020 at 10:40:26AM +0200, Marek Vasut wrote: > >> On 10/7/2

[PATCH 0/2] drm: mxsfb: Primary plane format fix and enhancement

2020-10-12 Thread Laurent Pinchart
Hello, This small patch series fixes format switching for the primary plane, and adds support for the RGB888 format. There's not much else to tell, please see individual patches for details. Laurent Pinchart (2): drm: mxsfb: Fix format changes for primary plane drm: mxsfb: Add RGB888 support

[PATCH 1/2] drm: mxsfb: Fix format changes for primary plane

2020-10-12 Thread Laurent Pinchart
The primary plane's format is configured in registers that have no shadow support for live updates. They require the display to be fully reconfigured in order to be updated. Force a mode set when the primary plane format changes to ensure this. Signed-off-by: Laurent Pinchart --- drivers/gpu

[PATCH 2/2] drm: mxsfb: Add RGB888 support on the primary plane

2020-10-12 Thread Laurent Pinchart
The primary plane can support the packed 24-bit RGB888 format. Enable it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 5 + drivers/gpu/drm/mxsfb/mxsfb_kms.c | 7 +++ 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers

Re: [PATCH v3 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-10-11 Thread Laurent Pinchart
fore reading the device tree > properties so that the version information is available when private > data maximum width is initialized, if "max-width" property is not > found. > > Signed-off-by: Jyri Sarha > Reviewed-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart >

Re: [PATCH RESEND v3 1/6] drm/of: Change the prototype of drm_of_lvds_get_dual_link_pixel_order

2020-10-11 Thread Laurent Pinchart
int endpoint2_id); > #else > static inline uint32_t drm_of_crtc_port_mask(struct drm_device *dev, > struct device_node *port) > @@ -93,8 +97,12 @@ static inline int drm_of_find_panel_or_bridge(const struct > devi

Re: [PATCH] ARM: davinci_all_defconfig: Add CONFIG_DRM_DISPLAY_CONNECTOR=m

2020-10-10 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Sat, Oct 10, 2020 at 07:08:50PM +0300, Jyri Sarha wrote: > Current dumb-vga-dac driver requires CONFIG_DRM_DISPLAY_CONNECTOR > for it to work. > > Signed-off-by: Jyri Sarha Reviewed-by: Laurent Pinchart > --- > An alternative

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Laurent Pinchart
his way, instead of broken an > > > > userspace API that it is there since 1991. > > > > > > It has happened before :( It took 4 years for RDMA to undo the uAPI > > > breakage caused by a security fix for something that was a 15 years > > > old bug. > &g

Re: [PATCH v2 09/17] mm: Add unsafe_follow_pfn

2020-10-10 Thread Laurent Pinchart
:( It took 4 years for RDMA to undo the uAPI > > breakage caused by a security fix for something that was a 15 years > > old bug. > > Yeah we have a bunch of these on the drm side too. Some of them are > really just "you have to upgrade userspace", and there's no real fix > for the security nightmare without that. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 8/7] dt-bindings: display: mxsfb: Add compatible for i.MX8MM

2020-10-09 Thread Laurent Pinchart
From: Marek Vasut NXP's i.MX8MM has an LCDIF as well. Signed-off-by: Marek Vasut Reviewed-by: Laurent Pinchart Signed-off-by: Laurent Pinchart --- Changes since v1: - Rebased on top of the YAML conversion --- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 1 + 1 file changed, 1

Re: [PATCH v2 3/7] dt-bindings: display: mxsfb: Add a bus-width endpoint property

2020-10-09 Thread Laurent Pinchart
Hi Marek, On Wed, Oct 07, 2020 at 10:40:26AM +0200, Marek Vasut wrote: > On 10/7/20 3:24 AM, Laurent Pinchart wrote: > > [...] > > > + bus-width: > > +enum: [16, 18, 24] > > +description: | > > + The ou

Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML

2020-10-09 Thread Laurent Pinchart
Hi Rob, On Wed, Oct 07, 2020 at 11:00:20AM -0500, Rob Herring wrote: > On Wed, Oct 07, 2020 at 04:24:32AM +0300, Laurent Pinchart wrote: > > Convert the mxsfb binding to YAML. The deprecated binding is dropped, as > > neither the DT sources nor the driver support it anymore

Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML

2020-10-07 Thread Laurent Pinchart
Hi Marek, On Wed, Oct 07, 2020 at 10:55:24AM +0200, Marek Vasut wrote: > On 10/7/20 10:43 AM, Lucas Stach wrote: > > On Mi, 2020-10-07 at 10:32 +0200, Marek Vasut wrote: > >> On 10/7/20 3:24 AM, Laurent Pinchart wrote: > >> [...] > >>> +propertie

[PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML

2020-10-06 Thread Laurent Pinchart
of combination of documented and undocumented values. Keep it simple for now, and update the example to make it valid. Aligning the binding with the existing DT sources will be performed separately. Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg -- Changes since v1: - Drop unneeded quotes

[PATCH v2 6/7] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock

2020-10-06 Thread Laurent Pinchart
The LCDIF disp_axi clock is not mandatory in the DT binding and not required by the driver. Remove it when it points to a dummy clock. Signed-off-by: Laurent Pinchart Acked-by: Sam Ravnborg --- arch/arm/boot/dts/imx6sl.dtsi | 5 ++--- arch/arm/boot/dts/imx6sll.dtsi | 5 ++--- arch/arm/boot

[PATCH v2 7/7] drm: mxsfb: Add support for the bus-width DT property

2020-10-06 Thread Laurent Pinchart
A new bus-width DT property has been introduced in the bindings to allow overriding the bus width. Support it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 ++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 ++ drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8

[PATCH v2 4/7] ARM: dts: imx: Fix LCDIF compatible strings

2020-10-06 Thread Laurent Pinchart
The LCDIF in the i.MX6 SoCs has additional features compared to the i.MX28. Replace the fsl,imx28-lcdif fallback compatible string with fsl,imx6sx-lcdif to reflect that. Signed-off-by: Laurent Pinchart Acked-by: Sam Ravnborg --- arch/arm/boot/dts/imx6sl.dtsi | 2 +- arch/arm/boot/dts

[PATCH v2 5/7] arm64: dts: imx8mq: Fix LCDIF compatible strings

2020-10-06 Thread Laurent Pinchart
The LCDIF in the i.MX8 SoCs has additional features compared to the i.MX28. Replace the fsl,imx28-lcdif fallback compatible string with fsl,imx6sx-lcdif to reflect that. Signed-off-by: Laurent Pinchart Acked-by: Sam Ravnborg --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +- 1 file changed

[PATCH v2 3/7] dt-bindings: display: mxsfb: Add a bus-width endpoint property

2020-10-06 Thread Laurent Pinchart
:18], the output bus width is 24 instead of 18 when the signals are routed to LCD_DATA[5:0], LCD_DATA[11:6] and LCD_DATA[17:12]. Add a bus-width property to describe this data routing. Signed-off-by: Laurent Pinchart --- Changes since v1: - Fix property name in binding --- .../devicetree/bindings

[PATCH v2 0/7] drm: mxsfb: Allow overriding bus width

2020-10-06 Thread Laurent Pinchart
. Patch 7/7 finally adds support for the bus-width property to the mxsfb driver. Changes compared to v1 are minor and are listed in individual patches. Laurent Pinchart (7): dt-bindings: display: mxsfb: Convert binding to YAML dt-bindings: display: mxsfb: Add and fix compatible strings dt

[PATCH v2 2/7] dt-bindings: display: mxsfb: Add and fix compatible strings

2020-10-06 Thread Laurent Pinchart
. Signed-off-by: Laurent Pinchart Reviewed-by: Sam Ravnborg --- Changes since v1: - Fix indentation under enum --- .../devicetree/bindings/display/fsl,lcdif.yaml | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/display/fsl

Re: [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings

2020-10-06 Thread Laurent Pinchart
Hi Stefan, On Mon, Aug 24, 2020 at 04:19:23PM +0200, Stefan Agner wrote: > On 2020-08-24 01:26, Laurent Pinchart wrote: > > On Fri, Aug 21, 2020 at 04:53:56PM +0200, Stefan Agner wrote: > >> On 2020-08-13 03:29, Laurent Pinchart wrote: > >> > Additional compatible

Re: [PATCH] dt-bindings: mxsfb: Add compatible for i.MX8MM

2020-10-06 Thread Laurent Pinchart
changed, 1 insertion(+) > >> > > > > Acked-by: Rob Herring > > > > Though Laurent posted converting this to schema... > > Do you want me to rebase this on top of it or the other way around ? Would it be OK if I rebased this on top of the conversion, and

Re: [PATCH v2] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

2020-09-27 Thread Laurent Pinchart
Hi Prabhakar, On Sun, Sep 27, 2020 at 02:01:50PM +0100, Lad, Prabhakar wrote: > On Mon, Aug 24, 2020 at 1:48 AM Laurent Pinchart wrote: > > On Thu, Aug 13, 2020 at 03:00:41PM +0100, Lad Prabhakar wrote: > > > The iwg21d comes with a 7" capacitive touch screen, ther

Re: [PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-25 Thread Laurent Pinchart
On Fri, Sep 25, 2020 at 03:05:52PM +0300, Tomi Valkeinen wrote: > On 25/09/2020 15:00, Laurent Pinchart wrote: > > On Fri, Sep 25, 2020 at 10:36:44AM +0300, Tomi Valkeinen wrote: > >> On 24/09/2020 14:48, Laurent Pinchart wrote: > >>> Hi Tomi, >

Re: [PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-25 Thread Laurent Pinchart
On Fri, Sep 25, 2020 at 10:36:44AM +0300, Tomi Valkeinen wrote: > On 24/09/2020 14:48, Laurent Pinchart wrote: > > Hi Tomi, > > > > Thank you for the patch. > > > > On Wed, Sep 23, 2020 at 11:30:57AM +0300, Tomi Valkeinen wrote: > >> On x64 we get: >

Re: [PATCH] drm: bridge: cdns-mhdp8546: fix compile warning

2020-09-24 Thread Laurent Pinchart
attached) > - writel(~CDNS_APB_INT_MASK_SW_EVENT_INT, > + writel(~(u32)CDNS_APB_INT_MASK_SW_EVENT_INT, > mhdp->regs + CDNS_APB_INT_MASK); > } > -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [GIT PULL FOR v5.10 - v3] R-Car display drivers miscellaneous changes

2020-09-22 Thread Laurent Pinchart
On Tue, Sep 22, 2020 at 02:15:26PM +0300, Laurent Pinchart wrote: > Hi Dave and Daniel, > > Still because the original pull request hasn't been pulled yet, here's > an updated version that fixes one small issue. I had initially fixed it > in a separate patch to be merged in t

[GIT PULL FOR v5.10 - v3] R-Car display drivers miscellaneous changes

2020-09-22 Thread Laurent Pinchart
: rcar-du: lvds: Add r8a7742 support drm: rcar-du: Update description for DRM_RCAR_DW_HDMI Kconfig entry Laurent Pinchart (3): drm: rcar-du: Fix pitch handling for fully planar YUV formats drm: rcar-du: Fix crash when enabling a non-visible plane drm: rcar-du: Put reference

[PATCH v3] drm/bridge: lvds-codec: Add support for regulator

2020-09-22 Thread Laurent Pinchart
From: Biju Das Add the support for enabling optional regulator that may be used as VCC source. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart [Replaced 'error' variable with 'ret'] [Renamed regulator from 'vcc' to 'power'] Signed-off-by: Laurent Pinchart --- Changes since v2: - Use

Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: add missing properties to dt-schema

2020-09-17 Thread Laurent Pinchart
> maxItems: 1 > description: phandle to the associated power domain > > + dma-coherent: > +type: boolean > + >ports: > type: object > description: -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[GIT PULL FOR v5.10 - v2] R-Car display drivers miscellaneous changes

2020-09-16 Thread Laurent Pinchart
dt-bindings: display: renesas,lvds: Document r8a7742 bindings drm: rcar-du: lvds: Add r8a7742 support drm: rcar-du: Update description for DRM_RCAR_DW_HDMI Kconfig entry Laurent Pinchart (3): drm: rcar-du: Fix pitch handling for fully planar YUV formats drm: rcar-du: Fix

Re: [PATCH] drm: rcar-du: Put reference to VSP device

2020-09-16 Thread Laurent Pinchart
Hi Kieran, On Wed, Sep 16, 2020 at 11:26:36AM +0100, Kieran Bingham wrote: > On 16/09/2020 00:38, Laurent Pinchart wrote: > > The reference to the VSP device acquired with of_find_device_by_node() > > in rcar_du_vsp_init() is never released. Fix it with a drmm action, > >

Re: [PATCH] dt-bindings: dp-connector: add binding for DisplayPort connector

2020-09-16 Thread Laurent Pinchart
t; Signed-off-by: Tomi Valkeinen Possibly with a type property added, Reviewed-by: Laurent Pinchart > --- > .../display/connector/dp-connector.yaml | 48 +++ > 1 file changed, 48 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/displ

[PATCH] drm: rcar-du: Put reference to VSP device

2020-09-15 Thread Laurent Pinchart
lanes") Reported-by: Yu Kuai Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index f1a81c9b184d..fa09b3ae8b9d 100644 --- a/drive

Re: [PATCH] drm: rcar-du: add missing put_device() call in rcar_du_vsp_init()

2020-09-15 Thread Laurent Pinchart
e driver is unloaded. The way to handle cleanup in DRM is through drmm_add_action() nowadays, and I think we could thus simply replace the change above with a cleanup action that is run both in the error path and at driver remove. I'll post a proposal in a reply to this e-mail. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC PATCH 1/3] drm: use flags instead of boolean in plane check

2020-09-15 Thread Laurent Pinchart
c_check(struct drm_plane > *plane, > ret = drm_atomic_helper_check_plane_state(new_state, crtc_state, > DRM_PLANE_HELPER_NO_SCALING, >

Re: [PATCH] drm: Kconfig: Update description for DRM_RCAR_DW_HDMI config

2020-09-15 Thread Laurent Pinchart
ere. I'd propose The rcar_dw_hdmi driver is also used on Renesas RZ/G2 SoCs. Update the Kconfig entry description to reflect this. Reviewed-by: Laurent Pinchart If you're fine with that, there's no need to resubmit the patch. > Signed-off-by: Lad Prabhakar > Reviewed-by: Chris Paterson &g

Re: [GIT PULL FOR v5.10] R-Car display drivers miscellaneous changes

2020-09-15 Thread Laurent Pinchart
Hello, Is there anything blocking this ? On Tue, Sep 08, 2020 at 07:03:36PM +0300, Laurent Pinchart wrote: > Hi Dave and Daniel, > > The following changes since commit ce5c207c6b8dd9cdeaeeb2345b8a69335c0d98bf: > > Merge tag 'v5.9-rc4' into drm-next (2020-09-08

Re: [PATCH v2 20/21] drm/xlnx: Initialize DRM driver instance with CMA helper macro

2020-09-15 Thread Laurent Pinchart
gt; Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c > in

Re: [PATCH v2] drm/panel: samsung: make vint_table static

2020-09-15 Thread Laurent Pinchart
mmit message should mention that it also make the table const. I'd write "drm/panel: samsung: Make vint_table static const" in the subject line, and add here "While at it, make the table const as it is never modified." With those changes, Reviewed-by: Laurent Pinchart > Re

Re: [PATCH] drm/panel: samsung: make vint_table static

2020-09-14 Thread Laurent Pinchart
}; > > -unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = { > +static unsigned char vint_table[S6E3HA2_VINT_STATUS_MAX] = { Shouldn't it be const, while at it ? > 0x18, 0x19, 0x1a, 0x1b, 0x1c, > 0x1d, 0x1e, 0x1f, 0x20, 0x21 > }; -- Regards, Laurent Pinchart __

Re: [PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-09-14 Thread Laurent Pinchart
index 18815e75ca4f..76adf87fec4e 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h > @@ -28,8 +28,10 @@ struct drm_plane; > > /* Defaulting to pixel clock defined on AM335x */ > #define TILCDC_DEFAULT_MAX_PIXELCLOCK

Re: [PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time

2020-09-14 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Mon, Sep 14, 2020 at 11:34:49AM +0300, Jyri Sarha wrote: > END_OF_FRAME interrupts have been enabled all the time since the > beginning of this driver. It is about time to add this feature. > > Signed-off-by: Jyri Sarha Reviewed-by: Laur

Re: [PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

2020-09-10 Thread Laurent Pinchart
reset-names = "du.0", "du.2"; > > > + > > > + renesas,vsps = < 0>, < 0>, < 0>; > > > + status = "disabled"; > > > > Do you want support for CMMs?

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurent Pinchart
Hi Vitaly, On Thu, Sep 10, 2020 at 01:09:03PM -0400, Vitaly Prosyak wrote: > On 2020-09-10 6:56 a.m., Laurent Pinchart wrote: > > On Thu, Sep 10, 2020 at 01:28:03PM +0300, Pekka Paalanen wrote: > >> On Thu, 10 Sep 2020 12:30:09 +0300 Laurentiu Palcu wrote: > >>> On T

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurent Pinchart
es with each entry being a > triplet, while a 1D LUT could be 1024 entries with each entry being a > scalar. 1D LUTs are used per-channel so you need three of them, 3D LUTs > you need just one for the color value triplet mapping. > > A 3D LUT can express much more than a 4x4 CTM. A 1D LUT cannot do the > channel mixing that a CTM can. > > So if you truly have 3D LUTs everywhere, I wonder why the CSC matrix > blocks exist... Possibly because the 3D LUT uses interpolation (it's a 17x17x17 LUT in R-Car), having a separate CSC can give more precision (as well as allowing the two problems to be decoupled, at a relatively low hardware cost). -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: per-plane LUTs and CSCs?

2020-09-10 Thread Laurent Pinchart
el interface should look like. Since hw is pretty special in this > > area, I expect we'll have to do a bunch of impendendance mismatching in > > the kernel anyway. > > Speaking of that, where should we scream if we feel like we are missing > KMS properties to get the best out of color management and HDR in > Weston, assuming we're not kernel devs? > > Who to Cc? You can CC me for Renesas. I'm not necessarily the most knowledgeable person on this topic, but I can at least dispatch to developers who could help. > We currently have intel and AMD hardware at hand if that makes any > difference. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: rcar-du: Fix pitch handling for fully planar YUV formats

2020-09-09 Thread Laurent Pinchart
Hi Kieran, On Wed, Sep 09, 2020 at 05:06:01PM +0100, Kieran Bingham wrote: > On 09/09/2020 13:08, Ville Syrjälä wrote: > > On Tue, Sep 08, 2020 at 05:05:48PM +0100, Kieran Bingham wrote: > >> On 08/09/2020 16:52, Laurent Pinchart wrote: > >>> On Tue, Sep 08, 20

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-09-08 Thread Laurent Pinchart
as no information > > > > > wrt CPADHI or for loosely packed > > > > > > > > > > static const u32 tc_lvds_in_bus_fmts[] = { > > > > > MEDIA_BUS_FMT_RGB565_1X16, > > > > > MEDIA_BUS_FMT_RGB666_1X18, > >

[GIT PULL FOR v5.10] R-Car display drivers miscellaneous changes

2020-09-08 Thread Laurent Pinchart
support Lad Prabhakar (4): dt-bindings: display: renesas,du: Document the r8a7742 bindings drm: rcar-du: Add r8a7742 support dt-bindings: display: renesas,lvds: Document r8a7742 bindings drm: rcar-du: lvds: Add r8a7742 support Laurent Pinchart (2): drm: rcar-du: Fix

Re: [PATCH] drm: rcar-du: Fix pitch handling for fully planar YUV formats

2020-09-08 Thread Laurent Pinchart
Hi Kieran, On Tue, Sep 08, 2020 at 04:42:58PM +0100, Kieran Bingham wrote: > On 06/08/2020 03:26, Laurent Pinchart wrote: > > When creating a frame buffer, the driver verifies that the pitches for > > the chroma planes match the luma plane. This is done incorrectly for >

Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible.

2020-09-08 Thread Laurent Pinchart
On Tue, Sep 08, 2020 at 05:43:25PM +0300, Laurent Pinchart wrote: > Hi Kieran, > > On Tue, Sep 08, 2020 at 03:18:20PM +0100, Kieran Bingham wrote: > > On 08/09/2020 01:34, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > > > > > required is &

Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible.

2020-09-08 Thread Laurent Pinchart
000 { > > - compatible = "renesas,r8a7795-dw-hdmi"; > > + compatible = "renesas,r8a7795-hdmi"; > > reg = <0 0xfead 0 0x1>; > > interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>; > > clocks = < CPG_CORE R8A7795_CLK_S0D4>, < CPG_MOD 729>; > > -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Laurent Pinchart
erspace to handle the issue correctly. > > Signed-off-by: Stefan Agner Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 21 - > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Laurent Pinchart
Agner wrote: > >>>> On 2020-09-07 20:18, Daniel Vetter wrote: > >>>>> On Mon, Sep 07, 2020 at 07:17:12PM +0300, Laurent Pinchart wrote: > >>>>>> Hi Stefan, > >>>>>> > >>>>>> Thank you for the patch. > &g

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-08 Thread Laurent Pinchart
On Tue, Sep 08, 2020 at 10:48:55AM +0200, Daniel Vetter wrote: > On Tue, Sep 08, 2020 at 11:18:25AM +0300, Tomi Valkeinen wrote: > > On 08/09/2020 10:55, Stefan Agner wrote: > > > On 2020-09-07 20:18, Daniel Vetter wrote: > > >> On Mon, Sep 07, 2020 at 07:17:12PM

Re: [PATCH v2 10/10] arm64: dts: renesas: r8a77961-salvator-xs: add HDMI Sound support

2020-09-08 Thread Laurent Pinchart
ull request later today. Could you just let me know if you're fine with the small modification to the commit message proposed in 04/10 ? -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 10/10] arm64: dts: renesas: r8a77961-salvator-xs: add HDMI Sound support

2020-09-08 Thread Laurent Pinchart
> + bitclock-master = <_endpoint1>; > + frame-master = <_endpoint1>; > + > + playback = <>; > + }; > + }; > + }; > +}; > + > +_card { > + dais = <_port0 /* ak4613 */ > + _port1>; /* HDMI0 */ > +}; -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 09/10] arm64: dts: renesas: r8a77961-salvator-xs: add HDMI Display support

2020-09-08 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Tue, Sep 08, 2020 at 09:35:20AM +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > This patch enables HDMI Display on R-Car M3-W+ Salvator-XS board. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart &g

Re: [PATCH v2 08/10] arm64: dts: renesas: r8a77961: Add HDMI device nodes

2020-09-08 Thread Laurent Pinchart
gned-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > b/arch/arm64/boot/dts/ren

Re: [PATCH v2 07/10] arm64: dts: renesas: r8a77961: Add DU device nodes

2020-09-08 Thread Laurent Pinchart
gned-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > b/arch/arm64/boot/dts/ren

Re: [PATCH v2 06/10] arm64: dts: renesas: r8a77961: Add VSP device nodes

2020-09-08 Thread Laurent Pinchart
i Morimoto Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 55 +++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > index fe0db11b9c

Re: [PATCH v2 05/10] arm64: dts: renesas: r8a77961: Add FCP device nodes

2020-09-07 Thread Laurent Pinchart
gned-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart > --- > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 52 +++ > 1 file changed, 52 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > b/arch/arm64/boot/dts/renesas/r8a77961.

Re: [PATCH v2 04/10] drm: rcar-du: Add r8a77961 support

2020-09-07 Thread Laurent Pinchart
..." ? > Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index

Re: [PATCH v2 03/10] dt-bindings: display: renesas: dw-hdmi: Add R8A77961 support

2020-09-07 Thread Laurent Pinchart
r M3-W+) compatible HDMI TX >- "renesas,r8a77965-hdmi" for R8A77965 (R-Car M3-N) compatible HDMI TX >- "renesas,rcar-gen3-hdmi" for the generic R-Car Gen3 and RZ/G2 compatible >HDMI TX -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible.

2020-09-07 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Tue, Sep 08, 2020 at 09:34:11AM +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > required is "renesas,r8a7795-hdmi", instead of "renesas,r8a7795-dw-hdmi" > > Signed-off-by: Kuninori Morim

Re: [PATCH v2 01/10] dt-bindings: display: renesas: du: Document the r8a77961 bindings

2020-09-07 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Tue, Sep 08, 2020 at 09:34:04AM +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Document the R-Car M3-W+ (R8A77961) SoC in the R-Car DU bindings. > > Signed-off-by: Kuninori Morimoto Reviewed-by: L

Re: [RFC] Experimental DMA-BUF Device Heaps

2020-09-07 Thread Laurent Pinchart
buf; > > + > > + buf->dmabuf = dma_buf_export(_info); > > + if (IS_ERR(buf->dmabuf)) { > > + dev_err(buf->dev, "failed to export dmabuf\n"); > > + return PTR_ERR(buf->dmabuf); > > + } > > + > > + ret = dma_buf_fd(buf->dmabuf, fd_flags); > > + if (ret < 0) { > > + dev_err(buf->dev, "failed to get dmabuf fd: %d\n", ret); > > + return ret; > > + } > > + > > + return ret; > > +} > > + > > +static const struct dma_heap_ops dev_heap_ops = { > > + .allocate = dev_heap_allocate, > > +}; > > + > > +void dev_dma_heap_add(struct device *dev) > > +{ > > + struct dma_heap_export_info exp_info; > > + > > + exp_info.name = dev_name(dev); > > + exp_info.ops = _heap_ops; > > + exp_info.priv = dev; > > + > > + dev->heap = dma_heap_add(_info); > > +} > > +EXPORT_SYMBOL(dev_dma_heap_add); > > diff --git a/include/linux/device.h b/include/linux/device.h > > index ca18da4768e3..1fae95d55ea1 100644 > > --- a/include/linux/device.h > > +++ b/include/linux/device.h > > @@ -45,6 +45,7 @@ struct iommu_ops; > > struct iommu_group; > > struct dev_pin_info; > > struct dev_iommu; > > +struct dma_heap; > > > > /** > > * struct subsys_interface - interfaces to device functions > > @@ -597,6 +598,10 @@ struct device { > > struct iommu_group *iommu_group; > > struct dev_iommu*iommu; > > > > +#ifdef CONFIG_DMABUF_HEAPS_DEVICES > > + struct dma_heap *heap; > > +#endif > > + > > booloffline_disabled:1; > > booloffline:1; > > boolof_node_reused:1; > > diff --git a/include/linux/dma-heap.h b/include/linux/dma-heap.h > > index 454e354d1ffb..dcf7cca2f487 100644 > > --- a/include/linux/dma-heap.h > > +++ b/include/linux/dma-heap.h > > @@ -56,4 +56,10 @@ void *dma_heap_get_drvdata(struct dma_heap *heap); > > */ > > struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info); > > > > +#ifdef CONFIG_DMABUF_HEAPS_DEVICES > > +void dev_dma_heap_add(struct device *dev); > > +#else > > +static inline void dev_dma_heap_add(struct device *dev) {} > > +#endif > > + > > #endif /* _DMA_HEAPS_H */ -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: mxsfb: check framebuffer pitch

2020-09-07 Thread Laurent Pinchart
; I'd turn this into a dev_dbg(), printing error messages to the kernel log in response to user-triggered conditions is a bit too verbose and could flood the log. Wouldn't it be best to catch this issue when creating the framebuffer ? > + return -EINVAL; > + } > + >

Re: [GIT PULL FOR v5.9] Fix Kconfig dependency issue with DMAENGINES selection

2020-09-05 Thread Laurent Pinchart
With Dave and Daniel on the recipients' list this time. On Sat, Sep 05, 2020 at 08:27:51PM +0300, Laurent Pinchart wrote: > Hi Dave and Daniel, > > This small pull request fixes a Kconfig dependency issue introduced in > v5.9-rc1. Among the three patches required to fix the issue, th

[GIT PULL FOR v5.9] Fix Kconfig dependency issue with DMAENGINES selection

2020-09-05 Thread Laurent Pinchart
Laurent Pinchart (2): rapidio: Replace 'select' DMAENGINES 'with depends on' drm: xlnx: dpsub: Fix DMADEVICES Kconfig dependency drivers/gpu/drm/xlnx/Kconfig | 1 + drivers/rapidio/Kconfig | 2 +- 2 files changed, 2 insertions(+), 1

Re: [PATCH 4/5] dt-bindings: display/bridge: nwl-dsi: Document fsl,clock-drop-level property

2020-09-05 Thread Laurent Pinchart
nded, looking at this patch I have no idea what this does and how to compute the value that should be set. > patternProperties: >"^panel@[0-9]+$": > type: object -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v9 2/3] drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge

2020-09-03 Thread Laurent Pinchart
ed on EDID, fbdev is created with 1920x1200. Link > training is done, which > has the CR issue, and because of that the actual mode that we get is > 1280x960. I get a proper > picture here, so far so good. > > Then if I run kmstest, it only allows 1280x960 as the link doesn't support > higher modes (that's ok). > It the does link training and gets a 4 lane link, and enables 1280x960. But > the picture is not ok. > > If I then exit kmstest, it goes back to fbdev, but now that picture is broken > also. > > Running kmstest again gives me 1920x1200 (as the link has been 4 lane now), > and the picture is fine. > > I think the above suggests that the driver is not properly updating all the > registers based on the > new mode and link. I tried adding cdns_mhdp_validate_mode_params() call to > cdns_mhdp_atomic_enable(), so that tu-size etc will be calculated, but that > did not fix the problem. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 01/16] drm/encoder: remove obsolete documentation of bridge

2020-09-03 Thread Laurent Pinchart
tover documentation of the removed field. > > Signed-off-by: Michael Tretter Reviewed-by: Laurent Pinchart > --- > include/drm/drm_encoder.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/drm/drm_encoder.h b/include/drm/drm_encoder.h > index a60f5f1555

Re: [PATCH v4 04/15] drm/bridge: tc358764: add drm_panel_bridge support

2020-09-03 Thread Laurent Pinchart
et bridge.type to DRM_MODE_CONNECTOR_LVDS. > > > > v2: > >- Use PTR_ERR_OR_ZERO() (kbuild test robot) > > > > Signed-off-by: Sam Ravnborg > > Cc: Laurent Pinchart > > Cc: kbuild test robot > > Cc: Andrzej Hajda > > Cc: Neil Armstron

Re: [PATCH v2 1/4] drm/of: Change the prototype of drm_of_lvds_get_dual_link_pixel_order

2020-09-01 Thread Laurent Pinchart
Hi Maxime, On Tue, Sep 01, 2020 at 03:23:40PM +0200, Maxime Ripard wrote: > On Mon, Aug 31, 2020 at 11:28:52PM +0300, Laurent Pinchart wrote: > > On Thu, Jul 30, 2020 at 11:35:01AM +0200, Maxime Ripard wrote: > > > The drm_of_lvds_get_dual_link_pixel_order() fu

Re: [PATCH v2 1/3] dt-bindings: display: bridge: lvds-codec: Document vcc-supply property

2020-09-01 Thread Laurent Pinchart
power/ and the commit message updated to dt-bindings: display: bridge: lvds-codec: Document power-supply property Document optional power-supply property that may be used to specify the regulator powering up the device. ? -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 1/3] dt-bindings: display: bridge: lvds-codec: Document vcc-supply property

2020-09-01 Thread Laurent Pinchart
eric > and also to align with terminology used in generic 'simple' panels. > > In our case this Receiver converts LVDS signals to RGB signals and fed > this signal to simple panel. > On the receiver part, We need to supply power to TTL output, PLL and > LVDS input. It all derived

Re: [PATCH v2 3/4] drm/sun4i: tcon: Support the LVDS Dual-Link on the A20

2020-08-31 Thread Laurent Pinchart
_LVDS_IF_DUAL_LINKBIT(30) > #define SUN4I_TCON0_LVDS_IF_BITWIDTH_MASKBIT(26) > #define SUN4I_TCON0_LVDS_IF_BITWIDTH_18BITS (1 << 26) > #define SUN4I_TCON0_LVDS_IF_BITWIDTH_24BITS (0 << 26) > @@ -274,6 +275,9 @@ struct sun4i_tcon { >

Re: [PATCH v2 2/4] drm/sun4i: tcon: Refactor the LVDS and panel probing

2020-08-31 Thread Laurent Pinchart
gt; + } else { > + has_lvds_alt = true; > + } > + } > + > + if (!has_lvds_rst || > + (tcon->quirks->has_lvds_alt && !has_lvds_alt)) { > + dev_warn(dev, "Missing LVDS properties, P

Re: [PATCH v2 1/4] drm/of: Change the prototype of drm_of_lvds_get_dual_link_pixel_order

2020-08-31 Thread Laurent Pinchart
_device *dev, > struct device_node *port) > @@ -93,8 +97,12 @@ static inline int drm_of_find_panel_or_bridge(const struct > device_node *np, > } > > static inline int > -drm_of_lvds_get_dual_link_pixel_order(const struct device_node *port1, > - const struct device_node *port2) > +drm_of_lvds_get_dual_link_pixel_order(const struct device_node *dev1, > + int port1_id, > + int endpoint1_id, > + const struct device_node *dev2, > + int port2_id, > + int endpoint2_id) > { > return -EINVAL; > } -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v9 2/3] drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge

2020-08-31 Thread Laurent Pinchart
Hi Swapnil, Thank you for the patch. On Mon, Aug 31, 2020 at 10:23:34AM +0200, Swapnil Jakhade wrote: > Add a new DRM bridge driver for Cadence MHDP8546 DPTX IP used in TI J721E > SoC. MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) > and embedded Display Port (eDP)

Re: [RFC] Experimental DMA-BUF Device Heaps

2020-08-31 Thread Laurent Pinchart
Hi James, On Sun, Aug 23, 2020 at 03:53:50PM -0700, James Jones wrote: > On 8/23/20 1:46 PM, Laurent Pinchart wrote: > > On Sun, Aug 23, 2020 at 01:04:43PM -0700, James Jones wrote: > >> On 8/20/20 1:15 AM, Ezequiel Garcia wrote: > >>> On Mon, 2020-08-17 at

Re: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-30 Thread Laurent Pinchart
I_DCS_BUS_TYPE_DBI_SPI_C3, > >> + .lanes = 1, > >> +}; > >> + > >> +static const struct of_device_id ili9341_of_match[] = { > >> + { .compatible = "adafruit,yx240qv29", .data = > >> _pdata }, > >> + { } > >> +}; > >> +MODULE_DEVICE_TABLE(of, ili9341_of_match); > >> + > >> +static struct mipi_dsi_driver ili9341_dsi_driver = { > >> + .probe = ili9341_probe, > >> + .remove = ili9341_remove, > >> + .driver = { > >> + .name = "ili9341-dsi", > >> + .of_match_table = ili9341_of_match, > >> + }, > >> +}; > >> +module_mipi_dsi_driver(ili9341_dsi_driver); > > > > Again, you treat this driver as a mipi dsi driver but for a MIPI-DBI > > (I8080/SPI) > > panel device. That will make developers confused. > > > > Is it possible to just add a mipi_dbi_driver for I8080/SPI interface > > panel? > > Thanks! > > Please read the cover letter, it explains why it's done this way. The > whole point of this patchset is to merge DSI and DBI frameworks in a > way that can be maintained. I think this proves the point that the proposed naming is confusing. At least a rename would be required. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v1 2/2] drm: bridge: add support for lontium LT9611UXC bridge

2020-08-28 Thread Laurent Pinchart
On Fri, Aug 28, 2020 at 05:33:00PM +0300, Laurent Pinchart wrote: > On Fri, Aug 28, 2020 at 07:48:48PM +0530, Vinod Koul wrote: > > On 28-08-20, 15:04, Dmitry Baryshkov wrote: > > > > > +#define EDID_BLOCK_SIZE 128 > > > +#define EDID_NUM_BLOCKS 2 > >

Re: [PATCH v1 2/2] drm: bridge: add support for lontium LT9611UXC bridge

2020-08-28 Thread Laurent Pinchart
struct hdmi_codec_daifmt *fmt, > > +struct hdmi_codec_params *hparms) > > +{ > > + /* > > +* LT9611UXC will automatically detect rate and sample size, so no need > > +* to setup anything here. > > +*/ >

Re: [PATCH] drm/tidss: Add prepare_fb to the plane helper funcs

2020-08-26 Thread Laurent Pinchart
unction pointer to plane helper funcs. > > Signed-off-by: Gowtham Tammana > Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/tidss/tidss_plane.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/tidss/t

Re: [PATCH] drm/bridge: tc358767: fix EDID memory leak

2020-08-26 Thread Laurent Pinchart
gt;edid); > + tc->edid is gone in drm-misc-next, problem solved already :-) > return 0; > } -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-25 Thread Laurent Pinchart
Hi Mauro, On Tue, Aug 25, 2020 at 01:30:25PM +0200, Mauro Carvalho Chehab wrote: > Em Tue, 25 Aug 2020 05:29:29 +1000 > Dave Airlie escreveu: > > > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart > > wrote: > > > > > > Hi Mauro, > > > >

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-23 Thread Laurent Pinchart
Hi Tomi, On Fri, Aug 14, 2020 at 12:29:35PM +0300, Tomi Valkeinen wrote: > On 11/08/2020 05:36, Laurent Pinchart wrote: > > >> +static int cdns_mhdp_mailbox_write(struct cdns_mhdp_device *mhdp, u8 val) > >> +{ > >> + int ret, full; > >> + &g

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-23 Thread Laurent Pinchart
Hi Tomi, On Fri, Aug 14, 2020 at 11:22:09AM +0300, Tomi Valkeinen wrote: > On 11/08/2020 05:36, Laurent Pinchart wrote: > > >> +static int cdns_mhdp_connector_init(struct cdns_mhdp_device *mhdp) > >> +{ > >> + u32 bus_format = MEDIA_BUS_FMT_RGB121212_1X36; &

Re: [PATCH v2] ARM: dts: r8a7742-iwg21d-q7: Add LCD support

2020-08-23 Thread Laurent Pinchart
erything seems to match the schematics :-) Reviewed-by: Laurent Pinchart > --- > v1->v2 > * This patch is part of series [1] (rest of the patches have be accepted > by Geert [2]). > * Added regulator for lvds > * Added reset pin for touchpanel > * This patch is based on s

[PATCH] drm: panel: Fix bpc for OrtusTech COM43H4M85ULC panel

2020-08-23 Thread Laurent Pinchart
h COM43H4M85ULC panel") Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 4eabfdd3be2d..723e9c879dfc 100644 --- a/d

Re: [PATCH 4/8] dt-bindings: display: mxsfb: Rename to fsl, lcdif.yaml

2020-08-23 Thread Laurent Pinchart
Hi Stefan, On Fri, Aug 21, 2020 at 04:55:38PM +0200, Stefan Agner wrote: > On 2020-08-13 03:29, Laurent Pinchart wrote: > > Rename the mxsfb.yaml binding schema to fsl,lcdif.yaml to match the > > usual bindings naming scheme. > > I tend to prefer to just name it fsl,lcdif

Re: [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings

2020-08-23 Thread Laurent Pinchart
Hi Stefan, On Fri, Aug 21, 2020 at 04:53:56PM +0200, Stefan Agner wrote: > On 2020-08-13 03:29, Laurent Pinchart wrote: > > Additional compatible strings have been added in DT source for the > > i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings. > > Mo

Re: dt-bindings: display: xlnx: mixer: Inconsistent pixel format terminology in dt docs

2020-08-23 Thread Laurent Pinchart
t also defines a xlnx,video-format property that uses the values from UG934 for the AXI streaming interface. > I agree. The bindings should be in sync with datasheet and not rely on > software definitions. Since the driver is only in Xilinx vendor tree, > please send directly to g...@xilinx.com. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM

2020-08-23 Thread Laurent Pinchart
Hi Qian, On Fri, Aug 21, 2020 at 09:20:37PM -0400, Qian Cai wrote: > On Mon, Jun 08, 2020 at 06:16:22AM +0300, Laurent Pinchart wrote: > > Hi Qian, > > > > I forgot to mention, I think the subject line should be > > > > drm/rcar-du: Make DRM_RCAR_WRITEBACK dep

  1   2   3   4   5   6   7   8   9   10   >