Re: [PATCH v2 5/8] drm: drm_atomic_helper: Add a new helper to deal with the writeback connector validation

2021-11-03 Thread Leandro Ribeiro
Hi, On 11/3/21 12:03, Igor Torrente wrote: > Hi Leandro, > > On 10/28/21 6:38 PM, Leandro Ribeiro wrote: >> Hi, >> >> On 10/26/21 08:34, Igor Torrente wrote: >>> Add a helper function to validate the connector configuration receive in >>> the en

Re: [PATCH v2 5/8] drm: drm_atomic_helper: Add a new helper to deal with the writeback connector validation

2021-10-28 Thread Leandro Ribeiro
break; > + } > + } > + > + if (!format_supported) { > + DRM_DEBUG_KMS("Invalid pixel format %p4cc\n", > + >format->format); > + return -EINVAL; > + } > + > + retur

[PATCH v6 1/1] drm/doc: document drm_mode_get_plane

2021-06-11 Thread Leandro Ribeiro
Add a small description and document struct fields of drm_mode_get_plane. Signed-off-by: Leandro Ribeiro --- include/uapi/drm/drm_mode.h | 32 1 file changed, 32 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index

[PATCH v6 0/1] Document drm_mode_get_plane

2021-06-11 Thread Leandro Ribeiro
to the other. Suggested by Ville Syrjälä v6: document that gamma_size field was never used. Suggested by Pekka Paalanen and Daniel Vetter Leandro Ribeiro (1): drm/doc: document drm_mode_get_plane include/uapi/drm/drm_mode.h | 32 1 file changed, 32

Re: [PATCH v5 1/1] drm/doc: document drm_mode_get_plane

2021-06-11 Thread Leandro Ribeiro
On 6/11/21 4:33 AM, Daniel Vetter wrote: > On Fri, Jun 11, 2021 at 9:20 AM Pekka Paalanen wrote: >> >> On Thu, 10 Jun 2021 17:38:24 -0300 >> Leandro Ribeiro wrote: >> >>> Add a small description and document struct fields of >>> drm_mode_get_

[PATCH v5 1/1] drm/doc: document drm_mode_get_plane

2021-06-10 Thread Leandro Ribeiro
Add a small description and document struct fields of drm_mode_get_plane. Signed-off-by: Leandro Ribeiro --- include/uapi/drm/drm_mode.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index

[PATCH v5 0/1] Document drm_mode_get_plane

2021-06-10 Thread Leandro Ribeiro
to the other. Suggested by Ville Syrjälä Leandro Ribeiro (1): drm/doc: document drm_mode_get_plane include/uapi/drm/drm_mode.h | 35 +++ 1 file changed, 35 insertions(+) -- 2.31.1

Re: [PATCH v4 2/2] drm/doc: document drm_mode_get_plane

2021-06-09 Thread Leandro Ribeiro
On 6/9/21 8:00 PM, Leandro Ribeiro wrote: > Add a small description and document struct fields of > drm_mode_get_plane. > > Signed-off-by: Leandro Ribeiro > --- > include/uapi/drm/drm_mode.h | 36 > 1 file changed, 36 insertio

[PATCH v4 2/2] drm/doc: document drm_mode_get_plane

2021-06-09 Thread Leandro Ribeiro
Add a small description and document struct fields of drm_mode_get_plane. Signed-off-by: Leandro Ribeiro --- include/uapi/drm/drm_mode.h | 36 1 file changed, 36 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index

[PATCH v4 1/2] drm/doc: document how userspace should find out CRTC index

2021-06-09 Thread Leandro Ribeiro
In this patch we add a section to document what userspace should do to find out the CRTC index. This is important as they may be many places in the documentation that need this, so it's better to just point to this section and avoid repetition. Signed-off-by: Leandro Ribeiro --- Documentation

[PATCH v4 0/2] Document drm_mode_get_plane

2021-06-09 Thread Leandro Ribeiro
IN and OUT fields and make the description more concise. Suggested by Pekka Paalanen Leandro Ribeiro (2): drm/doc: document how userspace should find out CRTC index drm/doc: document drm_mode_get_plane Documentation/gpu/drm-uapi.rst| 13 +++ drivers/gpu/drm/drm_debugfs_crc.c | 8

Re: [PATCH 2/2] drm/doc: document drm_mode_get_plane

2021-05-19 Thread Leandro Ribeiro
On 5/6/21 6:10 AM, Pekka Paalanen wrote: > On Wed, 28 Apr 2021 18:36:51 -0300 > Leandro Ribeiro wrote: > >> Add a small description and document struct fields of >> drm_mode_get_plane. >> >> Signed-off-by: Leandro Ribeiro > > Hi, > > thanks a

Re: [PATCH 1/2] drm/doc: document how userspace should find out CRTC index

2021-05-19 Thread Leandro Ribeiro
On 5/12/21 10:04 AM, Pekka Paalanen wrote: > On Wed, 12 May 2021 09:50:14 -0300 > Leandro Ribeiro wrote: > >> On 5/6/21 5:50 AM, Pekka Paalanen wrote: >>> On Wed, 28 Apr 2021 18:36:50 -0300 >>> Leandro Ribeiro wrote: >>> >>>> In

Re: [PATCH 1/2] drm/doc: document how userspace should find out CRTC index

2021-05-12 Thread Leandro Ribeiro
On 5/6/21 5:50 AM, Pekka Paalanen wrote: > On Wed, 28 Apr 2021 18:36:50 -0300 > Leandro Ribeiro wrote: > >> In this patch we add a section to document what userspace should do to >> find out the CRTC index. This is important as there are multiple places >> in

Re: [PATCH v2 1/1] drm/doc: document drm_mode_get_plane

2021-04-28 Thread Leandro Ribeiro
On 4/27/21 6:00 AM, Daniel Vetter wrote: > On Tue, Apr 27, 2021 at 10:40:24AM +0300, Pekka Paalanen wrote: >> On Mon, 26 Apr 2021 14:30:53 -0300 >> Leandro Ribeiro wrote: >> >>> On 4/26/21 7:58 AM, Simon Ser wrote: >>>> On Monday, April 26th, 20

[PATCH 1/2] drm/doc: document how userspace should find out CRTC index

2021-04-28 Thread Leandro Ribeiro
In this patch we add a section to document what userspace should do to find out the CRTC index. This is important as there are multiple places in the documentation that need this, so it's better to just point to this section and avoid repetition. Signed-off-by: Leandro Ribeiro --- Documentation

[PATCH 2/2] drm/doc: document drm_mode_get_plane

2021-04-28 Thread Leandro Ribeiro
Add a small description and document struct fields of drm_mode_get_plane. Signed-off-by: Leandro Ribeiro --- include/uapi/drm/drm_mode.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index a5e76aa06ad5

[PATCH v3 0/2] Document drm_mode_get_plane

2021-04-28 Thread Leandro Ribeiro
v2: possible_crtcs field is a bitmask, not a pointer. Suggested by Ville Syrjälä v3: document how userspace should find out CRTC index. Also, document that field 'gamma_size' represents the number of entries in the lookup table. Suggested by Pekka Paalanen and Daniel Vetter Leandro Ribeiro (2

Re: [PATCH v2 1/1] drm/doc: document drm_mode_get_plane

2021-04-26 Thread Leandro Ribeiro
On 4/26/21 7:58 AM, Simon Ser wrote: > On Monday, April 26th, 2021 at 9:36 AM, Pekka Paalanen > wrote: > This should probably explain what the bits in the mask correspond to. As in, which CRTC does bit 0 refer to, and so on. >>> >>> What about: >>> >>> "possible_crtcs: Bitmask of

Re: [PATCH v2 1/1] drm/doc: document drm_mode_get_plane

2021-04-23 Thread Leandro Ribeiro
On 4/23/21 8:11 AM, Pekka Paalanen wrote: > On Thu, 22 Apr 2021 15:10:04 -0300 > Leandro Ribeiro wrote: > >> Add a small description and document struct fields of >> drm_mode_get_plane. >> >> Signed-off-by: Leandro Ribeiro >> --- >> include/ua

[PATCH v2 1/1] drm/doc: document drm_mode_get_plane

2021-04-22 Thread Leandro Ribeiro
Add a small description and document struct fields of drm_mode_get_plane. Signed-off-by: Leandro Ribeiro --- include/uapi/drm/drm_mode.h | 16 1 file changed, 16 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index a5e76aa06ad5

[PATCH v2 0/1] Document drm_mode_get_plane

2021-04-22 Thread Leandro Ribeiro
ugh the other commit of the series was incorrect. So I'm pushing the first commit again. v2: possible_crtcs field is a bitmask, not a pointer. Suggested by Ville Syrjälä Leandro Ribeiro (1): drm/doc: document drm_mode_get_plane include/uapi/drm/drm_mode.h | 16 1 file ch

Re: [PATCH 0/2] Document how userspace should use plane format list and IN_FORMATS

2021-04-08 Thread Leandro Ribeiro
On 4/8/21 8:35 AM, Daniel Vetter wrote: > On Tue, Apr 06, 2021 at 04:21:16PM -0300, Leandro Ribeiro wrote: >> This patch is to emphasize how userspace should use the plane format list and >> the IN_FORMATS blob. The plane format list contains the formats that do not >&

Re: [PATCH 1/2] drm/doc: document drm_mode_get_plane

2021-04-08 Thread Leandro Ribeiro
On 4/7/21 10:45 AM, Ville Syrjälä wrote: > On Tue, Apr 06, 2021 at 04:21:17PM -0300, Leandro Ribeiro wrote: >> Add a small description and document struct fields of >> drm_mode_get_plane. >> >> Signed-off-by: Leandro Ribeiro >> --- >> include/uapi/drm/dr

[PATCH 1/2] drm/doc: document drm_mode_get_plane

2021-04-06 Thread Leandro Ribeiro
Add a small description and document struct fields of drm_mode_get_plane. Signed-off-by: Leandro Ribeiro --- include/uapi/drm/drm_mode.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index d1a93d2a85f9

[PATCH 0/2] Document how userspace should use plane format list and IN_FORMATS

2021-04-06 Thread Leandro Ribeiro
modifiers. Leandro Ribeiro (2): drm/doc: document drm_mode_get_plane drm/doc: emphasize difference between plane formats and IN_FORMATS blob drivers/gpu/drm/drm_plane.c | 4 include/uapi/drm/drm_mode.h | 22 ++ 2 files changed, 26 insertions(+) -- 2.31.1

[PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-06 Thread Leandro Ribeiro
that these are not disjoint sets. If a format supports modifiers but the driver can also handle it without a modifier, it should be present in both the IN_FORMATS blob property and the plane format list. Signed-off-by: Leandro Ribeiro --- drivers/gpu/drm/drm_plane.c | 4 include/uapi/drm/drm_mode.h | 3

[PATCH] drm/vkms: detect modes during output initialization

2020-11-29 Thread Leandro Ribeiro
any valid mode, so these userspace applications would not be able to use VKMS. Call drm_helper_probe_single_connector_modes() during VKMS output initialization in order to start with the set of all valid modes. Signed-off-by: Leandro Ribeiro --- drivers/gpu/drm/vkms/vkms_output.c | 6 ++ 1

Re: [PATCH] drm/vkms: detect modes during output initialization

2020-11-29 Thread Leandro Ribeiro
On 11/27/20 6:10 PM, Leandro Ribeiro wrote: > In userspace we can use drmGetConnector() or drmGetConnectorCurrent() in > order to retrieve connector information. The difference between both is > that the former retrieves the complete set of modes and encoders > associated with t

Re: [BUG] drm/vkms: Failure when using drmGetConnectorCurrent()

2020-11-29 Thread Leandro Ribeiro
On 11/24/20 11:39 AM, Daniel Vetter wrote: On Fri, Nov 20, 2020 at 01:19:04PM -0300, Leandro Ribeiro wrote: Hello, We have a patch in Weston to replace drmGetConnector() calls with drmGetConnectorCurrent(): https://gitlab.freedesktop.org/wayland/weston/-/issues/437 https

[BUG] drm/vkms: Failure when using drmGetConnectorCurrent()

2020-11-21 Thread Leandro Ribeiro
Hello, We have a patch in Weston to replace drmGetConnector() calls with drmGetConnectorCurrent(): https://gitlab.freedesktop.org/wayland/weston/-/issues/437 https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/518 Unfortunately this is not working when we use VKMS (upstream

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-08-03 Thread Leandro Ribeiro
ms_crtc.c:21 vkms_vblank_simulate+0x101/0x110 I've decided to share this info with you, as it may help you somehow. I'm also investigating to help understand what is happening. Thanks, Leandro Ribeiro On 7/31/20 1:47 PM, Melissa Wen wrote: On 07/31, Sidong Yang wrote: On Fri, Jul 31, 2020 a

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-08-03 Thread Leandro Ribeiro
:21 vkms_vblank_simulate+0x101/0x110 From what I've read from this thread it seems like this is not the right fix, but I've decided to share this info with you anyway, as it may help. I'm also trying to understand what is happening. Thanks, Leandro Ribeiro On 7/31/20 1:47 PM, Melissa Wen

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-08-03 Thread Leandro Ribeiro
vkms_vblank_simulate+0x101/0x110 I've decided to share this info with you, as it may help you somehow. I'm also investigating to help understand what is happening. Thanks, Leandro Ribeiro On 7/31/20 1:47 PM, Melissa Wen wrote: On 07/31, Sidong Yang wrote: On Fri, Jul 31, 2020 at 11:08:34AM

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-31 Thread Leandro Ribeiro
:21 vkms_vblank_simulate+0x101/0x110 From what I've read from this thread it seems like this is not the right fix, but I've decided to share this info with you anyway, as it may help. I'm also trying to understand what is happening. Thanks, Leandro Ribeiro On 7/31/20 3:33 PM, Daniel Vetter

[PATCH] drm/doc: Update IGT documentation

2019-10-29 Thread Leandro Ribeiro
eir GitLab README, which should always be up to date. Signed-off-by: Leandro Ribeiro --- Documentation/gpu/drm-uapi.rst | 32 ++-- 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst index 94