Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

On 2024-04-16 10:10, Harry Wentland wrote: On 2024-04-16 04:01, Pekka Paalanen wrote: On Mon, 15 Apr 2024 18:33:39 -0400 Leo Li wrote: On 2024-04-15 04:19, Pekka Paalanen wrote: On Fri, 12 Apr 2024 16:14:28 -0400 Leo Li wrote: On 2024-04-12 11:31, Alex Deucher wrote: On Fri

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

On 2024-04-15 04:19, Pekka Paalanen wrote: On Fri, 12 Apr 2024 16:14:28 -0400 Leo Li wrote: On 2024-04-12 11:31, Alex Deucher wrote: On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen wrote: On Fri, 12 Apr 2024 10:28:52 -0400 Leo Li wrote: On 2024-04-12 04:03, Pekka Paalanen wrote

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

On 2024-04-12 11:31, Alex Deucher wrote: On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen wrote: On Fri, 12 Apr 2024 10:28:52 -0400 Leo Li wrote: On 2024-04-12 04:03, Pekka Paalanen wrote: On Thu, 11 Apr 2024 16:33:57 -0400 Leo Li wrote: ... That begs the question of what can

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

On 2024-04-12 04:03, Pekka Paalanen wrote: On Thu, 11 Apr 2024 16:33:57 -0400 Leo Li wrote: On 2024-04-04 10:22, Marius Vlad wrote: On Thu, Apr 04, 2024 at 09:59:03AM -0400, Harry Wentland wrote: Hi all, On 2024-04-04 06:24, Pekka Paalanen wrote: On Wed, 3 Apr 2024 17:32:46 -0400

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

On 2024-04-04 10:22, Marius Vlad wrote: On Thu, Apr 04, 2024 at 09:59:03AM -0400, Harry Wentland wrote: Hi all, On 2024-04-04 06:24, Pekka Paalanen wrote: On Wed, 3 Apr 2024 17:32:46 -0400 Leo Li wrote: On 2024-03-28 10:33, Pekka Paalanen wrote: On Fri, 15 Mar 2024 13:09:56 -0400

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

On 2024-03-28 10:33, Pekka Paalanen wrote: On Fri, 15 Mar 2024 13:09:56 -0400 wrote: From: Leo Li These patches aim to make the amdgpgu KMS driver play nicer with compositors when building multi-plane scanout configurations. They do so by: 1. Making cursor behavior more sensible. 2

Re: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

On 2024-03-28 11:52, Harry Wentland wrote: On 2024-03-28 11:48, Robert Mader wrote: Hi, On 15.03.24 18:09, sunpeng...@amd.com wrote: From: Leo Li [Why] DCN is the display hardware for amdgpu. DRM planes are backed by DCN hardware pipes, which carry pixel data from one end (memory

Re: [regression][6.0] After commit b261509952bc19d1012cf732f853659be6ebc61e I see WARNING message at drivers/gpu/drm/drm_modeset_lock.c:276 drm_modeset_drop_locks+0x63/0x70

this commit: b261509952bc19d1012cf732f853659be6ebc61e. b261509952bc19d1012cf732f853659be6ebc61e is the first bad commit commit b261509952bc19d1012cf732f853659be6ebc61e Author: Leo Li Date: Tue Aug 30 16:38:16 2022 -0400 drm/amd/display: Fix double cursor on non-video RGB MPO [Why]

Re: [PATCH v2 10/21] drm/amd/display: Signal mode_changed if colorspace changed

: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua Ashton Cc: dri-devel@lists.freedesktop.org Cc: amd-...@lists.freedesktop.org Reviewed-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff

Re: [PATCH v2 17/21] drm/amd/display: Format input and output CSC matrix

...@amd.com Cc: Joshua Ashton Cc: dri-devel@lists.freedesktop.org Cc: amd-...@lists.freedesktop.org Reviewed-by: Leo Li --- .../drm/amd/display/dc/core/dc_hw_sequencer.c | 38 - drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h | 54 +++ 2 files changed, 56 insertions

Re: [PATCH v2] drm/amd/display: fix PSR-SU/DSC interoperability support

On 1/5/23 15:07, Hamza Mahfooz wrote: On 1/5/23 13:29, Harry Wentland wrote: On 1/5/23 12:38, Hamza Mahfooz wrote: Currently, there are issues with enabling PSR-SU + DSC. This stems from the fact that DSC imposes a slice height on transmitted video data and we are not conforming to that

Re: [PATCH v2] drm/amd/display: add FB_DAMAGE_CLIPS support

in fill_dc_dirty_rects(). Signed-off-by: Hamza Mahfooz Thanks for the patch, it LGTM. Reviewed-by: Leo Li It would be good to add an IGT case to cover combinations of MPO & damage clip commits. Perhaps something that covers the usecase of moving a MPO video, while desktop UI updates. We'd expect th

Re: [PATCH] drm/amd/display: add FB_DAMAGE_CLIPS support

On 11/15/22 15:24, Hamza Mahfooz wrote: Currently, userspace doesn't have a way to communicate selective updates to displays. So, enable support for FB_DAMAGE_CLIPS for DCN ASICs newer than DCN301, convert DRM damage clips to dc dirty rectangles and fill them into dirty_rects in

Re: [PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

() that are only useful for debugging PSR (and confusing otherwise). So, we can instead limit the filling of dirty rectangles to only when PSR is enabled. Signed-off-by: Hamza Mahfooz Reviewed-by: Leo Li Thanks --- v2: give a more concrete reason. --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7

RE: [BUG] ls1046a: eDMA does not transfer data from I2C

> > > > Despite the DMA completing successfully, no data was copied into the > > buffer, leaving the original (now junk) contents. I probed the I2C bus > > with an oscilloscope, and I verified that the transfer did indeed occur. > > The timing between submission and completion seems reasonable for

RE: [BUG] ls1046a: eDMA does not transfer data from I2C

> -Original Message- > From: Sean Anderson > Sent: Tuesday, September 20, 2022 11:21 AM > To: Robin Murphy ; Oleksij Rempel > ; Pengutronix Kernel Team > ; linux-...@vger.kernel.org; linux-arm-kernel > ; Vinod Koul ; > dmaeng...@vger.kernel.org; Leo Li ; Lauren

RE: [BUG] ls1046a: eDMA does not transfer data from I2C

> ; Linux Kernel Mailing List ker...@vger.kernel.org>; linux-me...@vger.kernel.org; dri- > de...@lists.freedesktop.org; linaro-mm-...@lists.linaro.org; Joy Zou > ; Peng Ma ; Robin Gong > ; Shawn Guo ; Leo Li > > Subject: [BUG] ls1046a: eDMA does not transfer data from I2C &

Re: [PATCH] drm: Get ref on CRTC commit object when waiting for flip_done

On 2018-10-12 03:34 AM, Daniel Vetter wrote: On Thu, Oct 11, 2018 at 08:27:43PM -0400, sunpeng...@amd.com wrote: From: Leo Li This fixes a general protection fault, caused by accessing the contents of a flip_done completion object that has already been freed. It occurs due to the preemption

Re: [PATCH 01/21] drm/amdgpu: Remove default best_encoder hook from DC

481 ("drm/amd/display: Use DRM helper for best_encoder"). Cc: Ville Syrjälä Signed-off-by: Daniel Vetter Cc: Alex Deucher Cc: Harry Wentland Cc: Andrey Grodzovsky Cc: Tony Cheng Cc: "Leo (Sunpeng) Li" Cc: Shirish S Acked-by: Harry Wentland Thx for rebasing :) Review

Re: [PATCH 08/14] drm/amdgpu: Remove default best_encoder hook from DC

On 2018-09-03 12:54 PM, Daniel Vetter wrote: For atomic driver this is the default, no need to reimplement it. We still need to keep the copypasta for not-atomic drivers though, since no one polished the legacy crtc helpers as much as the atomic ones. Thanks for the patch! It seems I made an

Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled

On 2018-08-11 11:54 AM, Arnd Bergmann wrote: Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions that do a comparison of floating-point variables:

Re: [bug report] drm/amd/display: Read AUX channel even if only status byte is returned

On 2018-07-31 02:24 PM, Dan Carpenter wrote: [ Potential security issue, if I'm reading the code correctly. I don't really know the code and I haven't looked at the larger context. -dan ] Hello Leo (Sunpeng) Li, The patch edf6ffe4f47e: "drm/amd/display: Read AUX channel even if only

Re: [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

we already gets as part of verify_crc_source. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-by: Leo Li --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 4

Re: [PATCH 04/10] drm/amdgpu_dm/crc: Implement verify_crc_source callback

On 2018-07-03 06:19 AM, Maarten Lankhorst wrote: Op 02-07-18 om 13:07 schreef Mahesh Kumar: This patch implements "verify_crc_source" callback function for AMD drm driver. Signed-off-by: Mahesh Kumar Cc: dri-devel@lists.freedesktop.org Reviewed-by: Maarten Lankhorst Acked-

Re: [Intel-gfx] [PATCH] drm/atomic: Fix memleak on ERESTARTSYS during non-blocking commits

Updated IGT results seem sane: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7698/shards.html Would someone be able to apply this patch? Thanks, Leo On 2018-01-17 03:18 PM, Sean Paul wrote: On Wed, Jan 17, 2018 at 10:39 AM, Maarten Lankhorst wrote: Op

Re: Non-blocking commits on -ERESTARTSYS

On 2017-12-13 02:24 PM, Leo Li wrote: On 2017-12-13 12:23 PM, Maarten Lankhorst wrote: Op 13-12-17 om 17:19 schreef Leo Li: Hi Daniel, Maarten, Just digging an old thread out of the grave: https://lists.freedesktop.org/archives/dri-devel/2017-August/150495.html It's suppose to fix

Re: Non-blocking commits on -ERESTARTSYS

On 2017-12-13 12:23 PM, Maarten Lankhorst wrote: Op 13-12-17 om 17:19 schreef Leo Li: Hi Daniel, Maarten, Just digging an old thread out of the grave: https://lists.freedesktop.org/archives/dri-devel/2017-August/150495.html It's suppose to fix a memory leak on the drm_commit object during