ed.
Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
Cc: Christian Brauner
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/panthor/panthor_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panthor/panthor_drv.c
b/drivers/gpu/drm/panthor
and we have to hold the VM resv lock when
> calling this function.
>
> Fixes: 647810ec2476 ("drm/panthor: Add the MMU/VM logical block")
> Signed-off-by: Boris Brezillon
Looks good to me!
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/pant
gt; > drm_info() so that it's obvious from a dmesg log which firmware binary
> > is being used.
> >
> > Signed-off-by: Steven Price
>
> Just one formatting issue mentioned below, looks good otherwise.
>
> Reviewed-by: Boris Brezillon
Reviewed-by: Liviu Dud
; Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
> Cc:
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
the driver frontend block")
> Cc: Matthew Brost
> Cc: Simona Vetter
> Cc:
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
calc_profiling_ringbuf_num_slots(group->ptdev,
> args->ringbuf_size);
> +
> + queue->profiling_info.slots =
> + panthor_kernel_bo_create(group->ptdev, group->vm,
> + queue->profiling_info.slot_count *
> +
Hi Adrián,
On Sat, Aug 17, 2024 at 11:10:17AM +0200, Boris Brezillon wrote:
> On Fri, 16 Aug 2024 19:52:49 +0100
> Adrián Larumbe wrote:
>
> > In the off-chance that waiting for the firmware to signal its booted status
> > timed out in the fast reset path, one must flush the cache lines for the
On Tue, Aug 27, 2024 at 06:48:52PM +0530, Aryabhatta Dey wrote:
> Change 'indenpendently' to 'independently'.
>
> Signed-off-by: Aryabhatta Dey
Acked-by: Liviu Dudau
Thanks for the patch!
Jonathan, is that something you can pick up in your tree?
Best regards,
k_input returns a -EINVAL value.
>
> To fix the bug described above, when calculating the max_slave_zorder
> with the layer_split enabled, count the split layer in this calculation
> directly.
>
> Signed-off-by: hongchi.peng
Acked-by: Liviu Dudau
Thanks for the patch, I will push it into
}
>
> crtc_st->zpos_changed = true;
> --
> 2.34.1
>
> Best Regards,
> Hongchi Peng
Also, can you version your patches to help me track them better?
Best regards,
Liviu
>
> -邮件原件-
> 发件人: Liviu Dudau
> 发送时间: 2024年8月22日 22:05
> 收件人: Peng Hong
Hi Hongchi,
On Wed, Aug 21, 2024 at 04:56:13PM +0800, hongchi.peng wrote:
> We use komeda_crtc_normalize_zpos to normalize zpos of affected planes
> to their blending zorder in CU. If there's only one slave plane in
> affected planes and its layer_split property is enabled, order++ for
> its split
ise stale
> values eventually lead to a scheduler job timeout.
>
> Signed-off-by: Adrián Larumbe
Looks good to me!
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 8 +++-
> drivers/gpu/drm/panthor/panthor_mmu.c | 19 +++
es a preferred color mode of 32. As this
> is the default if no format has been given, leave it out entirely.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 4 +++-
> 1
es a preferred color mode of 32. As this
> is the default if no format has been given, leave it out entirely.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 4 +++-
> 1 file changed, 3 insertions(+), 1
es a preferred color mode of 32. As this
> is the default if no format has been given, leave it out entirely.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++--
> drivers/gpu/drm/ar
On Wed, Jul 10, 2024 at 07:50:06PM -0300, Daniel Almeida wrote:
> Dump the state of the GPU. This feature is useful for debugging purposes.
> ---
> Hi everybody!
Hi Daniel,
I know this is an RFC, but are you trying to avoid Cc-ing Panthor maintainers
by mistake or by choice? I will be away on sab
> Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
> Signed-off-by: Steven Price
Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/panthor/panthor_sched.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panthor/pa
On Sat, Jun 29, 2024 at 10:52:56AM +0200, Boris Brezillon wrote:
> On Fri, 28 Jun 2024 22:34:57 +0100
> Liviu Dudau wrote:
>
> > On Fri, Jun 28, 2024 at 04:55:36PM +0200, Boris Brezillon wrote:
> > > A sync-only job is meant to provide a synchronization point on a
> &g
b->done_fence;
What happens if the last job's done_fence was cancelled or timed out? Is the
sync job's done_fence going to be signalled with the same error?
Now that we're returning a fence here, should the job be also added into the
in_flight_jobs?
If you're happy with depending on t
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c
> b/drivers/gpu/drm
gt; is actually tested for both CONFIG_DEBUG_FS configuration values.
> Assuming most developers have it enabled, CONFIG_DEBUG_FS=n is not tested
> much and may fail the build due to the conditional compilation.
>
> Reported-by: k2ci
> Signed-off-by: pengfuyuan
Acked-by: Liviu
On Thu, Jun 06, 2024 at 11:20:58AM +0300, Jani Nikula wrote:
> On Thu, 06 Jun 2024, pengfuyuan wrote:
> > We do not call komeda_debugfs_init() and the debugfs core function
> > declaration if CONFIG_DEBUG_FS is not defined, but we should not
> > compile it either because the debugfs core function
On Thu, May 16, 2024 at 02:37:24PM +0100, li...@treblig.org wrote:
> From: "Dr. David Alan Gilbert"
>
> 'gamma_curve_segment' looks like it has never been used.
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert
Acked-by: Liviu Dudau
Thanks
...)
> if (!timeout) return -ETIMEDOUT;
>
> with all kinds of permutations. Check the return value directly to drop
> 'timeout' which also fixes its wrong type.
>
> Signed-off-by: Wolfram Sang
Acked-by: Liviu Dudau
I will change the subject line to s
On Thu, May 02, 2024 at 11:02:53PM +0200, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout'
> to
> store the result of wait_for_completion_timeout() causing patterns like:
>
> timeout = wait_for_completion_timeout(...)
> if (!timeout) r
llon
Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/panthor/panthor_device.c | 7 +--
> drivers/gpu/drm/panthor/panthor_sched.c | 19 ++-
> drivers/gpu/drm/panthor/panthor_sched.h | 2 +-
> 3 files changed, 16 insertions(+), 12 deletions(-)
>
>
n
>
> Reviewed-by: Steven Price
Acked-by: Liviu Dudau
>
> > ---
> > drivers/gpu/drm/panthor/panthor_fw.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c
> > b/drivers/gpu/drm/panthor/panthor_fw
On Thu, May 02, 2024 at 08:38:10PM +0200, Boris Brezillon wrote:
> Avoids use-after-free situations when panthor_fw_unplug() is called
> and the kernel BO was mapped to the FW VM.
>
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/panthor/pa
On Thu, May 02, 2024 at 08:38:09PM +0200, Boris Brezillon wrote:
> If the FW reports an unrecoverable fault, we need to reset the GPU
> before we can start re-using it again.
>
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/panthor/pan
patch
>
> Signed-off-by: Boris Brezillon
> Reviewed-by: Steven Price
Reviewed-by: Liviu Dudau
> ---
> include/uapi/drm/panthor_drm.h | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm
> Fixes: 9cca48fa4f89 ("drm/panthor: Add the heap logical block")
> Reported-by: Eric Smith
> Signed-off-by: Boris Brezillon
> Tested-by: Eric Smith
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_heap.c | 5 +++--
> 1 file changed
manually writing DISABLE to the MCU_CONTROL register.
>
> Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block")
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 7 ---
> 1 file changed, 4 insertions(+),
On Tue, Apr 30, 2024 at 01:28:52PM +0200, Boris Brezillon wrote:
> ID 0 is reserved to encode 'no-tiler-heap', the heap ID range is
> [1:MAX_HEAPS_PER_POOL], which we occasionally need to turn into an index
> in the [0:MAX_HEAPS_PER_POOL-1] when we want to access the context object.
>
> v2:
> - Ne
gned-off-by: Boris Brezillon
With the typo that Adrián mentioned fixed,
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_heap.c | 8
> include/uapi/drm/panthor_drm.h | 6 +-
> 2 files changed, 9 insertions(+), 5 deletions(-)
&
INVAL;
> +
Is is just me that feels like a lost opportunity to merge the check with the
one above?
if (!initial_chunk_count || initial_chunk_count > max_chunks)
return -EINVAL;
Otherwise, Reviewed-by: Liviu Dudau
Best regards,
Liviu
> if (hweight32(c
grow() return -ENOMEM for all kind of allocation
> failures
> - Document the panthor_heap_grow() semantics
>
> Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
> Signed-off-by: Antonino Maniscalco
> Signed-off-by: Boris Brezillon
Reviewed-by:
On Thu, Apr 25, 2024 at 12:39:20PM +0200, Boris Brezillon wrote:
> We can use upd_ctx.timedout_mask directly, and the faulty_slots update
> in the flush_caches_failed situation is never used.
>
> Suggested-by: Suggested-by: Steven Price
> Signed-off-by: Boris Brezillon
Reviewed-
fferently: how are your
words describing your code change here?
>
> Also, we consider a PRIME imported BO to be resident if its matching
> dma_buf has an open attachment, which means its backing storage had already
> been allocated.
Reviewed-by: Liviu Dudau
Best regards,
Liviu
>
_OP_MAP_NOEXEC |
> +
> DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED,
> +
> PANTHOR_VM_KERNEL_AUTO_VA);
> + if (IS_ERR(group->syncobjs.bo)) {
> + ret = PTR_ERR(group->syncobjs.bo);
> goto err_put_group;
> }
>
> - ret = panthor_kernel_bo_vmap(group->syncobjs);
> + ret = panthor_kernel_bo_vmap(group->syncobjs.bo);
> if (ret)
> goto err_put_group;
>
> - memset(group->syncobjs->kmap, 0,
> -group_args->queues.count * sizeof(struct panthor_syncobj_64b));
> + memset(group->syncobjs.bo->kmap, 0, syncobj_bo_size);
> +
> + group->syncobjs.times_offset =
> + group_args->queues.count * sizeof(struct panthor_syncobj_64b);
>
> - for (i = 0; i < group_args->queues.count; i++) {
> - group->queues[i] = group_create_queue(group, &queue_args[i]);
> + for (i = 0, total_slots = 0; i < group_args->queues.count; i++) {
> + group->queues[i] = group_create_queue(group, &queue_args[i],
> total_slots);
> if (IS_ERR(group->queues[i])) {
> ret = PTR_ERR(group->queues[i]);
> group->queues[i] = NULL;
> goto err_put_group;
> }
>
> + total_slots += (queue_args[i].ringbuf_size / (SLOTSIZE));
> group->queue_count++;
> }
>
> --
> 2.44.0
>
With those comments addressed,
Reviewed-by: Liviu Dudau
Best regards,
Liviu
--
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---
¯\_(ツ)_/¯
e calling
> __drm_atomic_helper_connector_reset.
>
> Fixes: 8cbc5caf36ef ("drm: mali-dp: Add writeback connector")
> Signed-off-by: Huai-Yuan Liu
Reviewed-by: Liviu Dudau
Thanks for the patch. I will pull it into drm-misc-fixes before the end of the
week.
Best regards,
Liviu
> ---
> V2:
> * In
Hi,
On Wed, Apr 03, 2024 at 09:43:01AM +0800, Huai-Yuan Liu wrote:
>
> In malidp_mw_connector_reset, new memory is allocated with kzalloc, but
> no check is performed. In order to prevent null pointer dereferencing,
> ensure that mw_state is checked before calling
> __drm_atomic_helper_connect
When compiling with W=1 the build process will flag empty comments,
misnamed documented variables and incorrect tagging of functions.
Fix them in one go.
Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block")
Cc: Boris Brezillon
Cc: Steven Price
Signed-off-by: L
irq_suspend/resume()")
Cc: Boris Brezillon
Cc: Steven Price
Signed-off-by: Liviu Dudau
---
drivers/gpu/drm/panthor/panthor_device.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/panthor/panthor_device.h
b/drivers/gpu/drm/panthor/panthor_device.h
index dc3e9c666b5bd
Hi Adrián,
Appologies for the delay in reviewing this.
On Tue, Mar 05, 2024 at 09:05:49PM +, Adrián Larumbe wrote:
> These values are sampled by the firmware right before jumping into the UM
> command stream and immediately after returning from it, and then kept inside a
> per-job accounting
from the _unplug() functions, which we don't want.
>
> v3:
> - New patch
>
> Fixes: 5fe909cae118 ("drm/panthor: Add the device logical block")
> Signed-off-by: Boris Brezillon
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/pant
pend() is called.
>
> v3:
> - Add Steve's R-b
>
> v2:
> - New patch
>
> Fixes: 5fe909cae118 ("drm/panthor: Add the device logical block")
> Reported-by: Steven Price
> Signed-off-by: Boris Brezillon
> Reviewed-by: Steven Price
Acked-by: Liviu Dudau
vice_mmio_offset()
> helper.
>
> v3:
> - No changes
>
> v2:
> - Kill panthor_device_mmio_offset()
>
> Fixes: 5fe909cae118 ("drm/panthor: Add the device logical block")
> Reported-by: Adrián Larumbe
> Reported-by: Lukas F. Hartmann
> Closes: https://gitlab.freedesktop.o
On Tue, Mar 26, 2024 at 10:02:19AM +, Colin Ian King wrote:
> There is a spelling mistake in a drm_err message. Fix it.
>
> Signed-off-by: Colin Ian King
Acked-by: Liviu Dudau
Boris, can you also pick this one up when you're pushing your kernel doc fix?
Best
On Tue, Mar 26, 2024 at 10:30:55AM +0100, Boris Brezillon wrote:
> The kernel doc prefix is /** not /*.
>
> Reported-by: Stephen Rothwell
> Signed-off-by: Boris Brezillon
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> include/uapi/drm/panthor_drm.h | 4 ++--
&g
On Mon, Mar 25, 2024 at 07:02:13PM +0100, Boris Brezillon wrote:
> On Mon, 25 Mar 2024 17:16:16 +
> Liviu Dudau wrote:
>
> > On Mon, Mar 25, 2024 at 02:57:04PM +0100, Boris Brezillon wrote:
> > > Make sure we set suspended=true last to avoid generating an irq storm
&g
On Mon, Mar 25, 2024 at 02:57:05PM +0100, Boris Brezillon wrote:
> panthor_xxx_irq_suspend() doesn't mask the interrupts if drm_dev_unplug()
> has been called, which is always the case when our panthor_xxx_unplug()
> helpers are called. Fix that by introducing a panthor_xxx_unplug() helper
> that d
On Mon, Mar 25, 2024 at 02:57:04PM +0100, Boris Brezillon wrote:
> Make sure we set suspended=true last to avoid generating an irq storm
> in the unlikely case where an IRQ happens between the suspended=true
> assignment and the _INT_MASK update.
>
> v2:
> - New patch
>
> Reported-by: Steven Pric
re are no realistic platforms to test where you can enable panthor
but disable runtime power management. All our emulator configuration are
based on Juno (ARCH_VEXPRESS) which select CONFIG_PM.
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_device.c | 1
> Signed-off-by: Thomas Zimmermann
> Cc: Liviu Dudau
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_
On Mon, Mar 11, 2024 at 05:52:59PM +0200, Jani Nikula wrote:
> On Mon, 11 Mar 2024, Liviu Dudau wrote:
> > On Mon, Mar 11, 2024 at 04:49:30PM +0200, Jani Nikula wrote:
> >> On Mon, 11 Mar 2024, Liviu Dudau wrote:
> >> > So with this revert we're OK with an
On Mon, Mar 11, 2024 at 04:49:30PM +0200, Jani Nikula wrote:
> On Mon, 11 Mar 2024, Liviu Dudau wrote:
> > On Mon, Mar 11, 2024 at 02:26:50PM +0200, Jani Nikula wrote:
> >> On Mon, 11 Mar 2024, Boris Brezillon wrote:
> >> > On Mon, 11 Mar 2024 13:51:46 +
n PCI_MSI
> >> >> drivers/pci/Kconfig:39: symbol PCI_MSI is selected by AMD_IOMMU
> >> >> drivers/iommu/amd/Kconfig:3:symbol AMD_IOMMU depends on
> >> >> IOMMU_SUPPORT
> >> >> For a resolution refer to Documentation/kbuild/kconfig-langu
On Fri, Mar 08, 2024 at 04:15:15PM +0100, Boris Brezillon wrote:
> On Fri, 8 Mar 2024 13:52:18 +
> Liviu Dudau wrote:
>
> > Hi Adrián,
> >
> > Thanks for the patch and appologies for taking a bit longer to respond,
> > I was trying to gather some inte
Hi Adrián,
Thanks for the patch and appologies for taking a bit longer to respond,
I was trying to gather some internal Arm feedback before replying.
On Tue, Mar 05, 2024 at 04:58:16PM +, Adrián Larumbe wrote:
> This brings in support for Panthor's HW performance counters and querying
> them
Hi Faiz,
On Mon, Feb 19, 2024 at 03:39:13PM +0530, Faiz Abbas wrote:
> Since commit f7936d6beda9 ("drm/arm/komeda: Remove component framework and
> add a simple encoder"), the devm_drm_of_get_bridge() call happens
> regardless of whether any remote nodes are available on the pipeline. Fix
> this b
On Mon, Mar 04, 2024 at 10:08:10AM +0100, Boris Brezillon wrote:
> Missing '*' to have a valid kerneldoc prefix.
>
> Reported-by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202403031019.6jvroqgt-...@intel.com/
> Signed-off-by: Boris Brezillon
LGTM :)
Best regards,
Liv
n sparc64 possible because of 'depends on COMPILE_TEST'?
Otherwise it doesn't make sense to try to build this for any arch other
than arm[64].
Regardless, patch looks harmless, so
Reviewed-by: Liviu Dudau
Best regards,
Liviu
>
> Reported-by: kernel test robot
> Closes:
&g
_PM with a Kconfig dependency instead.
>
> If someone needs to relax this dependency, it can be done in a follow-up.
>
> Reported-by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202403031944.eoimq8wk-...@intel.com/
> Signed-off-by: Boris Brezillon
R
Hi Faiz,
On Mon, Feb 19, 2024 at 03:39:12PM +0530, Faiz Abbas wrote:
> The following patches add fixes to the komeda DPU driver.
>
> Patch 1 fixes an issue where the crtc always expects both pipelines to
> always have remote nodes populated.
>
> Patch 2 is a cosmetic fix that ensures komeda does
rm/panthor: Add the MMU/VM logical block
> drm/panthor: Add the FW logical block
> drm/panthor: Add the heap logical block
> drm/panthor: Add the scheduler logical block
> drm/panthor: Add the driver frontend block
> drm/panthor: Allow driver compilation
> dr
ned-off-by: Boris Brezillon
> Acked-by: Steven Price # MIT+GPL2 relicensing,Arm
> Acked-by: Grant Likely # MIT+GPL2 relicensing,Linaro
> Acked-by: Boris Brezillon # MIT+GPL2
> relicensing,Collabora
Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/panthor/panthor_gem.c |
On Thu, Feb 08, 2024 at 05:00:23PM +0100, Boris Brezillon wrote:
> On Thu, 8 Feb 2024 15:55:36 +
> Liviu Dudau wrote:
>
> > On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote:
> > > On Thu, 8 Feb 2024 14:30:02 +
> > > Liviu Duda
lock
> drm/panthor: Add the MMU/VM logical block
> drm/panthor: Add the FW logical block
> drm/panthor: Add the heap logical block
> drm/panthor: Add the scheduler logical block
> drm/panthor: Add the driver frontend block
> drm/panthor: Allow driver compil
On Thu, Feb 08, 2024 at 04:14:59PM +0100, Boris Brezillon wrote:
> On Thu, 8 Feb 2024 14:30:02 +
> Liviu Dudau wrote:
>
> > > +int panthor_device_init(struct panthor_device *ptdev)
> > > +{
> > > + struct resource *res;
> > > + struct page *p;
>
VM_DONTDUMP | VM_PFNMAP);
> + return 0;
> +}
> +
> +#ifdef CONFIG_PM
> +int panthor_device_resume(struct device *dev)
> +{
> + struct panthor_device *ptdev = dev_get_drvdata(dev);
> + int ret, cookie;
> +
> + if (atomic_read(&ptdev->pm.state) !=
this state, all new MAP operations will be
> + * rejected, and any GPU job targeting this VM will fail.
> + * UNMAP operations are still accepted.
> + *
> + * The only way to recover from an unusable VM is to create a new
> + * VM, and destroy
Hi Boris,
On Mon, Dec 04, 2023 at 06:32:56PM +0100, Boris Brezillon wrote:
> The panthor driver is designed in a modular way, where each logical
> block is dealing with a specific HW-block or software feature. In order
> for those blocks to communicate with each other, we need a central
> panthor_
on # MIT+GPL2
> relicensing,Collabora
Hello,
Just some small name mismatch spotted here.
Otherwise,
Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 1454 +
> 1 file changed, 1454 insertions(+)
> create mode 100644 drivers/gpu/drm/
On Mon, Dec 04, 2023 at 06:33:01PM +0100, Boris Brezillon wrote:
> Contains everything that's FW related, that includes the code dealing
> with the microcontroller unit (MCU) that's running the FW, and anything
> related to allocating memory shared between the FW and the CPU.
>
> A few global FW e
Hi Rob,
Thanks for reviewing this!
On Tue, Dec 05, 2023 at 02:48:27PM -0600, Rob Herring wrote:
> On Mon, Dec 04, 2023 at 06:33:06PM +0100, Boris Brezillon wrote:
> > From: Liviu Dudau
> >
> > Arm has introduced a new v10 GPU architecture that replaces the Job Manager
>
On Sun, Oct 01, 2023 at 02:21:43PM +0200, Hans de Goede wrote:
> Hi,
>
> On 10/1/23 13:47, Kai Uwe Broulik wrote:
> > The One Mix 2S is a mini laptop with a 1200x1920 portrait screen
> > mounted in a landscape oriented clamshell case. Because of the too
> > generic DMI strings this entry is also d
On Wed, Sep 20, 2023 at 03:51:36PM +0200, Krzysztof Kozlowski wrote:
> On 20/09/2023 15:41, Liviu Dudau wrote:
> >>> +properties:
> >>> + $nodename:
> >>> +pattern: '^gpu@[a-f0-9]+$'
> >>> +
> >>> + compatible:
> >
On Wed, Sep 20, 2023 at 03:56:24PM +0200, Boris Brezillon wrote:
> On Wed, 20 Sep 2023 14:41:05 +0100
> Liviu Dudau wrote:
>
> > >
> > > Please describe also power domains - constrains and names.
> >
> > I'm not sure the power domains and how to ha
Hi Krzysztof,
Thanks for taking the time to review this patch. I'm about to update it
to address your comments and I need some clarifications from you.
On Sun, Aug 20, 2023 at 10:01:25AM +0200, Krzysztof Kozlowski wrote:
> On 09/08/2023 18:53, Boris Brezillon wrote:
> > Fro
On Wed, Aug 30, 2023 at 02:17:57PM +0100, Steven Price wrote:
> On 29/08/2023 15:00, Boris Brezillon wrote:
> > On Fri, 11 Aug 2023 16:47:56 +0100
> > Steven Price wrote:
> >
> >> On 09/08/2023 17:53, Boris Brezillon wrote:
> >>> The panthor driver is designed in a modular way, where each logical
> +
> + /** @id: Returned VM ID. */
> + __u32 id;
> +
> + /**
> + * @kernel_va_range: Size of the VA space reserved for kernel objects.
> + *
> + * If kernel_va_range is zero, we pick half of the VA space for kernel
> objects.
> + *
esktop.org/drm/drm-misc
> +F: drivers/gpu/drm/panthor/
> +F: include/uapi/drm/panthor_drm.h
Can we also add an entry for the bindings?
+F: Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
Also, I would like to volunteer as maintainer alongside Steven, so can I
please get a
quot;)
> Signed-off-by: Gaosheng Cui
> Reviewed-by: Liviu Dudau
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_stat
for the delay in replying, I thought I already did. Patch looks good
and thanks for the effort.
Reviewed-by: Liviu Dudau
I'm going to pull this into drm-misc-next by the end of the week.
Best regards,
Liviu
> ---
> v3 -> v2:
> * Rebased to latest drm-misc-next
>
> v2
arm/malidp_drv.c
> index c03cfd57b752..a5a9534d4353 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -12,6 +12,7 @@
> #include
> #include
> #include
> +#include
> #include
> #include
>
For the komeda and mal
>
> Let me know if there's anything I can do, thanks for your work again!
>
> Gaosheng,
>
> On 2023/7/13 16:54, Liviu Dudau wrote:
> > Hello,
> >
> > On Thu, Jul 13, 2023 at 10:05:56AM +0800, Gaosheng Cui wrote:
> > > The komeda_pipeline_get
mishandling the return value from komeda_pipeline_get_state(). If
IS_ERR(st) is
true it should use return ERR_CAST(st), following the same pattern as
komeda_pipeline_get_state().
If you don't want to update this patch I can send a separate patch. Otherwise,
the change looks good to me.
Re
Hi Faiz,
On Tue, Jul 04, 2023 at 10:04:54PM +0530, Faiz Abbas wrote:
> The Komeda driver always expects the remote connector node to initialize
> an encoder. It uses the component aggregator framework which consists
> of component->bind() calls used to initialize the remote encoder and attach
> it
On Tue, Jul 04, 2023 at 01:05:27AM +0200, Javier Martinez Canillas wrote:
> Otherwise if CONFIG_DRM is disabled, menuconfig will show an empty menu.
>
> Signed-off-by: Javier Martinez Canillas
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
>
> (no changes since v1)
>
Hi Faiz,
Thanks for the patch and for addressing what was at some moment on my "nice to
improve / cleanup" list. Sorry for the delay in responding, I had to revive
the bits of an old setup to be able to test this properly, with 2 encoders
attached.
On Wed, Jun 21, 2023 at 02:11:16PM +0530, Faiz A
ve got Cc-ed because of a comment, but I did have a look at the
whole
patch. If it is useful, then you can add
Reviewed-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_crtc.c | 2 +-
> drivers/gpu/drm/drm_atomic_uapi.c | 43 ---
>
ays returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git
ays returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König
Acked-by: Liviu Dudau
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git
ays returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König
Acked-by: Liviu Dudau
Thanks for the clean up!
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 5 ++---
> 1 file changed, 2 insertion
On Mon, Apr 03, 2023 at 05:22:01PM -0700, Matthew Brost wrote:
> Hello,
Hello,
Jumping a bit late on this thread as I was waiting on some approvals and then
holidays kicked in, but I would like to (re)introduce myself and the people
I work with and to let you know that we are interested in the ch
On Wed, Mar 15, 2023 at 09:34:37AM +, Steven Price wrote:
> On 13/03/2023 10:22, patrik.bergl...@arm.com wrote:
> > From: Patrik Berglund
> >
> > The Arm Morello board EDK2 port already provides an EFI GOP display for
> > Ceti/Cetus (Komeda) with more boards incoming.
> > However, once the Ko
(), as this is exactly
> what this function does.
>
> Since 'struct platform_device *pdev = to_platform_device(dev)',
> 'pdev->dev' is equivalent to 'dev'.
>
> Signed-off-by: Yang Li
Acked-by: Liviu Dudau
Thanks for the cleanup! I will pu
s is exactly what this function
> does.
>
> Since 'struct platform_device *pdev = to_platform_device(drm->dev)',
> 'drm->dev' is equivalent to 'pdev->deva'.
>
> Signed-off-by: Yang Li
Acked-by: Liviu Dudau
Thanks for cleaning this up!
B
r_show.cocci Coccinelle script.
>
> Signed-off-by: Deepak R Varma
Acked-by: Liviu Dudau
I will push the change into drm-misc-next by the end of the week.
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
amp;pdev->dev, &match, malidp_compare_dev,
> -port);
> - of_node_put(port);
> + component_match_add_of(&pdev->dev, &match, port);
> return component_master_add_with_match(&pdev->dev, &malidp_master_ops,
>
1 - 100 of 985 matches
Mail list logo
