Re: [PATCH] PCI: qcom: Fix compile error

2023-11-28 Thread Manivannan Sadhasivam
On Tue, Nov 28, 2023 at 12:39:02PM +0200, Jani Nikula wrote: > On Tue, 28 Nov 2023, Manivannan Sadhasivam > wrote: > > On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: > >> Hi Mani, > >> > >> On 28/11/23 10:44, Manivannan Sadhasivam wrote: &g

Re: [PATCH] PCI: qcom: Fix compile error

2023-11-27 Thread Manivannan Sadhasivam
On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote: > Hi Mani, > > On 28/11/23 10:44, Manivannan Sadhasivam wrote: > > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argum

Re: [PATCH] PCI: qcom: Fix compile error

2023-11-27 Thread Manivannan Sadhasivam
On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote: > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument > to acquire bus lock") has added an argument to acquire bus lock > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it > without this argument, resulting

Re: [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog

2023-10-31 Thread Manivannan Sadhasivam
On Mon, Oct 30, 2023 at 04:23:20PM -0700, Bjorn Andersson wrote: > During USB transfers on the SC8280XP __arm_smmu_tlb_sync() is seen to > typically take 1-2ms to complete. As expected this results in poor > performance, something that has been mitigated by proposing running the > iommu in

Re: [PATCH v2 0/2] Add MHI quirk for QAIC

2023-08-02 Thread Manivannan Sadhasivam
On Mon, Jun 26, 2023 at 11:15:56AM -0600, Jeffrey Hugo wrote: > On 6/8/2023 5:59 AM, Manivannan Sadhasivam wrote: > > On Fri, May 19, 2023 at 10:39:00AM -0600, Jeffrey Hugo wrote: > > > With the QAIC driver in -next, I'd like to suggest some MHI changes that > > >

Re: [PATCH v2 0/2] Add MHI quirk for QAIC

2023-06-08 Thread Manivannan Sadhasivam
On Fri, May 19, 2023 at 10:39:00AM -0600, Jeffrey Hugo wrote: > With the QAIC driver in -next, I'd like to suggest some MHI changes that > specific to AIC100 devices, but perhaps provide a framework for other > device oddities. > > AIC100 devices technically violate the MHI spec in two ways.

Re: [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-29 Thread Manivannan Sadhasivam
On Mon, May 29, 2023 at 09:38:59AM +0200, Konrad Dybcio wrote: > > > On 28.05.2023 19:07, Manivannan Sadhasivam wrote: > > On Tue, May 23, 2023 at 09:59:53AM +0200, Konrad Dybcio wrote: > >> > >> > >> On 23.05.2023 03:15, Bjorn Andersson wrote: > >

Re: [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-28 Thread Manivannan Sadhasivam
On Tue, May 23, 2023 at 09:59:53AM +0200, Konrad Dybcio wrote: > > > On 23.05.2023 03:15, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the > > SC8280XP. > > > > Signed-off-by: Bjorn Andersson > > Signed-off-by: Bjorn

Re: [PATCH v4 3/8] accel/qaic: Add MHI controller

2023-03-27 Thread Manivannan Sadhasivam
On Fri, Mar 24, 2023 at 09:26:49AM -0600, Jeffrey Hugo wrote: > On 3/24/2023 4:26 AM, Manivannan Sadhasivam wrote: > > On Mon, Mar 20, 2023 at 09:11:09AM -0600, Jeffrey Hugo wrote: > > > An AIC100 device contains a MHI interface with a number of different > > > channel

Re: [PATCH v4 3/8] accel/qaic: Add MHI controller

2023-03-24 Thread Manivannan Sadhasivam
On Mon, Mar 20, 2023 at 09:11:09AM -0600, Jeffrey Hugo wrote: > An AIC100 device contains a MHI interface with a number of different > channels for controlling different aspects of the device. The MHI > controller works with the MHI bus to enable and drive that interface. > > AIC100 uses the BHI

Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-07 Thread Manivannan Sadhasivam
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by > moving