RE: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h

2023-07-09 Thread Michael Kelley (LINUX)
From: Sui Jingfeng Sent: Sunday, July 9, 2023 3:05 AM > >drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem': > >> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared > >> (first use > in this function) > 1033 | base = screen_info.lfb_base; >

RE: [PATCH v2 RESEND 4/7] swiotlb: Dynamically allocated bounce buffers

2023-05-15 Thread Michael Kelley (LINUX)
From: Petr Tesarik Sent: Tuesday, May 9, 2023 2:18 AM > > The software IO TLB was designed with the assumption that it is not > used much, especially on 64-bit systems, so a small fixed memory > area (currently 64 MiB) is sufficient to handle the few cases which > still require a bounce buffer.

RE: [PATCH v2 031/101] fbdev/hyperv_fb: Duplicate video-mode option string

2023-03-12 Thread Michael Kelley (LINUX)
From: Thomas Zimmermann Sent: Thursday, March 9, 2023 8:01 AM > > Assume that the driver does not own the option string or its substrings > and hence duplicate the option string for the video mode. As the driver > implements a very simple mode parser in a fairly unstructured way, just >

RE: [PATCH 08/18] fbdev/hyperv-fb: Do not set struct fb_info.apertures

2022-12-29 Thread Michael Kelley (LINUX)
From: Thomas Zimmermann Sent: Monday, December 19, 2022 8:05 AM > > Generic fbdev drivers use the apertures field in struct fb_info to > control ownership of the framebuffer memory and graphics device. Do > not set the values in hyperv-fb. > > Signed-off-by: Thomas Zimmermann > --- >

RE: [PATCH] drm/hyperv: Don't overwrite dirt_needed value set by host

2022-09-22 Thread Michael Kelley (LINUX)
From: Saurabh Sengar Sent: Monday, September 12, 2022 8:33 AM > > Existing code is causing a race condition where dirt_needed value is > already set by the host and gets overwritten with default value. Remove > this default setting of dirt_needed, to avoid overwriting the value > received in

RE: [PATCH] drm/hyperv: Add ratelimit on error message

2022-09-10 Thread Michael Kelley (LINUX)
From: Saurabh Sengar Sent: Friday, September 9, 2022 8:10 AM > > Due to a full ring buffer, the driver may be unable to send updates to > the Hyper-V host. But outputing the error message can make the problem > worse because console output is also typically written to the frame > buffer. >

RE: [PATCH] drm/hyperv: Don't rely on screen_info.lfb_base for Gen1 VMs

2022-09-10 Thread Michael Kelley (LINUX)
From: Saurabh Sengar Sent: Friday, September 9, 2022 7:44 AM > > hyperv_setup_vram tries to remove conflicting framebuffer based on > 'screen_info'. As observed in past due to some bug or wrong setting > in grub, the 'screen_info' fields may not be set for Gen1, and in such > cases

RE: [PATCH v2 3/3] Drivers: hv: Never allocate anything besides framebuffer from framebuffer memory region

2022-08-25 Thread Michael Kelley (LINUX)
From: Vitaly Kuznetsov Sent: Thursday, August 25, 2022 2:00 AM > > Passed through PCI device sometimes misbehave on Gen1 VMs when Hyper-V > DRM driver is also loaded. Looking at IOMEM assignment, we can see e.g. > > $ cat /proc/iomem > ... > f800-fffb : PCI Bus :00 >

RE: [PATCH v2 2/3] Drivers: hv: Always reserve framebuffer region for Gen1 VMs

2022-08-25 Thread Michael Kelley (LINUX)
From: Vitaly Kuznetsov Sent: Thursday, August 25, 2022 2:00 AM > > vmbus_reserve_fb() tries reserving framebuffer region iff > 'screen_info.lfb_base' is set. Gen2 VMs seem to have it set by EFI fb Just so I'm clear, by "EFI fb" you mean the EFI layer code that sets up the frame buffer before

RE: [PATCH v2 1/3] PCI: Move PCI_VENDOR_ID_MICROSOFT/PCI_DEVICE_ID_HYPERV_VIDEO definitions to pci_ids.h

2022-08-25 Thread Michael Kelley (LINUX)
From: Vitaly Kuznetsov Sent: Thursday, August 25, 2022 2:00 AM > > There are already three places in kernel which define PCI_VENDOR_ID_MICROSOFT > and two for PCI_DEVICE_ID_HYPERV_VIDEO and there's a need to use these > from core Vmbus code. Move the defines where they belong. > > No

RE: [PATCH v1 3/4] Drivers: hv: Always reserve framebuffer region for Gen1 VMs

2022-08-23 Thread Michael Kelley (LINUX)
From: Vitaly Kuznetsov Sent: Thursday, August 18, 2022 7:25 AM > > vmbus_reserve_fb() tries reserving framebuffer region iff > screen_info.lfb_base is set. Gen2 VMs seem to have it set by EFI fb > but on Gen1 VM it is observed to be zero. FWIW, in a Gen1 VM, whether screen_info.lfb_base is

RE: [PATCH v1 2/4] drm/hyperv: Don't forget to put PCI device when removing conflicting FB fails

2022-08-22 Thread Michael Kelley (LINUX)
From: Vitaly Kuznetsov Sent: Thursday, August 18, 2022 7:25 AM > > When drm_aperture_remove_conflicting_pci_framebuffers() fails, 'pdev' > needs to be released with pci_dev_put(). > > Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video > device") > Signed-off-by:

RE: [PATCH v1 1/4] Drivers: hv: Move legacy Hyper-V PCI video device's ids to linux/hyperv.h

2022-08-22 Thread Michael Kelley (LINUX)
From: Vitaly Kuznetsov Sent: Thursday, August 18, 2022 7:25 AM > > There are already two places in kernel with PCI_VENDOR_ID_MICROSOFT/ > PCI_DEVICE_ID_HYPERV_VIDEO and there's a need to use these from core > Vmbus code. Move the defines to a common header. > > No functional change. > >

RE: [PATCH] drm/hyperv: Fix an error handling path in hyperv_vmbus_probe()

2022-08-05 Thread Michael Kelley (LINUX)
From: Christophe JAILLET Sent: Sunday, July 31, 2022 1:02 PM > > hyperv_setup_vram() calls vmbus_allocate_mmio(). > This must be undone in the error handling path of the probe, as already > done in the remove function. > > This patch depends on commit a0ab5abced55 ("drm/hyperv : Removing the >

RE: [PATCH] fbdev: Fix order of arguments to aperture_remove_conflicting_devices()

2022-07-21 Thread Michael Kelley (LINUX)
From: Thomas Zimmermann Sent: Thursday, July 21, 2022 1:17 AM > > Reverse the order of the final two arguments when calling > aperture_remove_conflicting_devices(). An error report is available > at [1]. > > Reported-by: kernel test robot > Signed-off-by: Thomas Zimmermann > Fixes:

RE: [PATCH 0/4] Remove support for Hyper-V 2008 and 2008R2/Win7

2022-05-08 Thread Michael Kelley (LINUX)
From: Pavel Machek Sent: Wednesday, May 4, 2022 10:23 AM > > Hi! > > > Linux code for running as a Hyper-V guest includes special cases for the > > first released versions of Hyper-V: 2008 and 2008R2/Windows 7. These > > versions were very thinly used for running Linux guests when first > >

RE: [PATCH v2] hv: account for packet descriptor in maximum packet size

2022-01-27 Thread Michael Kelley (LINUX)
From: Yanming Liu Sent: Wednesday, January 19, 2022 12:14 PM > > On Thu, Jan 20, 2022 at 2:12 AM Michael Kelley (LINUX) > wrote: > > > > From: Wei Liu Sent: Friday, January 14, 2022 11:13 AM > > > > > > On Mon, Jan 10, 2022 at 01:44:19AM +0100, Andrea P

RE: [PATCH 1/1] video: hyperv_fb: Fix validation of screen resolution

2022-01-23 Thread Michael Kelley (LINUX)
From: Wei Liu Sent: Sunday, January 23, 2022 1:56 PM > > On Sun, Jan 16, 2022 at 09:53:06PM +, Haiyang Zhang wrote: > > > > > > > -Original Message- > > > From: Michael Kelley (LINUX) > > > Sent: Sunday, January 16, 2022 2:19 PM > &

RE: [PATCH v2] hv: account for packet descriptor in maximum packet size

2022-01-19 Thread Michael Kelley (LINUX)
From: Wei Liu Sent: Friday, January 14, 2022 11:13 AM > > On Mon, Jan 10, 2022 at 01:44:19AM +0100, Andrea Parri wrote: > > (Extending Cc: list,) > > > > On Sun, Jan 09, 2022 at 05:55:16PM +0800, Yanming Liu wrote: > > > Commit adae1e931acd ("Drivers: hv: vmbus: Copy packets sent by Hyper-V > >