Re: [PATCH 3/4] drm/meson: Enable DRM InfoFrame support on GXL, GXM and G12A

2019-06-26 Thread Neil Armstrong
On 24/06/2019 16:59, Andrzej Hajda wrote: > On 26.05.2019 23:20, Jonas Karlman wrote: >> This patch enables Dynamic Range and Mastering InfoFrame on GXL, GXM and >> G12A. >> >> Cc: Neil Armstrong >> Signed-off-by: Jonas Karlman >> --- >> drivers/

[PATCH] MAINTAINERS: Update Maintainers and Reviewers of DRM Bridge Drivers

2019-06-24 Thread Neil Armstrong
Add myself as co-maintainer of DRM Bridge Drivers then add Jonas Karlman and Jernej Škrabec as Reviewers of DRM Bridge Drivers. Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Andrzej Hajda Cc: Jernej Škrabec Cc: Daniel Vetter Signed-off-by: Neil Armstrong --- MAINTAINERS | 3 +++ 1 file

Re: [PATCH 0/4] drm/bridge: dw-hdmi: Add support for HDR metadata

2019-06-24 Thread Neil Armstrong
Hi Daniel, Laurent, Andrzej, On 24/06/2019 01:30, Laurent Pinchart wrote: > On Fri, Jun 21, 2019 at 11:01:25AM +0200, Daniel Vetter wrote: >> On Thu, Jun 20, 2019 at 04:40:12PM +0200, Neil Armstrong wrote: >>> Hi Andrzej, >>> >>> Gentle ping, could you review

Re: [PATCH 0/4] drm/bridge: dw-hdmi: Add support for HDR metadata

2019-06-20 Thread Neil Armstrong
Hi Andrzej, Gentle ping, could you review the dw-hdmi changes here ? Thanks, Neil On 26/05/2019 23:18, Jonas Karlman wrote: > Add support for HDR metadata using the hdr_output_metadata connector property, > configure Dynamic Range and Mastering InfoFrame accordingly. > > A drm_infoframe flag

Re: [PATCH] drm/bridge: dw-hdmi: Use automatic CTS generation mode when using non-AHB audio

2019-06-20 Thread Neil Armstrong
Hi Andrzej, Gentle ping, do you think this could go in drm-misc-next for 5.3 ? Thanks, Neil On 12/06/2019 10:51, Neil Armstrong wrote: > When using an I2S source using a different clock source (usually the I2S > audio HW uses dedicated PLLs, different from the HDMI PHY PLL), fixed > C

Re: [PATCH] drm/bridge/synopsys: dw-hdmi: Handle audio for more clock rates

2019-06-19 Thread Neil Armstrong
On 18/06/2019 19:23, Jernej Škrabec wrote: > Hi! > > Dne torek, 18. junij 2019 ob 01:55:58 CEST je Douglas Anderson napisal(a): >> Let's add some better support for HDMI audio to dw_hdmi. >> Specifically: >> >> 1. For 44.1 kHz audio the old code made the assumption that an N of >> 6272 was right

Re: [PATCH 20/59] drm/meson: Drop drm_gem_prime_export/import

2019-06-18 Thread Neil Armstrong
On 14/06/2019 22:35, Daniel Vetter wrote: > They're the default. > > Aside: Would be really nice to switch the others over to > drm_gem_object_funcs. Yep, adding this to my infinite TODO list > > Signed-off-by: Daniel Vetter > Cc: Neil Armstrong > Cc: Kevin

[PATCH] drm/bridge: dw-hdmi: Use automatic CTS generation mode when using non-AHB audio

2019-06-12 Thread Neil Armstrong
MI Databook explains : If "CTS_manual" bit equals 0b this registers contains "audCTS[19:0]" generated by the Cycle time counter according to specified timing. Cc: Jernej Skrabec Cc: Maxime Ripard Cc: Jonas Karlman Cc: Heiko Stuebner Cc: Jerome Brunet Signed-off-by: Neil Armstrong

Re: [PATCH 2/5] drm/bridge: add encoder support to specify bridge input format

2019-06-07 Thread Neil Armstrong
On 07/06/2019 15:38, Laurent Pinchart wrote: > Hi Neil, > > Thank you for the patch. > > On Mon, May 20, 2019 at 03:37:50PM +0200, Neil Armstrong wrote: >> This patch adds a new format_set() callback to the bridge ops permitting >> the encoder to specify the ne

Re: [PATCH] drm/meson: fix G12A HDMI PLL settings for 4K60 1000/1001 variations

2019-06-07 Thread Neil Armstrong
On 06/06/2019 18:30, Kevin Hilman wrote: > Neil Armstrong writes: > >> The Amlogic G12A HDMI PLL needs some specific settings to lock with >> different fractional values for the 5,4GHz mode. >> >> Handle the 1000/1001 variation fractional case here to avoid having

Re: [PATCH 1/2] drm/meson: fix primary plane disabling

2019-06-07 Thread Neil Armstrong
On 06/06/2019 19:25, Kevin Hilman wrote: > Neil Armstrong writes: > >> The primary plane disable logic is flawed, when the primary plane is >> disabled, it is re-enabled in the vsync irq when another plane is updated. >> >> Handle the plane disabling correctly

Re: [PATCH 2/2] drm/meson: fix G12A primary plane disabling

2019-06-07 Thread Neil Armstrong
On 06/06/2019 19:30, Kevin Hilman wrote: > Neil Armstrong writes: > >> The G12A Primary plane was disabled by writing in the OSD1 configuration >> registers, but this caused the plane blender to stall instead of continuing >> blended only the overlay plane. >

[PATCH v2] drm/panfrost: make devfreq optional again

2019-06-05 Thread Neil Armstrong
Devfreq runtime usage was made mandatory, thus making panfrost fail to probe on Amlogic S912 SoCs missing the "operating-points-v2" property. Make it optional again, leaving PM_DEVFREQ selected by default. Fixes: f3617b449d ("drm/panfrost: Select devfreq") Signed-of

[PATCH 2/2] drm/meson: fix G12A primary plane disabling

2019-06-05 Thread Neil Armstrong
. Fixes: 490f50c109d1 ("drm/meson: Add G12A support for OSD1 Plane") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_crtc.c | 2 ++ drivers/gpu/drm/meson/meson_plane.c | 4 ++-- drivers/gpu/drm/meson/meson_viu.c | 3 +-- 3 files changed, 5 insertions(+), 4 deletions(-)

[PATCH 1/2] drm/meson: fix primary plane disabling

2019-06-05 Thread Neil Armstrong
09d1 ("drm/meson: Add G12A support for OSD1 Plane") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_crtc.c | 4 drivers/gpu/drm/meson/meson_plane.c | 4 +++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_crtc.c b/drivers

[PATCH 0/2] drm/meson: fix primary plane disabling

2019-06-05 Thread Neil Armstrong
The primary plane disabling logic is broken on all supported Amlogic SoCs, and the G12A primary plane disable register write is wrong. This patchset solves thse issues, and has been tested with the Baylibre ffmpeg-drm tool and modetest. Neil Armstrong (2): drm/meson: fix primary plane

Re: [PATCH 1/5] drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2019-06-05 Thread Neil Armstrong
On 22/05/2019 08:07, Andrzej Hajda wrote: > On 20.05.2019 15:37, Neil Armstrong wrote: >> Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support >> for these modes in the connector if the platform supports them. >> We limit these modes to DW-HDMI IP ve

Re: [PATCH 1/4] drm/bridge: dw-hdmi: Add Dynamic Range and Mastering InfoFrame support

2019-06-05 Thread Neil Armstrong
0x1201 > #define HDMI_FC_DBGAUD1CH0 0x1202 > @@ -746,6 +778,11 @@ enum { > HDMI_FC_PRCONF_OUTPUT_PR_FACTOR_MASK = 0x0F, > HDMI_FC_PRCONF_OUTPUT_PR_FACTOR_OFFSET = 0, > > +/* FC_PACKET_TX_EN field values */ > + HDMI_FC_PACK

Re: [PATCH 3/4] drm/meson: Enable DRM InfoFrame support on GXL, GXM and G12A

2019-06-05 Thread Neil Armstrong
On 26/05/2019 23:20, Jonas Karlman wrote: > This patch enables Dynamic Range and Mastering InfoFrame on GXL, GXM and G12A. > > Cc: Neil Armstrong > Signed-off-by: Jonas Karlman > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 5 + > 1 file changed, 5 insertions(+) >

[PATCH] drm/meson: fix G12A HDMI PLL settings for 4K60 1000/1001 variations

2019-06-05 Thread Neil Armstrong
Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_vclk.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_vclk.c b/drivers/gpu/drm/meson/meson_vclk.c index 44250eff8a3f..83fc2fc82001 100644 --- a/drivers/gpu/drm/meson/meson_vc

Re: [PATCH] drm/panfrost: make devfreq optional again

2019-06-05 Thread Neil Armstrong
On 03/06/2019 21:54, Ezequiel Garcia wrote: > On Fri, 2019-05-31 at 14:37 +0200, Neil Armstrong wrote: >> Devfreq runtime usage was made mandatory, thus making panfrost fail to probe >> on Amlogic S912 SoCs missin the "operating-points-v2" property. >> Make it opt

[PATCH] drm/panfrost: make devfreq optional again

2019-05-31 Thread Neil Armstrong
Devfreq runtime usage was made mandatory, thus making panfrost fail to probe on Amlogic S912 SoCs missin the "operating-points-v2" property. Make it optional again, leaving PM_DEVFREQ is selected by default. Fixes: f3617b449d ("drm/panfrost: Select devfreq") Signed-of

Re: Panfrost impossible to probe without opp table

2019-05-31 Thread Neil Armstrong
On 31/05/2019 14:09, Tomeu Vizoso wrote: > On Fri, 31 May 2019 at 14:03, Neil Armstrong wrote: >> >> Hi Tomeu, >> >> On 31/05/2019 13:59, Tomeu Vizoso wrote: >>> On Wed, 29 May 2019 at 23:29, Clément Péron wrote: >>>> >>>> Hi, >>

Re: Panfrost impossible to probe without opp table

2019-05-31 Thread Neil Armstrong
Hi Tomeu, On 31/05/2019 13:59, Tomeu Vizoso wrote: > On Wed, 29 May 2019 at 23:29, Clément Péron wrote: >> >> Hi, >> >> I have rebase my kernel on latest 5.2-rc2, and my panfrost driver is >> no more probing. >> >> The issue is coming from f3617b449d0bcf3b5d80a97f51498dcf7463cf7e >>

Re: [PATCH] drm/meson: imply dw-hdmi i2s audio for meson hdmi

2019-05-24 Thread Neil Armstrong
ers/gpu/drm/meson/Kconfig > @@ -14,3 +14,4 @@ config DRM_MESON_DW_HDMI > depends on DRM_MESON > default y if DRM_MESON > select DRM_DW_HDMI > + imply DRM_DW_HDMI_I2S_AUDIO > Reviewed-by: Neil Armstrong And applying to drm-misc-next Thanks, Neil __

[PATCH] drm/meson: update with SPDX Licence identifier

2019-05-20 Thread Neil Armstrong
Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_crtc.c | 15 +-- drivers/gpu/drm/meson/meson_crtc.h | 15 +-- drivers/gpu/drm/meson/meson_drv.c | 15 +-- drivers/gpu/drm/meson/meson_drv.h | 14 +- drivers/gpu/drm

[PATCH 5/5] drm/meson: Output in YUV444 if sink supports it

2019-05-20 Thread Neil Armstrong
. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index 5d67e2beba58..8bf9db7f39a4 100644 --- a/drivers/gpu/drm

[PATCH 2/5] drm/bridge: add encoder support to specify bridge input format

2019-05-20 Thread Neil Armstrong
-by: Neil Armstrong --- drivers/gpu/drm/drm_bridge.c | 35 +++ include/drm/drm_bridge.h | 19 +++ 2 files changed, 54 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 138b2711d389..33be74a977f7 100644

[PATCH 0/5] drm/meson: Add support for HDMI2.0 YUV420 4k60

2019-05-20 Thread Neil Armstrong
set() * rebased on v5.2-rc1 Neil Armstrong (5): drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a drm/bridge: add encoder support to specify bridge input format drm/bridge: dw-hdmi: Add support for dynamic output format setup drm/meson: Add YUV420 output support drm/meson:

[PATCH 3/5] drm/bridge: dw-hdmi: Add support for dynamic output format setup

2019-05-20 Thread Neil Armstrong
the YUV420 input bus format, enforcing YUV420 as output with the correct bit depth Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 121 -- 1 file changed, 112 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b

[PATCH 1/5] drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2019-05-20 Thread Neil Armstrong
Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support for these modes in the connector if the platform supports them. We limit these modes to DW-HDMI IP version >= 0x200a which are designed to support HDMI2.0 display modes. Signed-off-by: Neil Armstrong Tested-by: Heiko Stueb

[PATCH 4/5] drm/meson: Add YUV420 output support

2019-05-20 Thread Neil Armstrong
drm_bridge_format_set() for notify the bridge the input format has changed to YUV420. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 100 +++- drivers/gpu/drm/meson/meson_vclk.c | 93 -- drivers/gpu/drm/meson/meson_vclk.h | 7

Re: [PATCH] drm/panfrost: Select devfreq

2019-05-17 Thread Neil Armstrong
On 17/05/2019 17:00, Ezequiel Garcia wrote: > Currently, there is some logic for the driver to work without devfreq. > However, the driver actually fails to probe if !CONFIG_PM_DEVFREQ. > > Fix this by selecting devfreq, and drop the additional checks > for devfreq. > Please add a Fixes tag.

Re: [PATCH v4 0/8] Allwinner H6 Mali GPU support

2019-05-14 Thread Neil Armstrong
gpu compatible >> arm64: dts: allwinner: Add ARM Mali GPU node for H6 >> arm64: dts: allwinner: Add mali GPU supply for Pine H64 >> arm64: dts: allwinner: Add mali GPU supply for Beelink GS1 >> arm64: dts: allwinner: Add mali GPU supply for OrangePi Boards >

[PATCH] drm/meson: Add zpos immutable property to planes

2019-04-29 Thread Neil Armstrong
Add immutable zpos property to primary and overlay planes to specify the current fixed zpos position. Fixes: f9a2348196d1 ("drm/meson: Support Overlay plane for video rendering") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_overlay.c | 3 +++ drivers/gpu/drm/meson/mes

[PATCH] drm/meson: Add support for XBGR8888 & ABGR8888 formats

2019-04-29 Thread Neil Armstrong
Add missing XBGR & ABGR formats variants from the primary plane. Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_plane.c | 16 1 file changed, 16 insertions(

Re: [PATCH] drm/bridge: dw-hdmi: fix SCDC configuration for ddc-i2c-bus

2019-04-23 Thread Neil Armstrong
poser(struct dw_hdmi *hdmi, > hdmi_writeb(hdmi, 0, HDMI_FC_SCRAMBLER_CTRL); > hdmi_writeb(hdmi, (u8)~HDMI_MC_SWRSTZ_TMDSSWRST_REQ, > HDMI_MC_SWRSTZ); > - drm_scdc_set_scrambling(>i2c->adap, 0); &g

Re: [PATCH] drm/meson: add size and alignment requirements for dumb buffers

2019-04-17 Thread Neil Armstrong
On 16/04/2019 12:20, Sky Zhou wrote: > > On 2019/4/8 17:01, Neil Armstrong wrote: >> The Amlogic SoCs Canvas buffers stride must be aligned on 64bytes >> and overall size should be aligned on PAGE width. >> >> Adds a custom dumb_create op to adds these requireme

Re: [PATCH -next] drm/meson: Make some functions static

2019-04-17 Thread Neil Armstrong
On 16/04/2019 13:23, Neil Armstrong wrote: > > > Le 13/04/2019 16:14, Yue Haibing a écrit : >> From: YueHaibing >> >> Fix sparse warnings: >> >> drivers/gpu/drm/meson/meson_viu.c:93:6: warning: symbol >> 'meson_viu_set_g12a_osd1_matrix' was not decl

Re: [PATCH -next] drm/meson: Make some functions static

2019-04-16 Thread Neil Armstrong
bool csc_on) > +static void > +meson_viu_set_osd_lut(struct meson_drm *priv, enum viu_lut_sel_e lut_sel, > + unsigned int *r_map, unsigned int *g_map, > + unsigned int *b_map, bool csc_on) > { > unsigned int addr_port; > unsigned int data_port; > Acked-by: Neil Armstrong ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/tinydrm: Fix fbdev pixel format

2019-04-10 Thread Neil Armstrong
return 0; > } > diff --git a/drivers/gpu/drm/tinydrm/st7735r.c > b/drivers/gpu/drm/tinydrm/st7735r.c > index 022e9849b95b..ce9109e613e0 100644 > --- a/drivers/gpu/drm/tinydrm/st7735r.c > +++ b/drivers/gpu/drm/tinydrm/st7735r.c > @@ -207,7 +207,7 @@ static int st7735r_probe(struct spi_device *spi) > > spi_set_drvdata(spi, drm); > > - drm_fbdev_generic_setup(drm, 32); > + drm_fbdev_generic_setup(drm, 0); > > return 0; > } > Reviewed-by: Neil Armstrong ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH RFC 2/5] drm/bridge: add encoder support to specify bridge input format

2019-04-09 Thread Neil Armstrong
Hi Laurent, On 29/03/2019 11:42, Neil Armstrong wrote: > This patch adds a new format_set() callback to the bridge ops permitting > the encoder to specify the new input format and encoding. Is this something better ? This doesn't violate the layering anymore, do you have any thoughts

Re: [PATCH 09/11] drm/meson: Add G12A Video Clock setup

2019-04-09 Thread Neil Armstrong
On 09/04/2019 10:46, Jerome Brunet wrote: > On Mon, 2019-03-25 at 15:18 +0100, Neil Armstrong wrote: >> While switching to the Common Clock Framework is still Work In Progress, >> this patch adds the corresponding G12A HDMI PLL setup to be on-par >> with the other SoCs suppor

Re: [PATCH 06/11] drm/meson: Add G12A Support for the Overlay video plane

2019-04-09 Thread Neil Armstrong
On 09/04/2019 10:42, Jerome Brunet wrote: > On Mon, 2019-03-25 at 15:18 +0100, Neil Armstrong wrote: >> Amlogic G12A SoC supports the same set of Video Planes, but now >> are handled by the new OSD plane blender module. >> >> This patch uses the same VD1 plane for G12A,

Re: [PATCH 04/11] drm/meson: Add G12A Support for VIU setup

2019-04-09 Thread Neil Armstrong
On 09/04/2019 10:42, Jerome Brunet wrote: > On Mon, 2019-03-25 at 15:18 +0100, Neil Armstrong wrote: >> Amlogic G12A SoC needs a different VIU setup code, >> handle it. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/gpu/drm/meson/meson_viu.c | 72 +++

Re: [PATCH 08/11] drm/meson: Add G12A support for CVBS Encoer

2019-04-09 Thread Neil Armstrong
On 09/04/2019 10:44, Jerome Brunet wrote: > On Tue, 2019-04-09 at 10:43 +0200, Jerome Brunet wrote: >> On Mon, 2019-03-25 at 15:18 +0100, Neil Armstrong wrote: >>> The Meson G12A SoCs uses the exact same CVBS encoder except a simple >>> CVBS DAC register offset and set

Re: [PATCH 08/11] drm/meson: Add G12A support for CVBS Encoer

2019-04-09 Thread Neil Armstrong
On 09/04/2019 10:43, Jerome Brunet wrote: > On Mon, 2019-03-25 at 15:18 +0100, Neil Armstrong wrote: >> The Meson G12A SoCs uses the exact same CVBS encoder except a simple >> CVBS DAC register offset and settings delta. >> >> Signed-off-by: Neil Armstrong >&

Re: [PATCH 07/11] drm/meson: Add G12A support for plane handling in CRTC driver

2019-04-09 Thread Neil Armstrong
On 09/04/2019 10:43, Jerome Brunet wrote: > On Mon, 2019-03-25 at 15:18 +0100, Neil Armstrong wrote: >> This patch adds support for the new OSD+VD Plane blending module >> in the CRTC code by adding the G12A code to manage the blending >> module and setting the right OSD1

Re: [PATCH 0/3] dt-bindings: meson: Add G12A display bindings

2019-04-09 Thread Neil Armstrong
On 13/03/2019 15:10, Neil Armstrong wrote: > This patchset adds the G12A specific bindings for the Display VPU > and VPU Power Control. > > The Amlogic Meson G12A Display module is based on the Meson GXM SoC > with an updated Plane Blender, thus VPU architecture and interconnec

Re: [PATCH 00/11] drm/meson: Add G12A Support

2019-04-09 Thread Neil Armstrong
Hi, On 09/04/2019 10:42, Jerome Brunet wrote: > On Mon, 2019-03-25 at 15:18 +0100, Neil Armstrong wrote: >> The Amlogic G12A SoC offers very close Video Display >> functionnalities with it's older GXBB, GXL & GXM predecessors. >> >> The main differences are : >

Re: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU

2019-04-09 Thread Neil Armstrong
On 08/04/2019 21:07, Rob Herring wrote: > On Sun, Apr 7, 2019 at 5:17 AM Neil Armstrong wrote: >> >> Hi Rob, >> >> Le 01/04/2019 13:24, Neil Armstrong a écrit : >>> On 01/04/2019 12:00, Steven Price wrote: >>>> On 01/04/2019 09:09, Neil Armstro

Re: [PATCH 1/2] drm/lima: add missing Kconfig dependency

2019-04-09 Thread Neil Armstrong
On 09/04/2019 02:36, Qiang Yu wrote: > Current implementation does not support MMU-less > plarforms. > > Cc: Randy Dunlap You could also add : Suggested-by: Randy Dunlap Like patch 2. But you can fix it while applying it > Cc: Neil Armstrong > Fixes: a1d2a6339961 ("d

Re: [PATCH 2/2] drm/lima: include used header file explicitly

2019-04-09 Thread Neil Armstrong
On 09/04/2019 02:36, Qiang Yu wrote: > To prevent build fail on some platform which does > not have it in the include file chain. > > Cc: Neil Armstrong > Suggested-by: Randy Dunlap > Fixes: a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs") > Signed-off-by:

Re: [Lima] [PATCH -next] MAINTAINERS: mark lima mailing list as moderated

2019-04-08 Thread Neil Armstrong
d. Signed-off-by: Randy Dunlap Cc: Qiang Yu Cc: dri-devel@lists.freedesktop.org Cc: l...@lists.freedesktop.org Signed-off-by: Qiang Yu Link: https://patchwork.freedesktop.org/patch/msgid/9138d8e8-5390-0650-9bc3-050b869e9...@infradead.org Reviewed-by: Neil Armstrong &g

Re: [PATCH] drm/lima: fix build on MMU-less platform

2019-04-08 Thread Neil Armstrong
On 08/04/2019 14:20, Qiang Yu wrote: > On Mon, Apr 8, 2019 at 7:56 PM Neil Armstrong wrote: >> >> Hi, >> >> On 08/04/2019 13:26, Qiang Yu wrote: >>> Feedback from kbuild robot: >>> config: sh-allyesconfig (attached as .config) >>> compiler: sh

Re: [Lima] [PATCH -next] MAINTAINERS: mark lima mailing list as moderated

2019-04-08 Thread Neil Armstrong
On 08/04/2019 03:37, Qiang Yu wrote: > Looks good for me, patch is: > Reviewed-by: Qiang Yu Also: Reviewed-by: Neil Armstrong > > Should I apply this patch to drm-misc in this case? Or this patch will be > submitted in other kernel tree and back merged to drm-misc? You can p

Re: [PATCH] drm/lima: fix build on MMU-less platform

2019-04-08 Thread Neil Armstrong
Hi, On 08/04/2019 13:26, Qiang Yu wrote: > Feedback from kbuild robot: > config: sh-allyesconfig (attached as .config) > compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > lima_gem.c:(.text+0x6c): undefined reference to `vmf_insert_mixed' > > Cc: Randy Dunlap > Signed-off-by: Qiang Yu

[PATCH] drm/meson: add size and alignment requirements for dumb buffers

2019-04-08 Thread Neil Armstrong
The Amlogic SoCs Canvas buffers stride must be aligned on 64bytes and overall size should be aligned on PAGE width. Adds a custom dumb_create op to adds these requirements. Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") Suggested-by: Sky Zhou Signed-of

Re: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU

2019-04-07 Thread Neil Armstrong
Hi Rob, Le 01/04/2019 13:24, Neil Armstrong a écrit : > On 01/04/2019 12:00, Steven Price wrote: >> On 01/04/2019 09:09, Neil Armstrong wrote: >>> Add the bindings for the Bifrost family of ARM Mali GPUs. >>> >>> The Bifrost GPU architect

Re: [PATCH] Documentation/gpu/meson: Remove link to meson_canvas.c

2019-04-05 Thread Neil Armstrong
On 04/04/2019 16:31, Sean Paul wrote: > On Thu, Apr 04, 2019 at 10:28:29AM +0200, Neil Armstrong wrote: >> On 04/04/2019 08:56, Neil Armstrong wrote: >>> On 03/04/2019 22:56, Sean Paul wrote: >>>> From: Sean Paul >>>> >>>> The file wa

[PATCH] Revert "Documentation/gpu/meson: Remove link to meson_canvas.c"

2019-04-04 Thread Neil Armstrong
This reverts commit a3f98bb22cbfaaf67717e156f79e2bfeb42d4cac. Patch "Documentation/gpu/meson: Remove link to meson_canvas.c" was incorrectly applied on the wrong branch not containing the fixed commit 2bf6b5b0e374 ("drm/meson: exclusively use the canvas provider module")

Re: [PATCH] Documentation/gpu/meson: Remove link to meson_canvas.c

2019-04-04 Thread Neil Armstrong
On 04/04/2019 08:56, Neil Armstrong wrote: > On 03/04/2019 22:56, Sean Paul wrote: >> From: Sean Paul >> >> The file was removed in the below patch and is causing this error: >> WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno -function >>

Re: [PATCH] Documentation/gpu/meson: Remove link to meson_canvas.c

2019-04-04 Thread Neil Armstrong
code > > Fixes: 2bf6b5b0e374 ("drm/meson: exclusively use the canvas provider module") > Cc: Maxime Jourdan > Cc: Neil Armstrong > Cc: Kevin Hilman > Cc: dri-devel@lists.freedesktop.org > Cc: linux-amlo...@lists.infradead.org > Cc: linux-arm-ker...@lists.infradead.org &

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Neil Armstrong
On 02/04/2019 11:08, Daniel Vetter wrote: > On Tue, Apr 02, 2019 at 10:55:24AM +0200, Neil Armstrong wrote: >> Hi Sean, >> >> On 26/03/2019 21:44, Sean Paul wrote: >>> From: Sean Paul >>> >>> This patch adds a new drm helper library to help driv

Re: [PATCH v2 1/5] drm: Add helpers to kick off self refresh mode in drivers

2019-04-02 Thread Neil Armstrong
Hi Sean, On 26/03/2019 21:44, Sean Paul wrote: > From: Sean Paul > > This patch adds a new drm helper library to help drivers implement > self refresh. Drivers choosing to use it will register crtcs and > will receive callbacks when it's time to enter or exit self refresh > mode. > > In its

Re: [PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU

2019-04-01 Thread Neil Armstrong
On 01/04/2019 12:00, Steven Price wrote: > On 01/04/2019 09:09, Neil Armstrong wrote: >> Add the bindings for the Bifrost family of ARM Mali GPUs. >> >> The Bifrost GPU architecture is similar to the Midgard family, >> but with a different Shader Core & Execution En

Re: [PATCH v2 0/2] arm64: meson-gxm: Add support for the Mali T820 GPU

2019-04-01 Thread Neil Armstrong
On 15/03/2019 14:56, Neil Armstrong wrote: > This patchset adds : > - Optional reset properties in the midgard bindings > - Mali T820 Node in Amlogic Meson GXM DTSI > > Changes since v1: > - Updated midgard DT wording following the recently submitted > bifrost bindings >

Re: [PATCH v2 3/3] drm/panfrost: Add initial panfrost driver

2019-04-01 Thread Neil Armstrong
On 01/04/2019 09:47, Rob Herring wrote: > This adds the initial driver for panfrost which supports Arm Mali > Midgard and Bifrost family of GPUs. Currently, only the T860 and > T760 Midgard GPUs have been tested. > > v2: > - Add GPU reset on job hangs (Tomeu) > - Add RuntimePM and devfreq support

[PATCH v4] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU

2019-04-01 Thread Neil Armstrong
rate family needing separate bindings. The Bifrost GPUs are present in a number of recent SoCs, like the Amlogic G12A Family, and many other vendors. The Amlogic vendor specific compatible is added to handle the specific IP integration differences and dependencies. Signed-off-by: Neil Armst

Re: [Lima] [PATCH] MAINTAINERS: add drm/lima driver info

2019-03-29 Thread Neil Armstrong
> +F: drivers/gpu/drm/lima/ > +F: include/uapi/drm/lima_drm.h > +T: git git://anongit.freedesktop.org/drm/drm-misc > + > DRM DRIVERS FOR MEDIATEK > M: CK Hu > M: Philipp Zabel > Acked-by: Neil Armstrong ___ dri-de

[PATCH RFC 1/5] drm/bridge: dw-hdmi: allow ycbcr420 modes for >= 0x200a

2019-03-29 Thread Neil Armstrong
Now the DW-HDMI Controller supports the HDMI2.0 modes, enable support for these modes in the connector if the platform supports them. We limit these modes to DW-HDMI IP version >= 0x200a which are designed to support HDMI2.0 display modes. Signed-off-by: Neil Armstrong Tested-by: Heiko Stueb

[PATCH RFC 4/5] drm/meson: Add YUV420 output support

2019-03-29 Thread Neil Armstrong
drm_bridge_format_set() for notify the bridge the input format has changed to YUV420. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 100 +++- drivers/gpu/drm/meson/meson_vclk.c | 93 -- drivers/gpu/drm/meson/meson_vclk.h | 7

[PATCH RFC 2/5] drm/bridge: add encoder support to specify bridge input format

2019-03-29 Thread Neil Armstrong
-by: Neil Armstrong --- drivers/gpu/drm/drm_bridge.c | 35 +++ include/drm/drm_bridge.h | 19 +++ 2 files changed, 54 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 138b2711d389..b2ce2d3d070e 100644

[PATCH RFC 0/5] drm/meson: Add support for HDMI2.0 YUV420 4k60

2019-03-29 Thread Neil Armstrong
bus format. Only the meson DRM dw_hdmi glue allows ycbcr420 modes, so no breakage is expected here. The remaining patches adds support for 4:2:0 output and clock setup for the meson DW-HDMI glue, and how YUV444 output can be forced. Neil Armstrong (5): drm/bridge: dw-hdmi: allow ycbcr420 mo

[PATCH RFC 3/5] drm/bridge: dw-hdmi: Add support for dynamic output format setup

2019-03-29 Thread Neil Armstrong
the YUV420 input bus format, enforcing YUV420 as output with the correct bit depth Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 121 -- 1 file changed, 112 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b

[PATCH RFC 5/5] drm/meson: Output in YUV444 if sink supports it

2019-03-29 Thread Neil Armstrong
. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c index 5d67e2beba58..8bf9db7f39a4 100644 --- a/drivers/gpu/drm

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-28 Thread Neil Armstrong
On 27/03/2019 20:06, Eric Anholt wrote: > Neil Armstrong writes: > >> Hi, >> >> On 26/03/2019 21:40, Vasily Khoruzhick wrote: >>> Hi, >>> >>> So what's the status of it? >> >> We are waiting on ARM to give a feedback on the ARM GP

Re: [PATCH v8] drm/lima: driver for ARM Mali4xx GPUs

2019-03-27 Thread Neil Armstrong
gt;> - use get param interface to get info >>>>> - separate context create/free ioctl >>>>> - remove unused max sched task param >>>>> - update copyright time >>>>> - use xarray instead of idr >>>>> - stop using drmP.h

[PATCH 00/11] drm/meson: Add G12A Support

2019-03-25 Thread Neil Armstrong
the bindings found at [1]. [1] https://lkml.kernel.org/r/20190313141030.5958-1-narmstr...@baylibre.com Neil Armstrong (11): drm/meson: Switch PLL to 5.94GHz base for 297Mhz pixel clock drm/meson: Add registers for G12A SoC drm/meson: Add G12A Support for VPP setup drm/meson: Add G12A Sup

[PATCH 07/11] drm/meson: Add G12A support for plane handling in CRTC driver

2019-03-25 Thread Neil Armstrong
This patch adds support for the new OSD+VD Plane blending module in the CRTC code by adding the G12A code to manage the blending module and setting the right OSD1 & VD1 plane registers. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_crtc.c |

[PATCH 04/11] drm/meson: Add G12A Support for VIU setup

2019-03-25 Thread Neil Armstrong
Amlogic G12A SoC needs a different VIU setup code, handle it. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_viu.c | 72 --- 1 file changed, 67 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_viu.c b/drivers/gpu/drm/meson

[PATCH 06/11] drm/meson: Add G12A Support for the Overlay video plane

2019-03-25 Thread Neil Armstrong
Amlogic G12A SoC supports the same set of Video Planes, but now are handled by the new OSD plane blender module. This patch uses the same VD1 plane for G12A, using the exact same scaler and VD11 setup registers, except using the new blender register to disable the plane. Signed-off-by: Neil

[PATCH 01/11] drm/meson: Switch PLL to 5.94GHz base for 297Mhz pixel clock

2019-03-25 Thread Neil Armstrong
On Amlogic G12A SoC, the 2,97GHz PLL frequency is not stable enough to provide a correct 297MHz pixel clock, so switch the PLL base frequency with a /2 OD when the 297MHz pixel clock is requested. This solves the issue on G12A and also works fine on GXBB, GXL & GXM. Signed-off-by: Neil Armst

[PATCH 02/11] drm/meson: Add registers for G12A SoC

2019-03-25 Thread Neil Armstrong
This patch adds the new VPU registers added since the Amlogic GXM SoCs. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_registers.h | 247 1 file changed, 247 insertions(+) diff --git a/drivers/gpu/drm/meson/meson_registers.h b/drivers/gpu/drm/meson

[PATCH 09/11] drm/meson: Add G12A Video Clock setup

2019-03-25 Thread Neil Armstrong
the 5.94GHz DCO frequency. Apart that, it handle correctly all the other HDMI frequencies and can achieve even better DMT clock frequency precision with the larger fractional dividier width. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_vclk.c | 119

[PATCH 10/11] drm/meson: Add G12A compatible

2019-03-25 Thread Neil Armstrong
Finally add the Amlogic G12A SoC compatible for the VPU driver. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 079d22299d78..faf1b1b0357c 100644

[PATCH 11/11] drm/meson: Add G12A support for the DW-HDMI Glue

2019-03-25 Thread Neil Armstrong
ding exact same support as the previous GXBB, GXL & GXM SoCs. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 163 -- drivers/gpu/drm/meson/meson_dw_hdmi.h | 32 - 2 files changed, 157 insertions(+), 38 deletions(-) diff --git a/drivers

[PATCH 08/11] drm/meson: Add G12A support for CVBS Encoer

2019-03-25 Thread Neil Armstrong
The Meson G12A SoCs uses the exact same CVBS encoder except a simple CVBS DAC register offset and settings delta. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_venc.c | 11 +-- drivers/gpu/drm/meson/meson_venc_cvbs.c | 25 ++--- 2 files changed

[PATCH 05/11] drm/meson: Add G12A support for OSD1 Plane

2019-03-25 Thread Neil Armstrong
-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_plane.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c index b7786218cb10..bf8f1fab63aa 100644 --- a/drivers/gpu/drm/meson/meson_plane.c

[PATCH 03/11] drm/meson: Add G12A Support for VPP setup

2019-03-25 Thread Neil Armstrong
Amlogic G12A needs a different VPP setup code, handle it here. Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_vpp.c | 51 ++- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_vpp.c b/drivers/gpu/drm/meson

Re: [PATCH] drm/bridge: dw-hdmi: disable SCDC configuration for invalid setups

2019-03-25 Thread Neil Armstrong
On 25/03/2019 12:37, Andrzej Hajda wrote: > On 15.03.2019 10:54, Neil Armstrong wrote: >> This patch is an attempt to limit HDMI 2.0 SCDC setup when : >> - the SoC embeds an HDMI 1.4 only controller >> - the EDID supports SCDC but not scrambling >> - the ED

Re: [PATCH 1/2] drm/meson: Fix invalid pointer in meson_drv_unbind()

2019-03-25 Thread Neil Armstrong
On 22/03/2019 16:26, Jean-Philippe Brucker wrote: > meson_drv_bind() registers a meson_drm struct as the device's privdata, > but meson_drv_unbind() tries to retrieve a drm_device. This may cause a > segfault on shutdown: > > [ 5194.593429] Unable to handle kernel NULL pointer dereference at

Re: [PATCH] drm/bridge: dw-hdmi: disable SCDC configuration for invalid setups

2019-03-25 Thread Neil Armstrong
Hi Andrzej, Laurent, Gentle ping, Did you have time to review this fix ? Thanks ! Neil On 15/03/2019 10:54, Neil Armstrong wrote: > This patch is an attempt to limit HDMI 2.0 SCDC setup when : > - the SoC embeds an HDMI 1.4 only controller > - the EDID supports SCDC but not s

Re: [PATCH] drm/meson: fix TMDS clock filtering for DMT monitors

2019-03-25 Thread Neil Armstrong
On 20/03/2019 09:11, Neil Armstrong wrote: > DMT monitors does not necessarely report a maximum TMDS clock > in a VSDB EDID extension. > > In this case, all modes are wrongly rejected, including > the DRM fallback EDID. > > This patch only rejects modes whith c

Re: [PATCH 1/2] drm/bridge/synopsys: dw-hdmi: Add an option to suppress loading CEC driver

2019-03-25 Thread Neil Armstrong
unsigned long mpixelclock); >> + >> +unsigned int is_cec_unusable : 1; > > Strictly speaking your CEC controller isn't unusable, it's just a bit > difficult to use it according to your commit message. Would disable_cec > be a more appropriate field name ? Ac

Re: [PATCH 1/2] drm/meson: Fix invalid pointer in meson_drv_unbind()

2019-03-23 Thread Neil Armstrong
gt; Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller") > Signed-off-by: Jean-Philippe Brucker Thanks for working on this, Acked-by: Neil Armstrong I'll push it on drm-misc-fixes > --- > drivers/gpu/drm/meson/meson_drv.c | 4 ++-- > 1 file change

Re: [PATCH 2/2] drm/meson: Uninstall IRQ handler

2019-03-23 Thread Neil Armstrong
ntroller") > Signed-off-by: Jean-Philippe Brucker > --- > drivers/gpu/drm/meson/meson_drv.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Thanks for working on this, Acked-by: Neil Armstrong I'll push it on drm-misc-fixes > > diff --git a/drivers/gpu/drm/

Re: [PATCH 0/2] drm/meson: only allow using meson-canvas

2019-03-20 Thread Neil Armstrong
On 13/03/2019 13:50, Neil Armstrong wrote: > On 11/03/2019 11:51, Maxime Jourdan wrote: >> This patch series aims at removing access to the DMC register range from >> the meson DRM driver, and is the final step at fully migrating it to using >> the meson canvas provider mod

[PATCH] drm/meson: fix TMDS clock filtering for DMT monitors

2019-03-20 Thread Neil Armstrong
2:0 HDMI2.0 modes, who reports a clock > max_tmds_clock. Reported-by: Maxime Jourdan Fixes: d7d8fb7046b6 ("drm/meson: add HDMI div40 TMDS mode") Signed-off-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH v2 7/8] drm/meson: Add YUV420 output support

2019-03-19 Thread Neil Armstrong
On 19/03/2019 11:35, Maxime Jourdan wrote: > Hi Neil, > > On Fri, Feb 1, 2019 at 1:08 PM Neil Armstrong wrote: >> >> This patch adds support for the YUV420 output from the Amlogic Meson SoCs >> Video Processing Unit to the HDMI Controller. >> >> The YU

  1   2   3   4   5   6   7   >