Re: [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

2019-06-17 Thread Noralf Trønnes
Den 17.06.2019 23.20, skrev Daniel Vetter: > On Mon, Jun 17, 2019 at 06:54:04PM +0200, Noralf Trønnes wrote: >> >> >> Den 17.06.2019 18.29, skrev Daniel Vetter: >>> On Mon, Jun 17, 2019 at 05:47:50PM +0200, Noralf Trønnes wrote: >>>> >>&

Re: [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

2019-06-17 Thread Noralf Trønnes
Den 17.06.2019 18.29, skrev Daniel Vetter: > On Mon, Jun 17, 2019 at 05:47:50PM +0200, Noralf Trønnes wrote: >> >> >> Den 14.06.2019 22.35, skrev Daniel Vetter: >>> We're kinda going in the wrong direction. Spotted while typing better >>> gem/prime docs

Re: [PATCH 01/59] drm/todo: Improve drm_gem_object funcs todo

2019-06-17 Thread Noralf Trønnes
Den 14.06.2019 22.35, skrev Daniel Vetter: > We're kinda going in the wrong direction. Spotted while typing better > gem/prime docs. > > Cc: Thomas Zimmermann > Cc: Gerd Hoffmann > Cc: Rob Herring > Cc: Noralf Trønnes > Signed-off-by: Daniel Vetter > --- >

Re: [PATCH v4 10/12] drm/modes: Parse overscan properties

2019-06-16 Thread Noralf Trønnes
Den 15.06.2019 17.40, skrev Noralf Trønnes: > > > Den 14.06.2019 14.13, skrev Maxime Ripard: >> Properly configuring the overscan properties might be needed for the >> initial setup of the framebuffer for display that still have overscan. >> Let's allow for mo

Re: [PATCH v4 12/12] drm/vc4: hdmi: Set default state margin at reset

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > Now that the TV margins are properly parsed and filled into > drm_cmdline_mode, we just need to initialise the first state at reset to > get those values and start using them. > > Signed-off-by: Maxime Ripard > --- Reviewed-

Re: [PATCH v4 10/12] drm/modes: Parse overscan properties

2019-06-15 Thread Noralf Trønnes
s also needs to be documented in Documentation/fb/modedb.txt > > Reviewed-by: Noralf Trønnes > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_modes.c | 44 ++- > include/drm/drm_connector.h | 12 +- > 2 files changed, 50 insert

Re: [PATCH v4 09/12] drm/atomic: Add a function to reset connector TV properties

2019-06-15 Thread Noralf Trønnes
line_mode->tv_margins before it is added, so it needs to be moved after the patch that adds it. With that fixed: Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 08/12] drm/connector: Introduce a TV margins structure

2019-06-15 Thread Noralf Trønnes
ns.right: right margin > - * @margins.top: top margin > - * @margins.bottom: bottom margin > + * @margins: TV margins > * @mode: TV mode > * @brightness: brightness in percent > * @contrast: contrast in percent > The actual struct conversion is missing here, it has ende

Re: [PATCH v4 07/12] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-15 Thread Noralf Trønnes
Den 14.06.2019 14.13, skrev Maxime Ripard: > Rotations and reflections setup are needed in some scenarios to initialise > properly the initial framebuffer. Some drivers already had a bunch of > quirks to deal with this, such as either a private kernel command line > parameter (omapdss) or on the

Re: [PATCH v4 05/12] drm/modes: Rewrite the command line parser

2019-06-15 Thread Noralf Trønnes
operties set directly on the command line. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 04/12] drm/client: Change drm_client_panel_rotation name

2019-06-15 Thread Noralf Trønnes
nd line that we will introduce later in this series. > > Change the name to remove the panel mention. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freede

Re: [PATCH v4 03/12] drm/client: Restrict the rotation check to the rotation itself

2019-06-15 Thread Noralf Trønnes
e're also using > a reflection parameter, the test will fail for no particular reason. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 02/12] drm/client: Restrict the plane_state scope

2019-06-15 Thread Noralf Trønnes
e in the second > block with the value left by the first, without any warning from the > compiler since value would have been initialized. > > Fix this by moving the variable declaration to the proper scope. > > Signed-off-by: Maxime Ripard &

Re: [PATCH v4 01/12] drm/connector: Add documentation for drm_cmdline_mode

2019-06-15 Thread Noralf Trønnes
bool refresh_specified; > + > + /** > + * @bpp_specified: > + * > + * Did the mode has a preferred BPP? s/has/have/ Reviewed-by: Noralf Trønnes > + */ > bool bpp_specified; > - int xres, yres; > + > + /**

Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-13 Thread Noralf Trønnes
Den 13.06.2019 14.50, skrev Maxime Ripard: > Hi, > > On Wed, Jun 12, 2019 at 03:21:19PM +0200, Noralf Trønnes wrote: >>>> The only way I see for that to happen, is to set >>>> ->panel_orientation. And to repeat myself, imo that makes >>>> 'o

Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-12 Thread Noralf Trønnes
Den 11.06.2019 15.20, skrev Maxime Ripard: > Hi Noralf, > > On Fri, Apr 19, 2019 at 10:53:28AM +0200, Noralf Trønnes wrote: >> Den 18.04.2019 18.40, skrev Noralf Trønnes: >>> >>> >>> Den 18.04.2019 14.41, skrev Maxime Ripard: >>>> Rotati

Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

2019-06-12 Thread Noralf Trønnes
Den 11.06.2019 14.49, skrev Maxime Ripard: > Hi Noralf, > > On Thu, Apr 18, 2019 at 06:40:42PM +0200, Noralf Trønnes wrote: >> Den 18.04.2019 14.41, skrev Maxime Ripard: >>> + /** >>> +* We want the rotation on the command line to overwrite >>

Re: [PATCH] drm/fb: document dirty helper better

2019-06-11 Thread Noralf Trønnes
Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: Gerd Hoffmann > Cc: David Lechner > Cc: Noralf Trønnes > Cc: Hans de Goede > Signed-off-by: Daniel Vetter > --- With Chris's comment adressed: Reviewed-by: Noralf Trønnes > include/drm/drm_framebuffer.h |

Re: [PATCH] drm: Reverse lock order in pan_display_legacy()

2019-06-11 Thread Noralf Trønnes
; pan_display_atomic and pan_disaply_legacy and move it into > drm_fb_helper_pan_display. Like we do drm_fb_helper_dpms or > drm_fb_helper_setcmap or restore_fbdev_mode_force. Is 'lock' referring to modeset_mutex? If so it can't be moved out because pan_display_atomic() calls drm_client_modese

Re: [PATCH] drm/fb-helper: Unexport cmdline helpers

2019-06-11 Thread Noralf Trønnes
Den 11.06.2019 10.06, skrev Daniel Vetter: > On Sat, Jun 08, 2019 at 05:41:49PM +0200, Noralf Trønnes wrote: >> >> >> Den 07.06.2019 20.52, skrev Daniel Vetter: >>> No longer needed since the i915 initial config logic was pulled into >>> the shared

Re: [PATCH v8 0/5] drm/fb-helper: Move modesetting code to drm_client

2019-06-11 Thread Noralf Trønnes
Den 08.06.2019 17.26, skrev Noralf Trønnes: > This moves the modesetting code from drm_fb_helper to drm_client so it > can be shared by all internal clients. > > Let's see what the CI says about the remaining patches. I have added the > bootsplash todo entry patch adding

Re: [PATCH] drm/fb-helper: Unexport cmdline helpers

2019-06-08 Thread Noralf Trønnes
. Noralf. > Spotted while reviewing patches from Ville. > > Cc: Noralf Trønnes > Cc: Ville Syrjala > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_fb_helper.c | 9 + > include/drm/drm_fb_helper.h | 5 - > 2 files changed, 5 insertions(+), 9 de

[PATCH v8 3/5] drm/fb-helper: Move out modeset config code

2019-06-08 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c | 707 ++- drivers/gpu/drm/drm_fb_helper.c | 692

[PATCH v8 1/5] drm/fb-helper: Remove drm_fb_helper_connector

2019-06-08 Thread Noralf Trønnes
to look at the connectors, we just iterate over them using the same iterator function. Rename functions which signature is changed since they will be moved to drm_client in a later patch. v6: Improve commit message (Sam Ravnborg) Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg

[PATCH v8 5/5] drm/todo: Add bootsplash entry

2019-06-08 Thread Noralf Trønnes
Ease entry for anyone wanting to pick up the bootsplash work by providing a couple of pointers. v2: Add Sam as contact (Sam) Signed-off-by: Noralf Trønnes Reviewed-by: Paul Kocialkowski Reviewed-by: Sam Ravnborg --- Documentation/gpu/todo.rst | 15 +++ 1 file changed, 15

[PATCH v8 4/5] drm/client: Hack: Add bootsplash example

2019-06-08 Thread Noralf Trønnes
to be reversed for bootsplash to fend off fbdev. - Probably need some way to determine which is the primary display/device on multi DRM device systems. - Maybe do handover from early/simple DRM driver Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 5 + drivers/gpu/drm/Makefile

[PATCH v8 2/5] drm/fb-helper: Prepare to move out modeset config code

2019-06-08 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. v3: Remove stray newline Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 62 +++-- include/drm/drm_fb_helper.h

[PATCH v8 0/5] drm/fb-helper: Move modesetting code to drm_client

2019-06-08 Thread Noralf Trønnes
This moves the modesetting code from drm_fb_helper to drm_client so it can be shared by all internal clients. Let's see what the CI says about the remaining patches. I have added the bootsplash todo entry patch adding Sam as contact. Noralf. Noralf Trønnes (5): drm/fb-helper: Remove

Re: [PATCH v7 2/8] drm/fb-helper: Remove drm_fb_helper_crtc

2019-06-04 Thread Noralf Trønnes
Den 31.05.2019 16.01, skrev Noralf Trønnes: > struct drm_fb_helper_crtc is now just a wrapper around drm_mode_set so > use that directly instead and attach it as a modeset array onto > drm_client_dev. drm_fb_helper will use this array to store its modesets > which means it will alway

[PATCH v7 6/8] drm/fb-helper: Prepare to move out modeset config code

2019-05-31 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. v3: Remove stray newline Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 62 +++-- include/drm/drm_fb_helper.h

[PATCH v7 4/8] drm/fb-helper: Move out commit code

2019-05-31 Thread Noralf Trønnes
Move the modeset commit code to drm_client_modeset. No changes except exporting API. v7: Export drm_client_panel_rotation() (Gerd Hoffmann) v2: Move to drm_client_modeset.c instead of drm_client.c Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c

[PATCH v7 7/8] drm/fb-helper: Move out modeset config code

2019-05-31 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c | 707 ++- drivers/gpu/drm/drm_fb_helper.c | 692

[PATCH v7 5/8] drm/fb-helper: Remove drm_fb_helper_connector

2019-05-31 Thread Noralf Trønnes
to look at the connectors, we just iterate over them using the same iterator function. Rename functions which signature is changed since they will be moved to drm_client in a later patch. v6: Improve commit message (Sam Ravnborg) Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg

[PATCH v7 8/8] drm/client: Hack: Add bootsplash example

2019-05-31 Thread Noralf Trønnes
to be reversed for bootsplash to fend off fbdev. - Probably need some way to determine which is the primary display/device on multi DRM device systems. - Maybe do handover from early/simple DRM driver Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 5 + drivers/gpu/drm/Makefile

[PATCH v7 1/8] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-05-31 Thread Noralf Trønnes
*/ on a separate line - CHECK: Alignment should match open parenthesis v7: Declare drm_mode_set and drm_plane_state Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c| 168 drivers/gpu/drm

[PATCH v7 3/8] drm/fb-helper: Prepare to move out commit code

2019-05-31 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 122 +--- 1 file changed, 81

[PATCH v7 0/8] drm/fb-helper: Move modesetting code to drm_client

2019-05-31 Thread Noralf Trønnes
This moves the modesetting code from drm_fb_helper to drm_client so it can be shared by all internal clients. Changes this time: - Declare drm_mode_set and drm_plane_state in patch 1 - Export drm_client_panel_rotation() (Gerd Hoffmann) - Rebase Noralf. Cc: Gerd Hoffmann Noralf Trønnes (8

[PATCH v7 2/8] drm/fb-helper: Remove drm_fb_helper_crtc

2019-05-31 Thread Noralf Trønnes
rights from drm_fb_helper.c Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- Documentation/gpu/drm-client.rst | 3 + Documentation/gpu/todo.rst | 3 + drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_client.c | 10 +- drivers/g

Re: drm_gem_dumb_map_offset patch

2019-05-31 Thread Noralf Trønnes
Hi, [add Daniel Vetter] [cc dri-devel] Den 29.05.2019 15.09, skrev Pierre Yves MORDRET: > Hello Noralf, > > Sorry for bothering you with question but I need to better understand the > rational about a patch you did in DRM/GEM. > > First of all, let me introduce myself. > I'm currently employee

Re: [PATCH v6 2/8] drm/fb-helper: Remove drm_fb_helper_crtc

2019-05-23 Thread Noralf Trønnes
Den 23.05.2019 15.44, skrev Noralf Trønnes: > struct drm_fb_helper_crtc is now just a wrapper around drm_mode_set so > use that directly instead and attach it as a modeset array onto > drm_client_dev. drm_fb_helper will use this array to store its modesets > which means it will alway

[PATCH] drm/todo: Add bootsplash entry

2019-05-23 Thread Noralf Trønnes
Ease entry for anyone wanting to pick up the bootsplash work by providing a couple of pointers. Signed-off-by: Noralf Trønnes --- Documentation/gpu/todo.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index

[PATCH v6 7/8] drm/fb-helper: Move out modeset config code

2019-05-23 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c | 707 ++- drivers/gpu/drm/drm_fb_helper.c | 692

[PATCH v6 6/8] drm/fb-helper: Prepare to move out modeset config code

2019-05-23 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. v3: Remove stray newline Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 62 +++-- include/drm/drm_fb_helper.h

[PATCH v6 4/8] drm/fb-helper: Move out commit code

2019-05-23 Thread Noralf Trønnes
Move the modeset commit code to drm_client_modeset. No changes except exporting API. v2: Move to drm_client_modeset.c instead of drm_client.c Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_client_modeset.c | 287 +++ drivers/gpu/drm

[PATCH v6 5/8] drm/fb-helper: Remove drm_fb_helper_connector

2019-05-23 Thread Noralf Trønnes
to look at the connectors, we just iterate over them using the same iterator function. Rename functions which signature is changed since they will be moved to drm_client in a later patch. v6: Improve commit message (Sam Ravnborg) Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg

[PATCH v6 8/8] drm/client: Hack: Add bootsplash example

2019-05-23 Thread Noralf Trønnes
to be reversed for bootsplash to fend off fbdev. - Probably need some way to determine which is the primary display/device on multi DRM device systems. - Maybe do handover from early/simple DRM driver Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 5 + drivers/gpu/drm/Makefile

[PATCH v6 0/8] drm/fb-helper: Move modesetting code to drm_client

2019-05-23 Thread Noralf Trønnes
This moves the modesetting code from drm_fb_helper to drm_client so it can be shared by all internal clients. Changes this time: - Improve commit messages All patches have been reviewed now, thanks alot for reviewing! Noralf. Noralf Trønnes (8): drm/atomic: Move

[PATCH v6 2/8] drm/fb-helper: Remove drm_fb_helper_crtc

2019-05-23 Thread Noralf Trønnes
rights from drm_fb_helper.c Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- Documentation/gpu/drm-client.rst | 3 + Documentation/gpu/todo.rst | 3 + drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_client.c | 10 +- drivers/g

[PATCH v6 3/8] drm/fb-helper: Prepare to move out commit code

2019-05-23 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/drm_fb_helper.c | 122 +--- 1 file changed, 81

[PATCH v6 1/8] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-05-23 Thread Noralf Trønnes
*/ on a separate line - CHECK: Alignment should match open parenthesis Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c| 168 drivers/gpu/drm/drm_atomic_helper.c | 164

Re: [PATCH v5 08/11] drm/fb-helper: Remove drm_fb_helper_connector

2019-05-16 Thread Noralf Trønnes
Den 16.05.2019 15.07, skrev Sam Ravnborg: > Hi Noralf. > > See few comments in the following. > > Sam > > On Mon, May 06, 2019 at 08:01:36PM +0200, Noralf Trønnes wrote: >> All drivers add all their connectors so there's no need to keep around an >>

Re: [PATCH] drm/fb-helper: Fix drm_fb_helper_hotplug_event() NULL ptr argument

2019-05-16 Thread Noralf Trønnes
Den 15.05.2019 15.40, skrev Daniel Vetter: > On Wed, May 15, 2019 at 03:29:25PM +0200, Noralf Trønnes wrote: >> drm_fb_helper_hotplug_event() should tolerate the fb_helper argument being >> NULL. Commit 03a9606e7fee ("drm/fb-helper: Avoid race with DRM userspace")

Re: [PATCH v5 05/11] drm/fb-helper: Remove drm_fb_helper_crtc

2019-05-15 Thread Noralf Trønnes
May 06, 2019 at 08:01:33PM +0200, Noralf Trønnes wrote: >> It now only contains the modeset so use that directly instead and attach >> a modeset array to drm_client_dev. drm_fb_helper will use this array. >> Code will later be moved to drm_client, so add code there in a new file >

Re: [PATCH v5 07/11] drm/fb-helper: Move out commit code

2019-05-15 Thread Noralf Trønnes
Den 15.05.2019 11.09, skrev Sam Ravnborg: > Hi Noralf. > > On Mon, May 06, 2019 at 08:01:35PM +0200, Noralf Trønnes wrote: >> Move the modeset commit code to drm_client_modeset. >> No changes except exporting API. >> >> v2: Move to drm_client_modeset.c instead

[PATCH] drm/fb-helper: Fix drm_fb_helper_hotplug_event() NULL ptr argument

2019-05-15 Thread Noralf Trønnes
t;drm/fb-helper: Avoid race with DRM userspace") Reported-by: kbuild test robot Reported-by: Dan Carpenter Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu

Re: [PATCH v5 00/11] drm/fb-helper: Move modesetting code to drm_client

2019-05-14 Thread Noralf Trønnes
Den 06.05.2019 20.01, skrev Noralf Trønnes: > This moves the modesetting code from drm_fb_helper to drm_client so it > can be shared by all internal clients. > > Changes this time: > - Use restore_fbdev_mode_force() in > drm_fb_helper_restore_fbdev_mode_unlocked() to ple

Re: Applied "spi: Add spi_is_bpw_supported()" to the spi tree

2019-05-09 Thread Noralf Trønnes
Hi Mark, Den 15.04.2019 10.53, skrev Mark Brown: > The patch > >spi: Add spi_is_bpw_supported() > > has been applied to the spi tree at > >https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.2 > I can't see this in for-5.2 or linux-next. You also gave me a topic

Re: [PATCH] drm/cma-helper: Fix drm_gem_cma_free_object()

2019-05-08 Thread Noralf Trønnes
Den 08.05.2019 08.33, skrev Oleksandr Andrushchenko: > On 5/7/19 7:04 PM, Noralf Trønnes wrote: >> Hi, >> >> Could someone please have a look at this one? >> >> Noralf. >> >> Den 26.04.2019 14.47, skrev Noralf Trønnes: >>> The logic

Re: [PATCH] drm/cma-helper: Fix drm_gem_cma_free_object()

2019-05-07 Thread Noralf Trønnes
Hi, Could someone please have a look at this one? Noralf. Den 26.04.2019 14.47, skrev Noralf Trønnes: > The logic for freeing an imported buffer with a virtual address is > broken. It will free the buffer instead of unmapping the dma buf. > Fix by reversing the if ladder and fi

[PATCH v5 03/11] drm/fb-helper: No need to cache rotation and sw_rotations

2019-05-06 Thread Noralf Trønnes
Getting rotation info is cheap so we can do it on demand. This is done in preparation for the removal of struct drm_fb_helper_crtc. Cc: Hans de Goede Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_fb_helper.c | 131

[PATCH v5 02/11] drm/fb-helper: Avoid race with DRM userspace

2019-05-06 Thread Noralf Trønnes
gt;master in drm_fb_helper_single_fb_probe(), restore_fbdev_mode() has the check. Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- Documentation/gpu/todo.rst | 8 +++ drivers/gpu/drm/drm_auth.c | 20 +++ drivers/gpu/drm/drm_fb_helpe

[PATCH v5 01/11] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-05-06 Thread Noralf Trønnes
*/ on a separate line - CHECK: Alignment should match open parenthesis Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c| 168 drivers/gpu/drm/drm_atomic_helper.c | 164

[PATCH v5 05/11] drm/fb-helper: Remove drm_fb_helper_crtc

2019-05-06 Thread Noralf Trønnes
le has to be MIT licensed (Emmanuel Vadot) - Add copyrights from drm_fb_helper.c Signed-off-by: Noralf Trønnes --- Documentation/gpu/drm-client.rst | 3 + Documentation/gpu/todo.rst | 3 + drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_client.c | 10 +- d

[PATCH v5 00/11] drm/fb-helper: Move modesetting code to drm_client

2019-05-06 Thread Noralf Trønnes
a todo entry for this. - Rebase on drm-next (drm_fb_helper and drm_legacy patches) Noralf. Noralf Trønnes (11): drm/atomic: Move __drm_atomic_helper_disable_plane/set_config() drm/fb-helper: Avoid race with DRM userspace drm/fb-helper: No need to cache rotation and sw_rotations drm/fb-helper

[PATCH v5 10/11] drm/fb-helper: Move out modeset config code

2019-05-06 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_client_modeset.c | 707 ++- drivers/gpu/drm/drm_fb_helper.c | 692 -- include/drm

[PATCH v5 08/11] drm/fb-helper: Remove drm_fb_helper_connector

2019-05-06 Thread Noralf Trønnes
All drivers add all their connectors so there's no need to keep around an array of available connectors. Rename functions which signature is changed since they will be moved to drm_client in a later patch. Signed-off-by: Noralf Trønnes --- Documentation/gpu/todo.rst | 4 + drivers/gpu

[PATCH v5 06/11] drm/fb-helper: Prepare to move out commit code

2019-05-06 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 122 +--- 1 file changed, 81 insertions(+), 41 deletions

[PATCH v5 07/11] drm/fb-helper: Move out commit code

2019-05-06 Thread Noralf Trønnes
Move the modeset commit code to drm_client_modeset. No changes except exporting API. v2: Move to drm_client_modeset.c instead of drm_client.c Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client_modeset.c | 287 +++ drivers/gpu/drm/drm_fb_helper.c | 282

[PATCH v5 09/11] drm/fb-helper: Prepare to move out modeset config code

2019-05-06 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. v3: Remove stray newline Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_fb_helper.c | 62 +++-- include/drm/drm_fb_helper.h | 4 --- 2 files

[PATCH v5 11/11] drm/client: Hack: Add bootsplash example

2019-05-06 Thread Noralf Trønnes
to be reversed for bootsplash to fend off fbdev. - Probably need some way to determine which is the primary display/device on multi DRM device systems. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 5 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_bootsplash.c

[PATCH v5 04/11] drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode}

2019-05-06 Thread Noralf Trønnes
The values are already present in the modeset. This is done in preparation for the removal of struct drm_fb_helper_crtc. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_fb_helper.c | 12 include/drm/drm_fb_helper.h

Re: [PATCH 2/2] drm/edid: drmP.h include removal

2019-05-06 Thread Noralf Trønnes
Den 06.05.2019 11.52, skrev Jani Nikula: > Continue to get rid of drmP.h. Add minimal includes to build. Sort > includes while at it. > > Signed-off-by: Jani Nikula > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing

Re: [PATCH 1/2] drm/dp: drmP.h include removal

2019-05-06 Thread Noralf Trønnes
Den 06.05.2019 11.52, skrev Jani Nikula: > Continue to get rid of drmP.h. Add minimal includes to build. Sort > includes while at it. > > Signed-off-by: Jani Nikula > --- Reviewed-by: Noralf Trønnes ___ dri-devel mailing

Re: [PATCH v4 1/1] drm/fb-helper: Avoid race with DRM userspace

2019-05-05 Thread Noralf Trønnes
Den 04.05.2019 14.34, skrev Noralf Trønnes: > > > Den 25.04.2019 10.31, skrev Noralf Trønnes: >> drm_fb_helper_is_bound() is used to check if DRM userspace is in control. >> This is done by looking at the fb on the primary plane. By the time >> fb-helper gets

Re: [PATCH v4 1/1] drm/fb-helper: Avoid race with DRM userspace

2019-05-04 Thread Noralf Trønnes
Den 25.04.2019 10.31, skrev Noralf Trønnes: > drm_fb_helper_is_bound() is used to check if DRM userspace is in control. > This is done by looking at the fb on the primary plane. By the time > fb-helper gets around to committing, it's possible that the facts have > changed. > &g

[PATCH] drm/cma-helper: Fix drm_gem_cma_free_object()

2019-04-26 Thread Noralf Trønnes
;) Cc: sta...@vger.kernel.org Reported-by: "Li, Tingqian" Signed-off-by: Noralf Trønnes --- This bug is present in 5.0 and it only affects tinydrm drivers that import buffers, which is rare if anyone at all is doing it. I'll apply this to drm-misc-next and let it trickle down through stable u

Re: [Intel-gfx] [PATCH v4 0/1] drm/fb-helper: Move modesetting code to drm_client

2019-04-25 Thread Noralf Trønnes
Den 25.04.2019 11.25, skrev Daniel Vetter: > On Thu, Apr 25, 2019 at 10:31 AM Noralf Trønnes wrote: >> >> The Intel CI [1] was not happy with the previous version and I don't >> know which part it didn't like. So I'll split up the series and feed it >> piece

[PATCH v4 1/1] drm/fb-helper: Avoid race with DRM userspace

2019-04-25 Thread Noralf Trønnes
gt;master in drm_fb_helper_single_fb_probe(), restore_fbdev_mode() has the check. Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_auth.c | 20 drivers/gpu/drm/drm_fb_helper.c | 90 - drivers/gpu/drm/drm_i

[PATCH v4 0/1] drm/fb-helper: Move modesetting code to drm_client

2019-04-25 Thread Noralf Trønnes
The Intel CI [1] was not happy with the previous version and I don't know which part it didn't like. So I'll split up the series and feed it piece by piece until I know where the problem is. Noralf. [1] https://patchwork.freedesktop.org/series/58597/ Noralf Trønnes (1): drm/fb-helper: Avoid

Re: [Intel-gfx] [PATCH v3 00/11] drm/fb-helper: Move modesetting code to drm_client

2019-04-24 Thread Noralf Trønnes
Den 23.04.2019 13.04, skrev Martin Peres: > On 20/04/2019 20:24, Noralf Trønnes wrote: >> >> >> Den 20.04.2019 12.45, skrev Noralf Trønnes: >>> This moves the modesetting code from drm_fb_helper to drm_client so it >>> can be shared by all internal client

Re: [PATCH] drm/fb-helper: Fix drm_fb_helper_firmware_config() NULL pointer deref

2019-04-24 Thread Noralf Trønnes
Den 23.04.2019 21.01, skrev Daniel Vetter: > On Tue, Apr 23, 2019 at 04:53:53PM +0200, Noralf Trønnes wrote: >> Non-atomic drivers like ast doesn't have connector->state set resulting >> in a NULL pointer deref: >> >> [ 29.609593] BUG: unable to handle k

Re: [PATCH v2 03/12] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

2019-04-23 Thread Noralf Trønnes
Den 23.04.2019 16.17, skrev Thomas Zimmermann: > Hi > > Am 07.04.19 um 18:52 schrieb Noralf Trønnes: >> It is generic code and having it in the helper will let other drivers >> benefit from it. >> >> One change was necessary assuming this to be true: >>

[PATCH] drm/fb-helper: Fix drm_fb_helper_firmware_config() NULL pointer deref

2019-04-23 Thread Noralf Trønnes
775] drm_dev_register+0x111/0x150 [drm] Fix by bailing out if the driver does not support atomic modesetting. Fixes: 09ded8af57bc ("drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper") Reported-by: Thomas Zimmermann Cc: Daniel Vetter Cc: Jani Nikula Signed-off-by: Noralf Trønnes

Re: [PATCH v3 00/11] drm/fb-helper: Move modesetting code to drm_client

2019-04-20 Thread Noralf Trønnes
Den 20.04.2019 12.45, skrev Noralf Trønnes: > This moves the modesetting code from drm_fb_helper to drm_client so it > can be shared by all internal clients. > > Changes this time: > - Use full drm_client_init/release for the modesets (Daniel Vetter) > - drm_client_for

[PATCH v3 11/11] drm/client: Hack: Add bootsplash example

2019-04-20 Thread Noralf Trønnes
for bootsplash to fend off fbdev. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 5 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_bootsplash.c | 362 +++ drivers/gpu/drm/drm_client.c | 7 + drivers/gpu/drm/drm_drv.c

[PATCH v3 10/11] drm/fb-helper: Move out modeset config code

2019-04-20 Thread Noralf Trønnes
No functional changes, just moving code as-is and fixing includes. Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_client_modeset.c | 706 ++- drivers/gpu/drm/drm_fb_helper.c | 691 -- include/drm

[PATCH v3 07/11] drm/fb-helper: Move out commit code

2019-04-20 Thread Noralf Trønnes
Move the modeset commit code to drm_client_modeset. No changes except exporting API. v2: Move to drm_client_modeset.c instead of drm_client.c Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client_modeset.c | 287 +++ drivers/gpu/drm/drm_fb_helper.c | 282

[PATCH v3 05/11] drm/fb-helper: Remove drm_fb_helper_crtc

2019-04-20 Thread Noralf Trønnes
le has to be MIT licensed (Emmanuel Vadot) - Add copyrights from drm_fb_helper.c Signed-off-by: Noralf Trønnes --- Documentation/gpu/drm-client.rst | 3 + Documentation/gpu/todo.rst | 7 + drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_client.c | 10 +- d

[PATCH v3 00/11] drm/fb-helper: Move modesetting code to drm_client

2019-04-20 Thread Noralf Trønnes
/gpu/drm-client.rst (Daniel Vetter) Noralf. Noralf Trønnes (11): drm/atomic: Move __drm_atomic_helper_disable_plane/set_config() drm/fb-helper: Avoid race with DRM userspace drm/fb-helper: No need to cache rotation and sw_rotations drm/fb-helper: Remove drm_fb_helper_crtc->{x,y,desired_m

[PATCH v3 03/11] drm/fb-helper: No need to cache rotation and sw_rotations

2019-04-20 Thread Noralf Trønnes
Getting rotation info is cheap so we can do it on demand. This is done in preparation for the removal of struct drm_fb_helper_crtc. Cc: Hans de Goede Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_fb_helper.c | 131

[PATCH v3 02/11] drm/fb-helper: Avoid race with DRM userspace

2019-04-20 Thread Noralf Trønnes
gt;master in drm_fb_helper_single_fb_probe(), restore_fbdev_mode() has the check. Suggested-by: Daniel Vetter Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_auth.c | 20 drivers/gpu/drm/drm_fb_helper.c | 90 - drivers/gpu/drm/drm_i

[PATCH v3 09/11] drm/fb-helper: Prepare to move out modeset config code

2019-04-20 Thread Noralf Trønnes
This prepares the modeset code so it can be moved out as-is in the next patch. v3: Remove stray newline Signed-off-by: Noralf Trønnes Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_fb_helper.c | 62 +++-- include/drm/drm_fb_helper.h | 4 --- 2 files

[PATCH v3 01/11] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-04-20 Thread Noralf Trønnes
*/ on a separate line - CHECK: Alignment should match open parenthesis Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c| 168 drivers/gpu/drm/drm_atomic_helper.c | 164

[PATCH v3 06/11] drm/fb-helper: Prepare to move out commit code

2019-04-20 Thread Noralf Trønnes
This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 122 +--- 1 file changed, 81 insertions(+), 41 deletions

[PATCH v3 04/11] drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode}

2019-04-20 Thread Noralf Trønnes
The values are already present in the modeset. This is done in preparation for the removal of struct drm_fb_helper_crtc. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter Reviewed-by: Maxime Ripard --- drivers/gpu/drm/drm_fb_helper.c | 12 include/drm/drm_fb_helper.h

[PATCH v3 08/11] drm/fb-helper: Remove drm_fb_helper_connector

2019-04-20 Thread Noralf Trønnes
All drivers add all their connectors so there's no need to keep around an array of available connectors. Rename functions which signature is changed since they will be moved to drm_client in a later patch. Signed-off-by: Noralf Trønnes --- Documentation/gpu/todo.rst | 3 + drivers/gpu

Re: [PATCH v3 6/6] drm/vc4: hdmi: Set default state margin at reset

2019-04-19 Thread Noralf Trønnes
Den 18.04.2019 18.59, skrev Noralf Trønnes: > > > Den 18.04.2019 14.41, skrev Maxime Ripard: >> Now that the TV margins are properly parsed and filled into >> drm_cmdline_mode, we just need to initialise the first state at reset to >> get those values and start u

Re: [PATCH v3 4/6] drm/modes: Parse overscan properties

2019-04-19 Thread Noralf Trønnes
Den 18.04.2019 18.50, skrev Noralf Trønnes: > > > Den 18.04.2019 14.41, skrev Maxime Ripard: >> Properly configuring the overscan properties might be needed for the >> initial setup of the framebuffer for display that still have overscan. >> Let's allow for mo

Re: [PATCH v3 3/6] drm/modes: Allow to specify rotation and reflection on the commandline

2019-04-19 Thread Noralf Trønnes
Den 18.04.2019 18.40, skrev Noralf Trønnes: > > > Den 18.04.2019 14.41, skrev Maxime Ripard: >> Rotations and reflections setup are needed in some scenarios to initialise >> properly the initial framebuffer. Some drivers already had a bunch of >> quirks to dea

Re: [PATCH v3 6/6] drm/vc4: hdmi: Set default state margin at reset

2019-04-18 Thread Noralf Trønnes
line = >cmdline_mode; > + struct drm_connector_state *state; > + > + drm_atomic_helper_connector_reset(connector); Initially I wondered why not do this in the helper, but ofc that would apply the values to all the connectors. I know too little about this subject to argue for having it in the help

  1   2   3   4   5   6   7   8   9   10   >