On 21-11-20 07:26:02, Jakub Kicinski wrote:
> On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote:
> > > diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
> > > index 84dadfa726aa..9643b905e2d8 100644
> > > --- a/drivers/usb/cdns3/host.c
> &
i-exynos.c
> @@ -19,6 +19,7 @@
> #include
> #include
> #include
> +#include
>
> #include "pcie-designware.h"
>
> diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c
> b/drivers/pci/controller/dwc/pcie-qcom-ep.c
> index 7b17da2f9b3f..cfe66bf0
; +
> clk_disable_unprepare(usb->clk);
>
> return 0;
> }
>
> +static const struct dev_pm_ops tegra_usb_pm = {
> + SET_RUNTIME_PM_OPS(tegra_usb_runtime_suspend, tegra_usb_runtime_resume,
> +NULL)
> +};
> +
> static struct pl
_ep->use_streams) {
> - trace_printk("Blocking external request\n");
> + dev_dbg(priv_dev->dev, "Blocking external request\n");
> return ret;
> }
> }
> --
R
>Sent: Saturday, August 27, 2016 8:07 PM
>To: Tomi Valkeinen ; Tony Lindgren atomide.com>;
>Sean Paul ; Peter Chen ;
>Andrey Utkin
>Cc: David Airlie ; Peter Ujfalusi ti.com>; Dave
>Airlie ; Rob Clark ; Dr. H.
>Nikolaus
>Schaller ; Andrew Bradford ;
>kernel
This reverts commit 2ab9f5879162499e1c4e48613287e3f59e593c4f.
The of_get_next_parent will drop refcount on the passed node, so the reverted
patch is wrong, thanks for Tomi Valkeinen points it.
Cc: Tomi Valkeinen
Signed-off-by: Peter Chen
---
drivers/gpu/drm/omapdrm/dss/dss-of.c | 7 +++
1
>On 15/07/16 06:17, Peter Chen wrote:
>> of_node_put needs to be called when the device node which is got from
>> of_parse_phandle has finished using.
>>
>> Cc: Tomi Valkeinen
>> Signed-off-by: Peter Chen
>> ---
>> drivers/gpu/drm/omapdrm/d
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Alexey Brodkin
Signed-off-by: Peter Chen
---
drivers/gpu/drm/arc/arcpgu_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Joonyoung Shim
Cc: Seung-Woo Kim
Cc: Kyungmin Park
Signed-off-by: Peter Chen
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Tomi Valkeinen
Signed-off-by: Peter Chen
---
drivers/gpu/drm/omapdrm/dss/dss-of.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Tomi Valkeinen
Signed-off-by: Peter Chen
---
drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/omapdrm/displays
Hi Daniel,
Below are the remaining fixes for missing of_node_put, which are
not applied by you or individual driver maintainers.
Peter Chen (4):
gpu: drm: omapdrm: connector-dvi: add missing of_node_put after
calling of_parse_phandle
gpu: drm: omapdrm: dss-of: add missing of_node_put
>>> >
>>> >Just an aside: When you do the same bugfix for multiple places it's
>>> >good practice to submit it as one series (and cc everyone involved).
>>> >Increases the odds that someone is in a good mood and reviews them
>>> >all, instead of just the one affecting their own driver.
>>>
>>> Tha
>>
>> >
>> >Just an aside: When you do the same bugfix for multiple places it's
>> >good practice to submit it as one series (and cc everyone involved).
>> >Increases the odds that someone is in a good mood and reviews them
>> >all, instead of just the one affecting their own driver.
>>
>> Thanks,
>
>Just an aside: When you do the same bugfix for multiple places it's good
>practice to
>submit it as one series (and cc everyone involved). Increases the odds that
>someone
>is in a good mood and reviews them all, instead of just the one affecting
>their own
>driver.
Thanks, I realized that,
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Eric Anholt
Signed-off-by: Peter Chen
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/vc4
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Maxime Ripard
Cc: Chen-Yu Tsai
Signed-off-by: Peter Chen
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Benjamin Gaignard
Cc: Vincent Abriou
Signed-off-by: Peter Chen
---
drivers/gpu/drm/sti/sti_vtg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sti/sti_vtg.c b
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Benjamin Gaignard
Cc: Vincent Abriou
Signed-off-by: Peter Chen
---
drivers/gpu/drm/sti/sti_hqvdp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Benjamin Gaignard
Cc: Vincent Abriou
Signed-off-by: Peter Chen
---
drivers/gpu/drm/sti/sti_dvo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/sti/sti_dvo.c b
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Benjamin Gaignard
Cc: Vincent Abriou
Signed-off-by: Peter Chen
---
drivers/gpu/drm/sti/sti_compositor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/sti
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Mark Yao
Cc: Heiko Stuebner
Signed-off-by: Peter Chen
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip
Hi David,
This is remaining missing of_node_put issue fix for gpu/drm drivers, the
other fixes I sent yesterday. I think it may be easier for reviewing
using patch set for similar issue, thanks.
Peter Chen (7):
gpu: drm: rockchip_drm_drv: add missing of_node_put after calling
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Peter Chen
---
drivers/gpu/drm/omapdrm/dss/dss-of.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dss-of.c
b
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Peter Chen
---
drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/omapdrm/displays/connector-dvi.c
b
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Peter Chen
---
Changes for v2:
- There are two missings in the code, handle it both in one patch
drivers/gpu/drm/msm/msm_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Peter Chen
---
drivers/gpu/drm/msm/msm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 9c65409
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using, but current code only
calls it at error path, fix it by adding it at correct code path.
Signed-off-by: Peter Chen
---
drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 1 +
1 file changed, 1 insertion
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Peter Chen
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Peter Chen
---
drivers/gpu/drm/arc/arcpgu_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
index
30 matches
Mail list logo
