Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

2019-06-13 Thread Rob Clark
so, for dpu_format_map_tile, I'd like to define a fourcc modifier for tiled formats (we currently have a workaround in userspace w/ a private modifier in the gallium driver).. I think the problem is defining the layout of the tiled format(s) (there are at least two per generation and I can't

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-05 Thread Rob Clark
On Wed, Jun 5, 2019 at 6:18 AM Marek Szyprowski wrote: > > Hi Rob, > > On 2019-06-05 14:57, Rob Clark wrote: > > On Tue, Jun 4, 2019 at 11:58 PM Tomasz Figa wrote: > >> But first of all, I remember Marek already submitted some patches long > >> ago that e

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-05 Thread Rob Clark
On Tue, Jun 4, 2019 at 11:58 PM Tomasz Figa wrote: > > But first of all, I remember Marek already submitted some patches long > ago that extended struct driver with some flag that means that the > driver doesn't want the IOMMU to be attached before probe. Why > wouldn't that work? Sounds like a

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Mon, Jun 3, 2019 at 6:54 AM Thierry Reding wrote: > > On Mon, Jun 03, 2019 at 06:20:57AM -0700, Rob Clark wrote: > > On Mon, Jun 3, 2019 at 4:14 AM Robin Murphy wrote: > > > > > > On 03/06/2019 11:47, Rob Clark wrote: > > > > On Sun,

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Mon, Jun 3, 2019 at 4:14 AM Robin Murphy wrote: > > On 03/06/2019 11:47, Rob Clark wrote: > > On Sun, Jun 2, 2019 at 11:25 PM Tomasz Figa wrote: > >> > >> On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > >>> > >>> So, another ca

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Sun, Jun 2, 2019 at 11:25 PM Tomasz Figa wrote: > > On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > > > > On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > > > > > > On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > > > > >

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Mon, Jun 3, 2019 at 12:57 AM Vivek Gautam wrote: > > > > On 6/3/2019 11:50 AM, Tomasz Figa wrote: > > On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > >> On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > >>> On Tue, Dec 4, 2018 at 2:29 PM Rob Her

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-02 Thread Rob Clark
On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > > On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > > > On Sat, Dec 1, 2018 at 10:54 AM Rob Clark wrote: > > > > > > This solves a problem we see with drm/msm, caused by getting > > > iommu_dma_

Re: [PATCH v3 3/5] drm/msm: fix fb references in async update

2019-05-31 Thread Rob Clark
how things work on kernel/display side after spending most of my time in userspace/mesa), but I don't want to hold this up.. Acked-by: Rob Clark > > > > --- > > Hello, > > > > As mentioned in the cover letter, > > But I couldn't test on MSM because I don't have th

Re: [PATCH v2 1/2] a5xx: Define HLSQ_DBG_ECO_CNTL

2019-05-29 Thread Rob Clark
thanks, I've pushed this one to envytools tree BR, -R On Wed, May 29, 2019 at 8:20 AM Jeffrey Hugo wrote: > > --- > rnndb/adreno/a5xx.xml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rnndb/adreno/a5xx.xml b/rnndb/adreno/a5xx.xml > index ae654eeb..16203512 100644 > ---

Re: [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-28 Thread Rob Clark
On Tue, May 28, 2019 at 6:17 PM Brian Masney wrote: > > On Tue, May 28, 2019 at 03:46:14PM +0200, Linus Walleij wrote: > > On Thu, May 9, 2019 at 4:04 AM Brian Masney wrote: > > > > > Here is a patch series that adds initial display support for the LG > > > Nexus 5 (hammerhead) phone. It's not

Re: [Freedreno] [PATCH v2] drm/msm/dpu: Use provided drm_minor to initialize debugfs

2019-05-28 Thread Rob Clark
: > https://patchwork.freedesktop.org/patch/msgid/20190524173231.5040-1-s...@poorly.run > > Cc: Rob Clark > Reported-by: Stephen Boyd > Reviewed-by: Abhinav Kumar > Signed-off-by: Sean Paul nice! Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms

Re: [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs

2019-05-24 Thread Rob Clark
On Fri, May 24, 2019 at 1:43 PM Stephen Boyd wrote: > > Quoting Sean Paul (2019-05-24 10:32:18) > > From: Sean Paul > > > > Instead of reaching into dev->primary for debugfs_root, use the minor > > passed into debugfs_init. > > > > This avoids creating the debug directory under

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-05-10 Thread Rob Clark
On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > On Sat, Dec 1, 2018 at 10:54 AM Rob Clark wrote: > > > > This solves a problem we see with drm/msm, caused by getting > > iommu_dma_ops while we attach our own domain and manage it directly at

Re: [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-09 Thread Rob Clark
On Thu, May 9, 2019 at 12:12 AM Brian Masney wrote: > > On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote: > > On Wed 08 May 19:25 PDT 2019, Rob Clark wrote: > > > > > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > > > > > > &

Re: [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-08 Thread Rob Clark
On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn Andersson wrote: > > On Sun 05 May 06:04 PDT 2019, Brian Masney wrote: > > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi > > > b/arch/arm/boot/dts/qcom-msm8974.dtsi > > [..] > > > +

[PATCH 1/5] drm/msm/dpu: clean up references of DPU custom bus scaling

2019-05-08 Thread Rob Clark
(Sean Paul) Changes in v4-v7: - None Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 174 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 +- drivers/gpu/drm/msm/disp

[PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS

2019-05-08 Thread Rob Clark
Djakov) Changes in v6: - Change to new icc_set API's (Doug Anderson) Changes in v7: - Fixed a typo Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 49 ++-- 1 file changed

[PATCH 5/5] drm/msm/mdp5: Use the interconnect API

2019-05-08 Thread Rob Clark
From: Georgi Djakov Signed-off-by: Georgi Djakov Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c index 97179bec8902

[PATCH 4/5] drm/msm/dpu: add icc voting in dpu_mdss_init

2019-05-08 Thread Rob Clark
balanced add a minimum vote in dpu_mdss_init() to avoid any unclocked access. This change depends on the following patch which introduces interconnect binding to MDSS driver: https://patchwork.codeaurora.org/patch/708155/ Signed-off-by: Abhinav Kumar Reviewed-by: Sean Paul Signed-off-by: Rob Clark

[PATCH 3/5] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845

2019-05-08 Thread Rob Clark
definitions (Rob Herring) Changes in v4: - Use port macros and change port string names (Georgi Djakov) Changes in v5-v7: - None Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Reviewed-by: Rob Herring Signed-off-by: Rob Clark --- Documentation/devicetree

[PATCH 0/5] drm/msm: mdp5+dpu interconnect support

2019-05-08 Thread Rob Clark
From: Rob Clark Most of this is a resend of things that have already been posted to list. I've rebased the DPU patches, which was somewhat conflicty due to other changes and refactoring in the DPU code. Probably wouldn't hurt for someone to look over my rebases of the first two patches

[PATCH] drm/msm/a6xx: No zap shader is not an error

2019-05-08 Thread Rob Clark
From: Rob Clark Depending on platform firmware, a zap shader may not be required to take the GPU out of secure mode on boot, in which case we can just write RBBM_SECVID_TRUST_CNTL directly. Which we *mostly* handled, but missed clearing 'ret' resulting that hw_init() returned an error

Re: [RFC][PATCH 0/3] mesa: Initial build fixups for AOSP/master

2019-05-03 Thread Rob Clark
ly found mesa/master has a few >> build issues when trying to build w/ freedreno. >> >> So this patch set provides only some very basic build fixes >> that are needed to get mesa/master building w/ AOSP/master >> (minus the build restrictions on external tools). >>

Re: [RFC][PATCH 0/3] mesa: Initial build fixups for AOSP/master

2019-05-03 Thread Rob Clark
On Thu, May 2, 2019 at 2:57 PM Dan Willemsen wrote: > > On Thu, May 2, 2019 at 1:52 PM John Stultz wrote: > > > > We need solutions for the xgettext and the python-mako usage. > > Android doesn't support translations at this level, so you may be > able to just skip xgettext altogether. > from

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-30 Thread Rob Clark
On Tue, Apr 30, 2019 at 5:42 AM Boris Brezillon wrote: > > +Rob, Eric, Mark and more > > Hi, > > On Fri, 5 Apr 2019 16:20:45 +0100 > Steven Price wrote: > > > On 04/04/2019 16:20, Boris Brezillon wrote: > > > Hello, > > > > > > This patch adds new ioctls to expose GPU counters to userspace. > >

Re: [PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Rob Clark
On Thu, Apr 25, 2019 at 7:09 AM Nicholas Mc Guire wrote: > > wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise > so checking for < makes no sense here. > > Signed-off-by: Nicholas Mc Guire > --- > > Problem located with an experimental coccinelle script > > While this

[pull] drm/msm: msm-next for 5.2

2019-04-21 Thread Rob Clark
rm/msm: Split submit_lookup_objects() into two loops Luca Weiss (1): drm/msm: Fix NULL pointer dereference Lucas Stach (1): drm/msm: don't allocate pages from the MOVABLE zone Rob Clark (2): drm/msm/gpu: add per-process pagetables param drm/msm: add param to retrieve # of GPU faults (

[PATCH 2/3] drm/msm: add param to retrieve # of GPU faults (global)

2019-04-16 Thread Rob Clark
From: Rob Clark For KHR_robustness, userspace wants to know two things, the count of GPU faults globally, and the count of faults attributed to a given context. This patch providees the former, and the next patch provides the latter. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno

[PATCH 3/3] drm/msm/gpu: Add submit queue queries

2019-04-16 Thread Rob Clark
of faults to see if it is responsible for any and if so it can invalidate itself. This is also helpful for testing by confirming to the user driver if a particular command stream caused a fault (or not as the case may be). Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- drivers/gpu

[PATCH 1/3] drm/msm/gpu: add per-process pagetables param

2019-04-16 Thread Rob Clark
From: Rob Clark For now it always returns '0' (false), but once the iommu work is in place to enable per-process pagetables we can update the value returned. Userspace needs to know this to make an informed decision about exposing KHR_robustness. Signed-off-by: Rob Clark --- drivers/gpu/drm

[PATCH 0/3] drm/msm: uabi updates for KHR_robustness

2019-04-16 Thread Rob Clark
pagetables yet without some iommu work landing first. But it can otherwise be tested for the fault detection part of things with a small hack. Jordan Crouse (1): drm/msm/gpu: Add submit queue queries Rob Clark (2): drm/msm/gpu: add per-process pagetables param drm/msm: add param to retrieve

Re: [PATCH libdrm] headers: Sync with drm-next

2019-04-10 Thread Rob Clark
On Tue, Apr 9, 2019 at 8:27 AM Eric Engestrom wrote: > > On Tuesday, 2019-04-09 12:59:13 +0100, Eric Engestrom wrote: > > On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote: > > > Generated using make headers_install from the drm-next > > > tree - git://anongit.freedesktop.org/drm/drm > > >

Re: [PATCH v3 3/5] drm/msm: fix fb references in async update

2019-03-27 Thread Rob Clark
On Wed, Mar 13, 2019 at 8:21 PM Helen Koike wrote: > > Async update callbacks are expected to set the old_fb in the new_state > so prepare/cleanup framebuffers are balanced. > > Cc: # v4.14+ > Fixes: 224a4c970987 ("drm/msm: update cursors asynchronously through atomic") > Suggested-by: Boris

Re: [RFC][PATCH 0/5 v2] DMA-BUF Heaps (destaging ION)

2019-03-19 Thread Rob Clark
On Tue, Mar 19, 2019 at 1:00 PM Andrew F. Davis wrote: > > On 3/19/19 11:54 AM, Benjamin Gaignard wrote: > > Le mer. 13 mars 2019 à 23:31, John Stultz a écrit : > >> > >> On Wed, Mar 13, 2019 at 1:11 PM Liam Mark wrote: > >>> On Tue, 5 Mar 2019, John Stultz wrote: > > Eventual TODOS:

Re: [PATCH v3 2/2] drm/lima: driver for ARM Mali4xx GPUs

2019-03-02 Thread Rob Clark
On Fri, Mar 1, 2019 at 9:32 PM Qiang Yu wrote: > > On Thu, Feb 28, 2019 at 5:41 AM Rob Herring wrote: > > > > On Wed, Feb 27, 2019 at 7:42 AM Qiang Yu wrote: > > > diff --git a/drivers/gpu/drm/lima/lima_drv.c > > > b/drivers/gpu/drm/lima/lima_drv.c> > > new file mode 100644 > > > index

Re: [RFC PATCH v1 15/15] drm/msm/a5xx: Support per-instance pagetables

2019-03-01 Thread Rob Clark
On Fri, Mar 1, 2019 at 2:39 PM Jordan Crouse wrote: > > Add support for per-instance pagetables for 5XX targets. Create a support > buffer for preemption to hold the SMMU pagetable information for a > preempted ring, enable TTBR1 to support split pagetables and add the > necessary PM4 commands to

[pull] drm/msm: msm-next for 5.1

2019-02-19 Thread Rob Clark
-bindings: drm/msm/a6xx: Document GMU bindings drm/msm: Truncate the buffer object name if the copy from user failed Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (2): drm/msm: honor GPU_READONLY flag MAINTAINERS: update entry for drm

Re: freedreno header uses not installed xf86atomic.h

2019-02-19 Thread Rob Clark
e: > > > > On Fri, 15 Feb 2019 at 15:06, Rob Clark via dri-devel > > > > wrote: > > > > > > > > > > On Fri, Feb 15, 2019 at 8:42 AM Eric Engestrom > > > > > wrote: > > > > > > > > > &

Re: [PATCH v1 2/6] dt-bindings: drm/msm/a6xx: Add GX power-domain for GMU bindings

2019-02-17 Thread Rob Clark
On Sun, Feb 17, 2019 at 4:08 PM Rob Herring wrote: > > On Mon, Feb 4, 2019 at 10:15 AM Jordan Crouse wrote: > > > > The GMU should have two power domains defined: "cx" and "gx". "cx" is the > > actual power domain for the device and "gx" will be attached at runtime > > to manage reference

Re: [v1] drm/msm: Remove clock and bandwidth votes in mdss pm suspend

2019-02-17 Thread Rob Clark
On Wed, Jan 23, 2019 at 6:12 AM Jayant Shekhar wrote: > > MDSS PM suspend is dependent on runtime suspend for disabling > clocks and removing bandwidth votes. In case of pm_suspend > triggered, dpm_prepare hold a refcount on power usage of device > and hence runtime suspend is never triggered

Re: [PATCH] drm/msm: fix an error code in the ioctl

2019-02-16 Thread Rob Clark via dri-devel
On Thu, Feb 14, 2019 at 2:19 AM Dan Carpenter wrote: > > The copy_to/from_user() functions return the number of bytes remaining > to be copied but we should return -EFAULT to the user. > > Fixes: f05c83e77460 ("drm/msm: add uapi to get/set debug name") > Signed-off-by: Dan Carpenter > --- > If I

Re: [Mesa-dev] [RFC] gpu/docs: Clarify what userspace means for gl

2019-02-16 Thread Rob Clark via dri-devel
On Thu, Feb 14, 2019 at 4:00 AM Daniel Vetter wrote: > > Clear rules avoid arguing. > > I think it'd be good to have an equally solid list on the kms side. > But kms is much more meant to be a standard, and the list of userspace > projects we've accepted in the past is constantly shifting and >

Re: [Freedreno] [PATCH] drm/msm: fix an error code in the ioctl

2019-02-15 Thread Rob Clark via dri-devel
On Fri, Feb 15, 2019 at 11:01 AM Jordan Crouse wrote: > > On Thu, Feb 14, 2019 at 06:16:01PM -0500, Rob Clark wrote: > > On Thu, Feb 14, 2019 at 2:19 AM Dan Carpenter > > wrote: > > > > > > The copy_to/from_user() functions return the number of bytes remain

Re: freedreno header uses not installed xf86atomic.h

2019-02-15 Thread Rob Clark via dri-devel
On Fri, Feb 15, 2019 at 8:42 AM Eric Engestrom wrote: > > On Friday, 2019-02-15 13:36:39 +, Eric Engestrom wrote: > > On Friday, 2019-02-15 07:11:55 -0500, Rob Clark wrote: > > > On Fri, Feb 15, 2019 at 3:55 AM Daniel Drake wrote: > > > > > > > >

Re: freedreno header uses not installed xf86atomic.h

2019-02-15 Thread Rob Clark via dri-devel
On Fri, Feb 15, 2019 at 3:55 AM Daniel Drake wrote: > > Hi, > > Using libdrm-2.4.97, mesa fails to build on ARM with: > > [ 456s] In file included from > ../../../../../src/gallium/drivers/freedreno/freedreno_util.h:33, > [ 456s] from >

Re: drm dsi2hdmi bridge - temperature sensor

2019-02-14 Thread Rob Clark via dri-devel
I mean, I guess it should be possible with an ugly non-upstreamable hack, maybe using a notifier_chain to call from the temp sensor driver to the hdmi bridge driver. I'm not really sure how that could be represented cleanly in dt, maybe Rob Herring or someone else on dri-devel has some ideas.

Re: [PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Rob Clark via dri-devel
On Wed, Feb 13, 2019 at 10:28 AM Daniel Vetter wrote: > > On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote: > > We've moved the tree to a shared gitlab tree, so that Sean can help out > > with maintainer duties. > > > > Cc: Sean Paul

[PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Rob Clark via dri-devel
We've moved the tree to a shared gitlab tree, so that Sean can help out with maintainer duties. Cc: Sean Paul Signed-off-by: Rob Clark --- I can include this patch in msm-next for v5.1, but wanted to get it ack'd on list MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [PATCH v2 3/5] drm: msm: Switch to use drm_gem_object reservation_object

2019-02-13 Thread Rob Clark via dri-devel
also do some cache > maintenance on the GEM object. > > Cc: Rob Clark > Cc: David Airlie > Cc: Daniel Vetter > Cc: linux-arm-...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedr...@lists.freedesktop.org > Signed-off-by: Rob Herring Acked-by: Rob C

[resend pull] drm/msm: drm-msm-fixes-2019-01-24 for 5.0

2019-01-24 Thread Rob Clark
): drm/msm: Add __printf verification Jordan Crouse (2): drm/msm/gpu: Remove hardcoded interrupt name drm/msm: drop interrupt-names Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (1): drm/msm: honor GPU_READONLY flag .../devicetree

Re: [PATCH 2/2] drm/msm: Use DRM_DEV_INFO_RATELIMITED for shrinker messages

2019-01-23 Thread Rob Clark
On Mon, Jan 21, 2019 at 4:36 AM Jani Nikula wrote: > > On Fri, 18 Jan 2019, "Kristian H. Kristensen" wrote: > > Otherwise we get hard to track down "Purging: 123123 bytes" messages in > > the log. > > > > Signed-off-by: Kristian H. Kristensen > > --- > > drivers/gpu/drm/msm/msm_gem_shrinker.c

[pull] drm/msm: drm-msm-fixes-2018-01-22 for 5.0

2019-01-22 Thread Rob Clark
): drm/msm: Add __printf verification Jordan Crouse (2): drm/msm/gpu: Remove hardcoded interrupt name drm/msm: drop interrupt-names Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (1): drm/msm: honor GPU_READONLY flag .../devicetree

Re: [PATCH v3 1/3] drm/msm/a6xx: Add support for an interconnect path

2019-01-18 Thread Rob Clark
On Fri, Jan 18, 2019 at 1:06 PM Doug Anderson wrote: > > Hi, > > On Thu, Dec 20, 2018 at 9:30 AM Jordan Crouse wrote: > > > > Try to get the interconnect path for the GPU and vote for the maximum > > bandwidth to support all frequencies. This is needed for performance. > > Later we will want to

Re: [PATCH v4 2/3] locking: Implement an algorithm choice for Wound-Wait mutexes

2019-01-17 Thread Rob Clark
On Wed, Jan 16, 2019 at 11:49 AM Thomas Hellstrom wrote: > > Hi, > > On Wed, 2019-01-16 at 09:24 -0500, Rob Clark wrote: > > So, I guess this is to do w/ the magic of merge commits, but it looks > > like the hunk changing the crtc_ww_class got lost: > > So what hap

Re: [PATCH v2 1/2] drm/msm: Fix A6XX support for opp-level

2019-01-16 Thread Rob Clark
s On Wed, Jan 16, 2019 at 1:46 PM Douglas Anderson wrote: > > The bindings for Qualcomm opp levels changed after being Acked but > before landing. Thus the code in the GPU driver that was relying on > the old bindings is now broken. > > Let's change the code to match the new bindings by

Re: [PATCH v4 2/3] locking: Implement an algorithm choice for Wound-Wait mutexes

2019-01-16 Thread Rob Clark
So, I guess this is to do w/ the magic of merge commits, but it looks like the hunk changing the crtc_ww_class got lost:  ~/src/linux   master  git show --pretty=short 08295b3b5beec9aac0f7a9db86f0fc3792039da3 drivers/gpu/drm/drm_modeset_lock.c commit 08295b3b5beec9aac0f7a9db86f0fc3792039da3

[PATCH] drm/cirrus: fix connector leak at unload

2019-01-11 Thread Rob Clark
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload. Signed-off-by: Rob Clark --- Similar case to the issue that was fixed recently in drm/ast drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c b

Re: [PATCH v7 0/6] arm64: dts: Add sdm845 GPU/GMU and SMMU

2019-01-09 Thread Rob Clark
On Wed, Jan 9, 2019 at 1:20 PM Doug Anderson wrote: > > Hi Rob, > > On Tue, Dec 18, 2018 at 10:32 AM Jordan Crouse wrote: > > > > Now that more of the sdm845 bindings are headed upstream this a refresh of > > of https://patchwork.freedesktop.org/series/39308/ to add bindings and nodes > > for

Re: [PATCH 2/2] drm/msm/gpu: fix building without debugfs

2019-01-08 Thread Rob Clark
On Tue, Jan 8, 2019 at 9:16 AM Ioana Ciornei wrote: > > > > Subject: [PATCH 2/2] drm/msm/gpu: fix building without debugfs > > > > When debugfs is disabled, but coredump is turned on, the adreno driver > > fails to > > build: > > > > drivers/gpu/drm/msm/adreno/a3xx_gpu.c:460:4: error: 'struct

Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-12-18 Thread Rob Clark
On Fri, Oct 26, 2018 at 10:09 AM Rob Clark wrote: > > BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency > FB_BACKLIGHT prevents it from being built as a module. There > doesn't seem to be any particularly good reason for this, so > switch FB_BACKLIGHT over to tristate.

[pull] drm/msm: msm-next for 4.21

2018-12-12 Thread Rob Clark
o.h static inline functions Mamta Shukla (1): drm: msm: Use DRM_DEV_* instead of dev_* Matthias Kaehlcke (1): dt-bindings: msm/dsi: Add ref clock for PHYs Rob Clark (5): drm/msm: update generated headers drm/msm/gpu: add submit flag to hint which buffers should be dumped

Re: [PATCH] drm/msm: fix arm64 build error

2018-12-10 Thread Rob Clark
On Mon, Dec 10, 2018 at 3:56 PM Arnd Bergmann wrote: > > The new a200 GPU MMU support fails to build on arm64 because > of a conflicting macro name: > > drivers/gpu/drm/msm/msm_gpummu.c:17: error: "VA_START" redefined [-Werror] > #define VA_START SZ_16M > > In file included from

Re: [Freedreno] [PATCH] drm/msm/a6xx: Add support for an interconnect path

2018-12-07 Thread Rob Clark
er if it would be appropriate and/or possible to merge this > with the generic interconnect patches and with his blessing I would like to > renew that request. This should merge cleanly against tip of tree and it would > be nice to get this support in at the same time that the base patches go

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-12-07 Thread Rob Clark
On Thu, Dec 6, 2018 at 8:38 PM Christoph Hellwig wrote: > > On Fri, Nov 30, 2018 at 10:46:04AM +0100, Daniel Vetter wrote: > > > Being able to dip into CMA and maybe iommu coalescing if we want to > > > get fancy is indeed the only reason for this API. If we just wanted > > > to map pages we

Re: [RESEND PATCH v3] drm/msm: Move fence put to where failure occurs

2018-12-04 Thread Rob Clark
On Tue, Dec 4, 2018 at 11:56 AM Robert Foss wrote: > > If dma_fence_wait fails to wait for a supplied in-fence in > msm_ioctl_gem_submit, make sure we release that in-fence. > > Also remove this dma_fence_put() from the 'out' label. > > Signed-off-by: Robert Foss > Reviewed-by: Chris Wilson >

Re: [PATCH] drm/msm: Only add available components

2018-12-04 Thread Rob Clark
yeah, that seems like a reasonable thing to do Reviewed-by: Rob Clark > --- > > drivers/gpu/drm/msm/msm_drv.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index b1577e960889..0b82

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-03 Thread Rob Clark
On Mon, Dec 3, 2018 at 7:45 AM Robin Murphy wrote: > > Hi Rob, > > On 01/12/2018 16:53, Rob Clark wrote: > > This solves a problem we see with drm/msm, caused by getting > > iommu_dma_ops while we attach our own domain and manage it directly at

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-03 Thread Rob Clark
On Mon, Dec 3, 2018 at 7:45 AM Robin Murphy wrote: > > Hi Rob, > > On 01/12/2018 16:53, Rob Clark wrote: > > This solves a problem we see with drm/msm, caused by getting > > iommu_dma_ops while we attach our own domain and manage it directly at

Re: [PATCH v2 5/9] drm/msm: add headless gpu device (for imx5)

2018-12-02 Thread Rob Clark
On Wed, Nov 21, 2018 at 8:55 PM Jonathan Marek wrote: > > This patch allows using drm/msm without qcom display hardware. This is > especially useful for iMX5 hardware, which has a a2xx GPU but uses the > imx-drm driver for display. > > Signed-off-by: Jonathan Marek > --- > v2: added commit

Re: [PATCH v2 3/9] drm/msm/mdp4: add lcdc-align-lsb flag to control lane alignment

2018-12-02 Thread Rob Clark
On Wed, Nov 21, 2018 at 8:55 PM Jonathan Marek wrote: > > Controls which of the 8 lanes are used for 6 bit color. > > Signed-off-by: Jonathan Marek > --- > .../gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 22 --- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git

[PATCH] of/device: add blacklist for iommu dma_ops

2018-12-01 Thread Rob Clark
son Signed-off-by: Rob Clark --- This is an alternative/replacement for [1]. What it lacks in elegance it makes up for in practicality ;-) [1] https://patchwork.freedesktop.org/patch/264930/ drivers/of/device.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/driv

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-12-01 Thread Rob Clark
, 2018 at 11:40 AM Jordan Crouse > > > > wrote: > > > >> > > > >> On Thu, Nov 29, 2018 at 01:48:15PM -0500, Rob Clark wrote: > > > >>> On Thu, Nov 29, 2018 at 10:54 AM Christoph Hellwig > > > >>> wrote: > > >

Re: [PATCH 4/4] drm/msm: bump UAPI version

2018-11-30 Thread Rob Clark
On Fri, Nov 30, 2018 at 10:36 AM Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 4:31 PM Rob Clark wrote: > > > > On Fri, Nov 30, 2018 at 10:12 AM Arnd Bergmann wrote: > > > > > > On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote: >

Re: [PATCH 4/4] drm/msm: bump UAPI version

2018-11-30 Thread Rob Clark
On Fri, Nov 30, 2018 at 10:12 AM Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote: > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/msm_drv.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > >

Re: [PATCH 2/4] drm/msm: rework GEM_INFO ioctl

2018-11-30 Thread Rob Clark
On Fri, Nov 30, 2018 at 10:14 AM Arnd Bergmann wrote: > > On Fri, Nov 30, 2018 at 4:02 PM Rob Clark wrote: > > > > > - > > -#define MSM_INFO_FLAGS (MSM_INFO_IOVA) > > +/* Get or set GEM buffer info. The requested value can be passed > > + * directly

[PATCH 4/4] drm/msm: bump UAPI version

2018-11-30 Thread Rob Clark
Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 6ebbd5010722..782cc33916d6 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm

[PATCH 3/4] drm/msm: add uapi to get/set debug name

2018-11-30 Thread Rob Clark
Add UAPI to get/set GEM objects' debug name. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 36 ++- include/uapi/drm/msm_drm.h| 2 ++ 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm

[PATCH 1/4] drm/msm/gpu: add submit flag to hint which buffers should be dumped

2018-11-30 Thread Rob Clark
a MSM_SUBMIT_BO_DUMP flag so userspace can indicate buffers that contain cmdstream (or are otherwise important to dump). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 5 - drivers/gpu/drm/msm/msm_rd.c | 13 ++--- include/uapi/drm/msm_drm.h | 5 - 3 files

[PATCH 2/4] drm/msm: rework GEM_INFO ioctl

2018-11-30 Thread Rob Clark
Prep work to add a way to get/set the GEM objects debug name. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 25 - include/uapi/drm/msm_drm.h| 17 - 2 files changed, 28 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/msm

[PATCH 0/4] drm/msm: uapi updates

2018-11-30 Thread Rob Clark
for a different purpose (and therefore a debug name set at GEM_NEW time would no be no longer valid). For now you can find the corresponding userspace: https://github.com/freedreno/mesa/commits/wip/invalidate-all-the-things Rob Clark (4): drm/msm/gpu: add submit flag to hint which buffers

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Rob Clark
On Thu, Nov 29, 2018 at 10:57 AM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 03:43:50PM +0100, Daniel Vetter wrote: > > Yeah we had patches to add manual cache management code to drm, so we > > don't have to abuse the dma streaming api anymore. Got shouted down. > > Abusing the dma

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Rob Clark
On Thu, Nov 29, 2018 at 12:24 PM Tomasz Figa wrote: > > [CC Marek] > > On Thu, Nov 29, 2018 at 9:09 AM Daniel Vetter wrote: > > > > On Thu, Nov 29, 2018 at 5:57 PM Christoph Hellwig wrote: > > > > > > Note that one thing I'd like to avoid is exposing these funtions directly > > > to drivers, as

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Rob Clark
On Thu, Nov 29, 2018 at 10:54 AM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 09:42:50AM -0500, Rob Clark wrote: > > Maybe the thing we need to do is just implement a blacklist of > > compatible strings for devices which should skip the automatic > > iommu/dma h

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Rob Clark
On Thu, Nov 29, 2018 at 10:53 AM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 09:25:43AM -0500, Rob Clark wrote: > > > As I told you before: hell no. If you spent the slightest amount of > > > actually trying to understand what you are doing here you'd know this

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Rob Clark
On Thu, Nov 29, 2018 at 9:25 AM Rob Clark wrote: > > On Thu, Nov 29, 2018 at 9:14 AM Christoph Hellwig wrote: > > > > On Thu, Nov 29, 2018 at 07:33:15PM +0530, Vivek Gautam wrote: > > > dma_map_sg() expects a DMA domain. However, the drm devices > > > hav

Re: [PATCH v3 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-29 Thread Rob Clark
On Thu, Nov 29, 2018 at 9:14 AM Christoph Hellwig wrote: > > On Thu, Nov 29, 2018 at 07:33:15PM +0530, Vivek Gautam wrote: > > dma_map_sg() expects a DMA domain. However, the drm devices > > have been traditionally using unmanaged iommu domain which > > is non-dma type. Using dma mapping APIs

Re: [Freedreno] [PATCH 3/3] drm/msm: Use Hardware counters for perf profiling

2018-11-28 Thread Rob Clark
On Fri, Oct 26, 2018 at 9:46 AM Sharat Masetty wrote: > > Added Rob to this thread. > > On 10/17/2018 8:05 PM, Jordan Crouse wrote: > > On Wed, Oct 17, 2018 at 06:34:01PM +0530, Sharat Masetty wrote: > >> This patch attempts to make use of the hardware counters for GPU busy % > >> estimation when

Re: [Freedreno] [PATCH 1/1] drm/msm/a6xx: Add support for an interconnect path

2018-11-28 Thread Rob Clark
On Wed, Nov 28, 2018 at 1:29 PM Jordan Crouse wrote: > > Try to get the interconnect path for the GPU and vote for the maximum > bandwidth to support all frequencies. This is needed for performance. > Later we will want to scale the bandwidth based on the frequency to > also optimize for power

Re: [PATCH v2 1/1] drm: msm: Replace dma_map_sg with dma_sync_sg*

2018-11-28 Thread Rob Clark
On Wed, Nov 28, 2018 at 2:39 AM Christoph Hellwig wrote: > > > + /* > > + * dma_sync_sg_*() flush the physical pages, so point > > + * sg->dma_address to the physical ones for the right > > behavior. > > + */ > > +

Re: [PATCH 7/9] drm/msm: implement a2xx mmu

2018-11-20 Thread Rob Clark
thanks, it's nice to see a2xx getting some attention upstream.. few comments inline.. On Wed, Nov 14, 2018 at 5:28 PM Jonathan Marek wrote: > > A2XX has its own very simple MMU. > > Added a msm_use_mmu() function because we can't rely on iommu_present to > decide to use MMU or not. > >

[PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-10-26 Thread Rob Clark
BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency FB_BACKLIGHT prevents it from being built as a module. There doesn't seem to be any particularly good reason for this, so switch FB_BACKLIGHT over to tristate. Signed-off-by: Rob Clark Tested-by: Arnd Bergmann --- v2: remove

Re: [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*

2018-10-23 Thread Rob Clark
On Tue, Oct 23, 2018 at 12:41 PM Sean Paul wrote: > > On Mon, Oct 22, 2018 at 08:22:57PM +0100, Chris Wilson wrote: > > Quoting Mamta Shukla (2018-10-20 18:49:26) > > > Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate > > > drm-formatted specific log messages so that it will

[PATCH] drm/msm/gpu: add submit flag to hint which buffers should be dumped

2018-10-23 Thread Rob Clark
a MSM_SUBMIT_BO_DUMP flag so userspace can indicate buffers that contain cmdstream (or are otherwise important to dump). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 5 - drivers/gpu/drm/msm/msm_rd.c | 13 ++--- include/uapi/drm/msm_drm.h | 5 - 3 files

[PATCH] drm/msm: fix handling of cmdstream offset

2018-10-15 Thread Rob Clark
buffers in the command Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_rd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c index cca933458439..0c2c8d2c631f 100644 --- a/drivers/gpu/drm/msm/msm_rd.c +++ b/drivers

Re: [Freedreno] [PATCH 1/3] lib/string: Pass the input gfp flags to kmalloc

2018-10-12 Thread Rob Clark
Thanks, I've pushed 2 and 3 to msm-next, since these should probably go in a -fixes pr for 4.20 This one, you might want to resend w/ --cc-cmd=./scripts/get_maintainer.pl so that it gets seen by someone who could apply it fwiw, I use git config sendemail.cccmd './scripts/get_maintainer.pl -i'

[PATCH libdrm] xf86drmHash: remove redundant zero init

2018-10-11 Thread Rob Clark
From: Rob Clark drmMalloc() is already calloc() Signed-off-by: Rob Clark --- Small micro-optimization that I noticed while doing some perf work.. I should probably look at promoting amdgpu's handle_table to core libdrm and replacing a couple of libdrm_freedreno's xf86drmHash tables over

Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-10-11 Thread Rob Clark
On Thu, Oct 11, 2018 at 3:02 AM Arnd Bergmann wrote: > > On Thu, Oct 11, 2018 at 3:16 AM Rob Clark wrote: > > > > On Wed, Oct 10, 2018 at 11:35 AM Arnd Bergmann wrote: > > > > > > On 10/10/18, Rob Clark wrote: > > > > BACKLIGHT_CL

Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-10-10 Thread Rob Clark
On Wed, Oct 10, 2018 at 11:35 AM Arnd Bergmann wrote: > > On 10/10/18, Rob Clark wrote: > > BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency > > FB_BACKLIGHT prevents it from being built as a module. There > > doesn't seem to be any particularly good reason

[PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-10-10 Thread Rob Clark
BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency FB_BACKLIGHT prevents it from being built as a module. There doesn't seem to be any particularly good reason for this, so switch FB_BACKLIGHT over to tristate. Signed-off-by: Rob Clark --- drivers/video/fbdev/Kconfig| 2

  1   2   3   4   5   6   7   8   9   10   >