Re: [PATCH] drm/msm: fix an error code in the ioctl

2019-02-16 Thread Rob Clark via dri-devel
On Thu, Feb 14, 2019 at 2:19 AM Dan Carpenter wrote: > > The copy_to/from_user() functions return the number of bytes remaining > to be copied but we should return -EFAULT to the user. > > Fixes: f05c83e77460 ("drm/msm: add uapi to get/set debug name") > Signed-off-by: Dan Carpenter > --- > If I

Re: [Mesa-dev] [RFC] gpu/docs: Clarify what userspace means for gl

2019-02-16 Thread Rob Clark via dri-devel
On Thu, Feb 14, 2019 at 4:00 AM Daniel Vetter wrote: > > Clear rules avoid arguing. > > I think it'd be good to have an equally solid list on the kms side. > But kms is much more meant to be a standard, and the list of userspace > projects we've accepted in the past is constantly shifting and > ad

Re: [Freedreno] [PATCH] drm/msm: fix an error code in the ioctl

2019-02-15 Thread Rob Clark via dri-devel
On Fri, Feb 15, 2019 at 11:01 AM Jordan Crouse wrote: > > On Thu, Feb 14, 2019 at 06:16:01PM -0500, Rob Clark wrote: > > On Thu, Feb 14, 2019 at 2:19 AM Dan Carpenter > > wrote: > > > > > > The copy_to/from_user() functions return the number of bytes remaining > > > to be copied but we should re

Re: freedreno header uses not installed xf86atomic.h

2019-02-15 Thread Rob Clark via dri-devel
On Fri, Feb 15, 2019 at 8:42 AM Eric Engestrom wrote: > > On Friday, 2019-02-15 13:36:39 +, Eric Engestrom wrote: > > On Friday, 2019-02-15 07:11:55 -0500, Rob Clark wrote: > > > On Fri, Feb 15, 2019 at 3:55 AM Daniel Drake wrote: > > > > > > > > Hi, > > > > > > > > Using libdrm-2.4.97, mesa

Re: freedreno header uses not installed xf86atomic.h

2019-02-15 Thread Rob Clark via dri-devel
On Fri, Feb 15, 2019 at 3:55 AM Daniel Drake wrote: > > Hi, > > Using libdrm-2.4.97, mesa fails to build on ARM with: > > [ 456s] In file included from > ../../../../../src/gallium/drivers/freedreno/freedreno_util.h:33, > [ 456s] from > ../../../../../src/gallium/drivers/freedre

Re: drm dsi2hdmi bridge - temperature sensor

2019-02-14 Thread Rob Clark via dri-devel
I mean, I guess it should be possible with an ugly non-upstreamable hack, maybe using a notifier_chain to call from the temp sensor driver to the hdmi bridge driver. I'm not really sure how that could be represented cleanly in dt, maybe Rob Herring or someone else on dri-devel has some ideas. (Ba

Re: [PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Rob Clark via dri-devel
On Wed, Feb 13, 2019 at 10:28 AM Daniel Vetter wrote: > > On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote: > > We've moved the tree to a shared gitlab tree, so that Sean can help out > > with maintainer duties. > > > > Cc: Sean

[PATCH] MAINTAINERS: update entry for drm/msm

2019-02-13 Thread Rob Clark via dri-devel
We've moved the tree to a shared gitlab tree, so that Sean can help out with maintainer duties. Cc: Sean Paul Signed-off-by: Rob Clark --- I can include this patch in msm-next for v5.1, but wanted to get it ack'd on list MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH v2 3/5] drm: msm: Switch to use drm_gem_object reservation_object

2019-02-13 Thread Rob Clark via dri-devel
On Sat, Feb 2, 2019 at 10:42 AM Rob Herring wrote: > > Now that the base struct drm_gem_object has a reservation_object, use it > and remove the private BO one. > > We can't use the drm_gem_reservation_object_wait() helper for MSM > because (in theory) msm_gem_cpu_prep() will also do some cache >