[PATCH] drm/panel: rm67191: Remove CLOCK_NON_CONTINUOUS flag

2020-08-29 Thread Robert Chiras (OSS)
From: Robert Chiras The flag MIPI_DSI_CLOCK_NON_CONTINUOUS was wrong used in the DSI driver, so it was added to this panel, but not necessary. So, remove this flag since it is not needed. Signed-off-by: Robert Chiras --- drivers/gpu/drm/panel/panel-raydium-rm67191.c | 3 +-- 1 file changed, 1

[PATCH 1/5] drm/bridge: nwl-dsi: Add support for video_pll

2020-08-29 Thread Robert Chiras (OSS)
From: Robert Chiras This patch adds support for a new clock 'video_pll' in order to better set the video_pll clock to a clock-rate that satisfies a mode's clock. The video PLL, on i.MX8MQ, can drive both DC pixel-clock and DSI phy_ref clock. When used with a bridge that can drive multiple modes

[PATCH 4/5] dt-bindings: display/bridge: nwl-dsi: Document fsl, clock-drop-level property

2020-08-29 Thread Robert Chiras (OSS)
From: Robert Chiras Add documentation for a new property: 'fsl,clock-drop-level'. Signed-off-by: Robert Chiras --- Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/nwl

[PATCH 2/5] dt-bindings: display/bridge: nwl-dsi: Document video_pll clock

2020-08-29 Thread Robert Chiras (OSS)
From: Robert Chiras Add documentation for a new clock 'video_pll'. Signed-off-by: Robert Chiras --- Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/nwl-dsi.yaml b

[PATCH 0/5] Add new features to nwl-dsi driver

2020-08-29 Thread Robert Chiras (OSS)
From: Robert Chiras This patch-set adds the new following features to the nwl-dsi bridge driver: 1. Control Video PLL from nwl-dsi driver Add support for the Video PLL into the nwl-dsi driver, in order to better control it's rate, depending on the requested video mode. Controlling the Video

[PATCH 5/5] drm/bridge: nwl-dsi: add support for DCSS

2020-08-29 Thread Robert Chiras (OSS)
From: Laurentiu Palcu DCSS needs active low VSYNC and HSYNC. Also, move the input selection in the probe function, as this will not change at runtime. Signed-off-by: Laurentiu Palcu Signed-off-by: Robert Chiras --- drivers/gpu/drm/bridge/nwl-dsi.c | 24 1 file

[PATCH 3/5] drm/bridge: nwl-dsi: Add support for clock-drop-level

2020-08-29 Thread Robert Chiras (OSS)
From: Robert Chiras The clock-drop-level is needed in order to add more blanking space needed by DSI panels when sending DSI commands. One level is the equivalent of phy_ref rate from the PLL rate. Since the PLL rate is targeted as highest possible, each level should not get the crtc_clock too

Re: [EXT] [PATCH v8 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-12-04 Thread Robert Chiras
On Mi, 2019-12-04 at 13:06 +0100, Guido Günther wrote: > Hi Robert, > On Tue, Dec 03, 2019 at 09:50:03AM +, Robert Chiras wrote: > > > > Hi Guido, > > > > Since your last revision sent, I've done more tests here and found > > a > > few more impro

Re: [EXT] [PATCH v8 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-12-03 Thread Robert Chiras
ontroller found > on > i.MX8 SoCs. > > It adds support for the i.MX8MQ but the same IP can be found on > e.g. the i.MX8QXP. > > It has been tested on the Librem 5 devkit using mxsfb. > > Signed-off-by: Guido Günther > Co-developed-by: Robert Chiras > Signed-off-by:

[PATCH v4 11/14] drm/mxsfb: Improve the axi clock usage

2019-08-30 Thread Robert Chiras
the clk API function for enable/disable the clock. Those functions are already checking for NULL clk and returning 0 if that's the case. Signed-off-by: Robert Chiras Acked-by: Leonard Crestez Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 drivers/gpu/drm/mxsfb

[PATCH v4 14/14] drm/mxsfb: Add support for live pixel format change

2019-08-30 Thread Robert Chiras
This IP requires full stop and re-start when changing display timings, but we can change the pixel format while running. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff

[PATCH v4 12/14] drm/mxsfb: Clear OUTSTANDING_REQS bits

2019-08-30 Thread Robert Chiras
Bit 21 can alter the CTRL2_OUTSTANDING_REQS value right after the eLCDIF is enabled, since it comes up with default value of 1 (this behaviour has been seen on some imx8 platforms). In order to fix this, clear CTRL2_OUTSTANDING_REQS bits before setting its value. Signed-off-by: Robert Chiras

[PATCH v4 00/14] Improvements and fixes for mxsfb DRM driver

2019-08-30 Thread Robert Chiras
a better representation (guido) - Included a patch submitted by Guido, while he was testing my patch-set Guido Günther (1): drm/mxsfb: Read bus flags from bridge if present Mirela Rabulea (1): drm/mxsfb: Signal mode changed when bpp changed Robert Chiras (12): drm/mxsfb: Update mxsfb to sup

[PATCH v4 10/14] drm/mxsfb: Update mxsfb to support LCD reset

2019-08-30 Thread Robert Chiras
The eLCDIF controller has control pin for the external LCD reset pin. Add support for it and assert this pin in enable and de-assert it in disable. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 14 ++ drivers/gpu/drm/mxsfb

[PATCH v4 04/14] drm/mxsfb: Reset vital registers for a proper initialization

2019-08-29 Thread Robert Chiras
Some of the registers, like LCDC_CTRL, CTRL2_OUTSTANDING_REQS and CTRL1_RECOVERY_ON_UNDERFLOW needs to be properly cleared/initialized for a better start and stop routine. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 1 file

[PATCH v4 05/14] drm/mxsfb: Update register definitions using bit manipulation defines

2019-08-29 Thread Robert Chiras
Use BIT(x) and GEN_MASK(h, l) for better representation the inside of various registers. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 151 ++--- 1 file changed, 89 insertions(+), 62 deletions(-) diff --git

[PATCH v4 03/14] drm/mxsfb: Add defines for the rest of registers

2019-08-29 Thread Robert Chiras
Some of the existing registers in this controller are not defined, but also not used. Add them to the register definitions, so that they can be easily used in future improvements or fixes. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 15

[PATCH v4 09/14] dt-bindings: display: Add max-memory-bandwidth property for mxsfb

2019-08-29 Thread Robert Chiras
Add new optional property 'max-memory-bandwidth', to limit the maximum bandwidth used by the MXSFB_DRM driver. Signed-off-by: Robert Chiras Tested-by: Guido Günther Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/display/mxsfb.txt | 5 + 1 file changed, 5 insertions

[PATCH v4 06/14] drm/mxsfb: Update mxsfb with additional pixel formats

2019-08-29 Thread Robert Chiras
based on input from the user and panel capabilities. Save the bus format in crtc->mode.private_flags, so the bridge can use it. Signed-off-by: Robert Chiras Signed-off-by: Mirela Rabulea Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c |

[PATCH v4 13/14] drm/mxsfb: Add support for horizontal stride

2019-08-29 Thread Robert Chiras
in order to do horizontal crop on the frame buffer processed by the eLCDIF block. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 79 -- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + drivers/gpu/drm/mxsfb

[PATCH v4 07/14] drm/mxsfb: Signal mode changed when bpp changed

2019-08-29 Thread Robert Chiras
From: Mirela Rabulea Add mxsfb_atomic_helper_check to signal mode changed when bpp changed. This will trigger the execution of disable/enable on a modeset with different bpp than the current one. Signed-off-by: Mirela Rabulea Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers

[PATCH v4 02/14] drm/mxsfb: Read bus flags from bridge if present

2019-08-29 Thread Robert Chiras
From: Guido Günther The bridge might have special requirmentes on the input bus. This is e.g. used by the imx-nwl bridge. Signed-off-by: Guido Günther Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v4 08/14] drm/mxsfb: Add max-memory-bandwidth property for MXSFB

2019-08-29 Thread Robert Chiras
Because of stability issues, we may want to limit the maximum bandwidth required by the MXSFB (eLCDIF) driver. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 48 +++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 ++ 2

[PATCH v4 01/14] drm/mxsfb: Update mxsfb to support a bridge

2019-08-29 Thread Robert Chiras
. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 17 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 46 +- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_out.c | 26

Re: [EXT] [PATCH v3 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-08-29 Thread Robert Chiras
e.g. the i.MX8QXP. > > It has been tested on the Librem 5 devkit using mxsfb. > > Signed-off-by: Guido Günther > Co-developed-by: Robert Chiras > --- >  drivers/gpu/drm/bridge/Kconfig   |   2 + >  drivers/gpu/drm/bridge/Makefile  |   1 + >  drivers/gpu/dr

Re: [EXT] [PATCH v3 0/2] drm: bridge: Add NWL MIPI DSI host controller support

2019-08-28 Thread Robert Chiras
it will allow this driver to dinamically set the video_pll clock for any kind of mode. So, for the whole patch-set, you can add: Tested-by: Robert Chiras Signed-off-by: Robert Chiras Best regards, Robert On Jo, 2019-08-22 at 12:44 +0200, Guido Günther wrote: > This adds initial support for the

Re: [PATCH v3 00/15] Improvements and fixes for mxsfb DRM driver

2019-08-28 Thread Robert Chiras
Hi Leonard, On Lu, 2019-08-26 at 19:19 +, Leonard Crestez wrote: > On 26.08.2019 17:35, Stefan Agner wrote: > > > > On 2019-08-26 14:05, Guido Günther wrote: > > > > > > Hi, > > > On Wed, Aug 21, 2019 at 01:15:40PM +0300, Robert Chiras wrote: > &

Re: [EXT] [PATCH v3 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-08-25 Thread Robert Chiras
On Thu, Aug 22, 2019 at 01:18:21PM +, Robert Chiras wrote: > > > > Hi Guido, > > > > I added my signed-off, plus some comments inline. > > > > On Jo, 2019-08-22 at 12:44 +0200, Guido Günther wrote: > > > > > > This adds initial support

Re: [EXT] [PATCH v3 2/2] drm/bridge: Add NWL MIPI DSI host controller support

2019-08-22 Thread Robert Chiras
e.g. the i.MX8QXP. > > It has been tested on the Librem 5 devkit using mxsfb. > > Signed-off-by: Guido Günther Signed-off-by: Robert Chiras > Co-developed-by: Robert Chiras > --- >  drivers/gpu/drm/bridge/Kconfig   |   2 + >  drivers/gpu/drm/bridge/Makefile 

[PATCH v3 06/15] drm/mxsfb: Update mxsfb with additional pixel formats

2019-08-22 Thread Robert Chiras
based on input from the user and panel capabilities. Save the bus format in crtc->mode.private_flags, so the bridge can use it. Signed-off-by: Robert Chiras Signed-off-by: Mirela Rabulea --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 147 ++--- drivers/gpu/drm/mx

[PATCH v3 00/15] Improvements and fixes for mxsfb DRM driver

2019-08-21 Thread Robert Chiras
changed when bpp changed Robert Chiras (13): drm/mxsfb: Update mxsfb to support a bridge drm/mxsfb: Add defines for the rest of registers drm/mxsfb: Reset vital registers for a proper initialization drm/mxsfb: Update register definitions using bit manipulation defines drm/mxsfb: Update mxsfb

[PATCH v3 04/15] drm/mxsfb: Reset vital registers for a proper initialization

2019-08-21 Thread Robert Chiras
Some of the registers, like LCDC_CTRL, CTRL2_OUTSTANDING_REQS and CTRL1_RECOVERY_ON_UNDERFLOW needs to be properly cleared/initialized for a better start and stop routine. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 1 file changed, 12 insertions

[PATCH v3 15/15] drm/mxsfb: Add support for live pixel format change

2019-08-21 Thread Robert Chiras
This IP requires full stop and re-start when changing display timings, but we can change the pixel format while running. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb

[PATCH v3 05/15] drm/mxsfb: Update register definitions using bit manipulation defines

2019-08-21 Thread Robert Chiras
Use BIT(x) and GEN_MASK(h, l) for better representation the inside of various registers. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 151 ++--- 1 file changed, 89 insertions(+), 62 deletions(-) diff --git a/drivers/gpu/drm/mxsfb

[PATCH v3 02/15] drm/mxsfb: Read bus flags from bridge if present

2019-08-21 Thread Robert Chiras
From: Guido Günther The bridge might have special requirmentes on the input bus. This is e.g. used by the imx-nwl bridge. Signed-off-by: Guido Günther Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v3 01/15] drm/mxsfb: Update mxsfb to support a bridge

2019-08-21 Thread Robert Chiras
. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 17 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 46 +- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_out.c | 26

[PATCH v3 13/15] drm/mxsfb: Clear OUTSTANDING_REQS bits

2019-08-21 Thread Robert Chiras
Bit 21 can alter the CTRL2_OUTSTANDING_REQS value right after the eLCDIF is enabled, since it comes up with default value of 1 (this behaviour has been seen on some imx8 platforms). In order to fix this, clear CTRL2_OUTSTANDING_REQS bits before setting its value. Signed-off-by: Robert Chiras

[PATCH v3 10/15] dt-bindings: display: Add max-memory-bandwidth property for mxsfb

2019-08-21 Thread Robert Chiras
Add new optional property 'max-memory-bandwidth', to limit the maximum bandwidth used by the MXSFB_DRM driver. Signed-off-by: Robert Chiras --- Documentation/devicetree/bindings/display/mxsfb.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v3 08/15] drm/mxsfb: Signal mode changed when bpp changed

2019-08-21 Thread Robert Chiras
From: Mirela Rabulea Add mxsfb_atomic_helper_check to signal mode changed when bpp changed. This will trigger the execution of disable/enable on a modeset with different bpp than the current one. Signed-off-by: Mirela Rabulea Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c

[PATCH v3 09/15] drm/mxsfb: Add max-memory-bandwidth property for MXSFB

2019-08-21 Thread Robert Chiras
Because of stability issues, we may want to limit the maximum bandwidth required by the MXSFB (eLCDIF) driver. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 48 +++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 2 ++ 2 files changed, 50

[PATCH v3 14/15] drm/mxsfb: Add support for horizontal stride

2019-08-21 Thread Robert Chiras
in order to do horizontal crop on the frame buffer processed by the eLCDIF block. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 79 -- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + drivers/gpu/drm/mxsfb/mxsfb_regs.h | 16 3 files

[PATCH v3 03/15] drm/mxsfb: Add defines for the rest of registers

2019-08-21 Thread Robert Chiras
Some of the existing registers in this controller are not defined, but also not used. Add them to the register definitions, so that they can be easily used in future improvements or fixes. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 15 +++ 1 file changed

[PATCH v3 12/15] drm/mxsfb: Improve the axi clock usage

2019-08-21 Thread Robert Chiras
the clk API function for enable/disable the clock. Those functions are already checking for NULL clk and returning 0 if that's the case. Signed-off-by: Robert Chiras Acked-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 32

[PATCH v3 11/15] drm/mxsfb: Update mxsfb to support LCD reset

2019-08-21 Thread Robert Chiras
The eLCDIF controller has control pin for the external LCD reset pin. Add support for it and assert this pin in enable and de-assert it in disable. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 14 ++ drivers/gpu/drm/mxsfb/mxsfb_regs.h | 2 ++ 2 files

[PATCH v3 07/15] drm/mxsfb: Fix the vblank events

2019-08-21 Thread Robert Chiras
with the '-v' parameter will result in an astronomical refresh rate (1+ Hz), because of that. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb

Re: [EXT] Re: [PATCH v2 06/15] drm/mxsfb: Update mxsfb with additional pixel formats

2019-08-14 Thread Robert Chiras
Hi Daniel, On Mi, 2019-08-14 at 12:44 +0100, Daniel Stone wrote: > Hi Robert, > > On Wed, 14 Aug 2019 at 11:49, Robert Chiras > wrote: > > > > +   case DRM_FORMAT_BGR565: /* BG16 */ > > +   if (mxsfb->devdata->ipversion <

Re: [EXT] Re: [PATCH v2 09/15] dt-bindings: display: Add max-res property for mxsfb

2019-08-14 Thread Robert Chiras
Hi Stefann, On Mi, 2019-08-14 at 13:25 +0200, Stefan Agner wrote: > On 2019-08-14 13:14, Robert Chiras wrote: > > > > Hi Stefan, > > On Mi, 2019-08-14 at 13:03 +0200, Stefan Agner wrote: > > > > > > On 2019-08-14 12:48, Robert Chiras wrote: > > &g

Re: [EXT] Re: [PATCH v2 04/15] drm/mxsfb: Reset vital register for a proper initialization

2019-08-14 Thread Robert Chiras
Hi Stefan, On Mi, 2019-08-14 at 13:11 +0200, Stefan Agner wrote: > On 2019-08-14 12:48, Robert Chiras wrote: > > > > Some of the regiters need, like LCDC_CTRL and > > CTRL2_OUTSTANDING_REQS > Typo in registers, and there is a need to many. Thanks, will fix this. > &g

Re: [EXT] Re: [PATCH v2 12/15] drm/mxsfb: Improve the axi clock usage

2019-08-14 Thread Robert Chiras
Hi Stefan, On Mi, 2019-08-14 at 13:06 +0200, Stefan Agner wrote: > On 2019-08-14 12:48, Robert Chiras wrote: > > > > Currently, the enable of the axi clock return status is ignored, > > causing > > issues when the enable fails then we try to disable it. Therefore, &g

Re: [EXT] Re: [PATCH v2 09/15] dt-bindings: display: Add max-res property for mxsfb

2019-08-14 Thread Robert Chiras
Hi Stefan, On Mi, 2019-08-14 at 13:03 +0200, Stefan Agner wrote: > On 2019-08-14 12:48, Robert Chiras wrote: > > > > Add new optional property 'max-res', to limit the maximum supported > > resolution by the MXSFB_DRM driver. > I would also mention the reason why we

[PATCH v2 05/15] drm/mxsfb: Update register definitions using bit manipulation defines

2019-08-14 Thread Robert Chiras
Use BIT(x) and GEN_MASK(h, l) for better representation the inside of various registers. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 151 ++--- 1 file changed, 89 insertions(+), 62 deletions(-) diff --git a/drivers/gpu/drm/mxsfb

[PATCH v2 01/15] drm/mxsfb: Update mxsfb to support a bridge

2019-08-14 Thread Robert Chiras
. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 17 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 46 +- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_out.c | 26

[PATCH v2 04/15] drm/mxsfb: Reset vital register for a proper initialization

2019-08-14 Thread Robert Chiras
Some of the regiters need, like LCDC_CTRL and CTRL2_OUTSTANDING_REQS needs to be properly cleared and initialized for a better start and stop routine. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers

[PATCH v2 07/15] drm/mxsfb: Fix the vblank events

2019-08-14 Thread Robert Chiras
with the '-v' parameter will result in an astronomical refresh rate (1+ Hz), because of that. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb

[PATCH v2 09/15] dt-bindings: display: Add max-res property for mxsfb

2019-08-14 Thread Robert Chiras
Add new optional property 'max-res', to limit the maximum supported resolution by the MXSFB_DRM driver. Signed-off-by: Robert Chiras --- Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v2 10/15] drm/mxsfb: Add max-res property for MXSFB

2019-08-14 Thread Robert Chiras
Because of stability issues, we may want to limit the maximum resolution supported by the MXSFB (eLCDIF) driver. This patch add support for a new property which we can use to impose such limitation. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 12 ++-- 1 file

[PATCH v2 15/15] drm/mxsfb: Add support for live pixel format change

2019-08-14 Thread Robert Chiras
This IP requires full stop and re-start when changing display timings, but we can change the pixel format while running. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb

[PATCH v2 14/15] drm/mxsfb: Add support for horizontal stride

2019-08-14 Thread Robert Chiras
in order to do horizontal crop on the frame buffer processed by the eLCDIF block. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 79 -- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 - drivers/gpu/drm/mxsfb/mxsfb_regs.h | 16

[PATCH v2 12/15] drm/mxsfb: Improve the axi clock usage

2019-08-14 Thread Robert Chiras
the clk API function for enable/disable the clock. Those functions are already checking for NULL clk and returning 0 if that's the case. Signed-off-by: Robert Chiras Acked-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 32

[PATCH v2 06/15] drm/mxsfb: Update mxsfb with additional pixel formats

2019-08-14 Thread Robert Chiras
based on input from the user and panel capabilities. Save the bus format in crtc->mode.private_flags, so the bridge can use it. Signed-off-by: Robert Chiras Signed-off-by: Mirela Rabulea --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 147 ++--- drivers/gpu/drm/mx

[PATCH v2 08/15] drm/mxsfb: Signal mode changed when bpp changed

2019-08-14 Thread Robert Chiras
From: Mirela Rabulea Add mxsfb_atomic_helper_check to signal mode changed when bpp changed. This will trigger the execution of disable/enable on a modeset with different bpp than the current one. Signed-off-by: Mirela Rabulea Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c

[PATCH v2 03/15] drm/mxsfb: Add defines for the rest of registers

2019-08-14 Thread Robert Chiras
Some of the existing registers in this controller are not defined, but also not used. Add them to the register definitions, so that they can be easily used in future improvements or fixes. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 15 +++ 1 file changed

[PATCH v2 02/15] drm/mxsfb: Read bus flags from bridge if present

2019-08-14 Thread Robert Chiras
From: Guido Günther The bridge might have special requirmentes on the input bus. This is e.g. used by the imx-nwl bridge. Signed-off-by: Guido Günther Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 00/15] Improvements and fixes for mxsfb DRM driver

2019-08-14 Thread Robert Chiras
Günther (1): drm/mxsfb: Read bus flags from bridge if present Mirela Rabulea (1): drm/mxsfb: Signal mode changed when bpp changed Robert Chiras (13): drm/mxsfb: Update mxsfb to support a bridge drm/mxsfb: Add defines for the rest of registers drm/mxsfb: Reset vital register for a proper

[PATCH v2 11/15] drm/mxsfb: Update mxsfb to support LCD reset

2019-08-14 Thread Robert Chiras
The eLCDIF controller has control pin for the external LCD reset pin. Add support for it and assert this pin in enable and de-assert it in disable. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 14 ++ drivers/gpu/drm/mxsfb/mxsfb_regs.h | 2 ++ 2 files

[PATCH v2 13/15] drm/mxsfb: Clear OUTSTANDING_REQS bits

2019-08-14 Thread Robert Chiras
Bit 21 can alter the CTRL2_OUTSTANDING_REQS value right after the eLCDIF is enabled, since it comes up with default value of 1 (this behaviour has been seen on some imx8 platforms). In order to fix this, clear CTRL2_OUTSTANDING_REQS bits before setting its value. Signed-off-by: Robert Chiras

Re: [EXT] Re: [PATCH 05/10] dt-bindings: display: Add max-res property for mxsfb

2019-08-14 Thread Robert Chiras
On Lu, 2019-07-22 at 11:48 -0600, Rob Herring wrote: > On Wed, Jun 26, 2019 at 04:32:13PM +0300, Robert Chiras wrote: > > > > Add new optional property 'max-res', to limit the maximum supported > > resolution by the MXSFB_DRM driver. > Bindings are for h/w descri

Re: [EXT] Re: [PATCH 00/10] Improvements and fixes for mxsfb DRM driver

2019-08-13 Thread Robert Chiras
On Ma, 2019-08-13 at 12:23 +0200, Guido Günther wrote: > Hi Robert, > On Wed, Jun 26, 2019 at 04:32:08PM +0300, Robert Chiras wrote: > > > > This patch-set improves the use of eLCDIF block on iMX 8 SoCs (like > > 8MQ, 8MM > > and 8QXP). Following, are the new

Re: [EXT] Re: [PATCH 00/10] Improvements and fixes for mxsfb DRM driver

2019-07-12 Thread Robert Chiras
Hi Guido, On Jo, 2019-07-11 at 17:04 +0200, Guido Günther wrote: > Hi Robert, > On Wed, Jun 26, 2019 at 04:32:08PM +0300, Robert Chiras wrote: > > > > This patch-set improves the use of eLCDIF block on iMX 8 SoCs (like > > 8MQ, 8MM > > and 8QXP). Following, are th

[PATCH 06/10] drm/mxsfb: Add max-res property for MXSFB

2019-06-27 Thread Robert Chiras
Because of stability issues, we may want to limit the maximum resolution supported by the MXSFB (eLCDIF) driver. This patch add support for a new property which we can use to impose such limitation. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 12 ++-- 1 file

[PATCH 05/10] dt-bindings: display: Add max-res property for mxsfb

2019-06-27 Thread Robert Chiras
Add new optional property 'max-res', to limit the maximum supported resolution by the MXSFB_DRM driver. Signed-off-by: Robert Chiras --- Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH 04/10] drm/mxsfb: Signal mode changed when bpp changed

2019-06-27 Thread Robert Chiras
From: Mirela Rabulea Add mxsfb_atomic_helper_check to signal mode changed when bpp changed. This will trigger the execution of disable/enable on a modeset with different bpp than the current one. Signed-off-by: Mirela Rabulea Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c

[PATCH 07/10] drm/mxsfb: Update mxsfb to support LCD reset

2019-06-26 Thread Robert Chiras
The eLCDIF controller has control pin for the external LCD reset pin. Add support for it and assert this pin in enable and de-assert it in disable. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 10 -- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 1 + 2 files changed, 9

[PATCH 08/10] drm/mxsfb: Improve the axi clock usage

2019-06-26 Thread Robert Chiras
the clk API function for enable/disable the clock. Those functions are already checking for NULL clk and returning 0 if that's the case. Signed-off-by: Robert Chiras Acked-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 32

[PATCH 10/10] drm/mxsfb: Add support for horizontal stride

2019-06-26 Thread Robert Chiras
in order to do horizontal crop on the frame buffer processed by the eLCDIF block. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 79 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 - drivers/gpu/drm/mxsfb/mxsfb_regs.h | 16

[PATCH 00/10] Improvements and fixes for mxsfb DRM driver

2019-06-26 Thread Robert Chiras
of them at maximum capacity (like it is the case on 8MQ, where there are two display controllers: DCSS and eLCDIF). The rest of the patches are bug-fixes. Mirela Rabulea (1): drm/mxsfb: Signal mode changed when bpp changed Robert Chiras (9): drm/mxsfb: Update mxsfb to support a bridge drm

[PATCH 02/10] drm/mxsfb: Update mxsfb with additional pixel formats

2019-06-26 Thread Robert Chiras
based on input from the user and panel capabilities. Save the bus format in crtc->mode.private_flags, so the bridge can use it. Signed-off-by: Robert Chiras Signed-off-by: Mirela Rabulea --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 158 ++--- drivers/gpu/drm/mx

[PATCH 09/10] drm/mxsfb: Clear OUTSTANDING_REQS bits

2019-06-26 Thread Robert Chiras
Bit 21 can alter the CTRL2_OUTSTANDING_REQS value right after the eLCDIF is enabled, since it comes up with default value of 1 (this behaviour has been seen on some imx8 platforms). In order to fix this, clear CTRL2_OUTSTANDING_REQS bits before setting its value. Signed-off-by: Robert Chiras

[PATCH 03/10] drm/mxsfb: Fix the vblank events

2019-06-26 Thread Robert Chiras
with the '-v' parameter will result in an astronomical refresh rate (1+ Hz), because of that. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb

[PATCH 01/10] drm/mxsfb: Update mxsfb to support a bridge

2019-06-26 Thread Robert Chiras
. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 46 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 46 +- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_out.c | 26

Re: [EXT] Re: [PATCH v5 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-26 Thread Robert Chiras
Hi Sam, On Mi, 2019-06-26 at 13:33 +0200, Sam Ravnborg wrote: > Hi Robert. > > On Wed, Jun 26, 2019 at 01:20:20PM +0300, Robert Chiras wrote: > > > > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI > > protocol). > I was about to apply these - but I

[PATCH v6 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-26 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg Reviewed-by: Fabio Estevam --- .../bindings/display/panel/raydium,rm67191.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644

[PATCH v6 0/2] Add DSI panel driver for Raydium RM67191

2019-06-26 Thread Robert Chiras
in enable (sam) *** SUBJECT HERE *** *** BLURB HERE *** Robert Chiras (2): dt-bindings: display: panel: Add support for Raydium RM67191 panel drm/panel: Add support for Raydium RM67191 panel driver .../bindings/display/panel/raydium,rm67191.txt | 41 ++ MAINTAINERS

[PATCH v6 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-26 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg Reviewed-by: Fabio Estevam --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel

[PATCH v5 0/2] Add DSI panel driver for Raydium RM67191

2019-06-26 Thread Robert Chiras
) - Fixed copyright statement (daniel) - Reordered includes (sam) - Added defines for panel specific color formats (fabio) - Removed unnecessary tests in enable and unprepare (sam) - Removed the unnecessary backlight write in enable (sam) Robert Chiras (2): dt-bindings: display: panel: Add support

[PATCH v5 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-26 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- .../bindings/display/panel/raydium,rm67191.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v5 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-26 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1

[PATCH v4 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-25 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- .../bindings/display/panel/raydium,rm67191.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v4 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-25 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1

[PATCH v4 0/2] Add DSI panel driver for Raydium RM67191

2019-06-25 Thread Robert Chiras
specific color formats (fabio) - Removed unnecessary tests in enable and unprepare (sam) - Removed the unnecessary backlight write in enable (sam) Robert Chiras (2): dt-bindings: display: panel: Add support for Raydium RM67191 panel drm/panel: Add support for Raydium RM67191 panel driver

Re: [EXT] Re: [PATCH v3 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-25 Thread Robert Chiras
On Lu, 2019-06-24 at 13:12 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Mon, Jun 24, 2019 at 4:44 AM Robert Chiras > wrote: > > > > > > > > > You did not handle the "power" regulator. > > There is no nee

Re: [EXT] Re: [PATCH v3 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-24 Thread Robert Chiras
On Vi, 2019-06-21 at 12:46 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Fri, Jun 21, 2019 at 11:16 AM Robert Chiras > wrote: > > > > > From what I've seen in the schematics, the power lines on the DSI > > port > >

Re: [EXT] Re: [PATCH v3 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-24 Thread Robert Chiras
Hi Fabio, Thanks for your feedback. I will handle them all, but for the pm_ops I have some comments. See inline. On Vi, 2019-06-21 at 10:59 -0300, Fabio Estevam wrote: > Hi Robert, > > On Thu, Jun 20, 2019 at 10:31 AM Robert Chiras > wrote: > > > > > +fail:

Re: [EXT] Re: [PATCH v3 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-21 Thread Robert Chiras
Hi Fabio, On Vi, 2019-06-21 at 11:00 -0300, Fabio Estevam wrote: > Hi Robert, > > On Thu, Jun 20, 2019 at 10:32 AM Robert Chiras > wrote: > > > > > > Add dt-bindings documentation for Raydium RM67191 DSI panel. > > > > Signed-off-by: Ro

[PATCH v3 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-20 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1

[PATCH v3 0/2] Add DSI panel driver for Raydium RM67191

2019-06-20 Thread Robert Chiras
(daniel) - Reordered includes (sam) - Added defines for panel specific color formats (fabio) - Removed unnecessary tests in enable and unprepare (sam) - Removed the unnecessary backlight write in enable (sam) Robert Chiras (2): dt-bindings: display: panel: Add support for Raydium RM67191 panel

[PATCH v3 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-20 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- .../bindings/display/panel/raydium,rm67191.txt | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [EXT] Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-20 Thread Robert Chiras
On Mi, 2019-06-19 at 10:28 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Tue, Jun 18, 2019 at 10:31 AM Robert Chiras > wrote: > > > > > +static const struct display_timing rad_default_timing = { > > +   .pixelc

Re: [EXT] Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-20 Thread Robert Chiras
Hi Sam, On Mi, 2019-06-19 at 15:25 +0200, Sam Ravnborg wrote: > On Tue, Jun 18, 2019 at 04:30:46PM +0300, Robert Chiras wrote: > > > > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI > > protocol). > > > > Signed-off-by: Robert Chiras > Pl

Re: [EXT] Re: [PATCH v2 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-20 Thread Robert Chiras
On Mi, 2019-06-19 at 10:21 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Tue, Jun 18, 2019 at 10:33 AM Robert Chiras > wrote: > > > > > +Optional properties: > > +- reset-gpios: a GPIO spec for the RST_B GPIO pin > &g

  1   2   >