Re: [PATCH v2 1/3] video: fbdev: Fix checkpatch warnings in goldfishfb.c

2018-06-16 Thread Roman Kiryanov
Hi,

could you please confirm you received our patches? Thank you.

Regards,
Roman.
On Fri, Jun 8, 2018 at 12:11 PM  wrote:
>
> From: Roman Kiryanov 
>
> Address issues pointed by checkpatch.pl
>
> Signed-off-by: Roman Kiryanov 
> ---
> Changes in v2:
>  - Updated the commit message to include "video: fbdev:" and added a 
> description.
>
>  drivers/video/fbdev/goldfishfb.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/goldfishfb.c 
> b/drivers/video/fbdev/goldfishfb.c
> index 3b70044773b6..de29c4ff77e5 100644
> --- a/drivers/video/fbdev/goldfishfb.c
> +++ b/drivers/video/fbdev/goldfishfb.c
> @@ -124,6 +124,7 @@ static int goldfish_fb_check_var(struct fb_var_screeninfo 
> *var,
>  static int goldfish_fb_set_par(struct fb_info *info)
>  {
> struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb);
> +
> if (fb->rotation != fb->fb.var.rotate) {
> info->fix.line_length = info->var.xres * 2;
> fb->rotation = fb->fb.var.rotate;
> @@ -148,13 +149,14 @@ static int goldfish_fb_pan_display(struct 
> fb_var_screeninfo *var,
> wait_event_timeout(fb->wait,
> fb->base_update_count != base_update_count, HZ / 15);
> if (fb->base_update_count == base_update_count)
> -   pr_err("goldfish_fb_pan_display: timeout waiting for base 
> update\n");
> +   pr_err("%s: timeout waiting for base update\n", __func__);
> return 0;
>  }
>
>  static int goldfish_fb_blank(int blank, struct fb_info *info)
>  {
> struct goldfish_fb *fb = container_of(info, struct goldfish_fb, fb);
> +
> switch (blank) {
> case FB_BLANK_NORMAL:
> writel(1, fb->reg_base + FB_SET_BLANK);
> --
> 2.18.0.rc1.242.g61856ae69a-goog
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH 3/3] ANDROID: goldfish_fb: Set pixclock = 0

2018-06-11 Thread Roman Kiryanov
Hi,

thank you for reviewing our patches. I sent "v2".

Regards,
Roman.
On Fri, Jun 8, 2018 at 9:24 AM Bartlomiej Zolnierkiewicz
 wrote:
>
>
> [ + linux-fbdev ML ]
>
> On Thursday, May 31, 2018 03:02:52 PM r...@google.com wrote:
> > From: Christoffer Dall 
> >
> > User space Android code identifies pixclock == 0 as a sign for emulation
> > and will set the frame rate to 60 fps when reading this value, which is
> > the desired outcome.
> >
> > Change-Id: I759bf518bf6683446bc786bf1be3cafa02dd8d42
>
> please drop your local Change-Id from the upstream kernel submissions
>
> > Signed-off-by: Christoffer Dall 
> > Signed-off-by: Peter Maydell 
>
> your S-o-b line is also needed
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R Institute Poland
> Samsung Electronics
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel