Re: [PATCH v3 2/9] of: property: add of_graph_get_next_port_endpoint()

2024-08-27 Thread Sakari Ailus
Hi Rob, On Tue, Aug 27, 2024 at 09:05:02AM -0500, Rob Herring wrote: > On Tue, Aug 27, 2024 at 5:47 AM Sakari Ailus wrote: > > > > Rob, Kunimori-san, > > > > On Mon, Aug 26, 2024 at 10:40:09AM -0500, Rob Herring wrote: > > > On Mon, Aug 26, 2024 at 02:43

Re: [PATCH v3 2/9] of: property: add of_graph_get_next_port_endpoint()

2024-08-27 Thread Sakari Ailus
tion that it also has a flags field to allow e.g. returning endpoints with regs higher than requested (FWNODE_GRAPH_ENDPOINT_NEXT). Most users dealing with endpoints on fwnode property API use this, could something like this be done on OF as well? Probably a similar flag would be needed though. -- Kind regards, Sakari Ailus

Re: [PATCH v2 1/9] of: property: add of_graph_get_next_port()

2024-08-24 Thread Sakari Ailus
(struct device_node *np); > > struct device_node *of_graph_get_port_by_id(struct device_node *node, u32 > > id); > > struct device_node *of_graph_get_next_endpoint(const struct device_node > > *parent, > > struct device_node *previous); > > +struct device_node *of_graph_get_next_ports(struct device_node *parent, > > + struct device_node *ports); > > +struct device_node *of_graph_get_next_port(struct device_node *parent, > > + struct device_node *port); > > struct device_node *of_graph_get_endpoint_by_regs( > > const struct device_node *parent, int port_reg, int reg); > > struct device_node *of_graph_get_remote_endpoint( > > @@ -73,6 +100,11 @@ static inline unsigned int > > of_graph_get_endpoint_count(const struct device_node > > return 0; > > } > > > > +static inline unsigned int of_graph_get_port_count(struct device_node *np) > > +{ > > + return 0; > > +} > > + > > static inline struct device_node *of_graph_get_port_by_id( > > struct device_node *node, u32 id) > > { > > @@ -86,6 +118,20 @@ static inline struct device_node > > *of_graph_get_next_endpoint( > > return NULL; > > } > > > > +static inline struct device_node *of_graph_get_next_ports( > > + struct device_node *parent, > > + struct device_node *previous) > > +{ > > + return NULL; > > +} > > + > > +static inline struct device_node *of_graph_get_next_port( > > + struct device_node *parent, > > + struct device_node *previous) > > +{ > > + return NULL; > > +} > > + > > static inline struct device_node *of_graph_get_endpoint_by_regs( > > const struct device_node *parent, int port_reg, int reg) > > { > -- Kind regards, Sakari Ailus

Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

2024-06-04 Thread Sakari Ailus
t->ids[i].string); > + index = __match_string(ids, -1, cid_list->ids[i].string); > if (index >= 0) > return true; > } Reviewed-by: Sakari Ailus # drivers/acpi -- Sakari Ailus

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Sakari Ailus
iated with a small number of companies > (https://kernelci.slack.com/signup#/domain-signup). That's a big no-go > for me. I agree. There is no shortage of good alternatives either: we have IRC, Matrix and XMPP for instance. Just pick one of them. -- Regards, Sakari Ailus

[PATCH v5 1/2] PM: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-30 Thread Sakari Ailus
alled pm_runtime_get_conditional() and implementations of pm_runtime_get_if_active() and pm_runtime_get_if_in_use() are moved to runtime.c. Signed-off-by: Sakari Ailus Reviewed-by: Alex Elder Reviewed-by: Laurent Pinchart Acked-by: Takashi Iwai # sound/ Reviewed-by: Jacek Lawrynowicz # drivers/

[PATCH v5 0/2] Small runtime PM API changes

2024-01-30 Thread Sakari Ailus
he 1st patch. since v1: - patch 1: Rename __pm_runtime_get_conditional() as pm_runtime_get_conditional(). - patch 1: Reword documentation on driver use of pm_runtime_get_conditional(). Sakari Ailus (2): PM: runtime: Simplify pm_runtime_get_if_active() usage PM: runtime: Add pm_runtime_put_auto

Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-26 Thread Sakari Ailus
Hi Alex, On Fri, Jan 26, 2024 at 09:12:02AM -0600, Alex Elder wrote: > On 1/22/24 5:41 AM, Sakari Ailus wrote: > > There are two ways to opportunistically increment a device's runtime PM > > usage count, calling either pm_runtime_get_if_active() or > > pm_runtime_get_i

Re: [PATCH v4 1/3] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-23 Thread Sakari Ailus
On Tue, Jan 23, 2024 at 03:48:01PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 23, 2024 at 08:44:04PM +0000, Sakari Ailus wrote: > > On Tue, Jan 23, 2024 at 11:24:23AM -0600, Bjorn Helgaas wrote: > > ... > > > > - I don't know whether it's

Re: [PATCH v4 1/3] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-23 Thread Sakari Ailus
Hi Bjorn, Thanks for the review. On Tue, Jan 23, 2024 at 11:24:23AM -0600, Bjorn Helgaas wrote: > On Tue, Jan 23, 2024 at 11:56:42AM +0200, Sakari Ailus wrote: > > There are two ways to opportunistically increment a device's runtime PM > > usage count, calling either pm_r

[PATCH v4 2/3] pm: runtime: Make pm_runtime_get_if_conditional() private

2024-01-23 Thread Sakari Ailus
Stop offering pm_runtime_get_if_conditional() API function for drivers, instead require them to use pm_runtime_get_if_{active,in_use}. Also convert the only user, the i915 driver, to use the said functions. Signed-off-by: Sakari Ailus --- drivers/base/power/runtime.c| 34

[PATCH v4 1/3] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-23 Thread Sakari Ailus
ed as pm_runtime_get_conditional(). Signed-off-by: Sakari Ailus Reviewed-by: Alex Elder # drivers/net/ipa/ipa_smp2p.c Reviewed-by: Laurent Pinchart Acked-by: Takashi Iwai # sound/ Reviewed-by: Jacek Lawrynowicz # drivers/accel/ivpu/ Acked-by: Rodrigo Vivi # drivers/gpu/drm/i915/ Reviewed-by: Rodrigo

[PATCH v4 0/3] Small runtime PM API changes

2024-01-23 Thread Sakari Ailus
umentation on driver use of pm_runtime_get_conditional(). Sakari Ailus (3): pm: runtime: Simplify pm_runtime_get_if_active() usage pm: runtime: Make pm_runtime_get_if_conditional() private pm: runtime: Add pm_runtime_put_autosuspend() replacement Documentation/power/runt

Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Sakari Ailus
Hi Rafael, Björn, Thanks for the review. On Mon, Jan 22, 2024 at 07:16:54PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 22, 2024 at 7:12 PM Bjorn Helgaas wrote: > > > > On Mon, Jan 22, 2024 at 01:41:21PM +0200, Sakari Ailus wrote: > > > There are two ways to oppor

[PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Sakari Ailus
ed as pm_runtime_get_conditional(). Signed-off-by: Sakari Ailus Reviewed-by: Alex Elder # drivers/net/ipa/ipa_smp2p.c Reviewed-by: Laurent Pinchart Acked-by: Takashi Iwai # sound/ Reviewed-by: Jacek Lawrynowicz # drivers/accel/ivpu/ Acked-by: Rodrigo Vivi # drivers/gpu/drm/i915/ Reviewed-by: Rodrigo

[PATCH v3 0/2] Small runtime PM API changes

2024-01-22 Thread Sakari Ailus
me_get_conditional() as pm_runtime_get_conditional(). - patch 1: Reword documentation on driver use of pm_runtime_get_conditional(). Sakari Ailus (2): pm: runtime: Simplify pm_runtime_get_if_active() usage pm: runtime: Add pm_runtime_put_autosuspend() replacement Documentation/power/r

Re: [PATCH 3/3] media: v4l2-core: Describe privacy_led field of v4l2_subdev

2023-05-18 Thread Sakari Ailus
gt; + * @privacy_led: Privacy LED associated with the sub-device. > * @enabled_streams: Bitmask of enabled streams used by > *v4l2_subdev_enable_streams() and > *v4l2_subdev_disable_streams() helper functions for fallback I'm not sure how this ever was an issue --- privacy_led field was documented in the same patch that added it. -- Kind regards, Sakari Ailus

Re: [PATCH v13 01/10] device property: Add remote endpoint to devcon matcher

2023-03-06 Thread Sakari Ailus
> > Signed-off-by: Prashant Malani > Signed-off-by: Pin-yen Lin Reviewed-by: Sakari Ailus -- Sakari Ailus

Re: [PATCH v11 1/9] device property: Add remote endpoint to devcon matcher

2023-02-09 Thread Sakari Ailus
Hi Pin-yen, On Thu, Feb 09, 2023 at 12:28:33PM +0800, Pin-yen Lin wrote: > Hi Sakari, > > Thanks for the review. > > On Mon, Feb 6, 2023 at 5:11 AM Sakari Ailus > wrote: > > > > Hi Pin-yen, > > > > On Sat, Feb 04, 2023 at 09:30:32PM +0800, Pin-

Re: [PATCH v11 1/9] device property: Add remote endpoint to devcon matcher

2023-02-05 Thread Sakari Ailus
; > + } > + } > + fwnode_handle_put(node); > + > node = fwnode_graph_get_remote_port_parent(ep); > if (!fwnode_device_is_available(node)) { > fwnode_handle_put(node); -- Kind regards, Sakari Ailus

Re: [PATCH v10 1/9] device property: Add remote endpoint to devcon matcher

2023-01-16 Thread Sakari Ailus
Hi Prashant, On Thu, Jan 12, 2023 at 02:31:45PM -0800, Prashant Malani wrote: > HI Sakari, > > On Thu, Jan 12, 2023 at 5:32 AM Sakari Ailus > wrote: > > > > Hi Pin-yen, > > > > On Thu, Jan 12, 2023 at 12:20:56PM +0800, Pin-yen Li

Re: [PATCH v10 1/9] device property: Add remote endpoint to devcon matcher

2023-01-12 Thread Sakari Ailus
+ if (matches) > + matches[count] = ret; > + count++; > + } > + } Aren't you missing fwnode_handle-put(node) here?? > + > node = fwnode_graph_get_remote_port_parent(ep); > if (!fwnode_device_is_available(node)) { > fwnode_handle_put(node); -- Kind regards, Sakari Ailus

Re: [PATCH v2 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-21 Thread Sakari Ailus
he series for > the format definitions. I think it'd be good to have only one set of definitions. Can we can sort the endianness question in a reasonable way? Also new Bayer formats will probably be still needed on V4L2 side but will they be relevant for DRM? I suppose that would mean new DRM format for each pixel order, too? Or can we think of something smarter that would still work reasonably with existing formats? -- Kind regards, Sakari Ailus

Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples

2022-11-21 Thread Sakari Ailus
Hi Laurent, On Sat, Jul 16, 2022 at 06:12:05PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote: > > On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote: > > > Now that a header exists with macros

Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types

2022-11-21 Thread Sakari Ailus
Hi Laurent, On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote: > Hello, > > On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote: > > Hi Sakari, > > > > Gentle ping. > > > > On Sun, Jul 17, 2022 at 06:54:00AM +, Sakari Ailus wro

Re: [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types

2022-07-16 Thread Sakari Ailus
patch. I can take these all if people are fine with that. -- Kind regards, Sakari Ailus

Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples

2022-07-16 Thread Sakari Ailus
i2c0 { > #address-cells = <1>; The definition doesn't seem to be used here. Is there a need to include this? I could drop this chunk while applying. There's just one trivial change elsewhere in this patch to make. -- Kind regards, Sakari Ailus

Re: [PATCH v9 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2022-06-16 Thread Sakari Ailus
On Sat, Jun 11, 2022 at 10:14:07PM +0800, Liu Ying wrote: > Patch 1/14 and 2/14 add bus formats used by pixel combiner. Thanks! For these: Acked-by: Sakari Ailus -- Sakari Ailus

Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation

2022-01-19 Thread Sakari Ailus
ES)); This would be better split on two lines. Then, Reviewed-by: Sakari Ailus -- Sakari Ailus

Re: [PATCH] media: switch from 'pci_' to 'dma_' API

2021-08-23 Thread Sakari Ailus
Thanks, Christophe. On Sun, Aug 22, 2021 at 11:30:08AM +0200, Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below. > > It has been compile tested. Reviewed-by: Sakari Ail

Re: [PATCH 0/4] drm: Finally retire struct drm_format_name_buf

2021-05-26 Thread Sakari Ailus
On Wed, May 26, 2021 at 09:21:10PM +0200, Thomas Zimmermann wrote: > ping for further a-bs / r-bs Thanks for the ping. For the series: Reviewed-by: Sakari Ailus > > Am 16.05.21 um 14:13 schrieb Thomas Zimmermann: > > This is a cleanup patchset to remove drm_format_name_b

Re: [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

2021-05-05 Thread Sakari Ailus
ith references for a long time, looks like from the very beginning of it, as in patch 8a0662d9ed2968e1186208336a8e1fab3fdfea63 . If you're expecting an fwnode family of function returning another node, then that function has to have taken a reference to that node before retur

Re: [PATCH v9 0/4] Add %p4cc printk modifier for V4L2 and DRM fourcc codes

2021-02-17 Thread Sakari Ailus
On Wed, Feb 17, 2021 at 01:14:42PM +0100, Thomas Zimmermann wrote: > Hi > > Am 16.02.21 um 16:57 schrieb Sakari Ailus: > > Hi all, > > > > On merging --- it would seem everyone is happy with merging this > > through the drm-misc tree. The last patch sh

[PATCH v9 3/4] drm: Switch to %p4cc format modifier

2021-02-16 Thread Sakari Ailus
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a large number of temporary variables at the same time. Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko Acked-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c

[PATCH v9 2/4] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-16 Thread Sakari Ailus
Now that we can print FourCC codes directly using printk, make use of the feature in V4L2 core. Signed-off-by: Sakari Ailus Acked-by: Mauro Carvalho Chehab Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko --- drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++- 1 file

[PATCH v9 0/4] Add %p4cc printk modifier for V4L2 and DRM fourcc codes

2021-02-16 Thread Sakari Ailus
- Added V4L2 core conversion to %p4cc, as well as change the DRM fourcc printing function to use %p4cc. - Add missing checkpatch.pl checks for %p4cc modifier. Sakari Ailus (4): lib/vsprintf: Add support for printing V4L2 and DRM fourccs v4l: ioctl: Use %p4cc printk modifier to print FourC

[PATCH v9 1/4] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-16 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by

[PATCH v9 4/4] drm: Remove drm_get_format_name()

2021-02-16 Thread Sakari Ailus
The %p4cc printk format modifier was recently added to print fourcc codes, replacing drm_get_format_name(). The function is no longer needed, so remove it. Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/drm_fourcc.c | 25

[PATCH v8 1/4] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-16 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by

[PATCH v8 2/4] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-16 Thread Sakari Ailus
Now that we can print FourCC codes directly using printk, make use of the feature in V4L2 core. Signed-off-by: Sakari Ailus Acked-by: Mauro Carvalho Chehab Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko --- drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++- 1 file

[PATCH v8 4/4] drm: Remove drm_get_format_name()

2021-02-16 Thread Sakari Ailus
The %p4cc printk format modifier was recently added to print fourcc codes, replacing drm_get_format_name(). The function is no longer needed, so remove it. Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko --- drivers/gpu/drm/drm_fourcc.c | 25

[PATCH v8 3/4] drm: Switch to %p4cc format modifier

2021-02-16 Thread Sakari Ailus
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a large number of temporary variables at the same time. Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by: Andy Shevchenko Acked-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c

[PATCH v8 0/4] Add %p4cc printk modifier for V4L2 and DRM fourcc codes

2021-02-16 Thread Sakari Ailus
ssing checkpatch.pl checks for %p4cc modifier. Sakari Ailus (4): lib/vsprintf: Add support for printing V4L2 and DRM fourccs v4l: ioctl: Use %p4cc printk modifier to print FourCC codes drm: Switch to %p4cc format modifier drm: Remove drm_get_format_name() Documentation/core-a

Re: [PATCH v7 3/3] drm: Switch to %p4cc format modifier

2021-02-16 Thread Sakari Ailus
Hi Thomas, Thanks for the review. On Tue, Feb 16, 2021 at 09:37:45AM +0100, Thomas Zimmermann wrote: > Hi > > Am 15.02.21 um 12:40 schrieb Sakari Ailus: > > Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a > > large number of temporary varia

Re: [PATCH v7 3/3] drm: Switch to %p4cc format modifier

2021-02-15 Thread Sakari Ailus
} else { > seq_printf(); > } > > ? I could, but it'd repeat a lot of the same format string that is very complicated right now. Therefore I thought it's better to split. Or do you mean seq_printf() vs. seq_puts()? checkpatch.pl (rightly) warns about it. > > >fb ? fb->modifier : 0, > >fb ? fb->width : 0, fb ? fb->height : 0, > >plane_visibility(plane_state), -- Sakari Ailus ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v7 2/3] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-15 Thread Sakari Ailus
On Mon, Feb 15, 2021 at 06:05:45PM +0100, Mauro Carvalho Chehab wrote: > Em Mon, 15 Feb 2021 17:56:27 +0100 > Petr Mladek escreveu: > > > On Mon 2021-02-15 13:40:29, Sakari Ailus wrote: > > > Now that we can print FourCC codes directly using printk, make use of the &g

Re: [PATCH v7 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-15 Thread Sakari Ailus
Hi Petr, On Mon, Feb 15, 2021 at 05:51:40PM +0100, Petr Mladek wrote: > On Mon 2021-02-15 17:54:47, Andy Shevchenko wrote: > > On Mon, Feb 15, 2021 at 03:56:50PM +0200, Sakari Ailus wrote: > > > On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote: > > > >

Re: [PATCH v7 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-15 Thread Sakari Ailus
Hi Andy, On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote: > On Mon, Feb 15, 2021 at 01:40:28PM +0200, Sakari Ailus wrote: > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by fourccs. The fourcc encoding is th

Re: [PATCH v7 2/3] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-15 Thread Sakari Ailus
Hi Andy, On Mon, Feb 15, 2021 at 03:34:04PM +0200, Andy Shevchenko wrote: > On Mon, Feb 15, 2021 at 01:40:29PM +0200, Sakari Ailus wrote: > > Now that we can print FourCC codes directly using printk, make use of the > > feature in V4L2 core. > > Reviewed-by: Andy Shevche

Re: [PATCH v7 3/3] drm: Switch to %p4cc format modifier

2021-02-15 Thread Sakari Ailus
Hi Andy, On Mon, Feb 15, 2021 at 03:41:14PM +0200, Andy Shevchenko wrote: > On Mon, Feb 15, 2021 at 01:40:30PM +0200, Sakari Ailus wrote: > > Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a > > large number of temporary variables at the same time. > &

[PATCH v7 2/3] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-15 Thread Sakari Ailus
Now that we can print FourCC codes directly using printk, make use of the feature in V4L2 core. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++- 1 file changed, 21 insertions(+), 64 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2

[PATCH v7 3/3] drm: Switch to %p4cc format modifier

2021-02-15 Thread Sakari Ailus
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a large number of temporary variables at the same time. Signed-off-by: Sakari Ailus --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 5 ++-- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c| 5 ++-- drivers/gpu/drm/amd

[PATCH v7 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-15 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by

[PATCH v7 0/3] Add %p4cc printk modifier for V4L2 and DRM fourcc codes

2021-02-15 Thread Sakari Ailus
ll as change the DRM fourcc printing function to use %p4cc. - Add missing checkpatch.pl checks for %p4cc modifier. Sakari Ailus (3): lib/vsprintf: Add support for printing V4L2 and DRM fourccs v4l: ioctl: Use %p4cc printk modifier to print FourCC codes drm: Switch to %p4cc format modifier

Re: [PATCH v6 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-12 Thread Sakari Ailus
Hi Petr, Thanks for the comments. On Thu, Feb 11, 2021 at 06:14:28PM +0100, Petr Mladek wrote: > On Tue 2021-02-09 19:47:55, Sakari Ailus wrote: > > Hi Andy, > > > > On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote: > > > On Tue, Feb 09, 2021 at

Re: [PATCH v6 2/3] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-12 Thread Sakari Ailus
Hi Petr, On Thu, Feb 11, 2021 at 05:31:46PM +0100, Petr Mladek wrote: > On Mon 2021-02-08 22:09:02, Sakari Ailus wrote: > > Now that we can print FourCC codes directly using printk, make use of the > > feature in V4L2 core. > > > > Signed-off-by: Sakari Ailus >

Re: [PATCH v6 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-09 Thread Sakari Ailus
Hi Andy, On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote: > On Tue, Feb 09, 2021 at 11:20:32AM +0200, Sakari Ailus wrote: > > On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote: > > > On Mon, Feb 8, 2021 at 10:11 PM Sakari

Re: [PATCH v6 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-09 Thread Sakari Ailus
Hi Andy, On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote: > On Mon, Feb 8, 2021 at 10:11 PM Sakari Ailus > wrote: > > > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by fourccs. The fourcc encoding is

Re: [PATCH v6 3/3] drm/fourcc: Switch to %p4cc format modifier

2021-02-09 Thread Sakari Ailus
Hi Daniel, Thanks for the comments. On Tue, Feb 09, 2021 at 08:27:10AM +0100, Daniel Vetter wrote: > On Mon, Feb 8, 2021 at 9:20 PM Sakari Ailus > wrote: > > > > Instead of constructing the FourCC code manually, use the %p4cc printk > > modifier to print it. Also leave

[PATCH v6 1/3] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2021-02-08 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus Reviewed-by: Petr Mladek Reviewed-by

[PATCH v6 2/3] v4l: ioctl: Use %p4cc printk modifier to print FourCC codes

2021-02-08 Thread Sakari Ailus
Now that we can print FourCC codes directly using printk, make use of the feature in V4L2 core. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++- 1 file changed, 21 insertions(+), 64 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2

[PATCH v6 0/3] Add %p4cc printk modifier for V4L2 and DRM fourcc codes

2021-02-08 Thread Sakari Ailus
. Sakari Ailus (3): lib/vsprintf: Add support for printing V4L2 and DRM fourccs v4l: ioctl: Use %p4cc printk modifier to print FourCC codes drm/fourcc: Switch to %p4cc format modifier Documentation/core-api/printk-formats.rst | 16 + drivers/gpu/drm/drm_fourcc.c | 16

[PATCH v6 3/3] drm/fourcc: Switch to %p4cc format modifier

2021-02-08 Thread Sakari Ailus
Instead of constructing the FourCC code manually, use the %p4cc printk modifier to print it. Also leave a message to avoid using this function. The next step would be to convert the users to use %p4cc directly instead and removing the function. Signed-off-by: Sakari Ailus --- drivers/gpu/drm

Re: [PATCH] dt-bindings: Drop unnecessary *-supply schemas properties

2020-12-22 Thread Sakari Ailus
gt; > Cc: Jonathan Cameron > Cc: Dmitry Torokhov > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Sakari Ailus > Cc: Lee Jones > Cc: Mark Brown > Cc: Maxime Ripard > Cc: dri-devel@lists.freedesktop.org > Cc: linux-...@vger.kernel.org > Cc: linux-in...

Re: [PATCH v5 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-12-10 Thread Sakari Ailus
Hi Andy, On Thu, Dec 10, 2020 at 03:05:02PM +0200, Andy Shevchenko wrote: > On Thu, Dec 10, 2020 at 2:16 PM Petr Mladek wrote: > > On Fri 2020-11-13 12:54:41, Sakari Ailus wrote: > > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > > pixel

[PATCH v5 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-11-13 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus --- since v4: - Use correct destination

Re: [PATCH v4 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-11-13 Thread Sakari Ailus
Hi Joe, On Tue, Nov 03, 2020 at 08:49:36AM -0800, Joe Perches wrote: > On Tue, 2020-11-03 at 16:56 +0200, Sakari Ailus wrote: > > On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote: > > > On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote: > > &

Re: [PATCH v4 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-11-03 Thread Sakari Ailus
Hi Andy, On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote: > On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote: > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by fourccs. The fourcc encoding is th

[PATCH v4 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-11-03 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus --- Hi folks, I believe I've addr

Re: [RESEND PATCH v3 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-11-03 Thread Sakari Ailus
Hi Rasmus, Thanks for the review. On Mon, Apr 27, 2020 at 05:44:00PM +0200, Rasmus Villemoes wrote: > On 27/04/2020 16.53, Sakari Ailus wrote: > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by fourccs. The fourcc encoding

Re: [PATCH 17/18] media/omap3isp: Clean up IOMMU workaround

2020-08-20 Thread Sakari Ailus
On Thu, Aug 20, 2020 at 06:25:19PM +0100, Robin Murphy wrote: > On 2020-08-20 17:53, Sakari Ailus wrote: > > Hi Robin, > > > > On Thu, Aug 20, 2020 at 04:08:36PM +0100, Robin Murphy wrote: > > > Now that arch/arm is wired up for default domains and iommu-dma, device

Re: [PATCH 17/18] media/omap3isp: Clean up IOMMU workaround

2020-08-20 Thread Sakari Ailus
iled -8<--- -- Kind regards, Sakari Ailus ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/fourcc: Add bayer formats and modifiers

2020-05-25 Thread Sakari Ailus
> + *+ - - - - - - - - + - - - - - - - - + - - - - - > - - - + - - - - - - - - + > + *| b0 b0 g0 g0 g0 g0 g0 g0 | g1 g1 g1 g1 b0 b0 b0 b0 | b1 b1 b1 b1 b1 > b1 g1 g1 | g2 g2 g2 g2 g2 g2 g2 g2 | > + *+ - - - - - - - - + - - - - - - - - + - - - - - > - - - + - - -

Re: [PATCH 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-27 Thread Sakari Ailus
On Mon, Apr 27, 2020 at 05:50:07PM +0300, Sakari Ailus wrote: > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM > pixel formats denoted by fourccs. The fourcc encoding is the same for both > so the same implementation can be used. > > Suggested-by: Mauro

[RESEND PATCH v3 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-27 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus --- since v2: - Add comments to explain

[PATCH 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-27 Thread Sakari Ailus
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM pixel formats denoted by fourccs. The fourcc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus --- Documentation/core-api/printk

Re: [PATCH 04/29] staging: media: ipu3: use vmap instead of reimplementing it

2020-04-23 Thread Sakari Ailus
On Tue, Apr 14, 2020 at 03:13:23PM +0200, Christoph Hellwig wrote: > Just use vmap instead of messing with vmalloc internals. > > Signed-off-by: Christoph Hellwig > Acked-by: Peter Zijlstra (Intel) Thanks! Acked-by: Sakari Ailus --

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-06 Thread Sakari Ailus
Hi Rasmus, Thanks for the comments. On Fri, Apr 03, 2020 at 02:10:53PM +0200, Rasmus Villemoes wrote: > On 03/04/2020 11.11, Sakari Ailus wrote: > > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by 4ccs. The 4cc encoding is the s

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-06 Thread Sakari Ailus
Hi Laurent, On Sat, Apr 04, 2020 at 03:21:47AM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Sat, Apr 04, 2020 at 03:14:25AM +0300, Sakari Ailus wrote: > > On Fri, Apr 03, 2020 at 09:32:42PM +0300, Andy Shevchenko wrote: > > > On Fri, Apr 3, 2020 at 8:54 PM Joe Pe

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
borate? This could be already used on DRM, presumably, and that does not depend on CONFIG_MEDIA_SUPPORT. I don't know how much there would be a need for that, though, but this remains a possibility. -- Sakari Ailus ___ dri-devel mailing list dr

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
Hi Joe, On Fri, Apr 03, 2020 at 11:38:29AM -0700, Joe Perches wrote: > On Fri, 2020-04-03 at 13:47 +0300, Sakari Ailus wrote: > > On Fri, Apr 03, 2020 at 01:24:49PM +0300, Laurent Pinchart wrote: > > > On Fri, Apr 03, 2020 at 12:11:56PM +0300, Sakari Ailus wrote: > > &

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
Hi Laurent, Thanks for the comments. On Fri, Apr 03, 2020 at 01:24:49PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Fri, Apr 03, 2020 at 12:11:56PM +0300, Sakari Ailus wrote: > > Add a printk modifier %ppf (for pixel format) for

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
Hi Andy, On Fri, Apr 03, 2020 at 12:54:41PM +0300, Andy Shevchenko wrote: > On Fri, Apr 03, 2020 at 12:39:16PM +0300, Sakari Ailus wrote: > > On Fri, Apr 03, 2020 at 12:31:03PM +0300, Andy Shevchenko wrote: > > > On Fri, Apr 03, 2020 at 12:11:56PM +0300, Sakari Ailus wrote: &g

Re: [PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
Hi Andy, Thanks for the comments. On Fri, Apr 03, 2020 at 12:31:03PM +0300, Andy Shevchenko wrote: > On Fri, Apr 03, 2020 at 12:11:56PM +0300, Sakari Ailus wrote: > > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by 4ccs. The

[PATCH v2 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-03 Thread Sakari Ailus
Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM pixel formats denoted by 4ccs. The 4cc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus --- since v1: - Improve documentation (add -BE

Re: [PATCH 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-02 Thread Sakari Ailus
Moi, On Thu, Apr 02, 2020 at 11:34:48AM +0300, Jani Nikula wrote: > On Wed, 01 Apr 2020, Sakari Ailus wrote: > > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by 4ccs. The 4cc encoding is the same for both so > > the same

Re: [PATCH 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-02 Thread Sakari Ailus
Hi Andy, Thanks for the review. On Wed, Apr 01, 2020 at 06:13:32PM +0300, Andy Shevchenko wrote: > On Wed, Apr 01, 2020 at 04:13:51PM +0200, Hans Verkuil wrote: > > On 4/1/20 4:05 PM, Sakari Ailus wrote: > > > Add a printk modifier %ppf (for pixel format) for printing V4L2 a

Re: [PATCH 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-02 Thread Sakari Ailus
Hi Hans, Thank you for the review. On Wed, Apr 01, 2020 at 04:13:51PM +0200, Hans Verkuil wrote: > On 4/1/20 4:05 PM, Sakari Ailus wrote: > > Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM > > pixel formats denoted by 4ccs. The 4cc encoding is the s

[PATCH 1/1] lib/vsprintf: Add support for printing V4L2 and DRM fourccs

2020-04-01 Thread Sakari Ailus
Add a printk modifier %ppf (for pixel format) for printing V4L2 and DRM pixel formats denoted by 4ccs. The 4cc encoding is the same for both so the same implementation can be used. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus --- Documentation/core-api/printk-formats.rst

Re: [PATCH] drm/fourcc: Add bayer formats and modifiers

2020-03-04 Thread Sakari Ailus
e DRM_FORMAT_MOD_ALLWINNER_TILED fourcc_mod_code(ALLWINNER, 1) > > +/* Mobile Industry Processor Interface (MIPI) modifiers */ > + > +/* > + * MIPI CSI-2 packing layout > + * > + * The CSI-2 RAW formats (for example Bayer) use a different packing layout > + * depenindg on

Re: [PATCH v3 10/12] media: constify fb ops across all drivers

2019-12-04 Thread Sakari Ailus
(Christophe de Dinechin) > > Cc: Hans Verkuil > Cc: Andy Walls > Cc: linux-me...@vger.kernel.org > Cc: ivtv-de...@ivtvdriver.org > Reviewed-by: Daniel Vetter > Signed-off-by: Jani Nikula Reviewed-by: Sakari Ailus -- Sakari Ailus ___

Re: [PATCH v3 11/41] media/v4l2-core/mm: convert put_page() to put_user_page*()

2019-08-07 Thread Sakari Ailus
s is part a tree-wide conversion, as described in commit fc1d8e7cca2d > ("mm: introduce put_user_page*(), placeholder versions"). > > Cc: Mauro Carvalho Chehab > Cc: Kees Cook > Cc: Hans Verkuil > Cc: Sakari Ailus > Cc: Jan Kara > Cc: Robin Murphy >

Re: [PATCH v5 2/3] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8 media bus format

2019-06-06 Thread Sakari Ailus
On Thu, Jun 06, 2019 at 12:22:46AM +0200, Paul Cercueil wrote: > This patch adds MEDIA_BUS_FMT_RGB888_3X8, used for the GiantPlus > GPM940B0 24-bit TFT panel, where the RGB components are transferred > sequentially on a 8-bit bus. > > Signed-off-by: Paul Cercueil Acked-b

Re: [PATCH 19/20] lib: image-formats: Add more functions

2019-04-17 Thread Sakari Ailus
: plane index > + * > + * Returns: > + * The size of the plane buffer. Similarly: Returns the minimum size of the plane buffer. With these, Acked-by: Sakari Ailus > + */ > +static inline > +unsigned int image_format_info_plane_size(const struct image_format_info >

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-02-07 Thread Sakari Ailus
works as expected with all sglists. A new > iterator type is introduced to provide compile-time safety against wrongly > mixing accessors and iterators. > > Signed-off-by: Jason Gunthorpe Acked-by: Sakari Ailus (ipu3-cio2) -- Sakari Ailus sakari.ai...@linux.intel.com

Re: [PATCH v4 8/9] phy: Add Cadence D-PHY support

2019-01-09 Thread Sakari Ailus
e > the v4l2 drivers are completely missing any phy support. In order to make > that phy support available to all these drivers, without having to > duplicate that code three times, let's create a generic phy framework > driver. > > Signed-off-by: Maxime Ripard Reviewed-

Re: [PATCH v4 7/9] dt-bindings: phy: Move the Cadence D-PHY bindings

2019-01-09 Thread Sakari Ailus
ff-by: Maxime Ripard Reviewed-by: Sakari Ailus Could you also send this to the devicetree list, please? > --- > Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt | 21 +--- > Documentation/devicetree/bindings/phy/cdns,dphy.txt | 20 +++- > 2 files changed

Re: [PATCH v4 0/9] phy: Add configuration interface for MIPI D-PHY devices

2019-01-09 Thread Sakari Ailus
Let me know what you think, > Maxime > > Changes from v3 > - Rebased on 5.0-rc1 > - Added the fixes suggested by Sakari Thanks! For patches 1--3: Acked-by: Sakari Ailus -- Sakari Ailus ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-17 Thread sakari . ailus
between the two devices on hardware, and this field is specifying how many of them are in use. In order for the bus to function, both ends need to be in agreement on which of these lanes are actually being used. The current practice I've seen without exceptions is that these are the first

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-13 Thread sakari . ailus
> + * from ULPS. > + * > + * Minimum value: 10 ps > + */ > + unsigned intwakeup; This is very close to the higher limit of the type's value range. How about using ns or µs for this one? -- Sakari Ailus __

  1   2   3   >