Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-12 Thread Sam Ravnborg
Hi Anitha. On Fri, Sep 11, 2020 at 08:54:41PM +, Chrisanthus, Anitha wrote: > Hi Neil, > Thanks for your review. Is a device tree binding document like this one > enough? Entries for kmb-drm are similar to this. >

Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-09-10 Thread Sam Ravnborg
Hi Laurentiu > > > I've tested this together with a hacked up eDP bridge driver stack on > > > my boards. The testing hasn't been really in-depth, but things seem to > > > work fine. I have now pushed the whole series into drm-misc-next. > > > > Something doesn't compile too well > > > > ERROR:

Re: [PATCH v7 2/4] drm/kmb: Add support for KeemBay Display

2020-09-10 Thread Sam Ravnborg
Hi Daniel. > > + } > > + > > + /* Initialize MIPI DSI */ > > + ret = kmb_dsi_init(drm, adv_bridge); > > Split up isn't correct here, this won't compile since the dsi code isn't > in this patch yet. So you need to have this ordered the other way round. I have explicit asked for a simple

Re: [PATCH v4] gpu/drm: ingenic: Add option to mmap GEM buffers cached

2020-09-10 Thread Sam Ravnborg
Hi Paul. On Wed, Sep 09, 2020 at 03:26:52PM +0200, Paul Cercueil wrote: > Any love for my patch? I have more pending :) I have looked through the patch a few times. And I did not find any spelling errors. But the memory magic was beyond me so I hope someone more knowledgeable can chime in here.

Re: [PATCH v2 3/3] drm: panel: add TDO tl070wsh30 panel driver

2020-09-07 Thread Sam Ravnborg
Hi Neil. On Mon, Sep 07, 2020 at 01:10:27PM +0200, Neil Armstrong wrote: > This adds support for the TDO TL070WSH30 TFT-LCD panel module. > The panel has a 1024×600 resolution and uses 24 bit RGB per pixel. > It provides a MIPI DSI interface to the host, a built-in LED backlight > and touch

Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings

2020-09-07 Thread Sam Ravnborg
Hi Neil. On Mon, Sep 07, 2020 at 03:24:47PM +0200, Neil Armstrong wrote: > Hi, > > On 07/09/2020 13:45, Sam Ravnborg wrote: > > Hi Neil. > > > > On Mon, Sep 07, 2020 at 01:10:26PM +0200, Neil Armstrong wrote: > >> This add the bindings for the 1024*600 tl070w

Re: [PATCH v2 2/3] dt-bindings: display: panel: add TDO tl070wsh30 DSI panel bindings

2020-09-07 Thread Sam Ravnborg
Hi Neil. On Mon, Sep 07, 2020 at 01:10:26PM +0200, Neil Armstrong wrote: > This add the bindings for the 1024*600 tl070wsh30 DSI panel. The binding looks like a panel-simple-dsi.yaml candidate. Only differen is enable-gpios versus reset-gpios Could you check if we can use panel-simple-dsi-yaml.

Re: [PATCH 0/2] drm: panel: add support for TDO tl070wsh30 panel

2020-09-07 Thread Sam Ravnborg
On Mon, Sep 07, 2020 at 12:33:41PM +0200, Neil Armstrong wrote: > Hi, > > Please ignore this serie, the vendors patch is missing and the panel driver > still has the vrefresh... > > Will repost. Please fix so DRM_DEV_* is replaced by dev_* logging. We no longer use the DRM_ based logging for

Re: [PATCH 40/59] drm/arcpgu: Stop using drm_device->dev_private

2020-09-04 Thread Sam Ravnborg
Hi Daniel. On Fri, Sep 04, 2020 at 03:42:44PM +0200, Daniel Vetter wrote: > On Fri, Apr 24, 2020 at 6:46 PM Sam Ravnborg wrote: > > > > Hi Daniel. > > > > On Wed, Apr 15, 2020 at 09:40:15AM +0200, Daniel Vetter wrote: > > > Upcasting using a contain

Re: [v4,04/15] drm/bridge: tc358764: add drm_panel_bridge support

2020-08-30 Thread Sam Ravnborg
Hi Marek. On Thu, Aug 27, 2020 at 01:39:06PM +0200, Marek Szyprowski wrote: > Hi Sam, > > On 26.07.2020 22:33, Sam Ravnborg wrote: > > Prepare the tc358764 bridge driver for use in a chained setup by > > replacing direct use of drm_panel with drm_panel_bridge support. >

Re: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-30 Thread Sam Ravnborg
Hi Laurent. > > > > Please read the cover letter, it explains why it's done this way. The > > whole point of this patchset is to merge DSI and DBI frameworks in a > > way that can be maintained. > > I think this proves the point that the proposed naming is confusing. At > least a rename would

Re: [PATCH] drm: panel: Fix bpc for OrtusTech COM43H4M85ULC panel

2020-08-29 Thread Sam Ravnborg
On Mon, Aug 24, 2020 at 03:32:54AM +0300, Laurent Pinchart wrote: > The OrtusTech COM43H4M85ULC panel is a 18-bit RGB panel. Commit > f098f168e91c ("drm: panel: Fix bus format for OrtusTech COM43H4M85ULC > panel") has fixed the bus formats, but forgot to address the bpc value. > Set it to 6. > >

Re: [PATCH v5 2/2] drm: panel: Add novatek nt36672a panel driver

2020-08-29 Thread Sam Ravnborg
Hi Sumit. On Wed, Aug 26, 2020 at 09:33:08PM +0530, Sumit Semwal wrote: > Novatek NT36672a is a generic DSI IC that drives command and video mode > panels. Add the driver for it. > > Right now adding support for some Poco F1 phones that have an LCD panel > from Tianma connected with this IC,

Re: [PATCH v5 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

2020-08-29 Thread Sam Ravnborg
Hi Sumit. On Wed, Aug 26, 2020 at 09:33:07PM +0530, Sumit Semwal wrote: > Novatek nt36672a is a display driver IC that can drive DSI panel. It > is also present in the Tianma video mode panel, which is a FHD+ panel > with a resolution of 1080x2246 and 6.18 inches size. It is found in > some of

Re: [PATCH v2 2/2] drm/ingenic: Fix driver not probing when IPU port is missing

2020-08-29 Thread Sam Ravnborg
o > probe. > > Fix the driver so that it will probe even if the IPU node is not present > in devicetree (but then IPU support is disabled of course). > > v2: Take a different approach > > Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") > Signed-of

Re: [PATCH v2 1/2] drm/ingenic: Fix leak of device_node pointer

2020-08-29 Thread Sam Ravnborg
On Thu, Aug 27, 2020 at 01:44:03PM +0200, Paul Cercueil wrote: > of_graph_get_remote_node() requires of_node_put() to be called on the > device_node pointer when it's no more in use. > > Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") > Signed-off-by: Paul C

Re: [PATCH 1/4] dt-bindings: display: samsung,amoled-mipi-dsi: Do not require enable-gpios on samsung,s6e63j0x03

2020-08-29 Thread Sam Ravnborg
> > Signed-off-by: Krzysztof Kozlowski Acked-by: Sam Ravnborg I expect this patch is picked up with the dts fixes. Sam > --- > .../display/panel/samsung,amoled-mipi-dsi.yaml | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git &

Re: [PATCH v2 1/2] dt-bindings: display: simple: Add AM-1280800N3TZQW-T00H

2020-08-29 Thread Sam Ravnborg
Hi Jagan. On Sat, Aug 29, 2020 at 10:03:27PM +0530, Jagan Teki wrote: > Add dt-bindings for 10.1" TFT LCD module from Ampire Co. Ltd. > as part of panel-simple. > > Signed-off-by: Jagan Teki Thanks for the quick update. Applied both patches to drm-misc-next. Sam > --- > Changes for

Re: [PATCH] drm/bridge: Fix the dsi remote end-points

2020-08-29 Thread Sam Ravnborg
On Fri, Aug 28, 2020 at 01:12:50PM +0530, Vinod Koul wrote: > DSI end-points are supposed to be at node 0 and node 1 as per binding. > So fix this and use node 0 and node 1 for dsi. > > Reported-by: Dmitry Baryshkov > Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") >

Re: [PATCH] drm/panel: rm67191: Remove CLOCK_NON_CONTINUOUS flag

2020-08-29 Thread Sam Ravnborg
On Fri, Aug 28, 2020 at 05:58:33PM +0300, Robert Chiras (OSS) wrote: > From: Robert Chiras > > The flag MIPI_DSI_CLOCK_NON_CONTINUOUS was wrong used in the DSI driver, > so it was added to this panel, but not necessary. > So, remove this flag since it is not needed. > > Signed-off-by: Robert

Re: [PATCH v9 0/5] Add support for iMX8MQ Display Controller Subsystem

2020-08-29 Thread Sam Ravnborg
Hi Laurentiu. > As to who is going to do the actual merge, I know we had a brief > discussion about it some time ago and I was supposed to apply for > drm-misc rights, however it feels a little awkward to merge my own > code... :) You are encouraged to commit your own code, it is anyway you who

Re: [PATCH v2 2/3] drm: bridge: add support for lontium LT9611UXC bridge

2020-08-28 Thread Sam Ravnborg
Hi Dmitry On Fri, Aug 28, 2020 at 06:49:05PM +0300, Dmitry Baryshkov wrote: > Add support for Lontium LT9611UXC HDMI bridge. Lontium LT9611UXC is a > DSI to HDMI bridge which supports two DSI ports and I2S port as an input > and HDMI port as output. Despite name being similar to LT9611, these >

Re: [PATCH v2 1/3] dt-bindings: display: bridge: Add documentation for LT9611UXC

2020-08-28 Thread Sam Ravnborg
ompatible > with the LT9611 chip, so let's reuse the lt9611.yaml schema. > > Signed-off-by: Dmitry Baryshkov > Acked-by: Vinod Koul Acked-by: Sam Ravnborg We can apply this when the driver is ready. Sam > --- > .../devicetree/bindings/display/bridge/lontium,lt9611.yaml | 5

Re: [PATCH 2/2] drm: panel: simple: Add AM-1280800N3TZQW-T00H

2020-08-28 Thread Sam Ravnborg
Hi Jagan. On Fri, Aug 28, 2020 at 09:29:38PM +0530, Jagan Teki wrote: > Add Ampire, AM-1280800N3TZQW-T00H 10.1" TFT LCD panel timings. > > Signed-off-by: Jagan Teki > --- > drivers/gpu/drm/panel/panel-simple.c | 28 > 1 file changed, 28 insertions(+) > > diff

Re: [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-08-28 Thread Sam Ravnborg
Hi Kevin. > > > > Any specific reason why this is not a ports node like used by many other > > display bindings? > > In other words - I think this is too simple. > We only support one display pipeline now, other interface, like > DP(DisplayPort), HDMI...will be add later... > > ports: >

Re: [PATCH RFC v6 2/6] drm/sprd: add Unisoc's drm kms master

2020-08-28 Thread Sam Ravnborg
Hi Kevin > > > > > + > > > + drm->dev_private = sprd; > > dev_private is deprecated. Alwyas use upclassing. > dev_private is deprecated ? I see everyone is still using it, so it > will be deprecated in the future? It is deprecated - and a lot of drivers is in need up an update to get away

Re: [PATCH] drm/ingenic: Fix driver not probing when IPU port is missing

2020-08-26 Thread Sam Ravnborg
Hi Paul. On Wed, Aug 26, 2020 at 11:58:41PM +0200, Paul Cercueil wrote: > Even if support for the IPU was compiled in, we may run on a device > (e.g. the Qi LB60) where the IPU is not available, or simply with an old > devicetree without the IPU node. In that case the ingenic-drm refused to >

Re: [PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling

2020-08-26 Thread Sam Ravnborg
rieve the EDID. > > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v2: > - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg) > > drivers/gpu/drm/bridge/parade-ps8640.c | 64 +++--- > 1 file changed, 58 insertions(+), 6 d

Re: [PATCH v2 0/5] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-08-26 Thread Sam Ravnborg
d the patch `drm/bridge: ps8640: Get the EDID from eDP control` > - Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg) > > Enric Balletbo i Serra (5): > drm/bridge_connector: Set default status connected for eDP connectors > drm/bridge: ps8640: Get the EDID from eDP

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-25 Thread Sam Ravnborg
Hi Mauro. Laurent and I discussed this driver a little on irc. Some highlights: This parts could use register names: + writel(0x2, noc_dss_base + 0xc); + writel(0x2, noc_dss_base + 0x8c); + writel(0x2, noc_dss_base + 0x10c); + writel(0x2, noc_dss_base + 0x18c); The two

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-25 Thread Sam Ravnborg
Hi Mauro > Before posting the big patch series again, let me send the new > version folded into a single patch. > > If you'd like to see the entire thing, I'm placing it here: > > > https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/hikey970_v2/ Review 3/3 For next

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-24 Thread Sam Ravnborg
Hi Mauro > Before posting the big patch series again, let me send the new > version folded into a single patch. Review 2/N The way output_poll_changed is used to set gpio_mux to select between the panel and the HDMI looks strange. But I do not know if there is a more correct way to do it. Other

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-24 Thread Sam Ravnborg
Hi Mauro > kirin9xx_fb_panel.h b/drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h > new file mode 100644 > index ..a69c20470f1d > --- /dev/null > +++ b/drivers/staging/hikey9xx/gpu/kirin9xx_fb_panel.h This file is not referenced and should be deleted. Sam

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-24 Thread Sam Ravnborg
Hi Mauro. > Before posting the big patch series again, let me send the new > version folded into a single patch. Review 1/N Lots of small details I missed last time. A good thing is that there is an opportunity to delete som more code. Sam > diff --git

Re: [PATCH] drm/brige/megachips: Add checking if ge_b850v3_lvds_init() is working correctly

2020-08-23 Thread Sam Ravnborg
Hi Nadezda On Wed, Aug 19, 2020 at 05:37:56PM +0300, Nadezda Lutovinova wrote: > If ge_b850v3_lvds_init() does not allocate memory for ge_b850v3_lvds_ptr, > then a null pointer dereference is accessed. > > The patch adds checking of the return value of ge_b850v3_lvds_init(). > > Found by Linux

Re: [PATCH] drm/bridge/tc358775: Fix for PTR_ERR

2020-08-23 Thread Sam Ravnborg
On Sun, Aug 16, 2020 at 11:20:41AM +0530, Vinay Simha BN wrote: > passing zero to 'PTR_ERR' > > Reported-by: kernel test robot > Signed-off-by: Vinay Simha BN Applied to drm-misc-next - thanks. Sam > --- > drivers/gpu/drm/bridge/tc358775.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PATCH v2 21/24] drm/amdgpu/atom: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use macros for initialization - Replace direct access to backlight_properties with get and set operations Signed-off-by: Sam Ravnborg Cc: Alex Deucher Cc: Christian König Cc: amd-...@lists.freedesktop.org Cc: Sam Ravnborg --- .../gpu/drm/amd/amdgpu/atombios_encoders.c| 19

[PATCH v2 18/24] drm/bridge: parade-ps8622: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use blacklight_get_brightness() helper - Use devm_ variant to register backlight device and drop explicit unregister - Use macro for initialization Signed-off-by: Sam Ravnborg Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec --- drivers/gpu

[PATCH v2 22/24] drm/i915: Backlight update

2020-08-23 Thread Sam Ravnborg
is that the confusing power states are now replaced by backligt_{enable,disable}. Signed-off-by: Sam Ravnborg Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: "Ville Syrjälä" Cc: Chris Wilson Cc: Manasi Navare Cc: Wambui Karuga Cc: Hans de Goede Cc: Maarten Lankhorst Cc: Sa

[PATCH v2 20/24] drm/radeon: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use macros for initialization - Replace direct access to backlight_properties with get and set operations Signed-off-by: Sam Ravnborg Cc: Alex Deucher Cc: Christian König Cc: amd-...@lists.freedesktop.org --- drivers/gpu/drm/radeon/atombios_encoders.c| 24 +-- .../gpu

[PATCH v2 08/24] drm/panel: asus-z00t-tm5p5-n35596: Backlight update

2020-08-23 Thread Sam Ravnborg
Update backlight to use macro for initialization and the backlight_get_brightness() operation to simply the update operation. Signed-off-by: Sam Ravnborg Cc: Konrad Dybcio Cc: Thierry Reding Cc: Sam Ravnborg --- .../gpu/drm/panel/panel-asus-z00t-tm5p5-n35596.c | 15 +++ 1 file

[PATCH v2 06/24] backlight: gpio: Use DECLARE_BACKLIGHT_INIT_RAW

2020-08-23 Thread Sam Ravnborg
Introduce use of DECLARE_BACKLIGHT_INIT_RAW when registering the backlight. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/gpio_backlight.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/video

[PATCH v2 14/24] drm/panel: samsung-s6e63j0x03: Backlight update

2020-08-23 Thread Sam Ravnborg
unregistering. Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Hoegeun Kwon Cc: Inki Dae Cc: Sam Ravnborg --- .../gpu/drm/panel/panel-samsung-s6e63j0x03.c | 53 +-- 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63j0x03

[PATCH v2 16/24] drm/panel: sony-acx424akp: Backlight update

2020-08-23 Thread Sam Ravnborg
is using the backlight enable/disable helpers. - Use macro for backlight initialization Signed-off-by: Sam Ravnborg Acked-by: Linus Walleij Cc: Linus Walleij Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-sony-acx424akp.c | 49 1 file changed, 9

[PATCH v2 09/24] drm/panel: jdi-lt070me05000: Backlight update

2020-08-23 Thread Sam Ravnborg
(). This is the order that is required by drm_panel. v2: - Use drm_panel based backlight Signed-off-by: Sam Ravnborg Cc: Vinay Simha BN Cc: Thierry Reding Cc: Sam Ravnborg --- .../gpu/drm/panel/panel-jdi-lt070me05000.c| 58 --- 1 file changed, 11 insertions(+), 47

[PATCH v2 03/24] backlight: Add get/set operations for brightness properties

2020-08-23 Thread Sam Ravnborg
the brightness and enable the backlight. The backlight_update_brightness() force the brightness update and typical usage is to set brightness after registering a backlight device. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 74

[PATCH v2 13/24] drm/panel: samsung-s6e63m0: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use drm_panel backlight support - Use macro for backlight initialization Signed-off-by: Sam Ravnborg Cc: Paweł Chmiel Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 25 +++ 1 file changed, 9 insertions(+), 16 deletions(-) diff --git

[PATCH v2 01/24] backlight: Silently fail backlight_update_status() if no device

2020-08-23 Thread Sam Ravnborg
backlight_update_status() may be called from code that does not have any valid backlight device. To avoid ifdeffery and too much conditionals silently fail if the backlight_device is NULL. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux

[PATCH v2 07/24] drm/gma500: Backlight update

2020-08-23 Thread Sam Ravnborg
) - Signed-off-by: Sam Ravnborg Cc: Patrik Jakobsson --- drivers/gpu/drm/gma500/backlight.c | 34 +--- drivers/gpu/drm/gma500/cdv_device.c | 24 +++-- drivers/gpu/drm/gma500/mdfld_device.c| 9 ++- drivers/gpu/drm/gma500/oaktrail_device.c | 10

[PATCH v2 04/24] backlight: gpio: Introduce backlight_{enable, disable}

2020-08-23 Thread Sam Ravnborg
Use backlight_{enable,disable} in the probe function to avoid hardcoding power handling in the driver. Move platform_set_drvdata() up as the enable/disable call will trigger a callback to the driver. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers

[PATCH v2 05/24] backlight: gpio: Use dev_err_probe()

2020-08-23 Thread Sam Ravnborg
Use dev_err_probe() to make some of the error handling simpler in the probe function. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- drivers/video/backlight/gpio_backlight.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

[PATCH v2 12/24] drm/panel: raydium-rm67191: Backlight update

2020-08-23 Thread Sam Ravnborg
- Replace direct access to backlight_properties with backlight_get_brightness(). - Use macro for initialization Signed-off-by: Sam Ravnborg Cc: Robert Chiras Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-raydium-rm67191.c | 11 +++ 1 file changed, 3 insertions

[PATCH v2 17/24] drm/panel: sony-acx565akm: Backlight update

2020-08-23 Thread Sam Ravnborg
drm_panel_init Signed-off-by: Sam Ravnborg Cc: Laurent Pinchart Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-sony-acx565akm.c | 47 +++- 1 file changed, 15 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c b/drivers

[PATCH v2 11/24] drm/panel: orisetech-otm8009a: Backlight update

2020-08-23 Thread Sam Ravnborg
- Replace direct access to backlight_properties with backlight_get_brightness(). - Use brightness and not power to determine if backlight is off - Use the devm_ variant for registering backlight device, and drop all explicit unregistering of the backlight device. Signed-off-by: Sam Ravnborg

[PATCH v2 02/24] backlight: Add DECLARE_* macro for device registration

2020-08-23 Thread Sam Ravnborg
are initialized. Signed-off-by: Sam Ravnborg Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han --- include/linux/backlight.h | 63 +++ 1 file changed, 63 insertions(+) diff --git a/include/linux/backlight.h b/include/linux/backlight.h index 190963ffb7fc

[PATCH v2 23/24] drm/omap: display: Backlight update

2020-08-23 Thread Sam Ravnborg
(Sebastian) Signed-off-by: Sam Ravnborg Cc: Tomi Valkeinen Cc: Sebastian Reichel Cc: Laurent Pinchart Cc: Zheng Bin Cc: Sam Ravnborg --- .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 37 +++ 1 file changed, 6 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 24/24] drm/shmobile: Backlight update

2020-08-23 Thread Sam Ravnborg
- Use get/set methods for backlight_properties - Use macro for backlight initialization Signed-off-by: Sam Ravnborg Cc: Laurent Pinchart Cc: Kieran Bingham Cc: linux-renesas-...@vger.kernel.org --- .../gpu/drm/shmobile/shmob_drm_backlight.c| 20 +++ 1 file changed, 7

[PATCH v2 15/24] drm/panel: samsung-s6e3ha2: Backlight update

2020-08-23 Thread Sam Ravnborg
from automatic unregistering. Drop all explicit unregistering. In s6e3ha2_disable() a 40 ms delay was dropped. Using drm_panel support backlight is disabled before display is turned off, so delay after turning off the display is irrelevant. Signed-off-by: Sam Ravnborg Cc: Thierry Reding Cc: Sam

[PATCH v2 19/24] drm/tilcdc: Backlight update

2020-08-23 Thread Sam Ravnborg
Introduce backlight_{enable,disable} to enable/disable backlight. Dropped NULL check as backlight_{enable,disable} handles this. Signed-off-by: Sam Ravnborg Cc: Rob Clark Cc: Ezequiel Garcia Cc: Jyri Sarha Cc: Tomi Valkeinen --- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 9 - 1 file

[PATCH v2 0/24] backlight: add init macros and accessors

2020-08-23 Thread Sam Ravnborg
: Patrik Jakobsson Cc: Paweł Chmiel Cc: Philippe CORNU Cc: Rob Clark Cc: Robert Chiras Cc: Rodrigo Vivi Cc: Sam Ravnborg Cc: Sebastian Reichel Cc: Thierry Reding Cc: Tomi Valkeinen Cc: "Ville Syrjälä" Cc: Vinay Simha BN Cc: Wambui Karuga Cc: Zheng Bin Sam Ra

[PATCH v2 10/24] drm/panel: novatek-nt35510: Backlight update

2020-08-23 Thread Sam Ravnborg
- Replace direct access to backlight_properties with backlight_get_brightness(). - Drop debug printout - Use macro for initialization Signed-off-by: Sam Ravnborg Cc: Linus Walleij Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 9 +++-- 1 file

Re: etnaviv crashes on dove cubox since 5.7.0 with external abort on non-linefetch (0x1808) at 0xf09c8000

2020-08-22 Thread Sam Ravnborg
Hi Josua. On Fri, Aug 21, 2020 at 03:25:36PM +0200, Ing. Josua Mayer wrote: > Dear Maintainers, readers ... > > While updating the solidrun cubox (dove) running debian from 5.6 to 5.7 > I came across a new crash in etnaviv that did not occur before - and is > also present in 5.8.0: > > [

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-08-22 Thread Sam Ravnborg
Hi Enric. On Fri, Aug 21, 2020 at 01:38:09PM +0200, Sam Ravnborg wrote: > Hi Enric. > > > > > Let me reformulate the question for if it was not clear. > > > > What I did is be able to read the EDID every time userspace asks for it (so > > kernel enables al

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-08-22 Thread Sam Ravnborg
On Mon, Jun 15, 2020 at 10:53:20PM +0200, Enric Balletbo i Serra wrote: > The get_edid() callback can be triggered anytime by an ioctl, i.e > > drm_mode_getconnector (ioctl) > -> drm_helper_probe_single_connector_modes >-> drm_bridge_connector_get_modes > ->

Re: [PATCH 2/3] drm/bridge: ps8640: Print an error if VDO control fails

2020-08-22 Thread Sam Ravnborg
Serra Reviewed-by: Sam Ravnborg > --- > > drivers/gpu/drm/bridge/parade-ps8640.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c > b/drivers/gpu/drm/bridge/parade-ps8640.c > index ce3e8b2da8c9

Re: [PATCH 1/3] drm/bridge: ps8640: Return an error for incorrect attach flags

2020-08-22 Thread Sam Ravnborg
y the new > drm_bridge model is supported. > > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Sam Ravnborg I will await the updated series before applying. > --- > > drivers/gpu/drm/bridge/parade-ps8640.c | 4 > 1 file changed, 4 insertions(+) > > diff -

Re: [PATCH 1/2] dt-bindings: display: simple: Add KD116N21-30NV-A010 compatible

2020-08-21 Thread Sam Ravnborg
Hi Douglas. On Fri, Aug 21, 2020 at 08:35:14AM -0700, Douglas Anderson wrote: > The KD116N21-30NV-A010 is a pretty standard eDP panel. Add it to the > list of compatible strings. > > Signed-off-by: Douglas Anderson Both patches applied to drm-misc-next. Sam > --- > >

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-21 Thread Sam Ravnborg
Hi Mauro. On Fri, Aug 21, 2020 at 04:41:58PM +0200, Mauro Carvalho Chehab wrote: > Another quick question: > > Em Wed, 19 Aug 2020 19:35:58 +0200 > Sam Ravnborg escreveu: > > > > +#define DSS_REDUCE(x)((x) > 0 ? ((x) - 1) : (x)) > > Use generic macros for

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-21 Thread Sam Ravnborg
Hi Mauro. Thanks for the detailed feedabck. Two comments in the following. Sam > > > > + ctx->dss_pri_clk = devm_clk_get(dev, "clk_edc0"); > > > + if (!ctx->dss_pri_clk) { > > > + DRM_ERROR("failed to parse dss_pri_clk\n"); > > > + return -ENODEV; > > > + } > ... > > > I had

Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

2020-08-21 Thread Sam Ravnborg
Hi Enric. > > Let me reformulate the question for if it was not clear. > > What I did is be able to read the EDID every time userspace asks for it (so > kernel enables all the required) and Sam is proposing to just fail if all is > not > setup. I can obviously do this but my question is, at

Re: [PATCH v6] drm/kmb: Add support for KeemBay Display

2020-08-20 Thread Sam Ravnborg
Hi Anitha. Feedback on kmb_dsi. The main feedback can be found after the kmb_dsi_init function. The highligt of the feedback is that, in my opinion, the best would be to use the drm_bridge abstraction for the kmb_dsi. Maybe because I am biased - and this is just overhead. But it just looks

Re: [PATCH v6] drm/kmb: Add support for KeemBay Display

2020-08-20 Thread Sam Ravnborg
LCD controller->mipi DSI-> ADV bridge > > Only 1080p resolution and single plane is supported at this time. > > v2: moved extern to .h, removed license text > use drm_dev_init, upclassed dev_private, removed HAVE_IRQ. > > v3: Squashed all 59 commits to one

Re: [PATCH v2 2/2] drm/panel: novatek, nt39016: Remove 'dev' field in priv struct

2020-08-20 Thread Sam Ravnborg
l->dev manually, it is done by > drm_panel_init(). > > Signed-off-by: Paul Cercueil Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-novatek-nt39016.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/pa

Re: [PATCH v2 1/2] drm/panel: novatek, nt39016: Reorder calls in probe

2020-08-20 Thread Sam Ravnborg
off-by: Paul Cercueil Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-novatek-nt39016.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c > b/drivers/gpu/drm/panel/panel-novatek-nt39016.c &g

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Sam Ravnborg
Hi Mauro. Quick feedback below. Sam On Thu, Aug 20, 2020 at 05:13:22PM +0200, Mauro Carvalho Chehab wrote: > Em Thu, 20 Aug 2020 16:48:08 +0200 > Sam Ravnborg escreveu: > > > Hi Mauro. > > > > On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-20 Thread Sam Ravnborg
Hi Mauro. On Thu, Aug 20, 2020 at 04:06:49PM +0200, Mauro Carvalho Chehab wrote: > Em Wed, 19 Aug 2020 19:35:58 +0200 > Sam Ravnborg escreveu: > > I'm already handling the other comments from your review (I'll send a > more complete comment about them after finishing), If yo

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Sam Ravnborg
Hi John. > > So, IMO, the best is to keep it on staging for a while, until those > > remaining bugs gets solved. > > I'm not sure I see all of these as compelling for pushing it in via > staging. And I suspect in the process of submitting the patches for > review folks may find the cause of some

Re: [PATCH 49/49] dt: display: Add binds for the DPE and DSI controller for Kirin 960/970

2020-08-19 Thread Sam Ravnborg
Hi Mauro. Some feedback in the following. Good to see DT schma files and not .txt files - but needs a bit more work. Sam On Wed, Aug 19, 2020 at 01:46:17PM +0200, Mauro Carvalho Chehab wrote: > Add a description of the bindings used by Kirin 960/970 Display > Serial Interface (DSI)

Re: [PATCH v14 0/2] Add initial support for slimport anx7625

2020-08-19 Thread Sam Ravnborg
Hi Xin Ji. On Mon, Aug 10, 2020 at 10:35:46PM +0200, Sam Ravnborg wrote: > Hi Xin Ji. > > On Thu, Jul 09, 2020 at 04:31:09PM +0800, Xin Ji wrote: > > Hi all, > > > > The following series add support for the Slimport ANX7625 transmitter, a > > ultra-low power

Re: [PATCH] drm/panel: novatek,nt39016: Remove 'dev' field in priv struct

2020-08-19 Thread Sam Ravnborg
Hi Paul. On Wed, Aug 19, 2020 at 08:14:12PM +0200, Paul Cercueil wrote: > There is already a 'struct device' pointer in the drm_panel structure, > that we can access easily from our priv structure, so there's no need > for a separate 'dev' field there. > > This also allows

Re: [PATCH v4 3/4] phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-08-19 Thread Sam Ravnborg
Hi Chun-Kuang Two small details below. Sam On Wed, Aug 19, 2020 at 11:44:20PM +0800, Chun-Kuang Hu wrote: > From: CK Hu > > mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_hdmi_phy driver

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread Sam Ravnborg
Hi Mauro. On Wed, Aug 19, 2020 at 01:45:28PM +0200, Mauro Carvalho Chehab wrote: > This patch series port the out-of-tree driver for Hikey 970 (which > should also support Hikey 960) from the official 96boards tree: > >https://github.com/96boards-hikey/linux/tree/hikey970-v4.9 > > Based on

Re: [PATCH v1 0/5] drm/panel: Use dev_ based logging

2020-08-18 Thread Sam Ravnborg
On Sat, Aug 15, 2020 at 02:54:01PM +0200, Sam Ravnborg wrote: > The drm/panel drivers uses a mixture of DRM_ and dev_ based logging. > With this patchset all panel drivers are migrated to use dev_ based > logging as the DRM_ based logging did not add any extra info. > > Drop

Re: [PATCH] drm/panel: s6e63m0: Order enable/disable sequence

2020-08-18 Thread Sam Ravnborg
sequence. > > Doing all of these things makes the display much more > stable on the Samsung GT-I8190 when enabling/disabling > the display pipeline. > > Cc: Paweł Chmiel > Cc: Stephan Gerhold > Signed-off-by: Linus Walleij Browsed through this patch - looks fine. Acked-by: Sam Rav

Re: [PATCH 0/4] drm/panel: s6e63m0: Add DSI transport

2020-08-18 Thread Sam Ravnborg
Hi Linus. On Sun, Aug 09, 2020 at 11:51:00PM +0200, Linus Walleij wrote: > This begins to modify the Samsung S6E63M0 driver to provide > DSI support. > > After these initial changes the driver can already be used > with the Samsung GT-I8190 (Golden) phone. > > After this initial support we will

Re: [PATCH v3 0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-18 Thread Sam Ravnborg
Hi Guido. On Mon, Aug 17, 2020 at 10:14:33AM +0200, Guido Günther wrote: > > The panel uses a Focaltech FT8006p, the touch part is handled by the already > existing edt-ft5x06. It can be found in e.g. the Librem 5. > > Changes from v2: > - Due to review comments by Sa

Re: [PATCH drm/hisilicon 0/4] Use drv_err instead of DRM_ERROR in hibmc driver

2020-08-18 Thread Sam Ravnborg
On Tue, Aug 18, 2020 at 02:51:40PM +0800, Tian Tao wrote: > patch #1 is using the drv_err instead of DRM_ERROR in hibmc_ttm.c > patch #2 is using the drv_err instead of DRM_ERROR in hibmc_drm_vdac.c > patch #3 is using the drv_err and drm_dbg_atomic instead of DRM_ERROR > and DRM_DEBUG_ATOMIC in

Re: [PATCH] drm/qxl: Fix build errors

2020-08-17 Thread Sam Ravnborg
ace deprecated function in qxl_display") We should not use Fixes for local fixes like this, as we do not want the robots to pick this commit. With the Fixes: dropped (maybe just reference the commit in the changelog): Acked-by: Sam Ravnborg > Cc: Sidong Yang > Cc: Gerd Hoffmann &g

Re: [PATCH] drm: panel: Fix bus format for OrtusTech COM43H4M85ULC panel

2020-08-16 Thread Sam Ravnborg
On Mon, Aug 17, 2020 at 03:30:45AM +0300, Laurent Pinchart wrote: > Hi Sam, > > On Thu, Aug 13, 2020 at 09:18:44PM +0200, Sam Ravnborg wrote: > > On Thu, Aug 13, 2020 at 01:02:44AM +0300, Laurent Pinchart wrote: > > > The OrtusTech COM43H4M85ULC panel is a 18-bi

Re: [PATCH v2 09/12] fbdev: i740fb: use generic power management

2020-08-16 Thread Sam Ravnborg
Hi Vaibhav On Tue, Aug 11, 2020 at 12:27:20AM +0530, Vaibhav Gupta wrote: > Drivers should do only device-specific jobs. But in general, drivers using > legacy PCI PM framework for .suspend()/.resume() have to manage many PCI > PM-related tasks themselves which can be done by PCI Core itself.

Re: [PATCH v2 01/12] fbdev: gxfb: use generic power management

2020-08-16 Thread Sam Ravnborg
Hi Vaibhav On Tue, Aug 11, 2020 at 12:27:12AM +0530, Vaibhav Gupta wrote: > Drivers should do only device-specific jobs. But in general, drivers using > legacy PCI PM framework for .suspend()/.resume() have to manage many PCI > PM-related tasks themselves which can be done by PCI Core itself.

Re: [PATCH v2 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-16 Thread Sam Ravnborg
On Sun, Aug 16, 2020 at 07:55:21PM +0200, Guido Günther wrote: > Hi Sam, > thanks for having a look! > > On Sat, Aug 15, 2020 at 11:27:27PM +0200, Sam Ravnborg wrote: > > Hi Guido. > > > > On Sat, Aug 15, 2020 at 11:16:22PM +0200, Guido Günther wrote: > >

Re: [PATCH 0/2] Modernize rocktech,jh057n00900 bindings a bit

2020-08-16 Thread Sam Ravnborg
Hi Guido. On Sun, Aug 16, 2020 at 09:13:41AM +0200, Guido Günther wrote: > This was prompted by Sam's review in > https://lore.kernel.org/dri-devel/20200815210802.ga1242...@ravnborg.org/ > and yamllint. I also added myself as maintainer, hope that's o.k. > > Guido Günther (2): > dt-bindings:

Re: [PATCH RESEND v12 0/4] Panel rotation patches

2020-08-16 Thread Sam Ravnborg
Hi Dmitry On Fri, Aug 14, 2020 at 12:56:05AM +0300, Dmitry Osipenko wrote: > Hello! > > This series adds support for display panel's DT rotation property. It's a > continuation of the work that was initially started by Derek Basehore for > the panel driver that is used by some Mediatek device

Re: [PATCH 8/8] drm: mxsfb: Add support for the bus-width DT property

2020-08-16 Thread Sam Ravnborg
Hi Laurent. On Thu, Aug 13, 2020 at 04:29:10AM +0300, Laurent Pinchart wrote: > A new bus-width DT property has been introduced in the bindings to allow > overriding the bus width. Support it. > > Signed-off-by: Laurent Pinchart We already reads the bus-width in following files in drm:

Re: [PATCH 7/8] ARM: dts: imx: Remove unneeded LCDIF disp_axi clock

2020-08-16 Thread Sam Ravnborg
On Thu, Aug 13, 2020 at 04:29:09AM +0300, Laurent Pinchart wrote: > The LCDIF disp_axi clock is not mandatory in the DT binding and not > required by the driver. Remove it when it points to a dummy clock. > > Signed-off-by: Laurent Pinchart Acked-by: Sam Ravnborg > --- >

Re: [PATCH 6/8] arm64: dts: imx8mq: Fix LCDIF compatible strings

2020-08-16 Thread Sam Ravnborg
On Thu, Aug 13, 2020 at 04:29:08AM +0300, Laurent Pinchart wrote: > The LCDIF in the i.MX8 SoCs has additional features compared to the > i.MX28. Replace the fsl,imx28-lcdif fallback compatible string with > fsl,imx6sx-lcdif to reflect that. > > Signed-off-by: Laurent Pinchart

Re: [PATCH 5/8] ARM: dts: imx: Fix LCDIF compatible strings

2020-08-16 Thread Sam Ravnborg
On Thu, Aug 13, 2020 at 04:29:07AM +0300, Laurent Pinchart wrote: > The LCDIF in the i.MX6 SoCs has additional features compared to the > i.MX28. Replace the fsl,imx28-lcdif fallback compatible string with > fsl,imx6sx-lcdif to reflect that. > > Signed-off-by: Laurent Pinchart

Re: [PATCH 4/8] dt-bindings: display: mxsfb: Rename to fsl, lcdif.yaml

2020-08-16 Thread Sam Ravnborg
On Thu, Aug 13, 2020 at 04:29:06AM +0300, Laurent Pinchart wrote: > Rename the mxsfb.yaml binding schema to fsl,lcdif.yaml to match the > usual bindings naming scheme. > > Signed-off-by: Laurent Pinchart I have been confused by the mxsfb name in the past, so this rename i welcome. A

Re: [PATCH 3/8] dt-bindings: display: mxsfb: Add a bus-width endpoint property

2020-08-16 Thread Sam Ravnborg
Hi Laurent. On Thu, Aug 13, 2020 at 04:29:05AM +0300, Laurent Pinchart wrote: > When the PCB routes the display data signals in an unconventional way, > the output bus width may differ from the bus width of the connected > panel or encoder. For instance, when a 18-bit RGB panel has its R[5:0], >

  1   2   3   4   5   6   7   8   9   10   >