Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2019-02-11 Thread Sebastian Reichel
Hi, ping & actually add the cc :) -- Sebastian On Tue, Dec 11, 2018 at 10:06:07AM +0200, Laurent Pinchart wrote: >> The problem is, that DISPC timings for DSI are not directly >> calculated from mode. Instead DSI code does some modifications >> before applying the DISPC settings. > > I wonder

Re: [PATCH v2 49/49] drm/omap: Remove panel-dpi driver

2019-02-09 Thread Sebastian Reichel
Hi, On Fri, Jan 11, 2019 at 05:51:20AM +0200, Laurent Pinchart wrote: > Panels are now supported through the drm_panel infrastructure, remove > the omapdrm-specific driver. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian Reichel > --- Tested-by: Sebastian Reic

Re: [PATCH v2 04/49] drm/omap: dsi: Hack-fix DSI bus flags

2019-02-09 Thread Sebastian Reichel
the omap_dss_device > structure") > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c > b/driver

Re: [PATCH v2 45/49] drm/omap: Add support for drm_bridge

2019-02-09 Thread Sebastian Reichel
rent bridges. These systems can't be supported > using drm_bridge for now (their support through the omap_dss_device > infrastructure is not affected), this will be fixed in subsequent > changes. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian Reichel > --- Tested

Re: [PATCH v2 03/49] drm/omap: dsi: Fix OF platform depopulate

2019-02-09 Thread Sebastian Reichel
dss: dsi: Move initialization code from bind > to probe") > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/g

Re: [PATCH 0/6] omapdrm: drm_bridge and drm_panel support

2019-02-09 Thread Sebastian Reichel
Hi, On Fri, Jan 11, 2019 at 03:34:19AM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > On Thursday, 20 December 2018 14:17:27 EET Sebastian Reichel wrote: > > Hi, > > > > On Mon, Dec 10, 2018 at 03:06:17AM +0200, Laurent Pinchart wrote: > > > This patch se

Re: [PATCH v2 48/49] drm/omap: Remove TFP410 and DVI connector drivers

2019-02-09 Thread Sebastian Reichel
Hi, On Fri, Jan 11, 2019 at 05:51:19AM +0200, Laurent Pinchart wrote: > Those components are supported by the drm_bridge infrastructure, remove > the omapdrm-specific driver. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian Reichel > --- Tested-by: Sebastian Reic

Re: [PATCH v2 47/49] drm/omap: Whitelist DT nodes to fixup with omapdss, prefix

2019-02-09 Thread Sebastian Reichel
rresponding drm_bridge drivers become available and get > successfully tested with omapdrm. > > The omapdss components load check code is updated accordingly to ignore > devices managed by external bridge drivers. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian R

Re: [PATCH v2 01/49] drm/atomic: Constify mode argument to mode_valid_path()

2019-02-09 Thread Sebastian Reichel
-by: Ville Syrjälä > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c > b/drivers/gpu/drm/drm_atomic_helper.c > index 54e2ae614d

Re: [PATCH v2 46/49] drm/omap: Add support for drm_panel

2019-02-09 Thread Sebastian Reichel
nel, we only need to add panel support in the connector .get_modes() > handler, take connector bus flags (set by the panel) into account, and > enable/disable the panel in the encoder enable/disable operations > handlers. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Se

Re: [PATCH v2 29/49] drm/omap: Pass drm_display_mode to .check_timings() and .set_timings()

2019-02-09 Thread Sebastian Reichel
es in some cases. If needed > they will be converted to operate on drm_display_mode natively. > > Signed-off-by: Laurent Pinchart > Tested-by: Sebastian Reichel > --- Reviewed-by: Sebastian Reichel -- Sebastian > .../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 8 +++--- > dr

Re: [PATCH v2 45/49] drm/omap: Add support for drm_bridge

2019-02-09 Thread Sebastian Reichel
rent bridges. These systems can't be supported > using drm_bridge for now (their support through the omap_dss_device > infrastructure is not affected), this will be fixed in subsequent > changes. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sebastian Reichel > --- >

Re: [PATCH v2 00/49] omapdrm: drm_bridge and drm_panel support

2019-02-09 Thread Sebastian Reichel
rc5, (which contains some DSI fixes). This worked without any manual merge conflicts :). I also rebased rebased the DSI command mode patchset on top of it. Everything seems to work fine on Droid 4, so the series is Tested-by: Sebastian Reichel I pushed out the rebased branch with DSI

Re: [PATCH 0/6] omapdrm: drm_bridge and drm_panel support

2018-12-21 Thread Sebastian Reichel
Hi, On Mon, Dec 10, 2018 at 03:06:17AM +0200, Laurent Pinchart wrote: > This patch series hooks up support for drm_bridge and drm_panel in the omapdrm > driver. > > [...] The series is Reviewed-by: Sebastian Reichel At the same time it is tested to break display on Droid 4.

Re: [PATCH 2/7] drm: omapdrm: Cleanup drm_display_mode print str

2018-12-19 Thread Sebastian Reichel
; --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/omap_connector.c | 9 ++--- > drivers/gpu/drm/omapdrm/omap_crtc.c | 8 ++-- > 2 files changed, 4 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_connector.

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2018-12-11 Thread Sebastian Reichel
Hi, On Mon, Dec 10, 2018 at 02:14:01PM +0100, Sebastian Reichel wrote: > On Mon, Dec 10, 2018 at 09:50:08AM +0200, Laurent Pinchart wrote: > > Hi Sebastian, > > > > On Monday, 10 December 2018 00:07:55 EET Sebastian Reichel wrote: > > > On Wed, Dec 05, 2018 at 05:0

Re: [PATCH v1.1 04/29] drm/omap: Use atomic suspend/resume helpers

2018-12-11 Thread Sebastian Reichel
> Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > Changes since v1: > > - Use drm_mode_config_helper_suspend() > --- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 -- > drivers/gpu/drm/omapdrm/omap_drv.c| 50 ++---

Re: [PATCH 24/29] drm/omap: Factor out common mode validation code

2018-12-11 Thread Sebastian Reichel
Hi Laurent, On Mon, Dec 10, 2018 at 10:27:05AM +0200, Laurent Pinchart wrote: > On Monday, 10 December 2018 00:19:22 EET Sebastian Reichel wrote: > > On Wed, Dec 05, 2018 at 05:00:17PM +0200, Laurent Pinchart wrote: > > > The encoder .atomic_check() and connector .mode_valid

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2018-12-11 Thread Sebastian Reichel
Hi, On Mon, Dec 10, 2018 at 09:50:08AM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > On Monday, 10 December 2018 00:07:55 EET Sebastian Reichel wrote: > > On Wed, Dec 05, 2018 at 05:00:15PM +0200, Laurent Pinchart wrote: > > > The DISPC timings checks relate

Re: [PATCH 30/29] drm/omap: Merge omap_dss_device type and output_type fields

2018-12-11 Thread Sebastian Reichel
y omap_dss_device instances corresponding to displays. This is > not documented and confusing. > > Clean the code by adding a new display field to the omap_dss_device > structure to identify displays, and merge the type and output_type > fields. > > Signed-off-by: Laurent Pinchart >

Re: [PATCH 08/29] drm/omap: Remove enable checks from display .enable() and .remove()

2018-12-10 Thread Sebastian Reichel
from the .enable() and .disable() handlers, and > add missing ones in the .remove() handler. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > .../gpu/drm/omapdrm/displays/connector-analog-tv.c| 6 ++ > drivers/gpu/drm/omapdrm/displays

Re: [PATCH 19/29] drm/omap: panel-dsi-cm: Store source pointer internally

2018-12-10 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 05:00:12PM +0200, Laurent Pinchart wrote: > The source pointer will be removed to the omap_dss_device structure. > Store it internally in the DSI panel driver data. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebast

Re: [PATCH 14/29] drm/omap: Add a dss device operation flag for .get_modes()

2018-12-10 Thread Sebastian Reichel
> helper function to locate the right dss device. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 1 + > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 1 + >

Re: [PATCH 20/29] drm/omap: Notify all devices in the pipeline of output disconnection

2018-12-10 Thread Sebastian Reichel
gt; pipeline. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/omap_connector.c | 28 ++-- > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap

Re: [PATCH 13/29] drm/omap: Merge display .get_modes() and .get_size() operations

2018-12-10 Thread Sebastian Reichel
> Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 14 +++--- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 --- > drivers/gpu/drm/omapdrm/omap_connector.c| 15 ++

Re: [PATCH 17/29] drm/omap: Move display alias ID to omap_drm_pipeline

2018-12-10 Thread Sebastian Reichel
e connection time and store > it in the pipeline structure instead to keep the feature. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/display.c | 2 -- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 --

Re: [PATCH 05/29] drm/omap: Move common display enable/disable code to encoder

2018-12-10 Thread Sebastian Reichel
r_disable() > handlers. > > The enabled check in the .disable() handler is left untouched, it will > be addressed separately. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > .../omapdrm/displays/connector-analog-tv.c| 23 +

Re: [PATCH 29/29] drm/omap: Refactor initialization sequence

2018-12-10 Thread Sebastian Reichel
ders before getting aliases and sorting the pipelines. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/omap_drv.c | 123 + > 1 file changed, 56 insertions(+), 67 deletions(-) > > diff

Re: [PATCH 16/29] drm/omap: Don't pass display pointer to encoder init function

2018-12-10 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 05:00:09PM +0200, Laurent Pinchart wrote: > The display isn't used by the encoder implementation, don't pass it to > the initialization function and store it internally needlessly. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Se

Re: [PATCH 23/29] drm/omap: venc: Simplify mode setting by caching configuration

2018-12-10 Thread Sebastian Reichel
> instead. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/venc.c | 68 +++--- > 1 file changed, 34 insertions(+), 34 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/ve

Re: [PATCH 22/29] drm/omap: Move DISPC timing checks to CRTC .mode_valid() operation

2018-12-10 Thread Sebastian Reichel
off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel This should also fix the issue with DSI in a less ugly way: https://lists.freedesktop.org/archives/dri-devel/2018-November/196622.html -- Sebastian > drivers/gpu/drm/omapdrm/omap_connector.c | 6 -- > drivers/gpu/drm/omap

Re: [PATCH 27/29] drm/omap: Store pixel clock instead of full mode in DPI and SDI encoders

2018-12-10 Thread Sebastian Reichel
off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dpi.c | 9 - > drivers/gpu/drm/omapdrm/dss/sdi.c | 6 +++--- > 2 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c >

Re: [PATCH 15/29] drm/omap: venc: List both PAL and NTSC modes

2018-12-10 Thread Sebastian Reichel
> Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/venc.c | 25 +++-- > 1 file changed, 19 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c > b/drivers/g

Re: [PATCH 06/29] drm/omap: Remove connection checks from internal encoders .enable()

2018-12-10 Thread Sebastian Reichel
t; > The safety check is thus not needed, remove it. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dpi.c | 17 + > drivers/gpu/drm/omapdrm/dss/dsi.c | 20 ++

Re: [PATCH 25/29] drm/omap: Pass drm_display_mode to .check_timings() and .set_timings()

2018-12-10 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 05:00:18PM +0200, Laurent Pinchart wrote: > The omap_dss_device .check_timings() and .set_timings() operations > operate on struct videomode, while the DRM API operates on struct > drm_display_mode. This forces conversion from to videomode in the > callers. While

Re: [PATCH 07/29] drm/omap: Remove connection checks from display .enable() and .remove()

2018-12-10 Thread Sebastian Reichel
safety checks. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > .../gpu/drm/omapdrm/displays/encoder-opa362.c | 7 --- > .../gpu/drm/omapdrm/displays/encoder-tfp410.c | 7 --- > .../drm/omapdrm/displays/encoder-tpd12s015.c

Re: [PATCH 12/29] drm/omap: Expose DRM modes instead of timings in display devices

2018-12-10 Thread Sebastian Reichel
M > modes directly to the connector. > > As this puts more burden on display devices, we also create a helper > function for panels to add a single DRM mode from the panel video > timings. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian &g

Re: [PATCH v1.1 26/29] drm/omap: venc: Use drm_display_mode natively

2018-12-10 Thread Sebastian Reichel
nce v1: > > - Set mode.crtc_* fields and mode name in venc_check_timings() > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/venc.c | 90 +++--- > 1 file changed, 44 insertions(+), 46 deletions(-) > > diff --git a/drivers/gpu/

Re: [PATCH 03/29] drm/omap: venc: Remove wss_data field from venc_device structure

2018-12-10 Thread Sebastian Reichel
On Wed, Dec 05, 2018 at 04:59:56PM +0200, Laurent Pinchart wrote: > The venc_device structure wss_data field is set to 0 and never otherwise > modified, remove it. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapd

Re: [PATCH 04/29] drm/omap: Use atomic suspend/resume helpers

2018-12-10 Thread Sebastian Reichel
> Signed-off-by: Laurent Pinchart > --- Documentation/gpu/todo.rst says, that this should be converted to drm_mode_config_helper_suspend, but at least it's no longer open coded after your change. Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/omapdss.h |

Re: [PATCH 24/29] drm/omap: Factor out common mode validation code

2018-12-10 Thread Sebastian Reichel
gt; function. > > Signed-off-by: Laurent Pinchart > --- This is a bit tricky to review. It would probably be easier to review, if the changes were split into two commits: 1. introduce common function 2. move drm_display_mode/videomode conversion further up the stack Anyways: Reviewed-

Re: [PATCH 21/29] drm/omap: Remove src field from omap_dss_device structure

2018-12-10 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 05:00:14PM +0200, Laurent Pinchart wrote: > The field is only used to check whether the device is connected, and we > can do so by checking the dss field instead. Remove the src field. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Se

Re: [PATCH 01/29] drm/omap: Remove declaration of nonexisting function

2018-12-10 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 04:59:54PM +0200, Laurent Pinchart wrote: > The omap_connector_attached_encoder() doesn't exist anymore, remove its > declaration from omap_connector.h. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian >

Re: [PATCH 09/29] drm/omap: Reverse direction of the DSS device enable/disable operations

2018-12-10 Thread Sebastian Reichel
otable exception of the DSI pipelines that will require more > work. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > .../omapdrm/displays/connector-analog-tv.c| 21 > .../gpu/drm/omapdrm/displays/connector-dvi.c | 21 -

Re: [PATCH 10/29] drm/omap: Remove omap_dss_device dst field

2018-12-10 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 05:00:03PM +0200, Laurent Pinchart wrote: > The field is only used in a safety check during device > connection/disconnection, where the src field can be easily used > instead. Remove it and use src. > > Signed-off-by: Laurent Pinchart > --- Revi

Re: [PATCH 18/29] drm/omap: Don't store display pointer in omap_connector structure

2018-12-10 Thread Sebastian Reichel
to the end of the > pipeline. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/omap_connector.c | 31 ++-- > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/o

Re: [PATCH 11/29] drm/omap: Factor out common init/cleanup code for output devices

2018-12-10 Thread Sebastian Reichel
Hi, On Wed, Dec 05, 2018 at 05:00:04PM +0200, Laurent Pinchart wrote: > All the internal encoders share common init and cleanup code. Factor it > out to separate functions. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/g

Re: [PATCH 02/29] drm/omap: Remove unused kobj field from struct omap_dss_device

2018-12-10 Thread Sebastian Reichel
On Wed, Dec 05, 2018 at 04:59:55PM +0200, Laurent Pinchart wrote: > The kobj field from struct omap_dss_device is not used. Remove it. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 -- >

Re: [PATCH 28/29] drm/omap: Simplify OF lookup of DSS devices

2018-12-09 Thread Sebastian Reichel
look them up by node only. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/base.c| 5 +-- > drivers/gpu/drm/omapdrm/dss/dss-of.c | 60 --- > drivers/gpu/drm/omapdrm/dss/omapds

Re: [PATCHv5 0/6] omapdrm: DSI command mode panel support

2018-11-27 Thread Sebastian Reichel
Hi, On Mon, Nov 26, 2018 at 11:34:30AM +0200, Tomi Valkeinen wrote: > On 21/11/18 18:09, Sebastian Reichel wrote: > > Here is another round of the DSI command mode panel patchset > > integrating the feedback from PATCHv4. The patches are based > > on 4.20-rc1 + fixes fro

[PATCHv5 6/6] drm/omap: add support for manually updated displays

2018-11-22 Thread Sebastian Reichel
a display refresh and seems to work as expected. Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_crtc.c | 117 ++-- drivers/gpu/drm/omapdrm/omap_crtc.h | 1 + drivers/gpu/drm/omapdrm

[PATCHv5 3/6] drm/omap: don't check dispc timings for DSI

2018-11-22 Thread Sebastian Reichel
for DSI here. Fixes: 7c27fa57ef31 ("drm/omap: Call dispc timings check operation directly") Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_connector.c | 8 +--- drivers/gpu/drm/omapdrm/omap

[PATCHv5 4/6] drm/omap: fix incorrect union usage

2018-11-22 Thread Sebastian Reichel
e most omap_dss_driver operations to omap_dss_device_ops") Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_encoder.c | 62 +++--- 1 file changed, 37 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c b/drivers/gpu/drm/omapdrm/omap_enco

[PATCHv5 2/6] drm/omap: populate DSI platform bus earlier

2018-11-22 Thread Sebastian Reichel
in dsi_init_output(). Fixes: 27d624527d992 ("drm/omap: dss: Acquire next dssdev at probe time") Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 20 ++-- 1 file changed, 10

[PATCHv5 1/6] drm/omap: use DRM_DEBUG_DRIVER instead of CORE

2018-11-22 Thread Sebastian Reichel
This macro is only used by omapdrm, which should print debug messages using the DRIVER category instead of the default CORE category. Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_drv.h | 4 ++-- 1

[PATCHv5 0/6] omapdrm: DSI command mode panel support

2018-11-22 Thread Sebastian Reichel
Sebastian Reichel (6): drm/omap: use DRM_DEBUG_DRIVER instead of CORE drm/omap: populate DSI platform bus earlier drm/omap: don't check dispc timings for DSI drm/omap: fix incorrect union usage drm/omap: add framedone interrupt support drm/omap: add support for manually updated displays

[PATCHv5 5/6] drm/omap: add framedone interrupt support

2018-11-22 Thread Sebastian Reichel
This prepares framedone interrupt handling for manual display update support. Acked-by: Pavel Machek Tested-by: Tony Lindgren Tested-by: Pavel Machek Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_crtc.c | 50 + drivers/gpu/drm/omapdrm

Re: [PATCHv4 5/6] drm/omap: add framedone interrupt support

2018-11-20 Thread Sebastian Reichel
Hi, On Sat, Nov 17, 2018 at 10:08:40PM +0100, Pavel Machek wrote: > > This prepares framedone interrupt handling for > > manual display update support. > > > > Signed-off-by: Sebastian Reichel > > Acked-by: Pavel Machek Thanks. > > @@ -217,6 +239,9 @@ sta

Re: [PATCHv4 4/6] drm/omap: fix incorrect union usage

2018-11-16 Thread Sebastian Reichel
Hi Tomi, On Fri, Nov 16, 2018 at 03:41:24PM +0200, Tomi Valkeinen wrote: > On 16/11/18 01:06, Sebastian Reichel wrote: > > The DSI encoder sets dssdev->ops->dsi.set_config, which is stored at the > > same offset as dssdev->ops->hdmi.set_hdmi_mode. The code in o

[PATCHv4 0/6] omapdrm: DSI command mode panel support

2018-11-16 Thread Sebastian Reichel
orientation hint * Add Tested-by from Tony Changes since PATCHv1: * Drop patches, that were queued by Tomi * Rebase to current master * Rework the omap3 workaround patch to only affect omap3 * Add orientation DRM property support -- Sebastian Sebastian Reichel (6): drm/omap: use DRM_DEBUG_DRIVER

[PATCHv4 4/6] drm/omap: fix incorrect union usage

2018-11-16 Thread Sebastian Reichel
e by exiting early if the output type definitely has no hdmi_set operations. Fixes: 83910ad3f51fb ("drm/omap: Move most omap_dss_driver operations to omap_dss_device_ops") Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_encoder.c | 8 1 file changed, 8 insertions(+)

[PATCHv4 2/6] drm/omap: populate DSI platform bus earlier

2018-11-16 Thread Sebastian Reichel
in dsi_init_output(). Fixes: 27d624527d992 ("drm/omap: dss: Acquire next dssdev at probe time") Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/dss/dsi.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/ds

[PATCHv4 3/6] drm/omap: don't check dispc timings for DSI

2018-11-16 Thread Sebastian Reichel
for DSI here. Fixes: 7c27fa57ef31 ("drm/omap: Call dispc timings check operation directly") Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_connector.c | 8 +--- drivers/gpu/drm/omapdrm/omap_encoder.c | 8 +--- 2 files changed, 10 insertions(+), 6 deletion

[PATCHv4 1/6] drm/omap: use DRM_DEBUG_DRIVER instead of CORE

2018-11-16 Thread Sebastian Reichel
This macro is only used by omapdrm, which should print debug messages using the DRIVER category instead of the default CORE category. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCHv4 5/6] drm/omap: add framedone interrupt support

2018-11-16 Thread Sebastian Reichel
This prepares framedone interrupt handling for manual display update support. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_crtc.c | 50 + drivers/gpu/drm/omapdrm/omap_crtc.h | 1 + drivers/gpu/drm/omapdrm/omap_irq.c | 25

[PATCHv4 6/6] drm/omap: add support for manually updated displays

2018-11-16 Thread Sebastian Reichel
a display refresh and seems to work as expected. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/omap_crtc.c | 116 ++-- drivers/gpu/drm/omapdrm/omap_crtc.h | 1 + drivers/gpu/drm/omapdrm/omap_fb.c | 41 ++ 3 files changed, 153 insertions(+), 5

Re: [PATCH v3 4/4] drm/omap: Move DISPC runtime PM handling to omapdrm

2018-11-10 Thread Sebastian Reichel
at remove time du to the > DISPC being already removed). > > Fixes: edb715dffdee ("drm/omap: dss: dsi: Move initialization code from bind > to probe") > Signed-off-by: Laurent Pinchart > --- +1 for writing fixes, that cleanup the code at the same time :) Decoupling

Re: [PATCH v3 3/4] drm/omap: dsi: Ensure the device is active during probe

2018-11-10 Thread Sebastian Reichel
_runtime_get() and dsi_runtime_put() calls. > > Fixes: edb715dffdee ("drm/omap: dss: dsi: Move initialization code from bind > to probe") > Signed-off-by: Laurent Pinchart > Acked-by: Tony Lindgren > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers

Re: [PATCH v3 2/4] drm/omap: hdmi4: Ensure the device is active during bind

2018-11-10 Thread Sebastian Reichel
gt; > Fixes: 27d624527d99 ("drm/omap: dss: Acquire next dssdev at probe time") > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > Changes since v2: > > - Call hdmi_runtime_put() instead of hdmi_runtime_get() in error path > ---

Re: [PATCH v3 1/4] drm/omap: Populate DSS children in omapdss driver

2018-11-10 Thread Sebastian Reichel
27d624527d99 ("drm/omap: dss: Acquire next dssdev at probe time") > Signed-off-by: Laurent Pinchart > Acked-by: Tony Lindgren > --- Reviewed-by: Sebastian Reichel -- Sebastian > arch/arm/mach-omap2/display.c | 111 ++ > driver

Re: [PATCH] drm/omap: dsi: Fix missing of_platform_depopulate()

2018-11-08 Thread Sebastian Reichel
Hi, On Tue, Nov 06, 2018 at 07:28:02AM -0800, Tony Lindgren wrote: > We're missing a call to of_platform_depopulate() on errors for dsi. > Looks like dss is already doing this. > > Signed-off-by: Tony Lindgren > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/g

Re: omap4: support for manually updated display

2018-10-19 Thread Sebastian Reichel
Hi, On Fri, Oct 19, 2018 at 09:44:50AM -0700, Tony Lindgren wrote: > * Pavel Machek [181018 22:15]: > > Hi! > > > > > > I want to make it clear that I don't want to claim any privilege in > > > > getting > > > > patches merged first. I am however worried that, without an easy way to > > > >

Re: omap4: support for manually updated display

2018-09-10 Thread Sebastian Reichel
Hi, On Mon, Sep 10, 2018 at 03:24:37PM +0300, Laurent Pinchart wrote: > On Monday, 10 September 2018 14:59:23 EEST Tomi Valkeinen wrote: > > On 30/08/18 12:04, Pavel Machek wrote: > > > There's neat series of patches on > > > > > >

Re: [PATCH v2 00/22] omapdrm: Rework the timing-related operations

2018-08-13 Thread Sebastian Reichel
Hi, On Mon, Aug 13, 2018 at 02:12:44PM +0300, Tomi Valkeinen wrote: > On 06/08/18 23:36, Laurent Pinchart wrote: > > > The series is based on top of the previously submitted "[PATCH v2 00/21] > > omapdrm: Rework the HPD-related operations" patch series. For convenience > > I've > > pushed it to

Re: [PATCH 00/23] omapdrm: Rework the timing-related operations

2018-06-12 Thread Sebastian Reichel
rking the .check_timings() operation by > making use of the bus flags. Patches 11/23 to 13/23 rework the .get_timings() > operation, and patches 14/23 to 21/23 complete the .check_timings() rework. > Patches 22/23 and 23/23 finally rework the .set_timings() operation. The

Re: [PATCH 20/21] drm/omap: Pass both output and display omap_dss_device to encoder init

2018-06-11 Thread Sebastian Reichel
gt; handling will require access to the output omap_dss_device. To prepare > for that, pass it to the encoder initialization function and store it > internally as well. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/d

Re: [PATCH 21/21] drm/omap: Don't call HDMI mode and infoframe operations recursively

2018-06-11 Thread Sebastian Reichel
> encoder just forward the operation to the previous component in the > chain. Call the operations directly on the HDMI encoder. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/displays/connector-hdmi.c | 20

Re: [PATCH 19/21] drm/omap: Get from CRTC to display device directly

2018-06-11 Thread Sebastian Reichel
rent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/omap_crtc.c| 25 - > drivers/gpu/drm/omapdrm/omap_encoder.c | 7 --- > drivers/gpu/drm/omapdrm/omap_encoder.h | 3 --- > 3 files changed, 4 insertions(+), 31 deletions

Re: [PATCH 04/21] drm/omap: Check omap_dss_device type based on the output_type field

2018-06-11 Thread Sebastian Reichel
t; This gets in the way of the omap_dss_device operations refactoring. > Replace that with a check based on the output_type field which is set > for all omap_dss_device instances but displays. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian

Re: [PATCH 18/21] drm/omap: Don't call EDID read operation recursively

2018-06-11 Thread Sebastian Reichel
ctor code. > This moves the complexity to a single central location and simplifies > the logic in omap_dss_device drivers. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 15 +-- > dr

Re: [PATCH 17/21] drm/omap: Move HPD disconnection handling to omap_connector

2018-06-11 Thread Sebastian Reichel
AP4 internal HDMI encoder. > > Knowledge of the DSS internals need to be removed from the > omap_dss_device instances in order to migrate to drm_bridge. To do so, > move HPD handling for CEC to the omap_connector. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by:

Re: [PATCH 16/21] drm/omap: Merge HPD enable operation with HPD callback registration

2018-06-11 Thread Sebastian Reichel
es[i].display; > - > - if (display->ops->disable_hpd) > - display->ops->disable_hpd(display); > - } > + for (i = 0; i < priv->num_pipes; i++) > + omap_connector_enable_hpd(priv->pipes[i].connector); > } >

Re: [PATCH 15/21] drm/omap: Remove unneeded safety checks in the HPD operations

2018-06-11 Thread Sebastian Reichel
> result be turned into a void operation. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 9 + > drivers/gpu/drm/omapdrm/displays/connector-hdmi.c| 14 +++---

Re: [PATCH 14/21] drm/omap: Don't call HPD registration operations recursively

2018-06-11 Thread Sebastian Reichel
t; detection support, iterate over the devices manually in the DRM > connector code. This moves the complexity to a single central location > and simplifies the logic in omap_dss_device drivers. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian

Re: [PATCH v2 44/60] drm/omap: dss: Add for_each_dss_output() macro

2018-06-11 Thread Sebastian Reichel
Hi, On Mon, Jun 11, 2018 at 08:11:09PM +0300, Laurent Pinchart wrote: > Hi Sebastian, > > On Monday, 11 June 2018 02:52:44 EEST Sebastian Reichel wrote: > > On Sat, May 26, 2018 at 08:25:02PM +0300, Laurent Pinchart wrote: > > > Similarly to for_each_dss_display(),

Re: [PATCH v2 46/60] drm/omap: dss: Remove duplicated parameter to dss_mgr_(dis)connect()

2018-06-11 Thread Sebastian Reichel
Hi, On Mon, Jun 11, 2018 at 08:16:24PM +0300, Laurent Pinchart wrote: > Hi Sebastian, > > On Monday, 11 June 2018 02:48:45 EEST Sebastian Reichel wrote: > > On Sat, May 26, 2018 at 08:25:04PM +0300, Laurent Pinchart wrote: > > > The dss_mgr_connect() and dss_mgr_disconn

Re: [PATCH 12/21] drm/omap: dss: Add device operations flags

2018-06-11 Thread Sebastian Reichel
drivers to signal support for operations. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/omapdss.h | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h

Re: [PATCH 13/21] drm/omap: Don't call .detect() operation recursively

2018-06-11 Thread Sebastian Reichel
> .detect() implementation. This moves the complexity to a single central > location and simplifies the logic in omap_dss_device drivers. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/displays/connector-dvi.c | 2 ++

Re: [PATCH 11/21] drm/omap: Move most omap_dss_driver operations to omap_dss_device_ops

2018-06-11 Thread Sebastian Reichel
e operations. To > simplify current and future code, move all operations that are not > specific to the display device to the omap_dss_device_ops. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > .../gpu/drm/omapdrm/displays/connector-a

Re: [PATCH 10/21] drm/omap: panel-tpo-td043mtea1: Convert to the GPIO descriptors API

2018-06-11 Thread Sebastian Reichel
rt the polarity of all GPIO operations in the driver. Rename the > nreset_gpio field to reset_gpio to reflect that. > > The reset GPIO is mandatory, so drop conditional tests through the > driver. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Se

Re: [PATCH 09/21] drm/omap: panel-tpo-td028ttec1: Drop unneeded linux/gpio.h header

2018-06-11 Thread Sebastian Reichel
Hi, On Wed, Jun 06, 2018 at 12:36:38PM +0300, Laurent Pinchart wrote: > The driver doesn't use GPIOs and thus doesn't need to include the > linux/gpio.h header. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omap

Re: [PATCH 08/21] drm/omap: panel-sony-acx565akm: Convert to the GPIO descriptors API

2018-06-11 Thread Sebastian Reichel
Hi, On Wed, Jun 06, 2018 at 12:36:37PM +0300, Laurent Pinchart wrote: > The GPIO descriptor API is favoured over the plain GPIO API for consumer > drivers. Using it simplifies the driver code. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebast

Re: [PATCH 07/21] drm/omap: panel-nec-nl8048hl11: Convert to the GPIO descriptors API

2018-06-11 Thread Sebastian Reichel
. The qvga GPIO is unused, so drop it completely. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > .../drm/omapdrm/displays/panel-nec-nl8048hl11.c| 54 > +- > 1 file changed, 11 insertions(+), 43 deletions(-) > &g

Re: [PATCH 06/21] drm/omap: encoder-tfp410: Convert to the GPIO descriptors API

2018-06-11 Thread Sebastian Reichel
rt the polarity of all GPIO operations in the driver. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c | 51 > ++- > 1 file changed, 13 insertions(+), 38 deletions(-)

Re: [PATCH 05/21] drm/omap: connector-hdmi: Convert to the GPIO descriptors API

2018-06-11 Thread Sebastian Reichel
Hi, On Wed, Jun 06, 2018 at 12:36:34PM +0300, Laurent Pinchart wrote: > The GPIO descriptor API is favoured over the plain GPIO API for consumer > drivers. Using it simplifies the driver code. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebast

Re: [PATCH 03/21] drm/omap: Remove unnecessary display output sanity checks

2018-06-11 Thread Sebastian Reichel
() macro it uses to iterate > over displays locates the displays by checking the driver field > internally. > > As those checks are unnecessary, remove them. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/om

Re: [PATCH 02/21] drm/omap: dss: Remove omap_dss_driver .[gs]et_mirror operations

2018-06-11 Thread Sebastian Reichel
Hi, On Wed, Jun 06, 2018 at 12:36:31PM +0300, Laurent Pinchart wrote: > The .get_mirror() and .set_mirror() omap_dss_driver operations are > implemented by the panel-tpo-td043mtea1 driver but are never used. > Remove them. > > Signed-off-by: Laurent Pinchart > --- Revi

Re: [PATCH 01/21] drm/omap: dss: Remove unused omap_dss_driver operations

2018-06-11 Thread Sebastian Reichel
Hi, On Wed, Jun 06, 2018 at 12:36:30PM +0300, Laurent Pinchart wrote: > The .probe(), .remove(), .run_test(), .get_rotate() and .set_rotate() > omap_dss_driver operations are not used. Remove them. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel

Re: [PATCH v2 60/60] drm/omap: dss: Remove the dss_mgr_(dis)connect() operations

2018-06-11 Thread Sebastian Reichel
Hi, On Sat, May 26, 2018 at 08:25:18PM +0300, Laurent Pinchart wrote: > The dss_mgr .connect() and .disconnect() are implemented as no-op in > omapdrm. The operations are unneeded, remove them. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebast

Re: [PATCH v2 59/60] drm/omap: Set dispc_channel_connect from DSS output connect handlers

2018-06-11 Thread Sebastian Reichel
f > going through the CRTC dss_mgr operations. > > Signed-off-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dpi.c | 3 +++ > drivers/gpu/drm/omapdrm/dss/dsi.c | 3 +++ > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 3 +++

  1   2   3   4   >