[PATCH libdrm] meson.build: Don't detect header for linux

The header is not required for Linux and GNU libc 2.30 starts to warn about Linux specific header deprecation. Don't detect header for linux. Signed-off-by: Seung-Woo Kim --- Fix meson.build script instead of code itself as commented below: https://patchwork.kernel.org/patch/11325345

Re: [PATCH] xf86drm: only include for FreeBSD build case

Hi On 2020년 01월 10일 00:28, Niclas Zeising wrote: > On 2020-01-09 16:18, Jani Nikula wrote: >> On Thu, 09 Jan 2020, Seung-Woo Kim wrote: >>> The header is only required FreeBSD and GNU libc >>> 2.30 starts to warn about Linux specific header >>> de

Re: [PATCH] xf86drm: only include for FreeBSD build case

Hi, On 2020년 01월 10일 00:18, Jani Nikula wrote: > On Thu, 09 Jan 2020, Seung-Woo Kim wrote: >> The header is only required FreeBSD and GNU libc >> 2.30 starts to warn about Linux specific header >> deprecation. Only include for FreeBSD. >> >

[PATCH] xf86drm: only include for FreeBSD build case

The header is only required FreeBSD and GNU libc 2.30 starts to warn about Linux specific header deprecation. Only include for FreeBSD. Signed-off-by: Seung-Woo Kim --- xf86drmMode.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/xf86drmMode.c b/xf86drmMode.c index

[PATCH] dma-buf/sw-sync: Use unsigned type for value of sync_timeline

The value of sync_timeline is only incremented and all reference usage of it is unsigned. Use unsigned type for value of synctimeline. Signed-off-by: Seung-Woo Kim --- drivers/dma-buf/sync_debug.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma-buf

[PATCH libdrm] xf86drm: Fix possible memory leak with drmModeGetPropertyPtr()

In drmModeGetPropertyPtr(), from upper error path, it calls free but with just next error path, it does not call. Fix the possible memory leak. Signed-off-by: Seung-Woo Kim --- xf86drmMode.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xf86drmMode.c b/xf86drmMode.c

[PATCH libdrm] tests/libkms-test-plane: fix possbile memory leak

The pointer p aquired with drmModeGetPlane() is not free in error path. Fix possible memory leak by calling drmModeFreePlane() in the error path. Signed-off-by: Seung-Woo Kim --- tests/kms/libkms-test-plane.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tests/kms

[PATCH] drm/exynos: g2d: remove style error

Remove checkpatch error, "foo* bar" should be "foo *bar". Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/ex

[RESEND][PATCH libdrm] configure.ac fix build error for config.h in autotools

top.org/show_bug.cgi?id=106561 Signed-off-by: Seung-Woo Kim --- It looks like missed from mailing list, so I resend. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 7e7c8d3..d72e84a 100644 --- a/configure.ac +++ b/co

[PATCH libdrm] configure.ac fix build error for config.h in autotools

top.org/show_bug.cgi?id=106561 Signed-off-by: Seung-Woo Kim --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 7e7c8d3..d72e84a 100644 --- a/configure.ac +++ b/configure.ac @@ -541,7 +541,7 @@ else AC_DEFINE(HAV

[PATCH libdrm] tests/exynos: remove dead condition

There is already condition checking input values between 2 and 4096 so condition checking 0 is always false. Remove the dead condition. Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> --- tests/exynos/exynos_fimg2d_perf.c |7 --- 1 files changed, 0 insertions(+), 7 del

Re: [PATCH libdrm] modetest: Fix to check return value of asprintf()

Hello, On 2018년 01월 22일 21:09, Eric Engestrom wrote: > On Wednesday, 2018-01-10 11:16:41 +0900, Seung-Woo Kim wrote: >> There is warning about ignoring return value of 'asprintf'. Fix to >> check return value of asprintf(). >> >> Signed-off-by: Seung-Woo Kim <sw0312.

[PATCH libdrm] modetest: Fix to check return value of asprintf()

There is warning about ignoring return value of 'asprintf'. Fix to check return value of asprintf(). Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> --- tests/modetest/modetest.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/tests/modetest/modetest.c b

[PATCH libdrm] amdgpu: fix not to add amdgpu.ids when building without amdgpu

The amdgpu.ids is only required when building with amdgpu support. Fix not to add it without amdgpu. Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> --- data/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/data/Makefile.am b/data/Makefile.am

[PATCH libdrm 1/3] exynos: fix type-punned pointer build warning

t-aliasing] e = (struct drm_event *) [i]; ^ Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> --- exynos/exynos_drm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exynos/exynos_drm.c b/exynos/exynos_drm.c index b961e52..f6204f1 100

[PATCH libdrm 2/3] exynos/fimg2d: remove unused-function build warning

The function g2d_reset() is not anymore used after the commit e3c97d1a2473 ("exynos/fimg2d: add g2d_validate_xyz() functions"), so it should be removed. Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> --- exynos/exynos_fimg2d.c | 14 -- 1 files changed, 0 i

[PATCH libdrm 3/3] tests/exynos: remove unused-function build warning

The function g2d_blend_test() is blocked to call because of feature unsafety. This patch blocks with proper feature name and also blocks the function itself to remove build warning. Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> --- tests/exynos/exynos_fimg2d_test.c |4 +++- 1

[PATCH libdrm 0/3] remove build warnings for exynos

For exynos module for libdrm, there are some build warnings, so this patch series remove them. Seung-Woo Kim (3): exynos: fix type-punned pointer build warning exynos/fimg2d: remove unused-function build warning tests/exynos: remove unused-function build warning exynos/exynos_drm.c

[PATCH libdrm] xf86drm: remove memory leaks in drmGetBusid/drmGetReservedContextList

In error path of drmGetBusid() and drmGetReservedContextList(), there are memory leaks for error path. So this removes them. Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> --- xf86drm.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/xf86d

[PATCH] tests/exynos: fix invalid code of error path in g2d test

This patch fixes invalid code of error path including NULL deference and leak in g2d test. Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> --- tests/exynos/exynos_fimg2d_test.c | 39 +++- 1 files changed, 21 insertions(+), 18 deletions(-) diff

Re: [PATCH libdrm] tests/exynos: fix memory issues of error path in g2d test

Hello Emil, Thanks for comment. On 2017년 03월 20일 09:08, Emil Velikov wrote: > Hi Seung-Woo Kim, > > On 16 March 2017 at 02:00, Seung-Woo Kim <sw0312@samsung.com> wrote: >> This patch fixes memory issues including NULL deference and leak >> in g2d test in e

[PATCH libdrm] tests/exynos: fix memory issues of error path in g2d test

This patch fixes memory issues including NULL deference and leak in g2d test in error path. Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> --- tests/exynos/exynos_fimg2d_test.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/

[RESEND][PATCH] libkms/exynos: fix memory leak in error path

This patch fixes memory leak in error path of exynos_bo_create(). Signed-off-by: Seung-Woo Kim --- libkms/exynos.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libkms/exynos.c b/libkms/exynos.c index 5de2e5a..0e97fb5 100644 --- a/libkms/exynos.c +++ b/libkms

[PATCH libdrm] libkms/exynos: fix memory leak in error path

This patch fixes memory leak in error path of exynos_bo_create(). Signed-off-by: Seung-Woo Kim --- libkms/exynos.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libkms/exynos.c b/libkms/exynos.c index 5de2e5a..0e97fb5 100644 --- a/libkms/exynos.c +++ b/libkms

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

Hello Javier, On 2016년 03월 29일 11:41, Javier Martinez Canillas wrote: > Hello Seung-Woo, > > Thanks a lot for your feedback. > > On 03/28/2016 09:46 PM, Seung-Woo Kim wrote: >> Hi Javier, >> >> On 2016년 03월 29일 10:28, Javier Martin

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

uired for drm fimc and drm gsc. Best Regards, - Seung-Woo Kim > > drivers/gpu/drm/exynos/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > -- Seung-Woo Kim Samsung Software R Center --

[PATCH v2 2/2] drm/msm/mdp4: Support NV12MT format in mdp4

de (and maybe even width?) should be a multiple of the > block size (but height does not) > > BR, > -R > > >> -Daniel >> >> >>> +#define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE fourcc_mod_code(SAMSUNG, 1) >>> + >>> #endif /* DRM_FOURCC_H */ >>> -- >>> Qualcomm Innovation Center, Inc. >>> >>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >>> a Linux Foundation Collaborative Project >>> >> >> -- >> Daniel Vetter >> Software Engineer, Intel Corporation >> +41 (0) 79 365 57 48 - http://blog.ffwll.ch > -- Seung-Woo Kim Samsung Software R Center --

[PATCH] drm: remove DRM_FORMAT_NV12MT

Hello Daniel, On 2015년 02월 04일 00:48, Daniel Vetter wrote: > So this has been merged originally in > > commit 83052d4d5cd518332440bb4ee63d68bb5f744e0f > Author: Seung-Woo Kim > Date: Thu Dec 15 15:40:55 2011 +0900 > > drm: Add multi buffer plane pixel formats &

[PATCH] drm/exynos: hdmi: replace fb size with mode size from win commit

-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_mixer.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index 6766271..086fe0e 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers

drm: exynos: mixer: fix using usleep() in atomic context

range' is just plain wrong while under > spinlock). When the spinlock setup gets cleaned up later, then we can > always change back to 'usleep_range' again. > > Any thoughts? In s5p-tv, same patch is already applied by Tomasz, so I agree to apply this patch also. Best Regards,

[PATCH] drm/exynos: hdmi: add null check for hdmiphy_port

The hdmiphy can be apb and hdmiphy_port can be null. So before accessing hdmiphy_port, it should be checked. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b

[PATCH] drm/exynos: hdmi: remove unnecessary dedicated i2c drivers

The i2c drivers for ddc and hdmiphy are already removed from build and instead, i2c clients registered via devicetree are used. So this patch removes the unnecessary i2c drivers. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_ddc.c | 63

[PATCH 2/4] drm/exynos/mixer: use MXR_GRP_SXY_SY

Hello Daniel, On 2014? 05? 07? 23:14, Daniel Kurtz wrote: > On Wed, May 7, 2014 at 1:14 PM, Seung-Woo Kim > wrote: >> Hi Daniel, >> >> On 2014? 05? 05? 00:26, Daniel Kurtz wrote: >>> Mixer hardware supports offsetting dma from start of source buffer u

[PATCH 2/4] drm/exynos/mixer: use MXR_GRP_SXY_SY

t = 0; > + dma_addr = win_data->dma_addr; Basically, you are right and source offset register can be used. But because of limitation of resolution for mixer up to 1920x1080, I considered modified soruce dma address to set one frame buffer, which is bigger than 1920x1080, on to both fimd and hdmi.

[Linaro-mm-sig] [PATCH] dma-buf: add meta data attachment

+ INIT_LIST_HEAD(>metas); >>>> >>> I am not sure I understand the relationship of 'meta data' with >>> 'dma-buf', or 'attachments' - do you mean to have a list of some >>> meta-data that is unrelated to the attachments to the dma-buf? I think >

[PATCH 2/2] drm/exynos: Fix build after removal of DRM_WAKUP

Yes, at least for exynos-drm-next tree of Inki. Inki sent pull request including my patch yesterday. Best Regards, - Seung-Woo Kim

[PATCH] drm/exynos: fix build error caused by removed drm core macros

DRM_HZ and DRM_WAKEUP macros are removed, but they still remained. So this patch fixes build errors by replacing the macros. Signed-off-by: Seung-Woo Kim --- The build errors are only in drm-next branch, so this patch is based on the branch. --- drivers/gpu/drm/exynos/exynos_drm_fimd.c |4

[RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

om>] > >>>>> Sent: Thursday, June 13, 2013 5:56 PM > >>>>> To: Rahul Sharma > >>>>> Cc: Rahul Sharma; Inki Dae; linux-samsung-soc at vger.kernel.org > <mailto:linux-samsung-soc at vger.kernel.org>; >

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

mailto:disc...@lists.ozlabs.org; DRI mailing list; Kukjin Kim; Seung-Woo Kim; Sean Paul; sunil joshi; Kishon Vijay Abraham I; Stephen Warren; grant.lik...@linaro.org mailto:grant.lik...@linaro.org Subject: Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock

[PATCH 3/3] drm/exynos: remove duplicated error routine and unnecessary assign

There were duplicated error handling routines during allocating pages in lowlevel_buffer_allocate() and g2d_userptr_get_dma_addr(). Also unnecessary NULL assignments for variable used not any more are removed from g2d_userptr_get_dma_addr() and g2d_userptr_put_dma_addr(). Signed-off-by: Seung-Woo

[PATCH v2 2/3] drm/exynos: fix pages allocation size in lowlevel_buffer_allocate

YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- change from v1: - adds precedence patch to fix allocation of array as Ville and Inki commented drivers/gpu/drm/exynos/exynos_drm_buf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gp

[PATCH 1/3] drm/exynos: use drm_calloc_large when allocates pointer array

From: YoungJun Cho <yj44@samsung.com> If the type of object is pointer array, the drm_calloc_large() is more suitable than kzalloc() for its allocation function. And uses drm_free_large() instead of kfree() also. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Sign

[PATCH v2 2/3] drm/exynos: fix pages allocation size in lowlevel_buffer_allocate

@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- change from v1: - adds precedence patch to fix allocation of array as Ville and Inki commented drivers/gpu/drm/exynos/exynos_drm_buf.c |2 +- 1 files changed, 1

[PATCH 1/3] drm/exynos: use drm_calloc_large when allocates pointer array

From: YoungJun Cho yj44@samsung.com If the type of object is pointer array, the drm_calloc_large() is more suitable than kzalloc() for its allocation function. And uses drm_free_large() instead of kfree() also. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim

[PATCH 3/3] drm/exynos: remove duplicated error routine and unnecessary assign

There were duplicated error handling routines during allocating pages in lowlevel_buffer_allocate() and g2d_userptr_get_dma_addr(). Also unnecessary NULL assignments for variable used not any more are removed from g2d_userptr_get_dma_addr() and g2d_userptr_put_dma_addr(). Signed-off-by: Seung-Woo

[PATCH] drm/exynos: fix pages allocation in lowlevel_buffer_allocate

From: YoungJun Cho When drm iommu is not supported, buf->pages has to be allocated and assigned to phys_to_page() result, which type is struct page *. So it is sufficient to allocate buf->pages with multiple struct page pointer size. Signed-off-by: YoungJun Cho

[PATCH v3 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top of the function. The type of return for the function is bool, so it fixes to return true and false instead of 1 and 0. Signed-off-by: Seung-Woo Kim Signed

[PATCH v2 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

Hello Ville, Thanks for comment. On 2013? 07? 02? 17:29, Ville Syrj?l? wrote: > On Tue, Jul 02, 2013 at 09:52:02AM +0900, Seung-Woo Kim wrote: >> If raw_edid of drm_edid_block_vaild() is null, it will crash, so >> checking in bad label is removed and instead assertion is adde

[PATCH v4 3/3] drm: fix error routines in drm_open_helper

m_release(), and drm_prime_destory_file_private() should be called when error happens after their pair functions are called. If an error occurs after executing dev->driver->open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho Signed-off-by: Seung-

[PATCH v2 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top of the function. The type of return for the function is bool, so it fixes to return true and false instead of 1 and 0. Signed-off-by: Seung-Woo Kim Signed

[PATCH v3 3/3] drm: fix error routines in drm_open_helper

m_release(), and drm_prime_destory_file_private() should be called when error happens after their pair functions are called. If an error occurs after executing dev->driver->open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho Signed-off-by: Seung-

[PATCH 2/3] drm: move edid null check to the first part of drm_edid_block_valid

Hi Daniel, On 2013? 07? 01? 23:56, Daniel Vetter wrote: > On Mon, Jul 1, 2013 at 12:21 PM, Chris Wilson > wrote: >> On Mon, Jul 01, 2013 at 07:06:32PM +0900, Seung-Woo Kim wrote: >>> If raw_edid is null, it will crash, so checking in bad label is >>> meaningle

Re: [PATCH v2 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

Hello Ville, Thanks for comment. On 2013년 07월 02일 17:29, Ville Syrjälä wrote: On Tue, Jul 02, 2013 at 09:52:02AM +0900, Seung-Woo Kim wrote: If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top

[PATCH v3 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top of the function. The type of return for the function is bool, so it fixes to return true and false instead of 1 and 0. Signed-off-by: Seung-Woo Kim sw0312

[PATCH] drm/exynos: fix pages allocation in lowlevel_buffer_allocate

From: YoungJun Cho yj44@samsung.com When drm iommu is not supported, buf-pages has to be allocated and assigned to phys_to_page() result, which type is struct page *. So it is sufficient to allocate buf-pages with multiple struct page pointer size. Signed-off-by: YoungJun Cho

[PATCH v2 3/3] drm: fix error routines in drm_open_helper

Hello Chris, On 2013? 07? 01? 19:57, Chris Wilson wrote: > On Mon, Jul 01, 2013 at 07:49:10PM +0900, Seung-Woo Kim wrote: >> + >> +out_close: >> +if (dev->driver->postclose) >> +dev->driver->postclose(dev, priv); >> +out_free: >>

[PATCH v2 3/3] drm: fix error routines in drm_open_helper

gt;open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- change from v1 - replace error value for failure to find the minor as ENODEV as Chris commented

[PATCH v2 1/3] drm: fix print format of sequence in trace point

seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- change from v1 - remove wrong commit messageas Chris commented drivers/gpu/drm/drm_trace.h |6 +++--- 1 files changed, 3 insertions

[PATCH 1/3] drm: fix print format of sequence in trace point

Hello Chris, Thank you for reviewing. On 2013? 07? 01? 19:23, Chris Wilson wrote: > On Mon, Jul 01, 2013 at 07:06:31PM +0900, Seung-Woo Kim wrote: >> seq of a trace point is unsigned int but print format was %d. So >> it fixes the format as %u even the format can be not use

[PATCH 3/3] drm: fix error routines in drm_open_helper

gt;open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_fops.c | 17 + 1 files changed, 13 insertions(+), 4 deletions

[PATCH 2/3] drm: move edid null check to the first part of drm_edid_block_valid

If raw_edid is null, it will crash, so checking in bad label is meaningless. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_edid.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm

[PATCH 1/3] drm: fix print format of sequence in trace point

seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u even the format can be not used. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_trace.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 0/3] drm: minor cleanups

This patch series fixes minor code issues including wrong trace point foramts, meaningless null checking, and possible resource leak in error cases. This is based drm-next branch. Seung-Woo Kim (2): drm: fix print format of sequence in trace point drm: move edid null check to the first part

[PATCH] drm/exynos: add error check routine in exynos_drm_open

From: YoungJun Cho When the exynos_drm_subdrv_open() returns error, the file_priv should be released and file->driver_priv set to NULL. Signed-off-by: YoungJun Cho Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_drv.c |9 - 1 file changed,

[PATCH 2/2] drm/exynos: initialize the buf_num in vp_video_buffer

From: YoungJun Cho <yj44@samsung.com> The buf_num in vp_video_buffer() should be 1 or 2, but it is not initialized, and only set to 2 in NV12M or NV12MT cases. So this patch initializes the buf_num with 1 as default. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Sign

[PATCH 1/2] drm/exynos: remove dead code in vidi_power_on

From: YoungJun Cho The type of input parameter enable is bool, so it does not need to check whether true or false. Signed-off-by: YoungJun Cho Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_vidi.c |3 --- 1 file changed, 3 deletions(-) diff

[PATCH] drm/exynos: fix not to remain exynos_gem_obj as a leak

ed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- This patch is based on exynos-drm-next branch. drivers/gpu/drm/exynos/exynos_drm_gem.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/g

[PATCH] drm/exynos: add error check routine in exynos_drm_open

From: YoungJun Cho yj44@samsung.com When the exynos_drm_subdrv_open() returns error, the file_priv should be released and file-driver_priv set to NULL. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH 0/3] drm: minor cleanups

This patch series fixes minor code issues including wrong trace point foramts, meaningless null checking, and possible resource leak in error cases. This is based drm-next branch. Seung-Woo Kim (2): drm: fix print format of sequence in trace point drm: move edid null check to the first part

[PATCH 1/3] drm: fix print format of sequence in trace point

seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u even the format can be not used. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/drm_trace.h |6 +++--- 1 files changed, 3

[PATCH 2/3] drm: move edid null check to the first part of drm_edid_block_valid

If raw_edid is null, it will crash, so checking in bad label is meaningless. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/drm_edid.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

[PATCH 3/3] drm: fix error routines in drm_open_helper

allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/drm_fops.c | 17

Re: [PATCH 1/3] drm: fix print format of sequence in trace point

Hello Chris, Thank you for reviewing. On 2013년 07월 01일 19:23, Chris Wilson wrote: On Mon, Jul 01, 2013 at 07:06:31PM +0900, Seung-Woo Kim wrote: seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u even the format can be not used. I don't understand

[PATCH v2 1/3] drm: fix print format of sequence in trace point

seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- change from v1 - remove wrong commit messageas Chris commented drivers/gpu/drm/drm_trace.h

[PATCH v2 3/3] drm: fix error routines in drm_open_helper

allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- change from v1 - replace error value for failure

Re: [PATCH v2 3/3] drm: fix error routines in drm_open_helper

Hello Chris, On 2013년 07월 01일 19:57, Chris Wilson wrote: On Mon, Jul 01, 2013 at 07:49:10PM +0900, Seung-Woo Kim wrote: + +out_close: +if (dev-driver-postclose) +dev-driver-postclose(dev, priv); +out_free: kfree(priv); filp-private_data = NULL; return ret

Re: [PATCH 2/3] drm: move edid null check to the first part of drm_edid_block_valid

Hi Daniel, On 2013년 07월 01일 23:56, Daniel Vetter wrote: On Mon, Jul 1, 2013 at 12:21 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, Jul 01, 2013 at 07:06:32PM +0900, Seung-Woo Kim wrote: If raw_edid is null, it will crash, so checking in bad label is meaningless. It would

[PATCH v3 3/3] drm: fix error routines in drm_open_helper

() should be called when error happens after their pair functions are called. If an error occurs after executing dev-driver-open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo

[PATCH v2 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top of the function. The type of return for the function is bool, so it fixes to return true and false instead of 1 and 0. Signed-off-by: Seung-Woo Kim sw0312

[PATCH v4 3/3] drm: fix error routines in drm_open_helper

() should be called when error happens after their pair functions are called. If an error occurs after executing dev-driver-open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo

[PATCH] drm/exynos: fix not to remain exynos_gem_obj as a leak

-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- This patch is based on exynos-drm-next branch. drivers/gpu/drm/exynos/exynos_drm_gem.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH 1/2] drm/exynos: remove dead code in vidi_power_on

From: YoungJun Cho yj44@samsung.com The type of input parameter enable is bool, so it does not need to check whether true or false. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_vidi.c |3 ---

[PATCH 2/2] drm/exynos: initialize the buf_num in vp_video_buffer

From: YoungJun Cho yj44@samsung.com The buf_num in vp_video_buffer() should be 1 or 2, but it is not initialized, and only set to 2 in NV12M or NV12MT cases. So this patch initializes the buf_num with 1 as default. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim

[PATCH v2] drm/gem: fix not to assign error value to gem name

013 -0800 drm: convert to idr_alloc() Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- change since v1: - Add a regression commit information in commit msg as Chris commented drivers/gpu/drm/drm_gem.c | 18 +++--- 1 file changed, 7 i

[PATCH v2] drm/gem: add mutex lock when using drm_gem_mmap_obj

YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park CC: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com> CC: Rob Clark --- This patch is based on drm-next branch. Changes since v1: - Use lockdep_assert_held() instead of mutex_is_locked() as Maarten

[PATCH] drm/gem: add mutex lock when using drm_gem_mmap_obj

YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park CC: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com> CC: Rob Clark --- This patch is based on drm-next branch. drivers/gpu/drm/drm_gem.c |4 drivers/gpu/drm/drm_gem_cma_helpe

[PATCH] drm/gem: fix not to assign error value to gem name

From: YoungJun Cho <yj44@samsung.com> If idr_alloc() is failed, obj->name can be error value. Also it cleans up duplicated flink processing code. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_gem

[PATCH 3/3] drm/prime: add return check for dma_buf_fd

From: YoungJun Cho <yj44@samsung.com> The dma_buf_fd() can return error when it fails to prepare fd, so the dma_buf needs to be put. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_prime.c

[PATCH 2/3] drm/prime: reorder drm_prime_add_buf_handle and remove prototype

Signed-off-by: Seung-Woo Kim Signed-off-by: YoungJun Cho Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_prime.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index

[PATCH 1/3] drm/prime: fix to put an exported dma_buf for adding handle failure

From: YoungJun Cho <yj44@samsung.com> When drm_prime_add_buf_handle() returns failure for an exported dma_buf, the dma_buf was already allocated and its refcount was increased, so it needs to be put. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmi

[PATCH 0/3] fix error routine of exporting dma_buf

During exporting dma_buf, it can fail after dma_buf is exported. In this case, exported dma_buf should be release with putting. Also dma_buf_fd can be failed to get fd, but failure cases are not handled. Error handling routine is not quite clean, so I send this patch set as RFC. Seung-Woo Kim (1

[PATCH v2] drm/gem: add mutex lock when using drm_gem_mmap_obj

Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com CC: Rob Clark robdcl...@gmail.com --- This patch is based on drm-next branch. Changes since v1: - Use

[PATCH v2] drm/gem: fix not to assign error value to gem name

2013 -0800 drm: convert to idr_alloc() Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- change since v1: - Add a regression commit information in commit msg as Chris commented

[PATCH 0/3] fix error routine of exporting dma_buf

During exporting dma_buf, it can fail after dma_buf is exported. In this case, exported dma_buf should be release with putting. Also dma_buf_fd can be failed to get fd, but failure cases are not handled. Error handling routine is not quite clean, so I send this patch set as RFC. Seung-Woo Kim (1

[PATCH 1/3] drm/prime: fix to put an exported dma_buf for adding handle failure

From: YoungJun Cho yj44@samsung.com When drm_prime_add_buf_handle() returns failure for an exported dma_buf, the dma_buf was already allocated and its refcount was increased, so it needs to be put. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312

[PATCH 2/3] drm/prime: reorder drm_prime_add_buf_handle and remove prototype

Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/drm_prime.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git

[PATCH 3/3] drm/prime: add return check for dma_buf_fd

From: YoungJun Cho yj44@samsung.com The dma_buf_fd() can return error when it fails to prepare fd, so the dma_buf needs to be put. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH] drm/gem: fix not to assign error value to gem name

From: YoungJun Cho yj44@samsung.com If idr_alloc() is failed, obj-name can be error value. Also it cleans up duplicated flink processing code. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH] drm/gem: add mutex lock when using drm_gem_mmap_obj

yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com CC: Rob Clark robdcl...@gmail.com --- This patch is based on drm-next branch. drivers/gpu/drm/drm_gem.c

[PATCH] drm/prime: replace NULL with error value in drm_prime_pages_to_sg

From: YoungJun Cho <yj44@samsung.com> Instead of NULL, error value is casted with ERR_PTR() for drm_prime_pages_to_sg() and IS_ERR_OR_NULL() macro is replaced with IS_ERR() macro for drm_gem_map_dma_buf(). Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Ky

  1   2   >