Hi,
We have an issue where two devices have dependencies to each other,
according to drivers/base/core.c's fw_devlinks, and this prevents them
from probing. I've been adding debugging to the core.c, but so far I
don't quite grasp the issue, so I thought to ask. Maybe someone can
instantly say
On 12/09/2024 21:08, Maxime Ripard wrote:
On Thu, Sep 12, 2024 at 06:04:11PM GMT, Maxime Ripard wrote:
On Thu, 12 Sep 2024 22:41:42 +0530, Devarsh Thakkar wrote:
Modify license to include dual licensing as GPL-2.0-only OR MIT license for
tidss display driver. This allows other operating system
Add the two DMA channels used for the DisplayPort audio to the
zynqmp_dpsub node.
Signed-off-by: Tomi Valkeinen
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
b/arch/arm64/boot/dts
mented out.
Tested-by: Anatoliy Klymenko
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/xlnx/Kconfig| 9 +
drivers/gpu/drm/xlnx/Makefile | 1 +
drivers/gpu/drm/xlnx/zynqmp_disp.c | 48
drivers/gpu/drm/xlnx/zynqmp_disp_regs.h | 7 +-
drivers/gpu/drm/xlnx/z
the end of the dmas list, and, after the audio support has
been added in "arm64: dts: zynqmp: Add DMA for DP audio", the driver
will treat the audio DMAs as optional to also support the old bindings.
Signed-off-by: Tomi Valkeinen
---
.../devicetree/bindings/display/xlnx/xlnx,zynqmp-dp
Signed-off-by: Tomi Valkeinen
Changes in v3:
- Expand the description in "dt-bindings: display/xlnx/zynqmp-dpsub: Add
audio DMAs" to be more clear about the DT binding change.
- Rebased on top of current upstream
- Link to v2:
https://lore.kernel.org/r/20240319-xilinx-dp-audio-v2-0
On 09/09/2024 12:31, Aradhya Bhatia wrote:
Hi,
Thank you, Francesco and Max, for testing and reporting this!
On 09/09/24 13:45, Tomi Valkeinen wrote:
Hi,
On 06/09/2024 14:43, Francesco Dolcini wrote:
+Max
Hello Aradhya,
On Tue, Jul 16, 2024 at 02:12:44PM +0530, Aradhya Bhatia wrote:
The
Hi,
On 06/09/2024 14:43, Francesco Dolcini wrote:
+Max
Hello Aradhya,
On Tue, Jul 16, 2024 at 02:12:44PM +0530, Aradhya Bhatia wrote:
The addition of the 2nd OLDI TX (and a 2nd DSS in AM62Px) creates a need
for some major changes for a full feature experience.
1. The OF graph needs to be upd
Hi,
On 03/09/2024 14:56, Maxime Ripard wrote:
On Mon, Sep 02, 2024 at 03:31:28PM GMT, Tomi Valkeinen wrote:
Hi,
On 02/09/2024 13:50, Daniel Vetter wrote:
On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote:
Hi,
On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote:
On 25
On 03/09/2024 10:40, Simona Vetter wrote:
On Mon, Sep 02, 2024 at 03:31:28PM +0300, Tomi Valkeinen wrote:
Hi,
On 02/09/2024 13:50, Daniel Vetter wrote:
On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote:
Hi,
On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote:
On 25/07
Hi,
On 02/09/2024 13:50, Daniel Vetter wrote:
On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote:
Hi,
On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote:
On 25/07/2024 14:28, Maxime Ripard wrote:
On Mon, Jul 15, 2024 at 11:32:34AM GMT, Tomi Valkeinen wrote:
On 02/07
Hi Ulf,
On 03/05/2024 16:45, Ulf Hansson wrote:
+ Abel, Saravanna, Stephen
On Mon, 15 Apr 2024 at 19:17, Tomi Valkeinen
wrote:
On 15/04/2024 19:00, Tomi Valkeinen wrote:
Add a new flag, TI_SCI_PD_KEEP_BOOT_STATE, which can be set in the dts
when referring to power domains. When this flag
Hi,
On 25/08/2024 23:31, H. Nikolaus Schaller wrote:
Hi,
CEC features are useful to e.g. control HDMI monitor standby.
But I wonder what happened to this series?
I could find some reviewed-by: and acked-by: in [1] but it wasn't merged
upstream
for unidentifiable reasons.
We apparently had me
, Dmitry Baryshkov wrote:
On Sat, Jun 22, 2024 at 05:16:58PM GMT, Aradhya Bhatia wrote:
On 17-Jun-24 13:41, Dmitry Baryshkov wrote:
On Mon, Jun 17, 2024 at 07:40:32AM GMT, Jan Kiszka wrote:
On 16.02.24 15:57, Marek Vasut wrote:
On 2/16/24 10:10, Tomi Valkeinen wrote:
Ok. Does anyone have a
Hi,
On 23/08/2024 18:00, Laurent Pinchart wrote:
Hi Biju,
On Fri, Aug 23, 2024 at 01:52:14PM +, Biju Das wrote:
On Friday, August 23, 2024 2:15 PM, Laurent Pinchart wrote:
On Thu, Aug 22, 2024 at 05:23:13PM +0100, Biju Das wrote:
This patch series aims to add support for RZ/G2UL DU.
The
Hi,
On 23/08/2024 18:00, Laurent Pinchart wrote:
On Fri, Aug 23, 2024 at 02:33:49PM +0100, Lad, Prabhakar wrote:
On Wed, Jun 26, 2024 at 6:51 AM Laurent Pinchart wrote:
On Tue, Jun 25, 2024 at 01:32:44PM +0100, Prabhakar wrote:
From: Lad Prabhakar
All the RZ/G2L DU specific components are l
ntics.
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/
tilcdc/tilcdc_panel.c
index 68093d6b6b16..5f2d1b6
Hi,
On 09/08/2024 05:10, Kuninori Morimoto wrote:
Hi Tomi
Thank you for your review
+/**
+ * of_graph_get_next_ports() - get next ports node.
+ * @parent: pointer to the parent device node
+ * @ports: current ports node, or NULL to get first
+ *
+ * Return: A 'ports' node pointer with refco
Hi Rob,
On 21/03/2024 07:52, Tomi Valkeinen wrote:
On 20/03/2024 17:37, Rob Herring wrote:
On Tue, Mar 19, 2024 at 10:22:37AM +0200, Tomi Valkeinen wrote:
The DP subsystem for ZynqMP support audio via two channels, and the DP
DMA has dma-engines for those channels. For some reason the DT
Hi Sean,
On 17/06/2024 17:48, Sean Anderson wrote:
On 6/17/24 03:47, Tomi Valkeinen wrote:
Hi Sean,
On 03/05/2024 22:29, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
te
On 08/08/2024 09:13, Ma Ke wrote:
As it may return NULL pointer and cause NULL pointer dereference. Add check
for the return value of alloc_ordered_workqueue.
Cc: sta...@vger.kernel.org
Fixes: 2f95bc6d324a ("drm: omapdrm: Perform initialization/cleanup at probe/remove
time")
Signed-off-by: Ma K
)
has_endpoint = true;
of_node_put(endpoint);
Reviewed-by: Tomi Valkeinen
Tomi
;
goto err_free;
Reviewed-by: Tomi Valkeinen
Tomi
On 06/08/2024 07:58, Kuninori Morimoto wrote:
We already have of_graph_get_next_endpoint(), but it is not
intuitive to use.
(X) node {
(Y) ports {
port@0 { endpoint { remote-endpoint = ...; };};
(A1)port@1 { endpoint { remote-endpoint =
On 06/08/2024 07:58, Kuninori Morimoto wrote:
We have endpoint base functions
- of_graph_get_next_device_endpoint()
- of_graph_get_device_endpoint_count()
- for_each_of_graph_device_endpoint()
Here, for_each_of_graph_device_endpoint() loop finds each endpoints
po
On 06/08/2024 07:58, Kuninori Morimoto wrote:
Current test-component.c is using for_each_endpoint_of_node()
for parsing, but it should use "port" base loop instead of "endpoint",
because properties are "port" base, instead of "endpoint".
The subject of the patch makes this sound like it's just
Hi,
On 25/07/2024 14:28, Maxime Ripard wrote:
On Mon, Jul 15, 2024 at 11:32:34AM GMT, Tomi Valkeinen wrote:
On 02/07/2024 14:43, Maxime Ripard wrote:
Hi Tomi,
On Wed, Jun 26, 2024 at 06:53:40PM GMT, Tomi Valkeinen wrote:
On 26/06/2024 18:07, Maxime Ripard wrote:
On Wed, Jun 26, 2024 at 12
On 30/07/2024 03:34, Kuninori Morimoto wrote:
We already have for_each_endpoint_of_node(), don't use
of_graph_get_next_endpoint() directly. Replace it.
Signed-off-by: Kuninori Morimoto
Acked-by: Dmitry Baryshkov
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/base.c | 3 +--
drop taking the lock.
Fixes: 3cbd0c587b12 ("drm/omap: gem: Replace struct_mutex usage with omap_obj
private lock")
Reported-by: Dan Carpenter
Closes:
https://lore.kernel.org/all/511b99d7-aade-4f92-bd3e-63163a13d617@stanley.mountain/
Signed-off-by: Tomi Valkeinen
---
drivers/
nice. Hide the warnings by a (__iomem void
*) typecast.
Signed-off-by: Tomi Valkeinen
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202407311737.vsj0sr1w-...@intel.com/
Cc: Ville Syrjälä
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +++---
1 file chang
b2f ("drm/omap: Add support for drm_bridge")
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/base.c| 25 ++---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 +--
drivers/gpu/drm/omapdrm/omap_drv.c| 4 ++--
3 files changed, 9 insertions(+), 23 deletion
A few minor fixes to omapdrm, mostly to remove sparse or other checker
warnings.
Tomi
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (3):
drm/omap: Fix possible NULL dereference
drm/omap: Hide sparse warnings
drm/omap: Fix locking in omap_gem_new_dmabuf()
drivers/gpu/drm
On 31/07/2024 15:26, Laurent Pinchart wrote:
Hi Dan,
(CC'ing Tomi)
Thank for the report. It indeed seems that something is wrong.
Tomi, could you handle this and send a fix ?
On Tue, Jul 30, 2024 at 05:01:35PM -0500, Dan Carpenter wrote:
Hello Laurent Pinchart,
Commit 3cbd0c587b12 ("drm/
Hi,
On 19/07/2024 12:59, Arnd Bergmann wrote:
From: Arnd Bergmann
Compile-testing with CONFIG_MMU disabled causes a link error in omapdrm:
arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function
`omap_gem_fault_2d':
omap_gem.c:(.text+0x36e): undefined reference to `vmf_insert_m
On 02/07/2024 14:43, Maxime Ripard wrote:
Hi Tomi,
On Wed, Jun 26, 2024 at 06:53:40PM GMT, Tomi Valkeinen wrote:
On 26/06/2024 18:07, Maxime Ripard wrote:
On Wed, Jun 26, 2024 at 12:55:39PM GMT, Tomi Valkeinen wrote:
On 26/06/2024 11:49, Maxime Ripard wrote:
Hi,
On Wed, Jun 19, 2024 at 12
: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments AM625 OLDI Transmitter
+
+maintainers:
+ - Tomi Valkeinen
+ - Aradhya Bhatia
+
+description: |
+ The AM625 TI Keystone OpenLDI transmitter (OLDI TX) supports serialized RGB
+ pixel data transmission between host and flat
IVE>;
+clocks =<&k3_clks 67 1>,
+<&k3_clks 216 1>,
+<&k3_clks 67 2>;
+clock-names = "fck", "vp1", "vp2";
+interrupts = ;
+ports {
+#address-cells = <1>;
+#size-cells = <0>;
+port@0 {
+reg = <0>;
+oldi_out0: endpoint {
+remote-endpoint = <&lcd_in0>;
+};
};
+};
};
Reviewed-by: Tomi Valkeinen
Tomi
On 11/05/2024 22:30, Aradhya Bhatia wrote:
Up till now, the OLDI support in tidss was integrated within the tidss dispc.
This was fine till the OLDI was one-to-mapped with the DSS video-port (VP).
The AM62 and AM62P SoCs have 2 OLDI TXes that can support dual-lvds / lvds-clone
modes.
Add OLDI TX
On 26/06/2024 18:07, Maxime Ripard wrote:
On Wed, Jun 26, 2024 at 12:55:39PM GMT, Tomi Valkeinen wrote:
On 26/06/2024 11:49, Maxime Ripard wrote:
Hi,
On Wed, Jun 19, 2024 at 12:07:48PM GMT, Tomi Valkeinen wrote:
From: Tomi Valkeinen
When a bridge driver uses
akes sense to explain a bit about this in a comment in the
driver code. Otherwise doing all of this in pre_enable and post_disable
looks a bit odd.
Reviewed-by: Tomi Valkeinen
Tomi
Signed-off-by: Aradhya Bhatia
---
.../gpu/drm/bridge/cadence/cdns-dsi-core.c| 32 +++
1
On 22/06/2024 14:09, Aradhya Bhatia wrote:
Move the bridge pre_enable call before crtc enable, and the bridge
post_disable call after the crtc disable.
The sequence of enable after this patch will look like:
bridge[n]_pre_enable
...
bridge[1]_pre_enable
crtc_ena
Signed-off-by: Aradhya Bhatia
Reviewed-by: Tomi Valkeinen
Tomi
---
.../gpu/drm/bridge/cadence/cdns-dsi-core.c| 51 ---
1 file changed, 43 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
b/drivers/gpu/drm/bridge/cadence/cdns
(ctx, delay) \
do {\
Reviewed-by: Tomi Valkeinen
Tomi
On 22/06/2024 14:09, Aradhya Bhatia wrote:
If any normal DCS write command has already been transmitted prior to
transmitting any Zero-Parameter DCS command, then it is necessary to
clear the TX FIFO by resetting it. Otherwise, the FIFO points to another
location, and the DCS command transmits un
timeout(dsi->regs + MCTL_MAIN_STS, status,
+ status & tmp, 100, 0));
I think an error print is more suitable than WARN_ON_ONCE(). Other than
that:
Reviewed-by: Tomi Valkeinen
Tomi
+
writel(HBP_LEN(dsi_cfg.hbp) | HSA_LEN(dsi_cfg.hsa),
dsi->reg
_valid_check ? mode->clock :
mode->crtc_clock) * 1000,
mipi_dsi_pixel_format_to_bpp(output->dev->format),
nlanes, phy_cfg);
I think this is fine as a fix.
Reviewed-by: Tomi Valkeinen
However... Th
dsi->regs + VID_HSIZE1);
Reviewed-by: Tomi Valkeinen
Tomi
Hi,
On 22/06/2024 14:09, Aradhya Bhatia wrote:
Initialize the Phy during the cdns-dsi _resume(), and de-initialize it
during the _suspend().
Also power-off the Phy from bridge_disable.
Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework")
Signed-off-by: Aradhya Bhatia
---
drive
while at it.
Signed-off-by: Aradhya Bhatia
Reviewed-by: Tomi Valkeinen
Tomi
---
.../gpu/drm/bridge/cadence/cdns-dsi-core.c| 28 ++-
.../gpu/drm/bridge/cadence/cdns-dsi-core.h| 2 --
2 files changed, 3 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm
connecting to a
sink bridge", and the desc could first say that connecting the sink to a
DSI panel works, but connecting to a bridge fails, as wrong OF node is
passed to of_drm_find_bridge().
Reviewed-by: Tomi Valkeinen
Tomi
Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI d
On 26/06/2024 11:49, Maxime Ripard wrote:
Hi,
On Wed, Jun 19, 2024 at 12:07:48PM GMT, Tomi Valkeinen wrote:
From: Tomi Valkeinen
When a bridge driver uses devm_mipi_dsi_device_register_full() or
devm_mipi_dsi_attach(), the resource management is moved to devres,
which releases the resource
On 20/06/2024 13:42, Laurent Pinchart wrote:
On Thu, Jun 20, 2024 at 09:43:05AM +0300, Tomi Valkeinen wrote:
On 19/06/2024 22:32, Laurent Pinchart wrote:
Hi Jacopo,
Thank you for the patch.
On Wed, Jun 19, 2024 at 12:22:16PM +0200, Jacopo Mondi wrote:
From: Phong Hoang
Add a check to the
On 19/06/2024 22:32, Laurent Pinchart wrote:
Hi Jacopo,
Thank you for the patch.
On Wed, Jun 19, 2024 at 12:22:16PM +0200, Jacopo Mondi wrote:
From: Phong Hoang
Add a check to the register access function when attaching a bridge
device.
I think the desc is missing the "why". I'm guessing i
;< 16)
+#define CLOCKSET1_LOCK (1 << 17)
This matches the documentation, but we should get it tested on V4H to
make sure it doesn't cause a regression. Tomi, would you be able to test
the patch ?
Works for me.
Tested-by: Tomi Valkeinen
Tomi
From: Tomi Valkeinen
When a bridge driver uses devm_mipi_dsi_device_register_full() or
devm_mipi_dsi_attach(), the resource management is moved to devres,
which releases the resource automatically when the bridge driver is
unbound.
However, if the DSI host goes away first, the host
Hi Sean,
On 03/05/2024 22:29, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help debug signal-integrity issues.
Last time I discussed converting the HPD work(s) to a
Hi,
On 24/05/2024 02:49, Anatoliy Klymenko wrote:
Unconditionally enable the DPSUB layer in the corresponding atomic plane
update callback. Setting the new display mode may require disabling and
re-enabling the CRTC. This effectively resets DPSUB to the default state
with all layers disabled. Th
Hi,
On 16/06/2024 21:43, Laurent Pinchart wrote:
On Thu, Jun 13, 2024 at 11:05:01AM -0400, Sean Anderson wrote:
On 5/20/24 11:05, Sean Anderson wrote:
On 5/20/24 05:40, Christophe JAILLET wrote:
If zynqmp_dpsub_drm_init() fails, we must undo the previous
drm_bridge_add() call.
Fixes: be3f304
Hi,
On 03/05/2024 16:45, Ulf Hansson wrote:
+ Abel, Saravanna, Stephen
On Mon, 15 Apr 2024 at 19:17, Tomi Valkeinen
wrote:
On 15/04/2024 19:00, Tomi Valkeinen wrote:
Add a new flag, TI_SCI_PD_KEEP_BOOT_STATE, which can be set in the dts
when referring to power domains. When this flag is
Hi,
On 04/05/2024 00:54, Sean Anderson wrote:
Hi,
I have discovered a bug in the displayport driver on drm-misc-next. To
trigger it, run
echo fd4a.display > /sys/bus/platform/drivers/zynqmp-dpsub/unbind
The system will become unresponsive and (after a bit) splat with a hard
LOCKUP. One co
On 03/05/2024 19:27, Nathan Chancellor wrote:
Hi Tomi,
On Sat, Apr 27, 2024 at 10:48:16AM +0300, Tomi Valkeinen wrote:
On 26/04/2024 22:27, Anatoliy Klymenko wrote:
Fix number of CI reported W=1 build issues.
Patch 1/2: Fix function arguments description.
Closes:
https://lore.kernel.org/oe
On 26/04/2024 22:27, Anatoliy Klymenko wrote:
Fix number of CI reported W=1 build issues.
Patch 1/2: Fix function arguments description.
Closes:
https://lore.kernel.org/oe-kbuild-all/202404260616.kfgdpcdn-...@intel.com/
Patch 2/2: Fix clang compilation error.
Closes:
https://lore.kernel.org/o
On 26/04/2024 12:30, Laurent Pinchart wrote:
On Fri, Mar 22, 2024 at 08:01:44AM +0200, Tomi Valkeinen wrote:
On 08/03/2024 22:47, Sean Anderson wrote:
We must always register the DRM bridge, since zynqmp_dp_hpd_work_func
calls drm_bridge_hpd_notify, which in turn expects hpd_mutex to be
On 25/04/2024 18:17, Sean Anderson wrote:
On 4/24/24 14:54, Tomi Valkeinen wrote:
Hi Sean,
On 23/04/2024 20:18, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to
On 26/04/2024 04:46, Anatoliy Klymenko wrote:
Fix W=1 clang 19 compilation error in zynqmp_disp_layer_drm_formats().
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202404260946.4ozxvhd2-...@intel.com/
---
This is missing your signed-off-by.
Tomi
drivers/gp
Hi Sean,
On 23/04/2024 20:18, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help debug signal-integrity issues.
Last time I discussed converting the HPD work(s) to a
axime Ripard
To: Thomas Zimmermann
To: David Airlie
To: Daniel Vetter
To: Michal Simek
To: Andrzej Hajda
To: Neil Armstrong
To: Robert Foss
To: Jonas Karlman
To: Jernej Skrabec
To: Rob Herring
To: Krzysztof Kozlowski
To: Conor Dooley
To: Mauro Carvalho Chehab
Cc: Tomi Valkeinen
Cc
On 23/04/2024 20:18, Sean Anderson wrote:
Instead of polling the status register for the AUX status, just enable
the IRQs and signal a completion.
Signed-off-by: Sean Anderson
---
This one seems to cause a hang when I unload the modules. I didn't debug
it further yet, but most likely we get
On 23/04/2024 23:50, Sean Anderson wrote:
Hi,
On 3/22/24 02:01, Tomi Valkeinen wrote:
Hi,
On 08/03/2024 22:47, Sean Anderson wrote:
We must always register the DRM bridge, since zynqmp_dp_hpd_work_func
calls drm_bridge_hpd_notify, which in turn expects hpd_mutex to be
initialized. We do this
On 23/04/2024 17:59, Sean Anderson wrote:
On 4/23/24 09:33, Tomi Valkeinen wrote:
Hi Sean,
On 22/04/2024 21:45, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to
Hi Sean,
On 22/04/2024 21:45, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help debug signal-integrity issues.
Last time I discussed converting the HPD work(s) to a
On 22/04/2024 21:45, Sean Anderson wrote:
We always call scheduled_delayed_work with no delay, so just use a
non-delayed work_struct instead.
Signed-off-by: Sean Anderson
---
Reviewed-by: Tomi Valkeinen
Tomi
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 13
On 22/04/2024 21:45, Sean Anderson wrote:
Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed
members.
Signed-off-by: Sean Anderson
---
Reviewed-by: Tomi Valkeinen
Tomi
Changes in v3:
- Split off documentation for base pointers to previous commit
Changes in v2
, e.g., "blend_base", but it doesn't
really matter as they are accessed only in a couple of places.
Reviewed-by: Tomi Valkeinen
Tomi
drivers/gpu/drm/xlnx/zynqmp_disp.c | 44 +-
1 file changed, 19 insertions(+), 25 deletions(-)
diff --git a/drive
insertions(+), 17 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 8cdd74a9b772..13157da0089e 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -436,19 +436,29
/zynqmp_dp.c | 31 +++
3 files changed, 139 insertions(+), 4 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 891577475349..24f1f367b1d3 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b
BIT(8)
#define ZYNQMP_DISP_AV_BUF_PALETTE_MEMORY 0x400
Reviewed-by: Tomi Valkeinen
Tomi
On 15/04/2024 19:00, Tomi Valkeinen wrote:
Add a new flag, TI_SCI_PD_KEEP_BOOT_STATE, which can be set in the dts
when referring to power domains. When this flag is set, the ti-sci
driver will check if the PD is currently enabled in the HW, and if so,
set the GENPD_FLAG_ALWAYS_ON flag so that
The first patch here is a fix for ti_sci_pm_domains to handle the case
where the dts has two nodes which refer to the same PD.
The second is the interesting one, and very much an RFC.
Tomi
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (2):
pmdomain: ti-sci: Fix duplicate PD referrals
checking if a PD with the ID has already been created, and only
create a PD for new IDs.
Fixes: efa5c01cd7ee ("soc: ti: ti_sci_pm_domains: switch to use multiple genpds
instead of one")
Signed-off-by: Tomi Valkeinen
---
drivers/pmdomain/ti/ti_sci_pm_domains.c | 20 ++
is not a bit-mask, so maybe
adding TI_SCI_PD_KEEP_BOOT_STATE flag this way is not fine.
Signed-off-by: Tomi Valkeinen
---
drivers/pmdomain/ti/ti_sci_pm_domains.c| 27 +--
include/dt-bindings/soc/ti,sci_pm_domain.h | 1 +
2 files changed, 26 insertions(+), 2 deletions(-
On 10/04/2024 20:04, Ville Syrjälä wrote:
On Wed, Apr 10, 2024 at 06:25:17PM +0300, Ville Syrjälä wrote:
On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote:
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
__iowmb() isn't available on most architectures. Mak
On 10/04/2024 18:25, Ville Syrjälä wrote:
On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote:
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
__iowmb() isn't available on most architectures. Make
its use optional so that the driver can be built on
On 22/09/2023 10:37, Wolfram Sang wrote:
Since commit ab78029ecc34 ("drivers/pinctrl: grab default handles from
device core"), we can rely on device core for setting the default pins.
Signed-off-by: Wolfram Sang
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 --
1 file changed, 6 deletion
On 30/03/2024 22:28, Krzysztof Kozlowski wrote:
Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().
Signed-off-by: Krzysztof Kozlowski
---
drivers/gpu/drm/om
On 04/04/2024 10:32, Dan Carpenter wrote:
Free "dp" before returning.
Fixes: be318d01a903 ("drm: xlnx: dp: Reset DisplayPort IP")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
Allow omapdrm to be built with COMPILE_TEST=y for greater
coverage.
FIXME: Still borked due to ?
Cc: Tomi Valkeinen
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/omapdrm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
phys_to_page() is not available on most architectures.
Just open code it like msm does. Allows COMPILE_TEST=y
builds of omapdrm on other architectures.
Cc: Tomi Valkeinen
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/omapdrm
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
Allow tilcdc to be built with COMPILE_TEST=y for greater
coverage. Builds fine on x86/x86_64 at least.
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/tilcdc/Kconfig | 2 +-
1 file changed
On 08/04/2024 20:04, Ville Syrjala wrote:
From: Ville Syrjälä
__iowmb() isn't available on most architectures. Make
its use optional so that the driver can be built on
other architectures with COMPILE_TEST=y.
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Signed-off-by: Ville Syrjälä
---
driver
On 21/03/2024 22:43, Anatoliy Klymenko wrote:
Program live video input format according to selected media bus format.
In the bridge mode of operation, DPSUB is connected to FPGA CRTC which
almost certainly supports a single media bus format as its output. Expect
this to be delivered via the new
_request_dma(struct zynqmp_disp *disp,
unsigned int i;
int ret;
- if (!disp->dpsub->dma_enabled)
- return 0;
-
for (i = 0; i < layer->info->num_channels; i++) {
struct zynqmp_disp_layer_dma *dma = &layer->dmas[i];
char dma_channel_name[16];
Reviewed-by: Tomi Valkeinen
Tomi
On 21/03/2024 22:43, Anatoliy Klymenko wrote:
DPSUB in bridge mode supports multiple input media bus formats.
Announce the list of supported input media bus formats via
drm_bridge.atomic_get_input_bus_fmts callback.
Introduce a set of live input formats, supported by DPSUB.
Rename zynqmp_disp_la
On 21/03/2024 22:43, Anatoliy Klymenko wrote:
Set layer mode of operation (live or dma-based) during layer creation.
Each DPSUB layer mode of operation is defined by corresponding DT node port
connection, so it is possible to assign it during layer object creation.
Previously it was set in layer
,
* DISP Configuration
*/
+/**
+ * zynqmp_dp_disp_connected_live_layer - Return the first connected live layer
+ * @dp: DisplayPort IP core structure
+ *
+ * Return: The first connected live display layer or NULL if none of the live
+ * layer is connected.
"layers"
Reviewe
On 21/03/2024 22:43, Anatoliy Klymenko wrote:
Update live format defines to match DPSUB AV_BUF_LIVE_VID_CONFIG register
layout.
I think this description needs a bit more. Mention that the defines are
not currently used, so we can change them like this without any other
change.
Tomi
Revi
/zynqmp_disp.h | 13 +
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
drivers/gpu/drm/xlnx/zynqmp_kms.c | 2 +-
4 files changed, 19 insertions(+), 18 deletions(-)
Reviewed-by: Tomi Valkeinen
Tomi
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
b/drivers/gpu/drm/xlnx/zynqmp_disp.c
Add myself as a co-maintainer for Xilinx DRM drivers to help Laurent.
Signed-off-by: Tomi Valkeinen
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1aabf1c15bb3..79ef5a6bf21b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7306,6 +7306,7 @@ F
On 22/03/2024 23:22, Sean Anderson wrote:
On 3/22/24 14:09, Tomi Valkeinen wrote:
On 22/03/2024 18:18, Sean Anderson wrote:
On 3/22/24 01:32, Tomi Valkeinen wrote:
On 21/03/2024 21:17, Sean Anderson wrote:
On 3/21/24 15:08, Tomi Valkeinen wrote:
On 21/03/2024 20:01, Sean Anderson wrote:
On
On 22/03/2024 18:18, Sean Anderson wrote:
On 3/22/24 01:32, Tomi Valkeinen wrote:
On 21/03/2024 21:17, Sean Anderson wrote:
On 3/21/24 15:08, Tomi Valkeinen wrote:
On 21/03/2024 20:01, Sean Anderson wrote:
On 3/21/24 13:25, Tomi Valkeinen wrote:
On 21/03/2024 17:52, Sean Anderson wrote:
On
1 - 100 of 1439 matches
Mail list logo
