[PATCH v3 2/2] drm/omapdrm: Fix console with deferred ops

2024-02-27 Thread Tony Lindgren
s Zimmermann Signed-off-by: Tony Lindgren --- drivers/gpu/drm/omapdrm/Kconfig | 2 +- drivers/gpu/drm/omapdrm/omap_fbdev.c | 28 ++-- drivers/video/fbdev/core/Kconfig | 6 ++ include/linux/fb.h | 4 4 files changed, 33 insertions(+),

[PATCH v3 1/2] drm/omapdrm: Fix console by implementing fb_dirty

2024-02-27 Thread Tony Lindgren
elper"). Fixes: f231af498c29 ("drm/fb-helper: Disconnect damage worker from update logic") Reviewed-by: Thomas Zimmermann Signed-off-by: Tony Lindgren --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/omapd

[PATCH v3 0/2] Fixes for omapdrm console

2024-02-27 Thread Tony Lindgren
Changes since v1: - Add FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS to use with FB_DEFAULT_DEFERRED_OPS as suggested by Thomas Tony Lindgren (2): drm/omapdrm: Fix console by implementing fb_dirty drm/omapdrm: Fix console with deferred ops drivers/gpu/drm/omapdrm/Kconfig | 2 +- drivers/gpu/drm

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-27 Thread Tony Lindgren
* Tony Lindgren [240227 11:47]: > * Thomas Zimmermann [240227 09:16]: > > I just realized the fb_deferred_io_mmap() is already exported. So please use > > it instead of duplicating the code in omapdrm. > > > > [1] > > https://elixir.bootlin.com/linux/v6.

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-27 Thread Tony Lindgren
* Thomas Zimmermann [240227 09:16]: > I just realized the fb_deferred_io_mmap() is already exported. So please use > it instead of duplicating the code in omapdrm. > > [1] > https://elixir.bootlin.com/linux/v6.7/source/drivers/video/fbdev/core/fb_defio.c#L237 Yeah I have now: static int

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-27 Thread Tony Lindgren
* Thomas Zimmermann [240227 07:56]: > Am 27.02.24 um 08:06 schrieb Tony Lindgren: > > * Tony Lindgren [240226 13:26]: > > > * Thomas Zimmermann [240226 09:10]: > > > > Am 26.02.24 um 10:01 schrieb Tomi Valkeinen: > > > > > On 26/02/2024 10:26, Tomi

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-26 Thread Tony Lindgren
* Tony Lindgren [240226 13:26]: > * Thomas Zimmermann [240226 09:10]: > > Am 26.02.24 um 10:01 schrieb Tomi Valkeinen: > > > On 26/02/2024 10:26, Tomi Valkeinen wrote: > > > > How is it broken? I don't usually use the console (or fbdev) but > > > > ena

Re: [PATCH v2 0/2] Fixes for omapdrm console

2024-02-26 Thread Tony Lindgren
* Thomas Zimmermann [240226 09:10]: > Hi > > Am 26.02.24 um 10:01 schrieb Tomi Valkeinen: > > On 26/02/2024 10:26, Tomi Valkeinen wrote: > > > Hi Tony, > > > > > > On 25/02/2024 08:46, Tony Lindgren wrote: > > > > Here are two fixes for o

[PATCH v2 2/2] drm/omapdrm: Fix console with deferred ops

2024-02-24 Thread Tony Lindgren
suggested by Thomas. We no longer need omap_fbdev_fb_mmap() as FB_DEFAULT_DEFERRED_OPS sets it to fb_deferred_io_mmap(). Fixes: 95da53d63dcf ("drm/omapdrm: Use regular fbdev I/O helpers") Suggested-by: Thomas Zimmermann Signed-off-by: Tony Lindgren --- drivers/gpu/drm/omapd

[PATCH v2 1/2] drm/omapdrm: Fix console by implementing fb_dirty

2024-02-24 Thread Tony Lindgren
elper"). Fixes: f231af498c29 ("drm/fb-helper: Disconnect damage worker from update logic") Reviewed-by: Thomas Zimmermann Signed-off-by: Tony Lindgren --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/omapd

[PATCH v2 0/2] Fixes for omapdrm console

2024-02-24 Thread Tony Lindgren
Here are two fixes for omapdrm console. Regards, Tony Changes since v1: - Add FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS to use with FB_DEFAULT_DEFERRED_OPS as suggested by Thomas Tony Lindgren (2): drm/omapdrm: Fix console by implementing fb_dirty drm/omapdrm: Fix console with deferred ops

Re: [PATCH 2/2] drm/omapdrm: Fix console with deferred ops

2024-02-24 Thread Tony Lindgren
* Thomas Zimmermann [240220 10:42]: > The changes below look good. You can test by instrumenting > drm_fb_helper_deferred_io() with printk(). For testing, you can reduce the > write-back frequency by setting helper->fbdefio.delay to a higher value. If > you set it to HZ, it should only do a

[PATCH v5 10/10] drm/bridge: tc358775: Configure hs_rate and lp_rate

2024-02-24 Thread Tony Lindgren
The hs_rate and lp_rate may be used by the dsi host for timing calculations. The tc358775 has a maximum bit rate of 1 Gbps/lane, tc358765 has maximurate of 800 Mbps per lane. Reviewed-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 13 + 1

[PATCH v5 09/10] drm/bridge: tc358775: Add support for tc358765

2024-02-24 Thread Tony Lindgren
set it to video event mode for the LCD output to work, and on the tc358775, this bit no longer exists. Looks like the registers seem to match otherwise based on a quick glance comparing the defines to the earlier Android kernel tc358765 driver. Reviewed-by: Michael Walle Signed-off-by: Tony

[PATCH v5 08/10] drm/bridge: tc358775: Enable pre_enable_prev_first flag

2024-02-24 Thread Tony Lindgren
Set pre_enable_prev_first to ensure the previous bridge is enabled first. Reviewed-by: Dmitry Baryshkov Reviewed-by: Michael Walle Tested-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm

[PATCH v5 07/10] drm/bridge: tc358775: Add burst and low-power modes

2024-02-24 Thread Tony Lindgren
Burst and low-power modes are supported both for tc358765 and tc358775. Reviewed-by: Michael Walle Tested-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775

[PATCH v5 06/10] drm/bridge: tc358775: Get bridge data lanes instead of the DSI host lanes

2024-02-24 Thread Tony Lindgren
, let's be nice and also check the DSI host for old dtb in use and warn. And as Dmitry pointed out, the lanes for the host and the bridge may be different because the lanes may be swapped on the host side. Reviewed-by: Dmitry Baryshkov Reviewed-by: Michael Walle Signed-off-by: Tony Lindgren

[PATCH v5 05/10] drm/bridge: tc358775: make standby GPIO optional

2024-02-24 Thread Tony Lindgren
-by: Krzysztof Kozlowski Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu

[PATCH v5 04/10] drm/bridge: tc358775: fix support for jeida-18 and jeida-24

2024-02-24 Thread Tony Lindgren
with a jeida-18 display (Evervision VGG644804). Fixes: b26975593b17 ("display/drm/bridge: TC358775 DSI/LVDS driver") Signed-off-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 21 + 1 file changed, 9 insertions(+), 12 deletion

[PATCH v5 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765

2024-02-24 Thread Tony Lindgren
ski Signed-off-by: Tony Lindgren --- .../display/bridge/toshiba,tc358775.yaml | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display/bridge/tosh

[PATCH v5 02/10] dt-bindings: display: bridge: tc358775: Add data-lanes

2024-02-24 Thread Tony Lindgren
depends on the controller used and is unrelated to the bridge binding. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Tony Lindgren --- .../display/bridge/toshiba,tc358775.yaml | 22 --- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/Documentation

[PATCH v5 01/10] dt-bindings: display: bridge: tc358775: make stby gpio optional

2024-02-24 Thread Tony Lindgren
: dropped regulator related changes] Signed-off-by: Tony Lindgren --- .../devicetree/bindings/display/bridge/toshiba,tc358775.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display

[PATCH v5 00/10] Improvments for tc358775 with support for tc358765

2024-02-24 Thread Tony Lindgren
: tc358775: fix support for jeida-18 and jeida-24 drm/bridge: tc358775: make standby GPIO optional Tony Lindgren (7): dt-bindings: display: bridge: tc358775: Add data-lanes dt-bindings: display: bridge: tc358775: Add support for tc358765 drm/bridge: tc358775: Get bridge data lanes instead

Re: [PATCH v4 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765

2024-02-24 Thread Tony Lindgren
* Krzysztof Kozlowski [240215 18:43]: > If there is going to be new version, please put allOf: block after > required: block. OK will post v5 set. > Anyway: > > Reviewed-by: Krzysztof Kozlowski Thanks, Tony

Re: [PATCH 2/2] drm/omapdrm: Fix console with deferred ops

2024-02-20 Thread Tony Lindgren
* Thomas Zimmermann [240220 09:32]: > Am 20.02.24 um 09:56 schrieb Tony Lindgren: > > Oh right, yes omapdrm is operating on memory. > > With the latest kernels, you should see a warning if helpers operate on the > wrong type of memory. [1][2] OK > [1] > https://elixi

Re: [PATCH 2/2] drm/omapdrm: Fix console with deferred ops

2024-02-20 Thread Tony Lindgren
* Thomas Zimmermann [240219 16:43]: > Am 19.02.24 um 15:19 schrieb Tony Lindgren: > > --- a/drivers/gpu/drm/omapdrm/Kconfig > > +++ b/drivers/gpu/drm/omapdrm/Kconfig > > @@ -5,6 +5,7 @@ config DRM_OMAP > > depends on ARCH_OMAP2PLUS > > sel

[PATCH 2/2] drm/omapdrm: Fix console with deferred ops

2024-02-19 Thread Tony Lindgren
rm: Use regular fbdev I/O helpers") Signed-off-by: Tony Lindgren --- drivers/gpu/drm/omapdrm/Kconfig | 1 + drivers/gpu/drm/omapdrm/omap_fbdev.c | 8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconf

[PATCH 1/2] drm/omapdrm: Fix console by implementing fb_dirty

2024-02-19 Thread Tony Lindgren
elper"). Fixes: f231af498c29 ("drm/fb-helper: Disconnect damage worker from update logic") Signed-off-by: Tony Lindgren --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/driver

[PATCH v4 10/10] drm/bridge: tc358775: Configure hs_rate and lp_rate

2024-02-15 Thread Tony Lindgren
The hs_rate and lp_rate may be used by the dsi host for timing calculations. The tc358775 has a maximum bit rate of 1 Gbps/lane, tc358765 has maximurate of 800 Mbps per lane. Reviewed-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 13 + 1

[PATCH v4 09/10] drm/bridge: tc358775: Add support for tc358765

2024-02-15 Thread Tony Lindgren
set it to video event mode for the LCD output to work, and on the tc358775, this bit no longer exists. Looks like the registers seem to match otherwise based on a quick glance comparing the defines to the earlier Android kernel tc358765 driver. Reviewed-by: Michael Walle Signed-off-by: Tony

[PATCH v4 08/10] drm/bridge: tc358775: Enable pre_enable_prev_first flag

2024-02-15 Thread Tony Lindgren
Set pre_enable_prev_first to ensure the previous bridge is enabled first. Reviewed-by: Dmitry Baryshkov Reviewed-by: Michael Walle Tested-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm

[PATCH v4 07/10] drm/bridge: tc358775: Add burst and low-power modes

2024-02-15 Thread Tony Lindgren
Burst and low-power modes are supported both for tc358765 and tc358775. Reviewed-by: Michael Walle Tested-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775

[PATCH v4 06/10] drm/bridge: tc358775: Get bridge data lanes instead of the DSI host lanes

2024-02-15 Thread Tony Lindgren
, let's be nice and also check the DSI host for old dtb in use and warn. And as Dmitry pointed out, the lanes for the host and the bridge may be different because the lanes may be swapped on the host side. Reviewed-by: Dmitry Baryshkov Reviewed-by: Michael Walle Signed-off-by: Tony Lindgren

[PATCH v4 05/10] drm/bridge: tc358775: make standby GPIO optional

2024-02-15 Thread Tony Lindgren
-by: Krzysztof Kozlowski Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu

[PATCH v4 04/10] drm/bridge: tc358775: fix support for jeida-18 and jeida-24

2024-02-15 Thread Tony Lindgren
with a jeida-18 display (Evervision VGG644804). Fixes: b26975593b17 ("display/drm/bridge: TC358775 DSI/LVDS driver") Signed-off-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 21 + 1 file changed, 9 insertions(+), 12 deletion

[PATCH v4 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765

2024-02-15 Thread Tony Lindgren
The tc358765 is similar to tc358775. The tc358765 just an earlier version of the hardware, and it's pin and register compatible with tc358775 for most part. >From the binding point of view the only difference is that the tc358765 does not have stdby-gpios. Signed-off-by: Tony Lindg

[PATCH v4 02/10] dt-bindings: display: bridge: tc358775: Add data-lanes

2024-02-15 Thread Tony Lindgren
depends on the controller used and is unrelated to the bridge binding. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Tony Lindgren --- .../display/bridge/toshiba,tc358775.yaml | 22 --- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/Documentation

[PATCH v4 01/10] dt-bindings: display: bridge: tc358775: make stby gpio optional

2024-02-15 Thread Tony Lindgren
: dropped regulator related changes] Signed-off-by: Tony Lindgren --- .../devicetree/bindings/display/bridge/toshiba,tc358775.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display

[PATCH v4 00/10] Improvments for tc358775 with support for tc358765

2024-02-15 Thread Tony Lindgren
side like other bridge devices do, and if not found, also parse on the DSI host side and warn Michael Walle (3): dt-bindings: display: bridge: tc358775: make stby gpio optional drm/bridge: tc358775: fix support for jeida-18 and jeida-24 drm/bridge: tc358775: make standby GPIO optional Tony

Re: [PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765

2024-02-12 Thread Tony Lindgren
* Rob Herring [240212 13:51]: > On Mon, Feb 12, 2024 at 12:30:12PM +0100, Krzysztof Kozlowski wrote: > > On 12/02/2024 09:17, Tony Lindgren wrote: > > > usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] > > > [-f {parsable,standar

Re: [PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765

2024-02-12 Thread Tony Lindgren
* Krzysztof Kozlowski [240212 08:06]: > On 11/02/2024 10:51, Tony Lindgren wrote: > > The tc358765 is similar to tc358775. The tc358765 just an earlier version > > of the hardware, and it's pin and register compatible with tc358775 for > > most part. > > > &g

[PATCH v2 1/2] dt-bindings: display: simple: Add boe, bp082wx1-100 8.2" panel

2024-02-11 Thread Tony Lindgren
This panel is found on Motorola mapphone tablets mz607 to mz609. Acked-by: Conor Dooley Signed-off-by: Tony Lindgren --- No changes since v1 --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree

[PATCH v2 2/2] drm/panel: simple: Add BOE BP082WX1-100 8.2" panel

2024-02-11 Thread Tony Lindgren
The BOE BP082WX1-100 is a 8.2" panel similar to the 10.1" panel BP101WX1-100. Both panels use the same timings. Acked-by: Conor Dooley Reviewed-by: Dmitry Baryshkov Signed-off-by: Tony Lindgren --- Changes since v1: - Update viewport dimensions based on panelook values asa

[PATCH v3 10/10] drm/bridge: tc358775: Configure hs_rate and lp_rate

2024-02-11 Thread Tony Lindgren
The hs_rate and lp_rate may be used by the dsi host for timing calculations. The tc358775 has a maximum bit rate of 1 Gbps/lane, tc358765 has maximurate of 800 Mbps per lane. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 13 + 1 file changed, 13 insertions

[PATCH v3 09/10] drm/bridge: tc358775: Add support for tc358765

2024-02-11 Thread Tony Lindgren
set it to video event mode for the LCD output to work, and on the tc358775, this bit no longer exists. Looks like the registers seem to match otherwise based on a quick glance comparing the defines to the earlier Android kernel tc358765 driver. Reviewed-by: Michael Walle Signed-off-by: Tony

[PATCH v3 08/10] drm/bridge: tc358775: Enable pre_enable_prev_first flag

2024-02-11 Thread Tony Lindgren
Set pre_enable_prev_first to ensure the previous bridge is enabled first. Reviewed-by: Dmitry Baryshkov Reviewed-by: Michael Walle Tested-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm

[PATCH v3 07/10] drm/bridge: tc358775: Add burst and low-power modes

2024-02-11 Thread Tony Lindgren
Burst and low-power modes are supported both for tc358765 and tc358775. Reviewed-by: Michael Walle Tested-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775

[PATCH v3 06/10] drm/bridge: tc358775: Get bridge data lanes instead of the DSI host lanes

2024-02-11 Thread Tony Lindgren
, let's be nice and also check the DSI host for old dtb in use and warn. And as Dmitry pointed out, the lanes for the host and the bridge may be different because the lanes may be swapped on the host side. Reviewed-by: Dmitry Baryshkov Reviewed-by: Michael Walle Signed-off-by: Tony Lindgren

[PATCH v3 05/10] drm/bridge: tc358775: make standby GPIO optional

2024-02-11 Thread Tony Lindgren
-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -669,12

[PATCH v3 04/10] drm/bridge: tc358775: fix support for jeida-18 and jeida-24

2024-02-11 Thread Tony Lindgren
with a jeida-18 display (Evervision VGG644804). Fixes: b26975593b17 ("display/drm/bridge: TC358775 DSI/LVDS driver") Signed-off-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 21 + 1 file changed, 9 insertions(+), 12 deletion

[PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765

2024-02-11 Thread Tony Lindgren
The tc358765 is similar to tc358775. The tc358765 just an earlier version of the hardware, and it's pin and register compatible with tc358775 for most part. >From the binding point of view the only difference is that the tc358765 does not have stdby-gpios. Signed-off-by: Tony Lindg

[PATCH v3 02/10] dt-bindings: display: bridge: tc358775: Add data-lanes

2024-02-11 Thread Tony Lindgren
depends on the controller used and is unrelated to the bridge binding. Signed-off-by: Tony Lindgren --- .../display/bridge/toshiba,tc358775.yaml | 22 --- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba

[PATCH v3 01/10] dt-bindings: display: bridge: tc358775: make stby gpio optional

2024-02-11 Thread Tony Lindgren
] Signed-off-by: Tony Lindgren --- .../devicetree/bindings/display/bridge/toshiba,tc358775.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml

[PATCH v3 00/10] Improvments for tc358775 with support for tc358765

2024-02-11 Thread Tony Lindgren
, and if not found, also parse on the DSI host side and warn Michael Walle (3): dt-bindings: display: bridge: tc358775: make stby gpio optional drm/bridge: tc358775: fix support for jeida-18 and jeida-24 drm/bridge: tc358775: make standby GPIO optional Tony Lindgren (7): dt-bindings: display: bridge

Re: [PATCH v2 09/10] drm/bridge: tc358775: Add support for tc358765

2024-01-30 Thread Tony Lindgren
* Michael Walle [231204 09:52]: > >> @@ -643,6 +658,7 @@ static int tc_probe(struct i2c_client *client) > >> > >> tc->dev = dev; > >> tc->i2c = client; > >> + tc->type = (enum tc3587x5_type)of_device_get_match_data(dev); > > > > Would it make sense to use

Re: [PATCH v2 10/10] drm/bridge: tc358775: Configure hs_rate and lp_rate

2024-01-30 Thread Tony Lindgren
* Michael Walle [231207 16:14]: > > The hs_rate and lp_rate may be used by the dsi host for timing > > calculations. The tc358775 has a maximum bit rate of 1 Gbps/lane, > > tc358765 has maximurate of 800 Mbps per lane. > > > > Signed-off-by: Tony Lindgren >

Re: [PATCH 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2024-01-26 Thread Tony Lindgren
* Rob Herring [240119 17:48]: > On Wed, Jan 10, 2024 at 10:38:57AM +0200, Tony Lindgren wrote: > > So for merging these, as many of the changes touch the omap variants, I > > could set up an immutable branch with all the changes after -rc1. Or I can > > ack the patches too i

Re: [PATCH 08/11] ARM: dts: DRA7xx: Add device tree entry for SGX GPU

2024-01-25 Thread Tony Lindgren
* Tony Lindgren [240118 08:57]: > * Andrew Davis [240117 15:52]: > > On 1/10/24 2:29 AM, Tony Lindgren wrote: > > > * Andrew Davis [240109 17:20]: > > > > --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi > > > > +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi &

Re: [PATCH 08/11] ARM: dts: DRA7xx: Add device tree entry for SGX GPU

2024-01-18 Thread Tony Lindgren
* Andrew Davis [240117 15:52]: > On 1/10/24 2:29 AM, Tony Lindgren wrote: > > * Andrew Davis [240109 17:20]: > > > --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi > > > +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi > > > @@ -850,

Re: [PATCH 02/11] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2024-01-10 Thread Tony Lindgren
* Krzysztof Kozlowski [240109 19:53]: > On 09/01/2024 18:19, Andrew Davis wrote: > > The Imagination PowerVR Series5 "SGX" GPU is part of several SoCs from > > multiple vendors. Describe how the SGX GPU is integrated in these SoC, > > including register space and interrupts. Clocks, reset, and

Re: [PATCH 08/11] ARM: dts: DRA7xx: Add device tree entry for SGX GPU

2024-01-10 Thread Tony Lindgren
* Andrew Davis [240109 17:20]: > --- a/arch/arm/boot/dts/ti/omap/dra7.dtsi > +++ b/arch/arm/boot/dts/ti/omap/dra7.dtsi > @@ -850,12 +850,19 @@ target-module@5600 { > ; > ti,sysc-sidle = , > , > -

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-06 Thread Tony Lindgren
* Andreas Kemnade [231205 09:43]: > On Tue, 5 Dec 2023 10:27:56 +0100 > Krzysztof Kozlowski wrote: > > > On 05/12/2023 10:02, Andreas Kemnade wrote: > > > On Tue, 5 Dec 2023 09:45:44 +0100 > > > Krzysztof Kozlowski wrote: > > > > > >>> Sure the clock nodes can be there for the child IP, but

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Tony Lindgren
* Krzysztof Kozlowski [231205 08:16]: > On 05/12/2023 09:10, Tony Lindgren wrote: > > * Krzysztof Kozlowski [231205 08:03]: > >> What does runtime PM have to do with it? If runtime PM enables clocks, > >> these are real signals and not optional. > > > &

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Tony Lindgren
* Krzysztof Kozlowski [231205 08:03]: > What does runtime PM have to do with it? If runtime PM enables clocks, > these are real signals and not optional. Runtime PM propagates to the parent device. Regards, Tony

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-04 Thread Tony Lindgren
* Krzysztof Kozlowski [231205 07:10]: > On 04/12/2023 19:22, Andrew Davis wrote: > > @@ -56,6 +76,43 @@ allOf: > >properties: > > clocks: > >maxItems: 1 > > + required: > > +- clocks > > +- clock-names > > You need to define the clocks for your

[PATCH 2/2] drm/panel: simple: Add BOE BP082WX1-100 8.2" panel

2023-12-02 Thread Tony Lindgren
The BOE BP082WX1-100 is a 8.2" panel similar to the 10.1" panel BP101WX1-100. Both panels use the same timings. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/panel/panel-simple.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-s

[PATCH 1/2] dt-bindings: display: simple: Add boe, bp082wx1-100 8.2" panel

2023-12-02 Thread Tony Lindgren
This panel is found on Motorola mapphone tablets mz607 to mz609. Signed-off-by: Tony Lindgren --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b

[PATCH v2 10/10] drm/bridge: tc358775: Configure hs_rate and lp_rate

2023-12-02 Thread Tony Lindgren
The hs_rate and lp_rate may be used by the dsi host for timing calculations. The tc358775 has a maximum bit rate of 1 Gbps/lane, tc358765 has maximurate of 800 Mbps per lane. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH v2 09/10] drm/bridge: tc358775: Add support for tc358765

2023-12-02 Thread Tony Lindgren
set it to video event mode for the LCD output to work, and on the tc358775, this bit no longer exists. Looks like the registers seem to match otherwise based on a quick glance comparing the defines to the earlier Android kernel tc358765 driver. Signed-off-by: Tony Lindgren --- drivers/gpu/drm

[PATCH v2 08/10] drm/bridge: tc358775: Enable pre_enable_prev_first flag

2023-12-02 Thread Tony Lindgren
Set pre_enable_prev_first to ensure the previous bridge is enabled first. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c --- a/drivers/gpu/drm/bridge

[PATCH v2 07/10] drm/bridge: tc358775: Add burst and low-power modes

2023-12-02 Thread Tony Lindgren
Burst and low-power modes are supported both for tc358765 and tc358775. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c --- a/drivers

[PATCH v2 06/10] drm/bridge: tc358775: Get bridge data lanes instead of the DSI host lanes

2023-12-02 Thread Tony Lindgren
, let's be nice and also check the DSI host for old dtb in use and warn. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge

[PATCH v2 05/10] drm/bridge: tc358775: make standby GPIO optional

2023-12-02 Thread Tony Lindgren
From: Michael Walle The stby pin is optional. It is only needed for power-up and down sequencing. It is not needed, if the power rails cannot by dynamically enabled. Because the GPIO is not optional, remove the error message. Signed-off-by: Michael Walle Signed-off-by: Tony Lindgren

[PATCH v2 04/10] drm/bridge: tc358775: fix support for jeida-18 and jeida-24

2023-12-02 Thread Tony Lindgren
with a jeida-18 display (Evervision VGG644804). Fixes: b26975593b17 ("display/drm/bridge: TC358775 DSI/LVDS driver") Signed-off-by: Michael Walle Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 21 + 1 file changed, 9 insertions(+), 12 deletion

[PATCH v2 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765

2023-12-01 Thread Tony Lindgren
The tc358765 is similar to tc358775 except for the stdby-gpios. Signed-off-by: Tony Lindgren --- .../bindings/display/bridge/toshiba,tc358775.yaml | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba

[PATCH v2 02/10] dt-bindings: display: bridge: tc358775: Add data-lanes

2023-12-01 Thread Tony Lindgren
depends on the controller used and is unrelated to the bridge binding. Signed-off-by: Tony Lindgren --- .../display/bridge/toshiba,tc358775.yaml | 21 --- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba

[PATCH v2 01/10] dt-bindings: display: bridge: tc358775: make stby gpio and vdd supplies optional

2023-12-01 Thread Tony Lindgren
the reset pin. Signed-off-by: Michael Walle Signed-off-by: Tony Lindgren --- .../devicetree/bindings/display/bridge/toshiba,tc358775.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml b/Documentation/devicetree

[PATCH v2 00/10] Improvments for tc358775 with support for tc358765

2023-12-01 Thread Tony Lindgren
and jeida-24 drm/bridge: tc358775: make standby GPIO optional Tony Lindgren (7): dt-bindings: display: bridge: tc358775: Add data-lanes dt-bindings: display: bridge: tc358775: Add support for tc358765 drm/bridge: tc358775: Get bridge data lanes instead of the DSI host lanes drm/bridge

Re: [PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes

2023-11-27 Thread Tony Lindgren
* Michael Walle [231127 14:31]: > + dt maintainers > > > > I actually have the same fix, but with one additional detail, which > > > I'm > > > unsure about though: This looks at the data-lanes property of the > > > *remote* > > > endpoint whereas other bridge drivers (see tc358767, ti-sn65dsi83,

Re: [PATCH 3/6] drm/bridge: tc358775: Add jeida-24 support

2023-11-27 Thread Tony Lindgren
tch: Yes great works for me with the tc358765 patches: Tested-by: Tony Lindgren > --snip-- > > From 46da1d76d4908e5879ed746cce1faeacd69c432e Mon Sep 17 00:00:00 2001 > From: Michael Walle > Date: Wed, 4 Oct 2023 13:52:57 +0200 > Subject: [PATCH] drm/bridge: tc358775

Re: [PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes

2023-11-27 Thread Tony Lindgren
* Michael Walle [231127 13:10]: > I actually have the same fix, but with one additional detail, which I'm > unsure about though: This looks at the data-lanes property of the *remote* > endpoint whereas other bridge drivers (see tc358767, ti-sn65dsi83, lt8912b, > anx7625) look at the local

Re: [PATCH 1/6] dt-bindings: tc358775: Add support for tc358765

2023-11-27 Thread Tony Lindgren
* Michael Walle [231127 12:44]: > Hi, > > > The tc358765 is similar to tc358775 except for the stdby-gpios. > > Bad timing (for me). I'm about to send a bigger patch series for the > tc358775 which fixes the (completely) broken initialialization. And also > contains some of your fixes. OK

[PATCH 2/2] drm/panel: simple: Add BOE BP101WX1-100 panel

2023-11-26 Thread Tony Lindgren
This panel is found on Motorola mapphone tablets from mz615 to mz617. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/panel/panel-simple.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel

[PATCH 1/2] dt-bindings: display: simple: Add boe,bp101wx1-100 panel

2023-11-26 Thread Tony Lindgren
This panel is found on Motorola mapphone tablets mz615 to mz617. Signed-off-by: Tony Lindgren --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b

[PATCH 6/6] drm/bridge: tc358775: Configure hs_rate and lp_rate

2023-11-26 Thread Tony Lindgren
The hs_rate and lp_rate may be used by the dsi host for timing calculations. The tc358775 has a maximum bit rate of 1 Gbps/lane, tc358765 has maximurate of 800 Mbps per lane. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 5/6] drm/bridge: tc358775: Add support for tc358765

2023-11-26 Thread Tony Lindgren
output to work. On tc358775, this bit no longer exists. Looks like the registers seem to match otherwise based on a quick glance comparing the defines to the earlier Android kernel tc358765 driver. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 55

[PATCH 4/6] drm/bridge: tc358775: Add burst and low-power modes

2023-11-26 Thread Tony Lindgren
Burst and low-power modes are supported both for tc358765 and tc358775. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c --- a/drivers

[PATCH 3/6] drm/bridge: tc358775: Add jeida-24 support

2023-11-26 Thread Tony Lindgren
The jeida-24 register values are the default hardware settings, but they not listed in the driver. Let's add them. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge

[PATCH 2/6] drm/bridge: tc358775: Fix getting dsi host data lanes

2023-11-26 Thread Tony Lindgren
river") Signed-off-by: Tony Lindgren --- drivers/gpu/drm/bridge/tc358775.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/

[PATCH 1/6] dt-bindings: tc358775: Add support for tc358765

2023-11-26 Thread Tony Lindgren
The tc358765 is similar to tc358775 except for the stdby-gpios. Signed-off-by: Tony Lindgren --- .../display/bridge/toshiba,tc358775.yaml| 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba

Re: [PATCH] omap: dsi: do not WARN on detach if dsidev was never attached

2023-09-21 Thread Tony Lindgren
* Tomi Valkeinen [230921 10:53]: > I sent a patch to the DSI framework code, > "[PATCH] drm/mipi-dsi: Fix detach call without attach". > > If that fixes the issue (please test, I don't have a suitable platform), > perhaps it's a better fix as detach really shouldn't be called if attach has > not

Re: [PATCH] drm/mipi-dsi: Fix detach call without attach

2023-09-21 Thread Tony Lindgren
l. Thanks this fixes the deferred probe warning I've been seeing: Tested-by: Tony Lindgren

Re: [PATCH] omap: dsi: do not WARN on detach if dsidev was never attached

2023-09-19 Thread Tony Lindgren
t; > This happens if the panel driver asks for an EPROBE_DEFER. > > So let's suppress the WARN() in this special case. Reviewed-by: Tony Lindgren Thanks, Tony

Re: [PATCH] drm/omap: dsi: Fix deferred probe warnings

2023-09-17 Thread Tony Lindgren
* H. Nikolaus Schaller [230916 12:50]: > Hi Tomi and Tony, > > > Am 13.09.2023 um 13:59 schrieb Tomi Valkeinen > > : > > > > On 12/04/2023 10:39, Tony Lindgren wrote: > >> We may not have dsi->dsidev initialized during probe, and that can &

Re: [PATCH] drm/omap: dsi: Fix deferred probe warnings

2023-09-13 Thread Tony Lindgren
* Tomi Valkeinen [230913 11:59]: > On 12/04/2023 10:39, Tony Lindgren wrote: > > We may not have dsi->dsidev initialized during probe, and that can > > lead into various dsi related warnings as omap_dsi_host_detach() gets > > called with dsi->dsidev set to NULL

Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4

2023-09-13 Thread Tony Lindgren
* Tomi Valkeinen [230913 12:11]: > I'm somewhat sure that the upstream driver used to work on omap4 sdp, which > has two DSI panels. But I can't even remember what omap4 version it had. I think those were both dsi command mode panels though, not video mode? Regards, Tony

Re: [PATCH] drm/omap: dsi: Fix deferred probe warnings

2023-09-13 Thread Tony Lindgren
* Laurent Pinchart [230412 11:59]: > On Wed, Apr 12, 2023 at 11:55:34AM +0300, Tomi Valkeinen wrote: > > On 12/04/2023 11:50, Laurent Pinchart wrote: > > > Hi Tony, > > > > > > Thank you for the patch. > > > > > > On Wed, Apr 12, 2023 a

Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4

2023-09-13 Thread Tony Lindgren
* Andreas Kemnade [230913 06:59]: > Some 3.0 source has it set behind a if (omap4). > Maybe it is helpful maybe not, at least in the omap4460 > trm these bits are marked as reserved. > But maybe some dsi video mode panel starts magically working. Interesting. So Andreas mentioned that dsi video

[PATCH] drm/omap: dsi: Fix deferred probe warnings

2023-04-12 Thread Tony Lindgren
mapdrm/dss/dsi.c:4414. Let's fix the warnings by checking for a valid dsi->dsidev. Signed-off-by: Tony Lindgren --- drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c --

Re: [PATCH v3 4/6] ARM: dts: omap: Use new media bus type macros

2023-01-19 Thread Tony Lindgren
* Laurent Pinchart [230114 15:37]: > Tony, could you take this patch in your tree for v6.3 ? The two patches > that it depends on have both been merged in v6.2. OK applying into omap-for-v6.3/dt. Thanks, Tony

  1   2   3   4   >