[PATCH v2 08/10] drm/panel: tpg110: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver tpo-tpg110-pa

[PATCH v2 06/10] drm/panel: s6d27a1: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver s6d27a1-pa

[PATCH v2 10/10] drm/panel: y030xx067a: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver abt-y030xx0

[PATCH v2 04/10] drm/panel: novatek, nt39016: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver nt39

[PATCH v2 09/10] drm/panel: ws2401: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver ws2401-pa

[PATCH v2 00/10] drm/panel: Silence no spi_device_id warnings

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree. Commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible") added a test to check that every SPI driver has a spi_device_id for each DT compatiable stri

[PATCH v2 02/10] drm/panel: panel-ilitek-ili9322: Silence no spi_device_id warnings

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver panel-ilitek-i

[PATCH v2 07/10] drm/panel: s6e63m0: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver panel-samsung-s

[PATCH v2 05/10] drm/panel: nv3052c: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver nv30

[PATCH v2 03/10] drm/panel: innolux-ej030na: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver panel-innolux-e

[PATCH v2 01/10] drm/panel: db7430: Silence no spi_device_id warning

2022-09-22 Thread Wei Yongjun
From: Wei Yongjun SPI devices use the spi_device_id for module autoloading even on systems using device tree, after commit 5fa6863ba692 ("spi: Check we have a spi_device_id for each DT compatible"), kernel warns as follows since the spi_device_id is missing: SPI driver db7430-pa

Re: [PATCH] gpu: dc: fix enum conversion in display_mode_vba

2022-09-18 Thread Wei Yongjun
On 2022/9/19 9:41, Zeng Heng wrote: > Fix below compile warning when open enum-conversion > option check (compiled with -Wenum-conversion): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn20/display_mode_vba_20.c: > In function ‘dml20_ModeSupportAndSystemConfigurationFull’: > drivers/gpu/dr

Re: [PATCH] gpu: color: eliminate implicit conversion about enum type

2022-09-18 Thread Wei Yongjun
gpu: color: fix enum-conversion compile warning 标题我记得不跟你所过让你改的 On 2022/9/19 9:44, Zeng Heng wrote: > Fix below compile warning when open enum-conversion > option check: > > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: > In function ‘apply_degamma_for_user_regamma’: > drive

[PATCH] drm/panel: y030xx067a: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver abt-y030xx067a has no spi_device_id for abt,y030xx067a Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-abt-y030xx067a.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu

[PATCH] drm/panel: panel-ilitek-ili9322: Silent no spi_device_id warnings

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warnings: SPI driver panel-ilitek-ili9322 has no spi_device_id for dlink,dir-685-panel SPI driver panel-ilitek-ili9322 has no spi_device_id for ilitek,ili9322 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-ilitek

[PATCH] drm/panel: novatek,nt39016: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver nt39016 has no spi_device_id for kingdisplay,kd035g6-54nt Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-novatek-nt39016.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers

[PATCH] drm/panel: nv3052c: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver nv3052c has no spi_device_id for leadtek,ltk035c5444t Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu

[PATCH] drm/panel: innolux-ej030na: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver panel-innolux-ej030na has no spi_device_id for innolux,ej030na Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-innolux-ej030na.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a

[PATCH] drm/panel: ws2401: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver ws2401-panel has no spi_device_id for samsung,lms380kf01 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-widechips-ws2401.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers

[PATCH] drm/panel: s6e63m0: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver panel-samsung-s6e63m0 has no spi_device_id for samsung,s6e63m0 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-samsung-s6e63m0-spi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a

[PATCH] drm/panel: s6d27a1: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver s6d27a1-panel has no spi_device_id for samsung,s6d27a1 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-samsung-s6d27a1.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu

[PATCH] drm/panel: tpg110: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver tpo-tpg110-panel has no spi_device_id for tpo,tpg110 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-tpo-tpg110.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm

[PATCH] drm/panel: db7430: Silent no spi_device_id warning

2022-09-15 Thread Wei Yongjun
From: Wei Yongjun Add spi_device_id entries to silent following SPI warning: SPI driver db7430-panel has no spi_device_id for samsung,lms397kf04 Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-samsung-db7430.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu

[PATCH -next] drm/exynos: g2d: fix missing unlock on error in g2d_runqueue_worker()

2021-06-15 Thread Wei Yongjun
Add the missing unlock before return from function g2d_runqueue_worker() in the error handling case. Fixes: 445d3bed75de ("drm/exynos: use pm_runtime_resume_and_get()") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++- 1 file

[PATCH -next] drm/panfrost: Fix missing clk_disable_unprepare() on error in panfrost_clk_init()

2021-06-08 Thread Wei Yongjun
Fix the missing clk_disable_unprepare() before return from panfrost_clk_init() in the error handling case. Fixes: b681af0bc1cc ("drm: panfrost: add optional bus_clock") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panfrost/panfrost_device.c | 3 ++- 1 file

[PATCH -next] drm/amdgpu: fix error return code in amdgpu_acpi_init()

2021-05-24 Thread Wei Yongjun
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 77bf762f8b30 ("drm/amdgpu/acpi: unify ATCS handling (v3)") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 5 +++

[PATCH -next] media: staging: tegra-vde: Fix error return code in tegra_vde_probe()

2021-05-24 Thread Wei Yongjun
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: dc8276b78917 ("staging: media: tegra-vde: use pm_runtime_resume_and_get()") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/staging/media/tegra

[PATCH -next] drm/amdgpu: fix unused-but-set-variable warnings

2021-05-20 Thread Wei Yongjun
83 | struct amdgpu_ring *ring; | ^~~~ Those variables are not really used, so remove them to fix the warnings. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 2 -- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 2 -- drivers/gpu/drm/amd/amdgpu/vcn_v3_0

[PATCH -next] drm/amd/display: Fix unused variable warning

2021-02-24 Thread Wei Yongjun
le only used when CONFIG_DRM_AMD_DC_DCN is set, this commit fix the warning. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH -next] drm/rockchip: cdn-dp: Mark cdn_dp_resume as __maybe_unused

2021-02-09 Thread Wei Yongjun
ume(struct device *dev) |^ Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-co

[PATCH -next] habanalabs: remove unused but set variable 'ctx_asid'

2020-07-30 Thread Wei Yongjun
it to fix the warning. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- .../misc/habanalabs/common/command_submission.c| 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/habanalabs/common/command_submission.c b/drivers/misc/habanalabs/common/command_su

[PATCH -next] drm: xlnx: Fix typo in parameter description

2020-07-26 Thread Wei Yongjun
Fix typo in parameter description. Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH -next] dma-fence: Make symbol 'dma_fence_lockdep_map' static

2020-07-23 Thread Wei Yongjun
dep annotations") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/dma-buf/dma-fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index af1d8ea926b3..43624b4ee13d 100644 --- a/drivers/dma-b

[PATCH -next] drm/nouveau/kms/nvd9-: Fix file release memory leak

2020-07-22 Thread Wei Yongjun
When using single_open() for opening, single_release() should be used instead of seq_release(), otherwise there is a memory leak. Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/nouveau/dispnv50

[PATCH -next] backlight: cr_bllcd: Remove unused variable 'intensity'

2020-07-22 Thread Wei Yongjun
uce gpio-backlight semantics"), this variable is never used, this commit removing it. Fixes: 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight semantics") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/video/backlight/cr_bllcd.c | 1 - 1 file changed, 1 deleti

[PATCH net-next] ksz884x: mark pcidev_suspend() as __maybe_unused

2020-07-03 Thread Wei Yongjun
ice *dev_d) |^~ Mark pcidev_suspend() as __maybe_unused to make it clear. Fixes: 64120615d140 ("ksz884x: use generic power management") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/net/ethernet/micrel/ksz884x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister()

2020-06-18 Thread Wei Yongjun
It's not necessary to unregister backlight device which registered with devm_backlight_device_register(). Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.

[PATCH -next] drm/vboxvideo: Fix a NULL vs IS_ERR() check in vbox_hw_init()

2020-05-01 Thread Wei Yongjun
The devm_gen_pool_create() function returns ERR_PTR() on error, it doesn't return NULL so this check doesn't work. Fixes: 4cc9b565454b ("drm/vboxvideo: Use devm_gen_pool_create") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++-- 1 file changed

[PATCH -next v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind()

2020-05-01 Thread Wei Yongjun
The of_drm_find_bridge() function returns NULL on error, it doesn't return error pointers so this check doesn't work. Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") Signed-off-by: Wei Yongjun --- v1 - > v2: add fixes and fix the subject --- drivers/

[PATCH -next] drm/mcde: dsi: Fix return value check in dev_err()

2020-04-28 Thread Wei Yongjun
In case of error, the function of_drm_find_bridge() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/mcde/mcde_dsi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions

[PATCH -next] drm/rcar-du: Fix return value check in rcar_du_cmm_init()

2020-04-28 Thread Wei Yongjun
In case of error, the function of_parse_phandle()/of_find_device_by_node() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test Fixes: 8de707aeb452 ("drm: rcar-du: kms: Initialize CMM instances") Signed-off-by: Wei Yongjun --

[PATCH net-next] net: lpc-enet: fix error return code in lpc_mii_init()

2020-04-28 Thread Wei Yongjun
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: b7370112f519 ("lpc32xx: Added ethernet driver") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/nxp/lpc_eth.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH net-next] ath11k: use GFP_ATOMIC under spin lock

2020-04-28 Thread Wei Yongjun
A spin lock is taken here so we should use GFP_ATOMIC. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Signed-off-by: Wei Yongjun --- drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wi

[PATCH net-next] dpaa2-eth: fix error return code in setup_dpni()

2020-04-28 Thread Wei Yongjun
Fix to return negative error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet

[PATCH -next v2] drm/mgag200: Fix typo in module parameter description

2020-01-12 Thread Wei Yongjun
There was a typo in the MODULE_PARM_DESC(). It said that the module parameter was "modeset" but it's actually the description for "hw_bug_no_startadd". Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0") Signed-off-by:

[PATCH -next] drm/mgag200: Fix typo in parameter description

2020-01-12 Thread Wei Yongjun
Fix typo in parameter description. Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH] drm/nouveau: add missing single_release()

2019-09-04 Thread Wei Yongjun
When using single_open() for opening, single_release() should be used, otherwise there is a memory leak. This is detected by Coccinelle semantic patch. Fixes: 6e9fc177399f ("drm/nouveau/debugfs: add copy of sysfs pstate interface ported to debugfs") Signed-off-by: Wei Yongjun --- d

[PATCH -next] drm/etnaviv: fix missing unlock on error in etnaviv_iommuv1_context_alloc()

2019-08-18 Thread Wei Yongjun
Add the missing unlock before return from function etnaviv_iommuv1_context_alloc() in the error handling case. Fixes: 27b67278e007 ("drm/etnaviv: rework MMU handling") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/etnaviv/etnaviv_iommu.c | 4 +++- 1 file changed, 3 insertions(+),

[PATCH -next] drm/panfrost: Fix missing unlock on error in panfrost_mmu_map_fault_addr()

2019-08-13 Thread Wei Yongjun
Add the missing unlock before return from function panfrost_mmu_map_fault_addr() in the error handling case. Fixes: 187d2929206e ("drm/panfrost: Add support for GPU heap allocations") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panfrost/panfrost_mmu.c | 5 - 1 file changed, 4

[PATCH -next] drm/vgem: Fix wrong pointer passed to PTR_ERR()

2019-08-01 Thread Wei Yongjun
PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned. Fixes: 7e9e5ead55be ("drm/vgem: fix cache synchronization on arm/arm64") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/vgem/vgem_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH -next] video: fbdev: imxfb: fix a typo in imxfb_probe()

2019-07-05 Thread Wei Yongjun
Fix the return value check which testing the wrong variable in imxfb_probe(). Fixes: 739a6439c2bf ("video: fbdev: imxfb: fix sparse warnings about using incorrect types") Signed-off-by: Wei Yongjun --- drivers/video/fbdev/imxfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH -next] drm/i915: fix possible memory leak in intel_hdcp_auth_downstream()

2019-07-04 Thread Wei Yongjun
'ksv_fifo' is malloced in intel_hdcp_auth_downstream() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/display/intel_hdcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

[PATCH -next] drm/amdgpu: Fix return value check in amdgpu_allocate_static_csa()

2018-12-04 Thread Wei Yongjun
Fix the return value check which testing the wrong variable in amdgpu_allocate_static_csa(). Fixes: 7946340fa389 ("drm/amdgpu: Move csa related code to separate file") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH -next] drm/fb-helper: Fix typo in parameter description

2018-12-04 Thread Wei Yongjun
Fix typo in parameter description. Fixes: 4be9bd10e22d ("drm/fb_helper: Allow leaking fbdev smem_start") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/drm_fb_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drive

[PATCH -next] drm/vkms: Fix possible memory leak in _vkms_get_crc()

2018-09-17 Thread Wei Yongjun
'vaddr_out' is malloced in _vkms_get_crc() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: db7f419c06d7 ("drm/vkms: Compute CRC with Cursor Plane") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/vkms/vkms_crc.c |

[PATCH -next] drm/vkms: Fix the error handling in vkms_init()

2018-08-03 Thread Wei Yongjun
In the drm_vblank_init() error handling case, platform device unregister is missing. This patch fix it. Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH -next] drm/sun4i: DW HDMI: Make symbol sun8i_dw_hdmi_pltfm_driver static

2018-07-12 Thread Wei Yongjun
Fixes the following sparse warning: drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:228:24: warning: symbol 'sun8i_dw_hdmi_pltfm_driver' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH -next] drm/tegra: dc: Using NULL instead of plain integer

2018-03-30 Thread Wei Yongjun
Fixes the following sparse warnings: drivers/gpu/drm/tegra/dc.c:2181:69: warning: Using plain integer as NULL pointer Signed-off-by: Wei Yongjun --- drivers/gpu/drm/tegra/dc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm

[PATCH -next] drm/amdgpu: fix error return code in amdgpu_amdkfd_gpuvm_create_process_vm()

2018-03-30 Thread Wei Yongjun
Fix to return error code -ENOMEM from the eviction fence create fail error handling case instead of 0, as done elsewhere in this function. Fixes: a46a2cd103a8 ("drm/amdgpu: Add GPUVM memory management functions for KFD") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/

[PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static

2018-03-30 Thread Wei Yongjun
Fixes the following sparse warning: drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1150:6: warning: symbol 'kfd_dev_is_large_bar' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH -next] drm/amdkfd: Fix the error return code in kfd_ioctl_unmap_memory_from_gpu()

2018-03-30 Thread Wei Yongjun
Passing NULL pointer to PTR_ERR will result in return value of 0 indicating success which is clearly not what it is intended here. This patch returns -EINVAL instead. Fixes: 5ec7e02854b3 ("drm/amdkfd: Add ioctls for GPUVM memory management") Signed-off-by: Wei Yongjun --- drivers/g

[PATCH -next] drm/meson: Fix potential NULL dereference in meson_drv_bind_master()

2018-03-22 Thread Wei Yongjun
(pdev, t, n); + if (!res) + return -EINVAL; ... when != res == NULL e = devm_ioremap(e1, res->start, e2); Signed-off-by: Wei Yongjun --- drivers/gpu/drm/meson/meson_drv.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/mes

[PATCH -next] drm/etnaviv: make local symbols static

2018-01-12 Thread Wei Yongjun
Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/etnaviv/etnaviv_iommu.c | 2 +- drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c | 2 +- 2 file changed, 2 insertion(+), 2 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_iommu.c b/drivers/gpu/drm/etnaviv/etnaviv_iommu.c index 7a8

[PATCH -next] drm/panel: ili9322:Make local symbols static

2018-01-03 Thread Wei Yongjun
Should it be static? Also change ili9322_inputs to 'const char * const' to avoid chackpatch warning. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9

[PATCH] drm/shmob: Fix return value check in shmob_drm_probe()

2017-10-12 Thread Wei Yongjun
In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] drm/msm: fix return value check in _msm_gem_kernel_new()

2017-10-12 Thread Wei Yongjun
In case of error, the function msm_gem_get_vaddr() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 8223286d62e2 ("drm/msm: Add a helper function for in-kernel buffer allocations") Signed-off-by: Wei Yongjun --

[PATCH] drm: Fix return value check in kirin_drm_platform_probe()

2017-10-12 Thread Wei Yongjun
In case of error, the function of_graph_get_remote_node() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test.. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 ++-- 1 file changed, 2 insertions

[PATCH -next] drm/vgem: Fix return value check in vgem_init()

2017-05-21 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 315f0242aa2b ("drm/vgem: Convert to a struct drm_device subclass") Signed-o

[PATCH -next] drm/pl111: Fix return value check in pl111_amba_probe()

2017-05-21 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") Signed-off-by: W

[PATCH -next] drm/i915: Fix return value check in kfence selftests

2017-05-18 Thread Wei Yongjun
From: Wei Yongjun Fix the return value check which testing the wrong variable. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/selftests/i915_sw_fence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_sw_fence.c b/drivers/gpu

[PATCH -next] drm/nouveau/secboot/gm20b: fix the error return code in gm20b_secboot_tegra_read_wpr()

2017-04-25 Thread Wei Yongjun
From: Wei Yongjun The error return code PTR_ERR(mc) is always 0 since mc is equal to 0 in this error handling case. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau

[PATCH -next] drm/rockchip: cdn-dp: fix return value check in cdn_dp_probe()

2017-04-24 Thread Wei Yongjun
From: Wei Yongjun Fix the retrn value check which testing the wrong variable in cdn_dp_probe(). Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH -next] drm/shmob: fix return value check in shmob_drm_probe()

2017-04-24 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- 1 file changed, 2

[PATCH -next] gpu: host1x: Fix wrong pointer passed to PTR_ERR()

2017-04-16 Thread Wei Yongjun
From: Wei Yongjun PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned. Fixes: b386c6b73ac6 ("gpu: host1x: Support module reset") Signed-off-by: Wei Yongjun --- drivers/gpu/host1x/dev.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] drm/etnaviv: fix missing unlock on error in etnaviv_gpu_submit()

2017-04-11 Thread Wei Yongjun
From: Wei Yongjun Add the missing unlock before return from function etnaviv_gpu_submit() in the error handling case. Fixes: f3cd1b064f11 ("drm/etnaviv: (re-)protect fence allocation with GPU mutex") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 3 ++- 1 fi

[PATCH -next] drm/bridge/tfp410: Make symbol tfp410_platform_driver static

2017-02-09 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/bridge/ti-tfp410.c:223:24: warning: symbol 'tfp410_platform_driver' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- 1 file changed, 1 inser

[PATCH -next] drm/msm/dsi: fix error return code in msm_dsi_host_init()

2017-02-09 Thread Wei Yongjun
From: Wei Yongjun Fix to return error code -ENOMEM from the malloc error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/msm/dsi/dsi_host.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b

[PATCH -next] drm: mxsfb: fix error return code in mxsfb_load()

2017-02-05 Thread Wei Yongjun
From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b

[PATCH -next] drm: mxsfb: Make local symbol mxsfb_funcs static

2017-02-05 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/mxsfb/mxsfb_drv.c:129:38: warning: symbol 'mxsfb_funcs' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH -next] drm/atomic: make release_crtc_commit() static

2017-01-12 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/drm_atomic_helper.c:1360:6: warning: symbol 'release_crtc_commit' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/drm_atomic_helper.c | 2 +- 1 file changed, 1 inser

[PATCH -next] drm/hisilicon/hibmc: Fix wrong pointer passed to PTR_ERR()

2017-01-12 Thread Wei Yongjun
From: Wei Yongjun PTR_ERR should access the value just tested by IS_ERR, otherwise the wrong error code will be returned. Fixes: d1667b86795a ("drm/hisilicon/hibmc: Add support for frame buffer") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2

[PATCH -next] dma-buf/sw_sync: fix non static symbol warning

2016-10-29 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/dma-buf/sw_sync.c:87:22: warning: symbol 'sync_timeline_create' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/dma-buf/sw_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH -next] drm/i915/gvt: fix return value check

2016-10-19 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function i915_gem_object_create() returns ERR_PTR() not NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 8 1 file changed, 4 insertions(+), 4

[PATCH -next] gpu: ipu-v3: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

2016-09-21 Thread Wei Yongjun
From: Wei Yongjun Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). Generated by: scripts/coccinelle/api/err_cast.cocci Signed-off-by: Wei Yongjun --- drivers/gpu/ipu-v3/ipu-image-convert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/ipu-v3

[PATCH] drm/omap: fix return value check in dsi_bind()

2016-09-17 Thread Wei Yongjun
From: Wei Yongjun Fix the retrn value check which testing the wrong variable in dsi_bind(). Signed-off-by: Wei Yongjun --- drivers/gpu/drm/omapdrm/dss/dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss

[PATCH -next] drm/i915: Fix non static symbol warning

2016-09-17 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/i915/intel_dp.c:1527:5: warning: symbol 'intel_dp_compute_bpp' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/intel_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH -next] drm/sun4i: backend: remove redundant dev_err call in sun4i_backend_bind()

2016-09-15 Thread Wei Yongjun
From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/sun4i/sun4i_backend.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu

[PATCH -next] drm/mediatek: Remove redundant dev_err call in mtk_drm_probe()

2016-09-10 Thread Wei Yongjun
From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a

[PATCH -next] drm/tilcdc: Fix non static symbol warning

2016-09-10 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning: symbol 'tilcdc_atomic_check' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- 1 file changed, 2 insert

[PATCH -next] drm/sun4i: Remove redundant dev_err call in sun4i_tcon_init_regmap()

2016-08-26 Thread Wei Yongjun
From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu

[PATCH -next] drm/i915: Fix non static symbol warning

2016-08-21 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/i915/intel_hotplug.c:480:6: warning: symbol 'i915_hpd_poll_init_work' was not declared. Should it be static? Also move the '{' to new line. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/intel_

[PATCH -next] drm/mgag200: fix error return code in mgag200fb_create()

2016-08-15 Thread Wei Yongjun
Fix to return error code -ENOMEM from the vmalloc() error handling case instead of 0, as done elsewhere in this function. Fixes: aec9e12953e7 ("drm/mgag200: Fix error handling paths in fbdev driver") Signed-off-by: Wei Yongjun --- drivers/gpu/drm/mgag200/mgag200_fb.c | 4 +++- 1 file

[PATCH -next] drm/tegra: dpaux: Fix return value check in tegra_dpaux_probe()

2016-07-30 Thread Wei Yongjun
In case of error, the function devm_pinctrl_register() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/gpu/drm/tegra/dpaux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation

2016-07-28 Thread Wei Yongjun
Use kmemdup rather than duplicating its implementation. Generated by: scripts/coccinelle/api/memdup.cocci Signed-off-by: Wei Yongjun --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b

[PATCH -next] drm/arm: mali-dp: Fix error return code in malidp_bind()

2016-07-28 Thread Wei Yongjun
Fix to return error code -EINVAL from the error handling case instead of 0, as done elsewhere in this function. Fixes: 3c31760e760c ('drm/arm: mali-dp: Set crtc.port to the port instead of the endpoint') Signed-off-by: Wei Yongjun --- drivers/gpu/drm/arm/malidp_drv.c | 4 +++- 1 file

[PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind()

2016-07-28 Thread Wei Yongjun
There is a error message within devm_ioremap_resource already, so remove the DRM_ERROR call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/arm/malidp_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_drv.c b

[PATCH -next] drm/fsl-dcu: use PTR_ERR_OR_ZERO() to simplify the code

2016-07-25 Thread Wei Yongjun
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Wei Yongjun --- drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c b/drivers

[PATCH -next] drm/virtio: Fix non static symbol warning

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/virtio/virtgpu_display.c:349:37: warning: symbol 'virtio_mode_config_helpers' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file

[PATCH -next] drm/vgem: Fix non static symbol warning

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/gpu/drm/vgem/vgem_fence.c:75:24: warning: symbol 'vgem_fence_ops' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/gpu/drm/vgem/vgem_fence.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH -next] drm/amdgpu: fix return value check in amdgpu_ttm_debugfs_init()

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function debugfs_create_file() returns NULL pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test in the return value check should be replaced with NULL test. (defined(CONFIG_DEBUG_FS) make sure debugfs is enabled) Signed-off-by: Wei Yongjun

  1   2   >