Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id)

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-25 Thread Wolfram Sang
..@alsa-project.org > Cc: linux-...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: net...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring I trust you guys in figuring out the details, so fo

Re: [PATCH 09/20] Documentation: i2c: eliminate duplicated word

2020-07-22 Thread Wolfram Sang
On Tue, Jul 07, 2020 at 11:04:03AM -0700, Randy Dunlap wrote: > Drop doubled word "new". > > Signed-off-by: Randy Dunlap For the record: Acked-by: Wolfram Sang signature.asc Description: PGP signature ___ dri-devel mai

Re: [PATCH 09/20] Documentation: i2c: eliminate duplicated word

2020-07-21 Thread Wolfram Sang
On Tue, Jul 07, 2020 at 11:04:03AM -0700, Randy Dunlap wrote: > Drop doubled word "new". > > Signed-off-by: Randy Dunlap > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > Cc: Wolfram Sang > Cc: linux-...@vger.kernel.org Reviewed-by: Wolfram Sang

Re: [PATCH] Remove handhelds.org links and email addresses

2020-06-30 Thread Wolfram Sang
Hi Alexander, thanks for trying to fix this, yet I have some doubts. On Mon, Jun 29, 2020 at 10:31:21PM +0200, Alexander A. Klimov wrote: > Rationale: > https://lore.kernel.org/linux-doc/20200626110706.7b5d4...@lwn.net/ I think we need some text here. Clicking on a link to understand what a

Re: [PATCH 0/6] remove deprecated i2c_new_device API

2020-06-22 Thread Wolfram Sang
On Mon, Jun 15, 2020 at 09:58:09AM +0200, Wolfram Sang wrote: > I want to remove the above API this cycle, and just a few patches have > not made it into 5.8-rc1. They have been reviewed and most had been > promised to get into linux-next, but well, things happen. So, I hope it

[PATCH 1/6] drm: encoder_slave: fix refcouting error for modules

2020-06-16 Thread Wolfram Sang
module_put() balances try_module_get(), not request_module(). Fix the error path to match that. Fixes: 2066facca4c7 ("drm/kms: slave encoder interface.") Signed-off-by: Wolfram Sang Reviewed-by: Emil Velikov --- I'd like to push it via I2C for 5.8-rc2. drivers/gpu/drm/drm_encoder_s

[PATCH 4/6] video: backlight: tosa_lcd: convert to use i2c_new_client_device()

2020-06-16 Thread Wolfram Sang
Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang Reviewed-by: Daniel Thompson --- I'd like to push it via I2C for 5.8-rc2. drivers/video/backlight/tosa_lcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 0/6] remove deprecated i2c_new_device API

2020-06-16 Thread Wolfram Sang
minor exception is the media documentation patch which I simply have missed so far, but it is trivial. And then, finally, there is the removal of the old API as the final patch. Phew, that's been a long ride. I am open for comments, of course. Happy hacking, Wolfram Wolfram Sang (6): drm

[PATCH 2/6] drm: encoder_slave: use new I2C API

2020-06-16 Thread Wolfram Sang
we use this condensed error check. Signed-off-by: Wolfram Sang Reviewed-by: Emil Velikov --- I'd like to push it via I2C for 5.8-rc2. drivers/gpu/drm/drm_encoder_slave.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_encoder_slave.c b

[PATCH] drm/vblank: remove outdated and noisy output

2020-05-15 Thread Wolfram Sang
, the vblank init message is displayed again when the DU driver is retried. Because the message doesn't really carry a useful information, I suggest to simply drop it. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/drm_vblank.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH 0/2] drm: encoder_slave: some updates

2020-05-13 Thread Wolfram Sang
On Mon, Mar 16, 2020 at 05:39:05PM +0100, Wolfram Sang wrote: > While converting I2C users to new APIs, I found a refcounting problem in > the encoder_slave implementation. This series fixes it and converts to > the new API. > > Based on linux-next and only build tested. >

Re: [PATCH 1/1] video: backlight: tosa_lcd: convert to use i2c_new_client_device()

2020-05-13 Thread Wolfram Sang
On Fri, Apr 17, 2020 at 11:14:46AM +0100, Lee Jones wrote: > On Thu, 26 Mar 2020, Wolfram Sang wrote: > > > Move away from the deprecated API and return the shiny new ERRPTR where > > useful. > > > > Signed-off-by: Wolfram Sang > > --- > > drivers/

Re: [PATCH v2 01/91] i2c: brcmstb: Allow to compile it on BCM2835

2020-04-26 Thread Wolfram Sang
On Fri, Apr 24, 2020 at 05:33:42PM +0200, Maxime Ripard wrote: > The BCM2711, supported by ARCH_BCM2835, also has a controller by the > brcmstb driver so let's allow it to be compiled on that platform. > > Cc: Kamal Dasu > Cc: Wolfram Sang > Cc: bcm-kernel-feedback-l...@broadc

Re: [PATCH v2 01/91] i2c: brcmstb: Allow to compile it on BCM2835

2020-04-24 Thread Wolfram Sang
On Fri, Apr 24, 2020 at 10:07:25AM -0700, Florian Fainelli wrote: > > > On 4/24/2020 9:13 AM, Wolfram Sang wrote: > > > >> config I2C_BRCMSTB > >>tristate "BRCM Settop/DSL I2C controller" > >> - depends on ARCH_BRCMSTB || BMIPS_GENERIC |

Re: [PATCH v2 01/91] i2c: brcmstb: Allow to compile it on BCM2835

2020-04-24 Thread Wolfram Sang
> config I2C_BRCMSTB > tristate "BRCM Settop/DSL I2C controller" > - depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \ > -COMPILE_TEST > + depends on ARCH_BCM2835 || ARCH_BRCMSTB || BMIPS_GENERIC || \ > +ARCH_BCM_63XX || COMPILE_TEST

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-20 Thread Wolfram Sang
everyone copies the simpler syntax. > > Signed-off-by: Rob Herring Same preamble for my ack as in patch 1: Acked-by: Wolfram Sang signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-20 Thread Wolfram Sang
pts which do transforms on the schema files. > > Signed-off-by: Rob Herring I see that people had comments but I can't judge the topics raised. So, I trust you guys that you find out when it is good to go and for that, here is my ack: Acked-by: Wolfram Sang signature.asc Descript

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

2020-04-16 Thread Wolfram Sang
everyone copies the simpler syntax. > > Signed-off-by: Rob Herring Acked-by: Wolfram Sang # for I2C signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

2020-04-16 Thread Wolfram Sang
pts which do transforms on the schema files. > > Signed-off-by: Rob Herring Acked-by: Wolfram Sang # for I2C signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/ma

Re: [PATCH 6/6] drm/radeon: convert to use i2c_new_client_device()

2020-03-27 Thread Wolfram Sang
> > > > Move away from the deprecated API. > > > > > > > > Signed-off-by: Wolfram Sang > > > > > > patches 1,6, are: > > > Acked-by: Alex Deucher > > Should we commit all to drm-misc-next? > > I'm fine to see it go thro

[PATCH 0/6] gpu: convert to use new I2C API

2020-03-26 Thread Wolfram Sang
We are deprecating calls which return NULL in favor of new variants which return an ERR_PTR. Only build tested. Wolfram Sang (6): drm/amdgpu: convert to use i2c_new_client_device() drm/gma500: convert to use i2c_new_client_device() drm/i2c/sil164: convert to use i2c_new_client_device

[PATCH 6/6] drm/radeon: convert to use i2c_new_client_device()

2020-03-26 Thread Wolfram Sang
Move away from the deprecated API. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/radeon/radeon_atombios.c | 4 ++-- drivers/gpu/drm/radeon/radeon_combios.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm

[PATCH 5/6] drm/nouveau/therm: convert to use i2c_new_client_device()

2020-03-26 Thread Wolfram Sang
Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c b/drivers/gpu

[PATCH 3/6] drm/i2c/sil164: convert to use i2c_new_client_device()

2020-03-26 Thread Wolfram Sang
Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/i2c/sil164_drv.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c index

[PATCH 1/6] drm/amdgpu: convert to use i2c_new_client_device()

2020-03-26 Thread Wolfram Sang
Move away from the deprecated API. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c index ba1bb95a3cf9..0e8018c9aa8e

[PATCH 0/1] video: convert to use new I2C API

2020-03-26 Thread Wolfram Sang
We are deprecating calls which return NULL in favor of new variants which return an ERR_PTR. Only build tested. Wolfram Sang (1): video: backlight: tosa_lcd: convert to use i2c_new_client_device() drivers/video/backlight/tosa_lcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 4/6] drm/i2c/tda998x: convert to use i2c_new_client_device()

2020-03-26 Thread Wolfram Sang
Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/i2c/tda998x_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c

[PATCH 2/6] drm/gma500: convert to use i2c_new_client_device()

2020-03-26 Thread Wolfram Sang
Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c b/drivers/gpu/drm

[PATCH 1/1] video: backlight: tosa_lcd: convert to use i2c_new_client_device()

2020-03-26 Thread Wolfram Sang
Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang --- drivers/video/backlight/tosa_lcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/tosa_lcd.c b/drivers/video/backlight/tosa_lcd.c

[PATCH 1/2] drm: encoder_slave: fix refcouting error for modules

2020-03-17 Thread Wolfram Sang
module_put() balances try_module_get(), not request_module(). Fix the error path to match that. Fixes: 2066facca4c7 ("drm/kms: slave encoder interface.") Signed-off-by: Wolfram Sang --- drivers/gpu/drm/drm_encoder_slave.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH 0/2] drm: encoder_slave: some updates

2020-03-17 Thread Wolfram Sang
While converting I2C users to new APIs, I found a refcounting problem in the encoder_slave implementation. This series fixes it and converts to the new API. Based on linux-next and only build tested. Wolfram Sang (2): drm: encoder_slave: fix refcouting error for modules drm: encoder_slave

[PATCH 2/2] drm: encoder_slave: use new I2C API

2020-03-17 Thread Wolfram Sang
we use this condensed error check. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/drm_encoder_slave.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_encoder_slave.c b/drivers/gpu/drm/drm_encoder_slave.c index d50a7884e69e..e464429d32df 100644

Re: [PATCH 04/89] i2c: brcmstb: Allow to compile it on BCM2835

2020-03-10 Thread Wolfram Sang
> config I2C_BRCMSTB > tristate "BRCM Settop/DSL I2C controller" > depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \ > -COMPILE_TEST > +COMPILE_TEST || ARCH_BCM2835 Can you please sort if for easier maintenance? signature.asc

Re: [PATCH 03/89] i2c: brcmstb: Support BCM2711 HDMI BSC controllers

2020-03-10 Thread Wolfram Sang
lso tie the AUTO_I2C registers with a > separate compatible so that we can enable AUTO_I2C if needed in the > future. > > The AUTO_I2C is enabled by default at boot though, so we first need to > release the BSC from the AUTO_I2C control. > > Cc: Kamal Dasu > Cc: Florian Fai

Re: [PATCH 01/89] dt-bindings: i2c: brcmstb: Convert the BRCMSTB binding to a schema

2020-03-10 Thread Wolfram Sang
On Mon, Feb 24, 2020 at 10:06:03AM +0100, Maxime Ripard wrote: > Switch the DT binding to a YAML schema to enable the DT validation. > > Cc: Kamal Dasu > Cc: Florian Fainelli > Cc: Rob Herring > Cc: Wolfram Sang > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: linux-

Re: [PATCH 02/89] dt-bindings: i2c: brcmstb: Add BCM2711 BSC/AUTO-I2C binding

2020-03-10 Thread Wolfram Sang
device with two register range, > which will allow us to use or or the other in the driver without > changing anything in the DT. > > Cc: Kamal Dasu > Cc: Florian Fainelli > Cc: Rob Herring > Cc: Wolfram Sang > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: linux-...@

Re: [PATCH 01/89] dt-bindings: i2c: brcmstb: Convert the BRCMSTB binding to a schema

2020-03-10 Thread Wolfram Sang
On Mon, Feb 24, 2020 at 10:06:03AM +0100, Maxime Ripard wrote: > Switch the DT binding to a YAML schema to enable the DT validation. > > Cc: Kamal Dasu > Cc: Florian Fainelli > Cc: Rob Herring > Cc: Wolfram Sang > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: linux-

Re: i2c: jz4780: silence log flood on txabrt

2020-02-13 Thread Wolfram Sang
On Wed, Feb 12, 2020 at 10:46:28AM +0100, Wolfram Sang wrote: > > The printout for txabrt is way too talkative. Reduce it to the minimum, > the rest can be gained by I2C core debugging and datasheet information. > Also, make it a debug printout, it won't help the regular user. > &

Re: i2c: jz4780: silence log flood on txabrt

2020-02-12 Thread Wolfram Sang
Hi, > > Sorry, normally I don't do counter patches. Yet, this time I realized > > that it would be faster to actually do what I envisioned than to > > describe it in words. I hope you don't feel offended. > > No problem. I had thought a little about that myself, but did not > dare to solve more

i2c: jz4780: silence log flood on txabrt

2020-02-12 Thread Wolfram Sang
The printout for txabrt is way too talkative. Reduce it to the minimum, the rest can be gained by I2C core debugging and datasheet information. Also, make it a debug printout, it won't help the regular user. Reported-by: H. Nikolaus Schaller Signed-off-by: Wolfram Sang --- Sorry, normally I

Re: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device

2019-11-28 Thread Wolfram Sang
On Thu, Nov 07, 2019 at 09:33:54AM +0100, Daniel Vetter wrote: > On Wed, Nov 06, 2019 at 10:50:23AM +0100, Wolfram Sang wrote: > > Move from the deprecated i2c_new_probed_device() to the new > > i2c_new_scanned_device(). Make use of the new ERRPTR if suitable. > > > >

Re: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device

2019-11-28 Thread Wolfram Sang
On Wed, Nov 06, 2019 at 10:50:23AM +0100, Wolfram Sang wrote: > Move from the deprecated i2c_new_probed_device() to the new > i2c_new_scanned_device(). Make use of the new ERRPTR if suitable. > > Signed-off-by: Wolfram Sang Applied to for-next, thanks! signature.asc Desc

[RFC PATCH 00/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant

2019-11-06 Thread Wolfram Sang
From: Wolfram Sang In the on-going mission to let i2c_new_* calls return an ERR_PTR instead of NULL, here is a series converting i2c_new_probed_device(). A new function called i2c_new_scanned_device() is introduced with the new retval, but for now, a compatibility helper is provided until all

[RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device

2019-11-06 Thread Wolfram Sang
Move from the deprecated i2c_new_probed_device() to the new i2c_new_scanned_device(). Make use of the new ERRPTR if suitable. Signed-off-by: Wolfram Sang --- Build tested only. RFC, please comment and/or ack, but don't apply yet. drivers/video/fbdev/matrox/i2c-matroxfb.c | 4 ++-- 1 file

[PATCH RESEND] gpu: drm: bridge: sii9234: convert to devm_i2c_new_dummy_device

2019-10-08 Thread Wolfram Sang
Move from the deprecated i2c_new_dummy() to devm_i2c_new_dummy_device(). We now get an ERRPTR which we use in error handling and we can skip removal of the created devices. Signed-off-by: Wolfram Sang --- Rebased to v5.4-rc2 since last time. One of the last two users of the old API, so please

[PATCH RESEND] gpu: drm: bridge: analogix-anx78xx: convert to i2c_new_dummy_device

2019-10-08 Thread Wolfram Sang
Move from the deprecated i2c_new_dummy() to i2c_new_dummy_device(). We now get an ERRPTR which we use in error handling. Signed-off-by: Wolfram Sang --- Rebased to v5.4-rc2 since last time. One of the last two users of the old API, so please apply soon, so I can remove the old interface. Only

Re: [BACKPORT 4.14.y 00/18] Backport candidate from TI 4.14 product kernel

2019-09-05 Thread Wolfram Sang
On Thu, Sep 05, 2019 at 10:17:41AM -0600, Mathieu Poirier wrote: > These patches are backport candidates picked out of TI's 4.14.y tree [1], > with most of them already found in the 4.19.y stable tree. Could you please update your scripting that only the cover-letter and I2C related patches will

[PATCH] video: backlight: tosa_lcd: drop check because i2c_unregister_device() is NULL safe

2019-08-21 Thread Wolfram Sang
No need to check the argument of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/video/backlight/tosa_lcd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

Re: [PATCH v2] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-08-14 Thread Wolfram Sang
On Fri, Aug 09, 2019 at 05:40:47PM +0200, Wolfram Sang wrote: > In the general move to have i2c_new_*_device functions which return > ERR_PTR instead of NULL, this patch converts i2c_new_secondary_device(). > > There are only few users, so this patch converts the I2C core and all &g

Re: [PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-08-09 Thread Wolfram Sang
Hi Laurent, > > > > + if (IS_ERR(state->i2c_clients[i])) { > > > > + err = PTR_ERR(state->i2c_clients[i]); > > > > v4l2_err(sd, "failed to create i2c client > > > > %u\n", i); > > > > goto err_i2c; > > This will

[PATCH v2] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-08-09 Thread Wolfram Sang
-of-tree users will get a build failure to understand they need to adapt their error checking code. Signed-off-by: Wolfram Sang Reviewed-by: Kieran Bingham # adv748x Reviewed-by: Laurent Pinchart # adv7511 --- Changes since v1: * adv7604: use a local variable for error handling * adv7604: simplify

Re: [PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-08-08 Thread Wolfram Sang
On Tue, Jul 23, 2019 at 04:47:09PM +0100, Kieran Bingham wrote: > Hi Wolfram, > > On 22/07/2019 18:26, Wolfram Sang wrote: > > In the general move to have i2c_new_*_device functions which return > > ERR_PTR instead of NULL, this patch converts i2c_new_secondary_device(). &g

Re: [PATCH v3 2/7] drivers: Introduce device lookup variants by of_node

2019-07-25 Thread Wolfram Sang
Rob Herring > Cc: Srinivas Kandagatla > Cc: Takashi Iwai > Cc: Wolfram Sang > Cc: Alan Tull > Cc: Moritz Fischer > Cc: linux-f...@vger.kernel.org > Cc: Peter Rosin > Cc: Mark Brown > Cc: Florian Fainelli > Cc: Heiner Kallweit > Cc: "David S. Miller&

[PATCH 0/1] gpu: convert subsystem to i2c_new_dummy_device()

2019-07-23 Thread Wolfram Sang
performed. The branch is based on v5.3-rc1. A branch (with some more stuff included) can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/i2c/new_dummy Some drivers still need to be manually converted. Patches for those will be sent out individually. Wolfram Sang (1

[PATCH 1/1] gpu: drm: bridge: analogix-anx78xx: convert to i2c_new_dummy_device

2019-07-22 Thread Wolfram Sang
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an ERRPTR which we use in error handling. Signed-off-by: Wolfram Sang --- Generated with coccinelle. Build tested by me and buildbot. Not tested on HW. drivers/gpu/drm/bridge/analogix-anx78xx.c | 6 +++--- 1 file changed, 3

[PATCH] gpu: drm: bridge: sii9234: convert to devm_i2c_new_dummy_device

2019-07-22 Thread Wolfram Sang
Move from i2c_new_dummy() to devm_i2c_new_dummy_device(). So, we now get an ERRPTR which we use in error handling and we can skip removal of the created devices. Signed-off-by: Wolfram Sang --- Only build tested. Part of a tree-wide move to deprecate i2c_new_dummy(). drivers/gpu/drm/bridge

[PATCH] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-07-22 Thread Wolfram Sang
-of-tree users will get a build failure to understand they need to adapt their error checking code. Signed-off-by: Wolfram Sang --- Kindly asking for acks/revs/tests from people knowing the modified drivers. drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 18 +- drivers/i2c/i2c-core

Re: [PATCH 03/14] docs: fix broken doc references due to renames

2019-07-22 Thread Wolfram Sang
On Tue, Jul 16, 2019 at 09:10:42AM -0300, Mauro Carvalho Chehab wrote: > Some files got renamed but probably due to some merge conflicts, > a few references still point to the old locations. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Wolfram Sang # I2C part signature.asc

[RFC/RFT PATCH RESEND] i2c: replace i2c_new_secondary_device with an ERR_PTR variant

2019-06-20 Thread Wolfram Sang
-of-tree users will get a build failure to understand they need to adapt their error checking code. Signed-off-by: Wolfram Sang --- Sorry for the resend. I missed to add quite some relevant ppl to cc. This patch is RFC for now because: * there is one FIXME blob which I can only remove after a missing

Re: [PATCH] docs: fix some broken references due to txt->rst renames

2019-06-18 Thread Wolfram Sang
On Tue, Jun 18, 2019 at 10:33:58AM -0300, Mauro Carvalho Chehab wrote: > There are three left-overs from the recent file renames, > probably due to some other conflicting patch. > > Fix them. > > Signed-off-by: Mauro Carvalho Chehab Thanks! Acked-by: Wolfram Sang signatu

Re: [PATCH v2 06/28] drivers: Add generic helper to match by of_node

2019-06-17 Thread Wolfram Sang
> > Is it an option to 'static inline' this simple function in the header, > > saving the EXPORT? > > > > No. OK, thanks for the explanation! signature.asc Description: PGP signature

Re: [PATCH v2 17/28] drivers: Introduce bus_find_device_by_of_node() helper

2019-06-14 Thread Wolfram Sang
: linux-rockc...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: Mathieu Poirier > Cc: Rob Herring > Cc: Srinivas Kandagatla > Cc: Takashi Iwai > Cc: Wolfram Sang > Cc: Greg Kroah-Hartman > Cc: "Rafael J. Wysocki" > Signed-off-by: Suzuki K Poulose Ac

Re: [PATCH v2 06/28] drivers: Add generic helper to match by of_node

2019-06-14 Thread Wolfram Sang
> + > +int device_match_of_node(struct device *dev, const void *np) > +{ > + return dev->of_node == np; > +} > +EXPORT_SYMBOL_GPL(device_match_of_node); Is it an option to 'static inline' this simple function in the header, saving the EXPORT? signature.asc Description: PGP signature

Re: [PATCH 00/34] treewide: simplify getting the adapter of an I2C client

2019-06-10 Thread Wolfram Sang
Hi Peter, > Similar things go on in: > > drivers/hwmon/lm90.c > drivers/leds/leds-is31fl319x.c > drivers/of/unittest.c Right. I'll fix them, too. > And drivers/rtc/rtc-fm3130.c has a couple of these: These are fixed in patch 26 of this series. Thanks and happy hacking, Wolfram

[PATCH 02/34] gpu: drm: bridge: sii9234: simplify getting the adapter of a client

2019-06-09 Thread Wolfram Sang
We have a dedicated pointer for that, so use it. Much easier to read and less computation involved. Signed-off-by: Wolfram Sang --- Please apply to your subsystem tree. drivers/gpu/drm/bridge/sii9234.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 00/34] treewide: simplify getting the adapter of an I2C client

2019-06-08 Thread Wolfram Sang
nch can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/no_to_adapter Please apply the patches to the individual subsystem trees. There are no dependencies. Thanks and kind regards, Wolfram Wolfram Sang (34): clk: clk-cdce706: simplify getting the adapter o

Re: KASAN: use-after-free Read in add_uevent_var

2019-05-06 Thread Wolfram Sang
> > The bug was bisected to: > > > > commit 0a1c7959acd9674a0e4e59f911f3e5fbf25fd693 > > Author: Wolfram Sang > > Date: Wed May 17 15:22:18 2017 + > > > > gpu: drm: tc35876x: move header file out of I2C realm > > Bisect seems to hav

Re: [PATCH 1/2] drm/msm: simplify getting .driver_data

2019-03-22 Thread Wolfram Sang
> > - struct platform_device *pdev = to_platform_device(dev); > > - struct msm_gpu *gpu = platform_get_drvdata(pdev); > > + struct msm_gpu *gpu = dev_get_drvdata(dev); > > Nice simplification :-) > > Do you catch these with Coccinelle? Yes, the previous series had the script in the cover

[PATCH 1/2] drm/msm: simplify getting .driver_data

2019-03-19 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/msm/adreno/adreno_device.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

[PATCH 2/2] drm/omap: simplify getting .driver_data

2019-03-19 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 18 ++ 1 file changed, 6 insertions

Re: [PATCH v2] i2c: of: Try to find an I2C adapter matching the parent

2019-02-08 Thread Wolfram Sang
> So I guess you could say we're in some in-between state, but I don't > think it's inconsistent. It just allows us to do this step by step, > which I think is good. Well, I am still not super happy, but it fixes a regression, so I will keep it in for-next. signature.asc Description: PGP

Re: [PATCH v2] i2c: of: Try to find an I2C adapter matching the parent

2019-02-06 Thread Wolfram Sang
> And there is a regression! Good that I didn't push out before > double-checking. No one noticed that this breaks registering child > devices because of_i2c_register_devices() doesn't have a pointer to work > with anymore? Well, sorry, I forgot an important detail. There is no regression

Re: [PATCH v2] i2c: of: Try to find an I2C adapter matching the parent

2019-02-06 Thread Wolfram Sang
On Tue, Feb 05, 2019 at 01:44:44PM +0100, Wolfram Sang wrote: > On Fri, Jan 25, 2019 at 02:11:42PM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > If an I2C adapter doesn't match the provided device tree node, also try > > matching the parent's device tre

Re: [PATCH v2] i2c: of: Try to find an I2C adapter matching the parent

2019-02-05 Thread Wolfram Sang
On Fri, Jan 25, 2019 at 02:11:42PM +0100, Thierry Reding wrote: > From: Thierry Reding > > If an I2C adapter doesn't match the provided device tree node, also try > matching the parent's device tree node. This allows finding an adapter > based on the device node of the parent device that was

Re: [PATCH] i2c: of: Try to find an I2C adapter matching the parent

2018-12-11 Thread Wolfram Sang
Any update on this patch? I thought it was interesting. BTW adding Rob (finally) to CC... On Mon, Oct 01, 2018 at 01:02:30AM +0200, Wolfram Sang wrote: > On Tue, Sep 25, 2018 at 06:06:11PM +0200, Thierry Reding wrote: > > From: Thierry Reding > > > > If an I2C

[PATCH 1/6] gpu: drm: msm: adreno: adreno_device: simplify getting .driver_data

2018-10-22 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/msm/adreno/adreno_device.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH 0/6] gpu: simplify getting .driver_data

2018-10-22 Thread Wolfram Sang
data(pdev) + dev_get_drvdata(d) <... when != pdev - >dev + d ...> Kind regards, Wolfram Wolfram Sang (6): gpu: drm: msm: adreno: adreno_device: simplify getting .driver_data gpu: drm: msm: disp: dpu1: dpu_kms: simplify getting .driver_data g

[PATCH 3/6] gpu: drm: msm: disp: mdp5: mdp5_kms: simplify getting .driver_data

2018-10-22 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH 5/6] gpu: drm: msm: msm_drv: simplify getting .driver_data

2018-10-22 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/msm/msm_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 2/6] gpu: drm: msm: disp: dpu1: dpu_kms: simplify getting .driver_data

2018-10-22 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions

[PATCH 6/6] gpu: drm: omapdrm: displays: panel-dsi-cm: simplify getting .driver_data

2018-10-22 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. .../gpu/drm/omapdrm/displays/panel-dsi-cm.c| 18 ++ 1 file changed, 6 insertions

[PATCH 4/6] gpu: drm: msm: dsi: dsi_host: simplify getting .driver_data

2018-10-22 Thread Wolfram Sang
We should get 'driver_data' from 'struct device' directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang --- Build tested only. buildbot is happy. drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff

Re: [PATCH] i2c: of: Try to find an I2C adapter matching the parent

2018-09-30 Thread Wolfram Sang
On Tue, Sep 25, 2018 at 06:06:11PM +0200, Thierry Reding wrote: > From: Thierry Reding > > If an I2C adapter doesn't match the provided device tree node, also try > matching the parent's device tree node. This allows finding an adapter > based on the device node of the parent device that was

Re: [PATCH 2/2] i2c: algos: bit: mention our experience about initial states

2018-06-25 Thread Wolfram Sang
On Sat, Jun 16, 2018 at 10:37:57PM +0900, Wolfram Sang wrote: > So, if somebody wants to re-implement this in the future, we pinpoint to > a problem case. > > Signed-off-by: Wolfram Sang Applied to for-current, thanks! ___ dri-devel mail

Re: [PATCH 1/2] Revert "i2c: algo-bit: init the bus to a known state"

2018-06-25 Thread Wolfram Sang
On Sat, Jun 16, 2018 at 10:37:56PM +0900, Wolfram Sang wrote: > This reverts commit 3e5f06bed72fe72166a6778f630241a893f67799. As per > bugzilla #200045, this caused a regression. I don't really see a way to > fix it without having the hardware. So, revert the patch and I will fix >

[PATCH 1/2] Revert "i2c: algo-bit: init the bus to a known state"

2018-06-17 Thread Wolfram Sang
users of this algorithm since, so there should be no one depending on the new behaviour. Reported-by: Sergey Larin Fixes: 3e5f06bed72f ("i2c: algo-bit: init the bus to a known state") Signed-off-by: Wolfram Sang --- drivers/i2c/algos/i2c-algo-bit.c | 5 - 1 file changed, 5 deletion

[PATCH 0/2] i2c: algos: bit: revert to fix regression (#200045)

2018-06-17 Thread Wolfram Sang
A regression was reported via Bugzilla and a revert seems to be the best choice for now. Check patch 1 for details. To not make the same mistake again, patch 2 adds a comment sharing our experience. Wolfram Sang (2): Revert "i2c: algo-bit: init the bus to a known state" i2c:

[PATCH 2/2] i2c: algos: bit: mention our experience about initial states

2018-06-17 Thread Wolfram Sang
So, if somebody wants to re-implement this in the future, we pinpoint to a problem case. Signed-off-by: Wolfram Sang --- drivers/i2c/algos/i2c-algo-bit.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c index

[RFT] i2c: algos: bit: prepare/unprepare before sending initial STOP

2018-06-15 Thread Wolfram Sang
Some adapters need to be prepared/unprepared before bitbanging the bus. Do this for the initial STOP, too. Signed-off-by: Wolfram Sang --- Ok, another idea to fix the regression. I'm not 100% sure if the placement is perfect, but it should serve well enough as a proof of concept to see

[PATCH 1/1] drm/msm/hdmi: don't check number of messages in the driver

2018-05-20 Thread Wolfram Sang
Since commit 1eace8344c02 ("i2c: add param sanity check to i2c_transfer()"), the I2C core does this check now. We can remove it from drivers. Signed-off-by: Wolfram Sang <w...@the-dreams.de> --- Only build tested. drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 3 --- 1 file chan

[PATCH 14/61] gpu: drm: msm: dsi: simplify getting .drvdata

2018-04-20 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++-

[PATCH 11/61] gpu: drm: msm: simplify getting .drvdata

2018-04-20 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/gpu/drm/msm/msm_drv.c | 3 +--

[PATCH 57/61] video: fbdev: simplify getting .drvdata

2018-04-20 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/video/fbdev/auo_k190x.c

[PATCH 13/61] gpu: drm: msm: disp: mdp5: simplify getting .drvdata

2018-04-20 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/gpu/drm/msm/disp/mdp5/mdp5_kms

[PATCH 15/61] gpu: drm: omapdrm: displays: simplify getting .drvdata

2018-04-20 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/gpu/drm/omapdrm/displays/panel-ds

[PATCH 00/61] tree-wide: simplify getting .drvdata

2018-04-20 Thread Wolfram Sang
t_drvdata(pdev) + dev_get_drvdata(d) <... when != pdev - >dev + d ...> Kind regards, Wolfram Wolfram Sang (61): ARM: plat-samsung: simplify getting .drvdata ata: simplify getting .drvdata auxdisplay: simplify getting .drvdata bus: simplif

[PATCH 58/61] video: fbdev: omap2: omapfb: displays: simplify getting .drvdata

2018-04-20 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. .../video/fbdev/omap2/omapfb/displays/pan

[PATCH 12/61] gpu: drm: msm: adreno: simplify getting .drvdata

2018-04-20 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/gpu/drm/msm/adreno/adreno_device

[PATCH 16/61] gpu: drm: vc4: simplify getting .drvdata

2018-04-20 Thread Wolfram Sang
We should get drvdata from struct device directly. Going via platform_device is an unneeded step back and forth. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Build tested only. buildbot is happy. Please apply individually. drivers/gpu/drm/vc4/vc4_drv.c | 3 +--

  1   2   3   >