Re: [PATCH] drm/qxl: prevent memory leak

2023-11-07 Thread Zongmin Zhou
Thanks for your reply. Best regards! On 2023/11/6 17:49, Maxime Ripard wrote: Hi, On Wed, Nov 01, 2023 at 12:58:17PM +1000, Dave Airlie wrote: On Wed, 22 Mar 2023 at 19:04, Zongmin Zhou wrote: The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_obj

Re: [RESEND PATCH] drm/qxl: prevent memory leak

2023-09-12 Thread zongmin zhou
On Tue, 2023-08-01 at 10:53 +0800, Zongmin Zhou wrote: > The allocated memory for qdev->dumb_heads should be released > in qxl_destroy_monitors_object before qxl suspend. > otherwise,qxl_create_monitors_object will be called to > reallocate memory for qdev->dumb_head

[RESEND PATCH] drm/qxl: prevent memory leak

2023-07-31 Thread Zongmin Zhou
The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object before qxl suspend. otherwise,qxl_create_monitors_object will be called to reallocate memory for qdev->dumb_heads after qxl resume, it will cause memory leak. Signed-off-by: Zongmin Zhou --- drive

Re: [PATCH] drm/probe_helper: fix the warning reported when calling drm_kms_helper_poll_disable during suspend

2023-04-27 Thread zongmin zhou
On Wed, 2023-04-26 at 16:10 +0300, Dmitry Baryshkov wrote: > On Wed, 26 Apr 2023 at 12:09, zongmin zhou > wrote: > > > > On Sun, 2023-04-23 at 22:51 +0200, Janne Grunau wrote: > > > On 2023-04-20 23:07:01 +0300, Dmitry Baryshkov wrote: > > > > On

Re: [PATCH] drm/probe_helper: fix the warning reported when calling drm_kms_helper_poll_disable during suspend

2023-04-26 Thread zongmin zhou
On Sun, 2023-04-23 at 22:51 +0200, Janne Grunau wrote: > On 2023-04-20 23:07:01 +0300, Dmitry Baryshkov wrote: > > On Thu, 20 Apr 2023 at 23:01, Janne Grunau wrote: > > > > > > On 2023-03-28 10:31:29 +0800, Zongmin Zhou wrote: > > > > When driver

[RESEND PATCH] drm/qxl: prevent memory leak

2023-04-24 Thread Zongmin Zhou
The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object before qxl suspend. otherwise,qxl_create_monitors_object will be called to reallocate memory for qdev->dumb_heads after qxl resume, it will cause memory leak. Signed-off-by: Zongmin Zhou --- drive

Re: [PATCH] drm/probe_helper: fix the warning reported when calling drm_kms_helper_poll_disable during suspend

2023-04-20 Thread zongmin zhou
On Thu, 2023-04-20 at 23:07 +0300, Dmitry Baryshkov wrote: > On Thu, 20 Apr 2023 at 23:01, Janne Grunau wrote: > > > > On 2023-03-28 10:31:29 +0800, Zongmin Zhou wrote: > > > When drivers call drm_kms_helper_poll_disable from > > > their device suspend impl

[PATCH] drm/probe_helper: fix the warning reported when calling drm_kms_helper_poll_disable during suspend

2023-03-27 Thread Zongmin Zhou
55.141575] [ 55.141575] ---[ end trace ]--- Fixes: a4e771729a51 ("drm/probe_helper: sort out poll_running vs poll_enabled") Signed-off-by: Zongmin Zhou --- drivers/gpu/drm/drm_probe_helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/dr

[PATCH] drm/qxl: prevent memory leak

2023-03-22 Thread Zongmin Zhou
The allocated memory for qdev->dumb_heads should be released in qxl_destroy_monitors_object before qxl suspend. otherwise,qxl_create_monitors_object will be called to reallocate memory for qdev->dumb_heads after qxl resume, it will cause memory leak. Signed-off-by: Zongmin Zhou --- drive

[RESEND PATCH] drm/qxl: drop set_prod_notify parameter from qxl_ring_create

2022-09-20 Thread Zongmin Zhou
Since qxl_io_reset(qdev) will be called immediately after qxl_ring_create() been called, and parameter like notify_on_prod will be set to default value. So the call to qxl_ring_init_hdr() before becomes meaningless. Signed-off-by: Zongmin Zhou Suggested-by: Ming Xie --- drivers/gpu/drm/qxl

[PATCH] drm/qxl: drop set_prod_notify parameter from qxl_ring_create

2022-09-08 Thread Zongmin Zhou
Since qxl_io_reset(qdev) will be called immediately after qxl_ring_create() been called, and parameter like notify_on_prod will be set to default value. So the call to qxl_ring_init_hdr() before becomes meaningless. Signed-off-by: Zongmin Zhou Suggested-by: Ming Xie --- drivers/gpu/drm/qxl

[PATCH] drm/qxl: fix the suspend/resume issue on qxl device

2022-09-07 Thread Zongmin Zhou
From: Zongmin Zhou Details: Currently, when trying to suspend and resume with qxl device, there are some error messages after resuming, eventually caused to black screen and can't be recovered. The first error message: [ 64.668577][C3] [drm] driver is in bug mode This error

[PATCH] drm/amdgpu: fixup bad vram size on gmc v8

2021-12-15 Thread Zongmin Zhou
-by: Zongmin Zhou --- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c index 492ebed2915b..63b890f1e8af 100644 --- a/drivers/gpu/drm/amd/amdgpu