Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()

2024-04-11 Thread jyri . sarha
April 10, 2024 at 8:04 PM, "Ville Syrjälä" mailto:ville.syrj...@linux.intel.com?to=%22Ville%20Syrj%C3%A4l%C3%A4%22%20%3Cville.syrjala%40linux.intel.com%3E > wrote: > > What if someone tries to actually boot a kernel built > with COMPILE_TEST=y on a machine with this hardware? > I doubt there

Re: [PATCH] drm/tilcdc: request and mapp iomem with devres

2023-12-28 Thread jyri . sarha
ctions provide a handy > way to both request and ioremap the memory with automatic cleanup. > > Replace the manual ioremap with the devm_ version. > > Suggested-by: Thomas Zimmermann > Signed-off-by: Philipp Stanner Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha I'll apply this

Re: [PATCH v3 16/16] drm/tilcdc: Convert to platform remove callback returning void

2023-11-28 Thread jyri . sarha
Beaglebone-Black,and tested that everything still works, so: Tested-by: Jyri Sarha I'll apply this shortly to drm-misc-next. Best regards, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/

Re: [PATCH 47/53] drm/tilcdc: Convert to platform remove callback returning void

2023-05-08 Thread jyri . sarha
e converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Jyri Sarha > --- > drivers/gpu/drm/tilcd

Re: [PATCH 1/4] drm/plane: Remove drm_plane_init()

2022-09-13 Thread jyri . sarha
wrapper around a call > to drm_universal_plane_init(), so drivers can just use that instead. > > Signed-off-by: Thomas Zimmermann Acked-by: Jyri Sarha > --- > drivers/gpu/drm/drm_modeset_helper.c | 3 +- > drivers/gpu/drm/drm_plane.c | 32 -- > driv

Re: [PATCH] drm/tilcdc: fix typos in comment

2022-04-25 Thread Jyri Sarha
On 2022-04-22 14:09, brookxu.cn wrote: From: Chunguang Xu Fix typos in comment. Signed-off-by: Chunguang Xu Pushed to drm-misc-next. Thanks, Jyri --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] tilcdc: tilcdc_external: fix an incorrect NULL check on list iterator

2022-03-27 Thread Jyri Sarha
: Xiaomeng Tong Thanks for the patch. Good catch. Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha I'll apply this to drm-misc-next in couple of days. Best regards, Jyri --- drivers/gpu/drm/tilcdc/tilcdc_external.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/d

Re: [PATCH v2 36/37] drm/tilcdc: Add support for the nomodeset kernel parameter

2021-12-17 Thread Jyri Sarha
will be available if it was set-up. But only a few DRM drivers currently check for nomodeset, make this driver to also support the command line parameter. Signed-off-by: Javier Martinez Canillas Acked-by: Jyri Sarha --- (no changes since v1) drivers/gpu/drm/tilcdc/tilcdc_drv.c | 3 +++ 1

Re: [PATCH v3] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Jyri Sarha
On 2021-12-16 11:55, Xiang wangx wrote: struct of_device_id should normally be const. Signed-off-by: Xiang wangx Reviewed-by: Jyri Sarha Thanks, Jyri --- Changes since v1 * add const in line 63 Changes since v2 * removed line 63 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +--- 1 file

Re: [PATCH v2] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Jyri Sarha
On 2021-12-16 11:44, Joe Perches wrote: On Thu, 2021-12-16 at 17:26 +0800, Xiang wangx wrote: struct of_device_id should normally be const. [] diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c [] @@ -60,7 +60,7 @@ void tilcdc_module_cleanup(struct

Re: [PATCH] drm/tilcdc: add const to of_device_id

2021-12-16 Thread Jyri Sarha
Please fix the bellow error and I will review and merge this. But in future, please at least compile test you changes with relevant configurations or alldefconfig before sending them to upstream! Best regards, Jyri On 2021-12-15 22:35, kernel test robot wrote: Hi Xiang, Thank you for the

Re: [PATCH v3 24/34] drm/tilcdc: Migrate to aggregate driver

2021-11-01 Thread Jyri Sarha
On 2021-10-26 3:00, Stephen Boyd wrote: Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Jyri Sarha Cc: Tomi Valkeinen Cc: Daniel Vetter

Re: [PATCH] drm: Remove redundant 'flush_workqueue()' calls

2021-10-12 Thread Jyri Sarha
); destroy_workqueue(E); Signed-off-by: Christophe JAILLET For tilcdc Acked-by: Jyri Sarha Thanks, Jyri --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 - drivers/gpu/drm/msm/dsi/dsi_host.c| 1 - drivers/gpu/drm/msm/edp/edp_ctrl.c| 1 - drivers/gpu/drm/msm/hdmi/hdmi.c | 4

Re: [PATCH] drm/bridge: Centralize error message when bridge attach fails

2021-04-15 Thread Jyri Sarha
Reviewed-by: Jyri Sarha ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 0/3] drm/tilcdc: fix LCD pixel clock setting

2021-03-23 Thread Jyri Sarha
Thanks, Reviewed-by: Jyri Sarha for the series. I'll merge these later today. Best regards, Jyri On 2021-03-22 23:33, Dario Binacchi wrote: The series was born from a patch to fix the LCD pixel clock setting. Two additional patches have been added to this. One renames a misleading variable

Re: [PATCH] drm/tilcdc: panel: fix platform_no_drv_owner.cocci warnings

2021-03-21 Thread Jyri Sarha
On 2021-03-03 11:04, Yang Li wrote: ./drivers/gpu/drm/tilcdc/tilcdc_panel.c:402:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Jyri Sarha I'll merge

Re: [PATCH v2 0/3] drm/tilcdc: fix LCD pixel clock setting

2021-03-21 Thread Jyri Sarha
, I think this looks good now. Reviewed-by: Jyri Sarha For the series. I'll wait a day or two if Tomi has something more to say and merge this to drm-misc-next. Best regards, Jyri Changes in v2: - The patch has been added in version 2. - Rename clk_div_rate to real_pclk_rate. - Provide pixel

Re: [PATCH] drm/tilcdc: fix LCD pixel clock setting

2021-03-19 Thread Jyri Sarha
On 2021-03-18 23:47, Dario Binacchi wrote: Il 17/03/2021 09:19 Tomi Valkeinen ha scritto: On 14/03/2021 17:13, Dario Binacchi wrote: > As reported by TI spruh73x RM, the LCD pixel clock (LCD_PCLK) frequency > is obtained by dividing LCD_CLK, the LCD controller reference clock, > for CLKDIV: >

Re: [RESEND PATCH] drm/tilcdc: fix raster control register setting

2021-02-18 Thread Jyri Sarha
On 2021-02-16 22:22, Dario Binacchi wrote: The fdd property of the tilcdc_panel_info structure must set the reqdly bit field (bit 12 to 19) of the raster control register. The previous statement set the least significant bit instead. Signed-off-by: Dario Binacchi Reviewed-by: Jyri Sarha

Re: [PATCH] drm/tilcdc: replace spin_lock_irqsave by spin_lock in hard IRQ

2021-02-18 Thread Jyri Sarha
On 2021-02-08 4:32, Tian Tao wrote: The code has been in a irq-disabled context since it is hard IRQ. There is no necessity to do it again. Signed-off-by: Tian Tao Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha I merge to this drm-misc-next soon. Best regards, Jyri --- drivers/gpu/drm

Re: [RESEND][PATCH] drm/tilcdc: send vblank event when disabling crtc

2021-02-09 Thread Jyri Sarha
commit") Signed-off-by: Quanyang Wang Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha Thanks a lot! I think I have bumbed into this once or twice, but latelu I have had time to look into this. I'll merge this to drm-misc-next soon. Best regards, Jyri --- drivers/gpu/drm/tilcdc/tilcdc_crtc

Re: [PATCH] drm/tilcdc: send vblank event when disabling crtc

2021-02-09 Thread Jyri Sarha
On 2021-02-09 5:09, quanyang.wang wrote: Ping. Could you resend the original patch (I have not received it) so I can easily test and merge it? I'll find some time to do it soon. Best regards, Jyri On 1/29/21 3:58 PM, Tomi Valkeinen wrote: Dropped the @ti.com addresses and added the new

Re: [PATCH] MAINTAINERS: Update addresses for TI display drivers

2020-12-16 Thread Jyri Sarha
On 2020-12-16 9:59, Tomi Valkeinen wrote: Update the maintainer email addresses for TI display drivers. Signed-off-by: Tomi Valkeinen Acked-by: Jyri Sarha --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure

2020-10-27 Thread Jyri Sarha
ddress the warning. > > Signed-off-by: Arnd Bergmann Reviewed-by: Jyri Sarha Please let me know if you want me to merge this. Best regards, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gp

[PATCH v3 0/2] drm/tilcdc: Couple of minor feature improvements

2020-10-10 Thread Jyri Sarha
Put TILCDC_DEFAULT_MAX_WIDTH_V1 before *_V2 and The vblank interrupts have been always on when the display is on for a very long time, so I decided that it is about time to fix it. Then the following patch is just a cleanup. BR, Jyri Jyri Sarha (2): drm/tilcdc: Do not keep vblank interrupt

[PATCH v3 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-10-10 Thread Jyri Sarha
is initialized, if "max-width" property is not found. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 +--- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 38 +++- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 7 ++--

[PATCH v3 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time

2020-10-10 Thread Jyri Sarha
END_OF_FRAME interrupts have been enabled all the time since the beginning of this driver. It is about time to add this feature. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 36 +--- 1

[PATCH] ARM: davinci_all_defconfig: Add CONFIG_DRM_DISPLAY_CONNECTOR=m

2020-10-10 Thread Jyri Sarha
Current dumb-vga-dac driver requires CONFIG_DRM_DISPLAY_CONNECTOR for it to work. Signed-off-by: Jyri Sarha --- An alternative would be selecting CONFIG_DRM_DISPLAY_CONNECTOR from all bridges requiring DRM connector. arch/arm/configs/davinci_all_defconfig | 1 + 1 file changed, 1 insertion

[PATCH v2 0/2] drm/tilcdc: Couple of minor feature improvements

2020-09-20 Thread Jyri Sarha
on when the display is on for a very long time, so I decided that it is about time to fix it. Then the following patch is just a cleanup. BR, Jyri Jyri Sarha (2): drm/tilcdc: Do not keep vblank interrupts enabled all the time drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data dr

[PATCH v2 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-09-20 Thread Jyri Sarha
is initialized, if "max-width" property is not found. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 +--- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 38 +++- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 7 ++--- 3 files changed, 26 inserti

[PATCH v2 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time

2020-09-20 Thread Jyri Sarha
END_OF_FRAME interrupts have been enabled all the time since the beginning of this driver. It is about time to add this feature. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 36 +--- 1

[PATCH 0/2] drm/tilcdc: Couple of minor feature improvements

2020-09-14 Thread Jyri Sarha
The vblank interrupts have been always on when the display is on for a very long time, so I decided that it is about time to fix it. Then the following patch is just a cleanup. BR, Jyri Jyri Sarha (2): drm/tilcdc: Do not keep vblank interrupts enabled all the time drm/tilcdc: Remove

[PATCH 2/2] drm/tilcdc: Remove tilcdc_crtc_max_width(), use private data

2020-09-14 Thread Jyri Sarha
We already have a private data member for maximum display width so let's use it and get rid of the redundant tilcdc_crtc_max_width(). Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 16 +--- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 38

[PATCH 1/2] drm/tilcdc: Do not keep vblank interrupts enabled all the time

2020-09-14 Thread Jyri Sarha
END_OF_FRAME interrupts have been enabled all the time since the beginning of this driver. It is about time to add this feature. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] drm/tidss: implement WA for AM65xx erratum i2000

2020-08-12 Thread Jyri Sarha
ly used on SR1.0 (which is > the new name for PG1). The previous WA code didn't check the SoC > revision, which this patch does. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 32 + > drivers/g

Re: [PATCH] drm/tidss: Replace HTTP links with HTTPS ones

2020-07-14 Thread Jyri Sarha
; > If you apply the patch, please let me know. > > Sorry again to all maintainers who complained about subject lines. > Now I realized that you want an actually perfect prefixes, > not just subsystem ones. > I tried my best... > And yes, *I could* (at least half

Re: [PATCH] drm/tilcdc: Use standard drm_atomic_helper_commit

2020-07-10 Thread Jyri Sarha
ay helpers would work out really > nice. > Probably. Should take a closer looks some day when I have time. > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Tested-by: Jyri Sarha Reviewed-by: Jyri Sarha > -- > From logs looks like we're not stuck

Re: [PATCH] drm/tilcdc: Use standard drm_atomic_helper_commit

2020-07-08 Thread Jyri Sarha
oes not finish and nothing comes visible on the screen until couple of "flip_done timed outs". A new kernel log is attached. Best regards, Jyri > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen > -- > I'm not really sure whether the event handling

Re: [PATCH 15/25] drm/tilcdc: Use standard drm_atomic_helper_commit

2020-07-08 Thread Jyri Sarha
ng also seems to exist (albeit with much hand-rolling and > probably some races, could perhaps be converted over to > drm_crtc_arm_vblank_event without any real loss). > > Motivated by me not having to hand-roll the dma-fence annotations for > this. > > Signed-off-by: Daniel

Re: [PATCH 14/25] drm/tidss: Annotate dma-fence critical section in commit path

2020-07-08 Thread Jyri Sarha
On 07/07/2020 23:12, Daniel Vetter wrote: > Ends right after hw_done(), totally standard case. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_kms.c | 4 > 1 file changed, 4 inser

Re: [PATCH v1 1/7] drm/tidss: drop use of legacy drm_bus_flags

2020-06-30 Thread Jyri Sarha
On 30/06/2020 21:05, Sam Ravnborg wrote: > Use the more descriptive _DRIVE_ variants thus avoiding the > legacy drm_bus_flags values. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Jyri Sarha > ---

Re: [PATCH v3 37/43] drm/tilcdc: Use GEM CMA object functions

2020-06-24 Thread Jyri Sarha
Thomas Zimmermann > Acked-by: Emil Velikov Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > b/drivers/gpu/drm

Re: [PATCH v3 38/43] drm/tilcdc: Set GEM CMA functions with DRM_GEM_CMA_DRIVER_OPS

2020-06-24 Thread Jyri Sarha
On 05/06/2020 10:32, Thomas Zimmermann wrote: > DRM_GEM_CMA_DRIVER_OPS sets the functions in struct drm_driver > to their defaults. No functional changes are made. > > Signed-off-by: Thomas Zimmermann > Acked-by: Emil Velikov Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha &

Re: [PATCH] drm/tidss: fix modeset init for DPI panels

2020-06-04 Thread Jyri Sarha
ff-by: Tomi Valkeinen > Fixes: 32a1795f57eecc39749017 ("drm/tidss: New driver for TI Keystone > platform Display SubSystem") > Cc: sta...@vger.kernel.org # v5.7+ Reviewed-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_kms.c | 2 +- > 1 file changed, 1 insertion(+)

Re: [PATCH 2/3] drm/tilcdc: remove unnecessary state->fb check

2020-05-19 Thread Jyri Sarha
On 29/04/2020 13:42, Tomi Valkeinen wrote: > tilcdc_plane_atomic_check() exits if state->fb == NULL, so no need to > check it again later. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_plane.c | 3 +-- > 1 file ch

Re: [PATCH 3/3] drm/tilcdc: add missing static for panel_driver

2020-05-19 Thread Jyri Sarha
On 29/04/2020 13:42, Tomi Valkeinen wrote: > struct platform_driver panel_driver is only used from tilcdc_panel.c, so > it can be static. > > Signed-off-by: Tomi Valkeinen Reviewed-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +- > 1 file chang

Re: [PATCH 1/3] drm/tilcdc: fix leak & null ref in panel_connector_get_modes

2020-05-19 Thread Jyri Sarha
; > Signed-off-by: Tomi Valkeinen Reviewed-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > b/drivers/gpu/drm/tilcdc/tilcdc_pane

Re: [PATCH] drm/tidss: remove AM65x PG1 YUV erratum code

2020-05-04 Thread Jyri Sarha
formats on PG1, getting wrong > colors on the screen. On the other hand, that may also be a plus, as the > same applications will now work on PG1 and PG2, even if the colors are > wrong on PG1. > > Signed-off-by: Tomi Valkeinen One minor nitpick bellow, but otherwise: Reviewed-by

Re: [PATCH 27/44] drm/tidss: Use devm_drm_dev_alloc

2020-04-14 Thread Jyri Sarha
On 03/04/2020 16:58, Daniel Vetter wrote: > Already using devm_drm_dev_init, so very simple replacment. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Tested-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_drv.c | 15 ---

Re: [PATCH 29/44] drm/tidss: Delete tidss->saved_state

2020-04-14 Thread Jyri Sarha
On 03/04/2020 16:58, Daniel Vetter wrote: > Not used anymore since the switch to suspend/resume helpers. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Tested-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_drv.h | 2 -- > 1 file changed,

Re: [PATCH 28/44] drm/tidss: Don't use drm_device->dev_private

2020-04-14 Thread Jyri Sarha
On 03/04/2020 16:58, Daniel Vetter wrote: > Upcasting using a container_of macro is more typesafe, faster and > easier for the compiler to optimize. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Tested-by: Jyri Sarha > --- > drivers/gpu/drm/

Re: [PATCH 07/10] drm/tilcdc: Set up fbdev after fully registering device

2020-04-07 Thread Jyri Sarha
On 06/04/2020 16:44, Thomas Zimmermann wrote: > Generic fbdev support is a DRM client. Set it up after fully registering > the new DRM device. > > Signed-off-by: Thomas Zimmermann Acked-by: Jyri Sarha However, this change hardly makes any difference, as the only place where &quo

Re: [PATCH 10/12] docs: dt: display/ti: fix typos at the devicetree/ directory name

2020-03-17 Thread Jyri Sarha
On 17/03/2020 15:10, Mauro Carvalho Chehab wrote: > The name of the devicetree directory is wrong on those three > TI bindings: > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Jyri Sarha > --- > Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml | 2 +

Re: [PATCH v2] dt-bindings: display: ti: Fix dtc unit-address warnings in examples

2020-03-14 Thread Jyri Sarha
/example-0/dss@04a0: unit name should not > have leading 0s > Documentation/devicetree/bindings/display/ti/ti,k2g-dss.example.dts:20.27-42.11: > Warning (unit_address_format): /example-0/dss@0254: unit name should not > have leading 0s > > Cc: Jyri Sarha > Cc: T

Re: [PATCH 17/22] drm/tilcdc: Use simple encoder

2020-03-06 Thread Jyri Sarha
On 05/03/2020 17:59, Thomas Zimmermann wrote: > The tilcdc driver uses empty implementations for its encoders. Replace > the code with the generic simple encoder. > > Signed-off-by: Thomas Zimmermann Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tilcdc/tilc

Re: [PATCH 16/22] drm/tidss: Use simple encoder

2020-03-06 Thread Jyri Sarha
On 05/03/2020 17:59, Thomas Zimmermann wrote: > The tidss driver uses an empty implementation for its encoder. Replace > the code with the generic simple encoder. > > Signed-off-by: Thomas Zimmermann Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_encoder.c | 10 ++

Re: [PATCH 17/21] drm/tilcdc: remove check for return value of debugfs functions.

2020-02-27 Thread Jyri Sarha
s not needed in > tilcdc_debugfs_init(). > > Also remove local variables that are not used after the changes, and > declare tilcdc_debugfs_init() as void. > > Signed-off-by: Wambui Karuga Ok, so this is a part of a bigger series. Acked-by: Jyri Sarha I assume the series will be merged

[PATCH v6] drm/tidss: dispc: Fix broken plane positioning code

2020-02-27 Thread Jyri Sarha
in tidss_atomic_check(). Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen --- One more round for this: - if(!opstate->crtc || opstate->crtc_x != npstate->crtc_x || + if (!opstate->crtc || opstate->crtc_x != npstate->crtc_x || The change is so

Re: [PATCH] drm/tilcdc: remove check for return value of debugfs functions.

2020-02-27 Thread Jyri Sarha
viewed-by: Jyri Sarha Tested-by: Jyri Sarha I'll merge this to drm-misc-next tomorrow. Thank you for the patch, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/til

[PATCH] drm/tidss: Add prepare_fb to the plane helper funcs

2020-02-27 Thread Jyri Sarha
From: Gowtham Tammana drm_gem_fb_prepare_fb() extracts fence and attaches to plane state. The fence info is needed if implicit fencing is used. Add this as prepare_fb function pointer to plane helper funcs. Signed-off-by: Gowtham Tammana Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tidss

Re: [PATCH -next] drm/tidss: Drop pointless static qualifier in dispc_find_csc()

2020-02-27 Thread Jyri Sarha
On 27/02/2020 08:50, YueHaibing wrote: > There is no need to have the 'const struct dispc_csc_coef *coef' > variable static since new value always be assigned before use it. > > Signed-off-by: YueHaibing Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha I'll merge this to drm-misc-n

Re: [PATCH] drm/tidss: Use drm_for_each_bridge_in_chain()

2020-02-27 Thread Jyri Sarha
On 22/02/2020 13:07, Laurent Pinchart wrote: > Replace the manual encoder->bridge_chain walk with the > drm_for_each_bridge_in_chain() macro. Drivers should not touch the > bridge_chain field directly. > > Signed-off-by: Laurent Pinchart Reviewed-by: Jyri Sarha Tested-by:

Re: [PATCH][next][V2] drm/tidss: fix spelling mistakes "bufer" and "requsted"

2020-02-27 Thread Jyri Sarha
On 24/02/2020 19:42, Colin King wrote: > From: Colin Ian King > > There are two spelling mistakes in warning and debug messages. > Fix them. > > Signed-off-by: Colin Ian King Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha I'll merge this to drm-misc-next tomorrow. Thank

[PATCH v5] drm/tidss: dispc: Fix broken plane positioning code

2020-02-24 Thread Jyri Sarha
in tidss_atomic_check(). Signed-off-by: Jyri Sarha --- The subject line has changed. The earlier versions of the patch can be found here: https://lists.freedesktop.org/archives/dri-devel/2020-February/254238.html https://lists.freedesktop.org/archives/dri-devel/2020-February/254744.html https

Re: [PATCH v4 3/3] drm: bridge: cdns-mhdp: add j721e wrapper

2020-02-24 Thread Jyri Sarha
p-j721e.c > b/drivers/gpu/drm/bridge/cdns-mhdp-j721e.c > new file mode 100644 > index ..a87faf55c065 > --- /dev/null > +++ b/drivers/gpu/drm/bridge/cdns-mhdp-j721e.c > @@ -0,0 +1,79 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * TI j721e Cadence MHD

Re: [PATCH v4] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-24 Thread Jyri Sarha
On 14/02/2020 13:20, Tomi Valkeinen wrote: > On 13/02/2020 21:37, Jyri Sarha wrote: >> The old implementation of placing planes on the CRTC while configuring >> the planes was naive and relied on the order in which the planes were >> configured, enabled, and disabled. The situ

Re: [PATCH 41/51] drm/tidss: Drop explicit drm_mode_config_cleanup call

2020-02-23 Thread Jyri Sarha
rsions for all the drm objects (planes, crtc, ...), so that > the cleanup actually happens before even drmm_kzalloc would release > the underlying memory. Not quite there yet. > > v2: Explain why this cleanup is possible (Laurent). > > Cc: Laurent Pinchart > Signed-off-by: D

Re: [PATCH 11/51] drm/tidss: Use drmm_add_final_kfree

2020-02-23 Thread Jyri Sarha
On 21/02/2020 23:02, Daniel Vetter wrote: > With this we can drop the final kfree from the release function. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_drv.c | 4 ++-- > 1 file cha

[PATCH resend 2/2] ARM: dts: keystone-k2g-evm: add HDMI video support

2020-02-14 Thread Jyri Sarha
Add DT nodes for HDMI video support for K2G EVM. The HDMI uses SiI9022 DPI as HDMI encoder. The DSS DPI is connected to SiI9022 HDMI encoder's video input and encoder's output goes to HDMI connector. Signed-off-by: Jyri Sarha --- arch/arm/boot/dts/keystone-k2g-evm.dts | 101

[PATCH resend 1/2] ARM: dts: keystone-k2g: Add DSS node

2020-02-14 Thread Jyri Sarha
Add DT node for DSS. K2G has DSS version 6. Keystone family DSS are somewhat different compered to the old OMAP family DSSes and the binding looks different too. Signed-off-by: Jyri Sarha Signed-off-by: Tomi Valkeinen Signed-off-by: Jyri Sarha --- arch/arm/boot/dts/keystone-k2g.dtsi | 22

[PATCH resend 0/2] dts: keystone-k2g-evm: Display support

2020-02-14 Thread Jyri Sarha
Resend because the earlier recipient list was wrong. Now that drm/tidss is queued for mainline, lets add display support for k2g-evm. There is no hurry since tidss is out only in v5.7, but it should not harm to have the dts changes in place before that. Jyri Sarha (2): ARM: dts: keystone-k2g

[PATCH v4] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
in tidss_atomic_check(). Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tidss/tidss_crtc.c | 55 + drivers/gpu/drm/tidss/tidss_crtc.h | 2 ++ drivers/gpu/drm/tidss/tidss_dispc.c | 55 +++-- drivers/gpu/drm/tidss/tidss_dispc.h | 5 +++ drivers

Re: [PATCH v3] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
On 13/02/2020 13:52, Jyri Sarha wrote: > On 13/02/2020 12:49, Tomi Valkeinen wrote: >> On 13/02/2020 12:44, Jyri Sarha wrote: >> >>> +    /* >>> + * If a plane on a CRTC changes add all active planes on that >>> + * CRTC to the

Re: [PATCH v3] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
On 13/02/2020 12:49, Tomi Valkeinen wrote: > On 13/02/2020 12:44, Jyri Sarha wrote: > >> +    /* >> + * If a plane on a CRTC changes add all active planes on that >> + * CRTC to the atomic state. This is needed for updating the >> + * plane positions

[PATCH v3] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
(). Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tidss/tidss_crtc.c | 52 +++ drivers/gpu/drm/tidss/tidss_dispc.c | 55 +++-- drivers/gpu/drm/tidss/tidss_dispc.h | 5 +++ drivers/gpu/drm/tidss/tidss_kms.c | 33 - 4 files changed, 109

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
On 13/02/2020 11:19, Daniel Vetter wrote: > On Thu, Feb 13, 2020 at 10:03 AM Jyri Sarha wrote: >> >> On 12/02/2020 22:28, Daniel Vetter wrote: >>> On Wed, Feb 12, 2020 at 7:01 PM Jyri Sarha wrote: >>>> >>>> On 12/02/2020 16:33, Ville Syrjälä wrote

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-13 Thread Jyri Sarha
On 12/02/2020 22:28, Daniel Vetter wrote: > On Wed, Feb 12, 2020 at 7:01 PM Jyri Sarha wrote: >> >> On 12/02/2020 16:33, Ville Syrjälä wrote: >>> On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: >>>> On 12/02/2020 15:59, Jyri Sarha wrote: >>&g

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
On 12/02/2020 16:33, Ville Syrjälä wrote: > On Wed, Feb 12, 2020 at 04:08:11PM +0200, Jyri Sarha wrote: >> On 12/02/2020 15:59, Jyri Sarha wrote: >>> The old implementation of placing planes on the CRTC while configuring >>> the planes was naive and relied on the ord

Re: [PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
On 12/02/2020 15:59, Jyri Sarha wrote: > The old implementation of placing planes on the CRTC while configuring > the planes was naive and relied on the order in which the planes were > configured, enabled, and disabled. The situation where a plane's zpos > was changed on the fly wa

[PATCH v2] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
(). Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tidss/tidss_crtc.c | 55 - drivers/gpu/drm/tidss/tidss_dispc.c | 55 +++-- drivers/gpu/drm/tidss/tidss_dispc.h | 5 +++ 3 files changed, 79 insertions(+), 36 deletions(-) diff --git a/drivers/gpu

Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-12 Thread Jyri Sarha
On 11/02/2020 17:41, Daniel Vetter wrote: > On Tue, Feb 11, 2020 at 04:40:21PM +0100, Daniel Vetter wrote: >> On Tue, Feb 11, 2020 at 03:00:30PM +0200, Ville Syrjälä wrote: >>> On Tue, Feb 11, 2020 at 11:11:34AM +0200, Tomi Valkeinen wrote: Hi Ville, On 10/02/2020 18:03, Ville

[PATCH v3 0/2] drm/panel: simple: Rocktech RK101II01D-CT + binding

2020-02-11 Thread Jyri Sarha
Add support for Rocktech RK101II01D-CT panel to panel-simple and add yaml binding for it. Changes since v2: - No separate binding document, just add new compatible to panel-simple.yaml Changes since first fersion: - Move to yaml binding Jyri Sarha (2): dt-bindings: panel-simple: Add rocktech

[PATCH v3 2/2] drm/panel: simple: Add Rocktech RK101II01D-CT panel

2020-02-11 Thread Jyri Sarha
Add support for Rocktech RK101II01D-CT, 10.1" 1280x800 TFT with LVDS interface, LED backlight and integrated Goodix GT928 capacitive touch panel. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/panel/panel-simple.c | 32 1 file change

[PATCH v3 1/2] dt-bindings: panel-simple: Add rocktech, rk101ii01d-ct compatible

2020-02-11 Thread Jyri Sarha
Add compatible to panel-simple for Rocktech Displays Limited RK101II01D-CT 10.1" TFT 1280x800 Pixels with LVDS interface, LED Backlight, and capacitive touch panel ("goodix,gt928" compatible). Signed-off-by: Jyri Sarha --- .../devicetree/bindings/display/panel/panel-simple.y

Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-10 Thread Jyri Sarha
On 10/02/2020 15:21, Ville Syrjälä wrote: > On Sun, Feb 09, 2020 at 02:50:09PM +0200, Jyri Sarha wrote: >> On 07/02/2020 20:45, Ville Syrjälä wrote: >>> On Fri, Feb 07, 2020 at 08:26:17PM +0200, Jyri Sarha wrote: >>>> On 07/02/2020 20:18, Jyri Sarha wrote: >>&

Re: [PATCH v4 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-02-09 Thread Jyri Sarha
ements supports > for single stream transport mode. > 3. 003-drm-bridge-cdns-mhdp-add-j721e-wrapper > Add Texas Instruments (TI) j721e wrapper for mhdp. The wrapper configures > mhdp clocks > and muxes as required by SoC. > For the whole series: Tested-by: Jyri Sarha Review

Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-09 Thread Jyri Sarha
On 07/02/2020 20:45, Ville Syrjälä wrote: > On Fri, Feb 07, 2020 at 08:26:17PM +0200, Jyri Sarha wrote: >> On 07/02/2020 20:18, Jyri Sarha wrote: >>> The old implementation of placing planes on the CRTC while configuring >>> the planes was naive and relied on the ord

Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-07 Thread Jyri Sarha
On 07/02/2020 20:18, Jyri Sarha wrote: > The old implementation of placing planes on the CRTC while configuring > the planes was naive and relied on the order in which the planes were > configured, enabled, and disabled. The situation where a plane's zpos > was changed on the fly wa

[PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-07 Thread Jyri Sarha
(or actually OVR) register space and it is more natural to configure them in a one go when configuring the CRTC. This is easy since we have access to the whole atomic state when updating the CRTC configuration. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/tidss/tidss_crtc.c | 2 +- drivers/gpu

Re: [PATCH v3 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-01-29 Thread Jyri Sarha
On 22/01/2020 12:55, Yuti Amonkar wrote: > This patch adds new DRM driver for Cadence MHDP DPTX IP used on J721e SoC. > MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and > embedded Display Port (eDP) standards.It integrates uCPU running the > embedded Firmware(FW)

[PATCH 2/2] ARM: dts: keystone-k2g-evm: add HDMI video support

2020-01-29 Thread Jyri Sarha
Add DT nodes for HDMI video support for K2G EVM. The HDMI uses SiI9022 DPI as HDMI encoder. The DSS DPI is connected to SiI9022 HDMI encoder's video input and encoder's output goes to HDMI connector. Signed-off-by: Jyri Sarha --- arch/arm/boot/dts/keystone-k2g-evm.dts | 101

[PATCH 1/2] ARM: dts: keystone-k2g: Add DSS node

2020-01-29 Thread Jyri Sarha
Add DT node for DSS. K2G has DSS version 6. Keystone family DSS are somewhat different compered to the old OMAP family DSSes and the binding looks different too. Signed-off-by: Jyri Sarha Signed-off-by: Tomi Valkeinen Signed-off-by: Jyri Sarha --- arch/arm/boot/dts/keystone-k2g.dtsi | 22

[PATCH 0/2] ARM: dts: keystone-k2g-evm: Display support

2020-01-29 Thread Jyri Sarha
Now that drm/tidss is queued for mainline, lets add display support for k2g-evm. There is no hurry since tidss is out only in v5.7, but it should not harm to have the dts changes in place before that. Jyri Sarha (2): ARM: dts: keystone-k2g: Add DSS node ARM: dts: keystone-k2g-evm: add HDMI

[PATCH v9 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-27 Thread Jyri Sarha
able() to dispc_set_irqenable() to avoid conflict exported omapfb function with same name - Add Signed-off-by: Tomi Valkeinen Co-developed-by: Tomi Valkeinen Signed-off-by: Jyri Sarha Acked-by: Sam Ravnborg Reviewed-by: Benoit Parrot Signed-off-by: Tomi Valkeinen --- Texas Instruments Finland

[PATCH v9 5/5] MAINTAINERS: add entry for tidss

2020-01-27 Thread Jyri Sarha
f-by: Tomi Valkeinen Signed-off-by: Jyri Sarha Reviewed-by: Benoit Parrot Signed-off-by: Tomi Valkeinen --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa9add598b7d..d8f65dc1dde8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH v9 0/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-27 Thread Jyri Sarha
ng from the beginning because it has been over a year since the previous patch set and the structure of the driver has evolved quite a bit. However, all the earlier comments should be addressed in this series. [1] https://patchwork.freedesktop.org/series/44947/ [2] https://lists.freedesktop.org/archives/dr

[PATCH v9 1/5] dt-bindings: display: ti, k2g-dss: Add dt-schema yaml binding

2020-01-27 Thread Jyri Sarha
value is the same as maxItems value - Remove ports node v5: - itemize reg and clocks properties' descriptions v6: - Add Reviewed-by: from Rob Herring and Benoit Parrot v7: no change v8: no change v9: - Remove ports-node from the dts example Signed-off-by: Jyri Sarha Reviewed-by: Rob

[PATCH v9 3/5] dt-bindings: display: ti, j721e-dss: Add dt-schema yaml binding

2020-01-27 Thread Jyri Sarha
t Parrot v7: no change v8: no change v9: no change Signed-off-by: Jyri Sarha Reviewed-by: Rob Herring Reviewed-by: Benoit Parrot --- .../bindings/display/ti/ti,j721e-dss.yaml | 208 ++ 1 file changed, 208 insertions(+) create mode 100644 Documentation/devicetree/bindin

[PATCH v9 2/5] dt-bindings: display: ti, am65x-dss: Add dt-schema yaml binding

2020-01-27 Thread Jyri Sarha
to reg and clocks properties - Remove minItems when its value is the same as maxItems value v5: - itemize reg and clocks properties' descriptions v6: - Add Reviewed-by: from Rob Herring and Benoit Parrot v7: no change v8: no change Signed-off-by: Jyri Sarha Reviewed-by: Rob Herring

[PATCH v8 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-20 Thread Jyri Sarha
ma property persistence and always write color properties in a new modeset v7: - Fix checkpatch.pl --strict issues - Rebase on top of drm-misc-next-2020-01-10 v8: - Remove idle debug prints from dispc_init() - Add Reviewed-by: Benoit Parrot Co-developed-by: Tomi Valkeinen Signed-of

  1   2   3   4   5   6   7   8   9   10   >