Re: [PATCH v2] drm: rcar-du: fix possible object reference leak

2019-04-09 Thread wen.yang99
> > The call to of_get_parent returns a node pointer with refcount > > incremented thus it must be explicitly decremented after the last > > usage. > > > > Detected by coccinelle with the following warnings: > > drivers/gpu/drm/rcar-du/rcar_du_of.c:235:2-8: ERROR: missing of_node_put; > >

Re: [PATCH v2] drm/meson: fix possible object reference leak

2019-04-09 Thread wen.yang99
> > v2->v1: convert a if statement into a ternary statement. > > Would you like to omit the arrow in such version information? Thank you for your comments The information about the previous versions goes below the ---, and only the reviewers can see it. It does not appear in the git log log.

Re: [PATCH 4/7] drm/omap: fix possible object reference leak

2019-04-08 Thread wen.yang99
> > The call to of_find_matching_node returns a node pointer with refcount > > incremented thus it must be explicitly decremented after the last > > usage. > > > > Detected by coccinelle with the following warnings: > > drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c:212:2-8: ERROR: missing > >

答复: Re: [PATCH 6/7] drm: rcar-du: fix possible object reference leak

2019-04-08 Thread wen.yang99
> > The call to of_get_parent returns a node pointer with refcount > > incremented thus it must be explicitly decremented after the last > > usage. > > > > Detected by coccinelle with the following warnings: > > drivers/gpu/drm/rcar-du/rcar_du_of.c:235:2-8: ERROR: missing of_node_put; > >