Re: [PATCH] dt-bindings: display: panel-timing: Define a single type for properties

[Sam Ravnborg]

Hi Rob,

On Wed, Apr 13, 2022 at 09:00:15AM -0500, Rob Herring wrote:
> It's not good practice to define multiple types for the same property, so
> factor out the type reference making the properties always an uint32-array
> with a length of 1 or 3 items.
> 
> Signed-off-by: Rob Herring 

Looks good,
Reviewed-by: Sam Ravnborg 

Let me know if we shall take it in drm-misc.

Sam

[PATCH] dt-bindings: display: panel-timing: Define a single type for properties

[Rob Herring]

It's not good practice to define multiple types for the same property, so
factor out the type reference making the properties always an uint32-array
with a length of 1 or 3 items.

Signed-off-by: Rob Herring 
---
 .../bindings/display/panel/panel-timing.yaml  | 42 ---
 1 file changed, 18 insertions(+), 24 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml 
b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
index 9bf592dc3033..7749de95ee40 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
@@ -71,78 +71,72 @@ properties:
 
   hfront-porch:
 description: Horizontal front porch panel timing
+$ref: /schemas/types.yaml#/definitions/uint32-array
 oneOf:
-  - $ref: /schemas/types.yaml#/definitions/uint32
-maxItems: 1
+  - maxItems: 1
 items:
   description: typical number of pixels
-  - $ref: /schemas/types.yaml#/definitions/uint32-array
-minItems: 3
+  - minItems: 3
 maxItems: 3
 items:
   description: min, typ, max number of pixels
 
   hback-porch:
 description: Horizontal back porch timing
+$ref: /schemas/types.yaml#/definitions/uint32-array
 oneOf:
-  - $ref: /schemas/types.yaml#/definitions/uint32
-maxItems: 1
+  - maxItems: 1
 items:
   description: typical number of pixels
-  - $ref: /schemas/types.yaml#/definitions/uint32-array
-minItems: 3
+  - minItems: 3
 maxItems: 3
 items:
   description: min, typ, max number of pixels
 
   hsync-len:
 description: Horizontal sync length panel timing
+$ref: /schemas/types.yaml#/definitions/uint32-array
 oneOf:
-  - $ref: /schemas/types.yaml#/definitions/uint32
-maxItems: 1
+  - maxItems: 1
 items:
   description: typical number of pixels
-  - $ref: /schemas/types.yaml#/definitions/uint32-array
-minItems: 3
+  - minItems: 3
 maxItems: 3
 items:
   description: min, typ, max number of pixels
 
   vfront-porch:
 description: Vertical front porch panel timing
+$ref: /schemas/types.yaml#/definitions/uint32-array
 oneOf:
-  - $ref: /schemas/types.yaml#/definitions/uint32
-maxItems: 1
+  - maxItems: 1
 items:
   description: typical number of lines
-  - $ref: /schemas/types.yaml#/definitions/uint32-array
-minItems: 3
+  - minItems: 3
 maxItems: 3
 items:
   description: min, typ, max number of lines
 
   vback-porch:
 description: Vertical back porch panel timing
+$ref: /schemas/types.yaml#/definitions/uint32-array
 oneOf:
-  - $ref: /schemas/types.yaml#/definitions/uint32
-maxItems: 1
+  - maxItems: 1
 items:
   description: typical number of lines
-  - $ref: /schemas/types.yaml#/definitions/uint32-array
-minItems: 3
+  - minItems: 3
 maxItems: 3
 items:
   description: min, typ, max number of lines
 
   vsync-len:
 description: Vertical sync length panel timing
+$ref: /schemas/types.yaml#/definitions/uint32-array
 oneOf:
-  - $ref: /schemas/types.yaml#/definitions/uint32
-maxItems: 1
+  - maxItems: 1
 items:
   description: typical number of lines
-  - $ref: /schemas/types.yaml#/definitions/uint32-array
-minItems: 3
+  - minItems: 3
 maxItems: 3
 items:
   description: min, typ, max number of lines
-- 
2.32.0