Re: [PATCH 0/4] treewide: Fix line continuation formats
On Thu, 2017-11-16 at 07:27 -0800, Joe Perches wrote: > Avoid using line continations in formats as that causes unexpected > output. Is having lines greater than 80 characters the preferred method? Could you add quotes before the backlash and before the first word on the next line instead? Mimi ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 0/4] treewide: Fix line continuation formats
On Thu, 2017-11-16 at 09:17 -0800, Joe Perches wrote: > On Thu, 2017-11-16 at 12:11 -0500, Mimi Zohar wrote: > > On Thu, 2017-11-16 at 07:27 -0800, Joe Perches wrote: > > > Avoid using line continations in formats as that causes unexpected > > > output. > > > > Is having lines greater than 80 characters the preferred method? > > yes. > > > Could you add quotes before the backlash and before the first word on > > the next line instead? > > coalesced formats are preferred. In the future, please reference the commit 6f76b6fcaa60 "CodingStyle: Document the exception of not splitting user-visible strings, for grepping" thanks, Mimi ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 0/4] treewide: Fix line continuation formats
On Thu, 2017-11-16 at 12:11 -0500, Mimi Zohar wrote: > On Thu, 2017-11-16 at 07:27 -0800, Joe Perches wrote: > > Avoid using line continations in formats as that causes unexpected > > output. > > Is having lines greater than 80 characters the preferred method? yes. > Could you add quotes before the backlash and before the first word on > the next line instead? coalesced formats are preferred. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 0/4] treewide: Fix line continuation formats
Avoid using line continations in formats as that causes unexpected output. Joe Perches (4): rk3399_dmc: Fix line continuation format drm: amd: Fix line continuation formats [media] dibx000_common: Fix line continuation format ima: Fix line continuation format drivers/devfreq/rk3399_dmc.c | 4 ++-- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 11 - .../amd/powerplay/hwmgr/process_pptables_v1_0.c| 6 ++--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 27 -- drivers/gpu/drm/amd/powerplay/smumgr/ci_smumgr.c | 6 ++--- .../gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c | 9 +++- .../gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 6 ++--- drivers/media/dvb-frontends/dibx000_common.c | 8 +++ security/integrity/ima/ima_template.c | 11 - 9 files changed, 33 insertions(+), 55 deletions(-) -- 2.15.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
