Re: [PATCH 06/11] dma: Drop JZ4740 driver

2019-07-30 Thread Paul Burton
Hello,

Paul Cercueil wrote:
> The newer and better JZ4780 driver is now used to provide DMA
> functionality on the JZ4740.
> 
> Signed-off-by: Paul Cercueil 
> Tested-by: Artur Rojek 
> Acked-by: Vinod Koul 

Applied to mips-next.

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.bur...@mips.com to report it. ]


Re: [PATCH 06/11] dma: Drop JZ4740 driver

2019-07-29 Thread Vinod Koul
On 25-07-19, 18:02, Paul Cercueil wrote:
> The newer and better JZ4780 driver is now used to provide DMA
> functionality on the JZ4740.

Please change subjetc to dmaengine: xxx

After that

Acked-by: Vinod Koul 

-- 
~Vinod
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 06/11] dma: Drop JZ4740 driver

2019-07-25 Thread Paul Cercueil
The newer and better JZ4780 driver is now used to provide DMA
functionality on the JZ4740.

Signed-off-by: Paul Cercueil 
Tested-by: Artur Rojek 
---
 drivers/dma/Kconfig  |   6 -
 drivers/dma/Makefile |   1 -
 drivers/dma/dma-jz4740.c | 623 ---
 3 files changed, 630 deletions(-)
 delete mode 100644 drivers/dma/dma-jz4740.c

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 03fa0c58cef3..7dd9831b4e6e 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -137,12 +137,6 @@ config DMA_BCM2835
select DMA_ENGINE
select DMA_VIRTUAL_CHANNELS
 
-config DMA_JZ4740
-   tristate "JZ4740 DMA support"
-   depends on MACH_JZ4740 || COMPILE_TEST
-   select DMA_ENGINE
-   select DMA_VIRTUAL_CHANNELS
-
 config DMA_JZ4780
tristate "JZ4780 DMA support"
depends on MIPS || COMPILE_TEST
diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
index 5bddf6f8790f..f5ce8665e944 100644
--- a/drivers/dma/Makefile
+++ b/drivers/dma/Makefile
@@ -22,7 +22,6 @@ obj-$(CONFIG_AXI_DMAC) += dma-axi-dmac.o
 obj-$(CONFIG_BCM_SBA_RAID) += bcm-sba-raid.o
 obj-$(CONFIG_COH901318) += coh901318.o coh901318_lli.o
 obj-$(CONFIG_DMA_BCM2835) += bcm2835-dma.o
-obj-$(CONFIG_DMA_JZ4740) += dma-jz4740.o
 obj-$(CONFIG_DMA_JZ4780) += dma-jz4780.o
 obj-$(CONFIG_DMA_SA11X0) += sa11x0-dma.o
 obj-$(CONFIG_DMA_SUN4I) += sun4i-dma.o
diff --git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c
deleted file mode 100644
index 39c676c47082..
--- a/drivers/dma/dma-jz4740.c
+++ /dev/null
@@ -1,623 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- *  Copyright (C) 2013, Lars-Peter Clausen 
- *  JZ4740 DMAC support
- */
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#include "virt-dma.h"
-
-#define JZ_DMA_NR_CHANS 6
-
-#define JZ_REG_DMA_SRC_ADDR(x) (0x00 + (x) * 0x20)
-#define JZ_REG_DMA_DST_ADDR(x) (0x04 + (x) * 0x20)
-#define JZ_REG_DMA_TRANSFER_COUNT(x)   (0x08 + (x) * 0x20)
-#define JZ_REG_DMA_REQ_TYPE(x) (0x0C + (x) * 0x20)
-#define JZ_REG_DMA_STATUS_CTRL(x)  (0x10 + (x) * 0x20)
-#define JZ_REG_DMA_CMD(x)  (0x14 + (x) * 0x20)
-#define JZ_REG_DMA_DESC_ADDR(x)(0x18 + (x) * 0x20)
-
-#define JZ_REG_DMA_CTRL0x300
-#define JZ_REG_DMA_IRQ 0x304
-#define JZ_REG_DMA_DOORBELL0x308
-#define JZ_REG_DMA_DOORBELL_SET0x30C
-
-#define JZ_DMA_STATUS_CTRL_NO_DESC BIT(31)
-#define JZ_DMA_STATUS_CTRL_DESC_INVBIT(6)
-#define JZ_DMA_STATUS_CTRL_ADDR_ERRBIT(4)
-#define JZ_DMA_STATUS_CTRL_TRANSFER_DONE   BIT(3)
-#define JZ_DMA_STATUS_CTRL_HALTBIT(2)
-#define JZ_DMA_STATUS_CTRL_COUNT_TERMINATE BIT(1)
-#define JZ_DMA_STATUS_CTRL_ENABLE  BIT(0)
-
-#define JZ_DMA_CMD_SRC_INC BIT(23)
-#define JZ_DMA_CMD_DST_INC BIT(22)
-#define JZ_DMA_CMD_RDIL_MASK   (0xf << 16)
-#define JZ_DMA_CMD_SRC_WIDTH_MASK  (0x3 << 14)
-#define JZ_DMA_CMD_DST_WIDTH_MASK  (0x3 << 12)
-#define JZ_DMA_CMD_INTERVAL_LENGTH_MASK(0x7 << 8)
-#define JZ_DMA_CMD_BLOCK_MODE  BIT(7)
-#define JZ_DMA_CMD_DESC_VALID  BIT(4)
-#define JZ_DMA_CMD_DESC_VALID_MODE BIT(3)
-#define JZ_DMA_CMD_VALID_IRQ_ENABLEBIT(2)
-#define JZ_DMA_CMD_TRANSFER_IRQ_ENABLE BIT(1)
-#define JZ_DMA_CMD_LINK_ENABLE BIT(0)
-
-#define JZ_DMA_CMD_FLAGS_OFFSET 22
-#define JZ_DMA_CMD_RDIL_OFFSET 16
-#define JZ_DMA_CMD_SRC_WIDTH_OFFSET 14
-#define JZ_DMA_CMD_DST_WIDTH_OFFSET 12
-#define JZ_DMA_CMD_TRANSFER_SIZE_OFFSET 8
-#define JZ_DMA_CMD_MODE_OFFSET 7
-
-#define JZ_DMA_CTRL_PRIORITY_MASK  (0x3 << 8)
-#define JZ_DMA_CTRL_HALT   BIT(3)
-#define JZ_DMA_CTRL_ADDRESS_ERROR  BIT(2)
-#define JZ_DMA_CTRL_ENABLE BIT(0)
-
-enum jz4740_dma_width {
-   JZ4740_DMA_WIDTH_32BIT  = 0,
-   JZ4740_DMA_WIDTH_8BIT   = 1,
-   JZ4740_DMA_WIDTH_16BIT  = 2,
-};
-
-enum jz4740_dma_transfer_size {
-   JZ4740_DMA_TRANSFER_SIZE_4BYTE  = 0,
-   JZ4740_DMA_TRANSFER_SIZE_1BYTE  = 1,
-   JZ4740_DMA_TRANSFER_SIZE_2BYTE  = 2,
-   JZ4740_DMA_TRANSFER_SIZE_16BYTE = 3,
-   JZ4740_DMA_TRANSFER_SIZE_32BYTE = 4,
-};
-
-enum jz4740_dma_flags {
-   JZ4740_DMA_SRC_AUTOINC = 0x2,
-   JZ4740_DMA_DST_AUTOINC = 0x1,
-};
-
-enum jz4740_dma_mode {
-   JZ4740_DMA_MODE_SINGLE  = 0,
-   JZ4740_DMA_MODE_BLOCK   = 1,
-};
-
-struct jz4740_dma_sg {
-   dma_addr_t addr;
-   unsigned int len;
-};
-
-struct jz4740_dma_desc {
-   struct virt_dma_desc vdesc;
-
-   enum dma_transfer_direction direction;
-   bool cyclic;
-
-   unsigned int num_sgs;
-   struct jz4740_dma_sg sg[];
-};
-
-struct