Hi Thomas,
Thank you for submitting your patch, it looks fine to me.
Reviewed-by: Robin van der Gracht
On Wed, 13 Mar 2024 16:45:00 +0100
Thomas Zimmermann wrote:
> Replace the use of struct backlight_properties.fb_blank with a
> call to backlight_get_brightness(). The helper implement the
On Thu, Mar 14, 2024 at 9:09 AM Thomas Zimmermann wrote:
>
> As Sam already said, it doesn't seem to make different in practice. I'd
> mention it in the commit message and that's it. Ok?
Yeah, that is what I meant -- thanks a lot!
Reviewed-by: Miguel Ojeda
Cheers,
Miguel
On Wed, Mar 13, 2024 at 6:54 PM Sam Ravnborg wrote:
>
> The driver does not set BL_CORE_SUSPENDRESUME so that part is a nop.
The driver may not set it now, but it is still not the same logic (and
unless I am missing something it would not generate the same code
either, so not sure I would say it
On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann wrote:
> Replace the use of struct backlight_properties.fb_blank with a
> call to backlight_get_brightness(). The helper implement the same
> logic as the driver's function.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Geert Uytterhoeven
Hi
Am 13.03.24 um 17:08 schrieb Miguel Ojeda:
Hi Thomas,
Thanks for this!
Cc'ing Andy and Geert -- the new maintainer and reviewer.
Ah, sorry. They are not yet in my MAINTAINERS file.
Also, a couple quick notes below since I am here...
On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann
On Wed, Mar 13, 2024 at 04:45:00PM +0100, Thomas Zimmermann wrote:
> Replace the use of struct backlight_properties.fb_blank with a
> call to backlight_get_brightness(). The helper implement the same
> logic as the driver's function.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Robin van der
Hi Miguel.
On Wed, Mar 13, 2024 at 05:08:08PM +0100, Miguel Ojeda wrote:
> Hi Thomas,
>
> Thanks for this!
>
> Cc'ing Andy and Geert -- the new maintainer and reviewer.
>
> Also, a couple quick notes below since I am here...
>
> On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann wrote:
> >
>
On Wed, Mar 13, 2024 at 6:11 PM Dan Carpenter wrote:
>
> Is there an advantage to making this const?
Not much in this case -- it is more about trying to be const-correct
where possible.
Cheers,
Miguel
On Wed, Mar 13, 2024 at 04:45:00PM +0100, Thomas Zimmermann wrote:
> Replace the use of struct backlight_properties.fb_blank with a
> call to backlight_get_brightness(). The helper implement the same
> logic as the driver's function.
If you end up resending there is a typo
On Wed, Mar 13, 2024 at 05:08:08PM +0100, Miguel Ojeda wrote:
> > - int brightness = bl->props.brightness;
> > + int brightness = backlight_get_brightness(bl);
>
> This can be `const` now (or even removed and have the call embedded below).
>
Is there an advantage to making this
Hi Thomas,
Thanks for this!
Cc'ing Andy and Geert -- the new maintainer and reviewer.
Also, a couple quick notes below since I am here...
On Wed, Mar 13, 2024 at 4:49 PM Thomas Zimmermann wrote:
>
> Replace the use of struct backlight_properties.fb_blank with a
> call to
Replace the use of struct backlight_properties.fb_blank with a
call to backlight_get_brightness(). The helper implement the same
logic as the driver's function.
Signed-off-by: Thomas Zimmermann
Cc: Robin van der Gracht
Cc: Miguel Ojeda
---
drivers/auxdisplay/ht16k33.c | 7 +--
1 file
12 matches
Mail list logo
