Re: [PATCH 3/6] drm: include idr.h from drm_file.h
Hi Jani, Thank you for the patch. On Thursday, 27 December 2018 14:56:38 EET Jani Nikula wrote: > Make it easier to drop drmP.h includes. How about explaining why idr.h is needed ? "drm_file.h embeds idr structures in DRM-specific structures. Include the corresponding header to make drm_file.h self-contained." Reviewed-by: Laurent Pinchart > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Laurent Pinchart > Signed-off-by: Jani Nikula > --- > include/drm/drm_file.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h > index 84ac79219e4c..6710b612e2f6 100644 > --- a/include/drm/drm_file.h > +++ b/include/drm/drm_file.h > @@ -32,6 +32,7 @@ > > #include > #include > +#include > > #include -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 3/6] drm: include idr.h from drm_file.h
On Thu, Dec 27, 2018 at 02:56:38PM +0200, Jani Nikula wrote: > Make it easier to drop drmP.h includes. > > Cc: Sam Ravnborg > Cc: Daniel Vetter > Cc: Laurent Pinchart > Signed-off-by: Jani Nikula > --- > include/drm/drm_file.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h > index 84ac79219e4c..6710b612e2f6 100644 > --- a/include/drm/drm_file.h > +++ b/include/drm/drm_file.h > @@ -32,6 +32,7 @@ > > #include > #include > +#include Yup, we embed the struct idr. Reviewed-by: Daniel Vetter > > #include > > -- > 2.11.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH 3/6] drm: include idr.h from drm_file.h
Make it easier to drop drmP.h includes. Cc: Sam Ravnborg Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Jani Nikula --- include/drm/drm_file.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index 84ac79219e4c..6710b612e2f6 100644 --- a/include/drm/drm_file.h +++ b/include/drm/drm_file.h @@ -32,6 +32,7 @@ #include #include +#include #include -- 2.11.0 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
