Re: [PATCH v2 18/28] drm/bridge: thc63: Use drm_bridge_init()

2019-12-05 Thread Laurent Pinchart
Hi Mihail,

Thank you for the patch.

On Wed, Dec 04, 2019 at 11:48:18AM +, Mihail Atanassov wrote:
> No functional change.
> 
> Signed-off-by: Mihail Atanassov 
> ---
>  drivers/gpu/drm/bridge/thc63lvd1024.c | 7 ++-
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c 
> b/drivers/gpu/drm/bridge/thc63lvd1024.c
> index 3d74129b2995..abe806db5f4d 100644
> --- a/drivers/gpu/drm/bridge/thc63lvd1024.c
> +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c
> @@ -218,11 +218,8 @@ static int thc63_probe(struct platform_device *pdev)
>   if (ret)
>   return ret;
>  
> - thc63->bridge.driver_private = thc63;
> - thc63->bridge.of_node = pdev->dev.of_node;
> - thc63->bridge.funcs = _bridge_func;
> - thc63->bridge.timings = >timings;
> -
> + drm_bridge_init(>bridge, >dev, _bridge_func,
> + >timings, thc63);

I think driver_private is unused, so the last argument can be NULL.

>   drm_bridge_add(>bridge);
>  
>   return 0;

-- 
Regards,

Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 18/28] drm/bridge: thc63: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change.

Signed-off-by: Mihail Atanassov 
---
 drivers/gpu/drm/bridge/thc63lvd1024.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c 
b/drivers/gpu/drm/bridge/thc63lvd1024.c
index 3d74129b2995..abe806db5f4d 100644
--- a/drivers/gpu/drm/bridge/thc63lvd1024.c
+++ b/drivers/gpu/drm/bridge/thc63lvd1024.c
@@ -218,11 +218,8 @@ static int thc63_probe(struct platform_device *pdev)
if (ret)
return ret;
 
-   thc63->bridge.driver_private = thc63;
-   thc63->bridge.of_node = pdev->dev.of_node;
-   thc63->bridge.funcs = _bridge_func;
-   thc63->bridge.timings = >timings;
-
+   drm_bridge_init(>bridge, >dev, _bridge_func,
+   >timings, thc63);
drm_bridge_add(>bridge);
 
return 0;
-- 
2.23.0

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel