Re: [PATCH v2 resend] drm/panel: Add driver for Seiko 43WVF1G panel
Hi Thierry, On Wed, Aug 30, 2017 at 11:12 AM, Thierry Redingwrote: > On Tue, Aug 29, 2017 at 02:29:08PM -0300, Fabio Estevam wrote: >> Hi Thierry, >> >> On Fri, Aug 18, 2017 at 12:08 PM, Thierry Reding >> wrote: >> >> > I've applied, though somewhat reluctantly, this to drm-misc-next without >> > Rob's Acked-by, but the device tree bindings look trivial enough. >> >> Was it really applied? I am not able to find this patch in linux-next. > > Yeah, this is still in drm-misc-next, but due to bad timing on my part > it missed the window for 4.14 by just a couple of minutes. > > Apologies for that. It should show up in linux-next shortly after > 4.14-rc1. Still does not show up in linux-next. Could you please double check it? ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 resend] drm/panel: Add driver for Seiko 43WVF1G panel
On Tue, Aug 29, 2017 at 02:29:08PM -0300, Fabio Estevam wrote: > Hi Thierry, > > On Fri, Aug 18, 2017 at 12:08 PM, Thierry Reding >wrote: > > > I've applied, though somewhat reluctantly, this to drm-misc-next without > > Rob's Acked-by, but the device tree bindings look trivial enough. > > Was it really applied? I am not able to find this patch in linux-next. Yeah, this is still in drm-misc-next, but due to bad timing on my part it missed the window for 4.14 by just a couple of minutes. Apologies for that. It should show up in linux-next shortly after 4.14-rc1. Thierry signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 resend] drm/panel: Add driver for Seiko 43WVF1G panel
Hi Thierry, On Fri, Aug 18, 2017 at 12:08 PM, Thierry Redingwrote: > I've applied, though somewhat reluctantly, this to drm-misc-next without > Rob's Acked-by, but the device tree bindings look trivial enough. Was it really applied? I am not able to find this patch in linux-next. Thanks ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 resend] drm/panel: Add driver for Seiko 43WVF1G panel
On Thu, Jul 27, 2017 at 11:26 AM, Marco Frankwrote: > Thierry, > > 2017-07-20 13:12 GMT-03:00 Marco Franchi : >> >> Add driver for Seiko Instruments Inc. 4.3" WVGA (800 x RGB x 480) >> TFT with Touch-Panel. >> >> Datasheet available at: >> http://www.glyn.de/data/glyn/media/doc/43wvf1g-0.pdf >> >> Seiko 43WVF1G panel has two power supplies: avdd and dvdd and they >> require a specific power on/down sequence. >> For this reason the simple panel driver cannot be used to drive this >> panel, so create a new one heavily based on simple panel. >> >> Based on initial patch submission from Breno Lima. >> >> Signed-off-by: Marco Franchi >> --- >> Changes since v1: >> -Change supply names to dvdd-supply and avdd-supply > > > I tried pingin Rob with no sucess so far. Given that this is a very simples > LCD driver, could you please apply it directly? > Thanks If you don't send to the right lists (i.e. the DT list), then it doesn't get into my queue (patchwork) and likely I won't see it. Rob ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 resend] drm/panel: Add driver for Seiko 43WVF1G panel
On Thu, Jul 20, 2017 at 01:12:59PM -0300, Marco Franchi wrote: > Add driver for Seiko Instruments Inc. 4.3" WVGA (800 x RGB x 480) > TFT with Touch-Panel. > > Datasheet available at: > http://www.glyn.de/data/glyn/media/doc/43wvf1g-0.pdf > > Seiko 43WVF1G panel has two power supplies: avdd and dvdd and they > require a specific power on/down sequence. > For this reason the simple panel driver cannot be used to drive this > panel, so create a new one heavily based on simple panel. > > Based on initial patch submission from Breno Lima. > > Signed-off-by: Marco Franchi> --- > Changes since v1: > -Change supply names to dvdd-supply and avdd-supply > .../bindings/display/panel/seiko,43wvf1g.txt | 23 ++ > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-seiko-43wvf1g.c| 372 > + > 4 files changed, 405 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/seiko,43wvf1g.txt > create mode 100644 drivers/gpu/drm/panel/panel-seiko-43wvf1g.c I've applied, though somewhat reluctantly, this to drm-misc-next without Rob's Acked-by, but the device tree bindings look trivial enough. Thanks, Thierry signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 resend] drm/panel: Add driver for Seiko 43WVF1G panel
Thierry, 2017-07-20 13:12 GMT-03:00 Marco Franchi: > Add driver for Seiko Instruments Inc. 4.3" WVGA (800 x RGB x 480) > TFT with Touch-Panel. > > Datasheet available at: > http://www.glyn.de/data/glyn/media/doc/43wvf1g-0.pdf > > Seiko 43WVF1G panel has two power supplies: avdd and dvdd and they > require a specific power on/down sequence. > For this reason the simple panel driver cannot be used to drive this > panel, so create a new one heavily based on simple panel. > > Based on initial patch submission from Breno Lima. > > Signed-off-by: Marco Franchi > --- > Changes since v1: > -Change supply names to dvdd-supply and avdd-supply > I tried pingin Rob with no sucess so far. Given that this is a very simples LCD driver, could you please apply it directly? Thanks ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v2 resend] drm/panel: Add driver for Seiko 43WVF1G panel
Add driver for Seiko Instruments Inc. 4.3" WVGA (800 x RGB x 480) TFT with Touch-Panel. Datasheet available at: http://www.glyn.de/data/glyn/media/doc/43wvf1g-0.pdf Seiko 43WVF1G panel has two power supplies: avdd and dvdd and they require a specific power on/down sequence. For this reason the simple panel driver cannot be used to drive this panel, so create a new one heavily based on simple panel. Based on initial patch submission from Breno Lima. Signed-off-by: Marco Franchi--- Changes since v1: -Change supply names to dvdd-supply and avdd-supply .../bindings/display/panel/seiko,43wvf1g.txt | 23 ++ drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-seiko-43wvf1g.c| 372 + 4 files changed, 405 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/seiko,43wvf1g.txt create mode 100644 drivers/gpu/drm/panel/panel-seiko-43wvf1g.c diff --git a/Documentation/devicetree/bindings/display/panel/seiko,43wvf1g.txt b/Documentation/devicetree/bindings/display/panel/seiko,43wvf1g.txt new file mode 100644 index 000..aae57ef --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/seiko,43wvf1g.txt @@ -0,0 +1,23 @@ +Seiko Instruments Inc. 4.3" WVGA (800 x RGB x 480) TFT with Touch-Panel + +Required properties: +- compatible: should be "sii,43wvf1g". +- "dvdd-supply": 3v3 digital regulator. +- "avdd-supply": 5v analog regulator. + +Optional properties: +- backlight: phandle for the backlight control. + +Example: + + panel { + compatible = "sii,43wvf1g"; + backlight = <_display>; + dvdd-supply = <_lcd_3v3>; + avdd-supply = <_lcd_5v>; + port { + panel_in: endpoint { + remote-endpoint = <_out>; + }; + }; + }; diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index d84a031..09b0717 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -86,6 +86,15 @@ config DRM_PANEL_SAMSUNG_S6E8AA0 select DRM_MIPI_DSI select VIDEOMODE_HELPERS +config DRM_PANEL_SEIKO_43WVF1G + tristate "Seiko 43WVF1G panel" + depends on OF + depends on BACKLIGHT_CLASS_DEVICE + select VIDEOMODE_HELPERS + help + Say Y here if you want to enable support for the Seiko + 43WVF1G controller for 800x480 LCD panels + config DRM_PANEL_SHARP_LQ101R1SX01 tristate "Sharp LQ101R1SX01 panel" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 9f6610d..183c6bf 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -7,6 +7,7 @@ obj-$(CONFIG_DRM_PANEL_PANASONIC_VVX10F034N00) += panel-panasonic-vvx10f034n00.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_LD9040) += panel-samsung-ld9040.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E3HA2) += panel-samsung-s6e3ha2.o obj-$(CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0) += panel-samsung-s6e8aa0.o +obj-$(CONFIG_DRM_PANEL_SEIKO_43WVF1G) += panel-seiko-43wvf1g.o obj-$(CONFIG_DRM_PANEL_SHARP_LQ101R1SX01) += panel-sharp-lq101r1sx01.o obj-$(CONFIG_DRM_PANEL_SHARP_LS043T1LE01) += panel-sharp-ls043t1le01.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c new file mode 100644 index 000..71c09ed --- /dev/null +++ b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c @@ -0,0 +1,372 @@ +/* + * Copyright (C) 2017 NXP Semiconductors. + * Author: Marco Franchi + * + * Based on Panel Simple driver by Thierry Reding + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License version + * 2 as published by the Free Software Foundation. + */ + +#include +#include +#include +#include + +#include +#include +#include + +#include +#include + +struct seiko_panel_desc { + const struct drm_display_mode *modes; + unsigned int num_modes; + const struct display_timing *timings; + unsigned int num_timings; + + unsigned int bpc; + + /** +* @width: width (in millimeters) of the panel's active display area +* @height: height (in millimeters) of the panel's active display area +*/ + struct { + unsigned int width; + unsigned int height; + } size; + + u32 bus_format; + u32 bus_flags; +}; + +struct seiko_panel { + struct drm_panel base; + bool prepared; + bool enabled; + const struct seiko_panel_desc *desc; + struct backlight_device *backlight; + struct regulator *dvdd; + struct regulator *avdd; +}; + +static inline struct